[clang-tools-extra] b0210fe - [Clang] [NFC] Fix more `-Wreturn-type` warnings in tests everywhere (#123470)

2025-02-20 Thread via cfe-commits
Author: Sirraide Date: 2025-02-20T19:49:37+01:00 New Revision: b0210fee94bc29a507f900da1fb97f0e50ab2637 URL: https://github.com/llvm/llvm-project/commit/b0210fee94bc29a507f900da1fb97f0e50ab2637 DIFF: https://github.com/llvm/llvm-project/commit/b0210fee94bc29a507f900da1fb97f0e50ab2637.diff LOG:

[clang] [HLSL] Implement default constant buffer `$Globals` (PR #125807)

2025-02-20 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/125807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][hlsl][Sema] Simplify CBuffer Legacy Size Calculation Control Flow (PR #127921)

2025-02-20 Thread Sarah Spall via cfe-commits
https://github.com/spall approved this pull request. https://github.com/llvm/llvm-project/pull/127921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement default constant buffer `$Globals` (PR #125807)

2025-02-20 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/125807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-20 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,79 @@ +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -fclangir -emit-core-mlir %s -o %t.mlir +// RUN: FileCheck --input-file=%t.mlir %s + +char c; +// CHECK: memref.global "public" @c : memref + +signed char sc; +// CHECK: memref.global "public" @sc :

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++][ranges] P2542R8: Implement `views::concat` (PR #120920)

2025-02-20 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,646 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

2025-02-20 Thread Matheus Izvekov via cfe-commits
@@ -5294,10 +5294,14 @@ def err_template_missing_args : Error< "%select{class template|function template|variable template|alias template|" "template template parameter|concept|template}0 %1 requires template " "arguments">; -def err_template_arg_list_different_arity : Er

[clang] [clang-tools-extra] [compiler-rt] [Clang] [NFC] Fix more `-Wreturn-type` warnings in tests everywhere (PR #123470)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang-tools-extra,clang,compiler-rt` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbo

[clang] [clang-tools-extra] [compiler-rt] [Clang] [NFC] Fix more `-Wreturn-type` warnings in tests everywhere (PR #123470)

2025-02-20 Thread via cfe-commits
Sirraide wrote: That seems related; I’ll investigate this in a bit. https://github.com/llvm/llvm-project/pull/123470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [Clang] [NFC] Fix more `-Wreturn-type` warnings in tests everywhere (PR #123470)

2025-02-20 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/123470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 29361b3 - [Clang] Fix failing clang-tidy test (#128051)

2025-02-20 Thread via cfe-commits
Author: Sirraide Date: 2025-02-20T20:06:56+01:00 New Revision: 29361b326bd865f7c4f07d9fc5a908d3f2b177fc URL: https://github.com/llvm/llvm-project/commit/29361b326bd865f7c4f07d9fc5a908d3f2b177fc DIFF: https://github.com/llvm/llvm-project/commit/29361b326bd865f7c4f07d9fc5a908d3f2b177fc.diff LOG:

[clang-tools-extra] [Clang] Fix failing clang-tidy test (PR #128051)

2025-02-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: None (Sirraide) Changes #123470 broke one of the clang-tidy tests; this fixes that. --- Full diff: https://github.com/llvm/llvm-project/pull/128051.diff 1 Files Affected: - (modified) clang-tools-extra/test/clang-tidy/checkers/rea

[clang-tools-extra] [Clang] Fix failing clang-tidy test (PR #128051)

2025-02-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (Sirraide) Changes #123470 broke one of the clang-tidy tests; this fixes that. --- Full diff: https://github.com/llvm/llvm-project/pull/128051.diff 1 Files Affected: - (modified) clang-tools-extra/test/clang-tidy/check

[clang] [profile] runtime counter relocation is needed on windows-msvc targets (PR #127858)

2025-02-20 Thread via cfe-commits
Andarwinux wrote: > > Doesn't mingw target support it? > > Sorry I don't know. I was hoping someone familiar with clang on windows to > comment. @mstorsjo might review this? https://github.com/llvm/llvm-project/pull/127858 ___ cfe-commits mailing li

[clang] [HLSL] Implement default constant buffer `$Globals` (PR #125807)

2025-02-20 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/125807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Integrated Distributed ThinLTO (DTLTO): Initial support (PR #126654)

2025-02-20 Thread via cfe-commits
bd1976bris wrote: > > Some high level comments: > > > > * Should we just call it distributedLTO, or DLTO? Feel like we can drop the > > thin part for less typing, and from the user's point of view, using thinLTO > > infrastructure is just implementation details. Apologies for the slow reply.

[clang] [clang-tools-extra] [compiler-rt] [Clang] [NFC] Fix more `-Wreturn-type` warnings in tests everywhere (PR #123470)

2025-02-20 Thread via cfe-commits
Sirraide wrote: Should be fixed by #128051. https://github.com/llvm/llvm-project/pull/123470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [test] Remove `-emit-llvm` from the `and-errors.hlsl` test to avoid writing to a potentially write-protected directory (PR #128047)

2025-02-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Deric Cheung (Icohedron) Changes @mikaelholmen [mentioned](https://github.com/llvm/llvm-project/pull/127098#discussion_r1962897888) that the `-emit-llvm` argument isn't necessary for the `and-errors.hlsl` test and may cause issues due to

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-20 Thread Andy Kaylor via cfe-commits
@@ -55,6 +55,7 @@ class CIRGenerator : public clang::ASTConsumer { void Initialize(clang::ASTContext &astContext) override; bool HandleTopLevelDecl(clang::DeclGroupRef group) override; mlir::ModuleOp getModule() const; + mlir::MLIRContext &getMLIRContext() { return *mlir

[clang] [clang] C++20 Modules: document how to perform automated reductions (PR #124997)

2025-02-20 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese edited https://github.com/llvm/llvm-project/pull/124997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] C++20 Modules: document how to perform automated reductions (PR #124997)

2025-02-20 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. While I agree it would be good to full documentation on how to reduce test cases, I think this subset is very useful for modules issues. I think this is fine with or without the changes I suggested. https://github.com/llvm/llvm-project/p

[clang] [clang] C++20 Modules: document how to perform automated reductions (PR #124997)

2025-02-20 Thread Michael Spencer via cfe-commits
@@ -2072,3 +2072,25 @@ Interoperability with Clang Modules We **wish** to support Clang modules and standard C++ modules at the same time, but the mixing them together is not well used/tested yet. Please file new GitHub issues as you find interoperability problems. + +Finding r

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcilia (Large Immediate Arithmetic) extension (PR #124706)

2025-02-20 Thread Sam Elliott via cfe-commits
@@ -0,0 +1,117 @@ +# Xqcilia - Qualcomm uC Large Immediate Arithmetic extension +# RUN: not llvm-mc -triple riscv32 -mattr=+experimental-xqcilia < %s 2>&1 \ +# RUN: | FileCheck -check-prefixes=CHECK,CHECK-PLUS,CHECK-IMM %s +# RUN: not llvm-mc -triple riscv32 -mattr=-experiment

[clang] [clang] C++20 Modules: document how to perform automated reductions (PR #124997)

2025-02-20 Thread Michael Spencer via cfe-commits
@@ -2072,3 +2072,25 @@ Interoperability with Clang Modules We **wish** to support Clang modules and standard C++ modules at the same time, but the mixing them together is not well used/tested yet. Please file new GitHub issues as you find interoperability problems. + +Finding r

[clang-tools-extra] [Clang] Fix failing clang-tidy test (PR #128051)

2025-02-20 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/128051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement default constant buffer `$Globals` (PR #125807)

2025-02-20 Thread Sarah Spall via cfe-commits
https://github.com/spall approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/125807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Analyzer][CFG] Correctly handle rebuilt default arg and default init expression" (PR #127338)

2025-02-20 Thread Nico Weber via cfe-commits
nico wrote: Thanks for the warning! It's a cool feature, but the diagnostic is IMHO not super great at the moment. I'm doing the cleanup for the warning in Chromium at the moment, and here's an example that's now analyzed (from

[clang] [Clang] add -Wshift-bool warning to handle shifting of bool (PR #127336)

2025-02-20 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/127336 >From 272385df25b791b50472b92e12157477d021a26f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 15 Feb 2025 18:19:44 +0200 Subject: [PATCH 1/5] [Clang] add -Wshift-bool warning to handle shifting of boo

[clang] [clang] Alias cc modifier to c (PR #127719)

2025-02-20 Thread via cfe-commits
https://github.com/PiJoules updated https://github.com/llvm/llvm-project/pull/127719 >From 886754d42cf8619771b0877bc7edde940642c799 Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Tue, 18 Feb 2025 15:33:05 -0800 Subject: [PATCH] [clang] Alias cc modifier to c https://gcc.gnu.org/onlinedocs/g

[clang] [clang] Alias cc modifier to c (PR #127719)

2025-02-20 Thread via cfe-commits
PiJoules wrote: > Thanks for the fix! The changes should come with a release note in > `clang/docs/ReleaseNotes.rst` > > I'm not super familiar with GCC Asm Statements, but the changes look correct > to me otherwise. one https://github.com/llvm/llvm-project/pull/127719 __

[clang] [CodeGen] Ensure relative vtables use llvm.type.checked.load.relative (PR #126785)

2025-02-20 Thread via cfe-commits
https://github.com/PiJoules updated https://github.com/llvm/llvm-project/pull/126785 >From 3f31a63ea4b2371d697587454b7f1bb14624132a Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Tue, 11 Feb 2025 11:31:17 -0800 Subject: [PATCH] [CodeGen] Ensure relative vtables use llvm.type.checked.load.re

[clang] [CodeGen] Ensure relative vtables use llvm.type.checked.load.relative (PR #126785)

2025-02-20 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7f275e09a788412414e23e32dd3767ec92595cad 3f31a63ea4b2371d697587454b7f1bb14624132a --e

[clang] [HLSL] Allow arrays to be returned by value in HLSL (PR #127896)

2025-02-20 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt approved this pull request. https://github.com/llvm/llvm-project/pull/127896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Allow arrays to be returned by value in HLSL (PR #127896)

2025-02-20 Thread Ashley Coleman via cfe-commits
@@ -20681,7 +20681,8 @@ ExprResult RebuildUnknownAnyExpr::VisitCallExpr(CallExpr *E) { const FunctionType *FnType = CalleeType->castAs(); // Verify that this is a legal result type of a function. - if (DestType->isArrayType() || DestType->isFunctionType()) { + if ((Dest

[clang] [CodeGen] Ensure relative vtables use llvm.type.checked.load.relative (PR #126785)

2025-02-20 Thread via cfe-commits
https://github.com/PiJoules updated https://github.com/llvm/llvm-project/pull/126785 >From 864b0a07d4c862cacb4ae88912a8a100795009c4 Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Tue, 11 Feb 2025 11:31:17 -0800 Subject: [PATCH] [CodeGen] Ensure relative vtables use llvm.type.checked.load.re

[clang-tools-extra] [Clang] Fix failing clang-tidy test (PR #128051)

2025-02-20 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/128051 #123470 broke one of the clang-tidy tests; this fixes that. >From cc42e9e46635a33e8546852fd8146f7e397445d8 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Thu, 20 Feb 2025 20:06:04 +0100 Subject: [PATCH] [Clang]

[clang] [CodeGen] Ensure relative vtables use llvm.type.checked.load.relative (PR #126785)

2025-02-20 Thread via cfe-commits
@@ -2937,9 +2937,13 @@ llvm::Value *CodeGenFunction::EmitVTableTypeCheckedLoad( CGM.CreateMetadataIdentifierForType(QualType(RD->getTypeForDecl(), 0)); llvm::Value *TypeId = llvm::MetadataAsValue::get(CGM.getLLVMContext(), MD); + auto checked_load = CGM.getVTables().u

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

2025-02-20 Thread Jan Svoboda via cfe-commits
@@ -0,0 +1,164 @@ +//===- ModuleMapFile.h - Parsing and representation -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

2025-02-20 Thread Jan Svoboda via cfe-commits
@@ -0,0 +1,164 @@ +//===- ModuleMapFile.h - Parsing and representation -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [NFC][hlsl][Sema] Simplify CBuffer Legacy Size Calculation Control Flow (PR #127921)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `clang` at step 16 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/5171 Here is the relevant piece

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

2025-02-20 Thread Jan Svoboda via cfe-commits
@@ -0,0 +1,164 @@ +//===- ModuleMapFile.h - Parsing and representation -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISCV] Assembler support for XRivosVizip (PR #127694)

2025-02-20 Thread Philip Reames via cfe-commits
@@ -0,0 +1,27 @@ +//===-- RISCVInstrInfoXRivos.td --*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[clang] [llvm] [RISCV] Assembler support for XRivosVizip (PR #127694)

2025-02-20 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/127694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cc45365 - [clang][NFC] Update isAuxBuiltinID comment (#128038)

2025-02-20 Thread via cfe-commits
Author: Nick Sarnie Date: 2025-02-20T20:30:54Z New Revision: cc45365ab9065bc9e8ea48744f761b7ac30a5634 URL: https://github.com/llvm/llvm-project/commit/cc45365ab9065bc9e8ea48744f761b7ac30a5634 DIFF: https://github.com/llvm/llvm-project/commit/cc45365ab9065bc9e8ea48744f761b7ac30a5634.diff LOG: [

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Assembler support for XRivosVizip (PR #127694)

2025-02-20 Thread Philip Reames via cfe-commits
https://github.com/preames updated https://github.com/llvm/llvm-project/pull/127694 >From 81e50773d34f788df750bf6d4a4cd8c727a6b148 Mon Sep 17 00:00:00 2001 From: Philip Reames Date: Wed, 22 Jan 2025 12:54:24 -0800 Subject: [PATCH 1/2] [RISCV] Assembler support for XRivosVizip This implements a

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [profile] runtime counter relocation is needed on windows-msvc targets (PR #127858)

2025-02-20 Thread Anh Tuyen Tran via cfe-commits
https://github.com/anhtuyenibm approved this pull request. Thanks for pointing out this reference page. The changes look good to me. https://github.com/llvm/llvm-project/pull/127858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [llvm] [RISCV] Assembler support for XRivosVizip (PR #127694)

2025-02-20 Thread Philip Reames via cfe-commits
preames wrote: > > > I am kind of confused now. So the situation here is that RVIOS has > > > already implemented these vendor extensions in cores and RVIOS is also > > > trying to make these extensions official RVI standards, right? > > > > > > You're confusing two things. We (Rivos) have de

[clang] [lld] [llvm] Integrated Distributed ThinLTO (DTLTO): Initial support (PR #126654)

2025-02-20 Thread Steven Wu via cfe-commits
cachemeifyoucan wrote: > This is clearer as we are currently only going to distribute the ThinLTO part > and have no plans to distribute the FullLTO part. Making the name more > general could confuse users who might then expect in e.g., a mixed Thin+Full > link that the Full bitcode part would

[clang] [clang][NFC] Update isAuxBuiltinID comment (PR #128038)

2025-02-20 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/128038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Check for mutability better (PR #127843)

2025-02-20 Thread Hans Wennborg via cfe-commits
https://github.com/zmodem edited https://github.com/llvm/llvm-project/pull/127843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Check for mutability better (PR #127843)

2025-02-20 Thread Hans Wennborg via cfe-commits
@@ -13440,6 +13440,23 @@ bool Sema::GloballyUniqueObjectMightBeAccidentallyDuplicated( return true; } +// Determine whether the object seems mutable for the purpose of diagnosing +// possible unique object duplication, i.e. non-const-qualified, and +// not an always-constan

[clang] Check for mutability better (PR #127843)

2025-02-20 Thread Hans Wennborg via cfe-commits
https://github.com/zmodem approved this pull request. LGTM with a nit. I'll wait a day before merging in case anyone else wants to review as well. https://github.com/llvm/llvm-project/pull/127843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

2025-02-20 Thread Jan Svoboda via cfe-commits
@@ -3157,25 +2140,18 @@ bool ModuleMap::parseModuleMapFile(FileEntryRef File, bool IsSystem, assert((!Offset || *Offset <= Buffer->getBufferSize()) && "invalid buffer offset"); - // Parse this module map file. - Lexer L(SourceMgr.getLocForStartOfFile(ID), MMapLan

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-20 Thread Bruno Cardoso Lopes via cfe-commits
@@ -2958,6 +2958,8 @@ defm clangir : BoolFOption<"clangir", BothFlags<[], [ClangOption, CC1Option], "">>; def emit_cir : Flag<["-"], "emit-cir">, Visibility<[ClangOption, CC1Option]>, Group, HelpText<"Build ASTs and then lower to ClangIR">; +def emit_cir_mlir : Flag<["-"],

[clang] [clang][dataflow] Add test repro for a crash (PR #128065)

2025-02-20 Thread Jan Voung via cfe-commits
https://github.com/jvoung created https://github.com/llvm/llvm-project/pull/128065 An issue with looking up the "this" when a default init of field2 refers to field1. >From a7002fb5a61c2f6f3c4df2347b6d5f861bf45f8e Mon Sep 17 00:00:00 2001 From: Jan Voung Date: Thu, 20 Feb 2025 19:40:16 +

[clang] [clang][dataflow] Add test repro for a crash (PR #128065)

2025-02-20 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6e7da07c73c179396e21fb729ac14d6b2a1c3152 a7002fb5a61c2f6f3c4df2347b6d5f861bf45f8e --e

[clang] [MS][clang] Add support for vector deleting destructors (PR #126240)

2025-02-20 Thread Reid Kleckner via cfe-commits
rnk wrote: Thanks for the updates, I think this is almost done. @zmodem , this will probably have some impact on Chrome code size and will probably churn many crash stack traces. I think it's safe to rely on all the existing automated testing, but this is a high-risk change to keep in mind if

[clang] [WIP][clang]: Implement a conditional lifetimebound_if builtin. (PR #125520)

2025-02-20 Thread Haojian Wu via cfe-commits
hokein wrote: > auto& value = m[std::string_view(std::string())]; // Doesn't get caught This case is supported as well, https://godbolt.org/z/KKsvd8Kx1. https://github.com/llvm/llvm-project/pull/125520 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [WIP][clang]: Implement a conditional lifetimebound_if builtin. (PR #125520)

2025-02-20 Thread Haojian Wu via cfe-commits
hokein wrote: > It would be nice if you could share some code snippets how exactly this would > be used in practice. Some simple examples from Abseil. When using `lifetime_capture` in the `insert` method, we currently have two overloads: - [one overload](https://github.com/abseil/abseil-cpp

[clang] [llvm] [CaptureTracking][FunctionAttrs] Add support for CaptureInfo (PR #125880)

2025-02-20 Thread Hans Wennborg via cfe-commits
zmodem wrote: > @zmodem Could you please check whether the clang build on windows works with > the patch at #128020? I'm afraid I get the same crashes with that one. https://github.com/llvm/llvm-project/pull/125880 ___ cfe-commits mailing list cfe-co

[clang] [test] Remove `-emit-llvm` from the `and-errors.hlsl` test to avoid writing to a potentially write-protected directory (PR #128047)

2025-02-20 Thread Sarah Spall via cfe-commits
https://github.com/spall approved this pull request. https://github.com/llvm/llvm-project/pull/128047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [profile] runtime counter relocation is needed on windows-msvc targets (PR #127858)

2025-02-20 Thread Wael Yehia via cfe-commits
https://github.com/w2yehia edited https://github.com/llvm/llvm-project/pull/127858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-20 Thread Andy Kaylor via cfe-commits
@@ -2958,6 +2958,8 @@ defm clangir : BoolFOption<"clangir", BothFlags<[], [ClangOption, CC1Option], "">>; def emit_cir : Flag<["-"], "emit-cir">, Visibility<[ClangOption, CC1Option]>, Group, HelpText<"Build ASTs and then lower to ClangIR">; +def emit_cir_mlir : Flag<["-"],

[clang] [WIP][clang]: Implement a conditional lifetimebound_if builtin. (PR #125520)

2025-02-20 Thread Haojian Wu via cfe-commits
hokein wrote: It feels like the current direction & discussion is expanding into a broader problem space beyond the specific issue this PR aims to address. We have two major problems which seem to be orthogonal: 1. **avoiding code duplication** – specifically, reducing the number of function

[clang] [test] Remove `-emit-llvm` from the `and-errors.hlsl` test to avoid writing to a potentially write-protected directory (PR #128047)

2025-02-20 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/128047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Ensure relative vtables use llvm.type.checked.load.relative (PR #126785)

2025-02-20 Thread via cfe-commits
https://github.com/PiJoules updated https://github.com/llvm/llvm-project/pull/126785 >From 07c7c069a57ec78e64df711cb17d5c873d3ad8cd Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Tue, 11 Feb 2025 11:31:17 -0800 Subject: [PATCH] [CodeGen] Ensure relative vtables use llvm.type.checked.load.re

[clang] [NFC][hlsl][Sema] Simplify CBuffer Legacy Size Calculation Control Flow (PR #127921)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-windows` running on `premerge-windows-1` while building `clang` at step 8 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/35/builds/7475 Here

[clang] [Clang] Implement CWG2918 'Consideration of constraints for address of overloaded function' (PR #127773)

2025-02-20 Thread Vlad Serebrennikov via cfe-commits
@@ -60,6 +60,92 @@ struct S { #endif } // namespace cwg2917 +namespace cwg2918 { // cwg2918: 21 + +#if __cplusplus >= 202002L + +namespace Example1 { + +template struct X { + void f(short) requires B; + void f(long); + template void g(short) requires B; + template void g(l

[clang] [Clang] Mark P1061 (Structured Bindings can introduce a Pack) as implemented (PR #127980)

2025-02-20 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/127980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Mark P1061 (Structured Bindings can introduce a Pack) as implemented (PR #127980)

2025-02-20 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, though I changed the patch summary to link it to the implementation work. https://github.com/llvm/llvm-project/pull/127980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] 12f8ed5 - [Clang] Mark P1061 (Structured Bindings can introduce a Pack) as implemented (#127980)

2025-02-20 Thread via cfe-commits
Author: cor3ntin Date: 2025-02-20T13:55:32+01:00 New Revision: 12f8ed58a039ff3a3365591203f76ae07a179215 URL: https://github.com/llvm/llvm-project/commit/12f8ed58a039ff3a3365591203f76ae07a179215 DIFF: https://github.com/llvm/llvm-project/commit/12f8ed58a039ff3a3365591203f76ae07a179215.diff LOG:

[clang] [clang-tools-extra] [compiler-rt] [Clang] [NFC] Fix more `-Wreturn-type` warnings in tests everywhere (PR #123470)

2025-02-20 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM; I'm sure plenty of these could have changed the return type to `void`, but I think adding a `return` statement is fine as well (it means we don't have to question whether the return type mattered elsewhere in the tests). https:/

[clang] [ARM, AArch64] Fix ABI bugs with over-sized bitfields (PR #126774)

2025-02-20 Thread John Brawn via cfe-commits
@@ -161,5 +168,62 @@ int test_bitint8(){ } // CHECK: ret i32 1 +// Over-sized bitfield, which results in a 64-bit container type, so 64-bit +// alignment. +struct OverSizedBitfield { + int x : 64; +}; + +unsigned sizeof_OverSizedBitfield = sizeof(OverSizedBitfield); +unsigne

[clang-tools-extra] [clang-tidy] Add new check bugprone-unintended-char-ostream-output (PR #127720)

2025-02-20 Thread Congcong Cai via cfe-commits
@@ -0,0 +1,69 @@ +//===--- UnintendedCharOstreamOutputCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang][Sema] Fix initialization of `NonTypeTemplateParmDecl`... (PR #121768)

2025-02-20 Thread Matheus Izvekov via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?=, Alejandro =?utf-8?q?Álvarez_Ayllón?=, Alejandro =?utf-8?q?Álvarez_Ayllón?=, Alejandro =?utf-8?q?Álvarez_Ayllón?=, Alejandro =?utf-8?q?Álvarez_Ayllón?=, Alejandro =?utf-8?q?Álvarez_Ayllón?=, Alejandro =?utf-8?q?Álvarez_Ayllón?=, Alejandro =?utf-8?q?Álvarez_Aylló

[clang-tools-extra] [clang-tidy] Add new check bugprone-unintended-char-ostream-output (PR #127720)

2025-02-20 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/127720 >From b69bb465a24f2175f2f9f91f220252d3bcb27bde Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 19 Feb 2025 07:38:37 +0800 Subject: [PATCH 1/8] [clang-tidy]add new check bugprone-unintended-char-ostre

[clang] [CMake] Fix variable name (PR #127967)

2025-02-20 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: Please merge this soon. This has broken our CI miserably and has blocked all our testing. Thanks! https://github.com/llvm/llvm-project/pull/127967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] [OpenEmbedded] Fix include and lib paths for multilib targets (PR #121302)

2025-02-20 Thread Mike Crowe via cfe-commits
mikecrowe wrote: @nikic @MaskRay Ping https://github.com/llvm/llvm-project/pull/121302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-20 Thread Henrich Lauko via cfe-commits
@@ -2958,6 +2958,8 @@ defm clangir : BoolFOption<"clangir", BothFlags<[], [ClangOption, CC1Option], "">>; def emit_cir : Flag<["-"], "emit-cir">, Visibility<[ClangOption, CC1Option]>, Group, HelpText<"Build ASTs and then lower to ClangIR">; +def emit_cir_mlir : Flag<["-"],

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-20 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/127835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] 079115e - [libclc] Move modf to the CLC library (#127828)

2025-02-20 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-02-20T08:36:46Z New Revision: 079115e6eac0412214104b593849ee805d8921ce URL: https://github.com/llvm/llvm-project/commit/079115e6eac0412214104b593849ee805d8921ce DIFF: https://github.com/llvm/llvm-project/commit/079115e6eac0412214104b593849ee805d8921ce.diff LOG

[clang] [TBAA] Refine pointer-tbaa for void pointers by pointer depth (PR #126047)

2025-02-20 Thread Bruno De Fraine via cfe-commits
brunodf-snps wrote: @Endilll @rjmccall OK to merge. https://github.com/llvm/llvm-project/pull/126047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] more useful error message for decomposition declaration missing initializer (PR #127924)

2025-02-20 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon commented: Thank you for the patch! The change needs a LIT test though. An example of a LIT test can be found in clang/test/SemaCXX. You would need to use -verify flag and check that the new error message is emitted as intended. It would be great also to include a

[clang] [clang] print correct context for diagnostics suppressed by deduction (PR #125453)

2025-02-20 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/125453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Propagate `volatile` qualifier in derived-to-base conversion (PR #127824)

2025-02-20 Thread Antonio Frighetto via cfe-commits
https://github.com/antoniofrighetto updated https://github.com/llvm/llvm-project/pull/127824 >From 1c7357a3279322ba469c1293d49bfba67b0565b5 Mon Sep 17 00:00:00 2001 From: Antonio Frighetto Date: Wed, 19 Feb 2025 16:47:18 +0100 Subject: [PATCH] [clang][Sema] Propagate `volatile` during derived-t

[clang] [CodeGen][NFC] Move test builtin_signbit.cpp to CodeGen (PR #127814)

2025-02-20 Thread Donát Nagy via cfe-commits
NagyDonat wrote: The CI failure is in a completely unrelated test file; I'm pretty confident that it's unrelated to my commit. https://github.com/llvm/llvm-project/pull/127814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [llvm] [AArch64][SVE] Lower unpredicated loads/stores as LDR/STR. (PR #127837)

2025-02-20 Thread Ricardo Jesus via cfe-commits
rj-jesus wrote: Hi @paulwalker-arm, I think the alignment requirements of LD1 and LDR are indeed different, but this only matters if `AlignmentEnforced()` is enabled, right? I thought `AlignmentEnforced` wasn't generally a concern, otherwise even the current lowering we have for `vld1q_u8(uint

[clang] [clang][Sema] Propagate `volatile` during derived-to-base conversion (PR #127824)

2025-02-20 Thread Antonio Frighetto via cfe-commits
antoniofrighetto wrote: > Should the result type of the ImplicitCastExpr be volatile in the AST? Definitely, updated, thanks! https://github.com/llvm/llvm-project/pull/127824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [clang][Sema] Propagate `volatile` during derived-to-base conversion (PR #127824)

2025-02-20 Thread Antonio Frighetto via cfe-commits
https://github.com/antoniofrighetto edited https://github.com/llvm/llvm-project/pull/127824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Propagate `volatile` during derived-to-base conversion (PR #127824)

2025-02-20 Thread Antonio Frighetto via cfe-commits
https://github.com/antoniofrighetto edited https://github.com/llvm/llvm-project/pull/127824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Lower modf builtin using `llvm.modf` intrinsic (PR #126750)

2025-02-20 Thread via cfe-commits
dcandler wrote: FYI, I was also a getting an error from this change, when trying to build picolibc for armv6m (as well as other arm targets): ``` SoftenFloatResult #0: t106: f64,f64 = fmodf t105, ../../../../../src/picolibc/test/math-funcs.c:85:10 fatal error: error in backend: Do not know how

[clang] [Clang] Fix segmentation fault caused by `VarBypassDetector` stack overflow on deeply nested expressions (PR #124128)

2025-02-20 Thread Boaz Brickner via cfe-commits
@@ -0,0 +1,30 @@ +// RUN: %clang_cc1 %s -emit-llvm -o - -Wstack-exhausted bricknerb wrote: I believe one of @cor3ntin concerns in #111701 was flakiness, not just speed. I'm happy to try and add that option if there are no objections. https://github.com/llvm/llvm

[clang] [TBAA] Refine pointer-tbaa for void pointers by pointer depth (PR #126047)

2025-02-20 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/126047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >