=?utf-8?q?André?= Brand ,
=?utf-8?q?André?= Brand ,
=?utf-8?q?André?= Brand ,
=?utf-8?q?André?= Brand
Message-ID:
In-Reply-To:
Sirraide wrote:
> @Sirraide I just rebased the branch on main and ran the unit tests locally in
> case you'd like to merge it now.
Ah, sorry, I’ve been a bit busy so
MacDue wrote:
> I'm a hard no on making this a target dependent option. Just enable it
> unconditionally and take the regression
Fine, I don't mind the regression as it does not affect targets I work on, I
just wanted to make the changes needed for AArch64 without knowingly slightly
regressin
https://github.com/balazske updated
https://github.com/llvm/llvm-project/pull/127191
From 1f2ad6d5ce6f11fb031ec2175527f56ea86761ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?=
Date: Mon, 3 Feb 2025 15:35:31 +0100
Subject: [PATCH 1/4] [clang][analyzer] Add checker
'alpha.c
@@ -0,0 +1,239 @@
+// RUN: %check_clang_tidy %s readability-ambiguous-smartptr-reset-call %t
--fix-notes --
+
+namespace std {
+
+template
+struct unique_ptr {
+ T& operator*() const;
+ T* operator->() const;
+ void reset(T* p = nullptr);
+};
+
+template
+struct shared_ptr {
https://github.com/andykaylor edited
https://github.com/llvm/llvm-project/pull/127621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From 610953fa4f0b6b93549bdaf1ac6e317a34551f93 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 13:38:13 +
Subject: [PATCH 1/8] [MLIR][OpenMP] Add LLVM translation support for OpenMP
Use
@@ -13,19 +13,25 @@
const UINT_TYPE sign_bit = (UINT_TYPE)1
\
<< (sizeof(INT_TYPE_SCALAR) * 8 - 1);
\
const UINT_TYPE sign_bit_mask = sign_bit - (UINT_TYPE)1;
\
-INT_TYP
@@ -13,19 +13,25 @@
const UINT_TYPE sign_bit = (UINT_TYPE)1
\
<< (sizeof(INT_TYPE_SCALAR) * 8 - 1);
\
const UINT_TYPE sign_bit_mask = sign_bit - (UINT_TYPE)1;
\
-INT_TYP
@@ -13,19 +13,25 @@
const UINT_TYPE sign_bit = (UINT_TYPE)1
\
<< (sizeof(INT_TYPE_SCALAR) * 8 - 1);
\
const UINT_TYPE sign_bit_mask = sign_bit - (UINT_TYPE)1;
\
-INT_TYP
@@ -13,19 +13,25 @@
const UINT_TYPE sign_bit = (UINT_TYPE)1
\
<< (sizeof(INT_TYPE_SCALAR) * 8 - 1);
\
const UINT_TYPE sign_bit_mask = sign_bit - (UINT_TYPE)1;
\
-INT_TYP
https://github.com/TIFitis closed
https://github.com/llvm/llvm-project/pull/124746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gandhi56 wrote:
ping
https://github.com/llvm/llvm-project/pull/124989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
foxtran wrote:
> Will it have redefinition problem since I need to share this enum between two
> diagnostics?
Unfortunately, yes...
https://github.com/llvm/llvm-project/blob/785a5b4676e7aa77904babb9f66e862b5fc39295/clang/test/TableGen/select-enum-errors.td#L15-L20
https://github.com/llvm/llv
https://github.com/mydeveloperday commented:
Looks good to me
https://github.com/llvm/llvm-project/pull/127545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
foxtran wrote:
> I think this might be a good candidate for the new %enum_select thingy that
> @erichkeane added recently (see
> https://clang.llvm.org/docs/InternalsManual.html#formatting-a-diagnostic-argument
> for documentation if you’re not familiar w/ it).
Yep, thank you!
Will it have r
@@ -588,42 +579,26 @@ struct CheckFallThroughDiagnostics {
static CheckFallThroughDiagnostics MakeForCoroutine(const Decl *Func) {
CheckFallThroughDiagnostics D;
D.FuncLoc = Func->getLocation();
-D.diag_MaybeFallThrough_HasNoReturn = 0;
-D.diag_MaybeFallThroug
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/127675
We add the hlsl_device address space to represent the device memory
space as defined in section 1.7.1.3 of the [HLSL
spec](https://microsoft.github.io/hlsl-specs/specs/hlsl.pdf).
Fixes https://github.com/llvm/l
spall wrote:
> Looks fine to me, but this change doesn't only affect HLSL does it? The
> function `getArrayParameterType` in `ASTContext.cpp` doesn't look like it is
> HLSL-specific. I wonder if a similar bug occurs within C/C++.
I believe this function is only called in an HLSL context.
http
@@ -6747,8 +6747,18 @@ defm backtrace : BooleanFFlag<"backtrace">,
Group;
defm bounds_check : BooleanFFlag<"bounds-check">, Group;
defm check_array_temporaries : BooleanFFlag<"check-array-temporaries">,
Group;
defm cray_pointer : BooleanFFlag<"cray-pointer">, Group;
-defm d_l
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/121763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6747,8 +6747,18 @@ defm backtrace : BooleanFFlag<"backtrace">,
Group;
defm bounds_check : BooleanFFlag<"bounds-check">, Group;
defm check_array_temporaries : BooleanFFlag<"check-array-temporaries">,
Group;
defm cray_pointer : BooleanFFlag<"cray-pointer">, Group;
-defm d_l
@@ -94,6 +94,11 @@ bool Qualifiers::isTargetAddressSpaceSupersetOf(LangAS A,
LangAS B,
(A == LangAS::Default &&
(B == LangAS::cuda_constant || B == LangAS::cuda_device ||
B == LangAS::cuda_shared)) ||
+ // In HLSL, the this pointer for mem
https://github.com/Icohedron edited
https://github.com/llvm/llvm-project/pull/127670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/126828
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/V-FEXrt approved this pull request.
https://github.com/llvm/llvm-project/pull/127346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11246,6 +11246,12 @@ static void DiagnoseBadShiftValues(Sema& S, ExprResult
&LHS, ExprResult &RHS,
if (S.getLangOpts().OpenCL)
return;
+ if (LHS.get()->IgnoreParenImpCasts()->getType()->isBooleanType()) {
+S.Diag(Loc, diag::warn_shift_bool)
+<< (Opc ==
@@ -7115,6 +7115,9 @@ def warn_shift_result_sets_sign_bit : Warning<
"signed shift result (%0) sets the sign bit of the shift expression's "
"type (%1) and becomes negative">,
InGroup>, DefaultIgnore;
+def warn_shift_bool : Warning<
+ "%select{left|right}0 shifting a `bo
https://github.com/zhouronghua updated
https://github.com/llvm/llvm-project/pull/119513
>From 2daff934319a2cd654c0bc27d168e3c3d2f8d902 Mon Sep 17 00:00:00 2001
From: "ronghua.zhou"
Date: Fri, 14 Feb 2025 01:04:51 +
Subject: [PATCH] [Feature]: support for the BC library file into the compile
dyung wrote:
> > I'm seeing our internal downstream builder hit the exact same error in this
> > test, but that is building a Windows hosted compiler targeting Windows.
> > Looking at our runs, it seems to have started appearing after your change
> > [479ffe8](https://github.com/llvm/llvm-proj
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
If the target type is a pointer type.
---
Full diff: https://github.com/llvm/llvm-project/pull/127615.diff
5 Files Affected:
- (modified) clang/lib/AST/ByteCode/Compiler.cpp (+4-2)
- (modified) clang/lib/
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/127525
>From d931667e3b7e18f8ba6f054405ffc5fe2fac36b4 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Tue, 18 Feb 2025 01:26:26 +0800
Subject: [PATCH 1/2] [Clang][CodeGen] Bail out on constexpr unknown values in
Co
https://github.com/frasercrmck created
https://github.com/llvm/llvm-project/pull/127628
This commit is a broad update across libclc to use the CLC conversion builtins
in CLC functions, even those with a '__clc' prefix in the generic folder. This
better prepares them for an official move to the
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
Changes
StringLiteral is used as internal data of EmbedExpr and we directly use it as
an initializer if a single EmbedExpr appears in the initializer list of a char
array. It is fast and convenient, but i
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/127629
StringLiteral is used as internal data of EmbedExpr and we directly use it as
an initializer if a single EmbedExpr appears in the initializer list of a char
array. It is fast and convenient, but it is causing
Vipul-Cariappa wrote:
My theory with limited testing: The crash is caused by assertion failure at
https://github.com/llvm/llvm-project/blob/eb7c947272952d40d3235d89652a10da52cb2b4d/clang/lib/AST/DeclBase.cpp#L1757C1-L1758C54.
So if we disable assertions it does not crash, and crashes otherwise.
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/127629
>From 700ec6f78c0a24729801bea381bafbcafb06826b Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 18 Feb 2025 05:12:07 -0800
Subject: [PATCH 1/2] [clang] Introduce "binary" StringLiteral for #e
@@ -3830,6 +3876,14 @@ SDValue SystemZTargetLowering::lowerSELECT_CC(SDValue Op,
ISD::CondCode CC = cast(Op.getOperand(4))->get();
SDLoc DL(Op);
+ // SELECT_CC involving f16 will not have the cmp-ops promoted by the
+ // legalizer, as it will be handled according to the
https://github.com/dtcxzyw ready_for_review
https://github.com/llvm/llvm-project/pull/127525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sjoerd Meijer (sjoerdmeijer)
Changes
We had an internal discussion about -ffp-contract, how it compared to GCC which
defaults to fast, and standard compliance. Looking at our docs, I think most
information is there, but also thought it co
https://github.com/dtcxzyw edited
https://github.com/llvm/llvm-project/pull/127525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Yingwei Zheng (dtcxzyw)
Changes
After https://github.com/llvm/llvm-project/pull/95474, unknown references are
valid in constant expressions. However, constexpr-unknown values are not
allowed in CodeGen. This patch bails out on con
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Elvina Yakubova (ElvinaYakubova)
Changes
Enable optional ISA extensions on Grace when mcpu=grace is used
---
Full diff: https://github.com/llvm/llvm-project/pull/127620.diff
5 Files Affected:
- (modified) clang/test/Driver/aarch6
https://github.com/sjoerdmeijer edited
https://github.com/llvm/llvm-project/pull/127620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -92,7 +92,7 @@
// COBALT-100: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-cpu"
"neoverse-n2"
// RUN: %clang --target=aarch64 -mcpu=grace -### -c %s 2>&1 | FileCheck
-check-prefix=GRACE %s
-// GRACE: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-cpu" "neoverse-v2"
--
https://github.com/sjoerdmeijer commented:
It would be good to mention in the description:
- that Grace is no longer an alias, but is a separate CPU definition.
- which optional extensions are now enabled.
https://github.com/llvm/llvm-project/pull/127620
___
https://github.com/frasercrmck closed
https://github.com/llvm/llvm-project/pull/127532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/127623
Declaring a coroutine `[[noreturn]]` doesn't make sense, because it will always
return its handle. Clang previously crashed when trying to warn about this
(diagnostic ID was 0).
This PR adds a warning specific
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/125658
>From 70d7bd8fe791210a6e83389c7e33e17d1fed0c77 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Tue, 4 Feb 2025 10:14:12 +0100
Subject: [PATCH] [Clang] Do not try to transform invalid bindings
In the presen
Author: Fraser Cormack
Date: 2025-02-18T12:06:14Z
New Revision: 1c6cecdbdd2470292ce0b508922d807e3100f85c
URL:
https://github.com/llvm/llvm-project/commit/1c6cecdbdd2470292ce0b508922d807e3100f85c
DIFF:
https://github.com/llvm/llvm-project/commit/1c6cecdbdd2470292ce0b508922d807e3100f85c.diff
LOG
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: nerix (Nerixyz)
Changes
Declaring a coroutine `[[noreturn]]` doesn't make sense, because it will always
return its handle. Clang previously crashed when trying to warn about this
(diagnostic ID was 0).
This PR adds a warning specific to
@@ -7115,6 +7115,9 @@ def warn_shift_result_sets_sign_bit : Warning<
"signed shift result (%0) sets the sign bit of the shift expression's "
"type (%1) and becomes negative">,
InGroup>, DefaultIgnore;
+def warn_shift_bool : Warning<
+ "%select{left|right}0 shifting a `bo
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/127061
>From a76ee008bdb87655da465e21d09c840edecc2b1b Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Thu, 13 Feb 2025 15:24:09 +0200
Subject: [PATCH 1/2] [Clang] emit -Wunused-variable warning for unused
structur
https://github.com/ElvinaYakubova edited
https://github.com/llvm/llvm-project/pull/127620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
The fixme comment turned out to be true.
---
Full diff: https://github.com/llvm/llvm-project/pull/127627.diff
2 Files Affected:
- (modified) clang/lib/AST/ByteCode/Descriptor.cpp (+24-2)
- (modified) clan
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/127627
The fixme comment turned out to be true.
>From 7fec903e68bc8a2803b2bfd51d47cc4723e24234 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 18 Feb 2025 14:02:58 +0100
Subject: [PATCH] [clan
@@ -3986,11 +3986,15 @@ defm assumptions : BoolFOption<"assumptions",
"Disable codegen and compile-time checks for C++23's [[assume]]
attribute">,
PosFlag>;
+
+let Visibility = [ClangOption, FlangOption] in {
DavidTruby wrote:
The docs
[here](ht
JonPsson1 wrote:
Updated per review.
- Wrapping all isel handlings of FP with !useSoftFloat to make sure no custom
lowerering may ever use an FP reg. I am not really sure this is needed as the
type-legalizer is run before any lowering, but maybe do it just to be sure.
- Also found out that a
@@ -0,0 +1,134 @@
+//===--- UseNumericLimitsCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/arsenm requested changes to this pull request.
I'm a hard no on making this a target dependent option. Just enable it
unconditionally and take the regression
https://github.com/llvm/llvm-project/pull/121763
___
cfe-commits mailing
@@ -0,0 +1,203 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,53 @@
+// Simple functions
+// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -fclangir
-emit-cir %s -o - | FileCheck %s
+
+void empty() { }
+// CHECK: cir.func @empty() -> !cir.void {
andykaylor wrote:
Why aren't the function names mang
@@ -3910,8 +3910,13 @@ StmtResult Sema::BuildReturnStmt(SourceLocation
ReturnLoc, Expr *RetValExp,
FnRetType = FD->getReturnType();
if (FD->hasAttrs())
Attrs = &FD->getAttrs();
-if (FD->isNoReturn())
- Diag(ReturnLoc, diag::warn_noreturn_function_has_ret
foxtran wrote:
> Would you be interested in collaborating on a paper?
Yep. Sure. Let's make C/C++ safer!
https://github.com/llvm/llvm-project/pull/123470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Philip Reames (preames)
Changes
This implements assembler support for the XRivosVizip custom/vendor extension
from Rivos Inc. which is defined in:
https://github.com/rivosinc/rivos-custom-extensions (See src/xrivosvizip.adoc)
Codeg
@@ -544,25 +544,17 @@ static ControlFlowKind
CheckFallThrough(AnalysisDeclContext &AC) {
namespace {
struct CheckFallThroughDiagnostics {
- unsigned diag_MaybeFallThrough_HasNoReturn;
- unsigned diag_MaybeFallThrough_ReturnsNonVoid;
- unsigned diag_AlwaysFallThrough_HasNoR
@@ -696,47 +665,41 @@ static void CheckFallThroughForBody(Sema &S, const Decl
*D, const Stmt *Body,
if (CD.checkDiagnostics(Diags, ReturnsVoid, HasNoReturn))
return;
SourceLocation LBrace = Body->getBeginLoc(), RBrace = Body->getEndLoc();
- auto EmitDiag = [&](Sourc
@@ -544,25 +544,17 @@ static ControlFlowKind
CheckFallThrough(AnalysisDeclContext &AC) {
namespace {
struct CheckFallThroughDiagnostics {
- unsigned diag_MaybeFallThrough_HasNoReturn;
- unsigned diag_MaybeFallThrough_ReturnsNonVoid;
- unsigned diag_AlwaysFallThrough_HasNoR
@@ -721,6 +721,8 @@ DecodeStatus RISCVDisassembler::getInstruction32(MCInst
&MI, uint64_t &Size,
"Qualcomm uC Conditional Move custom opcode table");
TRY_TO_DECODE_FEATURE(RISCV::FeatureVendorXqciint, DecoderTableXqciint32,
"Qu
https://github.com/preames edited
https://github.com/llvm/llvm-project/pull/127694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/preames commented:
(inline comments on possible discussion points)
https://github.com/llvm/llvm-project/pull/127694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -696,47 +665,41 @@ static void CheckFallThroughForBody(Sema &S, const Decl
*D, const Stmt *Body,
if (CD.checkDiagnostics(Diags, ReturnsVoid, HasNoReturn))
return;
SourceLocation LBrace = Body->getBeginLoc(), RBrace = Body->getEndLoc();
- auto EmitDiag = [&](Sourc
@@ -202,6 +202,7 @@
// CHECK-NEXT: xqcilo 0.2 'Xqcilo' (Qualcomm uC Large
Offset Load Store Extension)
// CHECK-NEXT: xqcilsm 0.2 'Xqcilsm' (Qualcomm uC Load
Store Multiple Extension)
// CHECK-NEXT: xqcisls 0.2
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/127623
>From 62ca537167467947d37174ee822c67a0d44a3bf0 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Tue, 18 Feb 2025 12:56:05 +0100
Subject: [PATCH] [Clang] Warn about `[[noreturn]]` on coroutines
---
.../clang/Basic/
@@ -381,24 +381,22 @@ typename A::pint_t
DwarfInstructions::evaluateExpression(pint_t expression, A &addressSpace,
const R ®isters,
pint_t initialStackValue) {
- const bool log = false;
jeremy-rifkin wrote:
Hi @foxtran, I have been working on a proposal on the C++ side. Extensive
justification is needed to justify breakage here and I have been attempting to
survey the extent of potential breakage. The wording is also tricky especially
since attributes are designed to be ignor
Author: Krzysztof Drewniak
Date: 2025-02-18T14:15:28-06:00
New Revision: f7d03707d1f59cddab98d49fe55d8946477f87c8
URL:
https://github.com/llvm/llvm-project/commit/f7d03707d1f59cddab98d49fe55d8946477f87c8
DIFF:
https://github.com/llvm/llvm-project/commit/f7d03707d1f59cddab98d49fe55d8946477f87c8.
https://github.com/krzysz00 closed
https://github.com/llvm/llvm-project/pull/126828
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide commented:
I still think it makes more sense to diagnose this when the FunctionDecl is
created rather than when we try and return from it.
https://github.com/llvm/llvm-project/pull/127623
___
cfe-commits mailing list
cfe-co
https://github.com/PiJoules updated
https://github.com/llvm/llvm-project/pull/126785
>From 4642bdb03543cca1ee9d1bbd70cb53b2d76b4e8c Mon Sep 17 00:00:00 2001
From: Leonard Chan
Date: Tue, 11 Feb 2025 11:31:17 -0800
Subject: [PATCH] [CodeGen] Ensure relative vtables use
llvm.type.checked.load.re
@@ -3910,8 +3910,13 @@ StmtResult Sema::BuildReturnStmt(SourceLocation
ReturnLoc, Expr *RetValExp,
FnRetType = FD->getReturnType();
if (FD->hasAttrs())
Attrs = &FD->getAttrs();
-if (FD->isNoReturn())
- Diag(ReturnLoc, diag::warn_noreturn_function_has_ret
Sirraide wrote:
> I still think it makes more sense to diagnose this when the FunctionDecl is
> created rather than when we try and return from it.
Huh, weird, github went ahead and posted that comment anyway even though it was
complaining about the review message being empty. This was suppose
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/127623
>From 51d7ebdd37013c3d90d2720952c712815fb49525 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Tue, 18 Feb 2025 12:56:05 +0100
Subject: [PATCH] [Clang] Warn about `[[noreturn]]` on coroutines
---
.../clang/Basic/
@@ -3910,8 +3910,13 @@ StmtResult Sema::BuildReturnStmt(SourceLocation
ReturnLoc, Expr *RetValExp,
FnRetType = FD->getReturnType();
if (FD->hasAttrs())
Attrs = &FD->getAttrs();
-if (FD->isNoReturn())
- Diag(ReturnLoc, diag::warn_noreturn_function_has_ret
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -223,6 +221,41 @@
} while (0)
#endif
+#define _LIBUNWIND_TRACING_COMPACT_UNWIND (0)
+#if !_LIBUNWIND_TRACING_COMPACT_UNWIND
+#define _LIBUNWIND_TRACE_COMPACT_UNWIND0(msg)
+#define _LIBUNWIND_TRACE_COMPACT_UNWIND(msg, ...)
+#else
+#define _LIBUNWIND_TRACE_COMPACT_UNWIND0
Prabhuk wrote:
@joaosaffran apologies. It was relanded by @nikic in
https://github.com/llvm/llvm-project/commit/7e3735d1a1b85cea48feb45cb7c2b5d8eaa216ae
We were able to verify that reverting this patch locally resolves the windows
builder failure that we are facing. We will try to dig deeper
@@ -0,0 +1,124 @@
+; RUN: llc -mtriple=x86_64-unknown-linux-gnu %s -o %t -filetype=obj
+; RUN:llvm-dwarfdump %t | FileCheck %s
stevemerr wrote:
I'd recommend adding spaces to make this look more like the other tests. So
change to "RUN: " and "; CHECK:" for exa
https://github.com/preames created
https://github.com/llvm/llvm-project/pull/127694
This implements assembler support for the XRivosVizip custom/vendor extension
from Rivos Inc. which is defined in:
https://github.com/rivosinc/rivos-custom-extensions (See src/xrivosvizip.adoc)
Codegen support
@@ -223,6 +221,41 @@
} while (0)
#endif
+#define _LIBUNWIND_TRACING_COMPACT_UNWIND (0)
+#if !_LIBUNWIND_TRACING_COMPACT_UNWIND
+#define _LIBUNWIND_TRACE_COMPACT_UNWIND0(msg)
+#define _LIBUNWIND_TRACE_COMPACT_UNWIND(msg, ...)
+#else
+#define _LIBUNWIND_TRACE_COMPACT_UNWIND0
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Philip Reames (preames)
Changes
This implements assembler support for the XRivosVizip custom/vendor extension
from Rivos Inc. which is defined in:
https://github.com/rivosinc/rivos-custom-extensions (See src/xrivosvizip.adoc)
Codegen supp
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -544,25 +544,17 @@ static ControlFlowKind
CheckFallThrough(AnalysisDeclContext &AC) {
namespace {
struct CheckFallThroughDiagnostics {
- unsigned diag_MaybeFallThrough_HasNoReturn;
- unsigned diag_MaybeFallThrough_ReturnsNonVoid;
- unsigned diag_AlwaysFallThrough_HasNoR
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/127623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1176,6 +1176,10 @@ void Sema::CheckCompletedCoroutineBody(FunctionDecl *FD,
Stmt *&Body) {
for (AddrLabelExpr *ALE : Fn->AddrLabels)
Diag(ALE->getBeginLoc(), diag::err_coro_invalid_addr_of_label);
+ // Coroutines always return a handle, so they can't be [[noreturn]
@@ -1176,6 +1176,10 @@ void Sema::CheckCompletedCoroutineBody(FunctionDecl *FD,
Stmt *&Body) {
for (AddrLabelExpr *ALE : Fn->AddrLabels)
Diag(ALE->getBeginLoc(), diag::err_coro_invalid_addr_of_label);
+ // Coroutines always return a handle, so they can't be [[noreturn]
@@ -696,47 +665,41 @@ static void CheckFallThroughForBody(Sema &S, const Decl
*D, const Stmt *Body,
if (CD.checkDiagnostics(Diags, ReturnsVoid, HasNoReturn))
return;
SourceLocation LBrace = Body->getBeginLoc(), RBrace = Body->getEndLoc();
- auto EmitDiag = [&](Sourc
@@ -1176,6 +1176,10 @@ void Sema::CheckCompletedCoroutineBody(FunctionDecl *FD,
Stmt *&Body) {
for (AddrLabelExpr *ALE : Fn->AddrLabels)
Diag(ALE->getBeginLoc(), diag::err_coro_invalid_addr_of_label);
+ // Coroutines always return a handle, so they can't be [[noreturn]
@@ -544,25 +544,17 @@ static ControlFlowKind
CheckFallThrough(AnalysisDeclContext &AC) {
namespace {
struct CheckFallThroughDiagnostics {
- unsigned diag_MaybeFallThrough_HasNoReturn;
- unsigned diag_MaybeFallThrough_ReturnsNonVoid;
- unsigned diag_AlwaysFallThrough_HasNoR
michael-kenzel wrote:
> @michael-kenzel Was there a reason why this never got merged?
I don't think there was, I guess this just fell through the cracks…
https://github.com/llvm/llvm-project/pull/72040
___
cfe-commits mailing list
cfe-commits@lists.ll
201 - 300 of 537 matches
Mail list logo
