[clang] Reapply "[Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP."… (PR #126671)

2025-02-11 Thread Amit Kumar Pandey via cfe-commits
https://github.com/ampandey-1995 updated https://github.com/llvm/llvm-project/pull/126671 >From e735ed1d3a577dcb66336515c1a6e9955b397dd3 Mon Sep 17 00:00:00 2001 From: Amit Pandey Date: Tue, 11 Feb 2025 08:06:21 +0530 Subject: [PATCH] Reapply "[Driver][ROCm][OpenMP] Fix default ockl linking for

[clang] [llvm] [ARM] Adding diagnostics for mcmodel=tiny when used in invalid targets (PR #125643)

2025-02-11 Thread via cfe-commits
ShashwathiNavada wrote: > Can you add tests and a release note entry? Thanks! @cor3ntin I have addressed your comment. Could you please look into it. Thank you!! https://github.com/llvm/llvm-project/pull/125643 ___ cfe-commits mailing list cfe-commi

[clang] [clang] CTAD: Remove an incorrect assertion in BuildDeductionGuideForTypeAlias (PR #126532)

2025-02-11 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/126532 >From cc0b4f59c273db9baff85a457ef534d6f7ca9cfb Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 10 Feb 2025 15:44:00 +0100 Subject: [PATCH] [clang] CTAD: Remove an incorrect assertion in BuildDeductionGuideF

[clang] [clang] CTAD: Remove an incorrect assertion in BuildDeductionGuideForTypeAlias (PR #126532)

2025-02-11 Thread Haojian Wu via cfe-commits
https://github.com/hokein ready_for_review https://github.com/llvm/llvm-project/pull/126532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] CTAD: Remove an incorrect assertion in BuildDeductionGuideForTypeAlias (PR #126532)

2025-02-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes Fixes #125821 The assertion was too strict, as Clang can reach this code path when recursively generating deduction guides for alias templates. See the detailed explanation [here](https://github.com/llvm/llvm

[clang] [clang][HeuristicResolver] Track the expression whose type is being simplified after each step in simplifyType() (PR #126689)

2025-02-11 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/126689 From e5a3d7aa5362357acd30ef5d1bafaa814ac2c89f Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 11 Feb 2025 01:56:50 -0500 Subject: [PATCH 1/2] [clang][HeuristicResolver] Track the expression whose type i

[clang] [llvm] [NVPTX] Add intrinsics for redux.sync f32 instructions (PR #126664)

2025-02-11 Thread Durgadoss R via cfe-commits
@@ -328,6 +328,24 @@ defm REDUX_SYNC_AND : REDUX_SYNC<"and", "b32", int_nvvm_redux_sync_and>; defm REDUX_SYNC_XOR : REDUX_SYNC<"xor", "b32", int_nvvm_redux_sync_xor>; defm REDUX_SYNC_OR : REDUX_SYNC<"or", "b32", int_nvvm_redux_sync_or>; +multiclass REDUX_SYNC_F { + def : NVP

[clang] [verify] Improve the error messages with multiple active prefixes (PR #126068)

2025-02-11 Thread Timm Baeder via cfe-commits
tbaederr wrote: This all looks like welcome improvements to me, but I'll let someone else make the final call. There are currently C++ meetings though, so some people might not be as available. https://github.com/llvm/llvm-project/pull/126068 ___ cfe

[clang] [llvm] [NVPTX] Add intrinsics for redux.sync f32 instructions (PR #126664)

2025-02-11 Thread Durgadoss R via cfe-commits
@@ -1,11 +1,13 @@ -// RUN: %clang_cc1 "-triple" "nvptx-nvidia-cuda" "-target-feature" "+ptx70" "-target-cpu" "sm_80" -emit-llvm -fcuda-is-device -o - %s | FileCheck %s -// RUN: %clang_cc1 "-triple" "nvptx64-nvidia-cuda" "-target-feature" "+ptx70" "-target-cpu" "sm_80" -emit-llvm

[clang] [clang] CTAD: Remove an incorrect assertion in BuildDeductionGuideForTypeAlias (PR #126532)

2025-02-11 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/126532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #126674)

2025-02-11 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/126674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Update the undefined assignment checker diagnostics to not use the term 'garbage' (PR #126596)

2025-02-11 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > This is a sufficiently strong contract in the static analyzer; I'm not aware > of any long-lived undefined values and I'd consider it a bug if I ever see a > long-lived undefined value. I'm pretty sure there are a few assertions that > would crash if this ever happened. > >

[clang] 9fdb063 - [clang][analyzer][NFC] Fix typos in comments (#126676)

2025-02-11 Thread via cfe-commits
Author: Ben Shi Date: 2025-02-11T18:40:32+08:00 New Revision: 9fdb0633051121af24dfa00e8a762df10138ecc3 URL: https://github.com/llvm/llvm-project/commit/9fdb0633051121af24dfa00e8a762df10138ecc3 DIFF: https://github.com/llvm/llvm-project/commit/9fdb0633051121af24dfa00e8a762df10138ecc3.diff LOG:

[clang] [llvm] [NVPTX] Add intrinsics for redux.sync f32 instructions (PR #126664)

2025-02-11 Thread Srinivasa Ravi via cfe-commits
https://github.com/Wolfram70 updated https://github.com/llvm/llvm-project/pull/126664 >From 062a48e73ea1434f3c00ab3c0e717db66aa0f15e Mon Sep 17 00:00:00 2001 From: Srinivasa Ravi Date: Mon, 10 Feb 2025 14:13:42 +0530 Subject: [PATCH] [NVPTX] Add intrinsics for redux.sync f32 instructions Adds

[clang] [analyzer] Update the undefined assignment checker diagnostics to not use the term 'garbage' (PR #126596)

2025-02-11 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/126596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Update the undefined assignment checker diagnostics to not use the term 'garbage' (PR #126596)

2025-02-11 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat dismissed https://github.com/llvm/llvm-project/pull/126596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TBAA] Refine pointer-tbaa for void pointers by pointer depth (PR #126047)

2025-02-11 Thread Bruno De Fraine via cfe-commits
@@ -80,6 +80,28 @@ llvm::MDNode *CodeGenTBAA::getChar() { return Char; } +llvm::MDNode *CodeGenTBAA::getAnyPtr(unsigned PtrDepth) { + assert(PtrDepth >= 1 && "Pointer must have some depth"); + + // Populate at least PtrDepth elements in AnyPtrs. These are the type nodes +

[clang] [HLSL] Appropriately set function attribute optnone (PR #125937)

2025-02-11 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy edited https://github.com/llvm/llvm-project/pull/125937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Appropriately set function attribute optnone (PR #125937)

2025-02-11 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy edited https://github.com/llvm/llvm-project/pull/125937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix false positive of [[clang::require_explicit_initialization]] on copy/move constructors (PR #126553)

2025-02-11 Thread via cfe-commits
higher-performance wrote: Oh - @AaronBallman would you mind tagging this for the release so we can cherry pick? https://github.com/llvm/llvm-project/pull/126553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [CodeGen] Avoid repeated hash lookups (NFC) (PR #126672)

2025-02-11 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/126672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c50f924 - [Sema] Avoid repeated hash lookups (NFC) (#126674)

2025-02-11 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-02-11T09:07:15-08:00 New Revision: c50f924aeae2d2eded772a7a80b20d46e1c9b41e URL: https://github.com/llvm/llvm-project/commit/c50f924aeae2d2eded772a7a80b20d46e1c9b41e DIFF: https://github.com/llvm/llvm-project/commit/c50f924aeae2d2eded772a7a80b20d46e1c9b41e.diff L

[clang] 8e4e144 - [CodeGen] Avoid repeated hash lookups (NFC) (#126672)

2025-02-11 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-02-11T09:06:40-08:00 New Revision: 8e4e1449318de0e73192edf0b3c6a0d5b6ec7a31 URL: https://github.com/llvm/llvm-project/commit/8e4e1449318de0e73192edf0b3c6a0d5b6ec7a31 DIFF: https://github.com/llvm/llvm-project/commit/8e4e1449318de0e73192edf0b3c6a0d5b6ec7a31.diff L

[clang] Fix false positive of [[clang::require_explicit_initialization]] on copy/move constructors (PR #126553)

2025-02-11 Thread via cfe-commits
higher-performance wrote: /cherry-pick 90192e8872cc90b4d292b180a49babf72d17e579 https://github.com/llvm/llvm-project/pull/126553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 75cb563 - [clang][Sema] Move computing enum bits into a separate function (#126096)

2025-02-11 Thread via cfe-commits
Author: Ilia Kuklin Date: 2025-02-11T22:17:52+05:00 New Revision: 75cb5633844deb4e0c6a5c7bdf84013b563818d3 URL: https://github.com/llvm/llvm-project/commit/75cb5633844deb4e0c6a5c7bdf84013b563818d3 DIFF: https://github.com/llvm/llvm-project/commit/75cb5633844deb4e0c6a5c7bdf84013b563818d3.diff L

[clang] [clang][Sema] Move computing enum bits into a separate function (PR #126096)

2025-02-11 Thread Ilia Kuklin via cfe-commits
https://github.com/kuilpd closed https://github.com/llvm/llvm-project/pull/126096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][cmake] Sanitize CLANG_BOLT values (PR #126768)

2025-02-11 Thread via cfe-commits
https://github.com/serge-sans-paille created https://github.com/llvm/llvm-project/pull/126768 This avoids failing later in the build process. >From 311777d5689fc2789e38967e8bb58077edb1a428 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Tue, 11 Feb 2025 18:20:15 +0100 Subject: [PATCH] [

[clang] [Driver][HIP] Do not pass -dependency-file flag for HIP Device offloading (PR #125646)

2025-02-11 Thread via cfe-commits
Prabhuk wrote: > @Prabhuk I'm not quite sure why I was mentioned here—which change are you > referring to? Sorry @sharadhr I got the wrong github handle. https://github.com/llvm/llvm-project/pull/125646 ___ cfe-commits mailing list cfe-commits@lists

[clang] [HLSL] Appropriately set function attribute optnone (PR #125937)

2025-02-11 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy edited https://github.com/llvm/llvm-project/pull/125937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] fix false positive of BlockInCriticalSectionChecker (PR #126752)

2025-02-11 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: Could you summarize the problem and the fix in the PR description? This will help people a lot when they read the git log. https://github.com/llvm/llvm-project/pull/126752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [clang][cmake] Sanitize CLANG_BOLT values (PR #126768)

2025-02-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (serge-sans-paille) Changes This avoids failing later in the build process. --- Full diff: https://github.com/llvm/llvm-project/pull/126768.diff 1 Files Affected: - (modified) clang/tools/driver/CMakeLists.txt (+5-1) ``d

[clang] [clang][cmake] Sanitize CLANG_BOLT values (PR #126768)

2025-02-11 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/126768 >From c2d1352aba4872957e34633b92d87c39d0eb7e45 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Tue, 11 Feb 2025 18:20:15 +0100 Subject: [PATCH] [clang][cmake] Sanitize CLANG_BOLT values This av

[clang] [analyzer][docs] Document how to use perf and uftrace to debug performance issues (PR #126724)

2025-02-11 Thread Balazs Benics via cfe-commits
@@ -45,3 +47,91 @@ Note: Both Chrome-tracing and speedscope tools might struggle with time traces a Luckily, in most cases the default max-steps boundary of 225 000 produces the traces of approximately that size for a single entry point. You can use ``-analyze-function=get_gl

[clang] [analyzer][docs] Document how to use perf and uftrace to debug performance issues (PR #126724)

2025-02-11 Thread Balazs Benics via cfe-commits
@@ -45,3 +47,91 @@ Note: Both Chrome-tracing and speedscope tools might struggle with time traces a Luckily, in most cases the default max-steps boundary of 225 000 produces the traces of approximately that size for a single entry point. You can use ``-analyze-function=get_gl

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-02-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. LGMT with a nit. https://github.com/llvm/llvm-project/pull/126324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-02-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/126324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-02-11 Thread Joseph Huber via cfe-commits
@@ -96,6 +100,47 @@ the header file to conditionally make a function constexpr whenever the constant evaluation of the corresponding builtin (for example, ``std::fmax`` calls ``__builtin_fmax``) is supported in Clang. +``__has_target_builtin`` + +

[clang] [analyzer][docs] Document how to use perf and uftrace to debug performance issues (PR #126724)

2025-02-11 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/126724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-02-11 Thread Aaron Ballman via cfe-commits
@@ -96,6 +100,47 @@ the header file to conditionally make a function constexpr whenever the constant evaluation of the corresponding builtin (for example, ``std::fmax`` calls ``__builtin_fmax``) is supported in Clang. +``__has_target_builtin`` + +

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-02-11 Thread Nick Sarnie via cfe-commits
@@ -96,6 +100,47 @@ the header file to conditionally make a function constexpr whenever the constant evaluation of the corresponding builtin (for example, ``std::fmax`` calls ``__builtin_fmax``) is supported in Clang. +``__has_target_builtin`` + +

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-02-11 Thread Joseph Huber via cfe-commits
@@ -96,6 +100,47 @@ the header file to conditionally make a function constexpr whenever the constant evaluation of the corresponding builtin (for example, ``std::fmax`` calls ``__builtin_fmax``) is supported in Clang. +``__has_target_builtin`` + +

[clang] [clang][Sema] Add diagnostic note for reference of function-like macros requiring without parentheses (PR #123495)

2025-02-11 Thread Aaron Ballman via cfe-commits
@@ -2347,6 +2347,27 @@ Sema::BuildDeclRefExpr(ValueDecl *D, QualType Ty, ExprValueKind VK, return E; } +// Check whether a similar function-like macro exists and suggest it +static bool isFunctionLikeMacro(const DeclarationName &Name, Sema &SemaRef, +

[clang] [HLSL] Fix resource wrapper declaration (PR #125718)

2025-02-11 Thread Steven Perron via cfe-commits
s-perron wrote: The other option is https://github.com/llvm/llvm-project/pull/123811. However, can you clarify "separate compilation". It is not clear to me exactly what type of linking you have in mind. This make it hard for me to reason about what should be done, and when. Are you thinking

[clang] b3510a8 - [NFC] [clang] simplify isDesignatorAtObjectEnd (#126658)

2025-02-11 Thread via cfe-commits
Author: Florian Mayer Date: 2025-02-11T09:05:35-08:00 New Revision: b3510a88b3c19645fbde09cb58af6dead68ebd36 URL: https://github.com/llvm/llvm-project/commit/b3510a88b3c19645fbde09cb58af6dead68ebd36 DIFF: https://github.com/llvm/llvm-project/commit/b3510a88b3c19645fbde09cb58af6dead68ebd36.diff

[clang] [NFC] [clang] simplify isDesignatorAtObjectEnd (PR #126658)

2025-02-11 Thread Florian Mayer via cfe-commits
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/126658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][HIP] Fix test for HIP as it was failing (PR #126585)

2025-02-11 Thread via cfe-commits
https://github.com/pirama-arumuga-nainar closed https://github.com/llvm/llvm-project/pull/126585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #126674)

2025-02-11 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/126674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 43c82a8 - [clang-installapi] Avoid repeated hash lookups (NFC) (#126677)

2025-02-11 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-02-11T09:07:46-08:00 New Revision: 43c82a8e07819ad0553ef0dffedff3c8b8cecf5e URL: https://github.com/llvm/llvm-project/commit/43c82a8e07819ad0553ef0dffedff3c8b8cecf5e DIFF: https://github.com/llvm/llvm-project/commit/43c82a8e07819ad0553ef0dffedff3c8b8cecf5e.diff L

[clang] [clang-installapi] Avoid repeated hash lookups (NFC) (PR #126677)

2025-02-11 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/126677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix false positive of [[clang::require_explicit_initialization]] on copy/move constructors (PR #126553)

2025-02-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman milestoned https://github.com/llvm/llvm-project/pull/126553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f574d82 - [Clang][Driver][HIP] Fix test for HIP as it was failing (#126585)

2025-02-11 Thread via cfe-commits
Author: Sharjeel Khan Date: 2025-02-11T09:11:40-08:00 New Revision: f574d8235371c4f28cad8e800d99bcb7ad579b7d URL: https://github.com/llvm/llvm-project/commit/f574d8235371c4f28cad8e800d99bcb7ad579b7d DIFF: https://github.com/llvm/llvm-project/commit/f574d8235371c4f28cad8e800d99bcb7ad579b7d.diff

[clang] Fix false positive of [[clang::require_explicit_initialization]] on copy/move constructors (PR #126553)

2025-02-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Oh - @AaronBallman would you mind tagging this for the release so we can > cherry pick? Sure! https://github.com/llvm/llvm-project/pull/126553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] Fix false positive of [[clang::require_explicit_initialization]] on copy/move constructors (PR #126553)

2025-02-11 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#126767 https://github.com/llvm/llvm-project/pull/126553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-11 Thread Chris B via cfe-commits
@@ -1017,4 +1017,15 @@ Error<"'#pragma unsafe_buffer_usage' was not ended">; def err_pp_pragma_unsafe_buffer_usage_syntax : Error<"expected 'begin' or 'end'">; + +// HLSL Root Signature Lexing Errors +let CategoryName = "Root Signature Lexical Issue" in { + def err_hlsl_expec

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-11 Thread Chris B via cfe-commits
https://github.com/llvm-beanz commented: In general I think this is very much moving in the right direction. I have two high level areas of feedback (see my more specific comments inline). In general, Lexer's don't often have the context to provide actionable error messages. As a result it is

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-11 Thread Chris B via cfe-commits
@@ -0,0 +1,194 @@ +#include "clang/Parse/ParseHLSLRootSignature.h" + +namespace clang { +namespace hlsl { + +// Lexer Definitions + +static bool IsNumberChar(char C) { + // TODO(#126565): extend for float support exponents + return isdigit(C); // integer support +} + +bool RootS

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-11 Thread Chris B via cfe-commits
@@ -0,0 +1,194 @@ +#include "clang/Parse/ParseHLSLRootSignature.h" + +namespace clang { +namespace hlsl { + +// Lexer Definitions + +static bool IsNumberChar(char C) { + // TODO(#126565): extend for float support exponents + return isdigit(C); // integer support +} + +bool RootS

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-11 Thread Chris B via cfe-commits
@@ -0,0 +1,194 @@ +#include "clang/Parse/ParseHLSLRootSignature.h" + +namespace clang { +namespace hlsl { + +// Lexer Definitions + +static bool IsNumberChar(char C) { + // TODO(#126565): extend for float support exponents + return isdigit(C); // integer support +} + +bool RootS

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-11 Thread Chris B via cfe-commits
@@ -0,0 +1,171 @@ +#include "clang/Parse/ParseHLSLRootSignature.h" + +namespace clang { +namespace hlsl { + +// Lexer Definitions + +static bool IsNumberChar(char C) { + // TODO(#120472): extend for float support exponents + return isdigit(C); // integer support +} + +bool RootS

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-11 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/122981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] fix false positive of BlockInCriticalSectionChecker (PR #126752)

2025-02-11 Thread via cfe-commits
@@ -145,6 +145,92 @@ using MutexDescriptor = std::variant; +class NonBlockOpenVisitor : public BugReporterVisitor { +private: + const VarRegion *VR; + const CallExpr *OpenCallExpr; + int O_NONBLOCKV; whisperity wrote: These POSIX constants are often def

[clang] b92bab3 - [HLSL] Appropriately set function attribute optnone (#125937)

2025-02-11 Thread via cfe-commits
Author: S. Bharadwaj Yadavalli Date: 2025-02-11T12:29:05-05:00 New Revision: b92bab3c010a8b8d7c2273ebdacfa34a757d URL: https://github.com/llvm/llvm-project/commit/b92bab3c010a8b8d7c2273ebdacfa34a757d DIFF: https://github.com/llvm/llvm-project/commit/b92bab3c010a8b8d7c2273ebdacfa34a7

[clang] [HLSL] Appropriately set function attribute optnone (PR #125937)

2025-02-11 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy closed https://github.com/llvm/llvm-project/pull/125937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Lower modf builtin using `llvm.modf` intrinsic (PR #126750)

2025-02-11 Thread Matt Arsenault via cfe-commits
@@ -859,6 +859,24 @@ static void emitSincosBuiltin(CodeGenFunction &CGF, const CallExpr *E, StoreCos->setMetadata(LLVMContext::MD_noalias, AliasScopeList); } +static llvm::Value *emitModfBuiltin(CodeGenFunction &CGF, const CallExpr *E, +l

[clang] Reapply "[Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP."… (PR #126671)

2025-02-11 Thread Amit Kumar Pandey via cfe-commits
https://github.com/ampandey-1995 updated https://github.com/llvm/llvm-project/pull/126671 >From 8367c38f7f04273e3ab2451351b6db8d3f7dbc0c Mon Sep 17 00:00:00 2001 From: Amit Pandey Date: Tue, 11 Feb 2025 08:06:21 +0530 Subject: [PATCH 1/3] Reapply "[Driver][ROCm][OpenMP] Fix default ockl linking

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-02-11 Thread Nick Sarnie via cfe-commits
@@ -96,6 +100,47 @@ the header file to conditionally make a function constexpr whenever the constant evaluation of the corresponding builtin (for example, ``std::fmax`` calls ``__builtin_fmax``) is supported in Clang. +``__has_target_builtin`` + +

[clang] [NFC][Clang] Use InstalledDir instead of Build config as anchor in test (PR #126770)

2025-02-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jinsong Ji (jsji) Changes Build config is optional in build config, use InstalledDir instead to avoid unexpected failures in different build config. --- Full diff: https://github.com/llvm/llvm-project/pull/126770.diff 1 Files Affected:

[clang] [NFC][Driver] Use InstalledDir instead of Build config as anchor in test (PR #126770)

2025-02-11 Thread Jinsong Ji via cfe-commits
https://github.com/jsji edited https://github.com/llvm/llvm-project/pull/126770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-linker-wrapper][lit] Fix SPIR-V ELF test when spirv-tools feature is available (PR #126756)

2025-02-11 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/126756 >From a758efe88d1e58a5b53dd7a4b7da6e174f645356 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Tue, 11 Feb 2025 07:57:11 -0800 Subject: [PATCH 1/2] [clang-linker-wrapper][lit] Fix SPIR-V ELF test when spirv-

[clang] [NFC][Driver] Use InstalledDir instead of Build config as anchor in test (PR #126770)

2025-02-11 Thread Jinsong Ji via cfe-commits
jsji wrote: Fixed in f574d8235371c4f28cad8e800d99bcb7ad579b7d https://github.com/llvm/llvm-project/pull/126770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Driver] Use InstalledDir instead of Build config as anchor in test (PR #126770)

2025-02-11 Thread Jinsong Ji via cfe-commits
https://github.com/jsji closed https://github.com/llvm/llvm-project/pull/126770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[HLSL] Implement the reflect HLSL function" (PR #125599)

2025-02-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: Deric Cheung (Icohedron) Changes This PR relands #122992. A reland was attempted before (#123853), but it [failed to pass the `sanitizer-aarch64-linux-bootstrap-hwasan` buildbot](https://github.com/llvm/llvm-project/pull/123853#issueco

[clang] [llvm] Reland "[HLSL] Implement the reflect HLSL function" (PR #125599)

2025-02-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-spir-v Author: Deric Cheung (Icohedron) Changes This PR relands #122992. A reland was attempted before (#123853), but it [failed to pass the `sanitizer-aarch64-linux-bootstrap-hwasan` buildbot](https://github.com/llvm/llvm-project/pull/123853#

[clang] [llvm] Reland "[HLSL] Implement the reflect HLSL function" (PR #125599)

2025-02-11 Thread Deric Cheung via cfe-commits
https://github.com/Icohedron ready_for_review https://github.com/llvm/llvm-project/pull/125599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[HLSL] Implement the reflect HLSL function" (PR #125599)

2025-02-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Deric Cheung (Icohedron) Changes This PR relands #122992. A reland was attempted before (#123853), but it [failed to pass the `sanitizer-aarch64-linux-bootstrap-hwasan` buildbot](https://github.com/llvm/llvm-project/pull/123853#iss

[clang] [llvm] Reland "[HLSL] Implement the reflect HLSL function" (PR #125599)

2025-02-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl @llvm/pr-subscribers-clang Author: Deric Cheung (Icohedron) Changes This PR relands #122992. A reland was attempted before (#123853), but it [failed to pass the `sanitizer-aarch64-linux-bootstrap-hwasan` buildbot](https://github.com/llvm/llvm-pro

[clang] [clang] Lower modf builtin using `llvm.modf` intrinsic (PR #126750)

2025-02-11 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue updated https://github.com/llvm/llvm-project/pull/126750 >From eee5bc815c4b6b7e5a18503959b2a2354d73058b Mon Sep 17 00:00:00 2001 From: Benjamin Maxwell Date: Tue, 11 Feb 2025 15:32:23 + Subject: [PATCH 1/2] [clang] Lower modf builtin using `llvm.modf` intrinsic Th

[clang] [NFC][Clang] Use InstalledDir instead of Build config as anchor in test (PR #126770)

2025-02-11 Thread Jinsong Ji via cfe-commits
https://github.com/jsji created https://github.com/llvm/llvm-project/pull/126770 Build config is optional in build config, use InstalledDir instead to avoid unexpected failures in different build config. >From d8367f6d54b62a94613d38c26c216cb81f2acdae Mon Sep 17 00:00:00 2001 From: Jinsong Ji D

[clang] 71478ec - [WebKit Checkers] Treat const Objective-C ivar as a safe origin (#126353)

2025-02-11 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2025-02-11T10:00:09-08:00 New Revision: 71478ecdb48075051e6e746c4c51b9caeb4c21b6 URL: https://github.com/llvm/llvm-project/commit/71478ecdb48075051e6e746c4c51b9caeb4c21b6 DIFF: https://github.com/llvm/llvm-project/commit/71478ecdb48075051e6e746c4c51b9caeb4c21b6.diff

[clang] [WebKit Checkers] Treat const Objective-C ivar as a safe origin (PR #126353)

2025-02-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/126353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Checkers] Treat const Objective-C ivar as a safe origin (PR #126353)

2025-02-11 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: Thank you for the review! https://github.com/llvm/llvm-project/pull/126353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Checkers] Treat const Objective-C ivar as a safe origin (PR #126353)

2025-02-11 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/126353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Lower modf builtin using `llvm.modf` intrinsic (PR #126750)

2025-02-11 Thread Benjamin Maxwell via cfe-commits
@@ -859,6 +859,24 @@ static void emitSincosBuiltin(CodeGenFunction &CGF, const CallExpr *E, StoreCos->setMetadata(LLVMContext::MD_noalias, AliasScopeList); } +static llvm::Value *emitModfBuiltin(CodeGenFunction &CGF, const CallExpr *E, +l

[clang] [llvm] Reland "[HLSL] Implement the reflect HLSL function" (PR #125599)

2025-02-11 Thread Deric Cheung via cfe-commits
Icohedron wrote: To get the PR up and running, I am just marking hwasan as unsupported for now. A proper fix will be implemented later. The Issue #124045 will remain open to track this. https://github.com/llvm/llvm-project/pull/125599 ___ cfe-commits

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

2025-02-11 Thread via cfe-commits
mydeveloperday wrote: closed due to inactivity https://github.com/llvm/llvm-project/pull/69859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

2025-02-11 Thread via cfe-commits
https://github.com/mydeveloperday closed https://github.com/llvm/llvm-project/pull/69859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

2025-02-11 Thread via cfe-commits
https://github.com/mydeveloperday closed https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[analyzer] Remove some false negatives in StackAddrEscapeChec… (PR #126614)

2025-02-11 Thread Balazs Benics via cfe-commits
steakhal wrote: Usually revert should have a link to the logs of an example build bot failure. https://github.com/llvm/llvm-project/pull/126614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[libclc] [libclc] Move conversion builtins to the CLC library (PR #124727)

2025-02-11 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/124727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP."… (PR #126671)

2025-02-11 Thread Amit Kumar Pandey via cfe-commits
@@ -1014,17 +1014,20 @@ RocmInstallationDetector::getCommonBitcodeLibs( bool isOpenMP = false) const { llvm::SmallVector BCLibs; - auto GPUSanEnabled = [GPUSan]() { return std::get(GPUSan); }; + // GPU Sanitizer currently only supports ASan and is enabled through host

[clang] Reapply "[Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP."… (PR #126671)

2025-02-11 Thread Amit Kumar Pandey via cfe-commits
https://github.com/ampandey-1995 edited https://github.com/llvm/llvm-project/pull/126671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][docs] Document how to use perf and uftrace to debug performance issues (PR #126520)

2025-02-11 Thread Balazs Benics via cfe-commits
https://github.com/steakhal commented: Sorry about the noise of "closed PRs" due to the removal of my repo. I had difficulties with Github that made me try different solutions to solve that. In any case, I fixed all the review comments. Thanks for the excellent recommendations! https://github.

[clang] [analyzer][docs] Document how to use perf and uftrace to debug performance issues (PR #126520)

2025-02-11 Thread Balazs Benics via cfe-commits
@@ -45,3 +48,91 @@ Note: Both Chrome-tracing and speedscope tools might struggle with time traces a Luckily, in most cases the default max-steps boundary of 225 000 produces the traces of approximately that size for a single entry point. You can use ``-analyze-function=get_gl

[clang] [analyzer][docs] Document how to use perf and uftrace to debug performance issues (PR #126520)

2025-02-11 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/126520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][docs] Document how to use perf and uftrace to debug performance issues (PR #126520)

2025-02-11 Thread Balazs Benics via cfe-commits
@@ -45,3 +48,91 @@ Note: Both Chrome-tracing and speedscope tools might struggle with time traces a Luckily, in most cases the default max-steps boundary of 225 000 produces the traces of approximately that size for a single entry point. You can use ``-analyze-function=get_gl

[clang] [analyzer][docs] Document how to use perf and uftrace to debug performance issues (PR #126520)

2025-02-11 Thread Balazs Benics via cfe-commits
@@ -45,3 +48,91 @@ Note: Both Chrome-tracing and speedscope tools might struggle with time traces a Luckily, in most cases the default max-steps boundary of 225 000 produces the traces of approximately that size for a single entry point. You can use ``-analyze-function=get_gl

[clang] [analyzer][docs] Document how to use perf and uftrace to debug performance issues (PR #126520)

2025-02-11 Thread Balazs Benics via cfe-commits
@@ -45,3 +48,91 @@ Note: Both Chrome-tracing and speedscope tools might struggle with time traces a Luckily, in most cases the default max-steps boundary of 225 000 produces the traces of approximately that size for a single entry point. You can use ``-analyze-function=get_gl

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-02-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Only some tiny nits from me https://github.com/llvm/llvm-project/pull/126324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-02-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/126324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-02-11 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,27 @@ +// RUN: %clang_cc1 -fopenmp -triple=spirv64 -fopenmp-is-target-device \ +// RUN: -aux-triple x86_64-linux-unknown -E %s | FileCheck -implicit-check-not="{{BAD|DOESNT}}" %s + +// RUN: %clang_cc1 -fopenmp -triple=nvptx64 -fopenmp-is-target-device \ +// RUN: -aux-t

<    1   2   3   4   5   >