https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/121854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Brian Foley
Date: 2025-02-03T19:57:37+01:00
New Revision: 39879e4f4022d2845de14810532f633e553fa650
URL:
https://github.com/llvm/llvm-project/commit/39879e4f4022d2845de14810532f633e553fa650
DIFF:
https://github.com/llvm/llvm-project/commit/39879e4f4022d2845de14810532f633e553fa650.diff
L
github-actions[bot] wrote:
@bpfoley Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
@@ -1058,8 +1061,10 @@ namespace cwg62 { // cwg62: 2.9
// cxx98-error@-1 {{template argument uses local type }}
get();
// cxx98-error@-1 {{template argument uses local type }}
+// cxx98-note@-2 {{while substituting explicitly-specified template
arguments}}
@@ -1386,6 +1386,7 @@ namespace cwg488 { // cwg488: 2.9 c++11
enum E { e };
f(e);
// cxx98-error@-1 {{template argument uses local type 'E'}}
+// cxx98-note@-2 {{while substituting deduced template arguments}}
Endilll wrote:
```suggestion
/
@@ -1058,8 +1061,10 @@ namespace cwg62 { // cwg62: 2.9
// cxx98-error@-1 {{template argument uses local type }}
get();
// cxx98-error@-1 {{template argument uses local type }}
+// cxx98-note@-2 {{while substituting explicitly-specified template
arguments}}
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/125453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll commented:
Changes to C++ DR tests look good otherwise.
https://github.com/llvm/llvm-project/pull/125453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/malavikasamak created
https://github.com/llvm/llvm-project/pull/125483
Add more tests, where the index of the const array access evaluates to a
constant and depends on a template argument.
rdar://143759014
>From 12dc35b91a805c75017d58d400082d2a8959ee31 Mon Sep 17 00:00:00 2
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
@llvm/pr-subscribers-clang
Author: Donát Nagy (NagyDonat)
Changes
This commit adds the new analyzer option `assume-one-iteration`, which is
`false` by default, but can be set to `true` to ensure that the analyzer always
assumes
https://github.com/NagyDonat created
https://github.com/llvm/llvm-project/pull/125494
This commit adds the new analyzer option `assume-one-iteration`, which is
`false` by default, but can be set to `true` to ensure that the analyzer always
assumes (at least) one iteration in loops.
In some si
@@ -2525,8 +2525,11 @@ void TextNodeDumper::VisitCXXRecordDecl(const
CXXRecordDecl *D) {
OS << " instantiated_from";
dumpPointer(Instance);
}
- if (const auto *CTSD = dyn_cast(D))
+ if (const auto *CTSD = dyn_cast(D)) {
dumpTemplateSpecializationKind(CTSD->get
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cdeeb390a9ea21540fc44ba10dede66fbc0b2fc8
e6648ffc578b6c878ffcab494d6c5f11c775053d --e
obiwac wrote:
Ping
https://github.com/llvm/llvm-project/pull/123252
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -21,6 +21,7 @@
#include "clang/AST/Type.h"
#include "clang/AST/TypeLoc.h"
#include "clang/Basic/Builtins.h"
+#include "clang/Basic/DiagnosticParse.h"
inbelic wrote:
```suggestion
```
https://github.com/llvm/llvm-project/pull/125319
@@ -19105,6 +19105,51 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned
BuiltinID,
return nullptr;
switch (BuiltinID) {
+ case Builtin::BI__builtin_hlsl_adduint64: {
inbelic wrote:
I suppose I know why we weren't able to re-use the `__builtin_ad
@@ -2214,6 +2227,42 @@ static bool CheckResourceHandle(
// returning an ExprError
bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall)
{
switch (BuiltinID) {
+ case Builtin::BI__builtin_hlsl_adduint64: {
+if (SemaRef.checkArgCount(TheCall, 2))
@@ -2023,6 +2024,18 @@ static bool CheckAllArgsHaveFloatRepresentation(Sema *S,
CallExpr *TheCall) {
checkAllFloatTypes);
}
+static bool CheckUnsignedIntegerRepresentation(Sema *S, CallExpr *TheCall) {
+ auto checkUnsignedInteger = [](clan
@@ -19105,6 +19105,51 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned
BuiltinID,
return nullptr;
switch (BuiltinID) {
+ case Builtin::BI__builtin_hlsl_adduint64: {
inbelic wrote:
Ah, I see that you have it in the commit notes. I still think it
@@ -0,0 +1,46 @@
+// RUN: %clang_cc1 -finclude-default-header -triple
dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only
-disable-llvm-passes -verify
+
+uint2 test_too_few_arg() {
+ return __builtin_hlsl_adduint64();
+ // expected-error@-1 {{too few arguments
@@ -230,6 +230,14 @@ static StructType *getSplitDoubleType(LLVMContext
&Context) {
return StructType::create({Int32Ty, Int32Ty}, "dx.types.splitdouble");
}
+static StructType *getBinaryWithCarryType(LLVMContext &Context) {
inbelic wrote:
This is maybe some
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/125319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -359,18 +359,21 @@ class OpLowerer {
return lowerToBindAndAnnotateHandle(F);
}
- Error replaceSplitDoubleCallUsages(CallInst *Intrin, CallInst *Op) {
+ Error replaceExtractElementTypeOfCallUsages(CallInst *Intrin, CallInst *Op) {
for (Use &U : make_early_inc_ra
@@ -0,0 +1,46 @@
+// RUN: %clang_cc1 -finclude-default-header -triple
dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only
-disable-llvm-passes -verify
+
+uint2 test_too_few_arg() {
+ return __builtin_hlsl_adduint64();
+ // expected-error@-1 {{too few arguments
https://github.com/inbelic commented:
I would like to see if there is another reviewer has a suggestion of how we
could re-use the built-in
https://github.com/llvm/llvm-project/pull/125319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
@@ -0,0 +1,17 @@
+; RUN: not opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library %s
2>&1 | FileCheck %s
+
+; DXIL operation UAddc only supports i32. Other integer types are unsupported.
+; CHECK: in function uaddc_i16
inbelic wrote:
nit: I think LLVM E
higher-performance wrote:
I think we should heavily consider the wider solution space before going with
this proposal. The problem we will quickly hit here is that we need to be sure
that whatever we want can actually be expressed as a condition in the cases we
want. That's not currently the c
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
MaskRay wrote:
I just noticed that non-arm architectures have a `HAVE_LINKER_FLAG_LONG_PLT`
check. This is an arm ELF specific option in GNU ld (ignored by lld). You could
keep the previous architecture == ARM check so that other machines d
zmodem wrote:
Looks like some buildbots are unhappy. I'll back it out for now.
https://github.com/llvm/llvm-project/pull/117622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Hans Wennborg
Date: 2025-02-03T13:56:46+01:00
New Revision: cdeeb390a9ea21540fc44ba10dede66fbc0b2fc8
URL:
https://github.com/llvm/llvm-project/commit/cdeeb390a9ea21540fc44ba10dede66fbc0b2fc8
DIFF:
https://github.com/llvm/llvm-project/commit/cdeeb390a9ea21540fc44ba10dede66fbc0b2fc8.diff
steakhal wrote:
Overall I had a quick look and nothing sticks out, but the devil is in the
details, right?
So I plan to allocate some quality time to review this PR this week.
Thanks for the PR!
https://github.com/llvm/llvm-project/pull/125494
___
cf
https://github.com/FantasqueX updated
https://github.com/llvm/llvm-project/pull/124315
>From 63ba8cc83e68cf649a4f930e4dc8ce867240406a Mon Sep 17 00:00:00 2001
From: Letu Ren
Date: Sat, 25 Jan 2025 01:23:52 +0800
Subject: [PATCH 1/2] [Sema] Add code completion for if constexpr
C++17 supports `i
zmodem wrote:
We're hitting an assert after this:
```
clang/lib/Analysis/CFG.cpp:822: void (anonymous
namespace)::CFGBuilder::appendStmt(CFGBlock *, const Stmt *): Assertion
`!isa(S) || cast(S)->IgnoreParens() == S' failed.
```
See https://crbug.com/394015869 for stack trace and reproducer. I
davidtrevelyan wrote:
@devnexen in principle, I'm of course not opposed to rtsan supporting FreeBSD -
is there any motivation in particular for why you propose adding it here? Is
this the first of many patches that are needed, or is it the only one that you
can foresee? I'd like to make sure t
@@ -294,6 +294,16 @@ ANALYZER_OPTION(
bool, ShouldUnrollLoops, "unroll-loops",
"Whether the analysis should try to unroll loops with known bounds.",
false)
+ANALYZER_OPTION(
+bool, ShouldAssumeOneIteration, "assume-one-iteration",
+"Whether the analyzer should
@@ -605,6 +605,10 @@ HANDLE_DW_AT(0x3b28, BORLAND_Delphi_ABI, 0, BORLAND)
HANDLE_DW_AT(0x3b29, BORLAND_Delphi_return, 0, BORLAND)
HANDLE_DW_AT(0x3b30, BORLAND_Delphi_frameptr, 0, BORLAND)
HANDLE_DW_AT(0x3b31, BORLAND_closure, 0, BORLAND)
+
+// Rust extensions.
+HANDLE_DW_AT(0x3
Author: Hans Wennborg
Date: 2025-02-03T15:52:04+01:00
New Revision: 90e0dd15ff070b5b4b1bb068cdade7f5b5e6ccec
URL:
https://github.com/llvm/llvm-project/commit/90e0dd15ff070b5b4b1bb068cdade7f5b5e6ccec
DIFF:
https://github.com/llvm/llvm-project/commit/90e0dd15ff070b5b4b1bb068cdade7f5b5e6ccec.diff
https://github.com/erichkeane approved this pull request.
I think the 'strict patch match' is valuable in the AST since the paper
introduces it as a term of art. I hate our ast-print formats at times, but
this is fine to me.
https://github.com/llvm/llvm-project/pull/125372
___
@@ -2525,8 +2525,11 @@ void TextNodeDumper::VisitCXXRecordDecl(const
CXXRecordDecl *D) {
OS << " instantiated_from";
dumpPointer(Instance);
}
- if (const auto *CTSD = dyn_cast(D))
+ if (const auto *CTSD = dyn_cast(D)) {
dumpTemplateSpecializationKind(CTSD->get
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/125372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Fraser Cormack
Date: 2025-02-03T17:50:42Z
New Revision: fe694b18dc518b86eae9aab85ff03abc54e1662f
URL:
https://github.com/llvm/llvm-project/commit/fe694b18dc518b86eae9aab85ff03abc54e1662f
DIFF:
https://github.com/llvm/llvm-project/commit/fe694b18dc518b86eae9aab85ff03abc54e1662f.diff
LOG
bogner wrote:
Sharing the code here makes sense to me, however, this does make the pass run
significantly earlier in the DXIL pipeline. That might be fine but we'll have
to make sure we aren't creating dead functions in any of the other DXIL backend
passes that might have been cleaned up by th
@@ -2016,8 +2016,9 @@ TypeInfo ASTContext::getTypeInfoImpl(const Type *T) const
{
case Type::Vector: {
const auto *VT = cast(T);
TypeInfo EltInfo = getTypeInfo(VT->getElementType());
-Width = VT->isExtVectorBoolType() ? VT->getNumElements()
-
https://github.com/frasercrmck closed
https://github.com/llvm/llvm-project/pull/125517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
firewave wrote:
Performance looks good. Everything under 5% is acceptable.
The top three entries should probably get tickets so they get looked into. The
amount seems too much for what it actually provides.
https://github.com/llvm/llvm-project/pull/125420
__
@@ -0,0 +1,473 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -22,16 +35,164 @@ using namespace llvm;
namespace cir {
namespace direct {
+// This pass requires the CIR to be in a "flat" state. All blocks in each
+// function must belong to the parent region. Once scopes and control flow
+// are implemented in CIR, a pass will be run b
@@ -22,16 +35,164 @@ using namespace llvm;
namespace cir {
namespace direct {
+// This pass requires the CIR to be in a "flat" state. All blocks in each
+// function must belong to the parent region. Once scopes and control flow
+// are implemented in CIR, a pass will be run b
@@ -498,12 +498,17 @@ Expected clang(ArrayRef InputFiles,
const ArgList &Args) {
};
// Forward all of the `--offload-opt` and similar options to the device.
- CmdArgs.push_back("-flto");
for (auto &Arg : Args.filtered(OPT_offload_opt_eq_minus, OPT_mllvm))
CmdArgs
https://github.com/jchlanda approved this pull request.
https://github.com/llvm/llvm-project/pull/125243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/omarahmed updated
https://github.com/llvm/llvm-project/pull/125243
>From f3d466bffc2113b54d62e9a45370c643800b218c Mon Sep 17 00:00:00 2001
From: omarahmed
Date: Fri, 31 Jan 2025 15:42:11 +
Subject: [PATCH] Pass -offload-lto instead of -lto for cuda/hip kernels
--
@@ -498,12 +498,17 @@ Expected clang(ArrayRef InputFiles,
const ArgList &Args) {
};
// Forward all of the `--offload-opt` and similar options to the device.
- CmdArgs.push_back("-flto");
for (auto &Arg : Args.filtered(OPT_offload_opt_eq_minus, OPT_mllvm))
CmdArgs
NagyDonat wrote:
By the way is the "NFC" tag justified for this "add an off-by-default option"
commit? I used this because e.g. if somebody is looking for a bug, they can
safely skip this commit -- but OTOH this _does_ add a new feature.
https://github.com/llvm/llvm-project/pull/125494
___
https://github.com/mydeveloperday approved this pull request.
Thank you
https://github.com/llvm/llvm-project/pull/125327
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
Thanks
https://github.com/llvm/llvm-project/pull/125478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -498,12 +498,16 @@ Expected clang(ArrayRef InputFiles,
const ArgList &Args) {
};
// Forward all of the `--offload-opt` and similar options to the device.
- CmdArgs.push_back("-flto");
for (auto &Arg : Args.filtered(OPT_offload_opt_eq_minus, OPT_mllvm))
CmdArgs
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/125516
None
>From c5932a0673b96eb250aa7740dc54f2985a700359 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Mon, 3 Feb 2025 16:17:35 +0100
Subject: [PATCH] [clang][bytecode] Handle union move assign
@@ -1115,14 +1117,13 @@ def fno_convergent_functions : Flag<["-"],
"fno-convergent-functions">,
// Common offloading options
let Group = offload_Group in {
-def offload_arch_EQ : Joined<["--"], "offload-arch=">, Flags<[NoXarchOption]>,
yxsamliu wrote:
For HI
Author: Artem Belevich
Date: 2025-02-03T10:27:11-08:00
New Revision: db60244519023a2b083caa3ed3a27a6b59eb03d8
URL:
https://github.com/llvm/llvm-project/commit/db60244519023a2b083caa3ed3a27a6b59eb03d8
DIFF:
https://github.com/llvm/llvm-project/commit/db60244519023a2b083caa3ed3a27a6b59eb03d8.diff
https://github.com/Artem-B closed
https://github.com/llvm/llvm-project/pull/125127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Malavika Samak (malavikasamak)
Changes
Add more tests, where the index of the const array access evaluates to a
constant and depends on a template argument.
rdar://143759014
---
Full diff: https://github.com/llvm/llvm-project/pull/125483
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/125403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ivanaivanovska closed
https://github.com/llvm/llvm-project/pull/124554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win`
running on `sie-win-worker` while building `clang` at step 7
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/46/builds/11501
Here is th
@@ -1909,7 +1909,19 @@ class Sema final : public SemaBase {
/// '\#pragma clang attribute push' directives to the given declaration.
void AddPragmaAttributes(Scope *S, Decl *D);
- void PrintPragmaAttributeInstantiationPoint();
+ using DiagFuncRef =
+ llvm::function_
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/125453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1909,7 +1909,19 @@ class Sema final : public SemaBase {
/// '\#pragma clang attribute push' directives to the given declaration.
void AddPragmaAttributes(Scope *S, Decl *D);
- void PrintPragmaAttributeInstantiationPoint();
+ using DiagFuncRef =
+ llvm::function_
https://github.com/erichkeane commented:
Share some of Corentin's concerns, else just a few comments.
https://github.com/llvm/llvm-project/pull/125453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/NagyDonat created
https://github.com/llvm/llvm-project/pull/125534
Before this commit, there were two alpha checkers that used different
algorithms/logic for detecting out of bounds memory access: the old
`alpha.security.ArrayBound` and the experimental, more complex
`alpha
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Donát Nagy (NagyDonat)
Changes
Before this commit, there were two alpha checkers that used different
algorithms/logic for detecting out of bounds memory access: the old
`alpha.security.ArrayBou
steakhal wrote:
> > Could you please run this with `--enable-check-profile` to see how heavy it
> > is?
>
> I plan to re-run it on clang soon, and share the results.
I've picked a heavy TU of clang for the test: `clang/lib/Sema/SemaExpr.cpp`
```
===
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/125420
>From 78390b2af01fcd5acfbd2a313852962c873e5611 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Sun, 2 Feb 2025 17:35:39 +0100
Subject: [PATCH 1/8] [clang-tidy] Add performance-redundant-lookup check
Finds r
@@ -0,0 +1,147 @@
+.. title:: clang-tidy - performance-redundant-lookup
+
+performance-redundant-lookup
+
+
+This check warns about potential redundant container lookup operations within
steakhal wrote:
Fixed in d9d3984a056192b8ef61f38
@@ -22,16 +35,164 @@ using namespace llvm;
namespace cir {
namespace direct {
+// This pass requires the CIR to be in a "flat" state. All blocks in each
+// function must belong to the parent region. Once scopes and control flow
+// are implemented in CIR, a pass will be run b
@@ -91,6 +91,12 @@ Improvements to clang-tidy
New checks
^^
+- New :doc:`performance-redundant-lookup
+ ` check.
+
+ This check warns about potential redundant container lookup operations within
EugeneZelenko wrote:
`This check` should be omitted.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ivana Ivanovska (ivanaivanovska)
Changes
The Clang disgnostic `-Wunsafe-buffer-usage` was adding up to +15% compilation
time when used. Profiling showed that most of the overhead comes from the use
of ASTMatchers.
This change replaces th
@@ -740,6 +740,24 @@ bool hasDeclaredDeductionGuides(DeclarationName Name,
DeclContext *DC) {
return false;
}
+// Returns all source deduction guides associated with the declared
+// deduction guides that have the specified deduction guide name.
+llvm::DenseSet getSourceDed
@@ -1191,13 +1209,10 @@ void DeclareImplicitDeductionGuidesForTypeAlias(
if (AliasTemplate->isInvalidDecl())
return;
auto &Context = SemaRef.Context;
- // FIXME: if there is an explicit deduction guide after the first use of the
- // type alias usage, we will not cove
https://github.com/hokein edited
https://github.com/llvm/llvm-project/pull/125478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ivanaivanovska ready_for_review
https://github.com/llvm/llvm-project/pull/125492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/125478
>From 62328c6ab0c9965712aea1d484fca4afa1294acd Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Mon, 3 Feb 2025 11:55:17 +0100
Subject: [PATCH 1/2] [clang] CTAD alias: Respecte explicit deduction guides
defined a
Author: Devon Loehr
Date: 2025-02-03T13:20:52+01:00
New Revision: d5684b8402d2175e80a2792db58e9a8e960a8544
URL:
https://github.com/llvm/llvm-project/commit/d5684b8402d2175e80a2792db58e9a8e960a8544
DIFF:
https://github.com/llvm/llvm-project/commit/d5684b8402d2175e80a2792db58e9a8e960a8544.diff
L
github-actions[bot] wrote:
@DKLoehr Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
https://github.com/zmodem closed
https://github.com/llvm/llvm-project/pull/117622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ivanaivanovska created
https://github.com/llvm/llvm-project/pull/125492
None
>From 54c7b3c1fb149b82c26927d0fd831d8786f70ac3 Mon Sep 17 00:00:00 2001
From: Ivana Ivanovska
Date: Mon, 2 Dec 2024 14:17:06 +
Subject: [PATCH] Optimize -Wunsafe-buffer-usage.
---
clang/lib/An
@@ -1106,8 +1106,12 @@ bool AMDGPUToolChain::shouldSkipSanitizeOption(
// For simplicity, we only allow -fsanitize=address
SanitizerMask K = parseSanitizerValue(A->getValue(), /*AllowGroups=*/false);
- if (K != SanitizerKind::Address)
+ if (K != SanitizerKind::Address) {
@@ -71,10 +71,10 @@ llvm::opt::DerivedArgList
*AMDGPUOpenMPToolChain::TranslateArgs(
const OptTable &Opts = getDriver().getOpts();
- for (Arg *A : Args) {
-if (!llvm::is_contained(*DAL, A))
+ for (Arg *A : Args)
+if (!shouldSkipSanitizeOption(*this, Args, BoundAr
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/124754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1596,12 +1596,14 @@ QualType Sema::BuildQualifiedType(QualType T,
SourceLocation Loc,
QualType ProblemTy;
if (T->isAnyPointerType() || T->isReferenceType() ||
-T->isMemberPointerType()) {
+T->isMemberPointerType() || T->isArrayType()) {
Qual
@@ -9,20 +9,20 @@ typedef int (*T)[2];
restrict T x;
typedef int *S[2];
-restrict S y; // expected-error {{restrict requires a pointer or reference
('S' (aka 'int *[2]') is invalid)}}
-
-
+restrict S y;
a-tarasyuk wrote:
@AaronBallman thanks for the feedback
w2yehia wrote:
I believe all comments have been addressed.
friendly ping.
@petrhosek any feedback please?
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/Xazax-hun edited
https://github.com/llvm/llvm-project/pull/125508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun commented:
I haven't finished reviewing yet but some nits inline.
https://github.com/llvm/llvm-project/pull/125508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
@@ -287,6 +288,35 @@ class PathDiagnosticBuilder : public BugReporterContext {
const PathSensitiveBugReport *getBugReport() const { return R; }
};
+std::string timeTraceName(const BugReportEquivClass &EQ) {
+ if (!llvm::timeTraceProfilerEnabled()) {
Xazax-h
@@ -49,6 +49,127 @@ LLVM_DUMP_METHOD void ProgramPoint::dump() const {
return printJson(llvm::errs());
}
+const char *ProgramPoint::kindToStr(Kind K) {
Xazax-hun wrote:
Should this return a `StringRef` instead?
https://github.com/llvm/llvm-project/pull/125
@@ -49,6 +49,127 @@ LLVM_DUMP_METHOD void ProgramPoint::dump() const {
return printJson(llvm::errs());
}
+const char *ProgramPoint::kindToStr(Kind K) {
+ switch (K) {
+ case BlockEdgeKind:
+return "BlockEdge";
+ case BlockEntranceKind:
+return "BlockEntrance";
+
bpfoley wrote:
Could you please merge this for me? I don't have merge permissions.
https://github.com/llvm/llvm-project/pull/121854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -49,6 +49,127 @@ LLVM_DUMP_METHOD void ProgramPoint::dump() const {
return printJson(llvm::errs());
}
+const char *ProgramPoint::kindToStr(Kind K) {
+ switch (K) {
+ case BlockEdgeKind:
+return "BlockEdge";
+ case BlockEntranceKind:
+return "BlockEntrance";
+
@@ -49,6 +49,127 @@ LLVM_DUMP_METHOD void ProgramPoint::dump() const {
return printJson(llvm::errs());
}
+const char *ProgramPoint::kindToStr(Kind K) {
Xazax-hun wrote:
Based on the similar methods in `Decl` and `Stmt` the naming convention should
be somet
@@ -0,0 +1,38 @@
+=
+Performance Investigation
+=
+
+Multiple factors contribute to the time it takes to analyze a file with Clang
Static Analyzer.
+A translation unit contains multiple entry points, each of which take multiple
ste
301 - 400 of 472 matches
Mail list logo