[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Andy Kaylor via cfe-commits
@@ -22,13 +34,127 @@ using namespace llvm; namespace cir { namespace direct { +struct ConvertCIRToLLVMPass +: public mlir::PassWrapper> { + void getDependentDialects(mlir::DialectRegistry ®istry) const override { +registry.insert(); + } + void runOnOperation() final

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Andy Kaylor via cfe-commits
@@ -22,13 +34,127 @@ using namespace llvm; namespace cir { namespace direct { +struct ConvertCIRToLLVMPass +: public mlir::PassWrapper> { + void getDependentDialects(mlir::DialectRegistry ®istry) const override { +registry.insert(); + } + void runOnOperation() final

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Andy Kaylor via cfe-commits
@@ -22,13 +34,127 @@ using namespace llvm; namespace cir { namespace direct { +struct ConvertCIRToLLVMPass +: public mlir::PassWrapper> { + void getDependentDialects(mlir::DialectRegistry ®istry) const override { +registry.insert(); + } + void runOnOperation() final

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Erich Keane via cfe-commits
@@ -22,13 +34,127 @@ using namespace llvm; namespace cir { namespace direct { +struct ConvertCIRToLLVMPass +: public mlir::PassWrapper> { + void getDependentDialects(mlir::DialectRegistry ®istry) const override { +registry.insert(); + } + void runOnOperation() final

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Erich Keane via cfe-commits
@@ -1,8 +1,10 @@ // Smoke test for ClangIR-to-LLVM IR code generation // RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-llvm %s -o - | FileCheck %s -// TODO: Add checks when proper lowering is implemented. -// For now, we're just creating an empty mod

[clang] Reland: [clang] Track function template instantiation from definition (PR #125266)

2025-01-31 Thread Matheus Izvekov via cfe-commits
@@ -5276,9 +5277,31 @@ void Sema::InstantiateFunctionDefinition(SourceLocation PointOfInstantiation, RebuildTypeSourceInfoForDefaultSpecialMembers(); SetDeclDefaulted(Function, PatternDecl->getLocation()); } else { +NamedDecl *ND = Function; +DeclContext *DC

[clang] [PCH, CUDA] Take CUDA attributes into account (PR #125127)

2025-01-31 Thread Artem Belevich via cfe-commits
@@ -14,12 +16,19 @@ void kcall(void (*kp)()) { __global__ void kern() { } +__host__ int overloaded_func(); Artem-B wrote: Done https://github.com/llvm/llvm-project/pull/125127 ___ cfe-commits mailing list cfe-commi

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Andy Kaylor via cfe-commits
@@ -31,6 +33,24 @@ namespace direct { std::unique_ptr lowerDirectlyFromCIRToLLVMIR(mlir::ModuleOp mlirModule, llvm::LLVMContext &llvmCtx); + +class CIRToLLVMGlobalOpLowering +: public mlir::OpConversionPattern { + mlir::DataLayout const &dataLa

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Erich Keane via cfe-commits
@@ -22,13 +34,127 @@ using namespace llvm; namespace cir { namespace direct { +struct ConvertCIRToLLVMPass +: public mlir::PassWrapper> { + void getDependentDialects(mlir::DialectRegistry ®istry) const override { +registry.insert(); + } + void runOnOperation() final

[clang] [PCH, CUDA] Take CUDA attributes into account (PR #125127)

2025-01-31 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B updated https://github.com/llvm/llvm-project/pull/125127 >From d6ff7dc3dcc5ca677a811888f5e67cc5aaad9d8f Mon Sep 17 00:00:00 2001 From: Artem Belevich Date: Thu, 30 Jan 2025 14:30:22 -0800 Subject: [PATCH 1/3] [PCH, CUDA] Take CUDA attributes into account During deser

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Erich Keane via cfe-commits
@@ -31,6 +33,24 @@ namespace direct { std::unique_ptr lowerDirectlyFromCIRToLLVMIR(mlir::ModuleOp mlirModule, llvm::LLVMContext &llvmCtx); + +class CIRToLLVMGlobalOpLowering +: public mlir::OpConversionPattern { + mlir::DataLayout const &dataLa

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Andy Kaylor via cfe-commits
@@ -1,8 +1,10 @@ // Smoke test for ClangIR-to-LLVM IR code generation // RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-llvm %s -o - | FileCheck %s -// TODO: Add checks when proper lowering is implemented. -// For now, we're just creating an empty mod

[clang] [compiler-rt] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2025-01-31 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: rebase https://github.com/llvm/llvm-project/pull/109164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Simplify and eliminate redundant map lookups (PR #125272)

2025-01-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/125272 None >From 086be8a46407ae1d0e5f8f965858cb6a27b8c5d5 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Fri, 31 Jan 2025 20:26:45 +0100 Subject: [PATCH] [analyzer][NFC] Simplify and eliminate redundant map look

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Andy Kaylor via cfe-commits
@@ -1,8 +1,10 @@ // Smoke test for ClangIR-to-LLVM IR code generation // RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-llvm %s -o - | FileCheck %s -// TODO: Add checks when proper lowering is implemented. -// For now, we're just creating an empty mod

[clang] [SveEmitter] Explicitly merge with `poison` instead of `undef` (PR #124596)

2025-01-31 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: The architecture manual isn't really helpful here... the instruction set doesn't really have any notion of undefined values in this context; the operations in question are always "merging". The intrinsic allows omitting the destination register for convenience, in which c

[clang] Reland: [clang] Track function template instantiation from definition (PR #125266)

2025-01-31 Thread Matheus Izvekov via cfe-commits
@@ -5276,9 +5277,31 @@ void Sema::InstantiateFunctionDefinition(SourceLocation PointOfInstantiation, RebuildTypeSourceInfoForDefaultSpecialMembers(); SetDeclDefaulted(Function, PatternDecl->getLocation()); } else { +NamedDecl *ND = Function; +DeclContext *DC

[clang] [clang][dataflow][NFC] Remove double lookup (PR #125282)

2025-01-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/125282 None >From 35f531c01029576c090f00e0de1404250dea16d3 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Fri, 31 Jan 2025 21:09:12 +0100 Subject: [PATCH] [clang][dataflow][NFC] Remove double lookup --- clang/l

[clang] [clang][dataflow][NFC] Remove double lookup (PR #125282)

2025-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/125282.diff 1 Files Affected: - (modified) clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp (+3-2) ``diff diff --git a/cl

[clang] [clang][NFC] Simplify code in ExprMutationAnalyzer (PR #125283)

2025-01-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/125283 None >From b9544eb08f48c10d2ad16ce2ce9a8c9b84c2aaf5 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Fri, 31 Jan 2025 21:10:00 +0100 Subject: [PATCH] [clang][NFC] Simplify code in ExprMutationAnalyzer ---

[clang] [clang][mutation analyzer][NFC] Simplify code in ExprMutationAnalyzer (PR #125283)

2025-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: Balazs Benics (steakhal) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/125283.diff 1 Files Affected: - (modified) clang/lib/Analysis/ExprMutationAnalyzer.cpp (+1-4) ``diff diff --git a/clang/lib/A

[clang] [analyzer][NFC] Simplify and eliminate redundant map lookups (PR #125272)

2025-01-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/125272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9333d8f - [analyzer][NFC] Simplify and eliminate redundant map lookups (#125272)

2025-01-31 Thread via cfe-commits
Author: Balazs Benics Date: 2025-01-31T22:16:39+01:00 New Revision: 9333d8fb0749b1ae2b152a1003d2ecc00027b3d5 URL: https://github.com/llvm/llvm-project/commit/9333d8fb0749b1ae2b152a1003d2ecc00027b3d5 DIFF: https://github.com/llvm/llvm-project/commit/9333d8fb0749b1ae2b152a1003d2ecc00027b3d5.diff

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Erich Keane via cfe-commits
@@ -22,16 +34,156 @@ using namespace llvm; namespace cir { namespace direct { +struct ConvertCIRToLLVMPass +: public mlir::PassWrapper> { + void getDependentDialects(mlir::DialectRegistry ®istry) const override { +registry.insert(); + } + void runOnOperation() final

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Erich Keane via cfe-commits
@@ -22,16 +34,156 @@ using namespace llvm; namespace cir { namespace direct { +struct ConvertCIRToLLVMPass +: public mlir::PassWrapper> { + void getDependentDialects(mlir::DialectRegistry ®istry) const override { +registry.insert(); + } + void runOnOperation() final

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. LGTM, but Bruno has an open, and I would love more details to one of the comments (re-flat CIR) if it is a sensible request. https://github.com/llvm/llvm-project/pull/125260 ___ cfe-commits mai

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/125260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Erich Keane via cfe-commits
@@ -22,16 +34,156 @@ using namespace llvm; namespace cir { namespace direct { +struct ConvertCIRToLLVMPass +: public mlir::PassWrapper> { + void getDependentDialects(mlir::DialectRegistry ®istry) const override { +registry.insert(); + } + void runOnOperation() final

[clang] [Clang][counted_by] Refactor __builtin_dynamic_object_size on FAMs (PR #122198)

2025-01-31 Thread Bill Wendling via cfe-commits
bwendling wrote: I'll look into it. https://github.com/llvm/llvm-project/pull/122198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Do not support some values of branch-protection with ptrauth-returns (PR #125280)

2025-01-31 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 created https://github.com/llvm/llvm-project/pull/125280 This patch does two things. 1. Previously, when checking driver arguments, we emitted an error for unsupported values of `-mbranch-protection` when using pauthtest ABI. The reason for that was ptrauth-returns

[clang] [clang][mutation analyzer][NFC] Simplify code in ExprMutationAnalyzer (PR #125283)

2025-01-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/125283 >From b9544eb08f48c10d2ad16ce2ce9a8c9b84c2aaf5 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Fri, 31 Jan 2025 21:10:00 +0100 Subject: [PATCH 1/2] [clang][NFC] Simplify code in ExprMutationAnalyzer --- cl

[clang] [clang][mutation analyzer][NFC] Simplify code in ExprMutationAnalyzer (PR #125283)

2025-01-31 Thread Balazs Benics via cfe-commits
@@ -813,10 +813,7 @@ FunctionParmMutationAnalyzer::findMutation(const ParmVarDecl *Parm) { // before analyzing parameters of A. Then when analyzing the second "call A", // FunctionParmMutationAnalyzer can use this memoized value to avoid infinite // recursion. - Results

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Michael Buch via cfe-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( Michael137 wrote: Unless

[clang] [Clang][Driver] Declare win32 threads on Windows (PR #121442)

2025-01-31 Thread Mateusz Mikuła via cfe-commits
mati865 wrote: Guess this is not happening. https://github.com/llvm/llvm-project/pull/121442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Declare win32 threads on Windows (PR #121442)

2025-01-31 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 closed https://github.com/llvm/llvm-project/pull/121442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2025-01-31 Thread via cfe-commits
https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001 From: Leijurv Date: Fri, 29 Nov 2024 21:54:36 -0600 Subject: [PATCH 01/13] [clang-format] Add BreakBeforeTemplateClose option --- clang/d

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/125260 >From 4801886dd4c45d32891a7337ad7430a6c5137929 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Tue, 28 Jan 2025 12:28:58 -0800 Subject: [PATCH 1/4] [CIR] Initial implementation of CIR-to-LLVM IR lowering pa

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2025-01-31 Thread via cfe-commits
https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001 From: Leijurv Date: Fri, 29 Nov 2024 21:54:36 -0600 Subject: [PATCH 01/14] [clang-format] Add BreakBeforeTemplateClose option --- clang/d

[clang] Add clang atomic control options and attribute (PR #114841)

2025-01-31 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu edited https://github.com/llvm/llvm-project/pull/114841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Make memory representation of boolean vectors in HLSL, vectors of i32. Add support for boolean swizzling. (PR #123977)

2025-01-31 Thread Sarah Spall via cfe-commits
https://github.com/spall ready_for_review https://github.com/llvm/llvm-project/pull/123977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Fix assert when constexpr size passed to snprintf() (#119786) (PR #124022)

2025-01-31 Thread Thomas Sepez via cfe-commits
tsepez wrote: Ping https://github.com/llvm/llvm-project/pull/124022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [aarch64][x86][win] Add compiler support for MSVC's /funcoverride flag (Windows kernel loader replaceable functions) (PR #125320)

2025-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: Daniel Paoliello (dpaoliello) Changes Adds support for MSVC's undocumented `/funcoverride` flag, which marks functions as being replaceable by the Windows kernel loader. This is used to allow functions to be upgraded depending on the ca

[clang] [llvm] [aarch64][x86][win] Add compiler support for MSVC's /funcoverride flag (Windows kernel loader replaceable functions) (PR #125320)

2025-01-31 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello created https://github.com/llvm/llvm-project/pull/125320 Adds support for MSVC's undocumented `/funcoverride` flag, which marks functions as being replaceable by the Windows kernel loader. This is used to allow functions to be upgraded depending on the capabilitie

[clang] [CIR] Initial implementation of CIR-to-LLVM IR lowering pass (PR #125260)

2025-01-31 Thread Andy Kaylor via cfe-commits
@@ -22,16 +34,156 @@ using namespace llvm; namespace cir { namespace direct { +struct ConvertCIRToLLVMPass +: public mlir::PassWrapper> { + void getDependentDialects(mlir::DialectRegistry ®istry) const override { +registry.insert(); + } + void runOnOperation() final

[clang] [llvm] [aarch64][x86][win] Add compiler support for MSVC's /funcoverride flag (Windows kernel loader replaceable functions) (PR #125320)

2025-01-31 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/125320 >From 061d2521e8db70c591e9c0d8f2e6348120cb55c1 Mon Sep 17 00:00:00 2001 From: "Daniel Paoliello (HE/HIM)" Date: Fri, 31 Jan 2025 16:47:23 -0800 Subject: [PATCH] [aarch64][x86][win] Add support for MSVC's /fun

[clang] [clang][bytecode] Stack-allocate bottom function frame (PR #125253)

2025-01-31 Thread Jorge Gorbe Moya via cfe-commits
@@ -27,7 +27,7 @@ bool InterpState::inConstantContext() const { } InterpState::~InterpState() { - while (Current) { + while (Current && !Current->isBottomFrame()) { slackito wrote: This is causing use-after-destruction errors for me when running clang tests

[clang] [clang][bytecode] Stack-allocate bottom function frame (PR #125253)

2025-01-31 Thread Jorge Gorbe Moya via cfe-commits
slackito wrote: The problem described above also reproduced in one of the buildbots: https://lab.llvm.org/buildbot/#/builders/164/builds/6922/steps/17/logs/stdio I'll revert this patch. https://github.com/llvm/llvm-project/pull/125253 ___ cfe-commits

[clang] [clang-format] Fix a bug in annotating ClassHeadName (PR #125326)

2025-01-31 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/125326 None >From d2a9862cb4f88ebb92f0d5266ffd80aec51b8f04 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 31 Jan 2025 18:19:37 -0800 Subject: [PATCH] [clang-format] Fix a bug in annotating ClassHeadName --- clang

[clang] [clang-format] Hanlde qualified type names (PR #125327)

2025-01-31 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/125327 Fixes #125178. >From af3d964d74634f0dd9f7216572c1d852b7a549dc Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 31 Jan 2025 18:32:33 -0800 Subject: [PATCH] [clang-format] Hanlde qualified type names Fixes #125

[clang] [clang-format] Hanlde qualified type names (PR #125327)

2025-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #125178. --- Full diff: https://github.com/llvm/llvm-project/pull/125327.diff 2 Files Affected: - (modified) clang/lib/Format/QualifierAlignmentFixer.cpp (+7-1) - (modified) clang/unittests/Format

[clang] Revert "[clang][bytecode] Stack-allocate bottom function frame" (PR #125325)

2025-01-31 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito created https://github.com/llvm/llvm-project/pull/125325 Reverts llvm/llvm-project#125253 It introduced an msan failure. Caught by a buildbot here: https://lab.llvm.org/buildbot/#/builders/164/builds/6922/steps/17/logs/stdio >From e9ca5033e880f1f6e28692fb86c0b97a1b

[clang] Revert "[clang][bytecode] Stack-allocate bottom function frame" (PR #125325)

2025-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jorge Gorbe Moya (slackito) Changes Reverts llvm/llvm-project#125253 It introduced an msan failure. Caught by a buildbot here: https://lab.llvm.org/buildbot/#/builders/164/builds/6922/steps/17/logs/stdio --- Full diff: https://github.com

[clang] [Clang][counted_by] Don't treat a __bdos argument as an array if it isn't (PR #125298)

2025-01-31 Thread Nathan Chancellor via cfe-commits
@@ -0,0 +1,85 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple aarch64-unknown-linux-gnu -DCOUNTED_BY -O2 -Wall -Wno-int-conversion -fsanitize=array-bounds,object-size,local-bounds -fstrict-flex-

[clang] [clang-format] Fix a bug in annotating ClassHeadName (PR #125326)

2025-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/125326.diff 2 Files Affected: - (modified) clang/lib/Format/UnwrappedLineParser.cpp (+1-1) - (modified) clang/unittests/Format/TokenAnnotatorTes

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

2025-01-31 Thread via cfe-commits
GeorgeKA wrote: > Phew, first round in. Please don't take the number of suggestions as a > negative, the basic structure looks good there's just many small tweaks to be > made :). Thanks for all the comments @Maetveis . I worked my way through them, and this is ready for another look. The out

[clang] f73f5af - [Driver] Refactor option '-mlink-bitcode-file'. (#125322)

2025-01-31 Thread via cfe-commits
Author: Amit Kumar Pandey Date: 2025-02-01T08:15:37+05:30 New Revision: f73f5af442d5dfa762b69a82f0c2cdf8898b9060 URL: https://github.com/llvm/llvm-project/commit/f73f5af442d5dfa762b69a82f0c2cdf8898b9060 DIFF: https://github.com/llvm/llvm-project/commit/f73f5af442d5dfa762b69a82f0c2cdf8898b9060.d

[clang] [Driver] Refactor option '-mlink-bitcode-file'. (PR #125322)

2025-01-31 Thread Amit Kumar Pandey via cfe-commits
https://github.com/ampandey-1995 closed https://github.com/llvm/llvm-project/pull/125322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Hanlde qualified type name for `QualifierAlignment` (PR #125327)

2025-01-31 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/125327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Refactor option '-mlink-bitcode-file'. (PR #125322)

2025-01-31 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/15055 Here is the releva

[clang] 280609c - [clang-format][NFC] Minor improvement to FormatToken::isTypeName()

2025-01-31 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2025-01-31T18:52:53-08:00 New Revision: 280609c215e4a684cad215ea5be913293de0d255 URL: https://github.com/llvm/llvm-project/commit/280609c215e4a684cad215ea5be913293de0d255 DIFF: https://github.com/llvm/llvm-project/commit/280609c215e4a684cad215ea5be913293de0d255.diff LOG:

[clang] [clang][Sema] Emit warnings on incorrect AVR interrupt/signal handlers (PR #125328)

2025-01-31 Thread Ben Shi via cfe-commits
https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/125328 None >From 6f2fc35842a4a3647600da99342209bda4eb72f9 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 27 Jan 2025 13:04:45 +0800 Subject: [PATCH] [clang][Sema] Warning about incorrect AVR interrupt/signal ha

[clang] [clang][Sema] Emit warnings on incorrect AVR interrupt/signal handlers (PR #125328)

2025-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Ben Shi (benshi001) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/125328.diff 6 Files Affected: - (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+2-2) - (modified) clang/lib/Sema/SemaAVR.cpp (

[clang] [clang][Sema] Emit warnings on incorrect AVR interrupt/signal handlers (PR #125328)

2025-01-31 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/125328 >From 5ff3c98370a583d5619ba2a6ac5a605f87de7361 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 27 Jan 2025 13:04:45 +0800 Subject: [PATCH] [clang][Sema] Warning about incorrect AVR interrupt/signal handlers

[clang] [clang][Sema] Emit warnings on incorrect AVR interrupt/signal handlers (PR #125328)

2025-01-31 Thread Ben Shi via cfe-commits
benshi001 wrote: AVR interrupt/signal handlers must be `void` and has no argument. https://github.com/llvm/llvm-project/pull/125328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Emit warnings on incorrect AVR interrupt/signal handlers (PR #125328)

2025-01-31 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/125328 >From e9669133f46c409c4a5ee5cdd00cab2dc941a254 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 27 Jan 2025 13:04:45 +0800 Subject: [PATCH] [clang][Sema] Emit warnings about incorrect AVR interrupt/signal ha

[clang] [Feature]: support for the BC library file into the compile dependencies (PR #119513)

2025-01-31 Thread via cfe-commits
zhouronghua wrote: ping https://github.com/llvm/llvm-project/pull/119513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2025-01-31 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/117437 >From b5117efb5ec147a73e265023c5e3d6d9f2d750b7 Mon Sep 17 00:00:00 2001 From: yronglin Date: Sat, 1 Feb 2025 00:09:16 +0800 Subject: [PATCH 1/2] [Analyzer][CFG] Correctly handle rebuilt default arg and default

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2025-01-31 Thread via cfe-commits
@@ -5570,8 +5570,10 @@ ExprResult Sema::BuildCXXDefaultArgExpr(SourceLocation CallLoc, /*SkipImmediateInvocations=*/NestedDefaultChecking)) return ExprError(); + Expr *RewrittenExpr = Init == Param->getDefaultArg() ? nullptr : Init; yronglin wr

[clang] 386af4a - Revert "[clang][bytecode] Stack-allocate bottom function frame" (#125325)

2025-01-31 Thread via cfe-commits
Author: Jorge Gorbe Moya Date: 2025-01-31T20:09:14-08:00 New Revision: 386af4a5c64ab75eaee2448dc38f2e34a40bfed0 URL: https://github.com/llvm/llvm-project/commit/386af4a5c64ab75eaee2448dc38f2e34a40bfed0 DIFF: https://github.com/llvm/llvm-project/commit/386af4a5c64ab75eaee2448dc38f2e34a40bfed0.di

[clang] Revert "[clang][bytecode] Stack-allocate bottom function frame" (PR #125325)

2025-01-31 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito closed https://github.com/llvm/llvm-project/pull/125325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2025-01-31 Thread via cfe-commits
yronglin wrote: > I'm WAY happier with this. I don't have the ability to review the SA stuff > well enough to give an approval, but the rest of the stuff is good. 1 Nit, > else LGTM. Thanks for the review! There are no functional changes in Static Analyzer after @steakhal's +1 (just renamed a

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2025-01-31 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/117437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2025-01-31 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/117437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #125335)

2025-01-31 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/125335 Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Literal migration

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #125336)

2025-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Litera

[clang] [clang-format] Hanlde qualified type name for `QualifierAlignment` (PR #125327)

2025-01-31 Thread Owen Pan via cfe-commits
owenca wrote: > Seems to also work for top-level types (`::int_64_t constexpr x{123};` works > correctly) but breaks for fully qualified types (`::std::int64_t constexpr > x{123};` becomes `::constexpr std::int64_t x{123};`) Yeah, I intentionally didn't want to use a loop for names like `A1::A

[clang] [clang][bytecode] Stack-allocate bottom function frame (PR #125253)

2025-01-31 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Looks like from this patch https://lab.llvm.org/buildbot/#/builders/94/builds/4194/steps/17/logs/stdio https://github.com/llvm/llvm-project/pull/125253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 0d21ef4 - [clang][mutation analyzer][NFC] Simplify code in ExprMutationAnalyzer (#125283)

2025-01-31 Thread via cfe-commits
Author: Balazs Benics Date: 2025-02-01T08:20:47+01:00 New Revision: 0d21ef4e6c50c7d4d591adf7e6dbd6232e8a99c4 URL: https://github.com/llvm/llvm-project/commit/0d21ef4e6c50c7d4d591adf7e6dbd6232e8a99c4 DIFF: https://github.com/llvm/llvm-project/commit/0d21ef4e6c50c7d4d591adf7e6dbd6232e8a99c4.diff

[clang] d0a142e - [clang][dataflow][NFC] Remove double lookup (#125282)

2025-01-31 Thread via cfe-commits
Author: Balazs Benics Date: 2025-02-01T08:20:13+01:00 New Revision: d0a142eaea03661e8399f2c1733b93d21d55dfee URL: https://github.com/llvm/llvm-project/commit/d0a142eaea03661e8399f2c1733b93d21d55dfee DIFF: https://github.com/llvm/llvm-project/commit/d0a142eaea03661e8399f2c1733b93d21d55dfee.diff

[clang] [clang][mutation analyzer][NFC] Simplify code in ExprMutationAnalyzer (PR #125283)

2025-01-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/125283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #125336)

2025-01-31 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/125336 Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Literal migration

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #125335)

2025-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Litera

[clang] [clang][bytecode] Stack-allocate bottom function frame (PR #125253)

2025-01-31 Thread Vitaly Buka via cfe-commits
@@ -27,7 +27,7 @@ bool InterpState::inConstantContext() const { } InterpState::~InterpState() { - while (Current) { + while (Current && !Current->isBottomFrame()) { vitalybuka wrote: Some reordering is needed for "InterpState S;" and "InterpFrame BottomFram

[clang] [clang][bytecode] Stack-allocate bottom function frame (PR #125253)

2025-01-31 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > Looks like from this patch > https://lab.llvm.org/buildbot/#/builders/94/builds/4194/steps/17/logs/stdio I see it's alread reverted and green. Still the URL with stack traces may help to fix the issue. https://github.com/llvm/llvm-project/pull/125253 ___

[clang] 65708ba - [clang][CodeGenOpenCL][NFC] Remove redundant map lookups (#125285)

2025-01-31 Thread via cfe-commits
Author: Balazs Benics Date: 2025-02-01T08:21:15+01:00 New Revision: 65708bad579229cd7f62b8d0eaefda4bb20eb6d8 URL: https://github.com/llvm/llvm-project/commit/65708bad579229cd7f62b8d0eaefda4bb20eb6d8 DIFF: https://github.com/llvm/llvm-project/commit/65708bad579229cd7f62b8d0eaefda4bb20eb6d8.diff

[clang] [clang][CodeGenOpenCL][NFC] Remove redundant map lookups (PR #125285)

2025-01-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/125285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow][NFC] Remove double lookup (PR #125282)

2025-01-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/125282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2025-01-31 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. Much better! Thanks a lot for working on this https://github.com/llvm/llvm-project/pull/117437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [PCH, CUDA] Take CUDA attributes into account (PR #125127)

2025-01-31 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. thanks a lot, LGTM! https://github.com/llvm/llvm-project/pull/125127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Dont report explicit refs for global operator new/delete (PR #125199)

2025-01-31 Thread Haojian Wu via cfe-commits
@@ -32,6 +33,11 @@ namespace clang::include_cleaner { namespace { +bool isImplicitOperatorNewDelete(OverloadedOperatorKind OpKind) { hokein wrote: Nit: this function only checks whether `OpKind` is of the new/delete kind. Having `Implici`t in the function na

[clang-tools-extra] fcb1234 - [include-cleaner] Dont report explicit refs for global operator new/delete (#125199)

2025-01-31 Thread via cfe-commits
Author: kadir çetinkaya Date: 2025-01-31T14:01:45+01:00 New Revision: fcb12346dd656b6ce02971c3530b2680e3a332ac URL: https://github.com/llvm/llvm-project/commit/fcb12346dd656b6ce02971c3530b2680e3a332ac DIFF: https://github.com/llvm/llvm-project/commit/fcb12346dd656b6ce02971c3530b2680e3a332ac.dif

[clang-tools-extra] [include-cleaner] Dont report explicit refs for global operator new/delete (PR #125199)

2025-01-31 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/125199 From 696ef01effccbf6f666b444a8eea1eabaaa1f706 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Fri, 31 Jan 2025 11:17:27 +0100 Subject: [PATCH] [include-cleaner] Dont report explicit refs for global operat

[clang] [clang][doc] Provide documentation for FixedPointLiteral matcher (PR #125122)

2025-01-31 Thread via cfe-commits
https://github.com/earnol edited https://github.com/llvm/llvm-project/pull/125122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] allow restrict qualifier for array types with pointer types as element types (PR #120896)

2025-01-31 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/120896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] allow restrict qualifier for array types with pointer types as element types (PR #120896)

2025-01-31 Thread Aaron Ballman via cfe-commits
@@ -9,20 +9,20 @@ typedef int (*T)[2]; restrict T x; typedef int *S[2]; -restrict S y; // expected-error {{restrict requires a pointer or reference ('S' (aka 'int *[2]') is invalid)}} - - +restrict S y; AaronBallman wrote: Can you also add a test for multidi

[clang] [Clang] allow restrict qualifier for array types with pointer types as element types (PR #120896)

2025-01-31 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I believe these changes are correct, but adding a few more folks interested in C to verify because existing compilers definitely disagree: https://godbolt.org/z/1Yb44WP9o https://github.com/llvm/llvm-project/pull/120896 ___

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

2025-01-31 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @shafik thanks for pointing that out! I'll check it ASAP https://github.com/llvm/llvm-project/pull/114684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

2025-01-31 Thread Shafik Yaghmour via cfe-commits
shafik wrote: This PR is linked to the following regression: https://github.com/llvm/llvm-project/issues/125225 https://github.com/llvm/llvm-project/pull/114684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

2025-01-31 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman requested changes to this pull request. Thank you for trying to take this on, we definitely appreciate when folks try to split things up to improve our ability to maintain the code base! That said, I don't think we need another file for common functions; Sema.cpp

[clang] [llvm] [Hexagon] Set the default compilation target to V68 (PR #125239)

2025-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-hexagon Author: Ikhlas Ajbar (iajbar) Changes Set the default compilation target to V68 if no Hexagon processor is specified at the command-line. Add the elf header changes for v81/v83/v85 architectures. --- Full diff: https://github.com/llvm/l

<    1   2   3   4   5   >