[clang] [Driver] DragonFly also needs libexecinfo (PR #125179)

2025-01-30 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/125179 >From 984c3bb992bbc3d9c5c9af3b02e72914424f00c1 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 31 Jan 2025 02:15:00 -0500 Subject: [PATCH] [Driver] DragonFly also needs libexecinfo --- clang/lib/Driver/Tool

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

2025-01-30 Thread Muhammad Bassiouni via cfe-commits
https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/125045 >From d938f75b1a5638f013ae2f7fb4f0ac2f6e28c6a4 Mon Sep 17 00:00:00 2001 From: Muhammad Bassiouni Date: Thu, 30 Jan 2025 12:02:25 +0200 Subject: [PATCH 1/5] [clang:frontend] Move helper functions in SemaHLSL t

[clang] [Driver] DragonFly also needs libexecinfo (PR #125179)

2025-01-30 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/125179 >From 30642359e2e88bb9807cd9142c27f3b0b544bbe5 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 31 Jan 2025 02:15:00 -0500 Subject: [PATCH] [Driver] Add DragonFly for handling of libdl and libexecinfo --- cl

[clang] [Driver] Add DragonFly for handling of libdl and libexecinfo (PR #125179)

2025-01-30 Thread Brad Smith via cfe-commits
https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/125179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

2025-01-30 Thread Muhammad Bassiouni via cfe-commits
bassiounix wrote: Huh.. this shouldn't fail! I tested locally before pushing the commits! Looks like these files aren't mine .. I guess .. https://github.com/llvm/llvm-project/pull/125045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [AArch64] Enable vscale_range with +sme (PR #124466)

2025-01-30 Thread David Green via cfe-commits
https://github.com/davemgreen edited https://github.com/llvm/llvm-project/pull/124466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9f1c825 - [AArch64] Enable vscale_range with +sme (#124466)

2025-01-30 Thread via cfe-commits
Author: David Green Date: 2025-01-31T07:57:43Z New Revision: 9f1c825fb62319b94ac9604f733afd59e9eb461b URL: https://github.com/llvm/llvm-project/commit/9f1c825fb62319b94ac9604f733afd59e9eb461b DIFF: https://github.com/llvm/llvm-project/commit/9f1c825fb62319b94ac9604f733afd59e9eb461b.diff LOG: [

[clang] [clang][bytecode] Handle invalid temporary descriptors (PR #125033)

2025-01-30 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-aarch64-dylib` running on `linaro-flang-aarch64-dylib` while building `clang` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/50/builds/9675 Here is the relevant

[clang] [AArch64] Enable vscale_range with +sme (PR #124466)

2025-01-30 Thread David Green via cfe-commits
https://github.com/davemgreen closed https://github.com/llvm/llvm-project/pull/124466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bc47dae - [Driver] Add DragonFly for handling of libdl and libexecinfo (#125179)

2025-01-30 Thread via cfe-commits
Author: Brad Smith Date: 2025-01-31T02:59:27-05:00 New Revision: bc47daed6d5491a7c65d4dd42da6bb11d3b1ab00 URL: https://github.com/llvm/llvm-project/commit/bc47daed6d5491a7c65d4dd42da6bb11d3b1ab00 DIFF: https://github.com/llvm/llvm-project/commit/bc47daed6d5491a7c65d4dd42da6bb11d3b1ab00.diff LO

[clang] [Driver] Add DragonFly for handling of libdl and libexecinfo (PR #125179)

2025-01-30 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/125179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] DragonFly also needs libexecinfo (PR #125179)

2025-01-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e6d16f93b329f2f9618d18d0b99c6060e206cf08 b3a80b3ff84a6e7523defca8dfa33d6c524445f0 --e

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

2025-01-30 Thread Muhammad Bassiouni via cfe-commits
bassiounix wrote: > 1. If we were to introduce new helpers, then instead of making a new > header for this, these functions should just become member functions of the > `Sema` class. `Sema` or `SemaBase`? > 2. The new version of `CheckAllArgTypesAreCorrect()` is... way too > complic

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

2025-01-30 Thread via cfe-commits
Sirraide wrote: > `Sema` or `SemaBase`? Typically we just put those in `Sema`; I think the only thing in `SemaBase` at the moment are some diagnostics helpers. https://github.com/llvm/llvm-project/pull/125045 ___ cfe-commits mailing list cfe-commits@

[clang] [Driver] DragonFly also needs libexecinfo (PR #125179)

2025-01-30 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/125179 None >From b3a80b3ff84a6e7523defca8dfa33d6c524445f0 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 31 Jan 2025 02:15:00 -0500 Subject: [PATCH] [Driver] DragonFly also needs libexecinfo --- clang/lib/Drive

[clang] [Driver] DragonFly also needs libexecinfo (PR #125179)

2025-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brad Smith (brad0) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/125179.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/CommonArgs.cpp (+2-1) ``diff diff --git a/clang/lib/Driver/ToolChains

[clang] d2d8e2e - [clang][bytecode] Handle invalid temporary descriptors (#125033)

2025-01-30 Thread via cfe-commits
Author: Timm Baeder Date: 2025-01-31T08:53:31+01:00 New Revision: d2d8e2e0306ab1f0eac6406b5f2ec4d231b1f7ff URL: https://github.com/llvm/llvm-project/commit/d2d8e2e0306ab1f0eac6406b5f2ec4d231b1f7ff DIFF: https://github.com/llvm/llvm-project/commit/d2d8e2e0306ab1f0eac6406b5f2ec4d231b1f7ff.diff L

[clang] [clang][bytecode] Handle invalid temporary descriptors (PR #125033)

2025-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/125033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add framework for CIR to LLVM IR lowering (PR #124650)

2025-01-30 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/124650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang module] Current Working Directory Pruning (PR #124786)

2025-01-30 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu ready_for_review https://github.com/llvm/llvm-project/pull/124786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-30 Thread John McCall via cfe-commits
@@ -2489,6 +2489,81 @@ are listed below. $ clang -fuse-ld=lld -Oz -Wl,--icf=safe -fcodegen-data-use code.cc +Strict Aliasing +--- + +The C and C++ standards require accesses to objects in memory to use l-values of +an appropriate type for the object. This is

[clang] [clang] Add 'instantiated_from' for enums to the output of TextNodeDumper (PR #124409)

2025-01-30 Thread André Brand via cfe-commits
https://github.com/thebrandre edited https://github.com/llvm/llvm-project/pull/124409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add 'instantiated_from' for enums to the output of TextNodeDumper (PR #124409)

2025-01-30 Thread André Brand via cfe-commits
thebrandre wrote: @shafik @Sirraide I don't have any experience writing (robust) tests for AST dumps. I hope it makes sense. 🙈 https://github.com/llvm/llvm-project/pull/124409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [clang module] Current Working Directory Pruning (PR #124786)

2025-01-30 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan commented: Is it better if this optimization happens really early in the process since you only visit all the options in CI? In that case, you can just reset the `CurrentWorkingDirectory` in the VFS so all the searching is done without CWD. This avoids any ha

[clang] WIP: [clang] MicrosoftCXXABI: Serialize the exception copy constructor table in the AST (PR #114075)

2025-01-30 Thread Andrey Glebov via cfe-commits
https://github.com/glebov-andrey edited https://github.com/llvm/llvm-project/pull/114075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] Revert "Reapply "[ORC] Enable JIT support for the compact-unwind frame..." with fixes." (PR #125098)

2025-01-30 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir closed https://github.com/llvm/llvm-project/pull/125098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] Revert "Reapply "[ORC] Enable JIT support for the compact-unwind frame..." with fixes." (PR #125098)

2025-01-30 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: Failure looks unrelated. Merging. https://github.com/llvm/llvm-project/pull/125098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add framework for CIR to LLVM IR lowering (PR #124650)

2025-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/124650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang module] Current Working Directory Pruning (PR #124786)

2025-01-30 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu updated https://github.com/llvm/llvm-project/pull/124786 >From 7060564de1bb6062639f4b4839fa17958f212755 Mon Sep 17 00:00:00 2001 From: Qiongsi Wu Date: Mon, 27 Jan 2025 16:44:30 -0800 Subject: [PATCH 1/3] Initial implementation of clang modules current working dire

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2025-01-30 Thread Chandler Carruth via cfe-commits
chandlerc wrote: I know it's only been a few days, but pinging in the hope of landing this week... This seems to finally be in a good state and is somewhat hard to keep rebasing. Happy to do anything I can to help make review easier. https://github.com/llvm/llvm-project/pull/120534 ___

[clang] [llvm] [AMDGPU][True16][MC][CodeGen] true16 for v_alignbyte_b32 (PR #119750)

2025-01-30 Thread Joe Nash via cfe-commits
https://github.com/Sisyph commented: LGTM but please wait for the other reviewers. https://github.com/llvm/llvm-project/pull/119750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][True16][MC][CodeGen] true16 for v_alignbyte_b32 (PR #119750)

2025-01-30 Thread Joe Nash via cfe-commits
https://github.com/Sisyph edited https://github.com/llvm/llvm-project/pull/119750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][True16][MC][CodeGen] true16 for v_alignbyte_b32 (PR #119750)

2025-01-30 Thread Joe Nash via cfe-commits
@@ -1,10 +1,48 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 ; RUN: llc -mtriple=amdgcn -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s +; RUN: llc -mtriple=amdgcn -mcpu=gfx1100 -mattr=+real-true16 -verify-m

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-30 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/122116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] WIP: [clang] MicrosoftCXXABI: Serialize the exception copy constructor table in the AST (PR #114075)

2025-01-30 Thread Andrey Glebov via cfe-commits
@@ -1082,6 +1082,10 @@ bool Sema::CheckCXXThrowOperand(SourceLocation ThrowLoc, // friendship or any other means). Context.addCopyConstructorForExceptionObject(Subobject, CD); glebov-andrey wrote: The implementation has changed, and this code has be

[clang] [Clang] Fix __{add, remove}_pointer in Objective-C++ (PR #123678)

2025-01-30 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/123678 >From 3c1c9bf41d39d33123b33c5b131f7a0c0eb62581 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 21 Jan 2025 02:16:02 +0100 Subject: [PATCH] [Clang] Fix __{add,remove}_pointer in Objective-C++ --- c

[clang] WIP: [clang] MicrosoftCXXABI: Serialize the exception copy constructor table in the AST (PR #114075)

2025-01-30 Thread Andrey Glebov via cfe-commits
@@ -1082,6 +1082,10 @@ bool Sema::CheckCXXThrowOperand(SourceLocation ThrowLoc, // friendship or any other means). Context.addCopyConstructorForExceptionObject(Subobject, CD); + // Store the bit in CXXRecordDecl so that ASTReader can restore this + // map

[clang] WIP: [clang] MicrosoftCXXABI: Serialize the exception copy constructor table in the AST (PR #114075)

2025-01-30 Thread Andrey Glebov via cfe-commits
https://github.com/glebov-andrey edited https://github.com/llvm/llvm-project/pull/114075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 74d7f43 - [Clang] Fix __{add, remove}_pointer in Objective-C++ (#123678)

2025-01-30 Thread via cfe-commits
Author: Nikolas Klauser Date: 2025-01-30T20:34:29+01:00 New Revision: 74d7f43b98910a110bc194752fca829eb19c265a URL: https://github.com/llvm/llvm-project/commit/74d7f43b98910a110bc194752fca829eb19c265a DIFF: https://github.com/llvm/llvm-project/commit/74d7f43b98910a110bc194752fca829eb19c265a.dif

[clang] [Clang] Fix __{add, remove}_pointer in Objective-C++ (PR #123678)

2025-01-30 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/123678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] WIP: [clang] MicrosoftCXXABI: Fix exception copy constructor LUT after loading AST (PR #114075)

2025-01-30 Thread Andrey Glebov via cfe-commits
https://github.com/glebov-andrey edited https://github.com/llvm/llvm-project/pull/114075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __{add, remove}_pointer in Objective-C++ (PR #123678)

2025-01-30 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: /cherry-pick 74d7f43b98910a110bc194752fca829eb19c265a https://github.com/llvm/llvm-project/pull/123678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] WIP: [clang] MicrosoftCXXABI: Serialize the exception copy constructor table in the AST (PR #114075)

2025-01-30 Thread Andrey Glebov via cfe-commits
@@ -249,6 +249,11 @@ FIELD(HasDeclaredCopyAssignmentWithConstParam, 1, MERGE_OR) /// base classes or fields have a no-return destructor FIELD(IsAnyDestructorNoReturn, 1, NO_MERGE) +/// Microsoft CXX ABI specific: +/// Whether the copy constructor is used by a `throw` expressio

[clang] 0e62c74 - [analyzer][NFC] Remove a redundant container lookup (#125064)

2025-01-30 Thread via cfe-commits
Author: Balazs Benics Date: 2025-01-30T20:48:43+01:00 New Revision: 0e62c748d440a6d12d190e951c987efe309f40d6 URL: https://github.com/llvm/llvm-project/commit/0e62c748d440a6d12d190e951c987efe309f40d6 DIFF: https://github.com/llvm/llvm-project/commit/0e62c748d440a6d12d190e951c987efe309f40d6.diff

[clang] WIP: [clang] MicrosoftCXXABI: Serialize the exception copy constructor table in the AST (PR #114075)

2025-01-30 Thread Andrey Glebov via cfe-commits
@@ -2316,6 +2316,20 @@ void ASTDeclReader::VisitCXXConstructorDecl(CXXConstructorDecl *D) { } VisitCXXMethodDecl(D); + + // Microsoft CXX ABI specific: + // Restore the RecordToCopyCtor sidecar LUT entry so that `throw` expressions + // find the correct copy constructo

[clang] [analyzer][NFC] Remove a redundant container lookup (PR #125064)

2025-01-30 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/125064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DependencyScanning] Add ability to scan TU with a buffer input (PR #125111)

2025-01-30 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan created https://github.com/llvm/llvm-project/pull/125111 Update Dependency scanner so it can scan the dependency of a TU with a provided buffer rather than relying on the on disk file system to provide the input file. >From d836f2f5da850f0d985f34253873c6c4616

[clang] [DependencyScanning] Add ability to scan TU with a buffer input (PR #125111)

2025-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Steven Wu (cachemeifyoucan) Changes Update Dependency scanner so it can scan the dependency of a TU with a provided buffer rather than relying on the on disk file system to provide the input file. --- Patch is 26.23 KiB, truncated to 20.

[clang] [Clang] Fix __{add, remove}_pointer in Objective-C++ (PR #123678)

2025-01-30 Thread via cfe-commits
llvmbot wrote: >/cherry-pick 74d7f43b98910a110bc194752fca829eb19c265a Error: Command failed due to missing milestone. https://github.com/llvm/llvm-project/pull/123678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [Clang] Fix __{add, remove}_pointer in Objective-C++ (PR #123678)

2025-01-30 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 milestoned https://github.com/llvm/llvm-project/pull/123678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __{add, remove}_pointer in Objective-C++ (PR #123678)

2025-01-30 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: /cherry-pick 74d7f43b98910a110bc194752fca829eb19c265a https://github.com/llvm/llvm-project/pull/123678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [libc++] Rename `__` prefix to `__libcpp_` for locale related functions (PR #119241)

2025-01-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/119241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 20fd7df - Fix false negative when value initializing a field annotated with [[clang::require_field_initialization]] (#124329)

2025-01-30 Thread via cfe-commits
Author: higher-performance Date: 2025-01-30T15:34:08-05:00 New Revision: 20fd7df0b847bb46aac2f0b5b71d242220027cbc URL: https://github.com/llvm/llvm-project/commit/20fd7df0b847bb46aac2f0b5b71d242220027cbc DIFF: https://github.com/llvm/llvm-project/commit/20fd7df0b847bb46aac2f0b5b71d242220027cbc.

[clang] Fix false negative when value initializing a field annotated with [[clang::require_field_initialization]] (PR #124329)

2025-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/124329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add tcgen05 alloc/dealloc intrinsics (PR #124961)

2025-01-30 Thread Artem Belevich via cfe-commits
@@ -962,6 +962,109 @@ The ``griddepcontrol`` intrinsics allows the dependent grids and prerequisite gr For more information, refer `PTX ISA `__. +

[clang] [StaticAnalyzer] Fix state update in VisitObjCForCollectionStmt (PR #124477)

2025-01-30 Thread Balazs Benics via cfe-commits
steakhal wrote: > I wish I could see your reply earlier! It took me a while to reduce the > downstream reproducer and come up a minimal test. This way of testing looks > great. Maybe I should add this test anyway. Thank you steakhal! I think I'd still prefer the unittest over a lit test becaus

[clang] [Clang] disallow attributes on void parameters (PR #124920)

2025-01-30 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/124920 >From bd731e4be65fc9c1746aa6a8f63d206eb54bb2be Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 29 Jan 2025 15:17:06 +0200 Subject: [PATCH 1/4] [Clang] disallow attributes on void parameters --- clang/

[clang] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (PR #115099)

2025-01-30 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/115099 >From e5f485ad8000c296229794346fdd627b90e504d2 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 5 Nov 2024 16:05:53 -0800 Subject: [PATCH 1/3] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts

[clang] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (PR #115099)

2025-01-30 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: I had to rebase this over the table-gen-ification of the builtins, but I think this is still relevant. https://github.com/llvm/llvm-project/pull/115099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (PR #115099)

2025-01-30 Thread Reid Kleckner via cfe-commits
@@ -31,10 +31,13 @@ // All MMX instructions will be generated via builtins. Any MMX vector // types (<1 x i64>, <2 x i32>, etc.) that aren't used by these builtins will be // expanded by the back-end. +// // FIXME: _mm_prefetch must be a built-in because it takes a compile-ti

[clang] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (PR #115099)

2025-01-30 Thread Reid Kleckner via cfe-commits
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/115099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #122841)

2025-01-30 Thread via cfe-commits
https://github.com/earnol updated https://github.com/llvm/llvm-project/pull/122841 >From c26434fea8a3ebf546139805ab4f7ef5d2f4252d Mon Sep 17 00:00:00 2001 From: Vladislav Aranov Date: Mon, 13 Jan 2025 20:19:58 -0500 Subject: [PATCH 1/2] [clang-tidy] Address false positives in misc-redundant-ex

[clang] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (PR #115099)

2025-01-30 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/115099 >From e5f485ad8000c296229794346fdd627b90e504d2 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 5 Nov 2024 16:05:53 -0800 Subject: [PATCH 1/5] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts

[clang] [clang-format] Fix mismatched break in BlockIndent (PR #124998)

2025-01-30 Thread Gedare Bloom via cfe-commits
@@ -9608,6 +9608,10 @@ TEST_F(FormatTest, AlignsAfterOpenBracket) { "\"a aaa a aaa a\"\n" ");", Style); + verifyFormat("aaa(\n" + "&b

[clang] [clang-format] Fix annotation of Java/JavaScript keyword extends (PR #125038)

2025-01-30 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/125038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1a25bea - [clang-format] Add ClassHeadName to help annotating StartOfName (#124891)

2025-01-30 Thread via cfe-commits
Author: Owen Pan Date: 2025-01-30T19:33:15-08:00 New Revision: 1a25bea852cd4f7d99e644953c31278f7f257ccd URL: https://github.com/llvm/llvm-project/commit/1a25bea852cd4f7d99e644953c31278f7f257ccd DIFF: https://github.com/llvm/llvm-project/commit/1a25bea852cd4f7d99e644953c31278f7f257ccd.diff LOG:

[clang] [clang-format] Add ClassHeadName to help annotating StartOfName (PR #124891)

2025-01-30 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/124891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2025-01-30 Thread Aaron Ballman via cfe-commits
@@ -4782,6 +4857,34 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Function *F = CGM.getIntrinsic(Intrinsic::frameaddress, AllocaInt8PtrTy); return RValue::get(Builder.CreateCall(F, Depth)); } + case Builtin::BI__builtin_stack_ad

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2025-01-30 Thread Aaron Ballman via cfe-commits
@@ -899,6 +899,12 @@ def FrameAddress : Builtin { let Prototype = "void*(_Constant unsigned int)"; } +def StackAddress : Builtin { + let Spellings = ["__builtin_stack_address"]; + let Attributes = [NoThrow]; AaronBallman wrote: Should this be marked `Cons

[clang] [clang module] Current Working Directory Pruning (PR #124786)

2025-01-30 Thread Michael Spencer via cfe-commits
Bigcheese wrote: It has to happen after the header search optimization in case that removes relative header search paths. https://github.com/llvm/llvm-project/pull/124786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

2025-01-30 Thread via cfe-commits
https://github.com/Sirraide requested changes to this pull request. I think there may be some code duplication here, so moving *some* of this code around *might* make sense, but I see a few issues with how this is done at the moment: 1. If we were to introduce new helpers, then instead of makin

[clang] [StaticAnalyzer] Fix state update in VisitObjCForCollectionStmt (PR #124477)

2025-01-30 Thread Balazs Benics via cfe-commits
steakhal wrote: > @steakhal I have added your test on behalf of you here: > https://github.com/llvm/llvm-project/pull/124477/commits/b932fb61338ed6ec47db351240dc65b9454ba28c Yea, thanks. Please drop all the refs to my name. Otherwise LGTM. Thanks for fixing this. I think you can merge this to

[clang] [clang][X86] Support __attribute__((model("small"/"large"))) (PR #124834)

2025-01-30 Thread Arthur Eubanks via cfe-commits
@@ -1,64 +1,40 @@ -// RUN: %clang_cc1 -triple aarch64 -verify=expected,aarch64 -fsyntax-only %s +// RUN: %clang_cc1 -triple aarch64 -verify=expected,unsupported -fsyntax-only %s // RUN: %clang_cc1 -triple loongarch64 -verify=expected,loongarch64 -fsyntax-only %s -// RUN: %clang

[clang] [Clang][counted_by] Refactor __builtin_dynamic_object_size on FAMs (PR #122198)

2025-01-30 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/122198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (PR #115099)

2025-01-30 Thread Reid Kleckner via cfe-commits
@@ -2225,9 +2221,10 @@ _mm_storer_ps(float *__p, __m128 __a) ///be generated. \n ///_MM_HINT_T2: Move data using the T2 hint. The PREFETCHT2 instruction will ///be generated. -#define _mm_prefetch(a, sel) (__builtin_prefetch((const void *)(a), \ -

[clang] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (PR #115099)

2025-01-30 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/115099 >From e5f485ad8000c296229794346fdd627b90e504d2 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 5 Nov 2024 16:05:53 -0800 Subject: [PATCH 1/6] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts

[clang] [Serialization] Migrate away from PointerUnion::dyn_cast (NFC) (#124884) (PR #125024)

2025-01-30 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/12773 Here is the relevant piec

[clang] [clang][Index] Use HeuristicResolver in libIndex (PR #125153)

2025-01-30 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/125153 None >From ddb04e547e312884c63739600829b58c242211b3 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Thu, 30 Jan 2025 21:31:12 -0500 Subject: [PATCH] [clang][Index] Use HeuristicResolver in libIndex --

[clang] [clang-format] Fix mismatched break in BlockIndent (PR #124998)

2025-01-30 Thread Owen Pan via cfe-commits
@@ -349,6 +349,13 @@ bool ContinuationIndenter::canBreak(const LineState &State) { } } + // Allow breaking before the right parens with block indentation if there was + // a break after the left parens, which is tracked by BreakBeforeClosingParen owen

[clang] [clang-format] Fix mismatched break in BlockIndent (PR #124998)

2025-01-30 Thread Owen Pan via cfe-commits
@@ -9608,6 +9608,10 @@ TEST_F(FormatTest, AlignsAfterOpenBracket) { "\"a aaa a aaa a\"\n" ");", Style); + verifyFormat("aaa(\n" + "&b

[clang] [clang-format] Fix mismatched break in BlockIndent (PR #124998)

2025-01-30 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/124998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2025-01-30 Thread via cfe-commits
Andarwinux wrote: Will LLVM 20 miss this? https://github.com/llvm/llvm-project/pull/120534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add ClassHeadName to help annotating StartOfName (PR #124891)

2025-01-30 Thread Owen Pan via cfe-commits
@@ -1146,6 +1175,8 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { EXPECT_TOKEN(Tokens[31], tok::greater, TT_TemplateCloser); EXPECT_EQ(Tokens[31]->FakeRParens, 1u); EXPECT_TRUE(Tokens[31]->ClosesRequiresClause); + // FIXME: + // EXPECT_TOKEN(Tok

[clang] [clang-format] Add ClassHeadName to help annotating StartOfName (PR #124891)

2025-01-30 Thread Owen Pan via cfe-commits
@@ -1146,6 +1175,8 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { EXPECT_TOKEN(Tokens[31], tok::greater, TT_TemplateCloser); EXPECT_EQ(Tokens[31]->FakeRParens, 1u); EXPECT_TRUE(Tokens[31]->ClosesRequiresClause); + // FIXME: + // EXPECT_TOKEN(Tok

[clang] [clang-format] Add ClassHeadName to help annotating StartOfName (PR #124891)

2025-01-30 Thread Owen Pan via cfe-commits
@@ -3458,6 +3509,9 @@ TEST_F(TokenAnnotatorTest, BraceKind) { Tokens = annotate("a = class Foo extends goog.a {};", getGoogleStyle(FormatStyle::LK_JavaScript)); ASSERT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[3], tok::identifier, TT_Class

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2025-01-30 Thread via cfe-commits
h-vetinari wrote: You'd have to merge and request a backport pretty quickly. Historically features could still be argued to land between rc1 (which is imminent) and rc2, but the windows is definitely closing fast https://github.com/llvm/llvm-project/pull/120534

[clang] [libcxxabi] [llvm] [Clang] Mangling of pack indexing type and expression for itanium (PR #123513)

2025-01-30 Thread Shafik Yaghmour via cfe-commits
@@ -30220,6 +30220,11 @@ const char* cases[][2] = { {"_ZZNH3Foo3fooES_iENK4Foo24foo2Ev", "Foo::foo(this Foo, int)::Foo2::foo2() const" }, {"_ZNH3FooclERKS_", "Foo::operator()(this Foo const&)"}, + +// C++26 pack indexing shafik wrote: We should a

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2025-01-30 Thread Chandler Carruth via cfe-commits
chandlerc wrote: Given the benefit to binary size and compile time in things like `configure` scripts, I'd certainly like to see it land... Erich already reviewed an earlier version. Maybe @rnk can help with reviews? https://github.com/llvm/llvm-project/pull/120534

[clang] [clang-format] Fix mismatched break in BlockIndent (PR #124998)

2025-01-30 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/124998 >From 69658e8c2beb787b90ea29765bf428892d4e5ec4 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Wed, 29 Jan 2025 14:53:10 -0700 Subject: [PATCH 1/2] [clang-format] Fix mismatched break in BlockIndent Near the C

[clang] [clang-format] Add ClassHeadName to help annotating StartOfName (PR #124891)

2025-01-30 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/124891 >From 04fd96533a48b0f6fdbacb6c9947740bf4c58992 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 28 Jan 2025 23:16:10 -0800 Subject: [PATCH] [clang-format] Add ClassHeadName to help annotating StartOfName Fixe

[clang] [clang-format] Fix mismatched break in BlockIndent (PR #124998)

2025-01-30 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/124998 >From 69658e8c2beb787b90ea29765bf428892d4e5ec4 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Wed, 29 Jan 2025 14:53:10 -0700 Subject: [PATCH 1/3] [clang-format] Fix mismatched break in BlockIndent Near the C

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2025-01-30 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,25 @@ +// RUN: %clang_cc1 -triple i686-unknown-unknown -emit-llvm -o - %s | FileCheck -check-prefix=X86 %s +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o - %s | FileCheck -check-prefix=X86_64 %s +// RUN: %clang_cc1 -triple riscv32-unknown-unknown -em

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2025-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for this! Please also be sure to add a release note to `clang/docs/ReleaseNotes.rst` as well as document the extension in `clang/docs/LanguageExtensions.rst` so users know about the functionality. Should we be supporting `STACK_ADDRESS_OFFS

[clang] Fix false negative when value initializing a field annotated with [[clang::require_field_initialization]] (PR #124329)

2025-01-30 Thread via cfe-commits
higher-performance wrote: > Sorry for the delayed review, this fell off my radar this week! :-/ > > Changes LGTM! The release branch did get cut, so this would need to be > backported > (https://releases.llvm.org/19.1.0/docs/GitHub.html#backporting-fixes-to-the-release-branches). Ah okay no w

[clang] [StaticAnalyzer] Fix state update in VisitObjCForCollectionStmt (PR #124477)

2025-01-30 Thread Ziqing Luo via cfe-commits
@@ -124,24 +124,26 @@ void ExprEngine::VisitObjCForCollectionStmt(const ObjCForCollectionStmt *S, bool isContainerNull = state->isNull(collectionV).isConstrainedTrue(); - ExplodedNodeSet dstLocation; - evalLocation(dstLocation, S, elem, Pred, state, elementV, false); +

[clang] Fix false negative when value initializing a field annotated with [[clang::require_field_initialization]] (PR #124329)

2025-01-30 Thread via cfe-commits
higher-performance wrote: > this would need to be backported > (https://releases.llvm.org/19.1.0/docs/GitHub.html#backporting-fixes-to-the-release-branches). Oh, @AaronBallman - would you mind adding this as a milestone so I can `/cherry-pick` here? https://github.com/llvm/llvm-project/pull/1

[clang] [DependencyScanning] Add ability to scan TU with a buffer input (PR #125111)

2025-01-30 Thread Ben Langmuir via cfe-commits
@@ -0,0 +1,111 @@ +// UNSUPPORTED: target=powerpc64-ibm-aix{{.*}} + +// RUN: rm -rf %t +// RUN: split-file %s %t + +//--- module.modulemap +module root { header "root.h" } +module direct { header "direct.h" } +module transitive { header "transitive.h" } +module addition { header "

[clang] [Clang] Make OpenMP offloading consistently use the bound architecture (PR #125135)

2025-01-30 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/125135 Summary: OpenMP was weirdly split between using the bound architecture from `--offload-arch=` and the old `-march=` option which only worked for single jobs. This patch removes that special handling. The main ben

[clang] [DependencyScanning] Add ability to scan TU with a buffer input (PR #125111)

2025-01-30 Thread Ben Langmuir via cfe-commits
@@ -0,0 +1,111 @@ +// UNSUPPORTED: target=powerpc64-ibm-aix{{.*}} + +// RUN: rm -rf %t +// RUN: split-file %s %t + +//--- module.modulemap +module root { header "root.h" } +module direct { header "direct.h" } +module transitive { header "transitive.h" } +module addition { header "

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-30 Thread Matheus Izvekov via cfe-commits
@@ -11714,27 +11714,44 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } - case TemplateDeductionResult::InvalidExplicitArguments: + case TemplateDeductionResult::InvalidExplicitArguments: { assert(ParamD && "no parameter f

  1   2   3   4   5   >