@@ -8147,6 +8149,26 @@ TEST_P(ImportFunctions, CTADWithLocalTypedef) {
ASSERT_TRUE(ToD);
}
+TEST_P(ImportFunctions, CTADAliasTemplate) {
+ Decl *TU = getTuDecl(
+ R"(
+ template struct A {
+A(T);
+ };
+ template
+ using B = A;
+ B b{(i
https://github.com/shafik edited
https://github.com/llvm/llvm-project/pull/123875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
I know you have approvals but you should expand the tests first.
https://github.com/llvm/llvm-project/pull/123875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/shafik commented:
when the discussion is eventually resolved please add a more detailed summary
explaining how the fix is implemented and why.
These go in the git log and it is important for relevant details to show up
there w/o the need for git show etc
https://github.com/
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/123818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/111465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay created
https://github.com/llvm/llvm-project/pull/124081
-fno-plt is an ELF specific option that GCC doesn't bother to give a
diagnostic on Windows. This option is somewhat popular and we've been
ignoring it for unsupported targets for a while (x86 support for a
while,
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Fangrui Song (MaskRay)
Changes
-fno-plt is an ELF specific option that GCC doesn't bother to give a
diagnostic on Windows. This option is somewhat popular and we've been
ignoring it for unsupported targets
Author: Chandler Carruth
Date: 2025-01-22T23:19:47-08:00
New Revision: cd5694ecea2da1990365f46f9737be1b29d94f0c
URL:
https://github.com/llvm/llvm-project/commit/cd5694ecea2da1990365f46f9737be1b29d94f0c
DIFF:
https://github.com/llvm/llvm-project/commit/cd5694ecea2da1990365f46f9737be1b29d94f0c.di
https://github.com/chandlerc closed
https://github.com/llvm/llvm-project/pull/123308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chandlerc wrote:
Ping -- a week now with no review.
https://github.com/llvm/llvm-project/pull/122873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chandlerc wrote:
> > I also so comments on the python script, but as I mentioned there, the
> > script is not code I'm suggesting to check in or maintain, merely
> > documenting for completeness. It was never written to be remotely readable
> > or clean, just to produce a verifiably equivalent
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/124081
>From a38b6aecebba895f11c967cc83f9e98bda359ffe Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Wed, 22 Jan 2025 23:03:41 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?UT
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/124081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: AdityaK
Date: 2025-01-22T23:30:04-08:00
New Revision: 2a51a0d39a659fe57b6d1d768bf08d378c5e
URL:
https://github.com/llvm/llvm-project/commit/2a51a0d39a659fe57b6d1d768bf08d378c5e
DIFF:
https://github.com/llvm/llvm-project/commit/2a51a0d39a659fe57b6d1d768bf08d378c5e.diff
LOG:
https://github.com/hiraditya closed
https://github.com/llvm/llvm-project/pull/123952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hiraditya closed
https://github.com/llvm/llvm-project/pull/124021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/124085
Don't insert a space between a type declaration r_paren and &/&&.
Fixes #124073.
>From 4a6d68388874e9b59936870b5c2c7d680a6bddc2 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Wed, 22 Jan 2025 23:38:47 -0800
Subj
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Don't insert a space between a type declaration r_paren and &/&&.
Fixes #124073.
---
Full diff: https://github.com/llvm/llvm-project/pull/124085.diff
2 Files Affected:
- (modified) clang/lib/Format/Toke
carlocab wrote:
LLVM 20 is branching soon -- would be good to try to get this in before then.
https://github.com/llvm/llvm-project/pull/111397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
HighCommander4 wrote:
Thanks for the reviews!
> Do we need a release note in llvm-project/clang/docs/ReleaseNotes.rst? This
> is an improvement on clang's code completion infra, but maybe it is not
> noticeable to compiler users.
I added a generic note about using `HeuristicResolver` to impro
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Kazu Hirata (kazutakahirata)
Changes
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
Litera
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/124076
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
Literal migration
https://github.com/shafik requested changes to this pull request.
Please add a more detailed summary to this PR. I have asked this on several PRs
and I believe the confusion reflected in the comments is very much attributed
to not explaining why you believe your fix works. It may be incorrect b
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/123818
>From 1b909be45a871d4942869ca93dfedac406fb72f1 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Tue, 21 Jan 2025 15:56:27 -0500
Subject: [PATCH] [clang][CodeComplete] Use HeuristicResolver to resolve
De
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/124074
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
Literal migration
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
Litera
Author: Nathan Ridge
Date: 2025-01-23T01:43:44-05:00
New Revision: ba174855203403f6c3e2a46bdd79dbb3e27ac6a4
URL:
https://github.com/llvm/llvm-project/commit/ba174855203403f6c3e2a46bdd79dbb3e27ac6a4
DIFF:
https://github.com/llvm/llvm-project/commit/ba174855203403f6c3e2a46bdd79dbb3e27ac6a4.diff
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/124080
Fixes https://github.com/llvm/llvm-project/issues/124079
>From dbdb0ed35cc33f7e4d6076812faaeef9437ddcc6 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Thu, 23 Jan 2025 01:34:14 -0500
Subject: [PATCH]
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nathan Ridge (HighCommander4)
Changes
Fixes https://github.com/llvm/llvm-project/issues/124079
---
Full diff: https://github.com/llvm/llvm-project/pull/124080.diff
1 Files Affected:
- (modified) clang/test/lit.cfg.py (+1)
``d
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/123818
>From 25fdf43fb182212e859aba806ab32cc25ec466af Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Thu, 26 Dec 2024 20:59:06 -0500
Subject: [PATCH 1/3] [clang][CodeComplete] Use HeuristicResolver to resolve
@@ -13464,6 +13464,14 @@ Decl *Sema::ActOnAliasDeclaration(Scope *S,
AccessSpecifier AS,
}
TemplateParameterList *TemplateParams = TemplateParamLists[0];
+// Check shadowing of a template parameter name
+for (NamedDecl *TP : TemplateParams->asArray()) {
+
https://github.com/shafik commented:
I see a lot of diagnostics were updated to `DefaultError` but I don't see
matching tests that demonstrate the now error. We should be testing each
diagnostic.
https://github.com/llvm/llvm-project/pull/123470
___
Author: AdityaK
Date: 2025-01-22T23:29:35-08:00
New Revision: 2b67eceeef6e04ae5a4093bec9a0f0b048c70958
URL:
https://github.com/llvm/llvm-project/commit/2b67eceeef6e04ae5a4093bec9a0f0b048c70958
DIFF:
https://github.com/llvm/llvm-project/commit/2b67eceeef6e04ae5a4093bec9a0f0b048c70958.diff
LOG:
mydeveloperday wrote:
Is there an github "Issue" for this? I can't quite understand what problem we
are trying to fix.
https://github.com/llvm/llvm-project/pull/123010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
Author: Younan Zhang
Date: 2025-01-22T16:08:19+08:00
New Revision: 69d0c4c1675c90cf99126210679a9c3ae0a8637e
URL:
https://github.com/llvm/llvm-project/commit/69d0c4c1675c90cf99126210679a9c3ae0a8637e
DIFF:
https://github.com/llvm/llvm-project/commit/69d0c4c1675c90cf99126210679a9c3ae0a8637e.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/123883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
https://github.com/llvm/llvm-project/pull/123890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2025-01-22T00:15:46-08:00
New Revision: a5159e200eb25c2873fb8db432962394a879e887
URL:
https://github.com/llvm/llvm-project/commit/a5159e200eb25c2873fb8db432962394a879e887
DIFF:
https://github.com/llvm/llvm-project/commit/a5159e200eb25c2873fb8db432962394a879e887.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/123890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `flang-aarch64-dylib`
running on `linaro-flang-aarch64-dylib` while building `clang` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/50/builds/9209
Here is the relevant
Author: Congcong Cai
Date: 2025-01-22T15:58:48+08:00
New Revision: 53ea5ffcb38d428e446d357f310e9c28957eaec7
URL:
https://github.com/llvm/llvm-project/commit/53ea5ffcb38d428e446d357f310e9c28957eaec7
DIFF:
https://github.com/llvm/llvm-project/commit/53ea5ffcb38d428e446d357f310e9c28957eaec7.diff
sirmc wrote:
I had a quick look (sorry for not getting to this earlier, was traveling around
Vietnam for a few weeks). Looks good to me. Especially the trick of encoding
the arity into the MOV32ri register seems very neat from a compatibility
standpoint.
So if I understand this correctly, the
Author: Shafik Yaghmour
Date: 2025-01-22T09:28:08+01:00
New Revision: 0a9c08c59ba61e727e9dee6d71883d9106963442
URL:
https://github.com/llvm/llvm-project/commit/0a9c08c59ba61e727e9dee6d71883d9106963442
DIFF:
https://github.com/llvm/llvm-project/commit/0a9c08c59ba61e727e9dee6d71883d9106963442.dif
Author: cor3ntin
Date: 2025-01-22T09:31:54+01:00
New Revision: 0369ac8d2555423fc6c41b2aed12aadf3eb9b0cd
URL:
https://github.com/llvm/llvm-project/commit/0369ac8d2555423fc6c41b2aed12aadf3eb9b0cd
DIFF:
https://github.com/llvm/llvm-project/commit/0369ac8d2555423fc6c41b2aed12aadf3eb9b0cd.diff
LOG:
hokein wrote:
Do we need a release note in llvm-project/clang/docs/ReleaseNotes.rst? This is
an improvement on clang's code completion infra, but maybe it is not noticeable
to compiler users.
https://github.com/llvm/llvm-project/pull/123818
___
cfe-c
@@ -5736,11 +5736,20 @@ class ConceptInfo {
// In particular, when E->getType() is DependentTy, try to guess a likely type.
// We accept some lossiness (like dropping parameters).
// We only try to handle common expressions on the LHS of MemberExpr.
-QualType getApproximateType
@@ -5736,11 +5736,20 @@ class ConceptInfo {
// In particular, when E->getType() is DependentTy, try to guess a likely type.
// We accept some lossiness (like dropping parameters).
// We only try to handle common expressions on the LHS of MemberExpr.
-QualType getApproximateType
cor3ntin wrote:
:tada: :rocket:
https://github.com/llvm/llvm-project/pull/95474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein approved this pull request.
https://github.com/llvm/llvm-project/pull/123818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/95474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chandlerc wrote:
> Thanks @chandlerc this is great! I think I'd seen multiple reviews where
> someone saw the preprocessor tricks and suggested it was more suitable for
> tablegen. Too bad we hadn't done it before now, but many thanks to you for
> doing it.
>
> I was able to do some fairly mi
https://github.com/chandlerc edited
https://github.com/llvm/llvm-project/pull/123460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
StarOne01 wrote:
Hey @Sirraide , inorder to include the test, we would need to figure out what's
going on with the `*out` pointer
https://github.com/llvm/llvm-project/pull/123495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/chandlerc closed
https://github.com/llvm/llvm-project/pull/123302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chandler Carruth
Date: 2025-01-22T00:41:27-08:00
New Revision: bc6f84a2db6e7d60d70cf9be8d6cce2a101d0faa
URL:
https://github.com/llvm/llvm-project/commit/bc6f84a2db6e7d60d70cf9be8d6cce2a101d0faa
DIFF:
https://github.com/llvm/llvm-project/commit/bc6f84a2db6e7d60d70cf9be8d6cce2a101d0faa.di
chandlerc wrote:
Ping
https://github.com/llvm/llvm-project/pull/123308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/svenvh closed
https://github.com/llvm/llvm-project/pull/114824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Sven van Haastregt
Date: 2025-01-22T09:49:56+01:00
New Revision: 957213f60b258a5f6cab04e50c78c0a0c1c304c2
URL:
https://github.com/llvm/llvm-project/commit/957213f60b258a5f6cab04e50c78c0a0c1c304c2
DIFF:
https://github.com/llvm/llvm-project/commit/957213f60b258a5f6cab04e50c78c0a0c1c304c2.
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/112860
>From b801140617023cda9fb2dcbb0a4098e2af94c42f Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Fri, 18 Oct 2024 10:59:35 +0200
Subject: [PATCH 1/3] '[Clang] Fix handling of immediate escalation for
inherit
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `arc-builder` running on
`arc-worker` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/3/builds/10663
Here is the relevant piece of
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/112860
>From 04846ad527b4558bd334b6502264c34fc405f205 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Fri, 18 Oct 2024 10:59:35 +0200
Subject: [PATCH 1/3] '[Clang] Fix handling of immediate escalation for
inherit
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick`
running on `linaro-clang-aarch64-quick` while building `clang` at step 5 "ninja
check 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/65/builds/11020
Here is the relevant pie
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while
building `clang` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/144/builds/16245
401 - 465 of 465 matches
Mail list logo
