ilya-biryukov wrote:
@VitaNuo I have landed a revert in f63e8ed16ef1fd2deb80cd88b5ca9d5b631b1c36, we
generally don't use PRs for reverts (just `git revert `, check it
builds and `git push origin main`).
https://github.com/llvm/llvm-project/pull/123962
__
cor3ntin wrote:
@erichkeane mind re-reviewing that?
https://github.com/llvm/llvm-project/pull/112860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `flang-aarch64-dylib`
running on `linaro-flang-aarch64-dylib` while building `clang,llvm` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/50/builds/9231
Here is the rel
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/123827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/V-FEXrt edited
https://github.com/llvm/llvm-project/pull/122981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilya-biryukov closed
https://github.com/llvm/llvm-project/pull/123962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Thurston Dang
Date: 2025-01-22T09:32:12-08:00
New Revision: 2476417232cdf2e1fce1a1df466b0995cdf559c5
URL:
https://github.com/llvm/llvm-project/commit/2476417232cdf2e1fce1a1df466b0995cdf559c5
DIFF:
https://github.com/llvm/llvm-project/commit/2476417232cdf2e1fce1a1df466b0995cdf559c5.diff
https://github.com/spall created
https://github.com/llvm/llvm-project/pull/123977
Make the memory representation of boolean vectors in HLSL, vectors of i32.
Allow boolean swizzling for boolean vectors in HLSL.
Add tests for boolean vectors and boolean vector swizzling.
Closes #91639
>From 50f8
@@ -216,11 +244,18 @@ int compareit(float a, float b) {
// no-inf-no-nan-warning@+2 {{use of infinity is undefined behavior due to the
currently enabled floating-point options}}
// no-inf-warning@+1 {{use of infinity is undefined behavior due to the
currently enabled floatin
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sarah Spall (spall)
Changes
Make the memory representation of boolean vectors in HLSL, vectors of i32.
Allow boolean swizzling for boolean vectors in HLSL.
Add tests for boolean vectors and boolean vector swizzling.
Closes #91639
---
Full
@@ -536,89 +536,84 @@ void CGHLSLRuntime::generateGlobalCtorDtorCalls() {
}
}
-void CGHLSLRuntime::handleGlobalVarDefinition(const VarDecl *VD,
- llvm::GlobalVariable *GV) {
- // If the global variable has resource binding, add i
@@ -253,12 +257,229 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl
*BufDecl) {
}
}
+// Returns true if the array has a zero size = if any of the dimensions is 0
+static bool isZeroSizedArray(const ConstantArrayType *CAT) {
+ while (CAT && !CAT->isZeroSize())
+
bwendling wrote:
Are there anymore comments?
https://github.com/llvm/llvm-project/pull/122198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron approved this pull request.
https://github.com/llvm/llvm-project/pull/123394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
galenelias wrote:
> Is there an github "Issue" for this? I can't quite understand what problem we
> are trying to fix.
There is not a GitHub Issue filed yet, but I could get one filed if that would
be helpful.
The issue is just there are users who want to use
`AllowShortNamespacesOnASingleLi
https://github.com/AidanGoldfarb updated
https://github.com/llvm/llvm-project/pull/122754
>From b6c576fb90362640b2fd4e41bd7f13dfee95d04d Mon Sep 17 00:00:00 2001
From: Aidan
Date: Mon, 13 Jan 2025 11:53:39 -0500
Subject: [PATCH 01/15] initial template arg fix push
---
.../clang/Basic/Diagnost
Author: AdityaK
Date: 2025-01-22T12:00:56-08:00
New Revision: 3057d0f14af5e073be3b7c7942dfff2a975ac4cb
URL:
https://github.com/llvm/llvm-project/commit/3057d0f14af5e073be3b7c7942dfff2a975ac4cb
DIFF:
https://github.com/llvm/llvm-project/commit/3057d0f14af5e073be3b7c7942dfff2a975ac4cb.diff
LOG:
https://github.com/hiraditya closed
https://github.com/llvm/llvm-project/pull/123955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MattPD updated
https://github.com/llvm/llvm-project/pull/123867
>From f02e20df8d8ef9c17f0ef530fd3b2beab3cf7ae2 Mon Sep 17 00:00:00 2001
From: "Matt P. Dziubinski"
Date: Tue, 21 Jan 2025 19:42:41 -0600
Subject: [PATCH] [OpenMP][SIMD][FIX] Use conservative "omp simd ordered"
l
@@ -11714,13 +11715,52 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl
*Found, Decl *Templated,
return;
}
- case TemplateDeductionResult::InvalidExplicitArguments:
+ case TemplateDeductionResult::InvalidExplicitArguments: {
assert(ParamD && "no parameter f
@@ -216,11 +244,18 @@ int compareit(float a, float b) {
// no-inf-no-nan-warning@+2 {{use of infinity is undefined behavior due to the
currently enabled floating-point options}}
// no-inf-warning@+1 {{use of infinity is undefined behavior due to the
currently enabled floatin
@@ -11610,9 +11610,10 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl
*Found, Decl *Templated,
bool TakingCandidateAddress) {
TemplateParameter Param = DeductionFailure.getTemplateParameter();
NamedDecl *ParamD;
- (ParamD = Param.dy
@@ -216,11 +244,18 @@ int compareit(float a, float b) {
// no-inf-no-nan-warning@+2 {{use of infinity is undefined behavior due to the
currently enabled floating-point options}}
// no-inf-warning@+1 {{use of infinity is undefined behavior due to the
currently enabled floatin
nico wrote:
If you haven't, it'd be good to also add a minimal regression test for the
assert :)
https://github.com/llvm/llvm-project/pull/119340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
https://github.com/gedare updated
https://github.com/llvm/llvm-project/pull/118409
>From 978e0415002be5ee51d226d15121392a8a0c2c85 Mon Sep 17 00:00:00 2001
From: Gedare Bloom
Date: Mon, 2 Dec 2024 15:16:39 -0700
Subject: [PATCH 1/3] [clang-format] Add PenaltyBreakBeforeMemberAccess
Add a config
gedare wrote:
> Please rebase and run `ninja clang-format-style`.
Done.
https://github.com/llvm/llvm-project/pull/118409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/111885
>From 6a3a200019f7d0973f35a83d735a2f517d636e3e Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Wed, 25 Sep 2024 14:31:54 -0400
Subject: [PATCH] Reland "[HIP] Use original file path for CUID" (#108771)
T
@@ -216,11 +244,18 @@ int compareit(float a, float b) {
// no-inf-no-nan-warning@+2 {{use of infinity is undefined behavior due to the
currently enabled floating-point options}}
// no-inf-warning@+1 {{use of infinity is undefined behavior due to the
currently enabled floatin
@@ -253,12 +257,229 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl
*BufDecl) {
}
}
+// Returns true if the array has a zero size = if any of the dimensions is 0
+static bool isZeroSizedArray(const ConstantArrayType *CAT) {
+ while (CAT && !CAT->isZeroSize())
+
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 589593254eede2f624f29390dc1018725e536505
c57b0c0bda26134131a4c846e0b81b000250709d --e
@@ -253,12 +257,229 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl
*BufDecl) {
}
}
+// Returns true if the array has a zero size = if any of the dimensions is 0
+static bool isZeroSizedArray(const ConstantArrayType *CAT) {
+ while (CAT && !CAT->isZeroSize())
+
@@ -11714,13 +11715,52 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl
*Found, Decl *Templated,
return;
}
- case TemplateDeductionResult::InvalidExplicitArguments:
+ case TemplateDeductionResult::InvalidExplicitArguments: {
assert(ParamD && "no parameter f
https://github.com/boomanaiden154 approved this pull request.
Changes to `__cpuidex_conflict.c` LGTM. I will put that on my TODO list.
https://github.com/llvm/llvm-project/pull/121839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
sivan-shani wrote:
Since all tests passed at pre-merge and rest of relevant tests passing on all
pipelines, it seems as the issue is not the patch at large but those specific 5
.ll tests. Will disable those specific 5 tests for now to clear the pipeline.
https://github.com/llvm/llvm-project/pu
https://github.com/inbelic approved this pull request.
https://github.com/llvm/llvm-project/pull/123853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -869,5 +875,12 @@ def convert_string(bytes_input):
return str(bytes_input)
+def print_filename(filename, null=False):
+if null:
+print(filename + "\0", end="")
HazardyKnusperkeks wrote:
Shouldn't you copy the the indentation of the pri
@@ -869,5 +875,12 @@ def convert_string(bytes_input):
return str(bytes_input)
+def print_filename(filename, null=False):
HazardyKnusperkeks wrote:
Why setting a value for null?
https://github.com/llvm/llvm-project/pull/123926
___
Author: Andy Kaylor
Date: 2025-01-22T10:11:53-08:00
New Revision: 7bf188fa991338e981e8dff120a4ed341ad7f4bd
URL:
https://github.com/llvm/llvm-project/commit/7bf188fa991338e981e8dff120a4ed341ad7f4bd
DIFF:
https://github.com/llvm/llvm-project/commit/7bf188fa991338e981e8dff120a4ed341ad7f4bd.diff
L
tahonermann wrote:
> No idea why I can't respond to the individual threads but...
@erichkeane, in order to reduce notifications, I replied to your comments as a
review. You should generally be able to reply to them individually or as part
of a batched review from the "Files changed" tab, but G
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/123433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11610,9 +11610,10 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl
*Found, Decl *Templated,
bool TakingCandidateAddress) {
TemplateParameter Param = DeductionFailure.getTemplateParameter();
NamedDecl *ParamD;
- (ParamD = Param.dy
@@ -216,11 +244,18 @@ int compareit(float a, float b) {
// no-inf-no-nan-warning@+2 {{use of infinity is undefined behavior due to the
currently enabled floating-point options}}
// no-inf-warning@+1 {{use of infinity is undefined behavior due to the
currently enabled floatin
kazutakahirata wrote:
> Since all tests passed at pre-merge and rest of relevant tests passing on all
> pipelines, it seems as the issue is not the patch at large but those specific
> 5 .ll tests. Will disable those specific 5 tests for now to clear the
> pipeline.
I've reverted the patch. I
Author: Krystian Stasiowski
Date: 2025-01-22T13:13:40-05:00
New Revision: 195a1fc5b05d7a42b2e3fa383edb9a7e8b34a9c5
URL:
https://github.com/llvm/llvm-project/commit/195a1fc5b05d7a42b2e3fa383edb9a7e8b34a9c5
DIFF:
https://github.com/llvm/llvm-project/commit/195a1fc5b05d7a42b2e3fa383edb9a7e8b34a9c5
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/109422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Krystian Stasiowski
Date: 2025-01-22T14:18:07-05:00
New Revision: 5ede7b6a6bc22aee86e592835ccc4eaa9459e5cd
URL:
https://github.com/llvm/llvm-project/commit/5ede7b6a6bc22aee86e592835ccc4eaa9459e5cd
DIFF:
https://github.com/llvm/llvm-project/commit/5ede7b6a6bc22aee86e592835ccc4eaa9459e5cd
@@ -0,0 +1,133 @@
+//=== ParseHLSLRootSignatureTest.cpp - Parse Root Signature tests
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/122981
>From c1fc823abf07dfb8326b6190672d9881890bbb15 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Tue, 14 Jan 2025 22:22:45 +
Subject: [PATCH 1/7] [HLSL][RootSignature] Implement Lexing of
DescriptorTables
@@ -253,12 +257,229 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl
*BufDecl) {
}
}
+// Returns true if the array has a zero size = if any of the dimensions is 0
+static bool isZeroSizedArray(const ConstantArrayType *CAT) {
+ while (CAT && !CAT->isZeroSize())
+
@@ -0,0 +1,46 @@
+// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -triple \
+// RUN: dxil-pc-shadermodel6.3-compute %s -emit-llvm -disable-llvm-passes -o
- | \
+// RUN: FileCheck %s --check-prefixes=CHECK,CHECK-DXIL
+// RUN: %clang_cc1 -std=hlsl2021 -finclude-defaul
@@ -0,0 +1,133 @@
+//=== ParseHLSLRootSignatureTest.cpp - Parse Root Signature tests
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -1818,8 +1819,21 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) {
// usual allocation and deallocation functions. Required by libc++
return 201802;
default:
+// We may get here because of aux builtins which may not be
+
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin`
running on `doug-worker-5` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/190/builds/13304
Here is th
@@ -253,12 +257,229 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl
*BufDecl) {
}
}
+// Returns true if the array has a zero size = if any of the dimensions is 0
+static bool isZeroSizedArray(const ConstantArrayType *CAT) {
+ while (CAT && !CAT->isZeroSize())
+
@@ -253,12 +257,229 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl
*BufDecl) {
}
}
+// Returns true if the array has a zero size = if any of the dimensions is 0
+static bool isZeroSizedArray(const ConstantArrayType *CAT) {
+ while (CAT && !CAT->isZeroSize())
+
@@ -253,12 +257,229 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl
*BufDecl) {
}
}
+// Returns true if the array has a zero size = if any of the dimensions is 0
+static bool isZeroSizedArray(const ConstantArrayType *CAT) {
+ while (CAT && !CAT->isZeroSize())
+
@@ -362,3 +364,93 @@ void
SemaSYCL::CheckSYCLEntryPointFunctionDecl(FunctionDecl *FD) {
}
}
}
+
+namespace {
+
+// The body of a function declared with the [[sycl_kernel_entry_point]]
+// attribute is cloned and transformed to substitute references to the original
+// fu
https://github.com/bader approved this pull request.
@tahonermann thanks a lot for the work. I really appreciate the detailed
description and comments!
@erichkeane did a great job with the code review, so I have nothing to add.
I just have one small question that does not affect the merge.
ht
https://github.com/bader edited https://github.com/llvm/llvm-project/pull/122379
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/122820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -253,12 +257,229 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl
*BufDecl) {
}
}
+// Returns true if the array has a zero size = if any of the dimensions is 0
+static bool isZeroSizedArray(const ConstantArrayType *CAT) {
+ while (CAT && !CAT->isZeroSize())
+
@@ -0,0 +1,153 @@
+#include "clang/Parse/ParseHLSLRootSignature.h"
+
+namespace llvm {
+namespace hlsl {
+namespace root_signature {
+
+// Lexer Definitions
+
+static bool IsNumberChar(char C) {
+ // TODO: extend for float support with or without hexadecimal/exponent
MagentaTreehouse wrote:
@Sirraide Could you help me merge this? Thank you.
https://github.com/llvm/llvm-project/pull/97930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/123982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/123982
>From c57b0c0bda26134131a4c846e0b81b000250709d Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 22 Jan 2025 13:43:38 -0500
Subject: [PATCH 1/2] =?UTF-8?q?Revert=20"Reapply=20"[Clang][Sema]=20Use=
@@ -0,0 +1,46 @@
+// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -triple \
+// RUN: dxil-pc-shadermodel6.3-compute %s -emit-llvm -disable-llvm-passes -o
- | \
+// RUN: FileCheck %s --check-prefixes=CHECK,CHECK-DXIL
+// RUN: %clang_cc1 -std=hlsl2021 -finclude-defaul
@@ -253,12 +257,229 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl
*BufDecl) {
}
}
+// Returns true if the array has a zero size = if any of the dimensions is 0
+static bool isZeroSizedArray(const ConstantArrayType *CAT) {
+ while (CAT && !CAT->isZeroSize())
+
@@ -117,13 +121,13 @@ class OptTable {
private:
// A unified string table for these options. Individual strings are stored as
// null terminated C-strings at offsets within this table.
- const char *StrTable;
+ const StringTable *StrTable;
chandlerc wrote
@@ -33,25 +33,26 @@ using namespace llvm::opt;
namespace {
struct OptNameLess {
- const char *StrTable;
- ArrayRef PrefixesTable;
+ const StringTable *StrTable;
chandlerc wrote:
(same as above)
https://github.com/llvm/llvm-project/pull/123308
https://github.com/hiraditya updated
https://github.com/llvm/llvm-project/pull/123952
>From 9a48ecb655bdc610021f0512a6f5b96328174091 Mon Sep 17 00:00:00 2001
From: AdityaK
Date: Wed, 22 Jan 2025 07:14:34 -0800
Subject: [PATCH] Android no longer supports arm < 7
---
clang/lib/Driver/ToolChains
@@ -0,0 +1,162 @@
+
+TypeSanitizer
+
+
+.. contents::
+ :local:
+
+Introduction
+
+
+The TypeSanitizer is a detector for strict type aliasing violations. It
consists of a compiler
+instrumentation module and a run-time library. C/C++
@@ -0,0 +1,162 @@
+
+TypeSanitizer
+
+
+.. contents::
+ :local:
+
+Introduction
+
+
+The TypeSanitizer is a detector for strict type aliasing violations. It
consists of a compiler
+instrumentation module and a run-time library. C/C++
@@ -0,0 +1,162 @@
+
+TypeSanitizer
+
AaronBallman wrote:
```suggestion
=
TypeSanitizer
=
```
https://github.com/llvm/llvm-project/pull/123595
___
cfe-commits mail
@@ -0,0 +1,153 @@
+
+TypeSanitizer
+
+
+.. contents::
+ :local:
+
+Introduction
+
+
+TypeSanitizer is a detector for strict type aliasing violations. It consists
of a compiler
+instrumentation module and a run-time library. The tool d
@@ -0,0 +1,162 @@
+
+TypeSanitizer
+
+
+.. contents::
+ :local:
+
+Introduction
+
+
+The TypeSanitizer is a detector for strict type aliasing violations. It
consists of a compiler
+instrumentation module and a run-time library. C/C++
https://github.com/AaronBallman commented:
Thank you for working on these docs!
https://github.com/llvm/llvm-project/pull/123595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,162 @@
+
+TypeSanitizer
+
+
+.. contents::
+ :local:
+
+Introduction
+
+
+The TypeSanitizer is a detector for strict type aliasing violations. It
consists of a compiler
+instrumentation module and a run-time library. C/C++
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/123595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/earnol updated
https://github.com/llvm/llvm-project/pull/122841
>From c26434fea8a3ebf546139805ab4f7ef5d2f4252d Mon Sep 17 00:00:00 2001
From: Vladislav Aranov
Date: Mon, 13 Jan 2025 20:19:58 -0500
Subject: [PATCH] [clang-tidy] Address false positives in
misc-redundant-expres
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/123587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sivan-shani wrote:
@nico @antmox the very same 5 .ll tests passed upstream pre-merge
https://buildkite.com/llvm-project/github-pull-requests/builds/139398#01948e1c-bd4f-41d6-878b-789113e2cbea
Not sure how to understand the later failure.
Still investigating.
https://github.com/llvm/llvm-project
nico wrote:
We (chromium) turned on fwrapv due to the pointer changes, and it had a bit of
a perf hit. We'd probably switch to this, hoping it'd address the perf issues
at least some.
Matching gcc's behavior for -f flags both compilers have also makes sense, IMHO.
https://github.com/llvm/llvm
@@ -1818,8 +1819,21 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) {
// usual allocation and deallocation functions. Required by libc++
return 201802;
default:
+// We may get here because of aux builtins which may not be
+
@@ -1818,8 +1819,21 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) {
// usual allocation and deallocation functions. Required by libc++
return 201802;
default:
+// We may get here because of aux builtins which may not be
+
https://github.com/thurstond closed
https://github.com/llvm/llvm-project/pull/122994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -536,89 +536,84 @@ void CGHLSLRuntime::generateGlobalCtorDtorCalls() {
}
}
-void CGHLSLRuntime::handleGlobalVarDefinition(const VarDecl *VD,
- llvm::GlobalVariable *GV) {
- // If the global variable has resource binding, add i
@@ -1818,8 +1819,21 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) {
// usual allocation and deallocation functions. Required by libc++
return 201802;
default:
+// We may get here because of aux builtins which may not be
+
sivan-shani wrote:
Yes, I realized that it is actually failing not only on AArch64 but also on x86
and was about to revert it myself.
Thank you, working on a fix.
https://github.com/llvm/llvm-project/pull/118771
___
cfe-commits mailing list
cfe-commit
@@ -33,25 +33,26 @@ using namespace llvm::opt;
namespace {
struct OptNameLess {
- const char *StrTable;
- ArrayRef PrefixesTable;
+ const StringTable *StrTable;
rnk wrote:
Can this be a const reference instead? Is there a reason you chose to make this
a p
@@ -117,13 +121,13 @@ class OptTable {
private:
// A unified string table for these options. Individual strings are stored as
// null terminated C-strings at offsets within this table.
- const char *StrTable;
+ const StringTable *StrTable;
rnk wrote:
Can
@@ -0,0 +1,505 @@
+// RUN: %clang_cc1 -fsyntax-only -std=c++23 -triple x86_64-unknown-unknown
-target-feature +fullbf16 -verify -ast-dump %s | FileCheck %s
+#include
+_Float16 f16_val_1 = 1.0bf16; // expected-error {{cannot initialize a variable
of type '_Float16' with an rvalu
@@ -132,6 +133,70 @@ template <> struct
llvm::DenseMapInfo {
return LHS == RHS;
}
};
+constexpr unsigned CXX23FloatRankToIndex(clang::BuiltinType::Kind Kind) {
jcranmer-intel wrote:
This function appears to be unused now.
https://github.com/llvm/llvm-p
https://github.com/jcranmer-intel commented:
I think this concludes my full look at this PR. I don't fully have a grasp on
the mechanisms of C++ overload to comment on key parts of this patch.
This also doesn't implement enough of the hard cases of P1467R9 (namely
_Float32/_Float64) for me to
@@ -4446,6 +4455,73 @@ CompareStandardConversionSequences(Sema &S,
SourceLocation Loc,
? ImplicitConversionSequence::Better
: ImplicitConversionSequence::Worse;
+ // C++23 [over.ics.rank]p4b3:
+ // A conversion in either direction between float
@@ -7444,9 +7444,12 @@ isArithmeticArgumentPromotion(Sema &S, const
ImplicitCastExpr *ICE) {
From = VecTy->getElementType();
if (const auto *VecTy = To->getAs())
To = VecTy->getElementType();
- // It's a floating promotion if the source type is a lower rank.
- retu
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/123308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcranmer-intel edited
https://github.com/llvm/llvm-project/pull/78503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5321,6 +5321,59 @@ class BuiltinBitCastExpr final
}
};
+// Represents an unexpanded pack where the list of expressions are
+// known. These are used when structured bindings introduce a pack.
+class ResolvedUnexpandedPackExpr final
+: public Expr,
+ private llvm
@@ -11226,12 +11232,14 @@ void Sema::CheckImplicitConversion(Expr *E, QualType
T, SourceLocation CC,
DiagnoseImpCast(*this, E, T, CC, diag::warn_impcast_float_precision);
}
// ... or possibly if we're increasing rank, too
- else if (Order < 0) {
+
@@ -0,0 +1,133 @@
+//=== ParseHLSLRootSignatureTest.cpp - Parse Root Signature tests
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
201 - 300 of 465 matches
Mail list logo
