[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-22 Thread Petr Polezhaev via cfe-commits
https://github.com/petr-polezhaev updated https://github.com/llvm/llvm-project/pull/122606 >From 994d7bfaf416b5015c5004365e199769e26dffc4 Mon Sep 17 00:00:00 2001 From: Petr Polezhaev Date: Sat, 11 Jan 2025 21:21:16 +0300 Subject: [PATCH] [clangd] Support .clangd command line modifications in

[clang] [Clang][OpenCL][AMDGPU] Allow a kernel to call another kernel (PR #115821)

2025-01-22 Thread Aniket Lal via cfe-commits
@@ -1085,8 +1085,10 @@ llvm::Value *CodeGenFunction::EmitBlockLiteral(const CGBlockInfo &blockInfo) { blockAddr.getPointer(), ConvertType(blockInfo.getBlockExpr()->getType())); if (IsOpenCL) { -CGM.getOpenCLRuntime().recordBlockInfo(blockInfo.BlockExpression, Inv

[clang-tools-extra] [clang-tidy] Add ClangQueryChecks config option (PR #123734)

2025-01-22 Thread via cfe-commits
@@ -126,8 +127,15 @@ struct ClangTidyOptions { using StringPair = std::pair; using OptionMap = llvm::StringMap; + struct QueryCheckValue { +std::string Source; DeNiCoN wrote: It is used to dump the config back. As for example in the "Check config dum

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2025-01-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/16819 Here is the rel

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2025-01-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/17619 Here is the r

[clang-tools-extra] [clang-tidy] Add ClangQueryChecks config option (PR #123734)

2025-01-22 Thread via cfe-commits
https://github.com/DeNiCoN edited https://github.com/llvm/llvm-project/pull/123734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Clang/Preprocessor: Support short circuit in directive (PR #123912)

2025-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: YunQiang Su (wzssyqa) Changes Don't Evaluate RHS in if directive when short circuit. Examples include #if 0 && another_condition #if 1 || another_condition --- Full diff: https://github.com/llvm/llvm-project/pull/123912.diff 2 File

[clang] [clang-tools-extra] Clang/Preprocessor: Not add headers of __has_include into DepColloctor (PR #120673)

2025-01-22 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa closed https://github.com/llvm/llvm-project/pull/120673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4/PS5][Driver] Observe /target/lib for libraries (PR #123350)

2025-01-22 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd closed https://github.com/llvm/llvm-project/pull/123350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1a1dbac - [PS4/PS5][Driver] Observe /target/lib for libraries (#123350)

2025-01-22 Thread via cfe-commits
Author: Edd Dawson Date: 2025-01-22T10:46:17Z New Revision: 1a1dbac5bc4eab4239b365c1b296e2729031a62e URL: https://github.com/llvm/llvm-project/commit/1a1dbac5bc4eab4239b365c1b296e2729031a62e DIFF: https://github.com/llvm/llvm-project/commit/1a1dbac5bc4eab4239b365c1b296e2729031a62e.diff LOG: [P

[clang] [clang-format] Add null-terminated path option (#123921) (PR #123926)

2025-01-22 Thread Nikolaos Chatzikonstantinou via cfe-commits
https://github.com/createyourpersonalaccount created https://github.com/llvm/llvm-project/pull/123926 This makes the `git clang-format` tool compose nicely with other shell utilities in case of maliciously (or innocently) crafted filenames. >From 9dfbb9a3cc7f6bc557bc1ccf25cc727a02c4274c Mon Se

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-01-22 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/120925 >From bce88b1bb464438828fc177c978ad2b99957530f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Dec 2024 02:35:07 +0200 Subject: [PATCH 1/4] [Clang] raise extension warning for unknown namespaced att

[clang] [llvm] [X86][AVX10.2-SATCVT][NFC] Remove NE from intrinsic and instruction name (PR #123275)

2025-01-22 Thread Phoebe Wang via cfe-commits
@@ -603,13 +603,13 @@ defm VCVTPS2IUBS : avx10_sat_cvt_base<0x6b, "vcvtps2iubs", SchedWriteVecIMul, X86vcvtp2iubsRnd>, AVX512PDIi8Base, T_MAP5, EVEX_CD8<32, CD8VF>; -defm VCVTTNEBF162IBS : avx10_sat_cvt_base<0x68, "vcvttn

[clang] [llvm] [HIP] Support managed variables using the new driver (PR #123437)

2025-01-22 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. https://github.com/llvm/llvm-project/pull/123437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2-SATCVT][NFC] Remove NE from intrinsic and instruction name (PR #123275)

2025-01-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/123275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Fix may-be incorrect ADL for module local entities (PR #123931)

2025-01-22 Thread Nikita Popov via cfe-commits
nikic wrote: I'm not seeing any impact: https://llvm-compile-time-tracker.com/compare.php?from=ff0f1dd341cb2fdc1281a14413b3aa93bf9a20c7&to=4bfdd091675b9957686ac81457629e124950dc25&stat=instructions:u https://github.com/llvm/llvm-project/pull/123931 __

[clang] [Clang] Add predefined macros for integer constants to implement section 7.18.4 of ISO/IEC 9899:1999 in `` in a safe way (PR #123514)

2025-01-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for the fix! Can you also add test coverage for the changes to `clang/test/Headers` and a release note so users know about the fix to `clang/docs/ReleaseNotes.rst`? Also, precommit CI found relevant failures: ``` TEST 'C

[clang] 1df50e6 - [PS5][Driver] Don't link with --build-id when -static (#123930)

2025-01-22 Thread via cfe-commits
Author: Edd Dawson Date: 2025-01-22T14:57:52Z New Revision: 1df50e6245cbc04f3b28de3c40127ad61d46b43b URL: https://github.com/llvm/llvm-project/commit/1df50e6245cbc04f3b28de3c40127ad61d46b43b DIFF: https://github.com/llvm/llvm-project/commit/1df50e6245cbc04f3b28de3c40127ad61d46b43b.diff LOG: [P

[clang] [PS5][Driver] Don't link with --build-id when -static (PR #123930)

2025-01-22 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd closed https://github.com/llvm/llvm-project/pull/123930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Widen loops: Augment assignment note when values invalidated at the start of a loop (PR #122398)

2025-01-22 Thread Balazs Benics via cfe-commits
steakhal wrote: > Hi @steakhal . > > Thank you for the further clarification and example. I now understand how > your proposal fits in with what I'm trying to accomplish. Thank you for your time for considering it! > I've started to implement the proposal but I have a few questions: > > * Wh

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-22 Thread Petr Polezhaev via cfe-commits
@@ -830,6 +830,16 @@ bool OverlayCDB::setCompileCommand(PathRef File, return true; } +std::unique_ptr +OverlayCDB::getProjectModules(PathRef File) const { + auto MDB = DelegatingCDB::getProjectModules(File); + MDB->setCommandMangler([&Mangler = Mangler](tooling::CompileCom

[clang] Clang/Preprocessor: Support short circuit in directive (PR #123912)

2025-01-22 Thread Fabian Ritter via cfe-commits
@@ -23,7 +23,7 @@ template __attribute__((host, device)) int templatify(int x) { __attribute__((device)) const int GlobalConst = __AMDGCN_WAVEFRONT_SIZE__; // expected-warning {{macro '__AMDGCN_WAVEFRONT_SIZE__' has been marked as deprecated}} constexpr int GlobalConstExpr =

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-22 Thread Petr Polezhaev via cfe-commits
https://github.com/petr-polezhaev edited https://github.com/llvm/llvm-project/pull/122606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Clang/Preprocessor: Support short circuit in directive (PR #123912)

2025-01-22 Thread Fabian Ritter via cfe-commits
ritter-x2a wrote: I think it would be more useful in practice if the deprecation warnings respected lazy evaluation, as the PR suggests, but it's worth noting that this deviates from the C Standard, which specifies that macros are replaced first, before short-circuit evaluation takes place. h

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-22 Thread kadir çetinkaya via cfe-commits
@@ -830,6 +830,16 @@ bool OverlayCDB::setCompileCommand(PathRef File, return true; } +std::unique_ptr +OverlayCDB::getProjectModules(PathRef File) const { + auto MDB = DelegatingCDB::getProjectModules(File); + MDB->setCommandMangler([&Mangler = Mangler](tooling::CompileCom

[clang] [C++20][Modules] Fix crash/compiler error due broken AST links (PR #123648)

2025-01-22 Thread Haojian Wu via cfe-commits
@@ -799,14 +817,12 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) { } if (D->getFriendObjectKind()) { -// For a function defined inline within a class template, we have to force -// the canonical definition to be the one inside the canonical definition

[clang] Remove incorrect CUDA defines (PR #123898)

2025-01-22 Thread Sergey Kozub via cfe-commits
https://github.com/sergey-kozub closed https://github.com/llvm/llvm-project/pull/123898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-22 Thread Antonio Frighetto via cfe-commits
@@ -11610,9 +11610,10 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, bool TakingCandidateAddress) { TemplateParameter Param = DeductionFailure.getTemplateParameter(); NamedDecl *ParamD; - (ParamD = Param.dy

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-22 Thread Antonio Frighetto via cfe-commits
@@ -11714,13 +11715,52 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } - case TemplateDeductionResult::InvalidExplicitArguments: + case TemplateDeductionResult::InvalidExplicitArguments: { assert(ParamD && "no parameter f

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-22 Thread Antonio Frighetto via cfe-commits
@@ -11714,13 +11715,52 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } - case TemplateDeductionResult::InvalidExplicitArguments: + case TemplateDeductionResult::InvalidExplicitArguments: { assert(ParamD && "no parameter f

[clang] [Clang] Implement CWG 2628 "Implicit deduction guides should propagate constraints" (PR #111143)

2025-01-22 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/43 >From 567177e658ede96a59a22af14c9472e232391487 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 4 Oct 2024 20:22:59 +0800 Subject: [PATCH 1/2] [Clang] Implement CWG 2628 "Implicit deduction guides should

[clang] [llvm] [AArch64] Implement NEON FP8 fused multiply-add intrinsics (non-indexed) (PR #123614)

2025-01-22 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. Déjà vu, LGTM. https://github.com/llvm/llvm-project/pull/123614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 97c3a99 - Remove incorrect CUDA defines (#123898)

2025-01-22 Thread via cfe-commits
Author: Sergey Kozub Date: 2025-01-22T12:15:32+01:00 New Revision: 97c3a990f05606cb807faf53bc41302fb62c7980 URL: https://github.com/llvm/llvm-project/commit/97c3a990f05606cb807faf53bc41302fb62c7980 DIFF: https://github.com/llvm/llvm-project/commit/97c3a990f05606cb807faf53bc41302fb62c7980.diff

[clang] [llvm] [AArch64] Add FP8 Neon intrinsics for dot-product (PR #123613)

2025-01-22 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add Neon FP8 conversion intrinsics (PR #123612)

2025-01-22 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement NEON FP8 intrinsics for fused multiply-add (indexed) (PR #123615)

2025-01-22 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. Phew, massive diff, LGTM. https://github.com/llvm/llvm-project/pull/123615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS5][Driver] Don't link with --build-id when -static (PR #123930)

2025-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Edd Dawson (playstation-edd) Changes Users of the PlayStation SDK aren't given the means to create or run static executables. Uses of `-static` are limited a few specialized cases within SIE. A `--build-id` isn't wanted in those cases. S

[clang] [PS5][Driver] Don't link with --build-id when -static (PR #123930)

2025-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Edd Dawson (playstation-edd) Changes Users of the PlayStation SDK aren't given the means to create or run static executables. Uses of `-static` are limited a few specialized cases within SIE. A `--build-id` isn't wanted in those ca

[clang] [PS5][Driver] Don't link with --build-id when -static (PR #123930)

2025-01-22 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd created https://github.com/llvm/llvm-project/pull/123930 Users of the PlayStation SDK aren't given the means to create or run static executables. Uses of `-static` are limited a few specialized cases within SIE. A `--build-id` isn't wanted in those cases. SI

[clang-tools-extra] [clang-tidy] Add EnableQtSupport option to modernize-use-integer-sign-comprison (PR #122127)

2025-01-22 Thread via cfe-commits
qt-tatiana wrote: > lgtm. please update the pr title and description before merging. because the > option name is changed. Done :) https://github.com/llvm/llvm-project/pull/122127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang-tools-extra] [clang-tidy] Add EnableQtSupport option to modernize-use-integer-sign-comprison (PR #122127)

2025-01-22 Thread via cfe-commits
qt-tatiana wrote: Hi all, Could you please help me to merge the change? I don't have write access.. Thank you! https://github.com/llvm/llvm-project/pull/122127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] clang/limits.h: Avoid including limits.h twice (PR #120526)

2025-01-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > > Yes and no. It's due to the redefinitions, for sure. But that > > > > diagnostic is suppressed in system headers: > > > > https://godbolt.org/z/Mb7Kh975f, so I think we need to understand why > > > > there's a `limits.h` being included as though it were not a system

[clang] bd56950 - [clang] Refine the temporay object member access filtering for GSL pointer (#122088)

2025-01-22 Thread via cfe-commits
Author: Haojian Wu Date: 2025-01-22T14:11:16+01:00 New Revision: bd56950b9cd5b6b07e1ccb9b02c5d8a7125a23b6 URL: https://github.com/llvm/llvm-project/commit/bd56950b9cd5b6b07e1ccb9b02c5d8a7125a23b6 DIFF: https://github.com/llvm/llvm-project/commit/bd56950b9cd5b6b07e1ccb9b02c5d8a7125a23b6.diff LO

[clang] [clang] Refine the temporay object member access filtering for GSL pointer (PR #122088)

2025-01-22 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/122088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Clang/Preprocessor: Support short circuit in directive (PR #123912)

2025-01-22 Thread Aaron Ballman via cfe-commits
@@ -23,7 +23,7 @@ template __attribute__((host, device)) int templatify(int x) { __attribute__((device)) const int GlobalConst = __AMDGCN_WAVEFRONT_SIZE__; // expected-warning {{macro '__AMDGCN_WAVEFRONT_SIZE__' has been marked as deprecated}} constexpr int GlobalConstExpr =

[clang] Clang/Preprocessor: Support short circuit in directive (PR #123912)

2025-01-22 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,74 @@ +// RUN: %clang -E -MD -MF - %s | FileCheck -check-prefix ZERO_AND_HAS_INCLUDE %s +// +// ZERO_AND_HAS_INCLUDE-NOT: limits.h +// +#if 0 && __has_include() +#include +#endif + +#if 4==5 && __has_include() +#include +#endif + +#if defined(_THIS_IS_NOT_DEFINED) &&

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-22 Thread Oliver Stannard via cfe-commits
https://github.com/ostannard approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/118771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS5][Driver] Don't link with --build-id when -static (PR #123930)

2025-01-22 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Arch] Disable mve.fp when explicit -mfpu option (PR #123028)

2025-01-22 Thread Jack Styles via cfe-commits
https://github.com/Stylie777 closed https://github.com/llvm/llvm-project/pull/123028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Modules] Delay deserialization of preferred_name attribute at r…" (PR #123962)

2025-01-22 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo created https://github.com/llvm/llvm-project/pull/123962 Reverts llvm/llvm-project#122726 We're seeing a 8-10% performance regression due to this patch. >From 1d94f0a4598ec08cd75fb7c1c7353ce318da2472 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova <115406782+vita..

[clang] Revert "[Modules] Delay deserialization of preferred_name attribute at r…" (PR #123962)

2025-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Viktoriia Bakalova (VitaNuo) Changes Reverts llvm/llvm-project#122726 We're seeing a 8-10% performance regression due to this patch. --- Full diff: https://github.com/llvm/llvm-project/pull/123962.diff 9 Files Affected: - (modified) cl

[clang] Revert "[Modules] Delay deserialization of preferred_name attribute at r…" (PR #123962)

2025-01-22 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [clang] Track source deduction guide for alias template deduction guides (PR #123875)

2025-01-22 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. Thanks, the change looks good. https://github.com/llvm/llvm-project/pull/123875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2025-01-22 Thread via cfe-commits
@@ -501,6 +519,110 @@ bool Sema::CheckEquivalentExceptionSpec( return Result; } +static const Expr *SubstituteExceptionSpecWithoutEvaluation( +Sema &S, const Sema::TemplateCompareNewDeclInfo &DeclInfo, +const Expr *ExceptionSpec) { + MultiLevelTemplateArgumentList M

[clang] 0165d04 - [HIP] [NFC] Rename to `ClangArgs`

2025-01-22 Thread via cfe-commits
Author: Xeonacid Date: 2025-01-22T18:01:52+08:00 New Revision: 0165d043a9d62197468e0d4f7578cd7a5e4084f8 URL: https://github.com/llvm/llvm-project/commit/0165d043a9d62197468e0d4f7578cd7a5e4084f8 DIFF: https://github.com/llvm/llvm-project/commit/0165d043a9d62197468e0d4f7578cd7a5e4084f8.diff LOG:

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-01-22 Thread via cfe-commits
charan-003 wrote: Hi @erichkeane, thank you for the feedback! I understand that the lexing logic should be moved to the parser. Could you please point me toward specific areas in the parser where this logic should be integrated? A bit more detail would help me ensure this is implemented correc

[clang] c4ef805 - [Clang] Re-write codegen for atomic_test_and_set and atomic_clear (#121943)

2025-01-22 Thread via cfe-commits
Author: Oliver Stannard Date: 2025-01-22T10:48:04Z New Revision: c4ef805b0bda16f734276086b0984583c2e21db6 URL: https://github.com/llvm/llvm-project/commit/c4ef805b0bda16f734276086b0984583c2e21db6 DIFF: https://github.com/llvm/llvm-project/commit/c4ef805b0bda16f734276086b0984583c2e21db6.diff LO

[clang] [Clang] Re-write codegen for atomic_test_and_set and atomic_clear (PR #121943)

2025-01-22 Thread Oliver Stannard via cfe-commits
https://github.com/ostannard closed https://github.com/llvm/llvm-project/pull/121943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add null-terminated path option (#123921) (PR #123926)

2025-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Nikolaos Chatzikonstantinou (createyourpersonalaccount) Changes This makes the `git clang-format` tool compose nicely with other shell utilities in case of maliciously (or innocently) crafted filenames. --- Full diff: https://githu

[clang] [clang-format] Add null-terminated path option (#123921) (PR #123926)

2025-01-22 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] Implement CWG 2628 "Implicit deduction guides should propagate constraints" (PR #111143)

2025-01-22 Thread via cfe-commits
@@ -445,10 +449,46 @@ struct ConvertConstructorToDeductionGuideTransform { return nullptr; TypeSourceInfo *NewTInfo = TLB.getTypeSourceInfo(SemaRef.Context, NewType); +// At this point, the function parameters are already 'instantiated' in the co

[clang] [Clang] Implement CWG 2628 "Implicit deduction guides should propagate constraints" (PR #111143)

2025-01-22 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/43 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement CWG 2628 "Implicit deduction guides should propagate constraints" (PR #111143)

2025-01-22 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo nit/question https://github.com/llvm/llvm-project/pull/43 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StrTable] Mechanically convert Hexagon builtins to use TableGen (PR #123460)

2025-01-22 Thread Brian Cain via cfe-commits
androm3da wrote: > I also so comments on the python script, but as I mentioned there, the script > is not code I'm suggesting to check in or maintain, merely documenting for > completeness. It was never written to be remotely readable or clean, just to > produce a verifiably equivalent TableGe

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-22 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/123003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-22 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,72 @@ +//===-- MemSpaces.cpp -*- C++ -*--// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-22 Thread Balazs Benics via cfe-commits
https://github.com/steakhal commented: I had a quick look at the PR, and over all it looks as expected. Good job! Have you considered changing `MemRegion::getMemorySpace()` into `MemRegion::getMemorySpace(ProgramStateRef)`? This should lessen the confusion of which APIs should a dev use to get

[clang] [llvm] [HIP] Support managed variables using the new driver (PR #123437)

2025-01-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/123437 >From 4414706b8ced9048a572fb78544a7e637c4946a0 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 17 Jan 2025 19:56:18 -0600 Subject: [PATCH 1/3] [HIP] Support managed variables using the new driver Summary

[clang] [llvm] [IR] Don't set strictfp on irrelevant calls (PR #122735)

2025-01-22 Thread Serge Pavlov via cfe-commits
spavloff wrote: > > If strict floating-point semantics are required at this call site, they are > > are required on every relevant call in this function. It means strictfp is > > a function attribute. Does anything prevents us from removal strictfp from > > all call sites? > > I think that tak

[clang] [llvm] [PseudoProbe] Support emitting to COFF object (PR #123870)

2025-01-22 Thread Haohai Wen via cfe-commits
https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/123870 >From 7c531922f20bf284a5cd83b20e94cb624ef031d2 Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Thu, 9 Jan 2025 15:29:33 +0800 Subject: [PATCH 1/3] [COFF] Preserve UniqueID used to create MCSectionCOFF This Un

[clang] Android defaults to pic (PR #123955)

2025-01-22 Thread via cfe-commits
https://github.com/hiraditya updated https://github.com/llvm/llvm-project/pull/123955 >From c26d8bd4dbbe8acbbac49249d1b8015cd5240ec9 Mon Sep 17 00:00:00 2001 From: AdityaK Date: Wed, 22 Jan 2025 07:23:20 -0800 Subject: [PATCH] Android defaults to pic --- clang/lib/Driver/ToolChains/CommonArgs

[clang] Revert "[Modules] Delay deserialization of preferred_name attribute at r…" (PR #123962)

2025-01-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5a9b74d20d5f3b7f92c01d68d28778108dfb1308 1d94f0a4598ec08cd75fb7c1c7353ce318da2472 --e

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-pgo Author: Sinkevich Artem (ArtSin) Changes Add support for expanding `%b` in `LLVM_PROFILE_FILE` to the binary ID (build ID). It can be used with `%m` to avoid its signature collisions. This is supported on all platforms where writing binary IDs into

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot3` while building `llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/7671 Here is the relevant piece of

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sinkevich Artem (ArtSin) Changes Add support for expanding `%b` in `LLVM_PROFILE_FILE` to the binary ID (build ID). It can be used with `%m` to avoid its signature collisions. This is supported on all platforms where writing binary IDs in

[clang] Android no longer supports arm < 7 (PR #123952)

2025-01-22 Thread via cfe-commits
https://github.com/hiraditya updated https://github.com/llvm/llvm-project/pull/123952 >From 7b83d000de0fb092461b15edd991413a3f27d713 Mon Sep 17 00:00:00 2001 From: AdityaK Date: Wed, 22 Jan 2025 07:14:34 -0800 Subject: [PATCH] Android no longer supports arm < 7 --- clang/lib/Driver/ToolChains

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-01-22 Thread Sinkevich Artem via cfe-commits
https://github.com/ArtSin created https://github.com/llvm/llvm-project/pull/123963 Add support for expanding `%b` in `LLVM_PROFILE_FILE` to the binary ID (build ID). It can be used with `%m` to avoid its signature collisions. This is supported on all platforms where writing binary IDs into pro

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-01-22 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-01-22 Thread Sami Tolvanen via cfe-commits
samitolvanen wrote: > A gentle reminder to please review this PR. Overall this looks fine to me, but I was hoping to get an answer to my question about how the Kconfig detection is actually going to be implemented: https://github.com/llvm/llvm-project/pull/121070#discussion_r1911688455 https:

[libclc] [libclc] Move sign to the CLC builtins library (PR #115699)

2025-01-22 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/115699 >From 8144673e0338acefe13fac0c20bbaba0412b8239 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Thu, 7 Nov 2024 12:40:56 + Subject: [PATCH 1/4] [libclc] Move sign to the CLC builtins library This pat

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-22 Thread Nico Weber via cfe-commits
nico wrote: Seems seems to break tests: http://45.33.8.238/linux/158130/step_11.txt Please take a look, and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/118771 ___ cfe-commits mailing list cfe-commits@lists.llvm

[libclc] [libclc] Move sign to the CLC builtins library (PR #115699)

2025-01-22 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck edited https://github.com/llvm/llvm-project/pull/115699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-01-22 Thread Sami Tolvanen via cfe-commits
samitolvanen wrote: > And AFAIK there's no other users of kCFI besides the Linux kernel (but please > correct me if I'm wrong). There are firmware projects that use KCFI, but AFAIK none of them run on x86. I'm also fairly certain that only Linux performs runtime patching based on the code seq

[clang] Clang/Preprocessor: Support short circuit in directive (PR #123912)

2025-01-22 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa created https://github.com/llvm/llvm-project/pull/123912 Don't Evaluate RHS in if directive when short circuit. Examples include #if 0 && another_condition #if 1 || another_condition >From 43ec3fe59bd5f1000e484fa98f323b1512a5e892 Mon Sep 17 00:00:00 2001 From: Y

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2025-01-22 Thread Timm Baeder via cfe-commits
tbaederr wrote: Just a `s/both/expected/` in those two lines should be enough https://github.com/llvm/llvm-project/pull/95474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2025-01-22 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Thank you. https://github.com/llvm/llvm-project/pull/95474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Clang/Preprocessor: Support short circuit in directive (PR #123912)

2025-01-22 Thread via cfe-commits
cor3ntin wrote: Can you explain the motivation for this change? Thanks https://github.com/llvm/llvm-project/pull/123912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Fix crash/compiler error due broken AST links (PR #123648)

2025-01-22 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/123648 >From e5cd06ddbc4193f9d5910eba93f0eb309d67063c Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Mon, 20 Jan 2025 09:03:25 -0800 Subject: [PATCH 1/3] [C++20][Modules] Fix crash/compiler error due broken AS

[clang] [Driver][ASan] Refactor Clang-Driver "Sanitizer Bitcode" linking. (PR #123922)

2025-01-22 Thread Matt Arsenault via cfe-commits
@@ -70,6 +70,10 @@ def err_drv_no_rocm_device_lib : Error< "cannot find ROCm device library%select{| for %1| for ABI version %1}0; provide its path via " "'--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to build " "without ROCm device library">; +def err_d

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2025-01-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/20475 Here is

[clang] [C++20][Modules] Fix crash/compiler error due broken AST links (PR #123648)

2025-01-22 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/123648 >From e5cd06ddbc4193f9d5910eba93f0eb309d67063c Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Mon, 20 Jan 2025 09:03:25 -0800 Subject: [PATCH 1/7] [C++20][Modules] Fix crash/compiler error due broken AS

[clang] [C++20][Modules] Fix crash/compiler error due broken AST links (PR #123648)

2025-01-22 Thread Dmitry Polukhin via cfe-commits
@@ -799,14 +813,14 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) { } if (D->getFriendObjectKind()) { -// For a function defined inline within a class template, we have to force -// the canonical definition to be the one inside the canonical definition

[clang] [clang][ExprConst] Avoid initializer diags if there is no init (PR #123925)

2025-01-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/123925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-reorder-fields] Reorder leading comments (PR #123740)

2025-01-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang-tools-extra,clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/11498 Here is the rel

[clang-tools-extra] [clang-tidy] Add EnableQtSupport option to modernize-use-integer-sign-comprison (PR #122127)

2025-01-22 Thread via cfe-commits
https://github.com/qt-tatiana edited https://github.com/llvm/llvm-project/pull/122127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6b486f4 - [Clang][Arch] Disable mve.fp when explicit -mfpu option (#123028)

2025-01-22 Thread via cfe-commits
Author: flopop01 Date: 2025-01-22T15:49:19Z New Revision: 6b486f458fe40919577d9249fa754daa913795d1 URL: https://github.com/llvm/llvm-project/commit/6b486f458fe40919577d9249fa754daa913795d1 DIFF: https://github.com/llvm/llvm-project/commit/6b486f458fe40919577d9249fa754daa913795d1.diff LOG: [Cla

[clang] [Clang][Arch] Disable mve.fp when explicit -mfpu option (PR #123028)

2025-01-22 Thread via cfe-commits
github-actions[bot] wrote: @flopop01 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)

2025-01-22 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/123959 I'm not sure why the test is larger for RISC-V than other targets, but we saw this before with #111360. The file is just over the current 60KB limit: ``` 62772 /home/asb/llvm-project/build/stage2/tools/clang/test/

[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)

2025-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Alex Bradbury (asb) Changes I'm not sure why the test is larger for RISC-V than other targets, but we saw this before with #111360. The file is just over the current 60KB limit: ``` 62772 /home/asb/llvm-project/build/stage2/tool

[clang] [C++20] [Modules] Fix may-be incorrect ADL for module local entities (PR #123931)

2025-01-22 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/123931 >From d83d7bd83cd6bd635420ec4e824afa299f20c154 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Wed, 22 Jan 2025 11:41:55 +0800 Subject: [PATCH] [C++20] [Modules] Fix may-be incorrect ADL for module local ent

  1   2   3   4   5   >