[clang-tools-extra] 361f363 - [clang-tidy]fix incorrect fix-it for the string contains a user-defined suffix (#122901)

2025-01-17 Thread via cfe-commits
Author: Congcong Cai Date: 2025-01-17T21:41:48+08:00 New Revision: 361f363c11265c6ce599a49dd081bab606b14de8 URL: https://github.com/llvm/llvm-project/commit/361f363c11265c6ce599a49dd081bab606b14de8 DIFF: https://github.com/llvm/llvm-project/commit/361f363c11265c6ce599a49dd081bab606b14de8.diff

[clang] clang/limits.h: Avoid including limits.h twice (PR #120526)

2025-01-17 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > but that leads to the question of: why is including musl's limits.h a > > problem? > > If we build `glibc` on `Alpine` with clang, we will meet the problem like > > ``` > ./include/bits/xopen_lim.h:84:10: warning: "NL_NMAX" redefined >84 | # define NL_NMAXIN

[clang] [clang][bytecode] Fix rejecting invalid sizeof expressions (PR #123332)

2025-01-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/123332 Emit the invalid note instead of nothing. >From 3b04b61f352684331c919e716eb1a3589f855125 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 17 Jan 2025 14:11:08 +0100 Subject: [PATCH] [cla

[clang] [clang][Sema] Move computing best enum types to a separate function (PR #120965)

2025-01-17 Thread Ilia Kuklin via cfe-commits
https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/120965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Move computing enum width and type to a separate function (PR #120965)

2025-01-17 Thread Ilia Kuklin via cfe-commits
https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/120965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f597d34 - [clang][Sema] Move computing best enum types to a separate function (#120965)

2025-01-17 Thread via cfe-commits
Author: Ilia Kuklin Date: 2025-01-17T18:23:07+05:00 New Revision: f597d346ab6e42cbfe421b153abf7ece6b592f1d URL: https://github.com/llvm/llvm-project/commit/f597d346ab6e42cbfe421b153abf7ece6b592f1d DIFF: https://github.com/llvm/llvm-project/commit/f597d346ab6e42cbfe421b153abf7ece6b592f1d.diff L

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-17 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: > This expression is indeed error-prone, but the problem is not the use of isa > but the use of the method getMemorySpace() My bad! You are right, it is not the `isa`. :) > this error-prone situation will be resolved soon in a follow-up commit I think it would be nice if w

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-17 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Please resolve open feedback items before the next round of reviews. Thanks. Sorry I might have been ahead of myself! I think this time I might have gotten it. https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing

[clang] [flang] Revert "Revert "Revert "[Flang][Driver] Add a flag to control zero initializa…" (PR #123330)

2025-01-17 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang,flang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11896 Here is

[clang] [llvm] [AArch64] FEAT_SPEv1p2 is optional in v8.7-A and v9.2-A (PR #123336)

2025-01-17 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm approved this pull request. LGTM, assuming no objections to CPU changes. https://github.com/llvm/llvm-project/pull/123336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-17 Thread kadir çetinkaya via cfe-commits
@@ -36,11 +38,16 @@ namespace clangd { /// `[:partition-name]`. So module names covers partitions. class ProjectModules { public: + using CommandProvider = + llvm::unique_function; kadircet wrote: this looks like a command-mangler, rather than command-p

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-17 Thread kadir çetinkaya via cfe-commits
@@ -191,6 +211,29 @@ export module M; EXPECT_TRUE(MInfo->canReuse(*Invocation, FS.view(TestDir))); } +TEST_F(PrerequisiteModulesTests, ModuleWithArgumentPatch) { + MockDirectoryCompilationDatabase CDB(TestDir, FS); + + CDB.addExtraClangFlag("-invalid-unknown-flag"); + + C

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-17 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet requested changes to this pull request. thanks for working on this! https://github.com/llvm/llvm-project/pull/122606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-17 Thread kadir çetinkaya via cfe-commits
@@ -48,7 +51,8 @@ class ModuleDependencyScanner { }; /// Scanning the single file specified by \param FilePath. - std::optional scan(PathRef FilePath); + std::optional scan(PathRef FilePath, + CommandProvider const &Provider); --

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-17 Thread kadir çetinkaya via cfe-commits
@@ -9,8 +9,10 @@ #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_PROJECTMODULES_H #define LLVM_CLANG_TOOLS_EXTRA_CLANGD_PROJECTMODULES_H +#include "support/Function.h" #include "support/Path.h" #include "support/ThreadsafeFS.h" +#include "clang/Tooling/CompilationDatabase.h" -

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-17 Thread kadir çetinkaya via cfe-commits
@@ -191,6 +211,29 @@ export module M; EXPECT_TRUE(MInfo->canReuse(*Invocation, FS.view(TestDir))); } +TEST_F(PrerequisiteModulesTests, ModuleWithArgumentPatch) { + MockDirectoryCompilationDatabase CDB(TestDir, FS); + + CDB.addExtraClangFlag("-invalid-unknown-flag"); + + C

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-17 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/122606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-17 Thread kadir çetinkaya via cfe-commits
@@ -32,6 +32,9 @@ namespace { /// interfere with each other. class ModuleDependencyScanner { public: + using CommandProvider = kadircet wrote: nit: let's use the one from `ProjectModules` rather than duplicating it here https://github.com/llvm/llvm-project/p

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-17 Thread kadir çetinkaya via cfe-commits
@@ -39,7 +40,25 @@ class MockDirectoryCompilationDatabase : public MockCompilationDatabase { void addFile(llvm::StringRef Path, llvm::StringRef Contents); std::unique_ptr getProjectModules(PathRef) const override { -return scanningProjectModules(MockedCDBPtr, TFS); +

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-17 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Aldo, update OpenMPSupport page Question about this. I see that the table for `OpenMP 6.0 Implementation Details` chapter has an entry for `Loop transformation constructs`. Should the `#pragma omp stripe` be listed here as a bullet item? Do you have a preference of how this

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl converted_to_draft https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate braces in macro definitions (PR #123279)

2025-01-17 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. This looks like it could solve some long running limitations, thank you for this one! https://github.com/llvm/llvm-project/pull/123279 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [flang] Revert "Revert "Revert "[Flang][Driver] Add a flag to control zero initializa…" (PR #123330)

2025-01-17 Thread via cfe-commits
jeanPerier wrote: The determinism of the failure with this patch is disturbing and I think I now know why: you are adding a test with `module m1` (in flang/test/Lower/zero_init.f90), which is likely the source of the clash since `module_use.f90` is reading a module also named m1. This means y

[clang] [mutation analyzer] enhance stability for `hasAnyInit` matcher (PR #122915)

2025-01-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/122915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] eb7dea8 - [mutation analyzer] enhance stability for `hasAnyInit` matcher (#122915)

2025-01-17 Thread via cfe-commits
Author: Congcong Cai Date: 2025-01-17T22:14:23+08:00 New Revision: eb7dea8bb15a00930b676f78f3b850079e2b964c URL: https://github.com/llvm/llvm-project/commit/eb7dea8bb15a00930b676f78f3b850079e2b964c DIFF: https://github.com/llvm/llvm-project/commit/eb7dea8bb15a00930b676f78f3b850079e2b964c.diff

[clang] 0171e56 - [clang][bytecode] Fix rejecting invalid sizeof expressions (#123332)

2025-01-17 Thread via cfe-commits
Author: Timm Baeder Date: 2025-01-17T15:14:47+01:00 New Revision: 0171e56ed0b2bb0c87c48e0895f5052986fa3cda URL: https://github.com/llvm/llvm-project/commit/0171e56ed0b2bb0c87c48e0895f5052986fa3cda DIFF: https://github.com/llvm/llvm-project/commit/0171e56ed0b2bb0c87c48e0895f5052986fa3cda.diff L

[clang] [clang][bytecode] Fix rejecting invalid sizeof expressions (PR #123332)

2025-01-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/123332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

2025-01-17 Thread Michael Buch via cfe-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/122928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/106036 >From ef0f3551dbb3ce61c57a5ad044d86b504c7742e0 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 10 Sep 2024 02:35:43 +0300 Subject: [PATCH 1/5] [Clang] restrict use of attribute names reserved by the C+

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,140 @@ +; RUN: llc -mtriple=spirv-unknown-unknown -debug-pass=Structure < %s -o /dev/null 2>&1 | \ farzonl wrote: I'm using this test case to help me figure out why I'm seeing an assert fire in `SPV_INTEL_inline_assembly/inline_asm.ll`. I can remove

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

2025-01-17 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122928 >From 88125a0f3a28d49877cedfd4350ab6e0f37185ed Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 14 Jan 2025 11:33:33 + Subject: [PATCH] [clang][DebugInfo] Emit DW_AT_object_pointer on function defi

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-clang Author: Michael Buch (Michael137) Changes In https://github.com/llvm/llvm-project/pull/122897 we started attaching `DW_AT_object_pointer` to function definitions. This patch does the same but for function declaratio

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Steven Perron via cfe-commits
https://github.com/s-perron approved this pull request. I don't see any problem, but I'm not familiar with standard practices in llvm. I like having the combiner pass. https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-c

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-17 Thread Erich Keane via cfe-commits
@@ -173,6 +176,20 @@ static bool isLanguageDefinedBuiltin(const SourceManager &SourceMgr, return false; } +static bool isReservedCXXAttributeName(Preprocessor &PP, IdentifierInfo *II) { + const LangOptions &Lang = PP.getLangOpts(); + if (Lang.CPlusPlus && + hasAttrib

[clang] [llvm] [AArch64] FEAT_SPEv1p2 is optional in v8.7-A and v9.2-A (PR #123336)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oliver Stannard (ostannard) Changes The FEAT_SPEv1p2 feature (known to LLVM as FeatureSPE_EEF and +spe-eef) was incorrectly marked as a required feature of Armv8.7-A (and later), which is incorrect because it is optional, and some CPUs do

[clang] [llvm] [AArch64] FEAT_SPEv1p2 is optional in v8.7-A and v9.2-A (PR #123336)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Oliver Stannard (ostannard) Changes The FEAT_SPEv1p2 feature (known to LLVM as FeatureSPE_EEF and +spe-eef) was incorrectly marked as a required feature of Armv8.7-A (and later), which is incorrect because it is optional, and some

[clang] [llvm] [X86][AVX10.2-BF16] Remove [NE]P from intrinsic and instruction name (PR #123335)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Phoebe Wang (phoebewang) Changes Ref.: https://cdrdv2.intel.com/v1/dl/getContent/828965 --- Patch is 1.81 MiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/123335.diff 29 Files Affected:

[clang] [llvm] [AArch64] FEAT_SPEv1p2 is optional in v8.7-A and v9.2-A (PR #123336)

2025-01-17 Thread Oliver Stannard via cfe-commits
https://github.com/ostannard created https://github.com/llvm/llvm-project/pull/123336 The FEAT_SPEv1p2 feature (known to LLVM as FeatureSPE_EEF and +spe-eef) was incorrectly marked as a required feature of Armv8.7-A (and later), which is incorrect because it is optional, and some CPUs do not i

[clang] [llvm] [X86][AVX10.2-BF16] Remove [NE]P from intrinsic and instruction name (PR #123335)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: Phoebe Wang (phoebewang) Changes Ref.: https://cdrdv2.intel.com/v1/dl/getContent/828965 --- Patch is 1.81 MiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/123335.diff 29 Files Affected: - (m

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-17 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > > Allow values within the range 0-100 of init_priority to be used outside > > system library, but with a warning > > This was an intentional decision, not a bug or an oversight (I'm sorry, I > didn't see that @philnik777 had marked this a good first issue!). See #67673 > f

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-17 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > The only spot I thought was questionable to change is this lower bound check > in `ArrayBoundCheckerV2`; I think it is fine to leave unchanged for now, > thoughts? > > https://github.com/llvm/llvm-project/blob/7e0758d2ead53bd4288989b8b2eda218cd6dc34a/clang/lib/StaticAnalyzer

[clang] [llvm] [X86][AVX10.2-BF16] Remove [NE]P from intrinsic and instruction name (PR #123335)

2025-01-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1274bca2ad5befe56d82ef76100e2c294ca57ce2 ef979383a507277247d36b97572f4bf558e84305 --e

[clang] [compiler-rt] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2025-01-17 Thread Matt Arsenault via cfe-commits
@@ -179,20 +179,31 @@ bool SystemZABIInfo::isVectorArgumentType(QualType Ty) const { getContext().getTypeSize(Ty) <= 128); } -bool SystemZABIInfo::isFPArgumentType(QualType Ty) const { +// The Size argument will in case of af an overaligned single element struct +//

[clang] [compiler-rt] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2025-01-17 Thread Matt Arsenault via cfe-commits
@@ -179,20 +179,31 @@ bool SystemZABIInfo::isVectorArgumentType(QualType Ty) const { getContext().getTypeSize(Ty) <= 128); } -bool SystemZABIInfo::isFPArgumentType(QualType Ty) const { +// The Size argument will in case of af an overaligned single element struct +//

[clang] [clang] Improve the documentation for the init_priority attribute (PR #123098)

2025-01-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! Thank you for the improved docs! https://github.com/llvm/llvm-project/pull/123098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-17 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang][bytecode] Fix rejecting invalid sizeof expressions (PR #123332)

2025-01-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/123332 >From bcb3faf64f933ce4c9f1040af8eaec4d4957c09c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 17 Jan 2025 14:11:08 +0100 Subject: [PATCH] [clang][bytecode] Fix rejecting invalid sizeof

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-17 Thread Donát Nagy via cfe-commits
NagyDonat wrote: @Xazax-hun When you write that this commit "makes memspaces a bit more error prone to use. Do you think we could find a way to prevent using isa on memspaces?" do I understand it correctly you mean that it's error-prone to use `isa<...>(MR->getMemorySpace())` directly? This e

[clang] [mutation analyzer] enhance stability for `hasAnyInit` matcher (PR #122915)

2025-01-17 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: ### Merge activity * **Jan 17, 8:44 AM EST**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/122915). https://github.com/llvm/llvm-project/pull/122915

[clang] [llvm] [X86][AMX-AVX512][NFC] Remove P from intrinsic and instruction name (PR #123270)

2025-01-17 Thread Feng Zou via cfe-commits
https://github.com/fzou1 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] refactor modernize-raw-string-literal fix hint (PR #122909)

2025-01-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/122909 >From 9d80866b56ad57b3ba012c81e73788e737d8237a Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 14 Jan 2025 22:24:46 +0800 Subject: [PATCH] [clang-tidy][NFC] refactor modernize-raw-string-literal fix

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-17 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > While this is a valid concern, I don't think it's much of a problem in > reality. GCC just warns on this (not even an error by default) and I wasn't > able to find a single use outside implementations of the reserved value range. I wouldn't expect to find uses within the

[clang-tools-extra] 48d0ef1 - [clang-tidy][NFC] refactor modernize-raw-string-literal fix hint (#122909)

2025-01-17 Thread via cfe-commits
Author: Congcong Cai Date: 2025-01-17T21:47:47+08:00 New Revision: 48d0ef1a07993139e1acf65910704255443103a5 URL: https://github.com/llvm/llvm-project/commit/48d0ef1a07993139e1acf65910704255443103a5 DIFF: https://github.com/llvm/llvm-project/commit/48d0ef1a07993139e1acf65910704255443103a5.diff

[clang-tools-extra] [clang-tidy][NFC] refactor modernize-raw-string-literal fix hint (PR #122909)

2025-01-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/122909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] baa5b76 - [C++20] [Modules] Make module local decls visible to language linkage in the same module

2025-01-17 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2025-01-17T22:17:50+08:00 New Revision: baa5b769f2f76baa0ce1ebfe28236dee2c761f0d URL: https://github.com/llvm/llvm-project/commit/baa5b769f2f76baa0ce1ebfe28236dee2c761f0d DIFF: https://github.com/llvm/llvm-project/commit/baa5b769f2f76baa0ce1ebfe28236dee2c761f0d.diff LO

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-17 Thread kadir çetinkaya via cfe-commits
@@ -57,7 +61,7 @@ class ModuleDependencyScanner { /// a global module dependency scanner to monitor every file. Or we /// can simply require the build systems (or even the end users) /// to provide the map. - void globalScan(); + void globalScan(CommandProvider const &P

[clang] 48803bc - [X86][AMX-AVX512][NFC] Remove P from intrinsic and instruction name (#123270)

2025-01-17 Thread via cfe-commits
Author: Phoebe Wang Date: 2025-01-17T22:21:19+08:00 New Revision: 48803bc8c7be25745a0e623e6753261c07281b06 URL: https://github.com/llvm/llvm-project/commit/48803bc8c7be25745a0e623e6753261c07281b06 DIFF: https://github.com/llvm/llvm-project/commit/48803bc8c7be25745a0e623e6753261c07281b06.diff L

[clang] [llvm] [X86][AMX-AVX512][NFC] Remove P from intrinsic and instruction name (PR #123270)

2025-01-17 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/123270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-17 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > > Aldo, update OpenMPSupport page > > Question about this. I see that the table for `OpenMP 6.0 Implementation > Details` chapter has an entry for `Loop transformation constructs`. Should > the `#pragma omp stripe` be listed here as a bullet item? Do you have a > prefer

[clang] [llvm] [mlir] [TableGen] Only store direct superclasses in Record (PR #123072)

2025-01-17 Thread Jay Foad via cfe-commits
https://github.com/jayfoad updated https://github.com/llvm/llvm-project/pull/123072 >From f12511a0fd30c47ea08e6c126cae558215758183 Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Wed, 15 Jan 2025 13:34:41 + Subject: [PATCH 01/13] Change API of getSuperClasses --- llvm/include/llvm/TableGen/

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-17 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > > While this is a valid concern, I don't think it's much of a problem in > > reality. GCC just warns on this (not even an error by default) and I wasn't > > able to find a single use outside implementations of the reserved value > > range. > > I wouldn't expect to find use

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

2025-01-17 Thread Mészáros Gergely via cfe-commits
Maetveis wrote: Sorry I was caught up with work, and didn't find the time to look at this until now. > @Maetveis Do you have any thoughts on the following two groups of options > that are unexpectedly succeeding? I'll note that I did come across some > options for which the driver appears to

[clang] [Thread Modeling]: Resolve function pointers (PR #123357)

2025-01-17 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Thread Modeling]: Resolve function pointers (PR #123357)

2025-01-17 Thread Isaac Nudelman via cfe-commits
https://github.com/nuudlman closed https://github.com/llvm/llvm-project/pull/123357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Thread Modeling]: Resolve function pointers (PR #123357)

2025-01-17 Thread Isaac Nudelman via cfe-commits
https://github.com/nuudlman created https://github.com/llvm/llvm-project/pull/123357 None >From 41ec6ffe545cb7a2b25bda5dbbeed094e478f7df Mon Sep 17 00:00:00 2001 From: Isaac Nudelman Date: Fri, 17 Jan 2025 09:31:04 -0600 Subject: [PATCH 1/2] Declare new thread modeling checker --- clang/incl

[clang] [z/OS] add tail padding to TypeLoc if needed (PR #122761)

2025-01-17 Thread Kai Nacke via cfe-commits
redstar wrote: Change LGTM, however I think there should be a test checking the tail padding. https://github.com/llvm/llvm-project/pull/122761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [clang][bytecode] Revisit global variables separately (PR #123358)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Call `EvaluateAsInitializer()` explicitly here, so we don't abort the evaluation of the `DeflRefExpr` just because the initializer of that global variable failed. --- Full diff: https://github.com/llvm/llvm

[clang] [clang][bytecode] Revisit global variables separately (PR #123358)

2025-01-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/123358 Call `EvaluateAsInitializer()` explicitly here, so we don't abort the evaluation of the `DeflRefExpr` just because the initializer of that global variable failed. >From 8dac131d58f4c6dc4ddb58c3933e7726d65f9d3

[clang] [clang][Sema] Move computing best enum types to a separate function (PR #120965)

2025-01-17 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11900 Here is the r

[clang] [compiler-rt] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2025-01-17 Thread Ulrich Weigand via cfe-commits
uweigand wrote: > I see a lot of target specific pre-processing in clear_cache.c that either > disables this to a no-op, or does something target specific. The test itself > this is disabled for some targets. Seems reasonable to leave this as > unsupported and disable the test (for now?). Also

[clang] [PS4/PS5][Driver] Observe /target/lib for libraries (PR #123350)

2025-01-17 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd edited https://github.com/llvm/llvm-project/pull/123350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Michael Buch (Michael137) Changes In https://github.com/llvm/llvm-project/pull/122897 we started attaching `DW_AT_object_pointer` to function definitions. This patch does the same but for function declarations (which we do for imp

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2025-01-17 Thread Erich Keane via cfe-commits
erichkeane wrote: > Both 1 and 2 seems like good options @hokein @erichkeane (especially 1 is > probably something we should try to do) I like 1, but not really 2, I think we should wait for this to be reasonably complete before merging it, particularly this close to the release. I'd probabl

[clang] [PS4/PS5][Driver] Observe /target/lib for libraries (PR #123350)

2025-01-17 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd created https://github.com/llvm/llvm-project/pull/123350 On PS5, if a custom --sysroot is supplied, /target/lib should be added to the library search paths (this already occurs if the default --sysroot is not overridden). Until now, this has been hardcoded as

[clang] [PS4/PS5][Driver] Observe /target/lib for libraries (PR #123350)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Edd Dawson (playstation-edd) Changes On PS5, if a custom --sysroot is supplied, /target/lib should be added to the library search paths (this already occurs if the default --sysroot is not overridden). Until now, this has been ha

[clang] [PS4/PS5][Driver] Observe /target/lib for libraries (PR #123350)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Edd Dawson (playstation-edd) Changes On PS5, if a custom --sysroot is supplied, /target/lib should be added to the library search paths (this already occurs if the default --sysroot is not overridden). Until now, this has

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From fb1c27ea34d42b9c141fe9a2d1a5ad8584dfa0a0 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH 1/5] [SPIRV] add pre legalization instruction combine - Add the bo

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From fb1c27ea34d42b9c141fe9a2d1a5ad8584dfa0a0 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH 1/5] [SPIRV] add pre legalization instruction combine - Add the bo

[clang] [llvm] [IR] Don't set strictfp on irrelevant calls (PR #122735)

2025-01-17 Thread Serge Pavlov via cfe-commits
spavloff wrote: Thank you for your retrospective view on `strictfp`. I didn't realize how much it is related to inlining. This use case should be carefully analyzed to refine meaning of the attribute. > Clearly intrinisics don't get inlined by the Inliner. But what if an > intrinsic gets lowe

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl ready_for_review https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0417cd1 - [Clang] FunctionEffects: Correctly navigate through array types in FunctionEffectsRef::get(). (#121525)

2025-01-17 Thread via cfe-commits
Author: Doug Wyatt Date: 2025-01-17T07:11:36-08:00 New Revision: 0417cd1b3e66c06966a3685f143df9228e2444b1 URL: https://github.com/llvm/llvm-project/commit/0417cd1b3e66c06966a3685f143df9228e2444b1 DIFF: https://github.com/llvm/llvm-project/commit/0417cd1b3e66c06966a3685f143df9228e2444b1.diff LO

[clang] [Clang] FunctionEffects: Correctly navigate through array types in FunctionEffectsRef::get(). (PR #121525)

2025-01-17 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos closed https://github.com/llvm/llvm-project/pull/121525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-17 Thread Devon Loehr via cfe-commits
@@ -13386,6 +13386,62 @@ void Sema::checkNonTrivialCUnion(QualType QT, SourceLocation Loc, .visit(QT, nullptr, false); } +bool Sema::GloballyUniqueObjectMightBeAccidentallyDuplicated( +const VarDecl *dcl) { + if (!dcl || !getLangOpts().CPlusPlus)

[clang] [llvm] [X86][AMX-AVX512][NFC] Remove P from intrinsic and instruction name (PR #123270)

2025-01-17 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang,llvm` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11903 Here is

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/123359 Summary: This patch matches CUDA, moving the HIP compilation jobs to the new driver by default. The old behavior will return with `--no-offload-new-driver`. The main difference is that objects compiled with the o

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: This patch matches CUDA, moving the HIP compilation jobs to the new driver by default. The old behavior will return with `--no-offload-new-driver`. The main difference is that objects compiled with th

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: This patch matches CUDA, moving the HIP compilation jobs to the new driver by default. The old behavior will return with `--no-offload-new-driver`. The main difference is that objects compiled

[clang] [llvm] [TySan] A Type Sanitizer (Clang) (PR #76260)

2025-01-17 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Sorry for the very late review but do we have clang documentation for this? +1, we do need documentation for this before Clang 20 ships. CC @fhahn https://github.com/llvm/llvm-project/pull/76260 ___ cfe-commits mailing list cfe-

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread via cfe-commits
b-sumner wrote: Breaking any existing HIP feature is a no-go in my opinion. Textures and surfaces are important to some developers. https://github.com/llvm/llvm-project/pull/123359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread Matt Arsenault via cfe-commits
arsenm wrote: I don't follow the connection to textures https://github.com/llvm/llvm-project/pull/123359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] FEAT_SPEv1p2 is optional in v8.7-A and v9.2-A (PR #123336)

2025-01-17 Thread David Green via cfe-commits
davemgreen wrote: Is this a system-reg only extension? It was enabled in #115296, which has an explanation why it was enabled. I'm not sure how well we implement the sys-reg only extensions always being enabled idea, or if the best way to handle that is making them required features. But this

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Breaking any existing HIP feature is a no-go in my opinion. Textures and > surfaces are important to some developers. Surfaces and textures are being phased out of CUDA as far as I can tell, so I wasn't sure how relevant it was (since we can use `--no-offload-new-driver` as a

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2025-01-17 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/104661 >From 68999359723466f762d3541359b1e55421e601fb Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 17 Jan 2025 10:55:59 -0500 Subject: [PATCH] [Clang] Remove 3-element vector load and store special handling

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123283)

2025-01-17 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/123283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Avoid repeated hash lookups (NFC) (PR #123285)

2025-01-17 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/123285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-17 Thread via cfe-commits
https://github.com/el-ev updated https://github.com/llvm/llvm-project/pull/121577 >From 5551c179d4b1ed0f41885fc96fa4844c9b0435b5 Mon Sep 17 00:00:00 2001 From: Iris Shi <0...@owo.li> Date: Fri, 3 Jan 2025 23:00:14 +0800 Subject: [PATCH 1/5] fix gnu::init_priority behavior --- clang/include/cla

[clang] [clang-tools-extra] [clang][Sema] Upstream HeuristicResolver from clangd (PR #121314)

2025-01-17 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/121314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c3ba6f3 - [Modules] Delay deserialization of preferred_name attribute at r… (#122726)

2025-01-17 Thread via cfe-commits
Author: Viktoriia Bakalova Date: 2025-01-17T09:10:58+01:00 New Revision: c3ba6f378ef80d750e2278560c6f95a300114412 URL: https://github.com/llvm/llvm-project/commit/c3ba6f378ef80d750e2278560c6f95a300114412 DIFF: https://github.com/llvm/llvm-project/commit/c3ba6f378ef80d750e2278560c6f95a300114412.

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-17 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo closed https://github.com/llvm/llvm-project/pull/122726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix greatergreater (PR #122282)

2025-01-17 Thread via cfe-commits
https://github.com/andergnet updated https://github.com/llvm/llvm-project/pull/122282 >From e2780f01d47518bb61a5c01c9ad4d9daddb5044a Mon Sep 17 00:00:00 2001 From: W123011 Date: Thu, 9 Jan 2025 15:04:26 +0100 Subject: [PATCH 1/5] Fix >> behavior on continuation intenter --- clang/lib/Format/C

<    1   2   3   4   >