[clang] [HLSL] Fix global resource initialization (PR #123394)

2025-01-17 Thread Helena Kotas via cfe-commits
https://github.com/hekota ready_for_review https://github.com/llvm/llvm-project/pull/123394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Fix global resource initialization (PR #123394)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Helena Kotas (hekota) Changes Create separate resource initialization function for each resource and add them to CodeGenModule's `CXXGlobalInits` list. Fixes #120636 and addresses this [comment ](https://github.com/llvm/llvm-project/pull/1

[clang] [HLSL] Fix global resource initialization (PR #123394)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Helena Kotas (hekota) Changes Create separate resource initialization function for each resource and add them to CodeGenModule's `CXXGlobalInits` list. Fixes #120636 and addresses this [comment ](https://github.com/llvm/llvm-project/pull/

[clang] [llvm] [NVPTX] Add support for PTX 8.6 and CUDA 12.6 (12.8) (PR #123398)

2025-01-17 Thread Sergey Kozub via cfe-commits
https://github.com/sergey-kozub created https://github.com/llvm/llvm-project/pull/123398 CUDA 12.8 supports PTX 8.6 which enables architecture "sm100a" (supports Blackwell-specific instructions). CUDA 12.7 technically does not exist, map it to PTX 8.5 (same as 12.6). >From 92e4b10e940e9c08606

[clang] [HLSL] Fix global resource initialization (PR #123394)

2025-01-17 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/123394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add support for PTX 8.6 and CUDA 12.6 (12.8) (PR #123398)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Sergey Kozub (sergey-kozub) Changes CUDA 12.8 supports PTX 8.6 which enables architecture "sm100a" (supports Blackwell-specific instructions). CUDA 12.7 technically does not exist, map it to PTX 8.5 (same

[clang] [z/OS] Add option to target older versions of LE on z/OS (PR #123399)

2025-01-17 Thread Sean Perry via cfe-commits
https://github.com/perry-ca created https://github.com/llvm/llvm-project/pull/123399 Add an option similar to the -qtarget option in XL to allow the user to say they want to be able to run the generated program on an older version of the LE environment. This option will do two things: - set t

[clang] [z/OS] Add option to target older versions of LE on z/OS (PR #123399)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Sean Perry (perry-ca) Changes Add an option similar to the -qtarget option in XL to allow the user to say they want to be able to run the generated program on an older version of the LE environment. This option will do two things:

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-17 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > Will a follow-up issue be created to move the useful `Sema` helpers into a > common file? I'm fine if you want to do this as a follow up. https://github.com/llvm/llvm-project/pull/122992 ___ cfe-commits mailing list cfe-commits@list

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-17 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > This pr LGTM once the graceful exit comment is handled. > > With respect to [this > comment](https://github.com/llvm/llvm-project/pull/122992#discussion_r1917127000). > Is the final solution to just gracefully exit or is this an intermediate > step and an issue will be used t

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread via cfe-commits
b-sumner wrote: > I'd like to avoid modifying this struct to avoid breaking ABI with OpenMP. > Perhaps I should make `addr` a pointer to a struct and just GEP the two > values. Are we trying to jam a square HIP peg into a round OpenMP hole, or are we truly wanting to move to a language neutra

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Richard Smith via cfe-commits
@@ -951,28 +959,124 @@ Sema::ActOnDecompositionDeclarator(Scope *S, Declarator &D, return New; } +// CheckBindingsCount +// - Checks the arity of the structured bindings +// - Creates the resolved pack expr if there is +//one +static bool CheckBindingsCount(Sema &S, D

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Richard Smith via cfe-commits
@@ -5321,6 +5321,59 @@ class BuiltinBitCastExpr final } }; +// Represents an unexpanded pack where the list of expressions are +// known. These are used when structured bindings introduce a pack. +class ResolvedUnexpandedPackExpr final zygoloid wrote: This

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Richard Smith via cfe-commits
@@ -1099,6 +1099,13 @@ def err_lambda_capture_misplaced_ellipsis : Error< "the name of the capture">; def err_lambda_capture_multiple_ellipses : Error< "multiple ellipses in pack capture">; +def err_binding_multiple_ellipses : Error< + "multiple ellipses in structured bind

[clang] [scan-build-py] use explicit compiler wrapper paths for intercept (PR #123252)

2025-01-17 Thread László Nagy via cfe-commits
rizsotto wrote: @obiwac LGTM! https://github.com/llvm/llvm-project/pull/123252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
@@ -5321,6 +5321,59 @@ class BuiltinBitCastExpr final } }; +// Represents an unexpanded pack where the list of expressions are +// known. These are used when structured bindings introduce a pack. +class ResolvedUnexpandedPackExpr final ricejasonf wrote: I d

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `WaveActiveMax` intrinsic (PR #123428)

2025-01-17 Thread Adam Yang via cfe-commits
https://github.com/adam-yang created https://github.com/llvm/llvm-project/pull/123428 ```- add clang builtin to Builtins.td - link builtin in hlsl_intrinsics - add codegen for spirv intrinsic and two directx intrinsics to retain signedness information of the operands in C

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `WaveActiveMax` intrinsic (PR #123428)

2025-01-17 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `WaveActiveMax` intrinsic (PR #123428)

2025-01-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 22d4ff155aadf0f098dd5dc48d9038da15108937 9a0cf138d99ebc9ae18db054b4d8eaa34e8174a8 --e

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
@@ -951,28 +959,124 @@ Sema::ActOnDecompositionDeclarator(Scope *S, Declarator &D, return New; } +// CheckBindingsCount +// - Checks the arity of the structured bindings +// - Creates the resolved pack expr if there is +//one +static bool CheckBindingsCount(Sema &S, D

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Fixed the managed stuff in https://github.com/llvm/llvm-project/pull/123437, should be good enough for the foreseeable future. https://github.com/llvm/llvm-project/pull/123359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [Clang] Add [[clang::no_specializations]] (PR #101469)

2025-01-17 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Flagging what looks like a bug https://github.com/llvm/llvm-project/pull/101469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a7bca18 - [clang-format] Correctly annotate braces in macro definitions (#123279)

2025-01-17 Thread via cfe-commits
Author: Owen Pan Date: 2025-01-17T19:26:00-08:00 New Revision: a7bca1861bfcd1490319115c1027166e27f4ae27 URL: https://github.com/llvm/llvm-project/commit/a7bca1861bfcd1490319115c1027166e27f4ae27 DIFF: https://github.com/llvm/llvm-project/commit/a7bca1861bfcd1490319115c1027166e27f4ae27.diff LOG:

[clang] [llvm] [Clang] Match MSVC handling of duplicate header search paths in Microsoft compatibility modes. (PR #105738)

2025-01-17 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann updated https://github.com/llvm/llvm-project/pull/105738 >From 1c9813eef03380f0013eaedf669612566a97bce1 Mon Sep 17 00:00:00 2001 From: Tom Honermann Date: Thu, 22 Aug 2024 09:44:56 -0700 Subject: [PATCH] [Clang] Support for MSVC compatible header search path orde

[clang] [llvm] [HIP] Support managed variables using the new driver (PR #123437)

2025-01-17 Thread Matt Arsenault via cfe-commits
@@ -1221,12 +1221,31 @@ void CGNVCUDARuntime::createOffloadingEntries() { ? static_cast(llvm::offloading::OffloadGlobalNormalized) : 0); if (I.Flags.getKind() == DeviceVarFlags::Variable) { - llvm::offloading::emitOffloadingEntry( - M

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123444)

2025-01-17 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/123444 Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Literal migration

[clang] [ByteCode] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123445)

2025-01-17 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/123445 Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Literal migration

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123444)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Litera

[clang] [ByteCode] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123445)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Litera

[clang] 90696d1 - [clang][bytecode][NFC] Simplify visitDeclRef (#123380)

2025-01-17 Thread via cfe-commits
Author: Timm Baeder Date: 2025-01-18T06:18:46+01:00 New Revision: 90696d17f2d6fda87d1cb4f75cc35015ba2795c9 URL: https://github.com/llvm/llvm-project/commit/90696d17f2d6fda87d1cb4f75cc35015ba2795c9 DIFF: https://github.com/llvm/llvm-project/commit/90696d17f2d6fda87d1cb4f75cc35015ba2795c9.diff L

[clang] [clang][bytecode][NFC] Simplify visitDeclRef (PR #123380)

2025-01-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/123380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix option `BreakBinaryOperations` for operator `>>` (PR #122282)

2025-01-17 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/122282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix option `BreakBinaryOperations` for operator `>>` (PR #122282)

2025-01-17 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/122282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate braces in macro definitions (PR #123279)

2025-01-17 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/123279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix option `BreakBinaryOperations` for operator `>>` (PR #122282)

2025-01-17 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/122282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e240261 - [clang-format] Fix option `BreakBinaryOperations` for operator `>>` (#122282)

2025-01-17 Thread via cfe-commits
Author: Ander Date: 2025-01-17T19:45:10-08:00 New Revision: e2402615a5a76d46a433dfcc1de10b38a1263c9d URL: https://github.com/llvm/llvm-project/commit/e2402615a5a76d46a433dfcc1de10b38a1263c9d DIFF: https://github.com/llvm/llvm-project/commit/e2402615a5a76d46a433dfcc1de10b38a1263c9d.diff LOG: [c

[clang] [clang-format] Fix option `BreakBinaryOperations` for operator `>>` (PR #122282)

2025-01-17 Thread via cfe-commits
github-actions[bot] wrote: @andergnet Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a buil

[clang] [clang-format] Fix option `BreakBinaryOperations` for operator `>>` (PR #122282)

2025-01-17 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/122282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Younan Zhang via cfe-commits
@@ -15991,6 +15998,24 @@ TreeTransform::TransformFunctionParmPackExpr(FunctionParmPackExpr *E) { return E; } +template +ExprResult TreeTransform::TransformResolvedUnexpandedPackExpr( +ResolvedUnexpandedPackExpr *E) { + bool ArgumentChanged = false; + SmallVector NewE

[clang] [clang][bytecode][NFC] Simplify visitDeclRef (PR #123380)

2025-01-17 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot8` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/9302 Here is the relevant piece of the

[clang] [clang-tools-extra] [ast matcher] use `Matcher` instead of `DynTypedMatcher` in `TypeLocTypeMatcher` (PR #123450)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes There are no template in `TypeLocTypeMatcher`. So we do not need to use `DynTypedMatcher` which can improve performance --- Full diff: https://github.com/llvm/llvm-project/pull/123450.diff 2 File

[clang] [clang-tools-extra] [ast matcher] use `Matcher` instead of `DynTypedMatcher` in `TypeLocTypeMatcher` (PR #123450)

2025-01-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/123450 There are no template in `TypeLocTypeMatcher`. So we do not need to use `DynTypedMatcher` which can improve performance >From 959949cd5170a538e1c93d00366014f6aaf3a232 Mon Sep 17 00:00:00 2001 From: Congcon

[clang] [clang-tools-extra] [ast matcher] use `Matcher` instead of `DynTypedMatcher` in `TypeLocTypeMatcher` (PR #123450)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Congcong Cai (HerrCai0907) Changes There are no template in `TypeLocTypeMatcher`. So we do not need to use `DynTypedMatcher` which can improve performance --- Full diff: https://github.com/llvm/llvm-project/pull/123450.diff 2 Files Aff

[clang] [HLSL] Fix global resource initialization (PR #123394)

2025-01-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8fa0f0efce5fb81eb422e6d7eec74c66dafef4a3 1d04bfa8e1b138a13acf30c3fc46428d3b260569 --e

[clang] 10fdd09 - [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (#122928)

2025-01-17 Thread via cfe-commits
Author: Michael Buch Date: 2025-01-17T19:51:14Z New Revision: 10fdd09c3bda8bfc532cecf4f11babaf356554f3 URL: https://github.com/llvm/llvm-project/commit/10fdd09c3bda8bfc532cecf4f11babaf356554f3 DIFF: https://github.com/llvm/llvm-project/commit/10fdd09c3bda8bfc532cecf4f11babaf356554f3.diff LOG:

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

2025-01-17 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/122928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-17 Thread Oleksandr T. via cfe-commits
@@ -179,13 +179,15 @@ static bool isLanguageDefinedBuiltin(const SourceManager &SourceMgr, static bool isReservedCXXAttributeName(Preprocessor &PP, IdentifierInfo *II) { const LangOptions &Lang = PP.getLangOpts(); if (Lang.CPlusPlus && - hasAttribute(AttributeCommonIn

[clang] [HLSL][Sema] Fixed Diagnostics that assumed only two arguments (PR #122772)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/122772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Fix global resource initialization (PR #123394)

2025-01-17 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/123394 >From 1d04bfa8e1b138a13acf30c3fc46428d3b260569 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Fri, 17 Jan 2025 12:40:21 -0800 Subject: [PATCH 1/2] [HLSL] Fix global resource initialization Fixes #120636 ---

[clang] [Clang] Correctly propagate type aliases' unexpanded flags up to lambda (PR #122875)

2025-01-17 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. I think the change is ok, but I don't think this fixes the underlying issue. There is something generally wrong with type aliases which don't use all of their parameters, and this needs more thought. https://github.com/llvm/llvm-project/p

[clang] [llvm] [NVPTX] Add support for PTX 8.6 and CUDA 12.6 (12.8) (PR #123398)

2025-01-17 Thread Durgadoss R via cfe-commits
https://github.com/durga4github approved this pull request. The updates look good to me. https://github.com/llvm/llvm-project/pull/123398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang-tools-extra] [clang-tidy][NFC] remove unused field in UnusedUsingDeclsCheck (PR #123451)

2025-01-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/123451 None >From ebeac6c8a91fea794e25540d40356be313a82799 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 18 Jan 2025 14:13:05 +0800 Subject: [PATCH] [clang-tidy][NFC] remove unused field in UnusedUsingDe

[clang-tools-extra] [clang-tidy][NFC] remove unused field in UnusedUsingDeclsCheck (PR #123451)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/123451.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.

[clang-tools-extra] 909bf38 - [clang-tidy][NFC] remove unused field in UnusedUsingDeclsCheck (#123451)

2025-01-17 Thread via cfe-commits
Author: Congcong Cai Date: 2025-01-18T14:14:50+08:00 New Revision: 909bf38c1fea56aab91b1eb43b8c00c515157a53 URL: https://github.com/llvm/llvm-project/commit/909bf38c1fea56aab91b1eb43b8c00c515157a53 DIFF: https://github.com/llvm/llvm-project/commit/909bf38c1fea56aab91b1eb43b8c00c515157a53.diff

[clang-tools-extra] [clang-tidy][NFC] remove unused field in UnusedUsingDeclsCheck (PR #123451)

2025-01-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/123451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [ASTMatchers][NFC] use `Matcher` instead of `DynTypedMatcher` in `TypeLocTypeMatcher` (PR #123450)

2025-01-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/123450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Younan Zhang via cfe-commits
@@ -757,23 +775,40 @@ bool Sema::CheckParameterPacksForExpansion( bool HaveFirstPack = false; std::optional NumPartialExpansions; SourceLocation PartiallySubstitutedPackLoc; + typedef LocalInstantiationScope::DeclArgumentPack DeclArgumentPack; for (UnexpandedParamet

[clang-tools-extra] [clang-tidy][NFC] improve performance misc-unused-using-decls (PR #123454)

2025-01-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/123454 skip header file before register AST Matchers it can avoid to matcher lots of ast node when lint header file >From 3d4b7e8776af4a51618febb45ba55e3f3428ca64 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date:

[clang-tools-extra] [clang-tidy][NFC] improve performance misc-unused-using-decls (PR #123454)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes skip header file before register AST Matchers it can avoid to matcher lots of ast node when lint header file --- Full diff: https://github.com/llvm/llvm-project/pull/123454.diff 1 Files Aff

[clang] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

2025-01-17 Thread Chandler Carruth via cfe-commits
chandlerc wrote: Pushed an update that rebases on main, and more notably use an improved script that preserves the grouping of builtins and the comments describing them. I noticed that there were interesting and important comments here, so I reworked things so we don't lose any information. h

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

2025-01-17 Thread Michał Górny via cfe-commits
mgorny wrote: I'm going to revert because of the buildbot failures. https://github.com/llvm/llvm-project/pull/122928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this`" (PR #123455)

2025-01-17 Thread Michał Górny via cfe-commits
https://github.com/mgorny closed https://github.com/llvm/llvm-project/pull/123455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c3a935e - Revert "[clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this`" (#123455)

2025-01-17 Thread via cfe-commits
Author: Michał Górny Date: 2025-01-18T07:59:30Z New Revision: c3a935e3f967f8f22f5db240d145459ee621c1e0 URL: https://github.com/llvm/llvm-project/commit/c3a935e3f967f8f22f5db240d145459ee621c1e0 DIFF: https://github.com/llvm/llvm-project/commit/c3a935e3f967f8f22f5db240d145459ee621c1e0.diff LOG:

[clang] [llvm] Revert "[clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this`" (PR #123455)

2025-01-17 Thread Michał Górny via cfe-commits
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/123455 Reverts llvm/llvm-project#122928 From ce83c9470ba1a9860c107d39e60d9148ac009e91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Date: Sat, 18 Jan 2025 07:59:09 + Subject: [PATCH] =?UTF-8?q

[clang] [llvm] [StrTable] Switch diag group names to `llvm::StringTable` (PR #123302)

2025-01-17 Thread Chandler Carruth via cfe-commits
chandlerc wrote: > You mention the performance tradeoff of pascal strings v null terminated ones > doesn't seem too important - I guess that's based on some judgement about > where/how these are used/where the strlens end up happening that you've > looked into? Could you summarize that in a bi

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-17 Thread Deric Cheung via cfe-commits
https://github.com/Icohedron updated https://github.com/llvm/llvm-project/pull/122992 >From 7ddd5b264731ef375d99d012d9fbfd54c744e5b2 Mon Sep 17 00:00:00 2001 From: Icohedron Date: Mon, 13 Jan 2025 21:23:31 + Subject: [PATCH 1/5] Implement `reflect` HLSL function --- clang/include/clang/Ba

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
@@ -951,28 +959,124 @@ Sema::ActOnDecompositionDeclarator(Scope *S, Declarator &D, return New; } +// CheckBindingsCount +// - Checks the arity of the structured bindings +// - Creates the resolved pack expr if there is +//one +static bool CheckBindingsCount(Sema &S, D

[clang] [llvm] [StrTable] Switch diag group names to `llvm::StringTable` (PR #123302)

2025-01-17 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc updated https://github.com/llvm/llvm-project/pull/123302 >From c78d4a2fd8d04aa79bab0c65044781aa0b8ca004 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Fri, 17 Jan 2025 08:31:45 + Subject: [PATCH] Switch diagnostic group names to use `llvm::StringTable` P

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
https://github.com/ricejasonf edited https://github.com/llvm/llvm-project/pull/121417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
https://github.com/ricejasonf edited https://github.com/llvm/llvm-project/pull/121417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
https://github.com/ricejasonf edited https://github.com/llvm/llvm-project/pull/121417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [IR] Don't set strictfp on irrelevant calls (PR #122735)

2025-01-17 Thread Andy Kaylor via cfe-commits
andykaylor wrote: What's the motivation for this change? Was the strictfp attribute blocking some optimization? My understanding of the attribute is that it only indicates that strict floating-point semantics are (potentially?) required at the call site. It doesn't indicate that the called fu

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-17 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,22 @@ +; RUN: not llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o /dev/null 2>&1 | FileCheck %s +; RUN: not llc -verify-machineinstrs -O0 -mtriple=spirv32-unknown-unknown %s -o /dev/null 2>&1 | FileCheck %s +; RUN: not %if spirv-tools %{ llc -O0 -

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/122992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-17 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,22 @@ +; RUN: not llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o /dev/null 2>&1 | FileCheck %s +; RUN: not llc -verify-machineinstrs -O0 -mtriple=spirv32-unknown-unknown %s -o /dev/null 2>&1 | FileCheck %s +; RUN: not %if spirv-tools %{ llc -O0 -

[clang] [llvm] [StrTable] Switch diag group names to `llvm::StringTable` (PR #123302)

2025-01-17 Thread Chandler Carruth via cfe-commits
@@ -51,6 +53,14 @@ class StringTable { constexpr Offset() = default; constexpr Offset(unsigned Value) : Value(Value) {} +constexpr bool operator==(const Offset &RHS) const { chandlerc wrote: Doh, done. Forgot to go back to this after the iterator

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 22d4ff155aadf0f098dd5dc48d9038da15108937 782e1a28d4f8ddbeb92a9c57b3f071ba837ce129 --e

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-17 Thread Farzon Lotfi via cfe-commits
@@ -3030,6 +3031,15 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register ResVReg, return selectExtInst(ResVReg, ResType, I, CL::fract, GL::Fract); case Intrinsic::spv_normalize: return selectExtInst(ResVReg, ResType, I, CL::normalize, GL::Normalize); + case In

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread Joseph Huber via cfe-commits
jhuber6 wrote: I somehow totally forgot that I implemented surfaces and textures, it was `managed` that I was having problems with. https://github.com/llvm/llvm-project/pull/123359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-17 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,32 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 + +// RUN: %clang_cc1 -O1 -triple spirv-pc-vulkan-compute %s -emit-llvm -o - | FileCheck %s farzonl wrote: The clang codgen tests should be suf

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang,llvm` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11921 Here is the relevant

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread via cfe-commits
b-sumner wrote: > For now, it's probably easier just to put some indirection in this and pass a > struct to the first argument. It would be even easier to not make the move. Does "addr" have different meanings in each context where an offload_entry is used? Is this going to confuse the debu

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/106036 >From ef0f3551dbb3ce61c57a5ad044d86b504c7742e0 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 10 Sep 2024 02:35:43 +0300 Subject: [PATCH 1/7] [Clang] restrict use of attribute names reserved by the C+

[clang] [NFC] Avoid potential nullptr deref by using castAs<> (PR #123395)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (schittir) Changes Use castAs<> instead of getAs<> --- Full diff: https://github.com/llvm/llvm-project/pull/123395.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGBuiltin.cpp (+4-4) ``diff diff --git a/cl

[clang] [NFC] Avoid potential nullptr deref by using castAs<> (PR #123395)

2025-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (schittir) Changes Use castAs<> instead of getAs<> --- Full diff: https://github.com/llvm/llvm-project/pull/123395.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGBuiltin.cpp (+4-4) ``diff diff --git a/clang/lib/

[clang] [NFC] Avoid potential nullptr deref by using castAs<> (PR #123395)

2025-01-17 Thread via cfe-commits
https://github.com/schittir created https://github.com/llvm/llvm-project/pull/123395 Use castAs<> instead of getAs<> >From f689f19bdb7db00e6adc0db25e407e20c9c7e695 Mon Sep 17 00:00:00 2001 From: Sindhu Chittireddy Date: Fri, 17 Jan 2025 12:52:39 -0800 Subject: [PATCH] [NFC] Avoid potential nul

[clang] [compiler-rt] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2025-01-17 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: > Both clear_cache and enable_execute_stack should just be empty no-op > functions on our platform. ah - ok. I fixed clear_cache.c, and this also took care of the other test case which was calling it. https://github.com/llvm/llvm-project/pull/109164 __

[clang] eddeb36 - [SPIRV] add pre legalization instruction combine (#122839)

2025-01-17 Thread via cfe-commits
Author: Farzon Lotfi Date: 2025-01-17T14:46:14-05:00 New Revision: eddeb36cf1ced0e14e17ac90f60922366e382100 URL: https://github.com/llvm/llvm-project/commit/eddeb36cf1ced0e14e17ac90f60922366e382100 DIFF: https://github.com/llvm/llvm-project/commit/eddeb36cf1ced0e14e17ac90f60922366e382100.diff

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2025-01-17 Thread Guillot Tony via cfe-commits
https://github.com/to268 updated https://github.com/llvm/llvm-project/pull/79845 >From 16328b43eac2ddd6fe999eac68e8ae07d040f54a Mon Sep 17 00:00:00 2001 From: Guillot Tony Date: Mon, 9 Dec 2024 01:46:40 +0100 Subject: [PATCH] N3006 base --- clang/docs/ReleaseNotes.rst | 3 +-

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-01-17 Thread Paul Kirth via cfe-commits
ilovepi wrote: @PeterChou1 We're looking at using clang-doc's HTML output more seriously for Fuchsia's official documentation. If you don't have time to work on this I can devote some cycles to addressing the existing review comments and get this landed, so that we can use the new template out

[clang] [HLSL] Fix global resource initialization (PR #123394)

2025-01-17 Thread Helena Kotas via cfe-commits
https://github.com/hekota created https://github.com/llvm/llvm-project/pull/123394 Create separate resource initialization function for each resource and add them to CodeGenModule's `CXXGlobalInits` list. fixes Fixes #120636 and addresses this [comment ](https://github.com/llvm/llvm-project/p

[clang] [HIP] Move HIP to the new driver by default (PR #123359)

2025-01-17 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I'd like to avoid modifying this struct to avoid breaking ABI with OpenMP. > > Perhaps I should make `addr` a pointer to a struct and just GEP the two > > values. > > Are we trying to jam a square HIP peg into a round OpenMP hole, or are we > truly wanting to move to a lang

[clang] 04383d6 - [Static analysis] Encodes a filename before inserting it into a URL. (#120810)

2025-01-17 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2025-01-17T13:31:56-08:00 New Revision: 04383d63130a72c1280d80ec3f5a09dfdf607462 URL: https://github.com/llvm/llvm-project/commit/04383d63130a72c1280d80ec3f5a09dfdf607462 DIFF: https://github.com/llvm/llvm-project/commit/04383d63130a72c1280d80ec3f5a09dfdf607462.diff

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120810)

2025-01-17 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/120810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
@@ -15991,6 +15998,24 @@ TreeTransform::TransformFunctionParmPackExpr(FunctionParmPackExpr *E) { return E; } +template +ExprResult TreeTransform::TransformResolvedUnexpandedPackExpr( +ResolvedUnexpandedPackExpr *E) { + bool ArgumentChanged = false; + SmallVector NewE

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
@@ -1166,26 +1166,54 @@ TemplateDeclInstantiator::VisitTypeAliasTemplateDecl(TypeAliasTemplateDecl *D) { Decl *TemplateDeclInstantiator::VisitBindingDecl(BindingDecl *D) { auto *NewBD = BindingDecl::Create(SemaRef.Context, Owner, D->getLocation(), -

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
@@ -50,17 +50,29 @@ class CollectUnexpandedParameterPacksVisitor auto *FTD = FD ? FD->getDescribedFunctionTemplate() : nullptr; if (FTD && FTD->getTemplateParameters()->getDepth() >= DepthLimit) return; - } else if (getDepthAndIndex(ND).first >= D

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
@@ -1166,26 +1166,54 @@ TemplateDeclInstantiator::VisitTypeAliasTemplateDecl(TypeAliasTemplateDecl *D) { Decl *TemplateDeclInstantiator::VisitBindingDecl(BindingDecl *D) { auto *NewBD = BindingDecl::Create(SemaRef.Context, Owner, D->getLocation(), -

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-17 Thread Jason Rice via cfe-commits
@@ -757,23 +775,40 @@ bool Sema::CheckParameterPacksForExpansion( bool HaveFirstPack = false; std::optional NumPartialExpansions; SourceLocation PartiallySubstitutedPackLoc; + typedef LocalInstantiationScope::DeclArgumentPack DeclArgumentPack; for (UnexpandedParamet

  1   2   3   4   >