[clang] clang/limits.h: Avoid including limits.h twice (PR #120526)

2025-01-16 Thread YunQiang Su via cfe-commits
wzssyqa wrote: > but that leads to the question of: why is including musl's limits.h a problem? It cause some warning like ``` ./include/bits/xopen_lim.h:84:10: warning: "NL_NMAX" redefined 84 | # define NL_NMAXINT_MAX ``` https://github.com/llvm/llvm-project/pull/120526

[clang] clang/limits.h: Avoid including limits.h twice (PR #120526)

2025-01-16 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa updated https://github.com/llvm/llvm-project/pull/120526 >From cc30e98287ec0ceca490f1f6a16a0190ff243ed6 Mon Sep 17 00:00:00 2001 From: YunQiang Su Date: Thu, 19 Dec 2024 14:09:04 +0800 Subject: [PATCH] clang/limits.h: Avoid including limits.h twice The limits.h of gl

[clang] [C++20] [Modules] Makes sure internal declaration won't be found by other TU (PR #123059)

2025-01-16 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/123059 >From d0decfc63c2fef8ae659bc2133c6aee849ec19ae Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Wed, 15 Jan 2025 11:33:54 +0800 Subject: [PATCH] [C++20] [Modules] Makes sure internal declaration won't be foun

[clang-tools-extra] [clangd] Implement simple folding of preprocessor branches (rebased) (PR #121449)

2025-01-16 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/121449 >From a678fcdf6b2a5e52799f0aa08f36c3989ab30146 Mon Sep 17 00:00:00 2001 From: Ruihua Dong Date: Thu, 2 Jan 2025 08:27:33 +0500 Subject: [PATCH] [clangd] Implement simple folding of preprocessor branches Extrac

[clang] [llvm] [Clang] Match MSVC handling of duplicate header search paths in Microsoft compatibility modes. (PR #105738)

2025-01-16 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann updated https://github.com/llvm/llvm-project/pull/105738 >From 9dc8727fad50d7a808fc14173189105675cb46c9 Mon Sep 17 00:00:00 2001 From: Tom Honermann Date: Thu, 22 Aug 2024 09:44:56 -0700 Subject: [PATCH] [Clang] Support for MSVC compatible header search path orde

[clang] [clang-format] Correctly annotate braces in macro definitions (PR #123279)

2025-01-16 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/123279 Fixes #123179. >From 04b03d24d661dc8e8503269b7ddf55140e88de20 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 16 Jan 2025 19:45:33 -0800 Subject: [PATCH] [clang-format] Correctly annotate braces in macro defi

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2025-01-16 Thread Shilei Tian via cfe-commits
shiltian wrote: bump bump https://github.com/llvm/llvm-project/pull/104661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-16 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/122992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-16 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/122992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add an option to control indentation of `export { ... }` (PR #110381)

2025-01-16 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/110381 >From 570aff7459311a43cd9c9139de05dc2ab4cf762c Mon Sep 17 00:00:00 2001 From: Sirraide Date: Sat, 28 Sep 2024 20:36:38 +0200 Subject: [PATCH 1/4] [clang-format] Add an option to control indentation of `export

[clang] [clang-format] Add an option to control indentation of `export { ... }` (PR #110381)

2025-01-16 Thread via cfe-commits
@@ -26588,10 +26613,7 @@ TEST_F(FormatTest, Cpp20ModulesSupport) { " int foo;\n" "};", Style); - verifyFormat("export {\n" - " int foo;\n" - "};", - Style); + verifyFormat("export { int f

[clang] [clang-format] Add an option to control indentation of `export { ... }` (PR #110381)

2025-01-16 Thread via cfe-commits
@@ -1522,6 +1523,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { LLVMStyle.EmptyLineAfterAccessModifier = FormatStyle::ELAAMS_Never; LLVMStyle.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_LogicalBlock; LLVMStyle.ExperimentalAutoDetectBinPacking

[clang] [clang-tools-extra] [clang][Sema] Upstream HeuristicResolver from clangd (PR #121314)

2025-01-16 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. The change looks good to me. https://github.com/llvm/llvm-project/pull/121314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][Sema] Fixed Diagnostics that assumed only two arguments (PR #122772)

2025-01-16 Thread Finn Plummer via cfe-commits
@@ -1688,13 +1688,21 @@ static bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { auto *VecTyA = ArgTyA->getAs(); SourceLocation BuiltinLoc = TheCall->getBeginLoc(); + bool AllBArgAreVectors = true; for (unsigned i = 1; i < TheCall->getNumArgs(); ++i) {

[clang] [HLSL][Sema] Fixed Diagnostics that assumed only two arguments (PR #122772)

2025-01-16 Thread Finn Plummer via cfe-commits
https://github.com/inbelic approved this pull request. https://github.com/llvm/llvm-project/pull/122772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/123060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: `Lexer::findNextToken` has an additional check: `if (!Lexer::isAtEndOfMacroExpansion(Loc, SM, LangOpts, &Loc))` Does this not change behavior in the case we are replacing? I imagine folks just copied from `Lexer::findNextToken` and purposely left this out,

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread Shafik Yaghmour via cfe-commits
@@ -118,47 +118,19 @@ findMembersUsedInInitExpr(const CXXCtorInitializer *Initializer, return Results; } -/// Returns the next token after `Loc` (including comment tokens). -static std::optional getTokenAfter(SourceLocation Loc, shafik wrote: This looks li

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

2025-01-16 Thread Oliver Hunt via cfe-commits
ojhunt wrote: > > This does mean that if the preferred and explicit types have different > > storage requirements we may not warn in all possible cases, but that's a > > scenario for which the warnings are much more complex and confusing > > If I understand the patch correctly, we always warn,

[compiler-rt] [libunwind] [libunwind][cmake] Compile _Unwind* routines with -fexceptions (PR #121819)

2025-01-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `libunwind-sphinx-docs` running on `gribozavr3` while building `libunwind` at step 3 "Install pip dependencies". Full details are available at: https://lab.llvm.org/buildbot/#/builders/149/builds/34 Here is the relevant piec

[compiler-rt] [libunwind] Reapply "[Fuchsia][cmake] Allow using FatLTO when building runtimes" (#119252) (PR #121820)

2025-01-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/121820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread Ashley Hauck via cfe-commits
khyperia wrote: Looks great, thanks! https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread via cfe-commits
github-actions[bot] wrote: @khyperia Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang] 9be358f - [clang][Driver] Add -fuse-lipo option (#121231)

2025-01-16 Thread via cfe-commits
Author: Ashley Hauck Date: 2025-01-16T13:57:41-08:00 New Revision: 9be358f82e90317a28754248038f0abd5aef38fd URL: https://github.com/llvm/llvm-project/commit/9be358f82e90317a28754248038f0abd5aef38fd DIFF: https://github.com/llvm/llvm-project/commit/9be358f82e90317a28754248038f0abd5aef38fd.diff

[clang] [clang][Driver] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan closed https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread Steven Wu via cfe-commits
cachemeifyoucan wrote: Merged. Thanks for your contribution! https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Ignore noexcept on function type when computing discriminator of member function pointers (PR #109056)

2025-01-16 Thread John McCall via cfe-commits
@@ -3442,6 +3442,35 @@ uint16_t ASTContext::getPointerAuthTypeDiscriminator(QualType T) { encodeTypeForFunctionPointerAuth(*this, Out, T); } else { T = T.getUnqualifiedType(); +// Drop exception specification from member function pointer type. rj

[clang] [Clang] FunctionEffects: Correctly navigate through array types in FunctionEffectsRef::get(). (PR #121525)

2025-01-16 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/121525 >From 805b182e1a9ebe5e344943748dce6c86594495eb Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Thu, 2 Jan 2025 14:28:48 -0800 Subject: [PATCH 1/4] [Clang] FunctionEffects: Correctly navigate through array typ

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-16 Thread Oleksandr T. via cfe-commits
@@ -173,6 +176,20 @@ static bool isLanguageDefinedBuiltin(const SourceManager &SourceMgr, return false; } +static bool isReservedCXXAttributeName(Preprocessor &PP, IdentifierInfo *II) { + const LangOptions &Lang = PP.getLangOpts(); + if (Lang.CPlusPlus && + hasAttrib

[clang] [Clang] allow restrict qualifier for array types with pointer types as element types (PR #120896)

2025-01-16 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/120896 >From 295df258043ef5a87ae603eedd308b863bad7b59 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 22 Dec 2024 15:14:30 +0200 Subject: [PATCH] [Clang] allow restrict qualifier for array types with pointer

[clang] [scan-build-py] use explicit compiler wrapper paths for intercept (PR #123252)

2025-01-16 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [scan-build-py] use explicit compiler wrapper paths for intercept (PR #123252)

2025-01-16 Thread Aymeric Wibo via cfe-commits
https://github.com/obiwac created https://github.com/llvm/llvm-project/pull/123252 Previously, when using compiler wrappers (`--override-compiler`, as is default on macOS with SIP on), CC/CXX were set to just `intercept-cc/c++`, which are installed to libexec (so a priori not in PATH). This P

[clang] [scan-build-py] use explicit compiler wrapper paths for intercept (PR #123252)

2025-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aymeric Wibo (obiwac) Changes Previously, when using compiler wrappers (`--override-compiler`, as is default on macOS with SIP on), CC/CXX were set to just `intercept-cc/c++`, which are installed to libexec (so a priori not in PATH). Thi

[clang] [Clang] allow restrict qualifier for array types with pointer types as element types (PR #120896)

2025-01-16 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @AaronBallman could you review these changes? thanks https://github.com/llvm/llvm-project/pull/120896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] handle [[warn_unused]] attribute for unused private fields (PR #120734)

2025-01-16 Thread Oleksandr T. via cfe-commits
@@ -3307,6 +3307,29 @@ void Sema::CheckShadowInheritedFields(const SourceLocation &Loc, } } +template +inline static bool HasAttribute(const QualType &T) { a-tarasyuk wrote: @AaronBallman could you take a look at this issue? thanks https://github.com/llv

[clang] [scan-build-py] use explicit compiler wrapper paths for intercept (PR #123252)

2025-01-16 Thread Aymeric Wibo via cfe-commits
https://github.com/obiwac updated https://github.com/llvm/llvm-project/pull/123252 >From 11fcbaaba06ebce33f20cc862e8475736c1e046b Mon Sep 17 00:00:00 2001 From: Aymeric Wibo Date: Fri, 17 Jan 2025 00:01:25 +0100 Subject: [PATCH] [scan-build-py] use explicit compiler wrapper paths for intercept

[clang] [scan-build-py] use explicit compiler wrapper paths for intercept (PR #123252)

2025-01-16 Thread Aymeric Wibo via cfe-commits
obiwac wrote: @rizsotto https://github.com/llvm/llvm-project/pull/123252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2025-01-16 Thread via cfe-commits
https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001 From: Leijurv Date: Fri, 29 Nov 2024 21:54:36 -0600 Subject: [PATCH 01/11] [clang-format] Add BreakBeforeTemplateClose option --- clang/d

[clang] [llvm] [X86][AMX-AVX512][NFC] Remove P from intrinsic and instruction name (PR #123270)

2025-01-16 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/123270 Ref.: https://cdrdv2.intel.com/v1/dl/getContent/828965 >From 6e6058e71a13de67e4c5b78258448629b3f8b0ba Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Fri, 17 Jan 2025 10:06:13 +0800 Subject: [PATCH] [X86

[clang] [llvm] [X86][AMX-AVX512][NFC] Remove P from intrinsic and instruction name (PR #123270)

2025-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Phoebe Wang (phoebewang) Changes Ref.: https://cdrdv2.intel.com/v1/dl/getContent/828965 --- Patch is 35.87 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/123270.diff 16 Files Affected: - (mo

[clang] [llvm] [X86][AMX-AVX512][NFC] Remove P from intrinsic and instruction name (PR #123270)

2025-01-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a761e26b2364ea457b79b9a4bea6d792e4913d24 6e6058e71a13de67e4c5b78258448629b3f8b0ba --e

[compiler-rt] [libunwind] [libunwind][cmake] Compile _Unwind* routines with -fexceptions (PR #121819)

2025-01-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/121819 >From 9f952de3cb3e973f17121c057089a28bf4c6e5e0 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 6 Jan 2025 11:15:35 -0800 Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-8

[compiler-rt] [libunwind] [libunwind][cmake] Compile _Unwind* routines with -fexceptions (PR #121819)

2025-01-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/121819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] 92f1f99 - [libunwind][cmake] Compile _Unwind* routines with -fexceptions (#121819)

2025-01-16 Thread via cfe-commits
Author: Paul Kirth Date: 2025-01-16T13:44:55-08:00 New Revision: 92f1f99d2ee9ff0f928741fef4fcb58e994302df URL: https://github.com/llvm/llvm-project/commit/92f1f99d2ee9ff0f928741fef4fcb58e994302df DIFF: https://github.com/llvm/llvm-project/commit/92f1f99d2ee9ff0f928741fef4fcb58e994302df.diff LO

[clang] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread Ashley Hauck via cfe-commits
khyperia wrote: @cachemeifyoucan thank you, done! (feel free to rewrite it as well, if you want or have any nitpicks) https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread Ashley Hauck via cfe-commits
https://github.com/khyperia edited https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libunwind] Reapply "[Fuchsia][cmake] Allow using FatLTO when building runtimes" (#119252) (PR #121820)

2025-01-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/121820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libunwind] Reapply "[Fuchsia][cmake] Allow using FatLTO when building runtimes" (#119252) (PR #121820)

2025-01-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/121820 >From 2035ab40f01fd10b91f48be9c921039fa12805c4 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 6 Jan 2025 11:15:42 -0800 Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?UTF-8

[clang] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan edited https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `ppc64-flang-aix` running on `ppc64-flang-aix-test` while building `clang,flang` at step 6 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/201/builds/1461 Here i

[clang] [clang][Driver] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread Steven Wu via cfe-commits
cachemeifyoucan wrote: I updated the title and PR message. Let me know if that looks ok for you. https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [clang][Driver] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan edited https://github.com/llvm/llvm-project/pull/121231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [BoundsSan] use structured bindings (PR #123228)

2025-01-16 Thread Thurston Dang via cfe-commits
https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/123228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a98df67 - [NFC] [BoundsSan] use structured bindings (#123228)

2025-01-16 Thread via cfe-commits
Author: Florian Mayer Date: 2025-01-16T14:00:42-08:00 New Revision: a98df676140c9b3e44f6e094df40d49f53e9a89c URL: https://github.com/llvm/llvm-project/commit/a98df676140c9b3e44f6e094df40d49f53e9a89c DIFF: https://github.com/llvm/llvm-project/commit/a98df676140c9b3e44f6e094df40d49f53e9a89c.diff

[clang] [NFC] [BoundsSan] use structured bindings (PR #123228)

2025-01-16 Thread Florian Mayer via cfe-commits
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/123228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Don't treat the default switch path as unreachable when all enumerators are covered (PR #123166)

2025-01-16 Thread Jeremy Rifkin via cfe-commits
https://github.com/jeremy-rifkin updated https://github.com/llvm/llvm-project/pull/123166 >From e1ce92c0f54301cacaba316d38d44d20c6d61cb8 Mon Sep 17 00:00:00 2001 From: Jeremy Rifkin <51220084+jeremy-rif...@users.noreply.github.com> Date: Thu, 16 Jan 2025 00:27:03 -0600 Subject: [PATCH 1/3] Don't

[clang] [Clang][Analysis] Don't treat the default switch path as unreachable when all enumerators are covered (PR #123166)

2025-01-16 Thread Jeremy Rifkin via cfe-commits
https://github.com/jeremy-rifkin edited https://github.com/llvm/llvm-project/pull/123166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Analysis] Don't treat the default switch path as unreachable when all enumerators are covered (PR #123166)

2025-01-16 Thread via cfe-commits
@@ -170,16 +170,14 @@ void test_nested_switch() { } } -// Test that if all the values of an enum covered, that the 'default' branch -// is unreachable. +// Test that a warning is not emitted if the code is unreachable. enum Values { A, B, C, D }; void test_all_enums_covere

[clang] Don't treat the default switch path as unreachable when all enumerators are covered (PR #123166)

2025-01-16 Thread Jeremy Rifkin via cfe-commits
@@ -170,16 +170,14 @@ void test_nested_switch() { } } -// Test that if all the values of an enum covered, that the 'default' branch -// is unreachable. +// Test that a warning is not emitted if the code is unreachable. enum Values { A, B, C, D }; void test_all_enums_covere

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: > I rebased and the tests are passing locally. but they are still failing in ci. It's the strange part. The thing is when I created a new https://github.com/llvm/llvm-project/pull/123191 today, I see all tests passing in CI before I press Merged. That's why I thought

[clang] [HLSL][Sema] Fixed Diagnostics that assumed only two arguments (PR #122772)

2025-01-16 Thread Farzon Lotfi via cfe-commits
@@ -1688,13 +1688,21 @@ static bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { auto *VecTyA = ArgTyA->getAs(); SourceLocation BuiltinLoc = TheCall->getBeginLoc(); + bool AllBArgAreVectors = true; for (unsigned i = 1; i < TheCall->getNumArgs(); ++i) {

[clang] [Clang] Correctly propagate type aliases' unexpanded flags up to lambda (PR #122875)

2025-01-16 Thread Shafik Yaghmour via cfe-commits
@@ -47,6 +49,10 @@ template void f() { }(), ...); }(1, 2); + [](Is...) { +([] { using T = ElementType; }(), ...); shafik wrote: Out of curiosity were applying the `getCanonicalType` to `T` and getting `int` while we really wanted `ElementType`?

[clang] [PAC] Ignore noexcept on function type when computing discriminator of member function pointers (PR #109056)

2025-01-16 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/109056 >From eede4b2c2916a3016643fb56f87f7601dfaff69b Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Mon, 16 Sep 2024 17:12:13 -0700 Subject: [PATCH 1/4] [PAC] Re-sign a pointer to a noexcept member function whe

[clang] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread Ashley Hauck via cfe-commits
khyperia wrote: @cachemeifyoucan Could you possibly help me get this merged? I'm not sure if your approval is enough, or if more reviewers are needed - and if so, who. Are you able to merge this if just your approval is enough? https://github.com/llvm/llvm-project/pull/121231 _

[clang] 8fa0f0e - [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (#122095)

2025-01-16 Thread via cfe-commits
Author: Martin Storsjö Date: 2025-01-16T22:49:09+02:00 New Revision: 8fa0f0efce5fb81eb422e6d7eec74c66dafef4a3 URL: https://github.com/llvm/llvm-project/commit/8fa0f0efce5fb81eb422e6d7eec74c66dafef4a3 DIFF: https://github.com/llvm/llvm-project/commit/8fa0f0efce5fb81eb422e6d7eec74c66dafef4a3.diff

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-16 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/122095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d49a2d2 - [Clang] disallow the use of asterisks preceding constructor and destructor names (#122621)

2025-01-16 Thread via cfe-commits
Author: Oleksandr T. Date: 2025-01-16T13:00:41-08:00 New Revision: d49a2d2bc9c65c787bfa04ac8ece614da48a8cd5 URL: https://github.com/llvm/llvm-project/commit/d49a2d2bc9c65c787bfa04ac8ece614da48a8cd5 DIFF: https://github.com/llvm/llvm-project/commit/d49a2d2bc9c65c787bfa04ac8ece614da48a8cd5.diff

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/122621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

2025-01-16 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/121419 >From 3f6b1d68978857035a972f49b1cfd9d9d0151be9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 1 Jan 2025 01:47:17 +0200 Subject: [PATCH 1/6] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualifi

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-16 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/106036 >From ef0f3551dbb3ce61c57a5ad044d86b504c7742e0 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 10 Sep 2024 02:35:43 +0300 Subject: [PATCH 1/4] [Clang] restrict use of attribute names reserved by the C+

[clang] [fuchsia][cmake] Add runtimes for cortex-m4 for the Fuchsia toolchain (PR #123258)

2025-01-16 Thread via cfe-commits
https://github.com/Prabhuk approved this pull request. https://github.com/llvm/llvm-project/pull/123258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] FunctionEffects: Correctly navigate through array types in FunctionEffectsRef::get(). (PR #121525)

2025-01-16 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/121525 >From 805b182e1a9ebe5e344943748dce6c86594495eb Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Thu, 2 Jan 2025 14:28:48 -0800 Subject: [PATCH 1/5] [Clang] FunctionEffects: Correctly navigate through array typ

[clang] [HLSL] cbuffer: Create host layout struct and add resource handle to AST (PR #122820)

2025-01-16 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/122820 >From 71ddb5a2b4cc8a9609410b436e896484401f5e90 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 13 Jan 2025 15:03:12 -0800 Subject: [PATCH 1/4] [HLSL] cbuffer: Create host layout struct and add resource ha

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > > > > I see also some problems in test cases > > > > > > > > > @VyacheslavLevytskyy the SPIRV test case failures are not related to my > > > change. They are also failing on main. > > > > > > I will check now. For one the reason is clear, #123191 > > I can't reproduce two o

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

2025-01-16 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/116785 >From 5f260726253e78a00d2dff02c22837ce02b49075 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Tue, 19 Nov 2024 11:55:11 +0100 Subject: [PATCH 1/6] [Clang] Consider preferred_type in bitfield warnings (#116760)

[clang] Add an off-by-default warning to complain about MSVC bitfield padding (PR #117428)

2025-01-16 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/117428 >From 3e25d7ef2e223942298078dace8979905956d05c Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Fri, 22 Nov 2024 17:53:24 +0100 Subject: [PATCH 1/7] Add an off-by-default warning to complain about MSVC bitfield

[clang] [clang] Improve the documentation for the init_priority attribute (PR #123098)

2025-01-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/123098 >From 05bb2f8554e7dab1e084738155348389284bcc36 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 15 Jan 2025 13:03:04 -0500 Subject: [PATCH 1/2] [clang] Improve the documentation for the init_priority attr

[clang] [clang-format] Fix misannotations of `<` in ternary expressions (PR #100980)

2025-01-16 Thread Alan Zhao via cfe-commits
alanzhao1 wrote: FYI this change messes up formatting of angle brackets for member function template parameters. See #123144 https://github.com/llvm/llvm-project/pull/100980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [clang] Improve the documentation for the init_priority attribute (PR #123098)

2025-01-16 Thread Louis Dionne via cfe-commits
@@ -121,11 +121,12 @@ def InitPriorityDocs : Documentation { In C++, the order in which global variables are initialized across translation units is unspecified, unlike the ordering within a single translation unit. The ``init_priority`` attribute allows you to specify a relati

[clang] [Driver][FreeBSD] Remove FreeBSD/loongarch32 support (PR #122515)

2025-01-16 Thread Brad Smith via cfe-commits
brad0 wrote: @emaste @brooksdavis https://github.com/llvm/llvm-project/pull/122515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][Sema] Fixed Diagnostics that assumed only two arguments (PR #122772)

2025-01-16 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/122772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Ignore noexcept on function type when computing discriminator of member function pointers (PR #109056)

2025-01-16 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/109056 >From eede4b2c2916a3016643fb56f87f7601dfaff69b Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Mon, 16 Sep 2024 17:12:13 -0700 Subject: [PATCH 1/3] [PAC] Re-sign a pointer to a noexcept member function whe

[clang] [llvm] [IR] Don't set strictfp on irrelevant calls (PR #122735)

2025-01-16 Thread Kevin P. Neal via cfe-commits
kpneal wrote: A recap of the history of the strictfp attribute. Originally we needed a way to prevent the Inliner from inlining a non-strictfp function into a strictfp function. We added the `strictfp` attribute to the function definition for this. Then we found that basic blocks were being o

[clang] [NFC] [BoundsSan] use structured bindings (PR #123228)

2025-01-16 Thread Florian Mayer via cfe-commits
https://github.com/fmayer ready_for_review https://github.com/llvm/llvm-project/pull/123228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] cbuffer: Create host layout structs (PR #122820)

2025-01-16 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/122820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [BoundsSan] use structured bindings (PR #123228)

2025-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Florian Mayer (fmayer) Changes This slightly simplifies the code. --- Full diff: https://github.com/llvm/llvm-project/pull/123228.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGExpr.cpp (+6-9

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-16 Thread Michael Flanders via cfe-commits
Flandini wrote: > I like the direction of this PR but at the same time it makes memspaces a bit > more error prone to use. Do you think we could find a way to prevent using > `isa` on memspaces? Do you mean moving away from a class hierarchy definition for memspaces and towards something else

[clang] Add -fuse-lipo option (PR #121231)

2025-01-16 Thread Steven Wu via cfe-commits
cachemeifyoucan wrote: @khyperia Sure, I can help you merge. Code change looks good as I don't see any open review feedback and no objection from adding the option. Can you please update the PR message to be a better formatted commit message? The squash commit will use that as commit message,

[clang] [clang][PCH] Don't try to create standalone debug-info for types marked nodebug (PR #123253)

2025-01-16 Thread Adrian Prantl via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -std=c++23 -x c++-header -emit-pch -fmodule-format=obj \ +// RUN: -o %t.pch %s \ +// RUN: -mllvm -debug-only=pchcontainer &>%t-pch.ll +// RUN: cat %t-pch.ll | FileCheck %s + adrian-prantl wrote: Don't forget the REQUIRE: a

[clang] [clang][PCH] Don't try to create standalone debug-info for types marked nodebug (PR #123253)

2025-01-16 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. That looks very correct :-) https://github.com/llvm/llvm-project/pull/123253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [fuchsia][cmake] Add runtimes for cortex-m4 for the Fuchsia toolchain (PR #123258)

2025-01-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/123258 None >From 28bf9373f5296f848f614b665bf494267a1bf40f Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Thu, 16 Jan 2025 23:48:24 + Subject: [PATCH] [fuchsia][cmake] Add runtimes for cortex-m4 for the Fuchsia

[clang] [fuchsia][cmake] Add runtimes for cortex-m4 for the Fuchsia toolchain (PR #123258)

2025-01-16 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#123258** https://app.graphite.dev/github/pr/llvm/llvm-project/123258?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1232

[clang] [fuchsia][cmake] Add runtimes for cortex-m4 for the Fuchsia toolchain (PR #123258)

2025-01-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi ready_for_review https://github.com/llvm/llvm-project/pull/123258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Don't treat the default switch path as unreachable when all enumerators are covered (PR #123166)

2025-01-16 Thread via cfe-commits
Sirraide wrote: > While it isn't technically 'unreachable', it IS by intent of the code. Is > there perhaps some sort of annotation on the struct we have that we could > skip this assumption on instead? Something that says "this enum might have > values not in the enumerator list"? Hmm, I can

[clang] Don't treat the default switch path as unreachable when all enumerators are covered (PR #123166)

2025-01-16 Thread via cfe-commits
@@ -170,16 +170,14 @@ void test_nested_switch() { } } -// Test that if all the values of an enum covered, that the 'default' branch -// is unreachable. +// Test that a warning is not emitted if the code is unreachable. enum Values { A, B, C, D }; void test_all_enums_covere

[clang] [fuchsia][cmake] Add runtimes for cortex-m4 for the Fuchsia toolchain (PR #123258)

2025-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul Kirth (ilovepi) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/123258.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+1-1) ``diff diff --git a/clang/cmake/caches/Fuchsia-s

[clang] [clang][PCH] Don't try to create standalone debug-info for types marked nodebug (PR #123253)

2025-01-16 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123253 >From 33b128cc2fd83894506f27ad730c3ac145c49f6f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 16 Jan 2025 23:02:10 + Subject: [PATCH 1/2] [clang][PCH] Don't try to create standalone debug-info fo

[clang] [libcxx] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

2025-01-16 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @ldionne could you take a look at the latest changes? thanks https://github.com/llvm/llvm-project/pull/121419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-16 Thread Deric Cheung via cfe-commits
https://github.com/Icohedron ready_for_review https://github.com/llvm/llvm-project/pull/122992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-16 Thread Michael Flanders via cfe-commits
@@ -0,0 +1,72 @@ +//===-- MemSpaces.cpp -*- C++ -*--// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

<    1   2   3   4   5   >