[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] 1819646 - [clang][refactor] Refactor `findNextTokenIncludingComments` (#123060)

2025-01-16 Thread via cfe-commits
Author: Clement Courbet Date: 2025-01-16T17:06:05+01:00 New Revision: 18196466238ff25d5c76906645ba1d92f08bd0f7 URL: https://github.com/llvm/llvm-project/commit/18196466238ff25d5c76906645ba1d92f08bd0f7 DIFF: https://github.com/llvm/llvm-project/commit/18196466238ff25d5c76906645ba1d92f08bd0f7.dif

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle closed https://github.com/llvm/llvm-project/pull/123060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/122265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread via cfe-commits
@@ -3183,10 +3183,24 @@ Expr *Expr::IgnoreUnlessSpelledInSource() { } return E; }; + + auto IgnoreImplicitCallSingleStep = [](Expr *E) { +if (auto *C = dyn_cast(E)) { + auto NumArgs = C->getNumArgs(); + if (NumArgs == 1 || + (NumArgs > 1 && isa

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo comment request. Thanks https://github.com/llvm/llvm-project/pull/122265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2025-01-16 Thread via cfe-commits
cor3ntin wrote: @antangelo @hokein What's the status here? If this is not merged by next week it won't make clang 20 (and there are unaddressed comments) Thanks! https://github.com/llvm/llvm-project/pull/98788 ___ cfe-commits mailing list cfe-commits

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -514,6 +514,78 @@ class RVInstJ +: RVInst { + bits<7> imm7; + bits<5> rs1; + bits<5> rd1; + bits<5> rd2; + + let Inst{31-27} = rd2; + let Inst{26-23} = imm7{6-3}; + let Inst{22-20} = 0b000; + let Inst{19-15} = rs1; + let Inst{14-12} = 0b100; + let Inst{11-7} = rd1

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -514,6 +514,78 @@ class RVInstJ +: RVInst { + bits<7> imm7; + bits<5> rs1; + bits<5> rd1; + bits<5> rd2; + + let Inst{31-27} = rd2; + let Inst{26-23} = imm7{6-3}; + let Inst{22-20} = 0b000; + let Inst{19-15} = rs1; + let Inst{14-12} = 0b100; + let Inst{11-7} = rd1

[clang] 66d347b - [Clang][AArch64]Make Tuple Size Optional for svluti4_lane Intrinsics (#123197)

2025-01-16 Thread via cfe-commits
Author: CarolineConcatto Date: 2025-01-16T16:13:55Z New Revision: 66d347b46fe7643c2721738d61cbdadb7edbcb8b URL: https://github.com/llvm/llvm-project/commit/66d347b46fe7643c2721738d61cbdadb7edbcb8b DIFF: https://github.com/llvm/llvm-project/commit/66d347b46fe7643c2721738d61cbdadb7edbcb8b.diff L

[clang] [Clang][AArch64]Make Tuple Size Optional for svluti4_lane Intrinsics (PR #123197)

2025-01-16 Thread via cfe-commits
https://github.com/CarolineConcatto closed https://github.com/llvm/llvm-project/pull/123197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-01-16 Thread Ashley Coleman via cfe-commits
@@ -0,0 +1,130 @@ +//=== ParseHLSLRootSignatureTest.cpp - Parse Root Signature tests -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/121394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement HLSL Flat casting (excluding splat cases) (PR #118842)

2025-01-16 Thread Chris B via cfe-commits
@@ -2412,6 +2412,102 @@ bool SemaHLSL::CheckCompatibleParameterABI(FunctionDecl *New, return HadError; } +// Generally follows PerformScalarCast, with cases reordered for +// clarity of what types are supported +bool SemaHLSL::CanPerformScalarCast(QualType SrcTy, QualType D

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-16 Thread Erich Keane via cfe-commits
@@ -3591,15 +3591,20 @@ static void handleInitPriorityAttr(Sema &S, Decl *D, const ParsedAttr &AL) { return; } + if (prioritynum < 0 || prioritynum > 65535) { erichkeane wrote: checking `<0` is silly, it is an unsigned argument. https://github.com/l

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-16 Thread Erich Keane via cfe-commits
@@ -3591,15 +3591,20 @@ static void handleInitPriorityAttr(Sema &S, Decl *D, const ParsedAttr &AL) { return; } + if (prioritynum < 0 || prioritynum > 65535) { +S.Diag(AL.getLoc(), diag::err_attribute_argument_out_of_range) +<< E->getSourceRange() << AL << 0

[clang] [clang][Sema] Move computing enum width and type to a separate function (PR #120965)

2025-01-16 Thread Ilia Kuklin via cfe-commits
kuilpd wrote: Updated code, fixed nits. @Fznamznon Does this look good to you too? https://github.com/llvm/llvm-project/pull/120965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: 2 nits, else this is on the right track. https://github.com/llvm/llvm-project/pull/121577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-01-16 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/122981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2025-01-16 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/104661 >From 06bb0e1c57e338923749826941c27b658338b540 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Thu, 16 Jan 2025 12:20:56 -0500 Subject: [PATCH] [Clang] Remove 3-element vector load and store special handling

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-01-16 Thread via cfe-commits
cor3ntin wrote: @erichkeane this is still doing lexing things in Sema, I was actually wondering if you had suggestions :D https://github.com/llvm/llvm-project/pull/117953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-01-16 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/122981 >From c1fc823abf07dfb8326b6190672d9881890bbb15 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Tue, 14 Jan 2025 22:22:45 + Subject: [PATCH 1/5] [HLSL][RootSignature] Implement Lexing of DescriptorTables

[clang] [llvm] [HLSL][RootSignature] Implement Parsing of Descriptor Tables (PR #122982)

2025-01-16 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/122982 >From 6a11fba7ecdb78b2ba1e63773a30b32109f6d78e Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Tue, 14 Jan 2025 22:22:45 + Subject: [PATCH 1/3] [HLSL][RootSignature] Implement Lexing of DescriptorTables

[clang] [clang] __STDC_NO_THREADS__ is no longer necessary for VS 2022 1939 and above (PR #117149)

2025-01-16 Thread Dipesh Sharma via cfe-commits
https://github.com/dipeshs809 updated https://github.com/llvm/llvm-project/pull/117149 >From c55e4eedcddf6bad5191eae87a01f933267b83fa Mon Sep 17 00:00:00 2001 From: dipeshs809 Date: Thu, 21 Nov 2024 17:48:22 +0530 Subject: [PATCH] [clang] guard __STDC_NO_THREADS__ defination for MSVCVersion 20

[clang] [clang][Sema] Simplify err_init_conversion_failed diagnostic message for const variables (PR #82109)

2025-01-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! I had an idea that might be an improved approach, but the general idea of the patch is great. I think this can likely land without a change to `clang/docs/ReleaseNotes.rst` because it's a minor wording improvement, but y

[clang] [clang][Sema] Simplify err_init_conversion_failed diagnostic message for const variables (PR #82109)

2025-01-16 Thread Aaron Ballman via cfe-commits
@@ -9804,12 +9804,22 @@ bool InitializationSequence::Diagnose(Sema &S, case FK_ConversionFailed: { QualType FromType = OnlyArg->getType(); -PartialDiagnostic PDiag = S.PDiag(diag::err_init_conversion_failed) - << (int)Entity.getKind() - << DestType - <

[clang] [clang][Sema] Simplify err_init_conversion_failed diagnostic message for const variables (PR #82109)

2025-01-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/82109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][Serialization] Stop including Frontend headers from Serialization (NFC) (PR #123140)

2025-01-16 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito closed https://github.com/llvm/llvm-project/pull/123140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement HLSL intialization list support (PR #123141)

2025-01-16 Thread Finn Plummer via cfe-commits
@@ -2576,3 +2576,162 @@ void SemaHLSL::processExplicitBindingsOnDecl(VarDecl *VD) { } } } + +static bool CastInitializer(Sema &S, ASTContext &Ctx, Expr *E, +llvm::SmallVectorImpl &List, +llvm::SmallVectorImpl &DestT

[clang] [HLSL] Implement HLSL intialization list support (PR #123141)

2025-01-16 Thread Finn Plummer via cfe-commits
@@ -0,0 +1,69 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -finclude-default-header -verify -Wdouble-promotion -Wconversion %s + +struct TwoFloats { + float X, Y; +}; + +struct TwoInts { + int Z, W; +}; + +struct Doggo { + int4 LegState; + int TailState; + f

[clang] [HLSL] Implement HLSL intialization list support (PR #123141)

2025-01-16 Thread Finn Plummer via cfe-commits
@@ -0,0 +1,69 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -finclude-default-header -verify -Wdouble-promotion -Wconversion %s + +struct TwoFloats { + float X, Y; +}; + +struct TwoInts { + int Z, W; +}; + +struct Doggo { + int4 LegState; + int TailState; + f

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/8] [clang][DebugInfo] Expand detection of structured bindings

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/8] [clang][DebugInfo] Expand detection of structured bindings

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-16 Thread Michael Buch via cfe-commits
@@ -3183,10 +3183,24 @@ Expr *Expr::IgnoreUnlessSpelledInSource() { } return E; }; + + auto IgnoreImplicitCallSingleStep = [](Expr *E) { +if (auto *C = dyn_cast(E)) { + auto NumArgs = C->getNumArgs(); + if (NumArgs == 1 || + (NumArgs > 1 && isa

[clang] 286f842 - [Sema] Migrate away from PointerUnion::dyn_cast (NFC) (#123158)

2025-01-16 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-01-16T08:45:03-08:00 New Revision: 286f8423c5e26df0743e47931d840b6226ae6a8c URL: https://github.com/llvm/llvm-project/commit/286f8423c5e26df0743e47931d840b6226ae6a8c DIFF: https://github.com/llvm/llvm-project/commit/286f8423c5e26df0743e47931d840b6226ae6a8c.diff L

[clang] c969964 - [AST] Migrate away from PointerUnion::dyn_cast (NFC) (#123156)

2025-01-16 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-01-16T08:44:15-08:00 New Revision: c969964e7b1e9ce231fdf032be6c14cc8cd0be88 URL: https://github.com/llvm/llvm-project/commit/c969964e7b1e9ce231fdf032be6c14cc8cd0be88 DIFF: https://github.com/llvm/llvm-project/commit/c969964e7b1e9ce231fdf032be6c14cc8cd0be88.diff L

[clang] dea4e61 - [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (#123157)

2025-01-16 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-01-16T08:44:37-08:00 New Revision: dea4e613a05cd7d7438a365beb81998b36185ed9 URL: https://github.com/llvm/llvm-project/commit/dea4e613a05cd7d7438a365beb81998b36185ed9 DIFF: https://github.com/llvm/llvm-project/commit/dea4e613a05cd7d7438a365beb81998b36185ed9.diff L

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123156)

2025-01-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/123156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123157)

2025-01-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/123157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] do not destruct fields of unions (PR #122330)

2025-01-16 Thread Jameson Nash via cfe-commits
vtjnash wrote: This roughly corresponds to 921bd20dddf5080cdb36f39c0162eb63b2d5325e in Sema, I think (@zygoloid). Maybe @tkremenek or @yronglin has done something in this part of the code recently too as reviewers and to merge this? https://github.com/llvm/llvm-project/pull/122330

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/121577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Move degrees/radians to CLC library & optimize (PR #123222)

2025-01-16 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/123222 Missing half variants were also added. The builtins are now consistently emitted in vector form (i.e., with a splat of the literal to the appropriate vector size). >From abe207cb6b90597a4f90a1db922c63ceb97

[clang] [clang] Emit @llvm.assume before streaming_compatible functions when the streaming mode is known (PR #121917)

2025-01-16 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: The two issues are sort of tied together: if the intrinsic isn't IntrNoMem, I suspect the assumption cache stops cooperating. But anyway, I guess the question is really whether we want these constructs represented explicitly in IR, to try to leverage the AssumptionCache, o

[libclc] [libclc] Move degrees/radians to CLC library & optimize (PR #123222)

2025-01-16 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: I wasn't able to verify the `half` variants with the OpenCL CTS for some obscure CTS reason. Given that they're just casting the double literal to half I think they're almost certainly correct. https://github.com/llvm/llvm-project/pull/123222

[clang] [llvm] [AArch64] Improve bcvtn2 and remove aarch64_neon_bfcvt intrinsics (PR #120363)

2025-01-16 Thread David Green via cfe-commits
@@ -323,9 +321,10 @@ bfloat16x8_t test_vcvtq_low_bf16_f32(float32x4_t a) { // CHECK-A64-NEXT: entry: // CHECK-A64-NEXT:[[TMP0:%.*]] = bitcast <8 x bfloat> [[INACTIVE:%.*]] to <16 x i8> // CHECK-A64-NEXT:[[TMP1:%.*]] = bitcast <4 x float> [[A:%.*]] to <16 x i8> -// CHE

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-16 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/106036 >From ef0f3551dbb3ce61c57a5ad044d86b504c7742e0 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 10 Sep 2024 02:35:43 +0300 Subject: [PATCH 1/3] [Clang] restrict use of attribute names reserved by the C+

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-01-16 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt edited https://github.com/llvm/llvm-project/pull/122981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-01-16 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt edited https://github.com/llvm/llvm-project/pull/122981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b311ab0 - [Clang] Fix canonicalization of pack indexing types (#123209)

2025-01-16 Thread via cfe-commits
Author: cor3ntin Date: 2025-01-16T17:50:31+01:00 New Revision: b311ab0f89980105a11f7bff5c6e7dd95d5c86fa URL: https://github.com/llvm/llvm-project/commit/b311ab0f89980105a11f7bff5c6e7dd95d5c86fa DIFF: https://github.com/llvm/llvm-project/commit/b311ab0f89980105a11f7bff5c6e7dd95d5c86fa.diff LOG:

[clang] [Clang] Fix canonicalization of pack indexing types (PR #123209)

2025-01-16 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/123209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-16 Thread Aidan Goldfarb via cfe-commits
https://github.com/AidanGoldfarb edited https://github.com/llvm/llvm-project/pull/122754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123158)

2025-01-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/123158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support AMDGPU's generic target (PR #122629)

2025-01-16 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/122629 >From 1b13d1465c90e3f6021628d723d807bdf4d155a8 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Thu, 16 Jan 2025 11:59:06 -0500 Subject: [PATCH] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to suppo

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-01-16 Thread Finn Plummer via cfe-commits
@@ -0,0 +1,130 @@ +//=== ParseHLSLRootSignatureTest.cpp - Parse Root Signature tests -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-01-16 Thread Erich Keane via cfe-commits
erichkeane wrote: > @erichkeane this is still doing lexing things in Sema, I was actually > wondering if you had suggestions :D Ah, i thought I'd mentioned on this before. Yeah, I very much would expect all of the work this is doing to be possible in the parser. Sema shouldn't be setting ra

[clang] [llvm] [InstCombine] Infer nuw for gep inbounds from base of object (PR #119225)

2025-01-16 Thread Florian Mayer via cfe-commits
fmayer wrote: > Seems like the root cause was an vectorizer bug, sent > https://github.com/llvm/llvm-project/pull/120730 that fixes it. This is landed, so from that side we could reland this. https://github.com/llvm/llvm-project/pull/119225 ___ cfe-c

[clang] [llvm] [HLSL][RootSignature] Implement Parsing of Descriptor Tables (PR #122982)

2025-01-16 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/122982 >From 6a11fba7ecdb78b2ba1e63773a30b32109f6d78e Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Tue, 14 Jan 2025 22:22:45 + Subject: [PATCH 1/6] [HLSL][RootSignature] Implement Lexing of DescriptorTables

[clang] [flang] Revert "Revert "[Flang][Driver] Add a flag to control zero initializa… (PR #123097)

2025-01-16 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan updated https://github.com/llvm/llvm-project/pull/123097 >From a58bb993f00f65ff4f4500b10c16939857ed25a0 Mon Sep 17 00:00:00 2001 From: Kiran Chandramohan Date: Wed, 15 Jan 2025 17:33:00 + Subject: [PATCH] =?UTF-8?q?Revert=20"Revert=20"[Flang][Driver]=20A

[clang] [PAC] Ignore noexcept on function type when computing discriminator of member function pointers (PR #109056)

2025-01-16 Thread Anton Korobeynikov via cfe-commits
asl wrote: Looks like ignoring `noexcept` made the everything even more cleaner :) https://github.com/llvm/llvm-project/pull/109056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-16 Thread Aidan Goldfarb via cfe-commits
https://github.com/AidanGoldfarb edited https://github.com/llvm/llvm-project/pull/122754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman @erichkeane I’ve switched back to the version without the std > check. should the diagnostic group be changed? I think we're fine to leave it as-is. https://github.com/llvm/llvm-project/pull/106036 ___ cfe-commits

[clang] [clang] Added warn-assignment-bool-context (PR #115234)

2025-01-16 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: I'm sorry it took us a while. The first step is to get the PR out of draft state. https://github.com/llvm/llvm-project/pull/115234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-16 Thread Aaron Ballman via cfe-commits
@@ -760,6 +760,7 @@ def AmbiguousMacro : DiagGroup<"ambiguous-macro">; def KeywordAsMacro : DiagGroup<"keyword-macro">; def ReservedIdAsMacro : DiagGroup<"reserved-macro-identifier">; def ReservedIdAsMacroAlias : DiagGroup<"reserved-id-macro", [ReservedIdAsMacro]>; +def Reserv

[clang] [HLSL] cbuffer: Create host layout struct and add resource handle to AST (PR #122820)

2025-01-16 Thread Chris B via cfe-commits
llvm-beanz wrote: > I was kind of hoping we might be able to generate the accesses off a handle > during codegen when the global is accessed. I'm not sure if that's possible > though. I'm concerned that this will be more complex to make work with the other CBV syntaxes. For example, the impli

[clang] 4446a98 - [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic (#118580)

2025-01-16 Thread via cfe-commits
Author: Adam Yang Date: 2025-01-16T10:35:23-08:00 New Revision: 4446a9849aaa7e33e0d544fa6501d3d851b25fd6 URL: https://github.com/llvm/llvm-project/commit/4446a9849aaa7e33e0d544fa6501d3d851b25fd6 DIFF: https://github.com/llvm/llvm-project/commit/4446a9849aaa7e33e0d544fa6501d3d851b25fd6.diff LOG

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic (PR #118580)

2025-01-16 Thread Adam Yang via cfe-commits
https://github.com/adam-yang closed https://github.com/llvm/llvm-project/pull/118580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Don't treat the default switch path as unreachable when all enumerators are covered (PR #123166)

2025-01-16 Thread Jeremy Rifkin via cfe-commits
jeremy-rifkin wrote: Hi Erich, thanks for taking a look. My preference here would be to explicitly mark the default path as unreachable as such if the intent of the code is that the code path should be unreachable, similar to how one might write: ```cpp bool is_prime(int num) { if(num < 0)

[clang] Don't treat the default switch path as unreachable when all enumerators are covered (PR #123166)

2025-01-16 Thread Erich Keane via cfe-commits
erichkeane wrote: Hmm... This isn't really my area of expertise, but I consider those types of warnings valuable. While it isn't technically 'unreachable', it IS by intent of the code. Is there perhaps some sort of annotation on the struct we have that we could skip this assumption on instead

[clang] 7dd34ba - Revert "[Wunsafe-buffer-usage] Fix false positive when const sized array is indexed by const evaluatable expressions (#119340)"

2025-01-16 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2025-01-16T09:33:01-05:00 New Revision: 7dd34baf5505d689161c3a8678322a394d7a2929 URL: https://github.com/llvm/llvm-project/commit/7dd34baf5505d689161c3a8678322a394d7a2929 DIFF: https://github.com/llvm/llvm-project/commit/7dd34baf5505d689161c3a8678322a394d7a2929.diff LO

[clang] [HLSL] Implement HLSL intialization list support (PR #123141)

2025-01-16 Thread Chris B via cfe-commits
llvm-beanz wrote: A couple notes for myself: * I need to write some AST tests * Also need to write tests to cover bit fields and unions. https://github.com/llvm/llvm-project/pull/123141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [Clang] Fix canonicalization of pack indexing types (PR #123209)

2025-01-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/123209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][AArch64][clang] Advance __FUNCTION_MULTI_VERSIONING_SUPPORT_LEVEL to ACLE Q3 (PR #123056)

2025-01-16 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/123056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a use-after-free in expression evaluation (PR #118480)

2025-01-16 Thread Viktoriia Bakalova via cfe-commits
VitaNuo wrote: > need to pass -std=c++20. > passing -DLLVM_USE_SANITIZER=Address in your cmake configuration should be > enough for that. Makes sense, I could reproduce the example. https://github.com/llvm/llvm-project/pull/118480 ___ cfe-commits mai

[clang] [Wunsafe-buffer-usage] Fix false positive when const sized array is indexed by const evaluatable expressions (PR #119340)

2025-01-16 Thread Nico Weber via cfe-commits
nico wrote: Reverted in 7dd34baf5505d689161c3a8678322a394d7a2929 for now. https://github.com/llvm/llvm-project/pull/119340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix canonicalization of pack indexing types (PR #123209)

2025-01-16 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/123209 A canonicalized pack indexing should refer to a canonicalized pattern Fixes #123033 >From 6b533adf454e59db7a4afec8b91e1770875be588 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 16 Jan 2025 15:33:01

[clang] 9033e0c - [FMV][AArch64][clang] Advance __FUNCTION_MULTI_VERSIONING_SUPPORT_LEVEL to ACLE Q3 (#123056)

2025-01-16 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2025-01-16T14:51:14Z New Revision: 9033e0c2d22c9f247eccea50ae8c975eb3468ac1 URL: https://github.com/llvm/llvm-project/commit/9033e0c2d22c9f247eccea50ae8c975eb3468ac1 DIFF: https://github.com/llvm/llvm-project/commit/9033e0c2d22c9f247eccea50ae8c975eb3468ac1.di

[clang] [llvm] [clang][Serialization] Stop including Frontend headers from Serialization (NFC) (PR #123140)

2025-01-16 Thread Jordan Rupprecht via cfe-commits
https://github.com/rupprecht approved this pull request. https://github.com/llvm/llvm-project/pull/123140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu-V2R2 (PR #123193)

2025-01-16 Thread Pengcheng Wang via cfe-commits
@@ -553,6 +553,37 @@ def XIANGSHAN_NANHU : RISCVProcessorModel<"xiangshan-nanhu", TuneZExtWFusion, TuneShiftedZExtWFusion]>; +def XIANGSHAN_KUNMINGHU : RISCVProcessorModel<"xiangshan-kunmi

[clang] [clang] Catch missing format attributes (PR #105479)

2025-01-16 Thread Budimir Aranđelović via cfe-commits
@@ -5335,6 +5335,230 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// Returns vector of format attributes. There are no two attributes with same +// arguments in r

[clang] [clang] Catch missing format attributes (PR #105479)

2025-01-16 Thread Budimir Aranđelović via cfe-commits
@@ -5335,6 +5335,230 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// Returns vector of format attributes. There are no two attributes with same +// arguments in r

[clang] [clang] Catch missing format attributes (PR #105479)

2025-01-16 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec edited https://github.com/llvm/llvm-project/pull/105479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add support for -rpath on AIX (PR #89279)

2025-01-16 Thread David Tenty via cfe-commits
https://github.com/daltenty approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/89279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2025-01-16 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec edited https://github.com/llvm/llvm-project/pull/105479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2025-01-16 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec edited https://github.com/llvm/llvm-project/pull/105479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2025-01-16 Thread Budimir Aranđelović via cfe-commits
@@ -5335,6 +5335,230 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// Returns vector of format attributes. There are no two attributes with same +// arguments in r

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: @farzonl Thank you for adding instcombine/pattern matching capabilities. LGTM overall. Maybe we should also document each transformation a bit in comments to the corresponding function, so that we clearly see what kind of input we expect to see to run the substitutio

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: I see also some problems in test cases https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diagtool] Make the BuiltinDiagnosticsByID table sorted (PR #120321)

2025-01-16 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,31 @@ +//===--- DiagnosticIDs.inc --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [diagtool] Make the BuiltinDiagnosticsByID table sorted (PR #120321)

2025-01-16 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet requested changes to this pull request. https://github.com/llvm/llvm-project/pull/120321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diagtool] Make the BuiltinDiagnosticsByID table sorted (PR #120321)

2025-01-16 Thread kadir çetinkaya via cfe-commits
kadircet wrote: we already have a concept of `DiagnosticID`. can we rename this to `AllDiagnosticKinds.inc` ? https://github.com/llvm/llvm-project/pull/120321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2025-01-16 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. Hi Momchil, I debated on this change, because it is undoing what I did previously and it is based on review feedback. The implementation is fine and correct. It is a matter of principles. I am going to approve because: 1) If we r

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2025-01-16 Thread via cfe-commits
@@ -650,6 +655,8 @@ llvm::Type *CodeGenTypes::ConvertType(QualType T) { // An ext_vector_type of Bool is really a vector of bits. llvm::Type *IRElemTy = VT->isExtVectorBoolType() ? llvm::Type::getInt1Ty(getLLVMContext()) +

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2025-01-16 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/118969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >