[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/122726 >From b61110999596363bafdc94904356840febfcfaa5 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Tue, 14 Jan 2025 14:00:48 +0100 Subject: [PATCH 1/4] [WIP][Modules] Delay deserialization of preferred_name

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread Clement Courbet via cfe-commits
@@ -118,47 +118,19 @@ findMembersUsedInInitExpr(const CXXCtorInitializer *Initializer, return Results; } -/// Returns the next token after `Loc` (including comment tokens). -static std::optional getTokenAfter(SourceLocation Loc, - co

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Chuanqi Xu via cfe-commits
@@ -3240,6 +3244,7 @@ def PreferredName : InheritableAttr { let InheritEvenIfAlreadyPresent = 1; let MeaningfulToClassTemplateDefinition = 1; let TemplateDependent = 1; + let DeferDeserialization = 1; ChuanqiXu9 wrote: Maybe it is better to add comment

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Chuanqi Xu via cfe-commits
@@ -3159,13 +3164,36 @@ Attr *ASTRecordReader::readAttr() { return New; } -/// Reads attributes from the current stream position. -void ASTRecordReader::readAttributes(AttrVec &Attrs) { +/// Reads attributes from the current stream position, advancing Idx. +/// For some attr

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/122726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: LGTM basically. https://github.com/llvm/llvm-project/pull/122726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Chuanqi Xu via cfe-commits
@@ -713,6 +713,10 @@ class Attr { // attribute may be documented under multiple categories, more than one // Documentation entry may be listed. list Documentation; + // Set to true if deserialization of this attribute must be deferred until + // the parent Decl is full

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Chuanqi Xu via cfe-commits
@@ -10079,6 +10079,11 @@ void ASTReader::finishPendingActions() { } PendingDeducedVarTypes.clear(); +// Load the delayed preferred name attributes. +for (unsigned I = 0; I != PendingDeferredAttributes.size(); ++I) + loadDeferredAttribute(PendingDeferredAtt

[clang] [diagtool] Make the BuiltinDiagnosticsByID table sorted (PR #120321)

2025-01-16 Thread Björn Pettersson via cfe-commits
@@ -0,0 +1,31 @@ +//===--- DiagnosticIDs.inc --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/123060 >From 005a730b72be1305c67f886d9a473273d7318d99 Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Wed, 15 Jan 2025 12:19:58 + Subject: [PATCH 1/4] [clang][refactor] Refactor `findNextTokenIncludingCo

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2025-01-16 Thread via cfe-commits
goldsteinn wrote: `` > Works well on Linux, generally seems fine although I still think it's worth > considering splitting out "getting-changes" into a separate shared code-base > to avoid dealing with details of calling diff for different version control > system here. Think lukel97 also te

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6affc1837537a802531a5394535f1f0b7ca865cb 66acd22f1de097e23eaafe7e5fe20168727f9d82 --e

[libclc] [libclc] Move smoothstep to CLC and optimize its codegen (PR #123183)

2025-01-16 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/123183 This commit moves the implementation of the smoothstep function to the CLC library, whilst optimizing the codegen. This commit also adds support for 'half' versions of smoothstep, which were previously mis

[libclc] [libclc] Move smoothstep to CLC and optimize its codegen (PR #123183)

2025-01-16 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: Here's an example of the difference in LLVM IR for `smoothstep(double16, double16, double16)`: https://godbolt.org/z/P9sM3Wjjn https://github.com/llvm/llvm-project/pull/123183 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[libclc] [libclc] Move smoothstep to CLC and optimize its codegen (PR #123183)

2025-01-16 Thread Fraser Cormack via cfe-commits
@@ -0,0 +1,52 @@ +/* frasercrmck wrote: I wasn't sure if the AMD copyright still applies to this copied file, so I kept it. https://github.com/llvm/llvm-project/pull/123183 ___ cfe-commits mailing list cfe-commits@lis

[clang-tools-extra] [clang-tidy][modernize] Replace memmove/memcpy with std::copy (PR #122940)

2025-01-16 Thread kadir çetinkaya via cfe-commits
kadircet wrote: > @kadircet Does the file need further changes from what I've already added? probably yes, it'd be great if you can just run https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/TidyFastChecks.py to generate the edits https://github.com/llvm/llvm-project/pul

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-16 Thread Martin Storsjö via cfe-commits
@@ -659,13 +659,21 @@ llvm::ARM::FPUKind arm::getARMTargetFeatures(const Driver &D, CPUArgFPUKind != llvm::ARM::FK_INVALID ? CPUArgFPUKind : ArchArgFPUKind; (void)llvm::ARM::getFPUFeatures(FPUKind, Features); } else { +bool Generic = true; if (!ForAS) {

[libclc] [libclc] Move smoothstep to CLC and optimize its codegen (PR #123183)

2025-01-16 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/123183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Deprecate __is_referenceable (PR #123185)

2025-01-16 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/123185 See #123078 >From c060b496d53002ce263ae43bd74153b2a89aca99 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Thu, 16 Jan 2025 12:19:03 +0100 Subject: [PATCH] [Clang] Deprecate __is_referenceable --- cl

[clang] [Clang] Deprecate __is_referenceable (PR #123185)

2025-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nikolas Klauser (philnik777) Changes See #123078 --- Full diff: https://github.com/llvm/llvm-project/pull/123185.diff 2 Files Affected: - (modified) clang/docs/LanguageExtensions.rst (+1-1) - (modified) clang/docs/ReleaseNotes.rst (+8

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-16 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,72 @@ +//===-- MemSpaces.cpp -*- C++ -*--// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-16 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun edited https://github.com/llvm/llvm-project/pull/123003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-16 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun commented: I like the direction of this PR but at the same time it makes memspaces a bit more error prone to use. Do you think we could find a way to prevent using `isa` on memspaces? https://github.com/llvm/llvm-project/pull/123003

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread Alexander Shaposhnikov via cfe-commits
@@ -118,47 +118,19 @@ findMembersUsedInInitExpr(const CXXCtorInitializer *Initializer, return Results; } -/// Returns the next token after `Loc` (including comment tokens). -static std::optional getTokenAfter(SourceLocation Loc, - co

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread Alexander Shaposhnikov via cfe-commits
https://github.com/alexander-shaposhnikov approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/123060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Pipelines] Move IPSCCP after inliner pipeline (PR #96620)

2025-01-16 Thread via cfe-commits
joshua-arch1 wrote: Are you testing your patch on LTO? Before applying your patch, the function is split into two patches: ``` 00071270 <_QMbrute_forcePdigits_2.specialized.1>: 00074630 <_QMbrute_forcePdigits_2.specialized.5>: ``` With your patch, it exhibits the same behavior. D

[clang] [Clang][Arch] Disable mve.fp when explicit -mfpu option (PR #123028)

2025-01-16 Thread Jack Styles via cfe-commits
https://github.com/Stylie777 commented: Was there any tests that need changing/updating for this? If we don't have tests for this it might be worth adding some. https://github.com/llvm/llvm-project/pull/123028 ___ cfe-commits mailing list cfe-commits@

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2025-01-16 Thread Chandler Carruth via cfe-commits
chandlerc wrote: > > Is there any hope of upgrading MSVC? I know you were looking at that, but > > not sure what progress happened there. > > I didn't go through with it and was hoping you would be able to find a > work-around. I'll start talking to people to try and do a stop-gap update to >

[clang] 3a9380f - [Multilib] Custom flags processing for library selection (#110659)

2025-01-16 Thread via cfe-commits
Author: Victor Campos Date: 2025-01-16T09:35:56Z New Revision: 3a9380f21d05eb8ced03349c8c503dc911f22621 URL: https://github.com/llvm/llvm-project/commit/3a9380f21d05eb8ced03349c8c503dc911f22621 DIFF: https://github.com/llvm/llvm-project/commit/3a9380f21d05eb8ced03349c8c503dc911f22621.diff LOG:

[clang] [Multilib] Custom flags processing for library selection (PR #110659)

2025-01-16 Thread Victor Campos via cfe-commits
https://github.com/vhscampos closed https://github.com/llvm/llvm-project/pull/110659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/123060 >From 005a730b72be1305c67f886d9a473273d7318d99 Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Wed, 15 Jan 2025 12:19:58 + Subject: [PATCH 1/5] [clang][refactor] Refactor `findNextTokenIncludingCo

[clang] [clang-cl] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--fmodule-output` (PR #121046)

2025-01-16 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > @ChuanqiXu9 are you able to have a look? Sorry, I can't test and take a deeper look on windows. From https://discourse.llvm.org/t/driver-volunteer-wanted-for-modules-support-in-driver-for-mac-ubuntu-and-windows/83768/13, I think you can CC people there or calling again ther

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-16 Thread David Spickett via cfe-commits
@@ -659,13 +659,21 @@ llvm::ARM::FPUKind arm::getARMTargetFeatures(const Driver &D, CPUArgFPUKind != llvm::ARM::FK_INVALID ? CPUArgFPUKind : ArchArgFPUKind; (void)llvm::ARM::getFPUFeatures(FPUKind, Features); } else { +bool Generic = true; if (!ForAS) {

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-16 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. My understanding is that: * This PR does not conflict with what the Debian patch does. * It in fact will fix a bug in the Debian build. * This does not change the behaviour of an unmodified Clang from a user's perspective, therefore we

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-16 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/122095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Improve bcvtn2 and remove aarch64_neon_bfcvt intrinsics (PR #120363)

2025-01-16 Thread Sjoerd Meijer via cfe-commits
@@ -323,9 +321,10 @@ bfloat16x8_t test_vcvtq_low_bf16_f32(float32x4_t a) { // CHECK-A64-NEXT: entry: // CHECK-A64-NEXT:[[TMP0:%.*]] = bitcast <8 x bfloat> [[INACTIVE:%.*]] to <16 x i8> // CHECK-A64-NEXT:[[TMP1:%.*]] = bitcast <4 x float> [[A:%.*]] to <16 x i8> -// CHE

[clang] [llvm] [IR] Convert from nocapture to captures(none) (PR #123181)

2025-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nikita Popov (nikic) Changes This PR removes the old `nocapture` attribute, replacing it with the new `captures` attribute introduced in https://github.com/llvm/llvm-project/pull/116990. This change is intended to be essentially NFC, rep

[clang] [llvm] [IR] Convert from nocapture to captures(none) (PR #123181)

2025-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-hexagon @llvm/pr-subscribers-backend-aarch64 Author: Nikita Popov (nikic) Changes This PR removes the old `nocapture` attribute, replacing it with the new `captures` attribute introduced in https://github.com/llvm/llvm-project/pull/116990. This

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2025-01-16 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/112792 >From 802764e879862541e205ba1a070824b71d2fef9a Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Thu, 17 Oct 2024 17:31:24 -0500 Subject: [PATCH 01/17] [emacs][clang-format] Add elisp API for clang-format o

[libclc] [libclc] Move smoothstep to CLC and optimize its codegen (PR #123183)

2025-01-16 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/123183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] b7e2014 - [libclc] Move smoothstep to CLC and optimize its codegen (#123183)

2025-01-16 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-01-16T11:44:09Z New Revision: b7e20147ad7c29f9624d2a071bd348a7acd63461 URL: https://github.com/llvm/llvm-project/commit/b7e20147ad7c29f9624d2a071bd348a7acd63461 DIFF: https://github.com/llvm/llvm-project/commit/b7e20147ad7c29f9624d2a071bd348a7acd63461.diff LOG

[clang] [Clang] Deprecate __is_referenceable (PR #123185)

2025-01-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu-V2R2 (PR #123193)

2025-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-clang-driver Author: Chyaka (liliumShade) Changes XiangShan-KunMingHu is the third generation of Open-source high-performance RISC-V processor developed by Beijing Institute of Open Source Chip (BOSC) , and its lates

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu-V2R2 (PR #123193)

2025-01-16 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Pipelines] Move IPSCCP after inliner pipeline (PR #96620)

2025-01-16 Thread via cfe-commits
sihuan wrote: @joshua-arch1 I tested this patch on LTO and it is consistent with what you describe. With the `-flto` option enabled is that `digits_2` has two specializations whether the patch is applied or not. However with LTO enabled, LLVM performance is comparable to GCC (in terms of numb

[clang] [flang] Revert "Revert "[Flang][Driver] Add a flag to control zero initializa… (PR #123097)

2025-01-16 Thread via cfe-commits
jeanPerier wrote: +1 with @tarunprabhu testing suggestion. I am not opposed adding the flag to bbc, but it should really not be the root cause of the issue. In the failing log, you can see that semantics mistook `y(1)` for a call ( the FIR output contains a `fir.call @_QPy(%0)`). This indeed i

[clang] [Clang][AArch64]Make Tuple Size Optional for svluti4_lane Intrinsics (PR #123197)

2025-01-16 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov approved this pull request. https://github.com/llvm/llvm-project/pull/123197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > I see also some problems in test cases @VyacheslavLevytskyy the SPIRV test case failures are not related to my change. They are also failing on main. https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-c

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread via cfe-commits
@@ -118,47 +118,19 @@ findMembersUsedInInitExpr(const CXXCtorInitializer *Initializer, return Results; } -/// Returns the next token after `Loc` (including comment tokens). -static std::optional getTokenAfter(SourceLocation Loc, - co

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: > > I see also some problems in test cases > > @VyacheslavLevytskyy the SPIRV test case failures are not related to my > change. They are also failing on main. I will check now. For one the reason is clear, https://github.com/llvm/llvm-project/pull/123191 https://g

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Viktoriia Bakalova via cfe-commits
@@ -3159,13 +3164,36 @@ Attr *ASTRecordReader::readAttr() { return New; } -/// Reads attributes from the current stream position. -void ASTRecordReader::readAttributes(AttrVec &Attrs) { +/// Reads attributes from the current stream position, advancing Idx. +/// For some attr

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/122726 >From b61110999596363bafdc94904356840febfcfaa5 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Tue, 14 Jan 2025 14:00:48 +0100 Subject: [PATCH 1/5] [WIP][Modules] Delay deserialization of preferred_name

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Viktoriia Bakalova via cfe-commits
@@ -10079,6 +10079,11 @@ void ASTReader::finishPendingActions() { } PendingDeducedVarTypes.clear(); +// Load the delayed preferred name attributes. +for (unsigned I = 0; I != PendingDeferredAttributes.size(); ++I) + loadDeferredAttribute(PendingDeferredAtt

[clang] [Clang][AArch64]Make Tuple Size Optional for svluti4_lane Intrinsics (PR #123197)

2025-01-16 Thread via cfe-commits
https://github.com/CarolineConcatto created https://github.com/llvm/llvm-project/pull/123197 The svluti4_lane intrinsic currently requires the tuple size to be specified in the intrinsic name when using a tuple type input. According to the ACLE specification, the svluti4_lane intrinsic with a

[clang] [Clang][AArch64]Make Tuple Size Optional for svluti4_lane Intrinsics (PR #123197)

2025-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (CarolineConcatto) Changes The svluti4_lane intrinsic currently requires the tuple size to be specified in the intrinsic name when using a tuple type input. According to the ACLE specification, the svluti4_lane intrinsic with a tuple

[clang] [diagtool] Make the BuiltinDiagnosticsByID table sorted (PR #120321)

2025-01-16 Thread Karl-Johan Karlsson via cfe-commits
https://github.com/karka228 updated https://github.com/llvm/llvm-project/pull/120321 >From 1ad62a9a136a5ae80c880459472a88517afe75a4 Mon Sep 17 00:00:00 2001 From: Karl-Johan Karlsson Date: Tue, 17 Dec 2024 22:48:04 +0100 Subject: [PATCH 1/3] [diagtool] Make the BuiltinDiagnosticsByID table sort

[clang] [Clang] Deprecate __is_referenceable (PR #123185)

2025-01-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM but please add the details back to the commit message before landing (makes code archeology easier on us in the future). https://github.com/llvm/llvm-project/pull/123185 ___ cfe-commits

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Chuanqi Xu via cfe-commits
@@ -83,6 +83,9 @@ class ASTRecordReader /// Returns the current value in this record, without advancing. uint64_t peekInt() { return Record[Idx]; } + /// Returns the next value in this record, without advancing. + uint64_t peekNextInt() { return Record[Idx + 1]; } --

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: > > > I see also some problems in test cases > > > > > > @VyacheslavLevytskyy the SPIRV test case failures are not related to my > > change. They are also failing on main. > > I will check now. For one the reason is clear, #123191 I can't reproduce two other fails

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM with nits. https://github.com/llvm/llvm-project/pull/122726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Intrinsics][AArch64] Add intrinsic to mask off aliasing vector lanes (PR #117007)

2025-01-16 Thread Sam Tebbs via cfe-commits
@@ -567,6 +567,9 @@ std::string SDNode::getOperationName(const SelectionDAG *G) const { case ISD::EXPERIMENTAL_VECTOR_HISTOGRAM: return "histogram"; + case ISD::EXPERIMENTAL_ALIAS_LANE_MASK: +return "alias_mask"; SamTebbs33 wrote: Done. https://g

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Chuanqi Xu via cfe-commits
@@ -3118,18 +3120,27 @@ class AttrReader { return Reader.readVersionTuple(); } + void skipInts(unsigned N) { Reader.skipInts(N); } + + unsigned getCurrentIdx() { return Reader.getIdx(); } + OMPTraitInfo *readOMPTraitInfo() { return Reader.readOMPTraitInfo(); }

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/122726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diagtool] Make the BuiltinDiagnosticsByID table sorted (PR #120321)

2025-01-16 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/120321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Intrinsics][AArch64] Add intrinsic to mask off aliasing vector lanes (PR #117007)

2025-01-16 Thread Sam Tebbs via cfe-commits
SamTebbs33 wrote: > If you want to upgrade the whilewr intrinsics (which I think sounds OK to > me), then it will need auto-update code something like in > https://github.com/llvm/llvm-project/pull/120363/files#diff-0c0305d510a076cef711c006c1d9fd78c95cade1f597d21ee46fd753e6982316. > It might b

[clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-16 Thread Nikita Popov via cfe-commits
nikic wrote: Compile-time looks fine on this one: https://llvm-compile-time-tracker.com/compare.php?from=8fb29ba287d72392bd7900c33d2a8d2149126dbe&to=fd734a392a094a573ee7fe587b9fc5f616f92a9a&stat=instructions:u https://github.com/llvm/llvm-project/pull/123152

[clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Looks like this change has some compile-time impact even if modules are not > used: > https://llvm-compile-time-tracker.com/compare.php?from=edc02351dd11cc4a39b7c541b26b71c6f36c8e55&to=7201cae106260aeb3e97d5291ff30f05076a&stat=instructions:u > It seems to add about 0.

[clang] [llvm] [Intrinsics][AArch64] Add intrinsic to mask off aliasing vector lanes (PR #117007)

2025-01-16 Thread Sam Tebbs via cfe-commits
@@ -2033,6 +2041,25 @@ bool AArch64TargetLowering::shouldExpandGetActiveLaneMask(EVT ResVT, return false; } +bool AArch64TargetLowering::shouldExpandGetAliasLaneMask( SamTebbs33 wrote: It certainly can. Done. https://github.com/llvm/llvm-project/pull/1170

[clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-16 Thread Nikita Popov via cfe-commits
nikic wrote: Thanks for the context! "I'm landing this without approval because I'm the maintainer for this component" is a lot less scary than "I'm landing this without approval because there's no time to wait on a review". https://github.com/llvm/llvm-project/pull/122887

[clang] [clang] Emit @llvm.assume before streaming_compatible functions when the streaming mode is known (PR #121917)

2025-01-16 Thread Nicholas Guy via cfe-commits
NickGuy-Arm wrote: > The assumption cache mechanism is used by a number of passes... @efriedma-quic @aemerson ping > I'm not sure it's correct to mark int_aarch64_sme_in_streaming_mode > IntrNoMem... That's fair, I had mistakenly assumed `IntrNoMem` to mean "I don't touch memory". I'll put

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Sam Elliott via cfe-commits
@@ -1448,3 +1448,18 @@ def FeatureTaggedGlobals : SubtargetFeature<"tagged-globals", "AllowTaggedGlobals", "true", "Use an instruction sequence for taking the address of a global " "that allows a memory tag in the upper address bits">; + +def FeatureVendorMIPSCMove

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Sam Elliott via cfe-commits
lenary wrote: Please can you undo these whitespace changes, given you're not really making changes to this file https://github.com/llvm/llvm-project/pull/121394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Sam Elliott via cfe-commits
https://github.com/lenary edited https://github.com/llvm/llvm-project/pull/121394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Sam Elliott via cfe-commits
https://github.com/lenary commented: Some small notes, the one about using RISCVExtension will probably have the most knock-on work (run both the llvm and the clang test suites after that change, to see where that info gets to) https://github.com/llvm/llvm-project/pull/121394 _

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Jessica Clarke via cfe-commits
@@ -62,6 +62,15 @@ static cl::opt RISCVMinimumJumpTableEntries( "riscv-min-jump-table-entries", cl::Hidden, cl::desc("Set minimum number of entries to use a jump table on RISCV")); +static cl::opt +UseLoadStorePairsOpt("riscv-load-store-pairs", jrt

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/122726 >From b61110999596363bafdc94904356840febfcfaa5 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Tue, 14 Jan 2025 14:00:48 +0100 Subject: [PATCH 1/7] [WIP][Modules] Delay deserialization of preferred_name

[clang] [Wunsafe-buffer-usage] Fix false positive when const sized array is indexed by const evaluatable expressions (PR #119340)

2025-01-16 Thread Nico Weber via cfe-commits
nico wrote: This makes clang assert on many inputs. Here's a repro: [repro.zip](https://github.com/user-attachments/files/18440860/repro.zip) ``` % ./input_file_parsers-161259.sh ... Assertion failed: (!isValueDependent() && "Expression evaluator can't be called on a dependent expression."), f

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/122726 >From b61110999596363bafdc94904356840febfcfaa5 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Tue, 14 Jan 2025 14:00:48 +0100 Subject: [PATCH 1/3] [WIP][Modules] Delay deserialization of preferred_name

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread via cfe-commits
@@ -118,47 +118,19 @@ findMembersUsedInInitExpr(const CXXCtorInitializer *Initializer, return Results; } -/// Returns the next token after `Loc` (including comment tokens). -static std::optional getTokenAfter(SourceLocation Loc, - co

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread via cfe-commits
@@ -118,47 +118,19 @@ findMembersUsedInInitExpr(const CXXCtorInitializer *Initializer, return Results; } -/// Returns the next token after `Loc` (including comment tokens). -static std::optional getTokenAfter(SourceLocation Loc, - co

[clang] [Sema] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123158)

2025-01-16 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/123158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123157)

2025-01-16 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/123157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123156)

2025-01-16 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/123156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correct the order of substituted arguments in CTAD alias guides (PR #123022)

2025-01-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/123022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][refactor] Refactor `findNextTokenIncludingComments` (PR #123060)

2025-01-16 Thread via cfe-commits
@@ -118,47 +118,19 @@ findMembersUsedInInitExpr(const CXXCtorInitializer *Initializer, return Results; } -/// Returns the next token after `Loc` (including comment tokens). -static std::optional getTokenAfter(SourceLocation Loc, - co

[clang] fd4f94d - [Clang] Correct the order of substituted arguments in CTAD alias guides (#123022)

2025-01-16 Thread via cfe-commits
Author: Younan Zhang Date: 2025-01-16T16:37:57+08:00 New Revision: fd4f94ddbf0c0f0c9d0185e6036fe51de5ab2ef3 URL: https://github.com/llvm/llvm-project/commit/fd4f94ddbf0c0f0c9d0185e6036fe51de5ab2ef3 DIFF: https://github.com/llvm/llvm-project/commit/fd4f94ddbf0c0f0c9d0185e6036fe51de5ab2ef3.diff

[clang] [Clang] Correct the order of substituted arguments in CTAD alias guides (PR #123022)

2025-01-16 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/123022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-16 Thread Viktoriia Bakalova via cfe-commits
@@ -3159,13 +3164,36 @@ Attr *ASTRecordReader::readAttr() { return New; } -/// Reads attributes from the current stream position. -void ASTRecordReader::readAttributes(AttrVec &Attrs) { +/// Reads attributes from the current stream position, advancing Idx. +/// For some attr

[clang] Add documentation for Multilib custom flags (PR #114998)

2025-01-16 Thread Victor Campos via cfe-commits
https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/114998 >From 16aa4a010c22288ba363e4ab680a38fe0b6a327d Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Mon, 13 Jan 2025 13:51:52 + Subject: [PATCH 01/12] [Multilib] Custom flags YAML parsing MIME-Version: 1.0 C

[clang] [clang-cl] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--fmodule-output` (PR #121046)

2025-01-16 Thread Sharadh Rajaraman via cfe-commits
sharadhr wrote: @ChuanqiXu9 are you able to have a look? https://github.com/llvm/llvm-project/pull/121046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add documentation for Multilib custom flags (PR #114998)

2025-01-16 Thread Victor Campos via cfe-commits
https://github.com/vhscampos edited https://github.com/llvm/llvm-project/pull/114998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add documentation for Multilib custom flags (PR #114998)

2025-01-16 Thread Victor Campos via cfe-commits
https://github.com/vhscampos closed https://github.com/llvm/llvm-project/pull/114998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 226a9d7 - Add documentation for Multilib custom flags (#114998)

2025-01-16 Thread via cfe-commits
Author: Victor Campos Date: 2025-01-16T09:53:04Z New Revision: 226a9d73eee1d36526428806c1204f82b2c1f6cd URL: https://github.com/llvm/llvm-project/commit/226a9d73eee1d36526428806c1204f82b2c1f6cd DIFF: https://github.com/llvm/llvm-project/commit/226a9d73eee1d36526428806c1204f82b2c1f6cd.diff LOG:

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -1448,3 +1448,18 @@ def FeatureTaggedGlobals : SubtargetFeature<"tagged-globals", "AllowTaggedGlobals", "true", "Use an instruction sequence for taking the address of a global " "that allows a memory tag in the upper address bits">; + +def FeatureVendorMIPSCMove

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -1448,3 +1448,18 @@ def FeatureTaggedGlobals : SubtargetFeature<"tagged-globals", "AllowTaggedGlobals", "true", "Use an instruction sequence for taking the address of a global " "that allows a memory tag in the upper address bits">; + +def FeatureVendorMIPSCMove

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,82 @@ +//===-- RISCVInstrInfoXMips.td -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [flang] Revert "Revert "[Flang][Driver] Add a flag to control zero initializa… (PR #123097)

2025-01-16 Thread Kiran Chandramohan via cfe-commits
kiranchandramohan wrote: Thanks @jeanPerier @tarunprabhu. I have created https://github.com/llvm/llvm-project/pull/123215 to use a temporary directory for the test. I will keep the bbc option in this patch as well. https://github.com/llvm/llvm-project/pull/123097 _

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-16 Thread Craig Topper via cfe-commits
@@ -109,6 +109,21 @@ def uimm7_lsb00 : RISCVOp, }]; } +// A 7-bit unsigned immediate where the least significant three bits are zero. topperc wrote: This should be defned in Mips specific file if that's the only place it is used. https://github.com/llvm/ll

  1   2   3   4   5   >