[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-15 Thread Yanzuo Liu via cfe-commits
@@ -104,7 +104,6 @@ void CodeGenFunction::EmitDecl(const Decl &D) { case Decl::Binding: case Decl::UnresolvedUsingIfExists: case Decl::HLSLBuffer: -llvm_unreachable("Declaration should not be in declstmts!"); zwuis wrote: Can we move some `case`s aft

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-15 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis commented: FYI Clang Static Analyzer (I built this branch locally) crashes when running with 'clang/test/SemaCXX/cxx2c-binding-pack.cpp'. My test command is `path/to/build/bin/clang-tidy --checks=clang-static-analyzer-core.BitwiseShift another/path/to/SemaCXX/cxx2c-bin

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-15 Thread Yanzuo Liu via cfe-commits
@@ -237,7 +237,7 @@ bool Decl::isTemplateParameterPack() const { } bool Decl::isParameterPack() const { - if (const auto *Var = dyn_cast(this)) + if (const auto *Var = dyn_cast(this)) zwuis wrote: My idea about this part of changes is adding `BindingDecl::i

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-15 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/121417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-15 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/121417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-15 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3f1a391b5eb89e53b5d026c417ae6a508d32c808 94c0e4da693faeacb108e3dc239ed56d99242b3c --e

[clang] [flang] [Flang][Driver] Deprecate Ofast (PR #101701)

2025-01-15 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu commented: Mimicking gfortran's behavior for now seems reasonable to me. We can always update the warning message later if needed. Thanks Kiran! https://github.com/llvm/llvm-project/pull/101701 ___ cfe-commits mailing l

[clang] [flang] [Flang][Driver] Deprecate Ofast (PR #101701)

2025-01-15 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu approved this pull request. https://github.com/llvm/llvm-project/pull/101701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang][Driver] Deprecate Ofast (PR #101701)

2025-01-15 Thread Tom Eccles via cfe-commits
@@ -933,10 +933,12 @@ def O : Joined<["-"], "O">, Group, def O_flag : Flag<["-"], "O">, Visibility<[ClangOption, CC1Option, FC1Option]>, Alias, AliasArgs<["1"]>; def Ofast : Joined<["-"], "Ofast">, Group, - Visibility<[ClangOption, CC1Option, FlangOption]>, - HelpTextForVar

[clang] [Clang] Correct the order of substituted arguments in CTAD alias guides (PR #123022)

2025-01-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. Seems fine, though please apply Corentin's suggestions. https://github.com/llvm/llvm-project/pull/123022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

2025-01-15 Thread via cfe-commits
@@ -0,0 +1,73 @@ +//===--- ExplicitMoveConstructorCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang] Fix false warning on reinterpret_casting unknown template type (PR #109430)

2025-01-15 Thread Arseniy Zaostrovnykh via cfe-commits
https://github.com/necto updated https://github.com/llvm/llvm-project/pull/109430 >From 3533863fd58f54d2d5570b4f593d2635e1e11aa8 Mon Sep 17 00:00:00 2001 From: Arseniy Zaostrovnykh Date: Fri, 20 Sep 2024 09:16:17 +0200 Subject: [PATCH 1/3] [clang] Fix false warning on reinterpret_casting unknow

[clang] [clang] Fix false warning on reinterpret_casting unknown template type (PR #109430)

2025-01-15 Thread Arseniy Zaostrovnykh via cfe-commits
necto wrote: > Hum, this actually need a release note, can you edit > clang/docs/ReleaseNotes.rst? Thanks Added: e0db8fb776c8 https://github.com/llvm/llvm-project/pull/109430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [Clang] Remove __is_referenceable builtin (PR #123078)

2025-01-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nikolas Klauser (philnik777) Changes `__is_referenceable` is almost unused in the wild, and the few cases I was able to find had checks around them. Since The places in the standard library where `__is_referenceable` is used have bespoke

[clang] [Clang] Remove __is_referenceable builtin (PR #123078)

2025-01-15 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/123078 `__is_referenceable` is almost unused in the wild, and the few cases I was able to find had checks around them. Since The places in the standard library where `__is_referenceable` is used have bespoke builti

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-15 Thread via cfe-commits
sivan-shani wrote: Fixed according to comments above https://github.com/llvm/llvm-project/pull/118771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang][Driver] Add a flag to control zero initialization of global v… (PR #122144)

2025-01-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-aarch64-rel-assert` running on `linaro-flang-aarch64-rel-assert` while building `clang,flang` at step 6 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/29/b

[clang] [Clang] Remove __is_referenceable builtin (PR #123078)

2025-01-15 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6affc1837537a802531a5394535f1f0b7ca865cb 3be22495bce1a182120ca0b1e17875efd5ac02f1 --e

[clang] [Clang] Document some of the implementation-defined keywords (PR #84591)

2025-01-15 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/84591 >From 46f59109c0f4902e798195128855345347ac128c Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Sat, 9 Mar 2024 02:14:36 +0100 Subject: [PATCH] [Clang] Document some of the implementation-defined keywords

[clang] [APINotes] Avoid duplicated attributes for class template instantiations (PR #122516)

2025-01-15 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/122516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2025-01-15 Thread via cfe-commits
goldsteinn wrote: > > Checking again and am still considering this patch too spesific/incomplete, > > checking vc's diff calls to git - they are considerably more involved than > > in this PR, meaning this PR will likely require follow up commits to fix > > problems _(see `vc-diff-internal`, i

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2025-01-15 Thread via cfe-commits
dyung wrote: > > @dyung -- this PR is updated with new fixes. NVPTX hopefully works and > > neither of my debugging checks fires. But there may still be some other > > failures I need to chase down, let me know? > > Hmm, looks like there are likely to be ARM and Hexagon failures remaining at

[clang] [llvm] [HLSL] Implement elementwise firstbitlow builtin (PR #116858)

2025-01-15 Thread Steven Perron via cfe-commits
s-perron wrote: The spir-v test failures are unrelated to your change. It is caused by a problem in spirv-val, and it has been fixed.Don't let that stop you from merging. https://github.com/llvm/llvm-project/pull/116858 ___ cfe-commits mailing list c

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-01-15 Thread Finn Plummer via cfe-commits
inbelic wrote: I have left the error reporting as a todo just to help with pr size, as it will require adding a good chunk of additional testing https://github.com/llvm/llvm-project/pull/122981 ___ cfe-commits mailin

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-15 Thread Baranov Victor via cfe-commits
@@ -196,3 +196,13 @@ Options // The following pointer may not become a 'int *const'. int *changing_pointee = &value; changing_pointee = &result; + +.. option:: AllowedTypes (default = '') + + A semicolon-separated list of names of types that + will be excluded fro

[clang] [llvm] [HLSL][RootSignature] Implement Parsing of Descriptor Tables (PR #122982)

2025-01-15 Thread Finn Plummer via cfe-commits
@@ -89,6 +91,72 @@ class RootSignatureLexer { } }; +class RootSignatureParser { +public: + RootSignatureParser(SmallVector &Elements, + const SmallVector &Tokens); + + // Iterates over the provided tokens and constructs the in-memory + // representati

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-15 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/122951 >From 841cfec5a0ab4ce5ce64e71facfb7becaf4340e8 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 14 Jan 2025 22:05:43 +0300 Subject: [PATCH 1/3] [clang-tidy] add AllowedTypes to misc-const-correctness -

[clang] [llvm] [HLSL] Implement elementwise firstbitlow builtin (PR #116858)

2025-01-15 Thread Steven Perron via cfe-commits
@@ -0,0 +1,219 @@ +; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %} + +; CHECK-DAG: [[glsl_450_ext:%.+]] = OpExtInstImport "GLSL.std.4

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-15 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,195 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -finclude-default-header -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ +// RUN: -emit-llvm -O1 -o - | FileChe

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-15 Thread Petr Polezhaev via cfe-commits
petr-polezhaev wrote: Ok. I'll wait for review confirmation and then fix the clang-format thing and merge new main https://github.com/llvm/llvm-project/pull/122606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-15 Thread Baranov Victor via cfe-commits
@@ -196,3 +196,13 @@ Options // The following pointer may not become a 'int *const'. int *changing_pointee = &value; changing_pointee = &result; + +.. option:: AllowedTypes (default = '') + + A semicolon-separated list of names of types that + will be excluded fro

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-15 Thread Baranov Victor via cfe-commits
@@ -196,3 +196,13 @@ Options // The following pointer may not become a 'int *const'. int *changing_pointee = &value; changing_pointee = &result; + +.. option:: AllowedTypes (default = '') + + A semicolon-separated list of names of types that + will be excluded fro

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-15 Thread Baranov Victor via cfe-commits
@@ -260,6 +260,11 @@ Changes in existing checks ` check to report a location even when the member location is not valid. +- Improved :doc:`misc-const-correctness + ` check by adding + the option ``AllowedTypes``, that excludes specified types vbvictor wr

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-15 Thread Baranov Victor via cfe-commits
@@ -45,7 +45,7 @@ Options copying. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default is empty. If a name in the list contains the sequence `::` it is matched - against the

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-15 Thread Baranov Victor via cfe-commits
@@ -68,5 +68,5 @@ Options Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default is empty. If a name in the list contains the sequence `::` it is matched against - the qualified

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-15 Thread Baranov Victor via cfe-commits
@@ -45,7 +45,7 @@ Options copying. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default is empty. If a name in the list contains the sequence `::` it is matched - against the

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-15 Thread Baranov Victor via cfe-commits
@@ -32,5 +32,5 @@ Options iteration. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default is empty. If a name in the list contains the sequence `::` it is matched - against th

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-15 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,195 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -finclude-default-header -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ +// RUN: -emit-llvm -O1 -o - | FileChe

[clang] [Driver][ARM] Change Android's NEON FPU hardcoding to "== 7" as it pessimizes future ArmV8 code (PR #122969)

2025-01-15 Thread Sharjeel Khan via cfe-commits
https://github.com/Sharjeel-Khan edited https://github.com/llvm/llvm-project/pull/122969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-15 Thread Baranov Victor via cfe-commits
@@ -196,3 +196,13 @@ Options // The following pointer may not become a 'int *const'. int *changing_pointee = &value; changing_pointee = &result; + +.. option:: AllowedTypes (default = '') + + A semicolon-separated list of names of types that + will be excluded fro

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-15 Thread Deric Cheung via cfe-commits
@@ -0,0 +1,195 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -finclude-default-header -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ +// RUN: -emit-llvm -O1 -o - | FileChe

[clang] [flang] Revert "Revert "[Flang][Driver] Add a flag to control zero initializa… (PR #123097)

2025-01-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-flang-driver Author: Kiran Chandramohan (kiranchandramohan) Changes …tion of global v…" (#123067)" This reverts commit 44ba43aa2b740878d83a9d6f1d52a333c0d48c22. Adds the flag to bbc as well. --- Full diff: https://git

[clang] [flang] Revert "Revert "[Flang][Driver] Add a flag to control zero initializa… (PR #123097)

2025-01-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kiran Chandramohan (kiranchandramohan) Changes …tion of global v…" (#123067)" This reverts commit 44ba43aa2b740878d83a9d6f1d52a333c0d48c22. Adds the flag to bbc as well. --- Full diff: https://github.com/llvm/llvm-project/pull/123097.dif

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-15 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify + +float test_no_second_arg(float2 p0) { + return reflect(p0); + // expected-error@-1 {{no matching function

[clang] [flang] Revert "Revert "[Flang][Driver] Add a flag to control zero initializa… (PR #123097)

2025-01-15 Thread Kiran Chandramohan via cfe-commits
kiranchandramohan wrote: Apologies for the churn here. But the previous patch (https://github.com/llvm/llvm-project/pull/122144) was causing some non-deterministic failures in `flang/test/Lower/module_use.f90`. I am assuming this is because the LoweringOpt is not set to a reasonable value in t

[clang] [Driver][ARM] Change Android's NEON FPU hardcoding to "== 7" as it pessimizes future ArmV8 code (PR #122969)

2025-01-15 Thread David Spickett via cfe-commits
DavidSpickett wrote: Make sure to update the *PR Description* as this becomes the commit message when the squash and merge happens. (yes, this is confusing but that's how llvm is set up) But what I read makes sense thank you for rephrasing the commit message. https://github.com/llvm/llvm-proj

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-15 Thread Deric Cheung via cfe-commits
@@ -0,0 +1,33 @@ +; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s Icohedron wrote: Changing the triple to `-mtriple=spirv32-unknown-unknown` does indeed cause the test to fail at instruction selection ``` FAIL: LLVM ::

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-15 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,195 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -finclude-default-header -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ +// RUN: -emit-llvm -O1 -o - | FileChe

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-15 Thread Farzon Lotfi via cfe-commits
@@ -51,6 +51,38 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(unsigned BuiltinID, TheCall->setType(RetTy); break; } + case SPIRV::BI__builtin_spirv_reflect: { +if (SemaRef.checkArgCount(TheCall, 2)) + return true; + +ExprResult A = TheCall->getArg(0)

[clang] 1865048 - [clang][Serialization] Add the missing block info (#122976)

2025-01-15 Thread via cfe-commits
Author: Steven Wu Date: 2025-01-15T09:58:23-08:00 New Revision: 18650480cb2ea46c9e8236c83593216af80fa25c URL: https://github.com/llvm/llvm-project/commit/18650480cb2ea46c9e8236c83593216af80fa25c DIFF: https://github.com/llvm/llvm-project/commit/18650480cb2ea46c9e8236c83593216af80fa25c.diff LOG

[clang] [clang][Serialization] Add the missing block info (PR #122976)

2025-01-15 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan closed https://github.com/llvm/llvm-project/pull/122976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [nfc][analyzer] Add MemSpace trait to program state (PR #123003)

2025-01-15 Thread Michael Flanders via cfe-commits
https://github.com/Flandini updated https://github.com/llvm/llvm-project/pull/123003 >From 7e0758d2ead53bd4288989b8b2eda218cd6dc34a Mon Sep 17 00:00:00 2001 From: Michael Flanders Date: Mon, 13 Jan 2025 12:34:50 -0600 Subject: [PATCH 1/6] [analyzer] Add MemSpace trait to program state This tra

[clang] [flang] Revert "Revert "[Flang][Driver] Add a flag to control zero initializa… (PR #123097)

2025-01-15 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: > The test that fails is `flang/test/Lower/module_use.f90`. This test also > compiles another test `flang/test/Lower/module_definition.f90`. Is there an > issue with compiling the same test with modules two times and can they > interact badly? This used to be the case in Cla

[clang] [Clang] Remove __is_referenceable builtin (PR #123078)

2025-01-15 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > Should we deprecate it in 20, remove in 21? _almost_ is not 0 > https://github.com/search?q=__is_referenceable%28&type=code What exactly would you like to do? Make `__has_builtin(__is_referenceable)` return 0 but still accept `__is_referenceable` for a release? https://git

[clang] [Driver][ARM] Change Android's NEON FPU hardcoding to "== 7" as it pessimizes future ArmV8 code (PR #122969)

2025-01-15 Thread Sharjeel Khan via cfe-commits
Sharjeel-Khan wrote: Thanks, I updated the PR description. Do you mind merging it @DavidSpickett? I still do not have commit access. https://github.com/llvm/llvm-project/pull/122969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [clang] Improve the documentation for the init_priority attribute (PR #123098)

2025-01-15 Thread Steven Wu via cfe-commits
@@ -136,12 +137,18 @@ relative ordering of values is important. For example: ``Obj2`` will be initialized *before* ``Obj1`` despite the usual order of initialization being the opposite. +Note that this attribute does not control the initialization order of objects +across fina

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-01-15 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: This was discussed during Clang C/C++ Language Working Group meeting today, and the consensus seems that this PR shouldn't land before Clang 20 branch, which is scheduled to happen on January 28th. https://github.com/llvm/llvm-project/pull/122423

[clang] [llvm] [RISCV][VLS] Support RISCV VLS calling convention (PR #100346)

2025-01-15 Thread Brandon Wu via cfe-commits
@@ -1953,7 +1953,7 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase { /// Extra information which affects how the function is called, like /// regparm and the calling convention. LLVM_PREFERRED_TYPE(CallingConv) -unsigned ExtInfo : 13; +

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-15 Thread Erich Keane via cfe-commits
@@ -173,6 +176,20 @@ static bool isLanguageDefinedBuiltin(const SourceManager &SourceMgr, return false; } +static bool isReservedCXXAttributeName(Preprocessor &PP, IdentifierInfo *II) { + const LangOptions &Lang = PP.getLangOpts(); + if (Lang.CPlusPlus && + hasAttrib

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-15 Thread Erich Keane via cfe-commits
@@ -173,6 +176,20 @@ static bool isLanguageDefinedBuiltin(const SourceManager &SourceMgr, return false; } +static bool isReservedCXXAttributeName(Preprocessor &PP, IdentifierInfo *II) { + const LangOptions &Lang = PP.getLangOpts(); + if (Lang.CPlusPlus && + hasAttrib

[clang] Thread Safety Analysis: Support warning on obtaining address of guarded variables (PR #123063)

2025-01-15 Thread Marco Elver via cfe-commits
https://github.com/melver updated https://github.com/llvm/llvm-project/pull/123063 >From 6727047d25b8b72f8e23b03a84c0b23f6dad566a Mon Sep 17 00:00:00 2001 From: Marco Elver Date: Wed, 15 Jan 2025 13:23:14 +0100 Subject: [PATCH] Thread Safety Analysis: Support warning on obtaining address of gu

[clang] [APINotes] Avoid duplicated attributes for class template instantiations (PR #122516)

2025-01-15 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/122516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] acdcdbc - [Sema] Migrate away from PointerUnion::dyn_cast (NFC) (#123014)

2025-01-15 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-01-15T07:56:19-08:00 New Revision: acdcdbcad9b6008687570270cbdf2d6fe86318db URL: https://github.com/llvm/llvm-project/commit/acdcdbcad9b6008687570270cbdf2d6fe86318db DIFF: https://github.com/llvm/llvm-project/commit/acdcdbcad9b6008687570270cbdf2d6fe86318db.diff L

[clang] [Sema] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123014)

2025-01-15 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/123014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-15 Thread via cfe-commits
@@ -68,5 +68,5 @@ Options Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default is empty. If a name in the list contains the sequence `::` it is matched against - the qualified

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-15 Thread via cfe-commits
@@ -45,7 +45,7 @@ Options copying. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default is empty. If a name in the list contains the sequence `::` it is matched - against the

[clang] 8ac35bd - [CUDA][HIP] Support CUID in new driver (#122859)

2025-01-15 Thread via cfe-commits
Author: Yaxun (Sam) Liu Date: 2025-01-15T10:58:25-05:00 New Revision: 8ac35bda18229e28e1638756a5187aa2608a4b50 URL: https://github.com/llvm/llvm-project/commit/8ac35bda18229e28e1638756a5187aa2608a4b50 DIFF: https://github.com/llvm/llvm-project/commit/8ac35bda18229e28e1638756a5187aa2608a4b50.dif

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-15 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/122859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix false warning on reinterpret_casting unknown template type (PR #109430)

2025-01-15 Thread Arseniy Zaostrovnykh via cfe-commits
https://github.com/necto updated https://github.com/llvm/llvm-project/pull/109430 >From 3533863fd58f54d2d5570b4f593d2635e1e11aa8 Mon Sep 17 00:00:00 2001 From: Arseniy Zaostrovnykh Date: Fri, 20 Sep 2024 09:16:17 +0200 Subject: [PATCH 1/3] [clang] Fix false warning on reinterpret_casting unknow

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-15 Thread via cfe-commits
@@ -32,5 +32,5 @@ Options iteration. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default is empty. If a name in the list contains the sequence `::` it is matched - against th

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-15 Thread via cfe-commits
@@ -45,7 +45,7 @@ Options copying. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default is empty. If a name in the list contains the sequence `::` it is matched - against the

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-15 Thread Deric Cheung via cfe-commits
https://github.com/Icohedron converted_to_draft https://github.com/llvm/llvm-project/pull/122992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang][Driver] Deprecate Ofast (PR #101701)

2025-01-15 Thread Kelvin Li via cfe-commits
https://github.com/kkwli approved this pull request. https://github.com/llvm/llvm-project/pull/101701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-15 Thread via cfe-commits
@@ -260,6 +260,11 @@ Changes in existing checks ` check to report a location even when the member location is not valid. +- Improved :doc:`misc-const-correctness + ` check by adding + the option ``AllowedTypes``, that excludes specified types EugeneZelen

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-15 Thread via cfe-commits
@@ -196,3 +196,13 @@ Options // The following pointer may not become a 'int *const'. int *changing_pointee = &value; changing_pointee = &result; + +.. option:: AllowedTypes (default = '') + + A semicolon-separated list of names of types that + will be excluded fro

[clang] 3a3a1e4 - [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (#123013)

2025-01-15 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-01-15T07:55:52-08:00 New Revision: 3a3a1e4627a37bdf5915b60fe375443bb280f23b URL: https://github.com/llvm/llvm-project/commit/3a3a1e4627a37bdf5915b60fe375443bb280f23b DIFF: https://github.com/llvm/llvm-project/commit/3a3a1e4627a37bdf5915b60fe375443bb280f23b.diff L

[clang] 3fd296e - [AST] Migrate away from PointerUnion::dyn_cast (NFC) (#123012)

2025-01-15 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-01-15T07:55:28-08:00 New Revision: 3fd296ece69c0bab77ce0df9a128202746ffce94 URL: https://github.com/llvm/llvm-project/commit/3fd296ece69c0bab77ce0df9a128202746ffce94 DIFF: https://github.com/llvm/llvm-project/commit/3fd296ece69c0bab77ce0df9a128202746ffce94.diff L

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123013)

2025-01-15 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/123013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #123012)

2025-01-15 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/123012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-15 Thread via cfe-commits
@@ -196,3 +196,13 @@ Options // The following pointer may not become a 'int *const'. int *changing_pointee = &value; changing_pointee = &result; + +.. option:: AllowedTypes (default = '') + + A semicolon-separated list of names of types that + will be excluded fro

[clang] [flang] [Flang][Driver] Add a flag to control zero initialization of global v… (PR #122144)

2025-01-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-aarch64-debug-reverse-iteration` running on `linaro-flang-aarch64-debug-reverse-iteration` while building `clang,flang` at step 6 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.o

[clang-tools-extra] [clang-tidy][modernize] Replace memmove/memcpy with std::copy (PR #122940)

2025-01-15 Thread Kuba Migdał via cfe-commits
kidq330 wrote: @kadircet Does the file need further changes from what I've already added? https://github.com/llvm/llvm-project/pull/122940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [llvm] [HLSL] Implement the `reflect` HLSL function (PR #122992)

2025-01-15 Thread Deric Cheung via cfe-commits
@@ -0,0 +1,195 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -finclude-default-header -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ +// RUN: -emit-llvm -O1 -o - | FileChe

[clang] [flang] [Flang][Driver] Deprecate Ofast (PR #101701)

2025-01-15 Thread Michael Klemm via cfe-commits
https://github.com/mjklemm approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/101701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove __is_referenceable builtin (PR #123078)

2025-01-15 Thread Erich Keane via cfe-commits
erichkeane wrote: > Should we deprecate it in 20, remove in 21? _almost_ is not 0 > https://github.com/search?q=__is_referenceable%28&type=code Eh, it is pretty effectively 0. If you subtract ones that are wrapped in '#if 0' or part of libcxx, the first two pages have like 3 entries on them.

[clang-tools-extra] [clang-reorder-fields] Move trailing comments. (PR #122918)

2025-01-15 Thread Clement Courbet via cfe-commits
@@ -116,26 +118,78 @@ findMembersUsedInInitExpr(const CXXCtorInitializer *Initializer, return Results; } -/// Returns the full source range for the field declaration up to (not -/// including) the trailing semicolumn, including potential macro invocations, -/// e.g. `int a

[clang-tools-extra] [clang-reorder-fields] Move trailing comments. (PR #122918)

2025-01-15 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/122918 >From 5180e6ee06531623adc35ac418d2dddbe58586c3 Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Tue, 14 Jan 2025 13:38:00 + Subject: [PATCH] [clang-reorder-fields] Move trailing comments. Currently

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

2025-01-15 Thread kadir çetinkaya via cfe-commits
@@ -181,13 +182,96 @@ class DiagnosticMapping { class DiagnosticIDs : public RefCountedBase { public: /// The level of the diagnostic, after it has been through mapping. - enum Level { -Ignored, Note, Remark, Warning, Error, Fatal + enum Level : uint8_t { Ignored, Note,

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

2025-01-15 Thread kadir çetinkaya via cfe-commits
@@ -584,7 +582,9 @@ DiagnosticIDs::getDiagnosticSeverity(unsigned DiagID, SourceLocation Loc, const auto &SM = Diag.getSourceManager(); // Custom diagnostics always are emitted in system headers. kadircet wrote: can you also update the comment here to desc

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

2025-01-15 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet requested changes to this pull request. > but I'd really love to hear from @kadircet as to whether this PR fully > addresses the issues found before: > https://github.com/llvm/llvm-project/pull/70976#discussion_r1775918960 I think it mostly does (left some comments

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

2025-01-15 Thread kadir çetinkaya via cfe-commits
@@ -551,10 +547,12 @@ DiagnosticIDs::getDiagnosticSeverity(unsigned DiagID, SourceLocation Loc, // as well as disabling all messages which are currently mapped to Warning // (whether by default or downgraded from Error via e.g. -Wno-error or #pragma // diagnostic.) + /

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

2025-01-15 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/119712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Add missing includes to CLC headers (PR #118654)

2025-01-15 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/118654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] a5b88cb - [libclc] Add missing includes to CLC headers (#118654)

2025-01-15 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-01-15T10:14:51Z New Revision: a5b88cb815d8f38698a3064a727b59143e0dae42 URL: https://github.com/llvm/llvm-project/commit/a5b88cb815d8f38698a3064a727b59143e0dae42 DIFF: https://github.com/llvm/llvm-project/commit/a5b88cb815d8f38698a3064a727b59143e0dae42.diff LOG

[libclc] [libclc] Add missing includes to CLC headers (PR #118654)

2025-01-15 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/118654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-15 Thread Antonio Frighetto via cfe-commits
https://github.com/antoniofrighetto edited https://github.com/llvm/llvm-project/pull/122754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-15 Thread Oliver Stannard via cfe-commits
@@ -7806,6 +7815,267 @@ bool AArch64AsmParser::parseDirectiveSEHSaveAnyReg(SMLoc L, bool Paired, return false; } +bool AArch64AsmParser::parseDirectiveAeabiSubSectionHeader(SMLoc L) { + // Expecting 3 AsmToken::Identifier after '.aeabi_subsection', a name and 2 + // param

[clang] fix armv6kz LDREX definition (PR #122965)

2025-01-15 Thread David Green via cfe-commits
https://github.com/davemgreen approved this pull request. Thanks LGTM. Let us know if we should squash and merge (I never know who has access). https://github.com/llvm/llvm-project/pull/122965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-15 Thread Oliver Stannard via cfe-commits
@@ -7806,6 +7815,267 @@ bool AArch64AsmParser::parseDirectiveSEHSaveAnyReg(SMLoc L, bool Paired, return false; } +bool AArch64AsmParser::parseDirectiveAeabiSubSectionHeader(SMLoc L) { + // Expecting 3 AsmToken::Identifier after '.aeabi_subsection', a name and 2 + // param

[clang] [llvm] [Intrinsics][AArch64] Add intrinsic to mask off aliasing vector lanes (PR #117007)

2025-01-15 Thread David Green via cfe-commits
@@ -2033,6 +2041,25 @@ bool AArch64TargetLowering::shouldExpandGetActiveLaneMask(EVT ResVT, return false; } +bool AArch64TargetLowering::shouldExpandGetAliasLaneMask( davemgreen wrote: Can this be removed now? https://github.com/llvm/llvm-project/pull/117

<    1   2   3   4   5   >