https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/122625
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff db88071a8b24ad9302659ee88383eea69a732f11
19bc40e7d824804ebcd9839cb2155a704d368e36 --e
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Shilei Tian (shiltian)
Changes
This a prime patch to support generic target when using `--offload-compress`.
---
Full diff: https://github.com/llvm/llvm-project/pull/122627.diff
7 Files Affected:
- (modified) clang/lib/Driver/Too
https://github.com/wonbinbk updated
https://github.com/llvm/llvm-project/pull/120348
>From edcf75fcf810ff08c47b93a0de420a4640e5a6b0 Mon Sep 17 00:00:00 2001
From: wonbinbk
Date: Tue, 24 Dec 2024 09:54:05 +1300
Subject: [PATCH 1/2] [clang-tidy] Use raw string for regex pattern
---
clang-tools-
wonbinbk wrote:
> feel free to ping me when you want to merge it.
Thank you! I just reformatted the change to make darker happy. Should be all
good to merge now if you don't see anything else need to be changed.
https://github.com/llvm/llvm-project/pull/120348
_
owenca wrote:
> > I think this should be covered by BlockIndent
>
> My understanding from looking at past PRs to clang-format was that backwards
> compatibility was a top requirement. If I changed the behavior of BlockIndent
> to put the `>` on the next line, that would change a lot of existin
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-darwin`
running on `doug-worker-3` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/23/builds/6556
Here is the r
@@ -2252,6 +2252,25 @@ struct FormatStyle {
/// \version 16
BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon;
+ /// If ``true``, a line break will be placed before the ``>`` in a multiline
+ /// template declaration.
+ /// \code
+ ///true:
+ ///templat
https://github.com/jhuber6 approved this pull request.
Maybe one day we'll be able to get rid of the bundler.
https://github.com/llvm/llvm-project/pull/122627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/leijurv updated
https://github.com/llvm/llvm-project/pull/118046
>From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001
From: Leijurv
Date: Fri, 29 Nov 2024 21:54:36 -0600
Subject: [PATCH 1/7] [clang-format] Add BreakBeforeTemplateClose option
---
clang/doc
@@ -0,0 +1,141 @@
+//===- ModuleMapFile.h - Parsing and representation -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
leijurv wrote:
I apologize for forgetting `clang-format-check-format`
You're right that I had still missed some more cases of `verifyNoChange`. I've
changed those now in
https://github.com/llvm/llvm-project/pull/118046/commits/130428887e534cc3bfdfeec5846df2fd1e939667.
The last two remaining `
@@ -1575,305 +1494,45 @@ namespace clang {
/// 'textual' to match the original intent.
llvm::SmallPtrSet UsesRequiresExcludedHack;
-/// Consume the current token and return its location.
-SourceLocation consumeToken();
-
-/// Skip tokens until we reach the
@@ -0,0 +1,141 @@
+//===- ModuleMapFile.h - Parsing and representation -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -3157,25 +2140,18 @@ bool ModuleMap::parseModuleMapFile(FileEntryRef File,
bool IsSystem,
assert((!Offset || *Offset <= Buffer->getBufferSize()) &&
"invalid buffer offset");
- // Parse this module map file.
- Lexer L(SourceMgr.getLocForStartOfFile(ID), MMapLan
@@ -2252,6 +2252,25 @@ struct FormatStyle {
/// \version 16
BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon;
+ /// If ``true``, a line break will be placed before the ``>`` in a multiline
+ /// template declaration.
+ /// \code
+ ///true:
+ ///templat
Bigcheese wrote:
> I'm happy with the way this split of the code worked out!
>
> > Currently this has no effect other than slightly changing diagnostics.
>
> Can you say more about the ordering changes? I understand we can't always
> emit diagnostics in source order, but it's helpful for reada
https://github.com/wonbinbk updated
https://github.com/llvm/llvm-project/pull/120348
>From edcf75fcf810ff08c47b93a0de420a4640e5a6b0 Mon Sep 17 00:00:00 2001
From: wonbinbk
Date: Tue, 24 Dec 2024 09:54:05 +1300
Subject: [PATCH 1/2] [clang-tidy] Use raw string for regex pattern
---
clang-tools-
@@ -747,6 +747,31 @@ static bool areSidesBinaryConstExpressions(const
BinaryOperator *&BinOp, const A
return false;
}
+static bool
+areSidesBinaryConstExpressionsOrDefines(const BinaryOperator *&BinOp,
+const ASTContext *AstCtx) {
+
https://github.com/wonbinbk updated
https://github.com/llvm/llvm-project/pull/120348
>From edcf75fcf810ff08c47b93a0de420a4640e5a6b0 Mon Sep 17 00:00:00 2001
From: wonbinbk
Date: Tue, 24 Dec 2024 09:54:05 +1300
Subject: [PATCH 1/2] [clang-tidy] Use raw string for regex pattern
---
clang-tools-
@@ -115,6 +115,9 @@ Improvements to clang-tidy
- Improved :program:`run-clang-tidy.py` script. Fixed minor shutdown noise
happening on certain platforms when interrupting the script.
+- Improved :program:`clang-tidy-diff.py` script. Add an option to exclude files
---
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux`
running on `premerge-linux-1` while building `clang,llvm` at step 7
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/153/builds/19253
He
@@ -154,8 +156,16 @@ void UseIntegerSignComparisonCheck::check(
DiagnosticBuilder Diag =
diag(BinaryOp->getBeginLoc(),
"comparison between 'signed' and 'unsigned' integers");
- const std::string CmpNamespace = ("std::" + parseOpCode(OpCode)).str();
- const
@@ -30,11 +30,12 @@ class UseIntegerSignComparisonCheck : public ClangTidyCheck
{
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
bool isLanguageVersionSupported(const LangOptio
@@ -80,11 +80,13 @@
UseIntegerSignComparisonCheck::UseIntegerSignComparisonCheck(
: ClangTidyCheck(Name, Context),
IncludeInserter(Options.getLocalOrGlobal("IncludeStyle",
utils::IncludeSorter::IS_LLVM),
-
https://github.com/PiotrZSL approved this pull request.
Except pointed out nits, looks fine.
https://github.com/llvm/llvm-project/pull/122127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
@@ -154,8 +156,16 @@ void UseIntegerSignComparisonCheck::check(
DiagnosticBuilder Diag =
diag(BinaryOp->getBeginLoc(),
"comparison between 'signed' and 'unsigned' integers");
- const std::string CmpNamespace = ("std::" + parseOpCode(OpCode)).str();
- const
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/122127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/122587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/121323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/120701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Younan Zhang
Date: 2025-01-11T19:17:09+08:00
New Revision: 77ef5a601ad3827316e412788f609e9141b51e83
URL:
https://github.com/llvm/llvm-project/commit/77ef5a601ad3827316e412788f609e9141b51e83
DIFF:
https://github.com/llvm/llvm-project/commit/77ef5a601ad3827316e412788f609e9141b51e83.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/122587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlocab wrote:
There is already handling of unsupported sanitisers just above:
https://github.com/llvm/llvm-project/blob/77ef5a601ad3827316e412788f609e9141b51e83/clang/lib/Driver/SanitizerArgs.cpp#L523-L530
Is it not possible to incorporate the lack of support for msan on Android there?
https
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/122423
>From d40a80859eafe96bdc99957db2aebb70db407e67 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 10 Jan 2025 09:46:24 +0800
Subject: [PATCH 1/7] Reapply "[Clang] Implement CWG2369 "Ordering between
constra
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/93634
>From 079f6d29c1091b89e949d674b1983bb6e08155df Mon Sep 17 00:00:00 2001
From: Kohei Asano
Date: Mon, 3 Jun 2024 09:15:44 +0900
Subject: [PATCH] [clang-format] add an option to insert a space only for empty
braces
khei4 wrote:
rebased but still required to be tested and fix again
https://github.com/llvm/llvm-project/pull/93634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/khei4 converted_to_draft
https://github.com/llvm/llvm-project/pull/93634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Congcong Cai (HerrCai0907)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/122594.diff
@@ -117,6 +117,9 @@ Improvements to clang-tidy
- Improved :program:`clang-tidy` by accepting parameters file in command line.
+- Improved :program:`clang-tidy` by fixing incorrect configuration file path
HerrCai0907 wrote:
#122594
https://github.com/llvm/ll
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/122594
https://github.com/user-attachments/assets/25433743-2c19-422a-93c5-3edfc1bb7a3f";
/>
>From 3f9b3ccf94deb98cdedc9928d409a102f5b0e435 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Sat, 11 Jan 2025 23:21
Author: Congcong Cai
Date: 2025-01-11T23:26:34+08:00
New Revision: 32351b5450119799ef33da92e87149467c64
URL:
https://github.com/llvm/llvm-project/commit/32351b5450119799ef33da92e87149467c64
DIFF:
https://github.com/llvm/llvm-project/commit/32351b5450119799ef33da92e87149467c64.diff
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/122595
None
>From 37b633e8eb393fac5d02e3dd551e2801d5b8d337 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Sat, 11 Jan 2025 23:25:47 +0800
Subject: [PATCH] [clang-tidy][doc] fix incorrectly code snippet in relea
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Congcong Cai (HerrCai0907)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/122595.diff
1 Files Affected:
- (modified) clang-tools-extra/docs/ReleaseNotes.rst (+3-3)
``diff
diff --git a/clang-tool
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/122595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/2LoS created https://github.com/llvm/llvm-project/pull/122609
None
>From ff12d49f0633678633d9e239db7424c60e94cb5d Mon Sep 17 00:00:00 2001
From: LoS
Date: Thu, 9 Jan 2025 18:46:36 +0100
Subject: [PATCH 1/3] Removed duplicated _LIBCPP_HIDE_FROM_ABI in libcxx
---
.../include/
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: LoS (2LoS)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/122609.diff
3 Files Affected:
- (renamed)
clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp ()
- (renamed) clang/test/SemaCXX/warn-suggest
@@ -5284,8 +5284,22 @@ void Sema::InstantiateFunctionDefinition(SourceLocation
PointOfInstantiation,
savedContext.pop();
}
- DeclGroupRef DG(Function);
- Consumer.HandleTopLevelDecl(DG);
+ // With CWG2369, we substitute constraints before instantiating the
associate
thurstond wrote:
> these checks into Toolchains/Linux.cpp so it triggers that code:
IMO adding the Android msan check into Toolchains/Linux.cpp would be cleaner
because it's:
1) only a 1 or 2 line change (compared with the current ~10 lines)
2) this file handles all the broad compatibility chec
Sharjeel-Khan wrote:
I can do it by moving these checks into Toolchains/Linux.cpp so it triggers
that code:
https://github.com/llvm/llvm-project/blob/2914ba1c01fdc496082197abf7cd35e2af526634/clang/lib/Driver/ToolChains/Linux.cpp#L809-L865.
Is this a good solution?
https://github.com/llvm/llvm-
https://github.com/2LoS closed https://github.com/llvm/llvm-project/pull/122609
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/TilakChad created
https://github.com/llvm/llvm-project/pull/122611
The (function) type of the lambda function is null while parsing trailing
return type. The type is filled-in when the lambda body is entered. So,
resolving `__PRETTY_FUNCTION__` before the lambda body is ente
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: TilakChad (TilakChad)
Changes
The (function) type of the lambda function is null while parsing trailing
return type. The type is filled-in when the lambda body is entered. So,
resolving `__PRETTY_FUNCTION__` before the lambda body is ente
cor3ntin wrote:
I've confirmed with @zyn0217 that this iteration of the patch fixes the bug
encountered by the chromium team wherein we tried to mangle lambdas with a
deduced return type during constraint satisfaction - which caused failure on
windows as mangling of lambda requires the enclosi
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/122611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -774,7 +774,12 @@ std::string
PredefinedExpr::ComputeName(PredefinedIdentKind IK,
const FunctionDecl *Decl = FD;
if (const FunctionDecl* Pattern = FD->getTemplateInstantiationPattern())
Decl = Pattern;
-const FunctionType *AFT = Decl->getType()->getAs();
+
https://github.com/cor3ntin commented:
Thanks for this PR.
The approach looks sensible to me
Can you add a release note in `clang/docs/ReleaseNotes.rst` ? Thanks
https://github.com/llvm/llvm-project/pull/122611
___
cfe-commits mailing list
cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/122611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/2LoS created https://github.com/llvm/llvm-project/pull/122613
None
>From 81daf0e300e66a36df321c215019805f0617d09b Mon Sep 17 00:00:00 2001
From: LoS
Date: Sat, 11 Jan 2025 21:07:17 +0100
Subject: [PATCH] Added .cpp extension to some test files in SemaCXX
---
...ride => warn
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: LoS (2LoS)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/122613.diff
3 Files Affected:
- (renamed)
clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp ()
- (renamed) clang/test/SemaCXX/warn-suggest
https://github.com/2LoS closed https://github.com/llvm/llvm-project/pull/122613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlosgalvezp wrote:
This check sounds a bit strange. Is this issue common in real-world projects,
do we have some data? It's the first time I've heard of it. Why would people
deviate from the standard signature for move constructors?
We could perhaps consider making this check a bit more gene
cor3ntin wrote:
> > Did you try to modify `IgnoreUnlessSpelledInSource` to support CallExpr?
>
> Yea I was thinking about it initially. But I wasn't sure what that would look
> like tbh. IIUC `IgnoreImplicitMemberCallSingleStep` will unwrap
> `CXXMemberCallExpr` into the underlying `MemberExpr
Author: Kazu Hirata
Date: 2025-01-11T13:15:50-08:00
New Revision: a56eb7c9986456ae4b492fff79c3cf18d0ef8ad3
URL:
https://github.com/llvm/llvm-project/commit/a56eb7c9986456ae4b492fff79c3cf18d0ef8ad3
DIFF:
https://github.com/llvm/llvm-project/commit/a56eb7c9986456ae4b492fff79c3cf18d0ef8ad3.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/122588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/122594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 166 of 166 matches
Mail list logo