[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

https://github.com/zyn0217 converted_to_draft https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/19281 Here is

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/122423 >From d40a80859eafe96bdc99957db2aebb70db407e67 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 10 Jan 2025 09:46:24 +0800 Subject: [PATCH 1/5] Reapply "[Clang] Implement CWG2369 "Ordering between constra

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/122423 >From d40a80859eafe96bdc99957db2aebb70db407e67 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 10 Jan 2025 09:46:24 +0800 Subject: [PATCH 1/6] Reapply "[Clang] Implement CWG2369 "Ordering between constra

[clang-tools-extra] ae9bf17 - [clang-tidy] remove never used IgnoreCase in option (#122573)

Author: Congcong Cai Date: 2025-01-11T22:46:04+08:00 New Revision: ae9bf17697d2245be707e93125f18d09eaf77aa9 URL: https://github.com/llvm/llvm-project/commit/ae9bf17697d2245be707e93125f18d09eaf77aa9 DIFF: https://github.com/llvm/llvm-project/commit/ae9bf17697d2245be707e93125f18d09eaf77aa9.diff

[clang-tools-extra] [clang-tidy] remove never used IgnoreCase in option (PR #122573)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/122573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/121323 >From 896db4495ff2c29c2e623d92e004ef64f49c8dd0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 30 Dec 2024 16:38:29 +0800 Subject: [PATCH] [clang-tidy] fix incorrect configuration file path resolving

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/121323 >From 896db4495ff2c29c2e623d92e004ef64f49c8dd0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 30 Dec 2024 16:38:29 +0800 Subject: [PATCH 1/2] [clang-tidy] fix incorrect configuration file path resol

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

@@ -117,6 +117,11 @@ Improvements to clang-tidy - Improved :program:`run-clang-tidy.py` script. Fixed minor shutdown noise happening on certain platforms when interrupting the script. +- Improved :program:`clang-tidy` by accepting parameters file in command line. + -

[clang-tools-extra] 0249554 - [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (#121323)

Author: Congcong Cai Date: 2025-01-11T22:51:47+08:00 New Revision: 0249554ee1ac49e6f1d93fa78a55971fc706f635 URL: https://github.com/llvm/llvm-project/commit/0249554ee1ac49e6f1d93fa78a55971fc706f635 DIFF: https://github.com/llvm/llvm-project/commit/0249554ee1ac49e6f1d93fa78a55971fc706f635.diff

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/121323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

https://github.com/dodicidodici updated https://github.com/llvm/llvm-project/pull/122599 >From 2f1627ee62c041d98cbc51b08aebf2dd2dbe5455 Mon Sep 17 00:00:00 2001 From: dodicidodici Date: Fri, 10 Jan 2025 19:05:09 +0100 Subject: [PATCH 1/6] add `performance-explicit-move-constructor` check ---

[clang-tools-extra] [clang-tidy] Add an option to exclude files not present in the compile database (PR #120348)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 212cba0ef37dd3b2a253c063240370de42fc67c1...834789678bf967e79c29041452bc96832592de36 clang

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++][ranges] P2542R8: Implement `views::concat` (PR #120920)

https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/120920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add an option to exclude files not present in the compile database (PR #120348)

HerrCai0907 wrote: feel free to ping me when you want to merge it. https://github.com/llvm/llvm-project/pull/120348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

https://github.com/petr-polezhaev created https://github.com/llvm/llvm-project/pull/122606 Tunnels `Manger` object into the `ScanningAllProjectModules` so it can be used to perform necessary command-line modifications (which also adds `--resources` path previously added there explicitly). This

[clang] [Clang] Add release note for pointer overflow optimization change (PR #122462)

https://github.com/zmodem approved this pull request. The current version lgtm by the way Maybe we should also put a blurb in the main llvm release notes and link to this one. https://github.com/llvm/llvm-project/pull/122462 ___ cfe-commits mailing l

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Petr Polezhaev (petr-polezhaev) Changes Tunnels `Manger` object into the `ScanningAllProjectModules` so it can be used to perform necessary command-line modifications (which also adds `--resources` path previously added there

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: dodicidodici (dodicidodici) Changes This patch adds a check that reports classes that define an explicit move constructor and a copy constructor. Closes #121707 --- Full diff: https://github.com/llvm/llvm-project/pull/122599.

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: dodicidodici (dodicidodici) Changes This patch adds a check that reports classes that define an explicit move constructor and a copy constructor. Closes #121707 --- Full diff: https://github.com/llvm/llvm-project/pull/122599.diff

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

https://github.com/dodicidodici ready_for_review https://github.com/llvm/llvm-project/pull/122599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] remove never used IgnoreCase in option (PR #122573)

https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/122573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Add API to query more information about base classes. (PR #120300)

https://github.com/DeinAlptraum approved this pull request. Re Python: LGTM! On a sidenote just fyi, there's no need to amend & forcepush when you adress review comments. I know the contributor guide says something about how you should have only a single commit when submitting a patch, but tha

[clang] [Clang][NFC] Fix a test failure with mold linker (PR #122587)

https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/122587 Mold prefers the suffix '$' for symbols like PLT and GOT entries, so exclude these symbols as well. Otherwise, this test will fail for developers using mold-linked Clang. >From 19467fe0e48abfe85003ebf80e29a37

[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/121506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

@@ -301,6 +301,11 @@ Changes in existing checks ` check to fix a crash when a class is declared but not defined. +- Improved :doc:`modernize-use-integer-sign-comparison + ` check to + add an option ``ConsideringIntegerSize``, that ignores a comparison between ---

[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

https://github.com/PiotrZSL requested changes to this pull request. Few small nits, but functionally ok. https://github.com/llvm/llvm-project/pull/121506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

@@ -126,6 +126,14 @@ class ModernizeModule : public ClangTidyModule { "modernize-use-uncaught-exceptions"); CheckFactories.registerCheck("modernize-use-using"); } + + ClangTidyOptions getModuleOptions() override { +ClangTidyOptions Options; +Options.Check

[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

@@ -34,3 +34,7 @@ Options A string specifying which include-style is used, `llvm` or `google`. Default is `llvm`. + +.. option:: ConsideringIntegerSize + Ignores a comparison between a signed wide and an unsigned narrow PiotrZSL wrote: i think there shou

[clang] [analyzer] Widen loops: Augment assignment note when values invalidated at the start of a loop (PR #122398)

steakhal wrote: > I agree that it would make more sense to generalize this beyond loop > widening. However, I'm having a hard time understanding how your proposal > would fit in to the augmentation of the assignment message like I do in this > PR. > > The part I'm most confused about is how w

[clang-tools-extra] 32bcd41 - [clang-tidy] use correct template type in ``std::min`` and ``std::max`` when operand is integer literal for readability-use-std-min-max (#122296)

Author: Congcong Cai Date: 2025-01-11T18:48:39+08:00 New Revision: 32bcd41adcc664f6d690efc9b7cd209ac9c65f68 URL: https://github.com/llvm/llvm-project/commit/32bcd41adcc664f6d690efc9b7cd209ac9c65f68 DIFF: https://github.com/llvm/llvm-project/commit/32bcd41adcc664f6d690efc9b7cd209ac9c65f68.diff

[clang-tools-extra] [clang-tidy] use correct template type in ``std::min`` and ``std::max`` when operand is integer literal for readability-use-std-min-max (PR #122296)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/122296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix wrong result of pointers comparison between unknown and stack (PR #122404)

steakhal wrote: My current stance is that we should have the memoryspace trait only for memregions that have an UnknownSpace memspace, becuase that would be the least amount of work. So it would be a hybrid solution. We have the memspaces as we have today, but for UnknownSpace you would need to

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/122423 >From d40a80859eafe96bdc99957db2aebb70db407e67 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 10 Jan 2025 09:46:24 +0800 Subject: [PATCH 1/4] Reapply "[Clang] Implement CWG2369 "Ordering between constra

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001 From: Leijurv Date: Fri, 29 Nov 2024 21:54:36 -0600 Subject: [PATCH 1/5] [clang-format] Add BreakBeforeTemplateClose option --- clang/doc

[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

@@ -80,16 +80,19 @@ UseIntegerSignComparisonCheck::UseIntegerSignComparisonCheck( : ClangTidyCheck(Name, Context), IncludeInserter(Options.getLocalOrGlobal("IncludeStyle", utils::IncludeSorter::IS_LLVM), -

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

@@ -117,6 +117,9 @@ Improvements to clang-tidy - Improved :program:`clang-tidy` by accepting parameters file in command line. +- Improved :program:`clang-tidy` by fixing incorrect configuration file path PiotrZSL wrote: Note: to be honest all those 'Improved

[clang-tools-extra] 30bb186 - [clang-tidy] Mention std::forward_list in container-size-empty doc (#120701)

Author: Niels Dekker Date: 2025-01-11T10:15:17+01:00 New Revision: 30bb1863892a235fe1d90eb6b496bd24b0c177d8 URL: https://github.com/llvm/llvm-project/commit/30bb1863892a235fe1d90eb6b496bd24b0c177d8 DIFF: https://github.com/llvm/llvm-project/commit/30bb1863892a235fe1d90eb6b496bd24b0c177d8.diff

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

https://github.com/PiotrZSL approved this pull request. Functionally ok. https://github.com/llvm/llvm-project/pull/121323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Mention std::forward_list in container-size-empty doc (PR #120701)

https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/120701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

https://github.com/dodicidodici created https://github.com/llvm/llvm-project/pull/122599 This patch adds a check that reports classes that define an explicit move constructor and a copy constructor. Closes #121707 >From 2f1627ee62c041d98cbc51b08aebf2dd2dbe5455 Mon Sep 17 00:00:00 2001 From: d

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Driver] Warn when using msan on Android (PR #122540)

https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/122540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ac604b2fa6ff0344a555954069721c0db7b874f9 828461273ea7ac1d38a4d3fe1ff8b810f80472e9 --e

[clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #121960)

@@ -852,6 +877,58 @@ static bool areExprsMacroAndNonMacro(const Expr *&LhsExpr, return LhsLoc.isMacroID() != RhsLoc.isMacroID(); } + +static bool areExprsSameMacroOrLiteral(const BinaryOperator *BinOp, + const ASTContext *Context) { + +

[clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #121960)

@@ -747,6 +747,31 @@ static bool areSidesBinaryConstExpressions(const BinaryOperator *&BinOp, const A return false; } +static bool +areSidesBinaryConstExpressionsOrDefines(const BinaryOperator *&BinOp, +const ASTContext *AstCtx) { +

[clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #121960)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/121960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #121960)

https://github.com/PiotrZSL requested changes to this pull request. Overall, may require some small work to make sure that code is straightforward and simple. As for functionality part, still has some gaps or redundant parts, but that is not a blocker. Please try to refactor your changes to be

[clang] [Clang][NFC] Fix a test failure with mold linker (PR #122587)

https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/122587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Fix a test failure with mold linker (PR #122587)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes Mold prefers the suffix '$' for symbols like PLT and GOT entries, so exclude these symbols as well. Otherwise, this test will fail for developers using mold-linked Clang. Closes https://github.com/llvm/llvm

[clang-tools-extra] [clang-tidy] exclude CXXParenListInitExpr from RedundantCastingCheck (PR #109741)

https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/109741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] exclude CXXParenListInitExpr from RedundantCastingCheck (PR #109741)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/109741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] exclude CXXParenListInitExpr from RedundantCastingCheck (PR #109741)

PiotrZSL wrote: > Actually, shouldn't this check instead change an explicit cast for a > `CXXParenListExpr` from `static_cast(42)` to `C(42)` Yes, but that's secondary. As in such case this could be seen as an FunctionalCast. https://github.com/llvm/llvm-project/pull/109741

[clang-tools-extra] dc2963c - [clang-tidy] exclude CXXParenListInitExpr from RedundantCastingCheck (#109741)

Author: Tommy Chen Date: 2025-01-11T11:04:19+01:00 New Revision: dc2963c8d77229ca1b20663beddef2323cc69a88 URL: https://github.com/llvm/llvm-project/commit/dc2963c8d77229ca1b20663beddef2323cc69a88 DIFF: https://github.com/llvm/llvm-project/commit/dc2963c8d77229ca1b20663beddef2323cc69a88.diff LO

[clang-tools-extra] [clang-tidy] exclude CXXParenListInitExpr from RedundantCastingCheck (PR #109741)

github-actions[bot] wrote: @dl8sd11 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang-tools-extra] [clang-tidy] exclude CXXParenListInitExpr from RedundantCastingCheck (PR #109741)

https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/109741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Fix a test failure with mold linker (PR #122587)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/122587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a3e62d8 - [AST] Fix a warning

Author: Kazu Hirata Date: 2025-01-11T00:11:42-08:00 New Revision: a3e62d849f07d1e55e6d15465f4f3842ff4b3717 URL: https://github.com/llvm/llvm-project/commit/a3e62d849f07d1e55e6d15465f4f3842ff4b3717 DIFF: https://github.com/llvm/llvm-project/commit/a3e62d849f07d1e55e6d15465f4f3842ff4b3717.diff L

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/122423 >From d40a80859eafe96bdc99957db2aebb70db407e67 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 10 Jan 2025 09:46:24 +0800 Subject: [PATCH 1/3] Reapply "[Clang] Implement CWG2369 "Ordering between constra

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] use correct template type in ``std::min`` and ``std::max`` when operand is integer literal for readability-use-std-min-max (PR #122296)

https://github.com/PiotrZSL approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/122296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add a release note about unchecked-optional-access smart pointer caching (PR #122290)

@@ -232,6 +232,10 @@ Changes in existing checks ` to support `bsl::optional` and `bdlb::NullableValue` from _. + Fixed false positives from smart pointer accessors repeated in checking + ``has_value`` and accessing ``value``, by caching

[clang-tools-extra] [clang-tidy] Add a release note about unchecked-optional-access smart pointer caching (PR #122290)

@@ -81,10 +81,12 @@ Exception: accessor methods The check assumes *accessor* methods of a class are stable, with a heuristic to determine which methods are accessors. Specifically, parameter-free ``const`` -methods are treated as accessors. Note that this is not guaranteed to

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

leijurv wrote: Thank you for the review @owenca > I think this should be covered by BlockIndent My understanding from looking at past PRs to clang-format was that backwards compatibility was a top requirement. If I changed the behavior of BlockIndent to put the `>` on the next line, that wou

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #122588)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/122588 None >From 7b2b5230116779c07db74056eba6618fdea7f910 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 11 Jan 2025 01:11:22 -0800 Subject: [PATCH] [Sema] Avoid repeated hash lookups (NFC) --- clang/

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #122588)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122588.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaDecl.cpp (+2-2) ``diff diff --git a/clang/lib/Sema/SemaDecl.cpp b/cl

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #122588)

https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/122588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Warn when using msan on Android (PR #122540)

https://github.com/Sharjeel-Khan updated https://github.com/llvm/llvm-project/pull/122540 >From c8d2c210a98fe0c96d758d538d50fcc0ca61a9ff Mon Sep 17 00:00:00 2001 From: Sharjeel Khan Date: Fri, 10 Jan 2025 20:07:52 + Subject: [PATCH 1/3] Warn when using msan on Android Msan is not supported

[clang-tools-extra] 2c7829e - [clang-tidy][doc] combine the clang-tidy itself's change together in release note (#122594)

Author: Congcong Cai Date: 2025-01-12T06:48:46+08:00 New Revision: 2c7829e676dfd6a33f7c9955ea930f51aca37e20 URL: https://github.com/llvm/llvm-project/commit/2c7829e676dfd6a33f7c9955ea930f51aca37e20 DIFF: https://github.com/llvm/llvm-project/commit/2c7829e676dfd6a33f7c9955ea930f51aca37e20.diff

[clang-tools-extra] [clang-tidy][doc] combine the clang-tidy itself's change together in release note (PR #122594)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/122594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][doc] combine the clang-tidy itself's change together in release note (PR #122594)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls` running on `linaro-g3-04` while building `clang-tools-extra` at step 6 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/4696 Here is the relevant pie

[clang-tools-extra] [clang-tidy][doc] combine the clang-tidy itself's change together in release note (PR #122594)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-asan` running on `sanitizer-buildbot7` while building `clang-tools-extra` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/4104 Here i

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/122621 Fixes #121706 >From b2c656afdf99eff52d019b68fcbbc6ce4bbdd7d3 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 12 Jan 2025 00:51:47 +0200 Subject: [PATCH] [Clang] disallow the use of asterisks preceding

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #121706 --- Full diff: https://github.com/llvm/llvm-project/pull/122621.diff 5 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) clang/include/clang/Basic/DiagnosticSemaK

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

zyn0217 wrote: @mysterymath @zmodem Can you both test this patch on Windows to confirm if it resolves issues you've reported? We'd greatly appreciate it! https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler target (PR #122627)

https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/122627 This a prime patch to support generic target when using `--offload-compress`. >From 95332e05f381f7e80cd1c57420db0c56cf8aedcf Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Sat, 11 Jan 2025 21:24:53 -0500 Sub

[clang] [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler target (PR #122627)

shiltian wrote: * **#122627** https://app.graphite.dev/github/pr/llvm/llvm-project/122627?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/122

[clang] [Driver] Avoid repeated map lookups (NFC) (PR #122625)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/122625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

@@ -4493,13 +4493,11 @@ struct FormatStyle { bool SpaceBeforeRangeBasedForLoopColon; /// If ``true``, spaces will be inserted into ``{}``. - /// \code - ///true:false: - ///void f() { } vs. void f() {} - ///

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

owenca wrote: > rebased but still required to be tested and fix again See https://github.com/llvm/llvm-project/pull/93634#discussion_r1912374181. https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/leijurv edited https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/leijurv edited https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

@@ -6,6 +6,275 @@ TEST_F(FormatTest, WrapsTemplateDeclarationsWithComments) { Style); } +TEST_F(FormatTest, BreakBeforeTemplateClose) { + FormatStyle Style = getGoogleStyle(FormatStyle::LK_Cpp); + // Begin with tests covering the case where there is no constra

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/owenca commented: You can run `ninja clang-format-check-format` to make sure your patch is correctly formatted before pushing. https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

https://github.com/TilakChad updated https://github.com/llvm/llvm-project/pull/122611 >From 4e5935f6631f0f0cd828559ec29ed931bc0333d3 Mon Sep 17 00:00:00 2001 From: Tilak Chad Date: Sun, 12 Jan 2025 00:03:32 +0545 Subject: [PATCH 1/2] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG_

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

@@ -774,7 +774,12 @@ std::string PredefinedExpr::ComputeName(PredefinedIdentKind IK, const FunctionDecl *Decl = FD; if (const FunctionDecl* Pattern = FD->getTemplateInstantiationPattern()) Decl = Pattern; -const FunctionType *AFT = Decl->getType()->getAs(); +

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

TilakChad wrote: I've updated the release notes. Thanks for reminding and for the review. :smile: https://github.com/llvm/llvm-project/pull/122611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001 From: Leijurv Date: Fri, 29 Nov 2024 21:54:36 -0600 Subject: [PATCH 1/6] [clang-format] Add BreakBeforeTemplateClose option --- clang/doc

[clang] [Driver] Avoid repeated map lookups (NFC) (PR #122625)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/122625 None >From b9a6a99e421170fbc1fb8c6641a83d21dfa0076c Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 11 Jan 2025 17:53:36 -0800 Subject: [PATCH] [Driver] Avoid repeated map lookups (NFC) --- clang

[clang] [Driver] Avoid repeated map lookups (NFC) (PR #122625)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122625.diff 1 Files Affected: - (modified) clang/lib/Driver/Driver.cpp (+2-2) ``diff diff --git

[clang] 4f6fabd - [Driver] Avoid repeated map lookups (NFC) (#122625)

Author: Kazu Hirata Date: 2025-01-11T19:49:59-08:00 New Revision: 4f6fabd11ad1a5de8e066adad28c8da4a615f8bb URL: https://github.com/llvm/llvm-project/commit/4f6fabd11ad1a5de8e066adad28c8da4a615f8bb DIFF: https://github.com/llvm/llvm-project/commit/4f6fabd11ad1a5de8e066adad28c8da4a615f8bb.diff L

  1   2   >