erichkeane wrote:
> > Is kinda wrong, it should be in the instantiation of that function...
>
> @erichkeane I don’t quite understand: the CWG issue itself requires us to
> check the constraint before substituting into the function during template
> argument deduction. So it shouldn’t live in a
https://github.com/carlocab edited
https://github.com/llvm/llvm-project/pull/122144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
I spent sometimes on this with @zyn0217
```cpp
template
using compare_three_way_result_t = _Up ::type;
struct __sfinae_assign_base {};
template
requires ([](W) { return true; }(_Up())) // #1
compare_three_way_result_t<_Tp, _Up> operator<=>(_Tp, _Up); //#2
struct RuntimeM
https://github.com/andergnet created
https://github.com/llvm/llvm-project/pull/122282
This PR fixes the issue https://github.com/llvm/llvm-project/issues/106228 were
the C++ ">>" operator got a different formatting than the "<<" one when using
BreakBinaryOperations.
This is my first PR on the
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Ander (andergnet)
Changes
This PR fixes the issue https://github.com/llvm/llvm-project/issues/106228 were
the C++ ">>" operator got a different formatting than the "<<" one
when using BreakBinaryOperations.
This is my first PR on
frasercrmck wrote:
> @frasercrmck BasicAA returns MayAlias for your example. Presumably AMDGPUAA
> returns NoAlias because addrspace(3) and addrspace(0) can't alias, or
> something like that.
Yep, you're right, sorry for the false alarm. Because it's a `amdgpu_kernel`
function and `A` (`%incd
@@ -5321,6 +5321,58 @@ class BuiltinBitCastExpr final
}
};
+// Represents an unexpanded pack where the list of expressions are
+// known. These are used when structured bindings introduce a pack.
+class ResolvedUnexpandedPackExpr final
+: public Expr,
+ private llvm
@@ -15991,6 +15991,13 @@
TreeTransform::TransformFunctionParmPackExpr(FunctionParmPackExpr *E) {
return E;
}
+template
+ExprResult TreeTransform::TransformResolvedUnexpandedPackExpr(
+ResolvedUnexpandedPackExpr *E) {
+ // Default behavior is to do nothing with this tr
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/121417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4167,6 +4165,8 @@ class BindingDecl : public ValueDecl {
/// Set the decomposed variable for this BindingDecl.
void setDecomposedDecl(ValueDecl *Decomposed) { Decomp = Decomposed; }
+ VarDecl *getHoldingVar() const;
erichkeane wrote:
Can we get the c
@@ -5321,6 +5321,58 @@ class BuiltinBitCastExpr final
}
};
+// Represents an unexpanded pack where the list of expressions are
+// known. These are used when structured bindings introduce a pack.
+class ResolvedUnexpandedPackExpr final
+: public Expr,
+ private llvm
@@ -2484,6 +2488,14 @@ TemplateInstantiator::TransformDeclRefExpr(DeclRefExpr
*E) {
if (PD->isParameterPack())
return TransformFunctionParmPackRefExpr(E, PD);
+ if (BindingDecl *BD = dyn_cast(D); BD && BD->isParameterPack())
{
+BD = cast(TransformDecl(BD->getL
@@ -3423,6 +3425,30 @@ VarDecl *BindingDecl::getHoldingVar() const {
return VD;
}
+void DecompositionDecl::VisitHoldingVars(
erichkeane wrote:
Rather than both of these functions, I'd prefer we have some sort of iterators
that allow standard iteration over
@@ -1965,3 +1965,52 @@ CXXFoldExpr::CXXFoldExpr(QualType T,
UnresolvedLookupExpr *Callee,
SubExprs[SubExpr::RHS] = RHS;
setDependence(computeDependence(this));
}
+
+ResolvedUnexpandedPackExpr::ResolvedUnexpandedPackExpr(SourceLocation BL,
+
https://github.com/erichkeane commented:
Most of this looks good, a handful of small concerns/changes I want, else
pretty good.
https://github.com/llvm/llvm-project/pull/121417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
@@ -2556,6 +2558,15 @@ void StmtPrinter::VisitPackIndexingExpr(PackIndexingExpr
*E) {
OS << "]";
}
+void StmtPrinter::VisitResolvedUnexpandedPackExpr(
+ResolvedUnexpandedPackExpr *E) {
+ OS << "getExprs() + E->getNumExprs(),
erichkeane
@@ -12726,11 +12726,15 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) {
// Likewise, variables with tuple-like bindings are required if their
// bindings have side-effects.
- if (const auto *DD = dyn_cast(VD))
-for (const auto *BD : DD->bindings())
- if (co
Author: Oleksandr T.
Date: 2025-01-09T17:01:30+02:00
New Revision: 1a73654b3212b623ac21b9deb3aeaadc6906b7e4
URL:
https://github.com/llvm/llvm-project/commit/1a73654b3212b623ac21b9deb3aeaadc6906b7e4
DIFF:
https://github.com/llvm/llvm-project/commit/1a73654b3212b623ac21b9deb3aeaadc6906b7e4.diff
https://github.com/a-tarasyuk closed
https://github.com/llvm/llvm-project/pull/121614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/emaxx-google created
https://github.com/llvm/llvm-project/pull/122286
Don't suggest to comment-out the parameter name if the parameter has an
attribute that's spelled after the parameter name.
This prevents the parameter's attributes from being wrongly applied to the
parame
erichkeane wrote:
That seems like a heavy hand. Should we instead be checking the 'unevaluated
context' state to see whether we should be emitting stuff? I can't imagine
that anything from an unevaluated context should ever be emitted.
https://github.com/llvm/llvm-project/pull/102857
___
https://github.com/a-tarasyuk deleted
https://github.com/llvm/llvm-project/pull/121614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/andergnet updated
https://github.com/llvm/llvm-project/pull/122282
>From e2780f01d47518bb61a5c01c9ad4d9daddb5044a Mon Sep 17 00:00:00 2001
From: W123011
Date: Thu, 9 Jan 2025 15:04:26 +0100
Subject: [PATCH 1/3] Fix >> behavior on continuation intenter
---
clang/lib/Format/C
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-backend-x86
Author: Timm Baeder (tbaederr)
Changes
---
Patch is 43.47 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Timm Baeder (tbaederr)
Changes
---
Patch is 43.47 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/122289.diff
40 Files Affected:
- (modified
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Timm Baeder (tbaederr)
Changes
---
Patch is 43.47 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/122289.diff
40 Files Affected:
-
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Timm Baeder (tbaederr)
Changes
---
Patch is 43.47 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/122289.diff
40 Files Aff
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-clang-tidy
Author: Congcong Cai (HerrCai0907)
Changes
1. add `static` for internal linkage functions
2. remove `clang` prefix for `QualType`
---
Full diff: https://github.com/llvm/llvm-project/pull/122288.diff
1
https://github.com/jvoung created
https://github.com/llvm/llvm-project/pull/122290
With caching added in https://github.com/llvm/llvm-project/pull/120249,
inform in notes that the `IgnoreSmartPointerDereference` option shouldn't
be needed anymore.
Other caching also added earlier:
https://githu
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Maksim Ivanov (emaxx-google)
Changes
Don't suggest to comment-out the parameter name if the parameter has an
attribute that's spelled after the parameter name.
This prevents the parameter's attributes from being wrongly applied to th
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/122289
None
>From 813b4bee5bddfbbc3eec8a7047c51cfde825bcee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Thu, 9 Jan 2025 16:01:59 +0100
Subject:
https://github.com/HerrCai0907 ready_for_review
https://github.com/llvm/llvm-project/pull/122288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/122288
1. add `static` for internal linkage functions
2. remove `clang` prefix for `QualType`
>From e12379058b4d4b22f46d7727f4ad28ecc2468f7a Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 9 Jan 2025 22:42:
HerrCai0907 wrote:
* **#122288** https://app.graphite.dev/github/pr/llvm/llvm-project/122288?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/122289
>From 813b4bee5bddfbbc3eec8a7047c51cfde825bcee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Thu, 9 Jan 2025 16:01:59 +0100
Subject: [PATC
https://github.com/emaxx-google updated
https://github.com/llvm/llvm-project/pull/122286
>From 3faba8c3df1901d9fb58bf0d087a2a832ac9f04a Mon Sep 17 00:00:00 2001
From: Maksim Ivanov
Date: Thu, 9 Jan 2025 14:59:35 +
Subject: [PATCH] [clang-tidy] Fix misc-unused-parameters on params with attrs
@@ -137,6 +137,10 @@ llvm::AllocaInst
*CodeGenFunction::CreateTempAlloca(llvm::Type *Ty,
Alloca =
new llvm::AllocaInst(Ty, CGM.getDataLayout().getAllocaAddrSpace(),
ArraySize, Name, AllocaInsertPt->getIterator());
+ if (Alloca->getName
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
tbaederr wrote:
@JDevlieghere The previous attempt made some lldb build bots fail. I've now
changed `TypeSystemClang.cpp` to create `ConstantExpr`s for the bitwidth values
and adapted one of the tests. Please review.
https://github.com/llvm/ll
tbaederr wrote:
>- We check whether two pointers are in the same range
>
> Is that possible to implement in the interpreter without going back to AST
> visitors?
I take "in the same range" meaning as "can be compared at compile time at all"
here, so yes, that would be rather trivial (we ha
GrumpyPigSkin wrote:
@cor3ntin, is this okay to be merged now or is there anything more you would
like me to add?
https://github.com/llvm/llvm-project/pull/121056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/121667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
camel-cdr wrote:
I thought the P550 was supposed to support RV64GCB, but that wouls require Zbs
support, which isn't listed here.
https://github.com/llvm/llvm-project/pull/122164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
nikic wrote:
@frasercrmck BasicAA returns MayAlias for your example. Presumably AMDGPUAA
returns NoAlias because addrspace(3) and addrspace(0) can't alias, or something
like that.
https://github.com/llvm/llvm-project/pull/119365
___
cfe-commits maili
antoniofrighetto wrote:
Kind ping for correct direction.
https://github.com/llvm/llvm-project/pull/120783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/120930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
quic-garvgupt wrote:
I have divided this PR into three separate PRs to streamline the review process
and ensured that ARM and RISCV tests are not modified in the same PR. Please
review them and provide any feedback or comments. Thanks!
[RISCV] Teach Barmetal toolchain about GCC installation(1/
https://github.com/jayfoad approved this pull request.
https://github.com/llvm/llvm-project/pull/122169
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Sergio Afonso
Date: 2025-01-09T10:28:16Z
New Revision: b79ed8729b3d6d5482481c41a7de2cd75b0f61df
URL:
https://github.com/llvm/llvm-project/commit/b79ed8729b3d6d5482481c41a7de2cd75b0f61df
DIFF:
https://github.com/llvm/llvm-project/commit/b79ed8729b3d6d5482481c41a7de2cd75b0f61df.diff
LOG:
https://github.com/skatrak closed
https://github.com/llvm/llvm-project/pull/115863
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -222,6 +227,9 @@ class CompilerInvocation : public CompilerInvocationBase {
return defaultKinds;
}
+ bool getEnableTimers() { return enableTimers; }
macurtis-amd wrote:
Nit: non-const getter is not needed.
https://github.com/llvm/llvm-project/pull/
@@ -167,6 +170,31 @@ bool CompilerInstance::executeAction(FrontendAction &act) {
// Set options controlling lowering to FIR.
invoc.setLoweringOptions();
+ if (invoc.getEnableTimers()) {
+// FIXME: Currently, enabling these results in a duplicate registration
+// e
@@ -1358,6 +1358,12 @@ bool CompilerInvocation::createFromArgs(
}
}
+ // Process the timing-related options.
+ if (const llvm::opt::Arg *a =
macurtis-amd wrote:
`a` is unused and produces a warning in my build.
https://github.com/llvm/llvm-project/pu
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux`
running on `systemz-1` while building `clang` at step 6 "test-openmp".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/88/builds/6586
Here is the relevant piece of the build log fo
Hana =?utf-8?q?Dusíková?= ,
Hana =?utf-8?q?Dusíková?= ,
Hana =?utf-8?q?Dusíková?= ,
Hana =?utf-8?q?Dusíková?= ,
Hana =?utf-8?q?Dusíková?= ,
Hana =?utf-8?q?Dusíková?= ,
Hana =?utf-8?q?Dusíková?=
Message-ID:
In-Reply-To:
tbaederr wrote:
Unfortunately we currently have two constant
https://github.com/jvoung edited
https://github.com/llvm/llvm-project/pull/122290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2202,6 +2202,17 @@ void
ASTStmtWriter::VisitPackIndexingExpr(PackIndexingExpr *E) {
Code = serialization::EXPR_PACK_INDEXING;
}
+void ASTStmtWriter::VisitResolvedUnexpandedPackExpr(
erichkeane wrote:
DID you see my comment on how to test these? I made
hanickadot wrote:
> Unfortunately we currently have two constant expression evaluators, can you
> take a look at implementing this in the bytecode interpreter as well? Since
> this PR is already pretty big I think it would be OK to do it in a follow-up
> PR.
I will try, I'm not familiar with
https://github.com/jvoung updated
https://github.com/llvm/llvm-project/pull/122290
>From 342ff1a05caa6943fe8a86415f30b433ac30106f Mon Sep 17 00:00:00 2001
From: Jan Voung
Date: Thu, 9 Jan 2025 14:10:30 +
Subject: [PATCH 1/2] [clang-tidy] Add a release note about
unchecked-optional-access s
https://github.com/emaxx-google updated
https://github.com/llvm/llvm-project/pull/122286
>From 3faba8c3df1901d9fb58bf0d087a2a832ac9f04a Mon Sep 17 00:00:00 2001
From: Maksim Ivanov
Date: Thu, 9 Jan 2025 14:59:35 +
Subject: [PATCH 1/2] [clang-tidy] Fix misc-unused-parameters on params with
emaxx-google wrote:
@usx95
https://github.com/llvm/llvm-project/pull/122286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Congcong Cai
Date: 2025-01-09T23:25:33+08:00
New Revision: c01ffab6e1dac13a344a06677f413e55073d0580
URL:
https://github.com/llvm/llvm-project/commit/c01ffab6e1dac13a344a06677f413e55073d0580
DIFF:
https://github.com/llvm/llvm-project/commit/c01ffab6e1dac13a344a06677f413e55073d0580.diff
fhahn wrote:
@pinskia thanks for sharing the GCC context!
https://github.com/llvm/llvm-project/pull/122116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/122240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/122088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NagyDonat created
https://github.com/llvm/llvm-project/pull/122246
This commit migrates the contents of 'annotations.html' in the old HTML-based
documentation of the Clang static analyzer to the new RST-based documentation.
During this conversion I reordered the sections of
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Donát Nagy (NagyDonat)
Changes
This commit migrates the contents of 'annotations.html' in the old HTML-based
documentation of the Clang static analyzer to the new RST-based documentation.
During this conversion I reorder
Author: Timm Baeder
Date: 2025-01-09T11:42:35+01:00
New Revision: fd6baa477fa13a4b893aeeba7fce92eb6a1f4962
URL:
https://github.com/llvm/llvm-project/commit/fd6baa477fa13a4b893aeeba7fce92eb6a1f4962
DIFF:
https://github.com/llvm/llvm-project/commit/fd6baa477fa13a4b893aeeba7fce92eb6a1f4962.diff
L
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/118475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff dcdf44aca7be8a3e8f36d308b7fd5e5979140574
471ed86de267fb7b99b49d6187dc20d031eb4b7f --e
HerrCai0907 wrote:
ping
https://github.com/llvm/llvm-project/pull/121323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HerrCai0907 wrote:
ping
https://github.com/llvm/llvm-project/pull/121406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/paulhoad approved this pull request.
https://github.com/llvm/llvm-project/pull/122234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/122234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -406,7 +406,7 @@ void use() {
strings.insert(strings.begin(), std::string());
std::vector pointers;
- pointers.push_back(getLifetimeBoundPointer(std::string())); //
expected-warning {{object whose reference is captured by 'pointers' will be
destroyed at the end of th
philnik777 wrote:
> > We check which one is the currently active member of a union, and
>
> This is `__builtin_is_within_lifetime`, isn't it?
I didn't realize that exists. I guess that is the correct builtin, yes.
https://github.com/llvm/llvm-project/pull/122099
___
https://github.com/gbMattN edited
https://github.com/llvm/llvm-project/pull/119387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/122139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm wrote:
Context?
https://github.com/llvm/llvm-project/pull/122277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexey-bataev commented:
Need to change the caption and summary of PR, I assume
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
mbrkusanin wrote:
> Context?
Instruction is unused.
https://github.com/llvm/llvm-project/pull/122277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/121614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kpneal wrote:
D146845 wasn't committed because it would have caused test failures. The tests
are wrong, the new checks reveal this, but the new checks cannot be committed
until all broken tests are fixed. Otherwise we get failures from the bots and
the Verifier checks would have been reverted.
@@ -3423,6 +3425,30 @@ VarDecl *BindingDecl::getHoldingVar() const {
return VD;
}
+void DecompositionDecl::VisitHoldingVars(
+llvm::function_ref F) const {
+ VisitBindings([&](BindingDecl *BD) {
+if (VarDecl *VD = BD->getHoldingVar())
+ F(VD);
+ });
+}
+
+void
@@ -17153,11 +17155,25 @@ OMPClause
*SemaOpenMP::ActOnOpenMPVarListClause(OpenMPClauseKind Kind,
case OMPC_has_device_addr:
Res = ActOnOpenMPHasDeviceAddrClause(VarList, Locs);
break;
- case OMPC_allocate:
-Res = ActOnOpenMPAllocateClause(Data.DepModOrTailExpr,
https://github.com/yxsamliu created
https://github.com/llvm/llvm-project/pull/122307
Added initial support for version 3 of the compressed offload bundle format,
which uses 64-bit fields for Total File Size and Uncompressed Binary Size. This
enables support for files larger than 4GB. The suppo
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
Added initial support for version 3 of the compressed offload bundle format,
which uses 64-bit fields for Total File Size and Uncompressed Binary Size. This
enables supp
@@ -86,10 +87,11 @@
// CHECK-NEXT: sve-aes2FEAT_SVE_AES2
Enable Armv9.6-A SVE multi-vector AES and multi-vector quadword
polynomial multiply instructions
// CHECK-NEXT: sve-b16b16 FEAT_SVE_B16B16
@@ -376,9 +376,11 @@ def FeatureSVE2SM4 : ExtensionWithMArch<"sve2-sm4",
"SVE2SM4", "FEAT_SVE_SM4",
def FeatureSVE2SHA3 : ExtensionWithMArch<"sve2-sha3", "SVE2SHA3",
"FEAT_SVE_SHA3",
"Enable SHA3 SVE2 instructions", [FeatureSVE2, FeatureSHA3]>;
+def FeatureSVEBitPerm : Ext
https://github.com/Lukacma edited
https://github.com/llvm/llvm-project/pull/121947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -155,8 +155,8 @@ def HasSVE2SM4 :
Predicate<"Subtarget->isSVEAvailable() && Subtarget->hasS
AssemblerPredicateWithAll<(all_of
FeatureSVE2SM4), "sve2-sm4">;
def HasSVE2SHA3 : Predicate<"Subtarget->isSVEAvailable() &&
Subtarget->ha
https://github.com/Lukacma commented:
Thank you for the patch Carol ! On top of comments I left I think we should
also add new runlines to both assembly tests for individual instructions and
instrinsics tests, to check that we produce correct assembly when ssve-bitperm
feature is used. Also I
@@ -34,7 +34,7 @@ rax1 z0.d, z0.d, z0.d
.arch_extension sve2-bitperm
.arch_extension nosve2-bitperm
bgrp z21.s, z10.s, z21.s
Lukacma wrote:
I would add `.arch_extension nosve2` to make the error message make sense.
Currently for this test sve2 is enabled by
https://github.com/jhuber6 commented:
I've never been a fan of this type of implicit behavior, since it will change
spuriously depending on what the user wants.
I also wonder if we couldn't do something similar with ELF compression so we
don't need to manually do all this stuff.
https://githu
Author: Yaxun (Sam) Liu
Date: 2025-01-09T10:58:06-05:00
New Revision: 465a3ce9fac1fcf49d5772f70564973a73748d57
URL:
https://github.com/llvm/llvm-project/commit/465a3ce9fac1fcf49d5772f70564973a73748d57
DIFF:
https://github.com/llvm/llvm-project/commit/465a3ce9fac1fcf49d5772f70564973a73748d57.dif
sarnex wrote:
Yep already working on it, integration issue with another change from me, my bad
https://github.com/llvm/llvm-project/pull/120266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/mbrkusanin updated
https://github.com/llvm/llvm-project/pull/122277
From 27d929a270ea1d8d3fa885f00794a092af12e50e Mon Sep 17 00:00:00 2001
From: Mirko Brkusanin
Date: Mon, 23 Dec 2024 12:25:25 +0100
Subject: [PATCH 1/2] [AMDGPU] Remove s_wakeup_barrier instruction
---
clang
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while
building `clang` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/144/builds/15260
jplehr wrote:
This also failed one of our bots:
https://lab.llvm.org/buildbot/#/builders/140/builds/14350
https://github.com/llvm/llvm-project/pull/120266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
jplehr wrote:
> Yep already working on it, integration issue with another change from me, my
> bad
Thank you for working on a fix. :)
https://github.com/llvm/llvm-project/pull/120266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
301 - 400 of 533 matches
Mail list logo