[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

2025-01-03 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,485 @@ +//===--- BuiltinsX86_64.td - X86-64 Builtin function database ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Arseniy Zaostrovnykh (necto) Changes Generalize the `SymbolID`s used for `SymbolData` to all `SymExpr`s and use these IDs for comparison `SymbolRef` keys in various containers, such as `ConstraintMap`. These IDs are supe

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
https://github.com/necto created https://github.com/llvm/llvm-project/pull/121551 Generalize the `SymbolID`s used for `SymbolData` to all `SymExpr`s and use these IDs for comparison `SymbolRef` keys in various containers, such as `ConstraintMap`. These IDs are superior to raw pointer values be

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Arseniy Zaostrovnykh (necto) Changes Generalize the `SymbolID`s used for `SymbolData` to all `SymExpr`s and use these IDs for comparison `SymbolRef` keys in various containers, such as `ConstraintMap`. These IDs are superior to raw pointe

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
necto wrote: @steakhal @NagyDonat, I revised and improved #121347. To facilitate review, I broke the change down into 3 self-contained commits. let tests pass after each of them. I re-evaluated this version and discovered no difference in the analysis outcome. https://github.com/llvm/llvm-proj

[clang] [clang][analyzer] Stabilize path-constraint order by using alloc IDs (PR #121347)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
https://github.com/necto closed https://github.com/llvm/llvm-project/pull/121347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Stabilize path-constraint order by using alloc IDs (PR #121347)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
necto wrote: Superseded by https://github.com/llvm/llvm-project/pull/121551 https://github.com/llvm/llvm-project/pull/121347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

2025-01-03 Thread Phoebe Wang via cfe-commits
phoebewang wrote: I don't see any removal in BuiltinsX86_64.def. Is it intended? https://github.com/llvm/llvm-project/pull/121043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

2025-01-03 Thread Chandler Carruth via cfe-commits
chandlerc wrote: For many of the comments -- this, like the previous PR, is script generated based on the physical grouping of the current `.def` file. My preference would be to land it without trying to massage to better utilize the TableGen features, as I'd really like to get the first cut i

[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

2025-01-03 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,485 @@ +//===--- BuiltinsX86_64.td - X86-64 Builtin function database ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

2025-01-03 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,485 @@ +//===--- BuiltinsX86_64.td - X86-64 Builtin function database ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] Bulk port 64-bit x86 builtins to TableGen (PR #121043)

2025-01-03 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,485 @@ +//===--- BuiltinsX86_64.td - X86-64 Builtin function database ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISCV] Add support of Sdext, Sdtrig extentions (PR #120936)

2025-01-03 Thread Shao-Ce SUN via cfe-commits
https://github.com/sunshaoce closed https://github.com/llvm/llvm-project/pull/120936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2fae5bd - [RISCV] Add support of Sdext, Sdtrig extentions (#120936)

2025-01-03 Thread via cfe-commits
Author: Shao-Ce SUN Date: 2025-01-03T17:25:42+08:00 New Revision: 2fae5bdea7c2016d4086aa7ecf3c5d0592ce95c8 URL: https://github.com/llvm/llvm-project/commit/2fae5bdea7c2016d4086aa7ecf3c5d0592ce95c8 DIFF: https://github.com/llvm/llvm-project/commit/2fae5bdea7c2016d4086aa7ecf3c5d0592ce95c8.diff L

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2025-01-03 Thread via cfe-commits
https://github.com/aalhwc updated https://github.com/llvm/llvm-project/pull/121332 >From f247c1ab9fa89ca09476ed0a398a4c4385e75193 Mon Sep 17 00:00:00 2001 From: aalhwc Date: Mon, 30 Dec 2024 05:03:59 -0500 Subject: [PATCH] [Clang] Add GCC's __builtin_stack_address() to Clang (#82632). This ne

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2025-01-03 Thread via cfe-commits
@@ -4782,6 +4782,30 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Function *F = CGM.getIntrinsic(Intrinsic::frameaddress, AllocaInt8PtrTy); return RValue::get(Builder.CreateCall(F, Depth)); } + case Builtin::BI__builtin_stack_ad

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2025-01-03 Thread via cfe-commits
https://github.com/aalhwc edited https://github.com/llvm/llvm-project/pull/121332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2025-01-03 Thread via cfe-commits
https://github.com/aalhwc edited https://github.com/llvm/llvm-project/pull/121332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/121551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Balazs Benics via cfe-commits
@@ -56,6 +68,8 @@ class SymExpr : public llvm::FoldingSetNode { Kind getKind() const { return K; } + SymbolID getSymbolID() const { return Sym; } steakhal wrote: This is expected to be a fairly infrequently used API. I think this deserves to be highlight

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Balazs Benics via cfe-commits
@@ -687,4 +711,35 @@ class SymbolVisitor { } // namespace clang +// Override the default definition that would use pointer values of SymbolRefs +// to order them, which is unstable due to ASLR. +// Use the SymbolID instead which reflect the order in which the symbols were +//

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Balazs Benics via cfe-commits
@@ -687,4 +711,35 @@ class SymbolVisitor { } // namespace clang +// Override the default definition that would use pointer values of SymbolRefs +// to order them, which is unstable due to ASLR. +// Use the SymbolID instead which reflect the order in which the symbols were +//

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Balazs Benics via cfe-commits
@@ -687,4 +711,35 @@ class SymbolVisitor { } // namespace clang +// Override the default definition that would use pointer values of SymbolRefs +// to order them, which is unstable due to ASLR. +// Use the SymbolID instead which reflect the order in which the symbols were +//

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Balazs Benics via cfe-commits
https://github.com/steakhal commented: @Xazax-hun I'm pretty happy with this PR, but I'm curious about your opinion on adding the `SymbolID Sym` member to the SymExprs. https://github.com/llvm/llvm-project/pull/121551 ___ cfe-commits mailing list cfe-

[clang] [Clang] Fix unexpanded packs in NTTP type constraints (PR #121296)

2025-01-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/121296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
https://github.com/necto edited https://github.com/llvm/llvm-project/pull/121551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix deducing auto& from const int in template parameters is impossible in partial specializations (PR #79733)

2025-01-03 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/79733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diagtool] Make the BuiltinDiagnosticsByID table sorted (PR #120321)

2025-01-03 Thread kadir çetinkaya via cfe-commits
@@ -23,28 +23,29 @@ llvm::ArrayRef diagtool::getBuiltinDiagnosticsByName() { return llvm::ArrayRef(BuiltinDiagnosticsByName); } - // FIXME: Is it worth having two tables, especially when this one can get // out of sync easily? +// clang-format off kadirce

[clang] cdad183 - [clang] Fix #embed "fast path" (#121479)

2025-01-03 Thread via cfe-commits
Author: Mariya Podchishchaeva Date: 2025-01-03T11:17:16+01:00 New Revision: cdad18319425a7bf93cc25b276a7961fe5b1168b URL: https://github.com/llvm/llvm-project/commit/cdad18319425a7bf93cc25b276a7961fe5b1168b DIFF: https://github.com/llvm/llvm-project/commit/cdad18319425a7bf93cc25b276a7961fe5b116

[clang] [clang] Fix #embed "fast path" (PR #121479)

2025-01-03 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/121479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diagtool] Make the BuiltinDiagnosticsByID table sorted (PR #120321)

2025-01-03 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet requested changes to this pull request. https://github.com/llvm/llvm-project/pull/120321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. I am OK with this change. Having more stable analysis results is valuable. That being said, do we know how exactly the unstable addresses result in unstable results? https://github.com/llvm/llvm-project/pull/121551 __

[clang] Add support for aligning BlockComments in declarations (PR #109497)

2025-01-03 Thread Owen Pan via cfe-commits
@@ -1022,7 +1028,10 @@ void WhitespaceManager::alignConsecutiveDeclarations() { if (C.Tok->is(TT_FunctionDeclarationName)) return Style.AlignConsecutiveDeclarations.AlignFunctionDeclarations; if (C.Tok->isNot(TT_StartOfName)) - return false; +

[clang] Mechanically port bulk of x86 builtins to TableGen (PR #120831)

2025-01-03 Thread Chandler Carruth via cfe-commits
@@ -108,9 +109,15 @@ class PrototypeParser { } else if (T.consume_back("&")) { ParseType(T); Type += "&"; +} else if (T.consume_front("long long")) { chandlerc wrote: This does maybe point at something that doesn't add much complexity -- I

[clang] [Clang] Fix unexpanded packs in NTTP type constraints (PR #121296)

2025-01-03 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/121296 >From 102e031cae56c130f48f08bcb316b6f451facf49 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 29 Dec 2024 23:13:52 +0800 Subject: [PATCH 1/6] [Clang] Diagnose unexpanded packs for NTTP type constraints

[clang] 2e41489 - [Clang] Fix unexpanded packs in NTTP type constraints (#121296)

2025-01-03 Thread via cfe-commits
Author: Younan Zhang Date: 2025-01-03T19:10:43+08:00 New Revision: 2e41489d7b1498ec8a18b99e6d7db9e946f2d786 URL: https://github.com/llvm/llvm-project/commit/2e41489d7b1498ec8a18b99e6d7db9e946f2d786 DIFF: https://github.com/llvm/llvm-project/commit/2e41489d7b1498ec8a18b99e6d7db9e946f2d786.diff

[clang] [Clang] Fix unexpanded packs in NTTP type constraints (PR #121296)

2025-01-03 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/121296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread via cfe-commits
@@ -951,28 +959,130 @@ Sema::ActOnDecompositionDeclarator(Scope *S, Declarator &D, return New; } +namespace { +// CheckBindingsCount +// - Checks the arity of the structured bindings +// - Creates the resolved pack expr if there is +//one +bool CheckBindingsCount(Sema

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread via cfe-commits
@@ -9780,6 +9780,7 @@ Sema::ActOnFunctionDeclarator(Scope *S, Declarator &D, DeclContext *DC, QualType R = TInfo->getType(); assert(R->isFunctionType()); + cor3ntin wrote: Whitespace change https://github.com/llvm/llvm-project/pull/121417 __

[clang] [Clang] Fix unexpanded packs in NTTP type constraints (PR #121296)

2025-01-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11096 Here is the relevant piec

[clang] [llvm] [AMDGPU][True16][MC] true16 for v_alignbyte_b32 (PR #119750)

2025-01-03 Thread Ivan Kosarev via cfe-commits
@@ -2353,8 +2353,8 @@ def int_amdgcn_writelane : [IntrNoMem, IntrConvergent, IntrWillReturn, IntrNoCallback, IntrNoFree] >; -def int_amdgcn_alignbyte : ClangBuiltin<"__builtin_amdgcn_alignbyte">, - DefaultAttrsIntrinsic<[llvm_i32_ty], [llvm_i32_ty, llvm_i32_ty, llvm_i32_ty]

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread via cfe-commits
@@ -,12 +,57 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] Reapply "[Driver][OHOS] Fix lld link issue for OHOS (#118192)" (PR #120159)

2025-01-03 Thread Peng Huang via cfe-commits
phuang wrote: > We can disable the test on -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF layouts, > but I don't find a lit feature that. It cannot work, becasue in the failed case, llvm runtime `x86_64-unknown-linux-gnu` target is built with `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF`, but at same

[clang] [clang] Implement __attribute__((format_matches)) (PR #116708)

2025-01-03 Thread Erich Keane via cfe-commits
=?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier Message-ID: In-Reply-To: https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/116708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [clang] Implement __attribute__((format_matches)) (PR #116708)

2025-01-03 Thread Erich Keane via cfe-commits
=?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier Message-ID: In-Reply-To: @@ -595,6 +595,97 @@ ArgType::matchesType(ASTContext &C, QualType argTy) const { llvm_unreachable("Invalid ArgType Kind!"); } +static analyze_format_string::ArgType::MatchKind +integerTypeMat

[clang] [clang] Implement __attribute__((format_matches)) (PR #116708)

2025-01-03 Thread Erich Keane via cfe-commits
=?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier Message-ID: In-Reply-To: https://github.com/erichkeane approved this pull request. I did as deep of a look-through as I could, though this is obviously a big patch. I didn't come up with any real comments, so everythign looks alright to

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM, thanks for this improvement. Using the "raw" ordering of pointers is always a red flag, I strongly support eliminating it if possible. By the way, what fraction of the results is perturbed (replaced with other random results) when

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
@@ -,12 +,55 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/102857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread Jason Rice via cfe-commits
@@ -50,16 +51,28 @@ class CollectUnexpandedParameterPacksVisitor auto *FTD = FD ? FD->getDescribedFunctionTemplate() : nullptr; if (FTD && FTD->getTemplateParameters()->getDepth() >= DepthLimit) return; - } else if (getDepthAndIndex(ND).first >= D

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/102857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add float type support to __builtin_reduce_add and __builtin_reduce_multipy (PR #120367)

2025-01-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/120367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add float type support to __builtin_reduce_add and __builtin_reduce_multipy (PR #120367)

2025-01-03 Thread Farzon Lotfi via cfe-commits
@@ -1754,6 +1755,17 @@ static bool interp__builtin_vector_reduce(InterpState &S, CodePtr OpPC, PrimType ElemT = *S.getContext().classify(ElemType); unsigned NumElems = Arg.getNumElems(); + if (ElemType->isRealFloatingType()) { +if (ID != Builtin::BI__builtin_reduce_a

[clang] [Clang] Add float type support to __builtin_reduce_add and __builtin_reduce_multipy (PR #120367)

2025-01-03 Thread Farzon Lotfi via cfe-commits
farzonl wrote: @Il-Capitano @RKSimon could I get another review of this PR? Thanks in advance! https://github.com/llvm/llvm-project/pull/120367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread via cfe-commits
@@ -,12 +,55 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] Deprecate order file instrumentation (PR #121514)

2025-01-03 Thread David Li via cfe-commits
https://github.com/david-xl commented: Is the plan to reuse the clang option -forder-file-instrumentation in the future? https://github.com/llvm/llvm-project/pull/121514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [Clang] Add float type support to __builtin_reduce_add and __builtin_reduce_multipy (PR #120367)

2025-01-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/120367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2025-01-03 Thread via cfe-commits
pizzud wrote: > Suppose this check should be silent for a shared_ptr with use_count() == 1. > Is it possible to change implementation in order to following this way? Wouldn't that be a runtime check, and thus not something clang-tidy can do without significant data flow analysis effort? Separ

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2025-01-03 Thread via cfe-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/67467 >From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 26 Sep 2023 10:45:42 -0700 Subject: [PATCH 01/12] [clang-tidy] Add bugprone-move-shared-pointer-contents chec

[clang] [Clang] Add float type support to __builtin_reduce_add and __builtin_reduce_multipy (PR #120367)

2025-01-03 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: > @RKSimon It looks like you started this work with: > > 1. > [a23291b](https://github.com/llvm/llvm-project/commit/a23291b7db48670f7c57adcfb45877c826a97f22) > > 2. > [8a92c45](https://github.com/llvm/llvm-project/commit/8a92c45e07dc81c83ca3afda3971d98c512429d4) > > If

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Farzon Lotfi via cfe-commits
@@ -2881,6 +2881,14 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register ResVReg, // translated to a `LocalInvocationId` builtin variable return loadVec3BuiltinInputID(SPIRV::BuiltIn::LocalInvocationId, ResVReg, ResType, I); + c

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2025-01-03 Thread via cfe-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/67467 >From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 26 Sep 2023 10:45:42 -0700 Subject: [PATCH 01/12] [clang-tidy] Add bugprone-move-shared-pointer-contents chec

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl deleted https://github.com/llvm/llvm-project/pull/121521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/121521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add float type support to __builtin_reduce_add and __builtin_reduce_multipy (PR #120367)

2025-01-03 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > fp reductions are a nightmare - every time I thought we were getting > somewhere, something else fastmath related causes more headaches. @RKSimon should I not proceed with this PR? I was really hoping to use this in HLSL as it makes implementing many of our runtime apis easy i

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread Jason Rice via cfe-commits
@@ -951,28 +959,130 @@ Sema::ActOnDecompositionDeclarator(Scope *S, Declarator &D, return New; } +namespace { +// CheckBindingsCount +// - Checks the arity of the structured bindings +// - Creates the resolved pack expr if there is +//one +bool CheckBindingsCount(Sema

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
@@ -,12 +,55 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. LGTM. Might want to check formatting though. https://github.com/llvm/llvm-project/pull/121521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [llvm] [HLSL][SPIR-V] implement SV_GroupID semantic lowering (PR #121521)

2025-01-03 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/121521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread via cfe-commits
@@ -,12 +,55 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] [Clang][Driver] Declare win32 threads on Windows (PR #121442)

2025-01-03 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 updated https://github.com/llvm/llvm-project/pull/121442 From b4a5daabac693aa3021c81180a9d25ac34177f62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Miku=C5=82a?= Date: Wed, 1 Jan 2025 21:38:49 +0100 Subject: [PATCH] [Clang][Driver] Declare win32 threads on Windo

[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

2025-01-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: None (qt-tatiana) Changes - modernize-use-integer-sign-comparison should ignore a comparison between the signed wide type and the unsigned narrow type, see #120867 --- Full diff: https://github.com/llvm/llvm-project/pull/121506.diff

[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

2025-01-03 Thread via cfe-commits
https://github.com/qt-tatiana ready_for_review https://github.com/llvm/llvm-project/pull/121506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Arseniy Zaostrovnykh via cfe-commits
necto wrote: > That being said, do we know how exactly the unstable addresses result in > unstable results? One mechanism that we studied in the past weeks is the SMT issue refutation: assertion order is that of the constraint order in the `ConstraintMap`, and it turns out Z3 runs a query dif

[clang] [compiler-rt] [Driver][OHOS] Fix lld link issue (PR #121575)

2025-01-03 Thread Peng Huang via cfe-commits
https://github.com/phuang updated https://github.com/llvm/llvm-project/pull/121575 >From b3ba140c00891c36dc27bbdda23e19089b7a3a2f Mon Sep 17 00:00:00 2001 From: Peng Huang Date: Thu, 2 Jan 2025 13:07:24 -0500 Subject: [PATCH] [Driver][OHOS] Fix lld link issue The link error is becasue clang rt

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread Tom Stellard via cfe-commits
tstellar wrote: This looks fine. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
@@ -,12 +,57 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] [clang][NFC][docs] Fix typo in LanguageExtensions (PR #121576)

2025-01-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/121576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread via cfe-commits
@@ -13044,6 +13045,17 @@ class Sema final : public SemaBase { bool SkipForSpecialization = false, bool ForDefaultArgumentSubstitution = false); + /// Apart from storing the result to \p Result, this behaves the same as + /// another overload. + void getTemplateI

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread via cfe-commits
@@ -,12 +,55 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread via cfe-commits
@@ -,12 +,55 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
@@ -13044,6 +13045,17 @@ class Sema final : public SemaBase { bool SkipForSpecialization = false, bool ForDefaultArgumentSubstitution = false); + /// Apart from storing the result to \p Result, this behaves the same as + /// another overload. + void getTemplateI

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
@@ -13044,6 +13045,17 @@ class Sema final : public SemaBase { bool SkipForSpecialization = false, bool ForDefaultArgumentSubstitution = false); + /// Apart from storing the result to \p Result, this behaves the same as + /// another overload. + void getTemplateI

[clang] 68d2656 - [clang][NFC][docs] Fix typo in LanguageExtensions (#121576)

2025-01-03 Thread via cfe-commits
Author: Fabian Ritter Date: 2025-01-03T16:15:27+01:00 New Revision: 68d265666e708bad1c63b419b6275aaba1a7dcd2 URL: https://github.com/llvm/llvm-project/commit/68d265666e708bad1c63b419b6275aaba1a7dcd2 DIFF: https://github.com/llvm/llvm-project/commit/68d265666e708bad1c63b419b6275aaba1a7dcd2.diff

[clang] [clang][NFC][docs] Fix typo in LanguageExtensions (PR #121576)

2025-01-03 Thread Fabian Ritter via cfe-commits
https://github.com/ritter-x2a closed https://github.com/llvm/llvm-project/pull/121576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
@@ -,12 +,55 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread Jason Rice via cfe-commits
@@ -422,8 +445,8 @@ Sema::DiagnoseUnexpandedParameterPacks(SourceLocation Loc, if (const TemplateTypeParmType *TTP = Unexpanded[I].first.dyn_cast()) Name = TTP->getIdentifier(); -else - Name = cast(Unexpanded[I].first)->getIdentifier(); +else if

[clang] Deprecate order file instrumentation (PR #121514)

2025-01-03 Thread Ellis Hoag via cfe-commits
ellishg wrote: > Is the plan to reuse the clang option -forder-file-instrumentation in the > future? No I wasn't planning on it. I'd like to remove this code for maintainability reasons and to encourage others to use IRPGO instead https://github.com/llvm/llvm-project/pull/121514

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-03 Thread Jason Rice via cfe-commits
@@ -422,8 +445,8 @@ Sema::DiagnoseUnexpandedParameterPacks(SourceLocation Loc, if (const TemplateTypeParmType *TTP = Unexpanded[I].first.dyn_cast()) Name = TTP->getIdentifier(); -else - Name = cast(Unexpanded[I].first)->getIdentifier(); +else if

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2025-01-03 Thread Younan Zhang via cfe-commits
@@ -,12 +,57 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2025-01-03 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Ping https://github.com/llvm/llvm-project/pull/120095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-03 Thread via cfe-commits
@@ -3324,6 +3324,9 @@ def err_attribute_argument_out_of_range : Error< def err_init_priority_object_attr : Error< "can only use 'init_priority' attribute on file-scope definitions " "of objects of class type">; +def warn_init_priority_reserved : Warning< + "requested 'init

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-03 Thread via cfe-commits
https://github.com/el-ev updated https://github.com/llvm/llvm-project/pull/121577 >From 5551c179d4b1ed0f41885fc96fa4844c9b0435b5 Mon Sep 17 00:00:00 2001 From: Iris Shi <0...@owo.li> Date: Fri, 3 Jan 2025 23:00:14 +0800 Subject: [PATCH 1/3] fix gnu::init_priority behavior --- clang/include/cla

[clang] [clang] Fix `gnu::init_priority` attribute handling for reserved values (PR #121577)

2025-01-03 Thread via cfe-commits
@@ -3324,6 +3324,9 @@ def err_attribute_argument_out_of_range : Error< def err_init_priority_object_attr : Error< "can only use 'init_priority' attribute on file-scope definitions " "of objects of class type">; +def warn_init_priority_reserved : Warning< + "requested 'init

[clang] [Clang] Fix unexpanded packs in NTTP type constraints (PR #121296)

2025-01-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux` running on `systemz-1` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/6349 Here is the relevant piece of the build log fo

[clang] [clang][analyzer] Stable order for SymbolRef-keyed containers (PR #121551)

2025-01-03 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > That being said, do we know how exactly the unstable addresses result in > unstable results? I cannot pinpoint the responsible code fragment, but in general this is a typical property of associative data structures. A typical associative map doesn't preserve the order of in

[clang] [flang] [llvm] [mlir] [MLIR][OpenMP] Lowering aligned clause to LLVM IR for SIMD directive (PR #119536)

2025-01-03 Thread Kaviya Rajendiran via cfe-commits
kaviya2510 wrote: Thanks for the review @tblah . https://github.com/llvm/llvm-project/pull/119536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d3eb65f - [MLIR][OpenMP] Lowering aligned clause to LLVM IR for SIMD directive (#119536)

2025-01-03 Thread via cfe-commits
Author: Kaviya Rajendiran Date: 2025-01-03T16:22:38+05:30 New Revision: d3eb65f15dfda454424125b2fa675378bd350889 URL: https://github.com/llvm/llvm-project/commit/d3eb65f15dfda454424125b2fa675378bd350889 DIFF: https://github.com/llvm/llvm-project/commit/d3eb65f15dfda454424125b2fa675378bd350889.d

<    1   2   3   >