[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2025-01-02 Thread via cfe-commits
https://github.com/dty2 deleted https://github.com/llvm/llvm-project/pull/120904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Diagnose unexpanded packs for NTTP type constraints (PR #121296)

2025-01-02 Thread via cfe-commits
@@ -857,7 +857,8 @@ class PackDeductionScope { if (auto *NTTP = dyn_cast( TemplateParams->getParam(Index))) { if (!NTTP->isExpandedParameterPack()) - if (auto *Expansion = dyn_cast(NTTP->getType())) + if (auto *Expansion = dyn_cast(

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2025-01-02 Thread Owen Pan via cfe-commits
https://github.com/owenca commented: Also, please address https://github.com/llvm/llvm-project/pull/106145#pullrequestreview-2365418005. https://github.com/llvm/llvm-project/pull/106145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2025-01-02 Thread via cfe-commits
https://github.com/dty2 deleted https://github.com/llvm/llvm-project/pull/120904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2025-01-02 Thread via cfe-commits
https://github.com/dty2 closed https://github.com/llvm/llvm-project/pull/120904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] ohos: fix ohos.c test case error with LLVM_ENABLE_PER_TARGET_RUNTIME_… (PR #121484)

2025-01-02 Thread Peng Huang via cfe-commits
phuang wrote: Updated the cmake script to output error message if LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is OFF for ohos targets. https://github.com/llvm/llvm-project/pull/121484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [compiler-rt] ohos: fix ohos.c test case error with LLVM_ENABLE_PER_TARGET_RUNTIME_… (PR #121484)

2025-01-02 Thread Peng Huang via cfe-commits
https://github.com/phuang updated https://github.com/llvm/llvm-project/pull/121484 >From 14d95fba0e0142be90d8c72dc8baed7cefc2268d Mon Sep 17 00:00:00 2001 From: Peng Huang Date: Thu, 2 Jan 2025 10:21:00 -0500 Subject: [PATCH 1/2] ohos: fix ohos.c test case error with LLVM_ENABLE_PER_TARGET_RUN

[clang] [flang] [llvm] [mlir] [MLIR][OpenMP] Lowering aligned clause to LLVM IR for SIMD directive (PR #119536)

2025-01-02 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/119536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ASTMatcher] Add `dependentTemplateSpecializationType` AST mat… (PR #121435)

2025-01-02 Thread kefan cao via cfe-commits
@@ -1926,6 +1926,21 @@ TEST_P(ASTMatchersTest, DependentNameType) { dependentNameType())); } +TEST_P(ASTMatchersTest, DependentTemplateSpecializationType) { + if (!GetParam().isCXX()) { +return; + } + + EXPECT_TRUE(matches( + R"( + template struct A; ---

[clang] [analyzer] Don't assume third iteration in loops (PR #119388)

2025-01-02 Thread Donát Nagy via cfe-commits
NagyDonat wrote: If I understand correctly, I handled every review suggestion. @steakhal If there are no additional suggestions, I'd be grateful for an approval. (My follow-up commit is mostly ready, I'll release it soon after merging this.) https://github.com/llvm/llvm-project/pull/119388 __

[clang] WIP on vector deleting destructors (PR #121490)

2025-01-02 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/121490 None >From 2a63bcb5b63f3a8fbeb206fbdbcfc1a328054fe0 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Thu, 12 Dec 2024 08:57:37 -0800 Subject: [PATCH 1/6] Add rough body emission --- clang/lib/C

[clang] WIP on vector deleting destructors (PR #121490)

2025-01-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes --- Patch is 22.88 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/121490.diff 11 Files Affected: - (modified) clang/include/clang/AST/VTableBuilder

[clang] WIP on vector deleting destructors (PR #121490)

2025-01-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Mariya Podchishchaeva (Fznamznon) Changes --- Patch is 22.88 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/121490.diff 11 Files Affected: - (modified) clang/include/clang/AST/VTabl

[clang] WIP on vector deleting destructors (PR #121490)

2025-01-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 207e485f4b7e8113b8b329ddcde423aafc0a8832 6b6ff040c875fd12614409927f39e37920089070 --e

[clang] WIP on vector deleting destructors (PR #121490)

2025-01-02 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: Oops, too early https://github.com/llvm/llvm-project/pull/121490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

2025-01-02 Thread Erich Keane via cfe-commits
@@ -15978,6 +15988,24 @@ Decl *Sema::ActOnFinishFunctionBody(Decl *dcl, Stmt *Body, CheckCoroutineWrapper(FD); } + // Diagnose invalid SYCL kernel entry point function declarations. + if (FD && !FD->isInvalidDecl() && !FD->isTemplated() && + FD->hasAttr()) { +

[clang] WIP on vector deleting destructors (PR #121490)

2025-01-02 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/121490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ohos: fix ohos.c test case error with LLVM_ENABLE_PER_TARGET_RUNTIME_… (PR #121484)

2025-01-02 Thread Carlo Cabrera via cfe-commits
carlocab wrote: > Note: OHOS driver doesn't support the old layout, compiler-rt for > ${arch}-linux-unknown-ohos targets have to be built with > LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON Can we make `cmake` error out if you try to build for `*-linux-unknown-ohos` with `LLVM_ENABLE_PER_TARGET_RUNT

[clang] [llvm] [RISCV] Add a generic OOO CPU (PR #120712)

2025-01-02 Thread Philip Reames via cfe-commits
@@ -0,0 +1,494 @@ +//===-- RISCVSchedGenericOOO.td - Generic O3 Processor -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISCV] Add a generic OOO CPU (PR #120712)

2025-01-02 Thread Philip Reames via cfe-commits
@@ -0,0 +1,494 @@ +//===-- RISCVSchedGenericOOO.td - Generic O3 Processor -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISCV] Add a generic OOO CPU (PR #120712)

2025-01-02 Thread Philip Reames via cfe-commits
@@ -0,0 +1,494 @@ +//===-- RISCVSchedGenericOOO.td - Generic O3 Processor -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

2025-01-02 Thread Erich Keane via cfe-commits
@@ -1550,6 +1550,8 @@ NamedDecl *Sema::ActOnNonTypeTemplateParameter(Scope *S, Declarator &D, IdResolver.AddDecl(Param); } + ProcessDeclAttributes(S, Param, D); erichkeane wrote: Still want Aaron to check on this. https://github.com/llvm/llvm-project

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #117904)

2025-01-02 Thread Alexey Bataev via cfe-commits
@@ -5965,6 +5967,269 @@ static bool teamsLoopCanBeParallelFor(Stmt *AStmt, Sema &SemaRef) { return Checker.teamsLoopCanBeParallelFor(); } +static Expr *getInitialExprFromCapturedExpr(Expr *Cond) { + + Expr *SubExpr = Cond->IgnoreParenImpCasts(); + + if (auto *DeclRef = dy

[clang] [llvm] [RISCV] Add a generic OOO CPU (PR #120712)

2025-01-02 Thread Craig Topper via cfe-commits
@@ -0,0 +1,494 @@ +//===-- RISCVSchedGenericOOO.td - Generic O3 Processor -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [analyzer] Don't assume third iteration in loops (PR #119388)

2025-01-02 Thread Donát Nagy via cfe-commits
NagyDonat wrote: The LLVM Buildbot failure is clearly unrelated to this commit -- it seems to be a straightforward flakiness on a completely unrelated part of the project. https://github.com/llvm/llvm-project/pull/119388 ___ cfe-commits mailing list c

[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

2025-01-02 Thread Nick Sarnie via cfe-commits
sarnex wrote: Ping on this one @llvm/pr-subscribers-backend-spir-v @llvm/pr-subscribers-clang-driver Thx! https://github.com/llvm/llvm-project/pull/120266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcicli (Conditional Load Immediate) extension (PR #121292)

2025-01-02 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/121292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Stabilize path-constraint order by using alloc IDs (PR #121347)

2025-01-02 Thread Arseniy Zaostrovnykh via cfe-commits
@@ -401,7 +401,22 @@ class RangeSet { friend class Factory; }; -using ConstraintMap = llvm::ImmutableMap; +struct ConstraintKVInfo : llvm::ImutKeyValueInfo { + static inline bool isEqual(key_type_ref L, key_type_ref R) { +return L->getAllocID() == R->getAllocID(); + }

[clang] d5c8af4 - [clang][bytecode] Consider start index when copying composite array (#121461)

2025-01-02 Thread via cfe-commits
Author: Timm Baeder Date: 2025-01-02T10:31:49+01:00 New Revision: d5c8af492f2d8620b04330024d46a5f48db546fe URL: https://github.com/llvm/llvm-project/commit/d5c8af492f2d8620b04330024d46a5f48db546fe DIFF: https://github.com/llvm/llvm-project/commit/d5c8af492f2d8620b04330024d46a5f48db546fe.diff L

[clang] [clang][bytecode] Consider start index when copying composite array (PR #121461)

2025-01-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/121461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #117904)

2025-01-02 Thread via cfe-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/117904 >From 1703aa62cfe35538aedbacb28e907535e838248c Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Fri, 20 Sep 2024 01:41:29 -0500 Subject: [PATCH 01/11] Support for dispatch construct (Sema & Codege

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-02 Thread Younan Zhang via cfe-commits
@@ -0,0 +1,82 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c++2b %s -verify +// expected-no-diagnostics + +template +struct type_ { }; + +template +auto sum(T... t) { return (t + ...); } + +struct my_struct { + int a; + int b; + int c; + int d; +}; + +struct fake

[clang] [clang][analyzer] Stabilize path-constraint order by using alloc IDs (PR #121347)

2025-01-02 Thread Arseniy Zaostrovnykh via cfe-commits
necto wrote: > Does the unstable constraint order only affect Z3 refutation, or did you > measure/notice differences in report flakyness even without Z3 refutation? I > think it would be great to see the impact of this change, while we eliminate > the Z3 from the equation. I've measured it n

[clang] [clang] Return larger CXX records in memory (PR #120670)

2025-01-02 Thread Pranav Kant via cfe-commits
@@ -2067,6 +2081,10 @@ void X86_64ABIInfo::classify(QualType Ty, uint64_t OffsetBase, Class &Lo, classify(I.getType(), Offset, FieldLo, FieldHi, isNamedArg); Lo = merge(Lo, FieldLo); Hi = merge(Hi, FieldHi); +if (returnCXXRecordGreaterThan128InM

[clang] [clang] Return larger CXX records in memory (PR #120670)

2025-01-02 Thread Pranav Kant via cfe-commits
https://github.com/pranavk updated https://github.com/llvm/llvm-project/pull/120670 >From 4b6839317bcd2a014011cb91b5a3e58d4a47b0b1 Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Fri, 20 Dec 2024 02:17:23 + Subject: [PATCH 1/5] [clang] Return larger CXX records in memory We incorrectly re

[clang] ohos: fix ohos.c test case error with LLVM_ENABLE_PER_TARGET_RUNTIME_… (PR #121484)

2025-01-02 Thread Peng Huang via cfe-commits
phuang wrote: > > Note: OHOS driver doesn't support the old layout, compiler-rt for > > ${arch}-linux-unknown-ohos targets have to be built with > > LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON > > Can we make `cmake` error out if you try to build for `*-linux-unknown-ohos` > with `LLVM_ENABLE_PER_T

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2025-01-02 Thread via cfe-commits
https://github.com/dmasloff updated https://github.com/llvm/llvm-project/pull/106145 >From 9848394edfa4bbae9f4f2df4b3dbcecefeb72624 Mon Sep 17 00:00:00 2001 From: dmasloff Date: Mon, 26 Aug 2024 22:11:05 +0300 Subject: [PATCH 1/9] fix merge conflict --- clang/docs/ClangFormatStyleOptions.rst

[clang-tools-extra] [clangd] Reduce superfluous rename conflicts (PR #121515)

2025-01-02 Thread Ujan RoyBandyopadhyay via cfe-commits
https://github.com/ujan-r created https://github.com/llvm/llvm-project/pull/121515 This commit adds a namespace check to the code for detecting name collisions, allowing `bar` to be renamed to `foo` in the following snippet: ```c typedef struct foo {} Foo; Foo bar; ``` Previously, such a rena

[clang-tools-extra] [clangd] Reduce superfluous rename conflicts (PR #121515)

2025-01-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Ujan RoyBandyopadhyay (ujan-r) Changes This commit adds a namespace check to the code for detecting name collisions, allowing `bar` to be renamed to `foo` in the following snippet: ```c typedef struct foo {} Foo; Foo bar; ``` Previously

[clang-tools-extra] [clangd] Reduce superfluous rename conflicts (PR #121515)

2025-01-02 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Deprecate order file instrumentation (PR #121514)

2025-01-02 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg edited https://github.com/llvm/llvm-project/pull/121514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2025-01-02 Thread via cfe-commits
https://github.com/dmasloff updated https://github.com/llvm/llvm-project/pull/106145 >From dde31f15552cb4f95a50e0835238062a0e6c69d8 Mon Sep 17 00:00:00 2001 From: dmasloff Date: Mon, 26 Aug 2024 22:11:05 +0300 Subject: [PATCH 1/9] fix merge conflict --- clang/docs/ClangFormatStyleOptions.rst

[clang] Deprecate order file instrumentation (PR #121514)

2025-01-02 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg updated https://github.com/llvm/llvm-project/pull/121514 >From 432c55783cbb5d4a9675f1f6018b58ffc4fe636d Mon Sep 17 00:00:00 2001 From: Ellis Hoag Date: Thu, 2 Jan 2025 10:51:54 -0800 Subject: [PATCH 1/2] Deprecate order file instrumentation --- clang/include/clang/D

[clang] Deprecate order file instrumentation (PR #121514)

2025-01-02 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg created https://github.com/llvm/llvm-project/pull/121514 `-forder-file-instrumentation` is used to instrument a startup function order, but this feature is also in IRPGO as Temporal Profiling. As discussed in https://discourse.llvm.org/t/rfc-temporal-profiling-extens

[clang] Deprecate order file instrumentation (PR #121514)

2025-01-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Ellis Hoag (ellishg) Changes `-forder-file-instrumentation` is used to instrument a startup function order, but this feature is also in IRPGO as Temporal Profiling. As discussed in https://discourse.llvm.

[clang] Deprecate order file instrumentation (PR #121514)

2025-01-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d9111f19d2ea53d8ce105b3d09425394ccf37969 432c55783cbb5d4a9675f1f6018b58ffc4fe636d --e

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-02 Thread Jason Rice via cfe-commits
@@ -422,8 +445,8 @@ Sema::DiagnoseUnexpandedParameterPacks(SourceLocation Loc, if (const TemplateTypeParmType *TTP = Unexpanded[I].first.dyn_cast()) Name = TTP->getIdentifier(); -else - Name = cast(Unexpanded[I].first)->getIdentifier(); +else if

[clang] [llvm] [Driver][clang-linker-wrapper] Add initial support for OpenMP offloading to generic SPIR-V (PR #120145)

2025-01-02 Thread Nick Sarnie via cfe-commits
sarnex wrote: @jhuber6 Thanks, if you don't think we need any more reviews do you mind merging? I still don't have push (working on it). If not, could you please ping other reviewers? Thx https://github.com/llvm/llvm-project/pull/120145 ___ cfe-commit

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-02 Thread Jason Rice via cfe-commits
@@ -0,0 +1,82 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c++2b %s -verify +// expected-no-diagnostics + +template +struct type_ { }; + +template +auto sum(T... t) { return (t + ...); } + +struct my_struct { + int a; + int b; + int c; + int d; +}; + +struct fake

[clang] Add -fuse-lipo option (PR #121231)

2025-01-02 Thread Ashley Hauck via cfe-commits
https://github.com/khyperia updated https://github.com/llvm/llvm-project/pull/121231 >From 33b542152876b9ccbf42cc3d070d582c32145477 Mon Sep 17 00:00:00 2001 From: khyperia Date: Fri, 27 Dec 2024 23:03:58 +0100 Subject: [PATCH 1/3] Add -fuse-lipo option --- clang/include/clang/Driver/Options.t

[clang] Add -fuse-lipo option (PR #121231)

2025-01-02 Thread Ashley Hauck via cfe-commits
khyperia wrote: > LGTM in general with a comment in test. > > For discussion. Is it better if the option supplies the full path to lipo or > just the name? Full path seems to be easy to use, but might deserve a warning > if the tool doesn't exist. If just the name, it might be better to rename

[clang] [llvm] [Driver][clang-linker-wrapper] Add initial support for OpenMP offloading to generic SPIR-V (PR #120145)

2025-01-02 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > @jhuber6 Thanks, if you don't think we need any more reviews do you mind > merging? I still don't have push (working on it). If not, could you please > ping other reviewers? Thx Sure, what's left for this to work? I'm probably going to be messing around with the OpenMP 'Devic

<    1   2   3