[clang] [Clang] Diagnose unexpanded packs for NTTP type constraints (PR #121296)

2024-12-31 Thread Younan Zhang via cfe-commits
@@ -857,7 +857,8 @@ class PackDeductionScope { if (auto *NTTP = dyn_cast( TemplateParams->getParam(Index))) { if (!NTTP->isExpandedParameterPack()) - if (auto *Expansion = dyn_cast(NTTP->getType())) + if (auto *Expansion = dyn_cast(

[clang] [llvm] [AArch64][SME] Disable inlining of callees with new ZT0 state (PR #121338)

2024-12-31 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm updated https://github.com/llvm/llvm-project/pull/121338 >From 8b8f191d9c6980f7342c0bea2681ffd8d1dbe90b Mon Sep 17 00:00:00 2001 From: Kerry McLaughlin Date: Mon, 30 Dec 2024 13:24:34 + Subject: [PATCH 1/2] [AArch64][SME] Disable inlining of callees with n

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 918316d3ee86c1655600738d201e42b30d8bedff Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [llvm] [AArch64][SME] Disable inlining of callees with new ZT0 state (PR #121338)

2024-12-31 Thread Kerry McLaughlin via cfe-commits
@@ -256,7 +256,7 @@ bool AArch64TTIImpl::areInlineCompatible(const Function *Caller, CalleeAttrs.set(SMEAttrs::SM_Enabled, true); } - if (CalleeAttrs.isNewZA()) kmclaughlin-arm wrote: Thanks @MacDue, there should be a similar restriction in Clang whic

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From a6837f7d31a54cc7e6e5bd6f18e19beb64feaf49 Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 00d35dcad3534cedc1373c957704366f8dc30225 Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 30c066f70dda6995e38f8f5288faf37e24520ec0 Mon Sep 17 00:00:00 2001 From: xtex Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixes #11743

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread via cfe-commits
@@ -164,6 +164,41 @@ TEST_F(MatchFilePathTest, Path) { EXPECT_FALSE(match("foo\\", R"(foo*\)")); } +TEST_F(MatchFilePathTest, Globstar) { + EXPECT_TRUE(match("/", "**")); + EXPECT_TRUE(match("foo", "**")); + EXPECT_TRUE(match("/foo", "**")); + EXPECT_TRUE(match("foo/", "

[clang] [llvm] [ConstantRange] Estimate tighter lower (upper) bounds for masked binary and (or) (PR #120352)

2024-12-31 Thread Stephen Senran Zhang via cfe-commits
zsrkmyn wrote: I'd appreciate much if you can help me commit it. https://github.com/llvm/llvm-project/pull/120352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Canonicalize absolute paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser edited https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
@@ -164,6 +164,41 @@ TEST_F(MatchFilePathTest, Path) { EXPECT_FALSE(match("foo\\", R"(foo*\)")); } +TEST_F(MatchFilePathTest, Globstar) { + EXPECT_TRUE(match("/", "**")); + EXPECT_TRUE(match("foo", "**")); + EXPECT_TRUE(match("/foo", "**")); + EXPECT_TRUE(match("foo/", "

[clang] 2feffec - [ConstantRange] Estimate tighter lower (upper) bounds for masked binary and (or) (#120352)

2024-12-31 Thread via cfe-commits
Author: Stephen Senran Zhang Date: 2024-12-31T18:40:17-08:00 New Revision: 2feffecb8853b1cdd38a0653df63d70412e65c12 URL: https://github.com/llvm/llvm-project/commit/2feffecb8853b1cdd38a0653df63d70412e65c12 DIFF: https://github.com/llvm/llvm-project/commit/2feffecb8853b1cdd38a0653df63d70412e65c1

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2024-12-31 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/121291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2024-12-31 Thread Baranov Victor via cfe-commits
vbvictor wrote: > I think that this check is one that we don't want to emit fixes for, at least > not in the main diagnostic, but maybe as a fixit attached to a note > What do others think? https://github.com/llvm/llvm-project/pull/121291 ___ cfe-c

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 79d2ed6ece54a9c1c7acd785156b5ffe10eb2ec7 Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 057dfa5d362257632a88b65e537df0b4fe806fe8 Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Djordje Todorovic via cfe-commits
https://github.com/djtodoro created https://github.com/llvm/llvm-project/pull/121394 Adding two extensions for MIPS p8700 CPU: 1. cmove (conditional move) 2. lsp (load/store pair) The official product page here: https://mips.com/products/hardware/p8700 >From a2e1fd5ffab4fe64a160571a9dffaa

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Djordje Todorovic (djtodoro) Changes Adding two extensions for MIPS p8700 CPU: 1. cmove (conditional move) 2. lsp (load/store pair) The official product page here: https://mips.com/products/hardware/p8700 --- Patch is 75.96

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Djordje Todorovic (djtodoro) Changes Adding two extensions for MIPS p8700 CPU: 1. cmove (conditional move) 2. lsp (load/store pair) The official product page here: https://mips.com/products/hardware/p8700 --- Patch is 75.96 K

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Djordje Todorovic (djtodoro) Changes Adding two extensions for MIPS p8700 CPU: 1. cmove (conditional move) 2. lsp (load/store pair) The official product page here: https://mips.com/products/hardware/p8700 --- Patch is 75.96 KiB, tru

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,371 @@ +//===- RISCVLoadStoreOptimizer.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,371 @@ +//===- RISCVLoadStoreOptimizer.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,371 @@ +//===- RISCVLoadStoreOptimizer.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1d5154663509b6200038a2f0b0ac958ea556fa9e a2e1fd5ffab4fe64a160571a9dffaacc3f22c32d --e

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,371 @@ +//===- RISCVLoadStoreOptimizer.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -298,6 +298,15 @@ class RISCVInstrInfo : public RISCVGenInstrInfo { unsigned getTailDuplicateSize(CodeGenOptLevel OptLevel) const override; + /// Return true if pairing the given load or store may be paired with another. + static bool isPairableLdStInstOpc(unsigned Op

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -514,6 +514,78 @@ class RVInstJhttps://github.com/llvm/llvm-project/pull/121394 https://github.com/llvm/llvm-project/pull/117865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2024-12-31 Thread via cfe-commits
@@ -4782,6 +4782,30 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Function *F = CGM.getIntrinsic(Intrinsic::frameaddress, AllocaInt8PtrTy); return RValue::get(Builder.CreateCall(F, Depth)); } + case Builtin::BI__builtin_stack_ad

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2024-12-31 Thread via cfe-commits
https://github.com/aalhwc edited https://github.com/llvm/llvm-project/pull/121332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2024-12-31 Thread Djordje Todorovic via cfe-commits
https://github.com/djtodoro updated https://github.com/llvm/llvm-project/pull/121394 >From f833498eb48595cc6b2bd5dd0c1b05d941313877 Mon Sep 17 00:00:00 2001 From: Djordje Todorovic Date: Thu, 26 Dec 2024 09:09:24 +0100 Subject: [PATCH] [RISCV] Add MIPS extensions Adding two extensions for MIPS

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -2017,6 +2169,74 @@ def : Pat<(binop_allwusers GPR:$rs1, (AddiPair:$rs2)), } //===--===// + +// MIPS extensions +//===--===// + +let Pre

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -62,6 +62,20 @@ static cl::opt RISCVMinimumJumpTableEntries( "riscv-min-jump-table-entries", cl::Hidden, cl::desc("Set minimum number of entries to use a jump table on RISCV")); +static cl::opt djtodoro wrote: Well, I do not think so. https://gith

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -367,6 +372,16 @@ class RISCVPassConfig : public TargetPassConfig { DAG->addMutation(createStoreClusterDAGMutation( DAG->TII, DAG->TRI, /*ReorderWhileClustering=*/true)); } + +const RISCVSubtarget &ST = C->MF->getSubtarget(); +if (!ST.getMacroFusi

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -426,6 +426,12 @@ The current vendor extensions supported are: ``Xwchc`` LLVM implements `the custom compressed opcodes present in some QingKe cores` by WCH / Nanjing Qinheng Microelectronics. The vendor refers to these opcodes by the name "XW". +``xmipscmove``

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -2017,6 +2169,74 @@ def : Pat<(binop_allwusers GPR:$rs1, (AddiPair:$rs2)), } //===--===// + djtodoro wrote: Addressed in https://github.com/llvm/llvm-project/pull/121394 https://github.

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -2710,6 +2713,45 @@ MachineInstr *RISCVInstrInfo::emitLdStWithAddr(MachineInstr &MemI, .setMemRefs(MemI.memoperands()) .setMIFlags(MemI.getFlags()); } +bool RISCVInstrInfo::isPairableLdStInstOpc(unsigned Opc) { + switch (Opc) { + default: +return false; +

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -1447,6 +1447,23 @@ def TuneConditionalCompressedMoveFusion def HasConditionalMoveFusion : Predicate<"Subtarget->hasConditionalMoveFusion()">; def NoConditionalMoveFusion : Predicate<"!Subtarget->hasConditionalMoveFusion()">; +def TuneMIPSP8700 +: SubtargetFeature<"m

[clang] 6279d2e - AArch64ABIInfo::passAsAggregateType - don't directly dereference getAs<> result. NFC.

2024-12-31 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-12-31T14:34:14Z New Revision: 6279d2e0f33ed1aa686aace48da6ccf912ab4b28 URL: https://github.com/llvm/llvm-project/commit/6279d2e0f33ed1aa686aace48da6ccf912ab4b28 DIFF: https://github.com/llvm/llvm-project/commit/6279d2e0f33ed1aa686aace48da6ccf912ab4b28.diff LOG:

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -2017,6 +2169,74 @@ def : Pat<(binop_allwusers GPR:$rs1, (AddiPair:$rs2)), } //===--===// + +// MIPS extensions +//===--===// + +let Pre

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-31 Thread Djordje Todorovic via cfe-commits
@@ -1447,6 +1447,23 @@ def TuneConditionalCompressedMoveFusion def HasConditionalMoveFusion : Predicate<"Subtarget->hasConditionalMoveFusion()">; def NoConditionalMoveFusion : Predicate<"!Subtarget->hasConditionalMoveFusion()">; +def TuneMIPSP8700 +: SubtargetFeature<"m

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2024-12-31 Thread Timm Baeder via cfe-commits
@@ -4782,6 +4782,30 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Function *F = CGM.getIntrinsic(Intrinsic::frameaddress, AllocaInt8PtrTy); return RValue::get(Builder.CreateCall(F, Depth)); } + case Builtin::BI__builtin_stack_ad

[clang] [clang][bytecode] Check memove/memcpy for available elements (PR #121383)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Both destination and source pointer need to have at least as many elements as requested. --- Full diff: https://github.com/llvm/llvm-project/pull/121383.diff 2 Files Affected: - (modified) clang/lib/AST/B

[clang] [clang][bytecode] Check memove/memcpy for available elements (PR #121383)

2024-12-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/121383 Both destination and source pointer need to have at least as many elements as requested. >From 129aa7348398123685a39555dd12c11f7da6d15f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue,

[clang] f0d6017 - [clang][bytecode] Check memove/memcpy for available elements (#121383)

2024-12-31 Thread via cfe-commits
Author: Timm Baeder Date: 2024-12-31T12:14:27+01:00 New Revision: f0d60170cc501447c999569db8fe91aacaad5fe2 URL: https://github.com/llvm/llvm-project/commit/f0d60170cc501447c999569db8fe91aacaad5fe2 DIFF: https://github.com/llvm/llvm-project/commit/f0d60170cc501447c999569db8fe91aacaad5fe2.diff L

[clang] [clang][bytecode] Check memove/memcpy for available elements (PR #121383)

2024-12-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/121383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix issue #117960 (PR #121039)

2024-12-31 Thread via cfe-commits
thebrandre wrote: Thanks for the feedback @cor3ntin! 🙂 I will change the title of the PR and of the commit message to: > _[clang] Fix implicit integer conversion for opaque enum declarations in > class templates_ adopting the terminology from [[dcl.enum]](https://wg21.link/dcl.enum) if that

[clang] [clang] Fix implicit integer conversion for opaque enum declarations in class templates (PR #121039)

2024-12-31 Thread via cfe-commits
https://github.com/thebrandre edited https://github.com/llvm/llvm-project/pull/121039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Diagnose unexpanded packs for NTTP type constraints (PR #121296)

2024-12-31 Thread via cfe-commits
@@ -857,7 +857,8 @@ class PackDeductionScope { if (auto *NTTP = dyn_cast( TemplateParams->getParam(Index))) { if (!NTTP->isExpandedParameterPack()) - if (auto *Expansion = dyn_cast(NTTP->getType())) + if (auto *Expansion = dyn_cast(

[clang] [clang][bytecode] Check memove/memcpy for available elements (PR #121383)

2024-12-31 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/10997 Here is the relevant piec

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 2aaa66fe42e10b968cfe259bfca721645d97b49c Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [Clang] Diagnose unexpanded packs for NTTP type constraints (PR #121296)

2024-12-31 Thread Younan Zhang via cfe-commits
@@ -857,7 +857,8 @@ class PackDeductionScope { if (auto *NTTP = dyn_cast( TemplateParams->getParam(Index))) { if (!NTTP->isExpandedParameterPack()) - if (auto *Expansion = dyn_cast(NTTP->getType())) + if (auto *Expansion = dyn_cast(

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From 9677fc64da8fa1bea56e6cee337f9fa90f6b7101 Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
@@ -7444,9 +7444,11 @@ isArithmeticArgumentPromotion(Sema &S, const ImplicitCastExpr *ICE) { From = VecTy->getElementType(); if (const auto *VecTy = To->getAs()) To = VecTy->getElementType(); - // It's a floating promotion if the source type is a lower rank. - retu

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
@@ -2289,6 +2289,33 @@ bool Type::isFloatingType() const { return false; } +bool Type::isCXX23StandardFloatingPointType(const ASTContext &Ctx) const { + if (!Ctx.getLangOpts().CPlusPlus23) +return false; + if (const auto *BT = dyn_cast(CanonicalType)) +return BT->g

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
https://github.com/cor3ntin commented: Thanks for working on this. I made a few comments (my review is a bit shallow as floating point isn't really my area of expertise...) Can you add - Tests to check template arguments deduction works properly - Tests that check the behavior on platforms t

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
@@ -4446,6 +4455,73 @@ CompareStandardConversionSequences(Sema &S, SourceLocation Loc, ? ImplicitConversionSequence::Better : ImplicitConversionSequence::Worse; + // C++23 12.2.4.3p4: cor3ntin wrote: Can you add the stable labe

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/78503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
@@ -453,8 +453,12 @@ static void InitializeStandardPredefinedMacros(const TargetInfo &TI, if (LangOpts.CPlusPlus26) // FIXME: Use correct value for C++26. Builder.defineMacro("__cplusplus", "202400L"); -else if (LangOpts.CPlusPlus23) +else if (LangOpts.

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread via cfe-commits
@@ -1032,6 +1033,21 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling, isFloat = true; continue; // Success. +// C++23 5.13.4 [lex.fcon] +case 'b': +case 'B': + if (!isFPConstant) +break; // Error for integer constant. +

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2024-12-31 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor reopened https://github.com/llvm/llvm-project/pull/121291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix crashes when passing VLA to va_arg (PR #119563)

2024-12-31 Thread via cfe-commits
amane-ame wrote: cc @efriedma-quic @tbaederr. Could anyone please review this? https://github.com/llvm/llvm-project/pull/119563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/121404 Closes #114969. >From 8b7802141853f77f3f074e6f41f416dfd25d90e4 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 31 Dec 2024 08:13:53 -0800 Subject: [PATCH] [clang-format] Support globstar in .clang-format-igno

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Closes #114969. --- Full diff: https://github.com/llvm/llvm-project/pull/121404.diff 4 Files Affected: - (modified) clang/docs/ClangFormat.rst (+4) - (modified) clang/docs/ReleaseNotes.rst (+1) - (modi

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Owen Pan (owenca) Changes Closes #114969. --- Full diff: https://github.com/llvm/llvm-project/pull/121404.diff 4 Files Affected: - (modified) clang/docs/ClangFormat.rst (+4) - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) c

[clang] [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (PR #121405)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: TilakChad (TilakChad) Changes For use of non-dependent type inside template, clang verifies eagerly that the type of variable being declared matches to that type. With this PR, we assign the type of the PackIndexingExpr to the type of the

[clang] [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (PR #121405)

2024-12-31 Thread via cfe-commits
https://github.com/TilakChad created https://github.com/llvm/llvm-project/pull/121405 For use of non-dependent type inside template, clang verifies eagerly that the type of variable being declared matches to that type. With this PR, we assign the type of the PackIndexingExpr to the type of the

[clang] [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (PR #121405)

2024-12-31 Thread via cfe-commits
TilakChad wrote: Alternatively, we could've make the PackIndexingExpr to be type dependent and try to verify type compatibility lazily during instantiation. It is how MSVC and GCC seems to behave. Considering that the clang seems to be eager about such type compatibility, this changes is alo

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread via cfe-commits
@@ -164,6 +164,41 @@ TEST_F(MatchFilePathTest, Path) { EXPECT_FALSE(match("foo\\", R"(foo*\)")); } +TEST_F(MatchFilePathTest, Globstar) { + EXPECT_TRUE(match("/", "**")); + EXPECT_TRUE(match("foo", "**")); + EXPECT_TRUE(match("/foo", "**")); + EXPECT_TRUE(match("foo/", "

[clang] [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (PR #121405)

2024-12-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/121405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1623c43 - [Clang] Resolved type of expression indexing into pack of values of a non-dependent type (#121405)

2024-12-31 Thread via cfe-commits
Author: TilakChad Date: 2025-01-01T15:50:05+08:00 New Revision: 1623c435948ae305220e638066e968cb3296e567 URL: https://github.com/llvm/llvm-project/commit/1623c435948ae305220e638066e968cb3296e567 DIFF: https://github.com/llvm/llvm-project/commit/1623c435948ae305220e638066e968cb3296e567.diff LOG

[clang] [llvm] [ConstantRange] Estimate tighter lower (upper) bounds for masked binary and (or) (PR #120352)

2024-12-31 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/120352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

2024-12-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #55474 --- Full diff: https://github.com/llvm/llvm-project/pull/121419.diff 8 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) clang/include/clang/Basic/DiagnosticSemaK

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From a4997209062fe1e2b23dcbe88ed2cdcdf8c9a0db Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

2024-12-31 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/121419 Fixes #55474 >From a9fdfac9f8655b8def5f99adde75bb5f2176057a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 1 Jan 2025 01:47:17 +0200 Subject: [PATCH] [Clang] emit -Wignored-qualifiers diagnostic for

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-12-31 Thread via cfe-commits
https://github.com/dmasloff updated https://github.com/llvm/llvm-project/pull/106145 >From 9848394edfa4bbae9f4f2df4b3dbcecefeb72624 Mon Sep 17 00:00:00 2001 From: dmasloff Date: Mon, 26 Aug 2024 22:11:05 +0300 Subject: [PATCH 1/8] fix merge conflict --- clang/docs/ClangFormatStyleOptions.rst

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-12-31 Thread via cfe-commits
dmasloff wrote: Resolved merge conflict https://github.com/llvm/llvm-project/pull/106145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread Fangrui Song via cfe-commits
MaskRay wrote: There is a typo in the subject. Absoultify => Absolutify. That said, sth like "canonicalize absolute paths " seem more appropriate wrt the changed semantics. https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/121404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-12-31 Thread M. Zeeshan Siddiqui via cfe-commits
@@ -2289,6 +2289,33 @@ bool Type::isFloatingType() const { return false; } +bool Type::isCXX23StandardFloatingPointType(const ASTContext &Ctx) const { + if (!Ctx.getLangOpts().CPlusPlus23) +return false; + if (const auto *BT = dyn_cast(CanonicalType)) +return BT->g

[clang] [llvm] [ConstantRange] Estimate tighter lower (upper) bounds for masked binary and (or) (PR #120352)

2024-12-31 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/120352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Support globstar in .clang-format-ignore (PR #121404)

2024-12-31 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/121404 >From 36efaa2849ee6276be5b3c0739f295d0921d1e6e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 31 Dec 2024 08:13:53 -0800 Subject: [PATCH 1/2] [clang-format] Support globstar in .clang-format-ignore Closes #1

[clang-tools-extra] [clangd] Add a unit test suite for HeuristicResolver (PR #121313)

2024-12-31 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/121313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add a unit test suite for HeuristicResolver (PR #121313)

2024-12-31 Thread Haojian Wu via cfe-commits
https://github.com/hokein commented: this looks good to me in general. https://github.com/llvm/llvm-project/pull/121313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add a unit test suite for HeuristicResolver (PR #121313)

2024-12-31 Thread Haojian Wu via cfe-commits
@@ -0,0 +1,521 @@ +//===-- HeuristicResolverTests.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] Diagnose unexpanded packs for NTTP type constraints (PR #121296)

2024-12-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/121296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Stabilize path-constraint order by using alloc IDs (PR #121347)

2024-12-31 Thread Balazs Benics via cfe-commits
@@ -427,8 +434,8 @@ class BinarySymExprImpl : public BinarySymExpr { public: BinarySymExprImpl(LHSTYPE lhs, BinaryOperator::Opcode op, RHSTYPE rhs, -QualType t) - : BinarySymExpr(ClassKind, op, t), LHS(lhs), RHS(rhs) { +QualType t

[clang] [clang][analyzer] Stabilize path-constraint order by using alloc IDs (PR #121347)

2024-12-31 Thread Balazs Benics via cfe-commits
@@ -401,7 +401,22 @@ class RangeSet { friend class Factory; }; -using ConstraintMap = llvm::ImmutableMap; +struct ConstraintKVInfo : llvm::ImutKeyValueInfo { + static inline bool isEqual(key_type_ref L, key_type_ref R) { +return L->getAllocID() == R->getAllocID(); + }

[clang] [clang][analyzer] Stabilize path-constraint order by using alloc IDs (PR #121347)

2024-12-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal commented: The content look narrow and precise. It raises me questions why is the only user of this new field the Constraint manager? And if the constraint manager is the only user, why is the SMT-based solver not using this? Should all the other immutableSet/Map ben

[clang] [clang][analyzer] Stabilize path-constraint order by using alloc IDs (PR #121347)

2024-12-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/121347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2024-12-31 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja requested changes to this pull request. https://github.com/llvm/llvm-project/pull/120920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2024-12-31 Thread A. Jiang via cfe-commits
@@ -0,0 +1,623 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang] [Clang] Diagnose unexpanded packs for NTTP type constraints (PR #121296)

2024-12-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/121296 >From 102e031cae56c130f48f08bcb316b6f451facf49 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 29 Dec 2024 23:13:52 +0800 Subject: [PATCH 1/4] [Clang] Diagnose unexpanded packs for NTTP type constraints

[clang] [Clang] Diagnose unexpanded packs for NTTP type constraints (PR #121296)

2024-12-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 converted_to_draft https://github.com/llvm/llvm-project/pull/121296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make passing incomplete types to builtin type-traits a non-sfinae-friendly error (PR #121333)

2024-12-31 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 approved this pull request. I think this is the right direction, so LGTM, but maybe you want to wait for other people to comment before landing. https://github.com/llvm/llvm-project/pull/121333 ___ cfe-commits mailing lis

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread via cfe-commits
https://github.com/xtexChooser updated https://github.com/llvm/llvm-project/pull/117458 >From ac31b0da02dac47e4099788d75f60970919c854f Mon Sep 17 00:00:00 2001 From: Bingwu Zhang Date: Sun, 24 Nov 2024 07:06:35 +0800 Subject: [PATCH] [clang] Absoultify paths in dependency file output This fixe

[clang] [clang-format] clang-format-ignore: Add support for double asterisk patterns (PR #110560)

2024-12-31 Thread Ameer J via cfe-commits
ameerj wrote: Closing in favor of #121404 https://github.com/llvm/llvm-project/pull/110560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] clang-format-ignore: Add support for double asterisk patterns (PR #110560)

2024-12-31 Thread Ameer J via cfe-commits
https://github.com/ameerj closed https://github.com/llvm/llvm-project/pull/110560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-12-31 Thread via cfe-commits
https://github.com/dmasloff updated https://github.com/llvm/llvm-project/pull/106145 >From 219424f9cd3477d9290c8766eaa857234a1ae387 Mon Sep 17 00:00:00 2001 From: dmasloff Date: Mon, 26 Aug 2024 22:11:05 +0300 Subject: [PATCH 1/7] [clang-format] Add new option: WrapNamespaceBodyWithNewlines -

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-12-31 Thread via cfe-commits
@@ -1493,6 +1493,22 @@ static auto computeNewlines(const AnnotatedLine &Line, Newlines = 1; } + if (Style.WrapNamespaceBodyWithEmptyLines != FormatStyle::WNBWELS_Leave) { +// Modify empty lines after TT_NamespaceLBrace. +if (PreviousLine && PreviousLine->endsWit

[clang] [clang] Absoultify paths in dependency file output (PR #117458)

2024-12-31 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/117458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >