dyung wrote:
``
> Hmm, this looks like I just didn't fix "enough".
>
> I've sent out #121043 and rebased this PR on top of that as well. Can you
> take another spin?
>
> This PR should be the right branch, incorporating all the other changes.
I've built and tested this PR (I think) and it doe
Author: Kinoshita Kotaro
Date: 2024-12-25T10:59:59+09:00
New Revision: 88d04be815bd289c691ab81061ac8a573ad15677
URL:
https://github.com/llvm/llvm-project/commit/88d04be815bd289c691ab81061ac8a573ad15677
DIFF:
https://github.com/llvm/llvm-project/commit/88d04be815bd289c691ab81061ac8a573ad15677.di
https://github.com/ytmukai closed
https://github.com/llvm/llvm-project/pull/120684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RossComputerGuy wrote:
We have a problem where everything related to `i128` / `long double` fail to
compile in LLVM libc without compiler-rt on aarch64 and possibly x86_64, this
is a problem. Related ABI info:
-
[aarch64](https://github.com/ARM-software/abi-aa/releases/download/2024Q3/aapcs64.
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> {
let association = AS_Loop;
let category = CA_Executable;
}
+def OMP_Stripe : Directive<"stripe"> {
+ let allowedOnceClauses = [
+VersionedClause,
zahiraam wrote:
I see. In this case I think it
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public
OMPLoopTransformationDirective {
}
};
+class OMPStripeDirective final : public OMPLoopTransformationDirective {
+ friend class ASTStmtReader;
+ friend class OMPExecutableDirective;
+
+ /// Default list of offse
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while
building `clang,compiler-rt` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/186/builds/5155
Here i
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/121072
Fix build issue introduced in #120547
>From 747b60109d9b4f05aa695898591c68845809c7a0 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 25 Dec 2024 07:31:48 +0800
Subject: [PATCH] [clang-tidy]link LLVM
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Congcong Cai (HerrCai0907)
Changes
Fix build issue introduced in #120547
---
Full diff: https://github.com/llvm/llvm-project/pull/121072.diff
1 Files Affected:
- (modified) clang-tools-extra/clang-tidy/tool/CMakeLists.txt (
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/121057
>From 98d65a0b9a1189ce73d97d76527b458f93f17b43 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 24 Dec 2024 23:32:02 +0800
Subject: [PATCH] [clang-tidy] add depercation warning for non-whitelisted
glo
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls`
running on `linaro-g3-03` while building `clang-tools-extra` at step 1
"Checkout lnt".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/143/builds/4438
Here is the relevant piec
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vitaly Buka (vitalybuka)
Changes
Simplifies and improve precision of the test.
---
Patch is 47.35 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/121081.diff
1 Files Affected:
- (modified) c
MaskRay wrote:
> …(https://github.com/llvm/llvm-project/pull/107493)
The subject line is now wrapped by github's pr system.
Perhaps just use `[Driver][SYCL] Add initial SYCL offload compilation support`
as the subject and mention that this is a reland of #107493.
https://github.com/llvm/llv
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -780,6 +781,41 @@ Driver::OpenMPRuntimeKind Driver::getOpenMPRuntime(const
ArgList &Args) const {
return RT;
}
+static const char *getDefaultSYCLArch(Compilation &C) {
MaskRay wrote:
Remove this trivial function and inline its use
https://github.com/ll
https://github.com/MaskRay requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,56 @@
+///
+/// Perform several driver tests for SYCL offloading for JIT
+///
+
+/// Check the phases graph with -fsycl. Use of -fsycl enables offload
+// RUN: %clang -ccc-print-phases --target=x86_64-unknown-linux-gnu \
+// RUN: -fsycl %s 2>&1 \
+// RUN: | FileCheck
@@ -0,0 +1,56 @@
+///
+/// Perform several driver tests for SYCL offloading for JIT
+///
+
+/// Check the phases graph with -fsycl. Use of -fsycl enables offload
+// RUN: %clang -ccc-print-phases --target=x86_64-unknown-linux-gnu \
+// RUN: -fsycl %s 2>&1 \
Mask
@@ -0,0 +1,56 @@
+///
+/// Perform several driver tests for SYCL offloading for JIT
+///
+
+/// Check the phases graph with -fsycl. Use of -fsycl enables offload
+// RUN: %clang -ccc-print-phases --target=x86_64-unknown-linux-gnu \
+// RUN: -fsycl %s 2>&1 \
+// RUN: | FileCheck
@@ -0,0 +1,56 @@
+///
+/// Perform several driver tests for SYCL offloading for JIT
+///
+
+/// Check the phases graph with -fsycl. Use of -fsycl enables offload
+// RUN: %clang -ccc-print-phases --target=x86_64-unknown-linux-gnu \
+// RUN: -fsycl %s 2>&1 \
+// RUN: | FileCheck
@@ -993,6 +1028,41 @@ void Driver::CreateOffloadingDeviceToolChains(Compilation
&C,
return;
}
+ //
MaskRay wrote:
We don't use start a comment block with `//\n`. Just delete the part before `We
need to generate a SYCL toolchain if the user specified
@@ -6591,11 +6679,23 @@ const ToolChain &Driver::getOffloadingDeviceToolChain(
HostTC, Args);
break;
}
+case Action::OFK_SYCL:
+ switch (Target.getArch()) {
MaskRay wrote:
Use `isSPI
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/121081
Simplifies and improve precision of the test.
>From 75aa55a129dd1311a889a9bb4b0f4ee04206d157 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Tue, 24 Dec 2024 19:38:02 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=
@@ -336,6 +338,9 @@ class LLVM_LIBRARY_VISIBILITY Generic_GCC : public
ToolChain {
const llvm::opt::ArgList &DriverArgs,
llvm::opt::ArgStringList &CC1Args) const override;
+ void AddSYCLIncludeArgs(const llvm::opt::ArgList &DriverArgs,
MaskRay wr
https://github.com/dkolsen-pgi created
https://github.com/llvm/llvm-project/pull/121069
Upstream several ClangIR-specific MLIR attributes, in particular attributes for
integer, floating-point, and null pointer constants. These are the first
ClangIR attributes to be upstreamed, so infrastructur
llvmbot wrote:
@llvm/pr-subscribers-clangir
Author: David Olsen (dkolsen-pgi)
Changes
Upstream several ClangIR-specific MLIR attributes, in particular attributes for
integer, floating-point, and null pointer constants. These are the first
ClangIR attributes to be upstreamed, so infrastru
https://github.com/scottconstable created
https://github.com/llvm/llvm-project/pull/121070
Kernel Control Flow Integrity (kCFI) is a feature that hardens indirect calls
by comparing a 32-bit hash of the function pointer's type against a hash of the
target function's type. If the hashes do not
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Scott Constable (scottconstable)
Changes
Kernel Control Flow Integrity (kCFI) is a feature that hardens indirect calls
by comparing a 32-bit hash of the function pointer's type against a hash of the
target function's type. If the ha
https://github.com/scottconstable updated
https://github.com/llvm/llvm-project/pull/121070
>From 70f1743e23ff8e218799e94b03a5bf033715666a Mon Sep 17 00:00:00 2001
From: Scott D Constable
Date: Mon, 23 Dec 2024 13:48:48 -0800
Subject: [PATCH] Implement a new kcfi_x86_arity feature that encodes a
@@ -11077,6 +11077,221 @@ TEST_F(FormatTest,
WrapsTemplateDeclarationsWithComments) {
Style);
}
+TEST_F(FormatTest, BreakBeforeTemplateClose) {
HazardyKnusperkeks wrote:
This one is still missing.
https://github.com/llvm/llvm-project/pull/118046
_
scottconstable wrote:
@phoebewang @sirmc @samitolvanen @Darksonn @lvwr @ojeda @maurer @rcvalle
@MaskRay
I have created https://github.com/llvm/llvm-project/pull/121070 to implement
the alternate proposal summarized in this comment above:
https://github.com/llvm/llvm-project/pull/117121#issuec
@@ -38,6 +40,10 @@ static bool mustBreakAfterAttributes(const FormatToken &Tok,
namespace {
+// TODO: Add new Type modifiers
HazardyKnusperkeks wrote:
```suggestion
// TODO: Add new Type modifiers.
```
https://github.com/llvm/llvm-project/pull/120904
__
@@ -181,8 +181,26 @@ void X86AsmPrinter::emitKCFITypeId(const MachineFunction
&MF) {
// Embed the type hash in the X86::MOV32ri instruction to avoid special
// casing object file parsers.
EmitKCFITypePadding(MF);
+
+ Register MovReg = X86::EAX;
+ const auto &Triple = M
@@ -2831,8 +2842,21 @@ class AnnotatingParser {
IsQualifiedPointerOrReference(BeforeRParen, LangOpts);
bool ParensCouldEndDecl =
AfterRParen->isOneOf(tok::equal, tok::semi, tok::l_brace,
tok::greater);
-if (ParensAreType && !ParensCouldEndDecl)
+if
scottconstable wrote:
> I haven't received a reply for my concerns I commented at [#117121
> (comment)](https://github.com/llvm/llvm-project/pull/117121#issuecomment-2502346476)
> and [#117121
> (comment)](https://github.com/llvm/llvm-project/pull/117121#issuecomment-2516251353),
> and they s
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Momchil Velikov (momchil-velikov)
Changes
---
Patch is 199.05 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/121063.diff
2 Files Affected:
- (added) clang/test/CodeGen/AArch64/fp8-intrinsic
a-tarasyuk wrote:
> If we were to add // clang-format off-next-line, would "next line" mean the
> next physical or logical/unwrapped line?
I would expect it to apply only to the physical line, similar to how other
formatters work. However, the main concern doesn’t seem to be about its
behavio
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/121006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -14477,6 +14484,279 @@ StmtResult
SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses,
buildPreInits(Context, PreInits));
}
+StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef
Clauses,
+
@@ -14477,6 +14484,279 @@ StmtResult
SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses,
buildPreInits(Context, PreInits));
}
+StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef
Clauses,
+
@@ -14477,6 +14484,279 @@ StmtResult
SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses,
buildPreInits(Context, PreInits));
}
+StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef
Clauses,
+
@@ -14477,6 +14484,279 @@ StmtResult
SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses,
buildPreInits(Context, PreInits));
}
+StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef
Clauses,
+
@@ -14477,6 +14484,279 @@ StmtResult
SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses,
buildPreInits(Context, PreInits));
}
+StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef
Clauses,
+
@@ -14477,6 +14484,279 @@ StmtResult
SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses,
buildPreInits(Context, PreInits));
}
+StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef
Clauses,
+
@@ -184,6 +191,37 @@ let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in {
} // hasSideEffects = 0, mayLoad = 0, mayStore = 0
} // Predicates = [HasVendorXqcia, IsRV32], DecoderNamespace = "Xqcia"
+let Predicates = [HasVendorXqciac, IsRV32], DecoderNamespace = "Xqciac" in {
+
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public
OMPLoopTransformationDirective {
}
};
+class OMPStripeDirective final : public OMPLoopTransformationDirective {
+ friend class ASTStmtReader;
+ friend class OMPExecutableDirective;
+
+ /// Default list of offse
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public
OMPLoopTransformationDirective {
}
};
+class OMPStripeDirective final : public OMPLoopTransformationDirective {
alexey-bataev wrote:
Add a comment describing the supported construct
https://gith
@@ -5965,6 +5967,269 @@ static bool teamsLoopCanBeParallelFor(Stmt *AStmt, Sema
&SemaRef) {
return Checker.teamsLoopCanBeParallelFor();
}
+static Expr *getInitialExprFromCapturedExpr(Expr *Cond) {
+
+ Expr *SubExpr = Cond->IgnoreParenImpCasts();
+
+ if (auto *DeclRef = dy
Author: Vitaly Buka
Date: 2024-12-24T13:57:03-08:00
New Revision: cd66c9b6a04689659348c0a3ff4c1205b1133fe9
URL:
https://github.com/llvm/llvm-project/commit/cd66c9b6a04689659348c0a3ff4c1205b1133fe9
DIFF:
https://github.com/llvm/llvm-project/commit/cd66c9b6a04689659348c0a3ff4c1205b1133fe9.diff
L
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/121006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -254,6 +254,7 @@ FEATURE(is_trivially_constructible, LangOpts.CPlusPlus)
FEATURE(is_trivially_copyable, LangOpts.CPlusPlus)
FEATURE(is_union, LangOpts.CPlusPlus)
FEATURE(kcfi, LangOpts.Sanitize.has(SanitizerKind::KCFI))
+FEATURE(kcfi_x86_arity, LangOpts.Sanitize.has(Sanitize
Author: Congcong Cai
Date: 2024-12-25T11:07:05+08:00
New Revision: 34f70007348d2d1a0e59fc0996e90a0b6fba1933
URL:
https://github.com/llvm/llvm-project/commit/34f70007348d2d1a0e59fc0996e90a0b6fba1933
DIFF:
https://github.com/llvm/llvm-project/commit/34f70007348d2d1a0e59fc0996e90a0b6fba1933.diff
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/121072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay commented:
We need a test to clang/test/Driver/ohos.c similar to linux-ld.c
`clang_rt.crtbegin.o`.
You can add UNSUPPORTED: system-windows to ohos.c so that we don't need
backslashes.
https://github.com/llvm/llvm-project/pull/118192
___
https://github.com/MaskRay requested changes to this pull request.
We need a test to clang/test/Driver/ohos.c similar to linux-ld.c
clang_rt.crtbegin.o.
You can add UNSUPPORTED: system-windows to ohos.c so that we don't need
backslashes.
https://github.com/llvm/llvm-project/pull/120159
__
@@ -780,6 +781,41 @@ Driver::OpenMPRuntimeKind Driver::getOpenMPRuntime(const
ArgList &Args) const {
return RT;
}
+static const char *getDefaultSYCLArch(Compilation &C) {
+ // If -fsycl is supplied we will assume SPIR-V
+ if (C.getDefaultToolChain().getTriple().isArch32Bi
https://github.com/HighCommander4 approved this pull request.
Thanks, LGTM!
I will wait a few days before merging in case anyone else has feedback.
https://github.com/llvm/llvm-project/pull/120996
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
@@ -181,8 +181,26 @@ void X86AsmPrinter::emitKCFITypeId(const MachineFunction
&MF) {
// Embed the type hash in the X86::MOV32ri instruction to avoid special
// casing object file parsers.
EmitKCFITypePadding(MF);
+
+ Register MovReg = X86::EAX;
+ const auto &Triple = M
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-solaris11-sparcv9`
running on `solaris11-sparcv9` while building `clang,compiler-rt` at step 5
"ninja check 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/13/builds/4296
Here is the releva
phoebewang wrote:
And you cannot use ESI when it's used to pass arguments. Suggested registers:
| Arity Indicator | Description | Encoding in reg field |
| --- | --- | --- |
| 0 | 0 parameters | EDI |
| 1 | 1 parameter in RDI | ESI |
| 2 | 2 parameters in RDI a
@@ -181,8 +181,26 @@ void X86AsmPrinter::emitKCFITypeId(const MachineFunction
&MF) {
// Embed the type hash in the X86::MOV32ri instruction to avoid special
// casing object file parsers.
EmitKCFITypePadding(MF);
+
+ Register MovReg = X86::EAX;
+ const auto &Triple = M
mdtoguchi wrote:
Ping
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 162 of 162 matches
Mail list logo
