https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/120287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu commented:
On the whole, this looks reasonable.
https://github.com/llvm/llvm-project/pull/120287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3596,6 +3596,9 @@ def fopenmp : Flag<["-"], "fopenmp">, Group,
Flags<[NoArgumentUnused]>,
Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>,
HelpText<"Parse OpenMP pragmas and generate parallel code.">;
+def fopenmp_default_none : Flag<["-"], "fopenmp-defau
https://github.com/gbMattN updated
https://github.com/llvm/llvm-project/pull/119387
>From 8781ff2355750ae61d140620b1f6862537de07e3 Mon Sep 17 00:00:00 2001
From: gbMattN
Date: Tue, 10 Dec 2024 15:01:37 +
Subject: [PATCH 1/3] [ASan] Add metadata to renamed instructions so ASan
doesn't use t
@@ -1229,8 +1248,15 @@ FunctionPass *llvm::createSPIRVStructurizerPass() {
PreservedAnalyses SPIRVStructurizerWrapper::run(Function &F,
FunctionAnalysisManager &AF) {
- FunctionPass *StructurizerPass = createSPIRVStructurizerPas
@@ -0,0 +1,43 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -ast-dump %s |
FileCheck %s
+
+// CHECK: FunctionDecl 0x{{[0-9A-Fa-f]+}} <{{.*}}> {{.*}} used branch 'int
(int)'
+// CHECK: AttributedStmt 0x{{[0-9A-Fa-f]+}} <
+// CHECK-NEXT: -HLSLControlFlowHintAttr 0x
@@ -0,0 +1,48 @@
+// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple
dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -o - |
FileCheck %s
+// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple
spirv-vulkan-library %s -fnative-half-type -emit-llvm -
https://github.com/llvm-beanz requested changes to this pull request.
Mostly minor nits, but the stuff in `SPIRVStructurizerWrapper::run` has to
change before we land this.
https://github.com/llvm/llvm-project/pull/116331
___
cfe-commits mailing list
@@ -2776,19 +2788,23 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register
ResVReg,
}
return MIB.constrainAllUses(TII, TRI, RBI);
}
- case Intrinsic::spv_loop_merge:
- case Intrinsic::spv_selection_merge: {
-const auto Opcode = IID == Intrinsic::spv_select
https://github.com/llvm-beanz edited
https://github.com/llvm/llvm-project/pull/116331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -295,6 +296,39 @@ static MDTuple *emitTopLevelLibraryNode(Module &M, MDNode
*RMD,
return constructEntryMetadata(nullptr, nullptr, RMD, Properties, Ctx);
}
+// TODO: We might need to refactor this to be more generic,
+// in case we need more metadata to be replaced.
+stat
@@ -2081,7 +2081,26 @@ void CodeGenFunction::EmitBranchOnBoolExpr(
Weights = createProfileWeights(TrueCount, CurrentCount - TrueCount);
}
- Builder.CreateCondBr(CondV, TrueBlock, FalseBlock, Weights, Unpredictable);
+ auto *BrInst = Builder.CreateCondBr(CondV, TrueBloc
@@ -5965,6 +5967,269 @@ static bool teamsLoopCanBeParallelFor(Stmt *AStmt, Sema
&SemaRef) {
return Checker.teamsLoopCanBeParallelFor();
}
+static Expr *getInitialExprFromCapturedExpr(Expr *Cond) {
+
+ Expr *SubExpr = Cond->IgnoreParenImpCasts();
+
+ if (auto *DeclRef = dy
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Nicholas Guy (NickGuy-Arm)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/120265.diff
6 Files Affected:
- (modified) clang/include/clang/Basic/arm_sme.td (+2)
- (modified) clang/test/CodeGen/AArch64/sme-int
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nicholas Guy (NickGuy-Arm)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/120265.diff
6 Files Affected:
- (modified) clang/include/clang/Basic/arm_sme.td (+2)
- (modified) clang/test/CodeGen/AArch64/sme-intrinsics/ac
https://github.com/NickGuy-Arm created
https://github.com/llvm/llvm-project/pull/120265
None
>From 898c30b5b97e80b8bdeb024aec30d0e530d39d42 Mon Sep 17 00:00:00 2001
From: Nick Guy
Date: Fri, 13 Dec 2024 13:39:24 +
Subject: [PATCH] [clang][llvm][aarch64] Add aarch64_sme_in_streaming_mode
i
@@ -11774,6 +11774,9 @@ def err_omp_clause_requires_dispatch_construct : Error<
"'%0' clause requires 'dispatch' context selector">;
def err_omp_append_args_with_varargs : Error<
"'append_args' is not allowed with varargs functions">;
+def warn_omp_dispatch_clause_novariant
@@ -9272,6 +9272,8 @@ def err_typecheck_expect_scalar_or_vector : Error<
"a vector of such type is required">;
def err_typecheck_expect_any_scalar_or_vector : Error<
"invalid operand of type %0 where a scalar or vector is required">;
+def err_typecheck_expect_scalar_or_vect
https://github.com/PiotrZSL requested changes to this pull request.
- reformat code
- missing release notes entry about new options added
- missing documentation for newly added options
- change should be in registerMatchers method
https://github.com/llvm/llvm-project/pull/120087
___
@@ -0,0 +1,86 @@
+// RUN: %check_clang_tidy %s readability-implicit-bool-conversion %t
+
+// RUN: %check_clang_tidy %s readability-implicit-bool-conversion %t \
+// RUN: -- -config='{CheckOptions: [{key:
readability-implicit-bool-conversion.CheckConversionsToBool, value: false},
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/120087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -357,20 +360,22 @@ void
ImplicitBoolConversionCheck::registerMatchers(MatchFinder *Finder) {
void ImplicitBoolConversionCheck::check(
const MatchFinder::MatchResult &Result) {
-
+ if(CheckConversionsToBool){
PiotrZSL wrote:
Wrong, place these things
https://github.com/madanial0 created
https://github.com/llvm/llvm-project/pull/120276
https://github.com/llvm/llvm-project/pull/119666 adds the `-strip-trailing-cr`
flag to diff which is not supported on AIX switch to use the python
implementation of diff instead
>From 1fb12758908b0cfeb8ff738
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Michael Klemm (mjklemm)
Changes
This PR adds the `-fopenmp-default-none` command line flag to the Flang
compiler. Similarly, to `-fimplicit-none` it provides error checking for OpenMP
directives by behavi
https://github.com/dwblaikie approved this pull request.
https://github.com/llvm/llvm-project/pull/119445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kazutakahirata wrote:
> AFAICT this is happening at each place that includes the file, e.g. also if
> you build AddressSanitizer. Not sure what the best way forward here is as
> this is not related to TypeSanitizer, but seems to impact all sanitizers?
I just posted https://github.com/llvm/llvm
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/120308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joaosaffran updated
https://github.com/llvm/llvm-project/pull/119041
>From 999f15be166d25521dfca4f95c1c909152f382e0 Mon Sep 17 00:00:00 2001
From: Joao Saffran
Date: Fri, 6 Dec 2024 01:27:24 +
Subject: [PATCH 1/6] Apply DXC fix and add tests
---
clang/test/CodeGenHLSL/d
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Paul Kirth (ilovepi)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/120318.diff
1 Files Affected:
- (added) clang-tools-extra/test/clang-doc/basic.cpp (+136)
``diff
diff --git a/clang-tools-extr
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/120318
None
>From 6042aeb6e0963abf5ff5a3d54fe9018949358515 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 17 Dec 2024 14:15:32 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/120145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -193,7 +193,8 @@ class Triple {
Mesa,
SUSE,
OpenEmbedded,
-LastVendorType = OpenEmbedded
+Intel,
sarnex wrote:
Will do in https://github.com/llvm/llvm-project/pull/120250, also my bad I
noticed I didn't even add a unit tests for this he
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on
`as-worker-93` while building `clang,llvm` at step 7
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/146/builds/1856
Here is the releva
@@ -150,3 +150,23 @@ clang::parseDarwinSDKInfo(llvm::vfs::FileSystem &VFS,
StringRef SDKRootPath) {
return llvm::make_error("invalid SDKSettings.json",
llvm::inconvertibleErrorCode());
}
+
+// For certain platforms/environments al
https://github.com/dklochkov-emb updated
https://github.com/llvm/llvm-project/pull/120258
>From 55996aa92a3bd5153e0991bc08c2d361951f7ab4 Mon Sep 17 00:00:00 2001
From: "Klochkov, Denis"
Date: Tue, 17 Dec 2024 16:49:55 +0100
Subject: [PATCH] [SYCL] do not support any SYCL standard except 2020
[
https://github.com/dklochkov-emb updated
https://github.com/llvm/llvm-project/pull/120258
>From 00b7797fb0e7095d398cb8a46f8ed3f9714989e2 Mon Sep 17 00:00:00 2001
From: "Klochkov, Denis"
Date: Tue, 17 Dec 2024 16:49:55 +0100
Subject: [PATCH] [SYCL] do not support any SYCL standard except 2020
[
https://github.com/dklochkov-emb created
https://github.com/llvm/llvm-project/pull/120258
SYCL no longer supports 2017/1.2.1 standard and it is recommended to move to
2020 standard as soon as possible. It was done:
1. -sycl-std has only one possible value: 2020.
2. Tests were fixed to check th
Author: Michael Buch
Date: 2024-12-17T16:40:10Z
New Revision: 9fc54c0e8049553a30c17a3698445d58800916c9
URL:
https://github.com/llvm/llvm-project/commit/9fc54c0e8049553a30c17a3698445d58800916c9
DIFF:
https://github.com/llvm/llvm-project/commit/9fc54c0e8049553a30c17a3698445d58800916c9.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/120154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: dklochkov-intel (dklochkov-emb)
Changes
SYCL no longer supports 2017/1.2.1 standard and it is recommended to move to
2020 standard as soon as possible. It was done:
1. -sycl-std has only one possible value: 2020.
2. Tests were fixed to ch
https://github.com/gbMattN updated
https://github.com/llvm/llvm-project/pull/119387
>From 8781ff2355750ae61d140620b1f6862537de07e3 Mon Sep 17 00:00:00 2001
From: gbMattN
Date: Tue, 10 Dec 2024 15:01:37 +
Subject: [PATCH 1/3] [ASan] Add metadata to renamed instructions so ASan
doesn't use t
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9fc54c0e8049553a30c17a3698445d58800916c9
898c30b5b97e80b8bdeb024aec30d0e530d39d42 --e
https://github.com/sarnex created
https://github.com/llvm/llvm-project/pull/120266
Currently we produce SPIR-V text with `spirv-dis` but assemble it with
`llvm-spirv`. The SPIR-V text format is different between the tools so the
assemble fails. We need to use the same tool for both, and since
@@ -1229,8 +1248,15 @@ FunctionPass *llvm::createSPIRVStructurizerPass() {
PreservedAnalyses SPIRVStructurizerWrapper::run(Function &F,
FunctionAnalysisManager &AF) {
- FunctionPass *StructurizerPass = createSPIRVStructurizerPas
@@ -17,12 +17,10 @@ double test_int_builtin(double p0) {
double2 test_int_builtin_2(double2 p0) {
return __builtin_hlsl_elementwise_firstbithigh(p0);
- // expected-error@-1 {{1st argument must be a vector of integers
- // (was 'double2' (aka 'vector'))}}
+ // expected-err
@@ -27292,6 +27294,13 @@ void AArch64TargetLowering::ReplaceNodeResults(
N->getOperand(1), N->getOperand(2));
Results.push_back(DAG.getNode(ISD::TRUNCATE, DL, VT, V));
return;
+}
+ case Intrinsic::aarch64_sme_in_streaming_mode: {
@@ -1636,12 +1636,8 @@ void SVEEmitter::createSMEHeader(raw_ostream &OS) {
OS << " return x0 & (1ULL << 63);\n";
OS << "}\n\n";
- OS << "__ai bool __arm_in_streaming_mode(void) __arm_streaming_compatible "
-"{\n";
- OS << " uint64_t x0, x1;\n";
- OS << " __bu
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 229d78de31467f623e33716a30cb0c6d285d7683
5e1b6df74e64111594161d96c6b3f67f0cd40ad8 --e
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/119989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nico wrote:
Aha! Yes, that bot does do incremental builds. (As do many devs.)
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,194 @@
+//===- unittests/Analysis/FlowSensitive/SmartPointerAccessorCachingTest.cpp
==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,134 @@
+#include "clang/Analysis/FlowSensitive/SmartPointerAccessorCaching.h"
+
+#include "clang/AST/CanonicalType.h"
+#include "clang/AST/DeclCXX.h"
+#include "clang/ASTMatchers/ASTMatchers.h"
+#include "clang/Basic/OperatorKinds.h"
+
+namespace clang::dataflow {
+
+na
https://github.com/phuang updated
https://github.com/llvm/llvm-project/pull/120159
>From db61f4b2fdc31d162a9a3b07e32dae8caa476152 Mon Sep 17 00:00:00 2001
From: Peng Huang
Date: Mon, 16 Dec 2024 10:07:02 -0500
Subject: [PATCH] Reapply "[Driver][OHOS] Fix lld link issue for OHOS
(#118192)"
Thi
phuang wrote:
> Without a test this should not land. [#118192
> (comment)](https://github.com/llvm/llvm-project/pull/118192#issuecomment-2539595603)
Hi @MaskRay could you please suggest how to test the changes? I though `ohos.c`
should already cover it.
https://github.com/llvm/llvm-project/pu
https://github.com/phuang edited
https://github.com/llvm/llvm-project/pull/120159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/118566
>From 75da343b0bd6e3b0f3219b349f6be4c882947820 Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Wed, 4 Dec 2024 02:24:12 +0200
Subject: [PATCH 1/4] [clang-format] extend clang-format directive with options
t
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/115487
>From 5e24d212f797b5fa1b6da1526c807046373d3c21 Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Fri, 8 Nov 2024 16:13:17 +0200
Subject: [PATCH 1/6] [Clang] skip default argument instantiation for
non-definin
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Vitaly Buka (vitalybuka)
Changes
1. -f[no-]sanitize-link-c++-runtime suppose to
override defauld behavior implied from `CCCIsCXX`
2. Take into account -nostdlib++
3. Fix typo hasFlag vs hasArg.
---
Ful
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/120370
1. -f[no-]sanitize-link-c++-runtime suppose to
override defauld behavior implied from `CCCIsCXX`
2. Take into account -nostdlib++
3. Fix typo hasFlag vs hasArg.
>From 6787146cf0e81ad8a69b3b2fadd7caf0f49c7
@@ -1754,6 +1755,17 @@ static bool interp__builtin_vector_reduce(InterpState
&S, CodePtr OpPC,
PrimType ElemT = *S.getContext().classify(ElemType);
unsigned NumElems = Arg.getNumElems();
+ if (ElemType->isRealFloatingType()) {
+if (ID != Builtin::BI__builtin_reduce_a
DavidTruby wrote:
Would it be a lot of work to add this flag for `clang` as well? It seems like
the behaviour would be equally useful there and I would prefer us to keep flags
available for both compilers where it makes sense.
In terms of implementation it looks like there's already a clang-ti
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast`
running on `gribozavr4` while building `llvm` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/56/builds/14775
Here is the rele
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `ml-opt-dev-x86-64` running
on `ml-opt-dev-x86-64-b1` while building `llvm` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/137/builds/10519
Here is the
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib`
running on `gribozavr4` while building `llvm` at step 7
"test-build-unified-tree-check-llvm".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/60/builds/15483
Here is the rel
https://github.com/DavidTruby commented:
Would it be a lot of work to add this flag for clang as well? It seems like the
behaviour would be equally useful there and I would prefer us to keep flags
available for both compilers where it makes sense.
In terms of implementation it looks like there'
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-debian-cpp20`
running on `clang-debian-cpp20` while building `llvm` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/108/builds/7269
Here is the re
fhahn wrote:
> I guess there are no release notes or manual b/c this is not ready to be used
> by general users on the command line and that will come via another PR?
I added a release note as part of the Clang patch to the `Sanitizers` section:
https://clang.llvm.org/docs/ReleaseNotes.html#sa
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/120370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while
building `llvm` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/16/builds/10896
401 - 469 of 469 matches
Mail list logo
