[clang] [clang] Fix sub-integer __builtin_elementwise_(add|sub)_sat (PR #119423)

2024-12-11 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Even with this fix, the behavior with mixed types still seems really confusing, especially if you mix signed/unsigned inputs. Can we address that somehow? https://github.com/llvm/llvm-project/pull/119423 ___ cfe-commits mailing l

[clang] [Clang][AArch64] Allow FP8 Neon vector types to be used by __builtin_shufflevector (PR #119031)

2024-12-11 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: My concern here is there's a tradeoff: there's less complexity constructing the type, maybe, but as a result you've scattered checks all over the code for a type that's basically the same as a VectorType. At first glance, this doesn't seem like the right tradeoff. https:

[clang-tools-extra] [analyzer] Split alpha core Identical Expression tests (PR #119543)

2024-12-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/119543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [analyzer] Split alpha core Identical Expression tests (PR #119543)

2024-12-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: Please change the `RUN` lines to use `check_clang_tidy` like so: `// RUN: %check_clang_tidy %s bugprone-branch-clone %t`, and drop the `BUGPRONEBRANCH` suffix in `bugprone-branch-clone.cpp`, as it is redundant after this change, and after removing the acci

[clang-tools-extra] [analyzer] Split alpha core Identical Expression tests (PR #119543)

2024-12-11 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,772 @@ +// RUN: clang-tidy %s -checks="-*,bugprone-branch-clone" -- 2>&1 | FileCheck %s --check-prefix=CHECK-MESSAGES-BUGPRONEBRANCH + +/* Only one expected warning per function allowed at the very end. */ + +int func(void) +{ + return 0; +} + +int func2(void) +{ + r

[clang] [clang] Fix crashes when passing VLA to va_arg (PR #119563)

2024-12-11 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Please add a testcase to clang/test/CodeGen/ . Put it in an existing file if there's already some related test. (See also https://llvm.org/docs/Contributing.html#how-to-submit-a-patch ) I don't think EmitAggregateCopy is the right place to call EmitVariablyModifiedType:

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-11 Thread Helmut Januschka via cfe-commits
@@ -0,0 +1,96 @@ +//===--- UseSpanFirstLastCheck.cpp - clang-tidy -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang-tools-extra] [llvm] [MTE] Apply alignment / size in AsmPrinter rather than IR (PR #111918)

2024-12-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson commented: I had to do something very similar for CHERI downstream: We have to ensure that all globals are precisely representable (which may require rounding up the size+alignment) so you don't end up creating bounds that include adjacent ones. The original patch

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-11 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/118074 >From cb748c34d35b8c0c9ca93a67b111dcf5d7665b34 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Fri, 29 Nov 2024 10:17:49 +0100 Subject: [PATCH 01/29] [clang-tidy] Add modernize-use-span-first-last check

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-12-11 Thread Shilei Tian via cfe-commits
shiltian wrote: @krzysz00 Do you suggest that the actual value doesn't matter? Like, 128 is not better or worse than 256. https://github.com/llvm/llvm-project/pull/79035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-11 Thread via cfe-commits
@@ -120,3 +120,30 @@ void test_ranges() { // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: prefer 'span::last()' over 'subspan()' // CHECK-FIXES: auto sub2 = s.last(n); } + +void test_different_spans() { + int arr1[] = {1, 2, 3, 4, 5}; + int arr2[] = {6, 7, 8, 9, 10}; + std

[clang] [clang-tools-extra] [clangd] Update clangDaemonTweaks to set symbol visibility macros (PR #112304)

2024-12-11 Thread Chris B via cfe-commits
@@ -114,7 +114,7 @@ macro(add_clang_library name) if(TARGET "obj.${name}") target_compile_definitions("obj.${name}" PUBLIC CLANG_BUILD_STATIC) endif() - elseif(NOT ARG_SHARED AND NOT ARG_STATIC) + elseif(NOT ARG_SHARED AND NOT ARG_STATIC AND NOT ARG_CLANG_IMPORT

[clang] [clang-tools-extra] [clangd] Update clangDaemonTweaks to set symbol visibility macros (PR #112304)

2024-12-11 Thread Chris B via cfe-commits
llvm-beanz wrote: What is the case where an object library wouldn't need to act as `CLANG_IMPORT`? It seems to me like the object library needs to be built assuming that it is importing clang symbols unless it is one of the core clang components. https://github.com/llvm/llvm-project/pull/1123

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-11 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,62 @@ +//===--- Xtensa.cpp - Implement Xtensa target feature support -===// +// +// The LLVM Compiler Infrastructure +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.

[libunwind] b0b546d - [libc++abi] Provide an explicit error when trying to build for MSVC (#119370)

2024-12-11 Thread via cfe-commits
Author: Louis Dionne Date: 2024-12-11T12:49:06-05:00 New Revision: b0b546d44777eb1fa25995384876bd14a006a929 URL: https://github.com/llvm/llvm-project/commit/b0b546d44777eb1fa25995384876bd14a006a929 DIFF: https://github.com/llvm/llvm-project/commit/b0b546d44777eb1fa25995384876bd14a006a929.diff

[libcxxabi] [libunwind] [libc++abi] Provide an explicit error when trying to build for MSVC (PR #119370)

2024-12-11 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/119370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implements FP8 SVE intrinsics for dot-product (PR #118125)

2024-12-11 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/118125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [MTE] Apply alignment / size in AsmPrinter rather than IR (PR #111918)

2024-12-11 Thread via cfe-commits
@@ -808,6 +808,10 @@ void Verifier::visitGlobalValue(const GlobalValue &GV) { "visibility must be dso_local!", &GV); + if (GV.isTagged()) { pcc wrote: Is this really a verifier issue? If the frontend wants to tag a global in a section (e

[clang] [clang-tools-extra] [llvm] [MTE] Apply alignment / size in AsmPrinter rather than IR (PR #111918)

2024-12-11 Thread via cfe-commits
@@ -2406,12 +2406,55 @@ void AsmPrinter::emitRemarksSection(remarks::RemarkStreamer &RS) { OutStreamer->emitBinaryData(Buf); } +static void tagGlobalDefinition(Module &M, GlobalVariable *G) { + Constant *Initializer = G->getInitializer(); + uint64_t SizeInBytes = + M

[clang] [llvm] [AArch64] Implement FP8 SVE intrinsics for fused multiply-add (PR #118126)

2024-12-11 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. LGTM, just fix the test name in the fmla https://github.com/llvm/llvm-project/pull/118126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [llvm] [AArch64] Implement FP8 SVE intrinsics for fused multiply-add (PR #118126)

2024-12-11 Thread via cfe-commits
@@ -0,0 +1,114 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 +; RUN: llc -mattr=+sve2,+fp8,+fp8fma < %s | FileCheck %s +; RUN: llc -mattr=+sme,+fp8,+ssve-fp8fma --force-streaming < %s | FileCheck %s + +target triple = "aa

[clang] [llvm] [AArch64] Implement FP8 SVE intrinsics for fused multiply-add (PR #118126)

2024-12-11 Thread via cfe-commits
@@ -0,0 +1,114 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 +; RUN: llc -mattr=+sve2,+fp8,+fp8fma < %s | FileCheck %s +; RUN: llc -mattr=+sme,+fp8,+ssve-fp8fma --force-streaming < %s | FileCheck %s + +target triple = "aa

[clang] [llvm] [AArch64] Implement FP8 SVE intrinsics for fused multiply-add (PR #118126)

2024-12-11 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/118126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LoongArch] Add FreeBSD targets (PR #119191)

2024-12-11 Thread yu shan wei via cfe-commits
yushanwei wrote: > Also a `[Clang]` tag could be prepended to the PR title to make it clearer > what part gets changed. Not only clang, all of FreeBSD on LoongArch https://github.com/llvm/llvm-project/pull/119191 ___ cfe-commits mailing list cfe-comm

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2024-12-11 Thread Momchil Velikov via cfe-commits
@@ -243,6 +243,7 @@ AArch64ABIInfo::convertFixedToScalableVectorType(const VectorType *VT) const { case BuiltinType::SChar: case BuiltinType::UChar: +case BuiltinType::MFloat8: momchil-velikov wrote: Intrinsics are not relevant here. This is cove

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2024-12-11 Thread Momchil Velikov via cfe-commits
@@ -761,8 +762,10 @@ bool AArch64ABIInfo::passAsPureScalableType( getContext().getBuiltinVectorTypeInfo(cast(Ty)); assert(Info.NumVectors > 0 && Info.NumVectors <= 4 && "Expected 1, 2, 3 or 4 vectors!"); - auto VTy = llvm::ScalableVectorType::get(CGT.ConvertTy

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2024-12-11 Thread Momchil Velikov via cfe-commits
@@ -529,6 +531,9 @@ llvm::Type *CodeGenTypes::ConvertType(QualType T) { } case BuiltinType::SveCount: return llvm::TargetExtType::get(getLLVMContext(), "aarch64.svcount"); +case BuiltinType::MFloat8: momchil-velikov wrote: > What is the dif

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2024-12-11 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/118969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-12-11 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: The main case I had in mind when adding the annotation was `range()`-like information: that is, the ability to infer `nsw` and friends on workgroup IDs and dimensions https://github.com/llvm/llvm-project/pull/79035 ___ cfe-commits mai

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2024-12-11 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/118969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2024-12-11 Thread Momchil Velikov via cfe-commits
@@ -4374,15 +4379,18 @@ ASTContext::getBuiltinVectorTypeInfo(const BuiltinType *Ty) const { ElBits, NF) \ case BuiltinType::Id: \ return {BFloat16T

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2024-12-11 Thread Momchil Velikov via cfe-commits
@@ -4374,15 +4379,18 @@ ASTContext::getBuiltinVectorTypeInfo(const BuiltinType *Ty) const { ElBits, NF) \ case BuiltinType::Id: \ return {BFloat16T

[clang-tools-extra] [clang-tidy]detecting conversion directly by `make_unique` and `make_shared` in bugprone-optional-value-conversion (PR #119371)

2024-12-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/119371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [analyzer] Split alpha core Identical Expression tests (PR #119543)

2024-12-11 Thread via cfe-commits
https://github.com/vabridgers created https://github.com/llvm/llvm-project/pull/119543 Split the remnant test from PR #114715, "Remove alpha.core.IdenticalExpr Checker" into seperate tests for misc-redundant-expression and bugprone-branch-clone per review comment requests. >From c1352227c0760

[clang-tools-extra] [analyzer] Split alpha core Identical Expression tests (PR #119543)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (vabridgers) Changes Split the remnant test from PR #114715, "Remove alpha.core.IdenticalExpr Checker" into seperate tests for misc-redundant-expression and bugprone-branch-clone per review comment requests. --- Patch i

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-12-11 Thread Shilei Tian via cfe-commits
shiltian wrote: What is the best case (from the compiler optimization perspective) that we can expect from `amdgpu-max-num-workgroups`? For example, is a smaller value better? I’d imagine that with a smaller value, the compiler can assume each workgroup has access to more resources. If that’s

[clang] [llvm] [AArch64] Implements FP8 SVE intrinsics for dot-product (PR #118125)

2024-12-11 Thread via cfe-commits
@@ -2468,4 +2468,30 @@ let SVETargetGuard = "sve2,fp8", SMETargetGuard = "sme2,fp8" in { // 8-bit floating-point convert to BFloat16/Float16 (top) def SVF1CVTLT : SInst<"svcvtlt1_{d}[_mf8]_fpm", "d~>", "bh", MergeNone, "aarch64_sve_fp8_cvtlt1", [VerifyRuntimeMode, SetsFPMR

[clang] [llvm] [AArch64] Implements FP8 SVE intrinsics for dot-product (PR #118125)

2024-12-11 Thread via cfe-commits
@@ -10719,7 +10719,16 @@ Value *CodeGenFunction::EmitSVEDupX(Value *Scalar, llvm::Type *Ty) { cast(Ty)->getElementCount(), Scalar); } -Value *CodeGenFunction::EmitSVEDupX(Value* Scalar) { +Value *CodeGenFunction::EmitSVEDupX(Value *Scalar) { + if (auto *Ty = Scalar->ge

[clang] [llvm] [AArch64] Implements FP8 SVE intrinsics for dot-product (PR #118125)

2024-12-11 Thread via cfe-commits
https://github.com/CarolineConcatto commented: Momchil, I believe the patch is fine, but I think you have two patches into one. FCVT nad FDOTs. Maybe we should split. https://github.com/llvm/llvm-project/pull/118125 ___ cfe-commits mailing list cfe-co

[clang] [llvm] [AArch64] Implements FP8 SVE intrinsics for dot-product (PR #118125)

2024-12-11 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/118125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [flang][OpenMP] Add frontend support for ompx_bare clause (PR #111106)

2024-12-11 Thread Ivan R. Ivanov via cfe-commits
https://github.com/ivanradanov updated https://github.com/llvm/llvm-project/pull/06 >From e778fad3eafcd78924efd7aa233ac7ba9f4e6a49 Mon Sep 17 00:00:00 2001 From: Ivan Radanov Ivanov Date: Fri, 4 Oct 2024 16:20:36 +0900 Subject: [PATCH 01/14] [flang] Add frontend support for OpenMP extension

[clang] [lldb] [Serialization] Support loading template specializations lazily (PR #119333)

2024-12-11 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @ChuanqiXu9, can we insert a fix for windows? https://github.com/llvm/llvm-project/pull/119333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement FP8 SVE intrinsics for fused multiply-add (PR #118126)

2024-12-11 Thread via cfe-commits
https://github.com/SpencerAbson unassigned https://github.com/llvm/llvm-project/pull/118126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement FP8 SVE intrinsics for fused multiply-add (PR #118126)

2024-12-11 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/118126 >From 5bc5078af32cda3dbcf3ca8dd53b01996ad34ea1 Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Mon, 25 Nov 2024 17:21:55 + Subject: [PATCH 1/3] [AArch64] Implements FP8 SVE intrinsics for dot-pr

[clang] [llvm] [AArch64] Implements FP8 SVE intrinsics for dot-product (PR #118125)

2024-12-11 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/118125 >From 5bc5078af32cda3dbcf3ca8dd53b01996ad34ea1 Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Mon, 25 Nov 2024 17:21:55 + Subject: [PATCH 1/2] [AArch64] Implements FP8 SVE intrinsics for dot-pr

[clang] [llvm] [AArch64] Implements FP8 SVE intrinsics for dot-product (PR #118125)

2024-12-11 Thread Momchil Velikov via cfe-commits
@@ -2468,4 +2468,30 @@ let SVETargetGuard = "sve2,fp8", SMETargetGuard = "sme2,fp8" in { // 8-bit floating-point convert to BFloat16/Float16 (top) def SVF1CVTLT : SInst<"svcvtlt1_{d}[_mf8]_fpm", "d~>", "bh", MergeNone, "aarch64_sve_fp8_cvtlt1", [VerifyRuntimeMode, SetsFPMR

[clang] [llvm] [AArch64] Implements FP8 SVE intrinsics for dot-product (PR #118125)

2024-12-11 Thread Momchil Velikov via cfe-commits
@@ -10719,7 +10719,16 @@ Value *CodeGenFunction::EmitSVEDupX(Value *Scalar, llvm::Type *Ty) { cast(Ty)->getElementCount(), Scalar); } -Value *CodeGenFunction::EmitSVEDupX(Value* Scalar) { +Value *CodeGenFunction::EmitSVEDupX(Value *Scalar) { + if (auto *Ty = Scalar->ge

[clang] [llvm] [AArch64] Implements FP8 SVE intrinsics for dot-product (PR #118125)

2024-12-11 Thread Momchil Velikov via cfe-commits
@@ -10719,7 +10719,16 @@ Value *CodeGenFunction::EmitSVEDupX(Value *Scalar, llvm::Type *Ty) { cast(Ty)->getElementCount(), Scalar); } -Value *CodeGenFunction::EmitSVEDupX(Value* Scalar) { +Value *CodeGenFunction::EmitSVEDupX(Value *Scalar) { + if (auto *Ty = Scalar->ge

[clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-11 Thread Reid Kleckner via cfe-commits
@@ -53,10 +53,8 @@ class OptTable { public: /// Entry for a single option instance in the option data table. struct Info { -/// A null terminated array of prefix strings to apply to name while -/// matching. -ArrayRef Prefixes; -StringLiteral PrefixedName; +

[clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-11 Thread Reid Kleckner via cfe-commits
@@ -845,13 +845,14 @@ MemoryBufferRef LinkerDriver::convertResToCOFF(ArrayRef mbs, // Create OptTable +#define OPTTABLE_STR_TABLE_CODE rnk wrote: I convinced myself this is not worth it. The changes to the `PrecomputedOptTable` are hard to abstract away. I

[clang] [clang-tools-extra] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-11 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks! I think this is ready to land. https://github.com/llvm/llvm-project/pull/119198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [flang] [flang][Driver] Don't require -fno-integrated-as when using -save-temps (PR #119624)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tarun Prabhu (tarunprabhu) Changes Currently, --save-temps requires -fno-integrated-as since flang does not have `fc1as` i.e. a driver for an integrated assembler. This simply checks if the driver is in flang-mode and forces useIntegrated

[clang] [flang] [flang][Driver] Don't require -fno-integrated-as when using -save-temps (PR #119624)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Tarun Prabhu (tarunprabhu) Changes Currently, --save-temps requires -fno-integrated-as since flang does not have `fc1as` i.e. a driver for an integrated assembler. This simply checks if the driver is in flang-mode and forces useInt

[clang] [flang] [flang][Driver] Don't require -fno-integrated-as when using -save-temps (PR #119624)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Author: Tarun Prabhu (tarunprabhu) Changes Currently, --save-temps requires -fno-integrated-as since flang does not have `fc1as` i.e. a driver for an integrated assembler. This simply checks if the driver is in flang-mode and forces useInt

[clang] [flang] [flang][Driver] Don't require -fno-integrated-as when using -save-temps (PR #119624)

2024-12-11 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. About time :) Thank you, LGTM! https://github.com/llvm/llvm-project/pull/119624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] 6f013db - [AArch64][FMV] Add missing feature dependencies and detect at runtime. (#119231)

2024-12-11 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-12-11T22:11:32Z New Revision: 6f013dbced67948119fe9ca71336f0284975ba4f URL: https://github.com/llvm/llvm-project/commit/6f013dbced67948119fe9ca71336f0284975ba4f DIFF: https://github.com/llvm/llvm-project/commit/6f013dbced67948119fe9ca71336f0284975ba4f.di

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/118074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][Modules] Fixing Build Breaks When -DLLVM_ENABLE_MODULES=ON (PR #119473)

2024-12-11 Thread Qiongsi Wu via cfe-commits
@@ -14,8 +14,6 @@ #ifndef CLANG_SUPPORT_COMPILER_H #define CLANG_SUPPORT_COMPILER_H -#include "llvm/Support/Compiler.h" qiongsiwu wrote: Thanks! Fixed! https://github.com/llvm/llvm-project/pull/119473 ___ cfe-commi

[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

2024-12-11 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/119231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-12-11 Thread Matt Arsenault via cfe-commits
arsenm wrote: > If that’s the case, is 1 the best-case scenario? Yes > @krzysz00 Do you suggest that the actual value doesn't matter? Like, 128 is > not better or worse than 256. This enables known bits optimizations. Less is always better, but the benefits can be marginal. https://githu

[clang] ee090cb - [OpenACC] Treat 'delete' as a valid clause during parsing in C++ mode

2024-12-11 Thread via cfe-commits
Author: erichkeane Date: 2024-12-11T14:19:20-08:00 New Revision: ee090cb83b523e4c8c888ded8ca1a70334ba65fa URL: https://github.com/llvm/llvm-project/commit/ee090cb83b523e4c8c888ded8ca1a70334ba65fa DIFF: https://github.com/llvm/llvm-project/commit/ee090cb83b523e4c8c888ded8ca1a70334ba65fa.diff LO

[clang] [flang] [flang][Driver] Don't require -fno-integrated-as when using -save-temps (PR #119624)

2024-12-11 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu created https://github.com/llvm/llvm-project/pull/119624 Currently, --save-temps requires -fno-integrated-as since flang does not have `fc1as` i.e. a driver for an integrated assembler. This simply checks if the driver is in flang-mode and forces useIntegratedAs(

[clang-tools-extra] ba373a2 - [clang-tidy]detecting conversion directly by `make_unique` and `make_shared` in bugprone-optional-value-conversion (#119371)

2024-12-11 Thread via cfe-commits
Author: Congcong Cai Date: 2024-12-12T06:55:29+08:00 New Revision: ba373a222fe6f65c45a05e9e1114c92580953b79 URL: https://github.com/llvm/llvm-project/commit/ba373a222fe6f65c45a05e9e1114c92580953b79 DIFF: https://github.com/llvm/llvm-project/commit/ba373a222fe6f65c45a05e9e1114c92580953b79.diff

[clang-tools-extra] [clang-tidy]detecting conversion directly by `make_unique` and `make_shared` in bugprone-optional-value-conversion (PR #119371)

2024-12-11 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/119371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][Modules] Fixing Build Breaks When -DLLVM_ENABLE_MODULES=ON (PR #119473)

2024-12-11 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu updated https://github.com/llvm/llvm-project/pull/119473 >From 06ae1ba1222f09e35ed428bcd6da91438b15e016 Mon Sep 17 00:00:00 2001 From: Qiongsi Wu Date: Tue, 10 Dec 2024 15:42:46 -0800 Subject: [PATCH 1/3] Fixing issues causing build break when -DLLVM_ENABLE_MODULES

[clang] [llvm] [clang][Modules] Fixing Build Breaks When -DLLVM_ENABLE_MODULES=ON (PR #119473)

2024-12-11 Thread Qiongsi Wu via cfe-commits
@@ -2,6 +2,7 @@ set(LLVM_LINK_COMPONENTS OrcShared OrcTargetProcess Support + Core qiongsiwu wrote: Code is revised to avoid adding the Core dependency. https://github.com/llvm/llvm-project/pull/119473 ___ c

[clang] [clang] Fix crashes when passing VLA to va_arg (PR #119563)

2024-12-11 Thread Robear Selwans via cfe-commits
mo7sen wrote: > While you're here, maybe look at emitting an undefined-behavior warning for > this construct? A VLA is never compatible with a function argument: if you > try to write an array in an function type, it gets promoted to a pointer. So > this construct is guaranteed to produce brok

[clang] [llvm] [clang][Modules] Fixing Build Breaks When -DLLVM_ENABLE_MODULES=ON (PR #119473)

2024-12-11 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu ready_for_review https://github.com/llvm/llvm-project/pull/119473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Merging RISCVToolChain and BareMetal toolchains (PR #118809)

2024-12-11 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt updated https://github.com/llvm/llvm-project/pull/118809 >From 569feb86c654be044781aa5968907a72ea882e88 Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Wed, 13 Nov 2024 02:45:51 -0800 Subject: [PATCH] [WIP] Merging RISCVToolChain and BareMetal toolchains Curr

[clang-tools-extra] [clang-tidy]detecting conversion directly by `make_unique` and `make_shared` in bugprone-optional-value-conversion (PR #119371)

2024-12-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang-tools-extra` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/11188

[clang] [llvm] [MTE] Apply alignment / size in AsmPrinter rather than IR (PR #111918)

2024-12-11 Thread Florian Mayer via cfe-commits
fmayer wrote: @pcc does this look better now? https://github.com/llvm/llvm-project/pull/111918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] fix parse windows driver and provides support for WSL paths. (PR #119350)

2024-12-11 Thread via cfe-commits
https://github.com/95833 closed https://github.com/llvm/llvm-project/pull/119350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement intrinsics for FP8 FCVT/FCVTN/BFCVT (PR #118025)

2024-12-11 Thread via cfe-commits
https://github.com/SpencerAbson closed https://github.com/llvm/llvm-project/pull/118025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b0763a4 - [AArch64] Implement intrinsics for FP8 FCVT/FCVTN/BFCVT (#118025)

2024-12-11 Thread via cfe-commits
Author: SpencerAbson Date: 2024-12-11T09:17:43Z New Revision: b0763a472be6098e8c8bdb32c06c593750e0566e URL: https://github.com/llvm/llvm-project/commit/b0763a472be6098e8c8bdb32c06c593750e0566e DIFF: https://github.com/llvm/llvm-project/commit/b0763a472be6098e8c8bdb32c06c593750e0566e.diff LOG:

[clang] [LoongArch] Add FreeBSD targets (PR #119191)

2024-12-11 Thread WÁNG Xuěruì via cfe-commits
https://github.com/xen0n approved this pull request. https://github.com/llvm/llvm-project/pull/119191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LoongArch] Add FreeBSD targets (PR #119191)

2024-12-11 Thread WÁNG Xuěruì via cfe-commits
@@ -223,6 +231,12 @@ void freebsd::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("--no-relax"); } + if (Triple.isLoongArch64()) { +CmdArgs.push_back("-X"); +if (Args.hasArg(options::OPT_mno_relax)) + CmdArgs.push_back("--no-

[clang] [clang][bytecode] Check for overlapping memcpy regions (PR #119535)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/119535.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuiltin.cpp (+14) - (modified) clang/test/AST/ByteCode/builtin-functions.c

[clang] [clang][bytecode] Check for overlapping memcpy regions (PR #119535)

2024-12-11 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/119535 None >From 03a5f354277a36d8380477bbd13a35484d701d3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 11 Dec 2024 11:08:40 +0100 Subject: [PATCH] [clang][bytecode] Check for overlapping m

[clang] [clang-tools-extra] [clang] Avoid re-evaluating field bitwidth (PR #117732)

2024-12-11 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/117732 >From f5d99b37218168f51e460b758f503debf683b086 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 27 Nov 2024 08:

[clang] [clang-tools-extra] [clang] Avoid re-evaluating field bitwidth (PR #117732)

2024-12-11 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/117732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang-tools-extra] [clang] Avoid re-evaluating field bitwidth (PR #117732)

2024-12-11 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/117732 >From 980c977c9255e6e6ba10bc5eac250a4072ca8aee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 27 Nov 2024 08:54:51 +0100 Subject: [PATCH] Save FieldDecl BitWidth as a ConstantExpr ---

[clang] [flang] [llvm] [mlir] [MLIR][OpenMP] Lowering aligned clause to LLVM IR for SIMD directive (PR #119536)

2024-12-11 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [flang] [llvm] [mlir] [MLIR][OpenMP] Lowering aligned clause to LLVM IR for SIMD directive (PR #119536)

2024-12-11 Thread Kaviya Rajendiran via cfe-commits
https://github.com/kaviya2510 created https://github.com/llvm/llvm-project/pull/119536 Added lowering support for aligned clause. >From ed29417f5fc9376c8a7e50a0525ef203967e5be0 Mon Sep 17 00:00:00 2001 From: Kaviya Rajendiran Date: Wed, 11 Dec 2024 15:02:59 +0530 Subject: [PATCH] [MLIR][OpenMP

[clang] [flang] [llvm] [mlir] [MLIR][OpenMP] Lowering aligned clause to LLVM IR for SIMD directive (PR #119536)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kaviya Rajendiran (kaviya2510) Changes Added lowering support for aligned clause to LLVM IR --- Full diff: https://github.com/llvm/llvm-project/pull/119536.diff 7 Files Affected: - (modified) clang/test/OpenMP/irbuilder_simd_aligned.cpp

[clang] [flang] [llvm] [mlir] [MLIR][OpenMP] Lowering aligned clause to LLVM IR for SIMD directive (PR #119536)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-openmp @llvm/pr-subscribers-flang-fir-hlfir Author: Kaviya Rajendiran (kaviya2510) Changes Added lowering support for aligned clause to LLVM IR --- Full diff: https://github.com/llvm/llvm-project/pull/119536.diff 7 Files Affected: - (modified) c

[clang] [flang] [llvm] [mlir] [MLIR][OpenMP] Lowering aligned clause to LLVM IR for SIMD directive (PR #119536)

2024-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-llvm Author: Kaviya Rajendiran (kaviya2510) Changes Added lowering support for aligned clause to LLVM IR --- Full diff: https://github.com/llvm/llvm-project/pull/119536.diff 7 Files Affected: - (modified) clang/test/OpenMP/irbuilder_simd_aligned

[clang] [flang] [llvm] [mlir] [MLIR][OpenMP] Lowering aligned clause to LLVM IR for SIMD directive (PR #119536)

2024-12-11 Thread Kaviya Rajendiran via cfe-commits
https://github.com/kaviya2510 edited https://github.com/llvm/llvm-project/pull/119536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9cdb7d2 - [NFC] Maintainers.rst: align email address formatting

2024-12-11 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2024-12-11T08:51:44Z New Revision: 9cdb7d2b6c333874ec969ef6ac64e0354bb3aa91 URL: https://github.com/llvm/llvm-project/commit/9cdb7d2b6c333874ec969ef6ac64e0354bb3aa91 DIFF: https://github.com/llvm/llvm-project/commit/9cdb7d2b6c333874ec969ef6ac64e0354bb3aa91.diff

[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

2024-12-11 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea edited https://github.com/llvm/llvm-project/pull/119231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 8d714db - [clangd] Consider expression statements in ExtractVariable tweak (#112525)

2024-12-11 Thread via cfe-commits
Author: Christian Kandeler Date: 2024-12-11T10:58:22+01:00 New Revision: 8d714db7f9617252401f85537d672c5b92c20557 URL: https://github.com/llvm/llvm-project/commit/8d714db7f9617252401f85537d672c5b92c20557 DIFF: https://github.com/llvm/llvm-project/commit/8d714db7f9617252401f85537d672c5b92c20557.

[clang-tools-extra] [clangd] Consider expression statements in ExtractVariable tweak (PR #112525)

2024-12-11 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler closed https://github.com/llvm/llvm-project/pull/112525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LoongArch] Add FreeBSD targets (PR #119191)

2024-12-11 Thread via cfe-commits
@@ -223,6 +231,12 @@ void freebsd::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("--no-relax"); } + if (Triple.isLoongArch64()) { +CmdArgs.push_back("-X"); +if (Args.hasArg(options::OPT_mno_relax)) + CmdArgs.push_back("--no-

[clang] [Multilib] Custom flags YAML parsing (PR #110657)

2024-12-11 Thread Victor Campos via cfe-commits
https://github.com/vhscampos edited https://github.com/llvm/llvm-project/pull/110657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][modules] Fix std::initializer_list recognition if it's exported out of a module (PR #118537)

2024-12-11 Thread via cfe-commits
https://github.com/jijjijj updated https://github.com/llvm/llvm-project/pull/118537 >From d0a3059a10b7ceeb7e9c27068266f8c41e794203 Mon Sep 17 00:00:00 2001 From: jijjijj Date: Tue, 3 Dec 2024 22:57:34 +0300 Subject: [PATCH 1/3] Fix std::initializer_list recognition if it's exported out of a mo

[clang] [Clang] Improve error for `-fsanitize=function/kcfi -mexecute-only` incompatibility (PR #118816)

2024-12-11 Thread Csanád Hajdú via cfe-commits
https://github.com/Il-Capitano updated https://github.com/llvm/llvm-project/pull/118816 From 94c933e0e7b7497e76c541f3ea7ed210349d2044 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Csan=C3=A1d=20Hajd=C3=BA?= Date: Thu, 5 Dec 2024 14:46:08 +0100 Subject: [PATCH 1/2] [Clang] Improve error for `-fsaniti

[clang] [lldb] [Serialization] Support loading template specializations lazily (PR #119333)

2024-12-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-arm64-windows-msvc` running on `linaro-armv8-windows-msvc-04` while building `clang,lldb` at step 4 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/3610 Here is the

[clang] 4dde52d - [clang][bytecode] Check for overlapping memcpy regions (#119535)

2024-12-11 Thread via cfe-commits
Author: Timm Baeder Date: 2024-12-11T12:06:56+01:00 New Revision: 4dde52d76b5342fd7e0b51094580818f3934ae2f URL: https://github.com/llvm/llvm-project/commit/4dde52d76b5342fd7e0b51094580818f3934ae2f DIFF: https://github.com/llvm/llvm-project/commit/4dde52d76b5342fd7e0b51094580818f3934ae2f.diff L

[clang] [clang][bytecode] Check for overlapping memcpy regions (PR #119535)

2024-12-11 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/119535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Enhance kCFI type IDs with a 3-bit arity indicator. (PR #117121)

2024-12-11 Thread Ramon de C Valle via cfe-commits
rcvalle wrote: I haven't received a reply for my concerns I commented at https://github.com/llvm/llvm-project/pull/117121#issuecomment-2502346476 and https://github.com/llvm/llvm-project/pull/117121#issuecomment-2516251353, and they still remain for the alternative proposal. I'd recommend wor

[clang] [RISCV] Merging RISCVToolChain and BareMetal toolchains (PR #118809)

2024-12-11 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt updated https://github.com/llvm/llvm-project/pull/118809 >From b58f9dd197c78b1e39676022a421ca0e6d5552a5 Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Wed, 13 Nov 2024 02:45:51 -0800 Subject: [PATCH] [WIP] Merging RISCVToolChain and BareMetal toolchains Curr

<    1   2   3   >