[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

2024-12-10 Thread Sander de Smalen via cfe-commits
@@ -61,13 +61,13 @@ unsigned AArch64::getFMVPriority(ArrayRef Features) { return Priority + MaxFMVPriority * NumFeatures; } -uint64_t AArch64::getCpuSupportsMask(ArrayRef FeatureStrs) { - uint64_t FeaturesMask = 0; - for (const StringRef &FeatureStr : FeatureStrs) { -

[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

2024-12-10 Thread Sander de Smalen via cfe-commits
@@ -349,6 +349,14 @@ void AArch64::ExtensionSet::reconstructFromParsedFeatures( } } +uint64_t AArch64::ExtensionSet::toCpuSupportsMask() const { + uint64_t FeaturesMask = 0; + for (const auto &I : getFMVInfo()) sdesmalen-arm wrote: nit: This shouldn't be

[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

2024-12-10 Thread Sander de Smalen via cfe-commits
@@ -61,13 +61,13 @@ unsigned AArch64::getFMVPriority(ArrayRef Features) { return Priority + MaxFMVPriority * NumFeatures; } -uint64_t AArch64::getCpuSupportsMask(ArrayRef FeatureStrs) { - uint64_t FeaturesMask = 0; - for (const StringRef &FeatureStr : FeatureStrs) { -

[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

2024-12-10 Thread Sander de Smalen via cfe-commits
@@ -349,6 +349,14 @@ void AArch64::ExtensionSet::reconstructFromParsedFeatures( } } +uint64_t AArch64::ExtensionSet::toCpuSupportsMask() const { sdesmalen-arm wrote: This function only has one use, perhaps just merge it into `getCpuSupportsMask`? https://g

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-10 Thread Zahira Ammarguellat via cfe-commits
@@ -501,6 +501,7 @@ class PreambleThread { } { +std::unique_lock Lock(Mutex); WithContext Guard(std::move(CurrentReq->Ctx)); zahiraam wrote: Thanks @tahonermann. I had forgotten about it. Closing it. https://github.com/llvm/llvm-

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-10 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/118664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Check vector element types for eligibility (PR #119385)

2024-12-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Like we do in ExprConstant.cpp. --- Full diff: https://github.com/llvm/llvm-project/pull/119385.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuiltinBitCast.cpp (+29) - (modified) clang

[clang] [llvm] [RISCV] Add stack clash protection (PR #117612)

2024-12-10 Thread Raphael Moreira Zinsly via cfe-commits
rzinsly wrote: > > > @rzinsly do you need someone to commit this? > > > > > > Yes, please. > > Please turn off [Keep my email addresses > private](https://github.com/settings/emails) setting in your account. > Otherwise the commit will be from the github hidden email which we don't use > in

[clang] [clang][CodeGen] `sret` args should always point to the `alloca` AS, so use that (PR #114062)

2024-12-10 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > I'm fine with how you're handling the address spaces for now. > > I'd like to talk about the rule you're implementing, though. It looks like > it's supposed to be: > > * return values always use the alloca AS > * arguments always use the default AS > * whether something is ind

[clang] Nominating Sven van Haastregt as OpenCL maintainer in Clang (PR #119383)

2024-12-10 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. Sorry to see you stepping down, thank you for all your contributions over the years! Thanks for the nomination, I gladly accept. https://github.com/llvm/llvm-project/pull/119383 ___ cfe-commits ma

[clang] [llvm] [BasicAA] Do not decompose past casts with different index width (PR #119365)

2024-12-10 Thread Ulrich Weigand via cfe-commits
uweigand wrote: @redstar looks like this disables an optimization on z/OS with mixed pointer widths. Please have a look whether this is relevant. https://github.com/llvm/llvm-project/pull/119365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 8a494dd - Nominating Sven van Haastregt as OpenCL maintainer in Clang (#119383)

2024-12-10 Thread via cfe-commits
Author: Anastasia Stulova Date: 2024-12-10T14:51:33Z New Revision: 8a494ddcbc0028937a92ad32380ed55c6bf4d7d8 URL: https://github.com/llvm/llvm-project/commit/8a494ddcbc0028937a92ad32380ed55c6bf4d7d8 DIFF: https://github.com/llvm/llvm-project/commit/8a494ddcbc0028937a92ad32380ed55c6bf4d7d8.diff

[clang] Nominating Sven van Haastregt as OpenCL maintainer in Clang (PR #119383)

2024-12-10 Thread Anastasia Stulova via cfe-commits
https://github.com/AnastasiaStulova closed https://github.com/llvm/llvm-project/pull/119383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

2024-12-10 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea edited https://github.com/llvm/llvm-project/pull/119231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Move vector diagnostics to checkBitCastConstexprEl… (PR #119366)

2024-12-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/119366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-10 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann edited https://github.com/llvm/llvm-project/pull/117268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

2024-12-10 Thread Alexandros Lamprineas via cfe-commits
@@ -349,6 +349,14 @@ void AArch64::ExtensionSet::reconstructFromParsedFeatures( } } +uint64_t AArch64::ExtensionSet::toCpuSupportsMask() const { labrinea wrote: Hmm, I am thinking we may want to reuse this once we change [getFMVPriority](https://github.com

[clang-tools-extra] [clang-tidy]detecting conversion directly by `make_unique` and `make_shared` in bugprone-optional-value-conversion (PR #119371)

2024-12-10 Thread Piotr Zegar via cfe-commits
@@ -12,20 +12,44 @@ #include "../utils/OptionsUtils.h" #include "clang/AST/ASTContext.h" #include "clang/ASTMatchers/ASTMatchFinder.h" +#include using namespace clang::ast_matchers; +using clang::ast_matchers::internal::Matcher; namespace clang::tidy::bugprone { names

[libcxxabi] [libunwind] [libc++abi] Provide an explicit error when trying to build for MSVC (PR #119370)

2024-12-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/119370 >From 259f1eecac3abf0ffdc5c41ef9edae35c604ee26 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Dec 2024 07:42:00 -0500 Subject: [PATCH] [libc++abi][libunwind] Provide an explicit error when trying to

[clang] 708a478 - [RISCV] Add stack clash protection (#117612)

2024-12-10 Thread via cfe-commits
Author: Raphael Moreira Zinsly Date: 2024-12-10T16:48:26Z New Revision: 708a478d6739aea20a8834cea45490f05b07ca10 URL: https://github.com/llvm/llvm-project/commit/708a478d6739aea20a8834cea45490f05b07ca10 DIFF: https://github.com/llvm/llvm-project/commit/708a478d6739aea20a8834cea45490f05b07ca10.d

[clang] [llvm] [RISCV] Add stack clash protection (PR #117612)

2024-12-10 Thread Sam Elliott via cfe-commits
https://github.com/lenary closed https://github.com/llvm/llvm-project/pull/117612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]detecting conversion directly by `make_unique` and `make_shared` in bugprone-optional-value-conversion (PR #119371)

2024-12-10 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/119371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a dangling reference in clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (PR #119197)

2024-12-10 Thread Ilya Biryukov via cfe-commits
@@ -1908,7 +1908,7 @@ void clang::EmitClangDiagDocs(const RecordKeeper &Records, raw_ostream &OS) { for (const Record *G : DiagGroups) { bool IsRemarkGroup = isRemarkGroup(G, DiagsInGroup); auto &GroupInfo = -DiagsInGroup[std::string(G->getValueAsString("Grou

[clang-tools-extra] [clang-tidy]detecting conversion directly by `make_unique` and `make_shared` in bugprone-optional-value-conversion (PR #119371)

2024-12-10 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL commented: Note: Probably also std::make_optional could be supported. Please improve performance - avoid creating temporary matchers on every match. Except above, looks fine. https://github.com/llvm/llvm-project/pull/119371 ___

[clang-tools-extra] [clang-tidy]detecting conversion directly by `make_unique` and `make_shared` in bugprone-optional-value-conversion (PR #119371)

2024-12-10 Thread Piotr Zegar via cfe-commits
@@ -12,20 +12,44 @@ #include "../utils/OptionsUtils.h" #include "clang/AST/ASTContext.h" #include "clang/ASTMatchers/ASTMatchFinder.h" +#include using namespace clang::ast_matchers; +using clang::ast_matchers::internal::Matcher; namespace clang::tidy::bugprone { names

[clang] [llvm] SystemZ: Add support for __builtin_setjmp and __builtin_longjmp. (PR #119257)

2024-12-10 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand commented: Thanks for fixing those issues. Just a couple of further comments inline. https://github.com/llvm/llvm-project/pull/119257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [clang][transformer] Allow usage of applyFirst with rewriteDescendants (PR #117658)

2024-12-10 Thread Yitzhak Mandelbaum via cfe-commits
ymand wrote: > @ymand, could you please take a look? Yes -- sorry, missed the notification. I'll try to review within 24h. https://github.com/llvm/llvm-project/pull/117658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

2024-12-10 Thread Erich Keane via cfe-commits
erichkeane wrote: > There are a few ways around this: if you are using c++17 or later, there is > `[[maybe_unused]]`. Another option is to ignore this warning in a specific > region with: > > ```c++ > #pragma clang diagnostic push > #pragma clang diagnostic ignored "-Wunused-private-field" > /

[clang] [analyzer] Don't assume third iteration in loops (PR #119388)

2024-12-10 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat created https://github.com/llvm/llvm-project/pull/119388 This commit ensures that if the loop condition is opaque (the analyzer cannot determine whether it's true or false) and there were at least two iterations, then the analyzer doesn't make the unjustified assum

[clang] [analyzer] Don't assume third iteration in loops (PR #119388)

2024-12-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Donát Nagy (NagyDonat) Changes This commit ensures that if the loop condition is opaque (the analyzer cannot determine whether it's true or false) and there were at least two iterations, then the analyzer doesn't make th

[libcxxabi] [libunwind] [libc++abi] Provide an explicit error when trying to build for MSVC (PR #119370)

2024-12-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/119370 >From c9f83596fbfa0423245eecbc9c4d9f65163648f1 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Dec 2024 07:42:00 -0500 Subject: [PATCH] [libc++abi][libunwind] Provide an explicit error when trying to

[clang] [analyzer] Don't assume third iteration in loops (PR #119388)

2024-12-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Donát Nagy (NagyDonat) Changes This commit ensures that if the loop condition is opaque (the analyzer cannot determine whether it's true or false) and there were at least two iterations, then the analyzer doesn't make the unjustified assu

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-12-10 Thread Victor Lomuller via cfe-commits
@@ -91,6 +97,88 @@ SPIRVTargetMachine::SPIRVTargetMachine(const Target &T, const Triple &TT, setRequiresStructuredCFG(false); } +enum AddressSpace { + Function = storageClassToAddressSpace(SPIRV::StorageClass::Function), + CrossWorkgroup = + storageClassToAddressSpac

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-10 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/107627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-10 Thread Ilya Biryukov via cfe-commits
@@ -499,6 +499,7 @@ static bool isNormalAssignmentOperator(const FunctionDecl *FD) { } bool implicitObjectParamIsLifetimeBound(const FunctionDecl *FD) { + FD = FD->getMostRecentDecl(); ilya-biryukov wrote: It would be great to explain the need for `getMostR

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-10 Thread Ilya Biryukov via cfe-commits
@@ -3250,26 +3285,17 @@ static void mergeParamDeclAttributes(ParmVarDecl *newDecl, diag::note_carries_dependency_missing_first_decl) << 1/*Param*/; } - if (!oldDecl->hasAttrs()) -return; - - bool foundAny = newDecl->hasAttrs(); - - // Ensure that any movin

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-10 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov commented: I really like the current implementation, but have one major suggestion about using`InheritableParamAttr`. Also, could we add a release note for it? https://github.com/llvm/llvm-project/pull/107627 ___ cfe-

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-10 Thread Ilya Biryukov via cfe-commits
@@ -3227,6 +3227,41 @@ void Sema::mergeDeclAttributes(NamedDecl *New, Decl *Old, if (!foundAny) New->dropAttrs(); } +template +static unsigned propagateAttribute(ParmVarDecl *toDecl, ilya-biryukov wrote: NIT: maybe document that it returns a number of adde

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-10 Thread Ilya Biryukov via cfe-commits
@@ -238,18 +239,13 @@ void Sema::inferLifetimeBoundAttribute(FunctionDecl *FD) { default: break; } -return; ilya-biryukov wrote: NIT: LLVM codifies a preference to use `return` in the Style Guide, see examples in [this section](https://llvm

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-10 Thread Ilya Biryukov via cfe-commits
@@ -3227,6 +3227,41 @@ void Sema::mergeDeclAttributes(NamedDecl *New, Decl *Old, if (!foundAny) New->dropAttrs(); } +template +static unsigned propagateAttribute(ParmVarDecl *toDecl, ilya-biryukov wrote: NIT: rename to `ToDecl` to match LLVM naming rules.

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-10 Thread Ilya Biryukov via cfe-commits
@@ -3250,26 +3285,17 @@ static void mergeParamDeclAttributes(ParmVarDecl *newDecl, diag::note_carries_dependency_missing_first_decl) << 1/*Param*/; } - if (!oldDecl->hasAttrs()) -return; - - bool foundAny = newDecl->hasAttrs(); - - // Ensure that any movin

[clang] [clang] Document the return value of __builtin_COLUMN (PR #118360)

2024-12-10 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/118360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Check vector element types for eligibility (PR #119385)

2024-12-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/119385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-10 Thread Zhengxing li via cfe-commits
lizhengxing wrote: @sudonatalie Hello Natalie, Could you help review this PR when you're available since it will modify your changes (https://github.com/llvm/llvm-project/pull/82536), Thanks. https://github.com/llvm/llvm-project/pull/117781 ___ cfe-co

[clang] [Clang] Change placeholders from `undef` to `poison` (PR #119141)

2024-12-10 Thread Pedro Lobo via cfe-commits
pedroclobo wrote: cc @nunoplopes https://github.com/llvm/llvm-project/pull/119141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Add `-i128:128` to the `datalayout` string. (PR #119204)

2024-12-10 Thread Dan Gohman via cfe-commits
@@ -183,11 +183,12 @@ class LLVM_LIBRARY_VISIBILITY WebAssembly32TargetInfo const TargetOptions &Opts) : WebAssemblyTargetInfo(T, Opts) { if (T.isOSEmscripten()) - resetDataLayout("e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-f128:64-n3

[clang] [clang-tools-extra] [llvm] [clang] WIP: Improved Context Declaration tracking (PR #107942)

2024-12-10 Thread Matheus Izvekov via cfe-commits
@@ -8494,10 +8495,21 @@ DeclResult Sema::ActOnClassTemplateSpecialization( return Specialization; } -Decl *Sema::ActOnTemplateDeclarator(Scope *S, - MultiTemplateParamsArg TemplateParameterLists, -Declarator &D

[clang] Fix a cmake error when using the Xcode generator. (PR #119403)

2024-12-10 Thread Paul Bowen-Huggett via cfe-commits
https://github.com/paulhuggett edited https://github.com/llvm/llvm-project/pull/119403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Add `-i128:128` to the `datalayout` string. (PR #119204)

2024-12-10 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode updated https://github.com/llvm/llvm-project/pull/119204 >From dd2939affd576539d83dfa877ea30192b41353b0 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Mon, 9 Dec 2024 04:30:33 -0800 Subject: [PATCH 1/2] [WebAssembly] Add `-i128:128` to the `datalayout` string. C

[clang] [clang-tools-extra] [llvm] [clang] WIP: Improved Context Declaration tracking (PR #107942)

2024-12-10 Thread Matheus Izvekov via cfe-commits
@@ -7946,6 +7980,8 @@ class Sema final : public SemaBase { /// A stack of expression evaluation contexts. SmallVector ExprEvalContexts; + SmallVector PendingLazyContextDecls; mizvekov wrote: The intention is that they are used for any declarations where

[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

2024-12-10 Thread Alexandros Lamprineas via cfe-commits
@@ -61,13 +61,13 @@ unsigned AArch64::getFMVPriority(ArrayRef Features) { return Priority + MaxFMVPriority * NumFeatures; } -uint64_t AArch64::getCpuSupportsMask(ArrayRef FeatureStrs) { - uint64_t FeaturesMask = 0; - for (const StringRef &FeatureStr : FeatureStrs) { -

[clang] [clang-tools-extra] [llvm] [clang] WIP: Improved Context Declaration tracking (PR #107942)

2024-12-10 Thread Matheus Izvekov via cfe-commits
@@ -17658,8 +17662,49 @@ HandleImmediateInvocations(Sema &SemaRef, } } +static void setContextDecl(Sema &S, Decl *Base, Decl *ContextDecl) { + switch (Base->getKind()) { + case Decl::CXXRecord: { +auto *RD = cast(Base); +RD->setLambdaContextDecl(ContextDecl); +

[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

2024-12-10 Thread Alexandros Lamprineas via cfe-commits
@@ -61,13 +61,13 @@ unsigned AArch64::getFMVPriority(ArrayRef Features) { return Priority + MaxFMVPriority * NumFeatures; } -uint64_t AArch64::getCpuSupportsMask(ArrayRef FeatureStrs) { - uint64_t FeaturesMask = 0; - for (const StringRef &FeatureStr : FeatureStrs) { -

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-10 Thread via cfe-commits
https://github.com/iseki0 updated https://github.com/llvm/llvm-project/pull/119090 >From 06be29809a8ac03e4ec9546e1dcfc138ab79167b Mon Sep 17 00:00:00 2001 From: iseki zero Date: Sun, 8 Dec 2024 03:17:40 +0800 Subject: [PATCH 1/2] [docs] Add a more detailed description in CXString.h. --- clang

[clang] [clang] Document the return value of __builtin_COLUMN (PR #118360)

2024-12-10 Thread via cfe-commits
https://github.com/GeorgeKA updated https://github.com/llvm/llvm-project/pull/118360 >From 3856d6ccf8b10f85cee8d03a349eb768600bd0e0 Mon Sep 17 00:00:00 2001 From: GeorgeKA Date: Mon, 2 Dec 2024 13:34:22 -0500 Subject: [PATCH 1/2] [clang] Document the return value of __builtin_COLUMN PR for iss

[clang] [clang] Reject `_Complex _BitInt` (PR #119402)

2024-12-10 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/119402 The C standard doesn't require support for these types and Codegen for these types is incorrect ATM. See https://github.com/llvm/llvm-project/issues/119352 >From 9c168204ffa0c23d8138eb1780a0ec54cb29f1c6 Mon S

[clang] [analyzer] Suppress out of bounds reports after weak loop assumptions (PR #109804)

2024-12-10 Thread Donát Nagy via cfe-commits
NagyDonat wrote: I'm abandoning this PR because I decided to return to writing general commits which improve the overall logic of the engine instead of just suppressing results from one particular (heavily affected) checker. (Moreover, this PR would've needed significant rebasing and code qual

[clang] [analyzer] Suppress out of bounds reports after weak loop assumptions (PR #109804)

2024-12-10 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/109804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Add `-i128:128` to the `datalayout` string. (PR #119204)

2024-12-10 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode updated https://github.com/llvm/llvm-project/pull/119204 >From dd2939affd576539d83dfa877ea30192b41353b0 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Mon, 9 Dec 2024 04:30:33 -0800 Subject: [PATCH] [WebAssembly] Add `-i128:128` to the `datalayout` string. Clang

[clang] [clang] Reject `_Complex _BitInt` (PR #119402)

2024-12-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes The C standard doesn't require support for these types and Codegen for these types is incorrect ATM. See https://github.com/llvm/llvm-project/issues/119352 --- Full diff: https://github.com/llvm/l

[clang] [clang] Reject `_Complex _BitInt` (PR #119402)

2024-12-10 Thread Erich Keane via cfe-commits
erichkeane wrote: Ah, probably needs something in 'breaking changes' in the release notes. https://github.com/llvm/llvm-project/pull/119402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [llvm] [WebAssembly] Add `-i128:128` to the `datalayout` string. (PR #119204)

2024-12-10 Thread Dan Gohman via cfe-commits
sunfishcode wrote: Rebased on top of #119288; the test diffs are much smaller now :-). https://github.com/llvm/llvm-project/pull/119204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f28e522 - [Clang] Change two placeholders from `undef` to `poison` [NFC] (#119141)

2024-12-10 Thread via cfe-commits
Author: Pedro Lobo Date: 2024-12-10T15:57:55Z New Revision: f28e52274c83d5ccd03455ef98a3758916998be9 URL: https://github.com/llvm/llvm-project/commit/f28e52274c83d5ccd03455ef98a3758916998be9 DIFF: https://github.com/llvm/llvm-project/commit/f28e52274c83d5ccd03455ef98a3758916998be9.diff LOG: [C

[clang] [llvm] [WebAssembly] Add `-i128:128` to the `datalayout` string. (PR #119204)

2024-12-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e665e781dc3f8fac0400f6ac8e168805b0cdf74a dd2939affd576539d83dfa877ea30192b41353b0 --e

[clang] [clang] Reject `_Complex _BitInt` (PR #119402)

2024-12-10 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/119402 >From 9c168204ffa0c23d8138eb1780a0ec54cb29f1c6 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 10 Dec 2024 07:50:56 -0800 Subject: [PATCH 1/2] [clang] Reject `_Complex _BitInt` The C standa

[clang] [clang] Reject `_Complex _BitInt` (PR #119402)

2024-12-10 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/119402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] SystemZ: Add support for __builtin_setjmp and __builtin_longjmp. (PR #119257)

2024-12-10 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand edited https://github.com/llvm/llvm-project/pull/119257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] SystemZ: Add support for __builtin_setjmp and __builtin_longjmp. (PR #119257)

2024-12-10 Thread Ulrich Weigand via cfe-commits
@@ -374,10 +374,11 @@ overall functioning of this intrinsic is compatible with the GCC to interoperate. The single parameter is a pointer to a five word buffer in which the calling -context is saved. The front end places the frame pointer in the first word, and -the target im

[clang] [llvm] SystemZ: Add support for __builtin_setjmp and __builtin_longjmp. (PR #119257)

2024-12-10 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,51 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 +; Test longjmp load from jmp_buf. +; Frame pointer from Slot 1. +; Jump address from Slot 2. +; Backchain Value from Slot 3. +; Stack Pointer from Slot 4. +; Lit

[clang] Fix a cmake error when using the Xcode generator. (PR #119403)

2024-12-10 Thread Paul Bowen-Huggett via cfe-commits
https://github.com/paulhuggett created https://github.com/llvm/llvm-project/pull/119403 I’m seeing a series of errors when trying to run the cmake configure step on macOS when the cmake generator is set to Xcode. All is well if I use the Ninja or Unix Makefile generators. Messages are all of t

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-10 Thread Alexey Gerenkov via cfe-commits
@@ -0,0 +1,141 @@ +//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE

[clang] Fix a cmake error when using the Xcode generator. (PR #119403)

2024-12-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul Bowen-Huggett (paulhuggett) Changes I’m seeing a series of errors when trying to run the cmake configure step on macOS when the cmake generator is set to Xcode. All is well if I use the Ninja or Unix Makefile generators. Messages are

[clang] Fix a cmake error when using the Xcode generator. (PR #119403)

2024-12-10 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-10 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann approved this pull request. Thanks, @mdtoguchi, this looks good to me! https://github.com/llvm/llvm-project/pull/117268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-10 Thread Tom Honermann via cfe-commits
@@ -6591,6 +6681,18 @@ const ToolChain &Driver::getOffloadingDeviceToolChain( HostTC, Args); break; } +case Action::OFK_SYCL: + switch (Target.getArch()) { + case llvm::Triple::spir: + case

[clang] [clang-tools-extra] [llvm] [clang] WIP: Improved Context Declaration tracking (PR #107942)

2024-12-10 Thread Matheus Izvekov via cfe-commits
@@ -17658,8 +17662,49 @@ HandleImmediateInvocations(Sema &SemaRef, } } +static void setContextDecl(Sema &S, Decl *Base, Decl *ContextDecl) { + switch (Base->getKind()) { + case Decl::CXXRecord: { +auto *RD = cast(Base); +RD->setLambdaContextDecl(ContextDecl); +

[clang] [Clang] Don't check incomplete CXXRecordDecl's members when transforming sizeof...(expr) (PR #119344)

2024-12-10 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/119344 For a FunctionParmPackExpr that is used as the argument of a sizeof...(pack) expression, we might exercise the logic that checks the CXXRecordDecl's members regardless of the type being incomplete, when rebuild

[clang-tools-extra] e69d8b8 - [clang-tidy][NFC] simplify matchers in bugprone-optional-value-conversion (#119346)

2024-12-10 Thread via cfe-commits
Author: Congcong Cai Date: 2024-12-10T18:00:41+08:00 New Revision: e69d8b8708b93281e91eb3679cec317a33aab246 URL: https://github.com/llvm/llvm-project/commit/e69d8b8708b93281e91eb3679cec317a33aab246 DIFF: https://github.com/llvm/llvm-project/commit/e69d8b8708b93281e91eb3679cec317a33aab246.diff

[clang-tools-extra] [clang-tidy][NFC] simplify matchers in bugprone-optional-value-conversion (PR #119346)

2024-12-10 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/119346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't check incomplete CXXRecordDecl's members when transforming sizeof...(expr) (PR #119344)

2024-12-10 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/119344 >From bca3cea00ce3e3980a45433d831cae86dec4b7e6 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 10 Dec 2024 16:56:15 +0800 Subject: [PATCH 1/2] [Clang] Don't check incomplete CXXRecordDecl's members when

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #119001)

2024-12-10 Thread Jeremy Morse via cfe-commits
jmorse wrote: > Maybe it's too big/complex a problem to try to think about, and incremental > development should overrule here - but may be worth thinking about? Urgh. I'll admit that I hadn't thought that far ahead, I just wanted to get the patch-series going again now that the root problem i

[clang] [clang][ExprConst] Move vector diagnostics to checkBitCastConstexprEl… (PR #119366)

2024-12-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/119366 >From 08d3ee1ec762ab9ca63125532556f5db8bbde8e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 10 Dec 2024 13:08:39 +0100 Subject: [PATCH] [clang][ExprConst] Move vector diagnostics to

[clang-tools-extra] [clangd] Consider expression statements in ExtractVariable tweak (PR #112525)

2024-12-10 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/112525 >From 83104569563db9a6716aae941edf9fe15493081a Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Tue, 23 May 2023 13:16:38 +0200 Subject: [PATCH] [clangd] Consider expression statements in ExtractVariabl

[clang-tools-extra] [clangd] Consider expression statements in ExtractVariable tweak (PR #112525)

2024-12-10 Thread Christian Kandeler via cfe-commits
ckandeler wrote: Rebased. https://github.com/llvm/llvm-project/pull/112525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Multilib] Custom flags YAML parsing (PR #110657)

2024-12-10 Thread Victor Campos via cfe-commits
https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110657 >From 4c9756a323f67dbe5fbdb45cf2ddb5f97adad18d Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:43:18 +0100 Subject: [PATCH 1/2] [Multilib] Custom flags YAML parsing This patch adds supp

[clang] [clang] Fix sub-integer __builtin_elementwise_(add|sub)_sat (PR #119423)

2024-12-10 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/119423 These builtins would unconditionally perform the usual arithmetic conversions on promotable scalar integer arguments. This meant in practice that char and short arguments were promoted to int, and the opera

[clang] [clang] Fix sub-integer __builtin_elementwise_(add|sub)_sat (PR #119423)

2024-12-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fraser Cormack (frasercrmck) Changes These builtins would unconditionally perform the usual arithmetic conversions on promotable scalar integer arguments. This meant in practice that char and short arguments were promoted to int, and the

[clang] [llvm] [HLSL] Do not print details in IR for target extension types (PR #115971)

2024-12-10 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 closed https://github.com/llvm/llvm-project/pull/115971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Darwin][Driver][clang] Prioritise command line args over `DEFAULT_SYSROOT` (PR #115993)

2024-12-10 Thread Fangrui Song via cfe-commits
MaskRay wrote: The PR description (first comment), which will be used as the default commit message, should be fixed. https://github.com/llvm/llvm-project/pull/115993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [FMV][AArch64][clang] Emit fmv-features metadata in LLVM IR. (PR #118544)

2024-12-10 Thread Andrew Carlotti via cfe-commits
andrewcarlotti wrote: > > Suppose you have target_version("i8mm+dotprod") and target_version("fcma"). > > The first version clearly has higher priority > > According to the [current > rules](https://arm-software.github.io/acle/main/acle.html#selection) yes, but > IMO that rule is broken and

[clang] [Darwin][Driver][clang] Prioritise command line args over `DEFAULT_SYSROOT` (PR #115993)

2024-12-10 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab edited https://github.com/llvm/llvm-project/pull/115993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Darwin][Driver][clang] Prioritise command line args over `DEFAULT_SYSROOT` (PR #115993)

2024-12-10 Thread Carlo Cabrera via cfe-commits
carlocab wrote: > The PR description (first comment), which will be used as the default commit > message, should be fixed. Thanks for the reminder, fixed. I plan to do a few more local tests with `DEFAULT_SYSROOT` enabled before merging (since this isn't tested in CI). https://github.com/llv

[clang] [FMV][AArch64][clang] Emit fmv-features metadata in LLVM IR. (PR #118544)

2024-12-10 Thread Jon Roelofs via cfe-commits
jroelofs wrote: > > > Suppose you have target_version("i8mm+dotprod") and > > > target_version("fcma"). The first version clearly has higher priority > > > > > > According to the [current > > rules](https://arm-software.github.io/acle/main/acle.html#selection) yes, > > but IMO that rule is

[clang] [clang] Fix a dangling reference in clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (PR #119197)

2024-12-10 Thread Rahul Joshi via cfe-commits
@@ -1908,7 +1908,7 @@ void clang::EmitClangDiagDocs(const RecordKeeper &Records, raw_ostream &OS) { for (const Record *G : DiagGroups) { bool IsRemarkGroup = isRemarkGroup(G, DiagsInGroup); auto &GroupInfo = -DiagsInGroup[std::string(G->getValueAsString("Grou

[clang] 3376bad - Eliminate duplicate call in Clang driver (NFC)

2024-12-10 Thread Aaron Puchert via cfe-commits
Author: Aaron Puchert Date: 2024-12-10T20:01:19+01:00 New Revision: 3376bad13216da8950bcdeb564df26d5ce4c12bc URL: https://github.com/llvm/llvm-project/commit/3376bad13216da8950bcdeb564df26d5ce4c12bc DIFF: https://github.com/llvm/llvm-project/commit/3376bad13216da8950bcdeb564df26d5ce4c12bc.diff

[clang] [llvm] SystemZ: Add support for __builtin_setjmp and __builtin_longjmp. (PR #119257)

2024-12-10 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand approved this pull request. LGTM, let's try to merge again. https://github.com/llvm/llvm-project/pull/119257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a dangling reference in clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (PR #119197)

2024-12-10 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/119197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a dangling reference in clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (PR #119197)

2024-12-10 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/119197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][AArch64][clang] Emit fmv-features metadata in LLVM IR. (PR #118544)

2024-12-10 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: Thanks for looking into this Andrew. There's one thing I would like to clarify here. Jon expressed the opinion that in your example the command line should determine the highest priority version (i8mm+fcma), which isn't what https://github.com/ARM-software/acle/pull/370 suggest

[clang] [llvm] [NVPTX] Add NVVMUpgradeAnnotations pass to cleanup legacy annotations (PR #119261)

2024-12-10 Thread Artem Belevich via cfe-commits
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind

<    1   2   3   4   >