[clang] [clang] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

2024-12-07 Thread via cfe-commits
@@ -368,8 +368,8 @@ bool CXXRecordDecl::FindBaseClass(const CXXBaseSpecifier *Specifier, const CXXRecordDecl *BaseRecord) { assert(BaseRecord->getCanonicalDecl() == BaseRecord && "User data for FindBaseClass is not canonical!"); -

[clang-tools-extra] 3f458cd - [Clang] Warning as error Array Comparisons from C++26 (#118872)

2024-12-07 Thread via cfe-commits
Author: Amr Hesham Date: 2024-12-07T18:28:09+01:00 New Revision: 3f458cd9abbf99cddcded076b5e7b4049607b7b4 URL: https://github.com/llvm/llvm-project/commit/3f458cd9abbf99cddcded076b5e7b4049607b7b4 DIFF: https://github.com/llvm/llvm-project/commit/3f458cd9abbf99cddcded076b5e7b4049607b7b4.diff LO

[clang-tools-extra] fix parse windows driver and wsl path (PR #119085)

2024-12-07 Thread via cfe-commits
https://github.com/95833 updated https://github.com/llvm/llvm-project/pull/119085 >From 1a37796fbb624a54b00cfff42674fbfa79616f61 Mon Sep 17 00:00:00 2001 From: root <987004...@qq.com> Date: Sun, 8 Dec 2024 01:19:59 +0800 Subject: [PATCH] fix parse windows driver and wsl path --- clang-tools-ex

[clang] [ubsan] Improve lowering of @llvm.allow.ubsan.check (PR #119013)

2024-12-07 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/119013 >From d66671a29061f80df52e4d4b7a2b6ce1de5cae27 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Fri, 6 Dec 2024 11:18:20 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?= =?U

[clang] [NFC][ubsan] Pre-commit test with missed optimization (PR #119012)

2024-12-07 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/119012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
https://github.com/AdUhTkJm created https://github.com/llvm/llvm-project/pull/119098 Fixed issue #118892. >From 367261c3b9d8bf80ba39ae296d30f53bff2a2d4b Mon Sep 17 00:00:00 2001 From: AdUhTkJm <2292398...@qq.com> Date: Sun, 8 Dec 2024 07:04:11 +0800 Subject: [PATCH] [Clang] Fix crash for incomp

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (AdUhTkJm) Changes Fixed issue #118892. --- Full diff: https://github.com/llvm/llvm-project/pull/119098.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaStmtAsm.cpp (+1) - (added) clang/test/Sema/inline-asm-incompatible-type

[clang] [rtsan] Add `verify_interceptors` flag to docs (PR #119074)

2024-12-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/119074 None >From 649e184e37ba94ac77b840ae4d02213a8fb77ab5 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Sat, 7 Dec 2024 07:45:34 -0800 Subject: [PATCH] [rtsan] Add `verify_interceptors` to docs --- clang/docs/Rea

[clang] [rtsan] Add `verify_interceptors` flag to docs (PR #119074)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chris Apple (cjappl) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/119074.diff 1 Files Affected: - (modified) clang/docs/RealtimeSanitizer.rst (+4-1) ``diff diff --git a/clang/docs/RealtimeSanitizer.rst b/

[clang] [clang][modules] Fix std::initializer_list recognition if it's exported out of a module (PR #118537)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (jijjijj) Changes If the std::initializer_list is exported out of module, its `DeclContext` is not a namespace as `Sema::isStdInitializerList` expects, but an `Decl::Kind::Export` and only its parent is a namespace. So this commit ma

[clang] [clang][modules] Fix std::initializer_list recognition if it's exported out of a module (PR #118537)

2024-12-07 Thread via cfe-commits
https://github.com/jijjijj ready_for_review https://github.com/llvm/llvm-project/pull/118537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/AMDGPU: Set amdgpu-max-num-workgroups to disable Y/Z by default (PR #119009)

2024-12-07 Thread Shilei Tian via cfe-commits
shiltian wrote: > So this is wrong. It was correct for openmp. Even OpenMP is discussing to introduce multi-dim support, though in LLVM I already implemented it as an extension. :-) https://github.com/llvm/llvm-project/pull/119009 ___ cfe-commits mai

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: iseki (iseki0) Changes Emmm... Maybe I'm splitting hairs. But I really think the paragraph should be more detailed. The orginal document makes me confused. Do I take the ownership of the string data? Here I don't refer the `clang_dispose

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread via cfe-commits
iseki0 wrote: @egorzhdan @compnerd Thank you. https://github.com/llvm/llvm-project/pull/119090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread via cfe-commits
https://github.com/iseki0 created https://github.com/llvm/llvm-project/pull/119090 Emmm... Maybe I'm splitting hairs. But I really think the paragraph should be more detailed. The orginal document makes me confused. Do I take the ownership of the string data? Here I don't refer the `clang_dis

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
@@ -74,49 +72,53 @@ static int32_t nvptx_parallel_reduce_nowait(void *reduce_data, uint32_t NumThreads = omp_get_num_threads(); if (NumThreads == 1) return 1; -/* - * This reduce function handles reduction within a team. It handles - * parallel regions in b

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Shilei Tian via cfe-commits
shiltian wrote: > > I like this method, but just out of curiosity, did we use anything in > > AMDGPU implementation that has target dependent lowering in the front end? > > If not, this is totally fine I'd say. > > We used to use the `__AMDGCN_WAVEFRONT_SIZE` but that was removed for > unrela

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/119091 >From 4c710e49eea97e542b97e0b5e78b7915acd32383 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Sat, 7 Dec 2024 13:47:23 -0600 Subject: [PATCH 1/2] [OpenMP] Use generic IR for the OpenMP DeviceRTL Summary: We

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-offload @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: We previously built this for every single architecture to deal with incompatibility. This patch updates it to use the 'generic' IR that `libc` and other projects use. Who

[clang] [clang-format] Fix an assertion failure in RemoveSemicolon (PR #117472)

2024-12-07 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/117472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/119091 >From 4c710e49eea97e542b97e0b5e78b7915acd32383 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Sat, 7 Dec 2024 13:47:23 -0600 Subject: [PATCH 1/3] [OpenMP] Use generic IR for the OpenMP DeviceRTL Summary: We

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I like this method, but just out of curiosity, did we use anything in AMDGPU > implementation that has target dependent lowering in the front end? If not, > this is totally fine I'd say. We used to use the `__AMDGCN_WAVEFRONT_SIZE` but that was removed for unrelated reasons.

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3f458cd9abbf99cddcded076b5e7b4049607b7b4 0df55740f2010c531ee4f96cc0f34aa1b8cea749 --e

[clang] [clang-tools-extra] [clang] [Sema] Preserve nested name specifier prefix in MemberPointerType (PR #118236)

2024-12-07 Thread Nathan Ridge via cfe-commits
@@ -5347,13 +5347,16 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state, case NestedNameSpecifier::TypeSpec: case NestedNameSpecifier::TypeSpecWithTemplate: - ClsType = QualType(NNS->getAsType(), 0); + const Type *N

[clang-tools-extra] [clangd] Document the cases in which Dex::Files and IdxContents are populated (PR #118906)

2024-12-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/118906 >From 45311dbceed8d438f2ac0db5019719a7fa32c0bf Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Thu, 5 Dec 2024 19:45:25 -0500 Subject: [PATCH] [clangd] Add clarifying comment about when Dex::IdxContents

[clang-tools-extra] [clangd] Add clarifying comment about when Dex::IdxContents is populated (PR #118906)

2024-12-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/118906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add clarifying comment about when Dex::IdxContents is populated (PR #118906)

2024-12-07 Thread Nathan Ridge via cfe-commits
@@ -121,6 +121,8 @@ class Dex : public SymbolIndex { llvm::DenseMap, std::vector> Relations; std::shared_ptr KeepAlive; // poor man's move-only std::any // Set of files which were used during this index build. + // Files and IdxContents are only populated for dynamic an

[clang] Fix lld link issue for OHOS (PR #118192)

2024-12-07 Thread Pavel Kosov via cfe-commits
kpdev wrote: @phuang Hi! Thank you for the patch. Will take a look in the nearest pair of days https://github.com/llvm/llvm-project/pull/118192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [clang-tools-extra] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-07 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/118872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Improve error for `-fsanitize=function/kcfi -mexecute-only` incompatibility (PR #118816)

2024-12-07 Thread Csanád Hajdú via cfe-commits
https://github.com/Il-Capitano edited https://github.com/llvm/llvm-project/pull/118816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Improve error for `-fsanitize=function/kcfi -mexecute-only` incompatibility (PR #118816)

2024-12-07 Thread Csanád Hajdú via cfe-commits
@@ -418,8 +418,14 @@ SanitizerArgs::SanitizerArgs(const ToolChain &TC, Add & NotAllowedWithExecuteOnly & ~DiagnosedKinds) { if (DiagnoseErrors) { std::string Desc = describeSanitizeArg(Arg, KindsToDiagnose); -D.Diag(diag::err_dr

[clang] 755519f - [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (#117573)

2024-12-07 Thread via cfe-commits
Author: Paul Osmialowski Date: 2024-12-07T11:18:44Z New Revision: 755519f7f661375be05750001ff11e106e6b7f87 URL: https://github.com/llvm/llvm-project/commit/755519f7f661375be05750001ff11e106e6b7f87 DIFF: https://github.com/llvm/llvm-project/commit/755519f7f661375be05750001ff11e106e6b7f87.diff L

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-07 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm closed https://github.com/llvm/llvm-project/pull/117573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

2024-12-07 Thread Vladislav Belov via cfe-commits
https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/119024 >From e3fd6b1d8408439e200622f577451d144ef8f720 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Fri, 6 Dec 2024 23:06:01 +0300 Subject: [PATCH] [clang][NFC] Fix cast for injected types in case name lookup for dependen

[clang] [clang][NFC] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

2024-12-07 Thread Vladislav Belov via cfe-commits
vbe-sc wrote: @erichkeane, @cor3ntin, could you, please, take a look at this fix? https://github.com/llvm/llvm-project/pull/119024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Check composite bitcasts for indeterminate bits (PR #118988)

2024-12-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/118988 >From c45a6b422ff2ad9f60e7e39d335be2e3d3fe4465 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 6 Dec 2024 15:52:38 +0100 Subject: [PATCH] [clang][bytecode] Check composite bitcasts for i

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-07 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: > It is normal cases that source code and test code have different quality > metrics. +1. That's responsibility of the build system. "What is a test" is something that can vary from project to project. > is expected to be removed again >From experience, removing flags i

[clang] d76650b - [clang-format] Clean up cmake target clang-format-check-format

2024-12-07 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-12-07T00:19:11-08:00 New Revision: d76650bced1de20cb79d1b4a0c1732339a5d0099 URL: https://github.com/llvm/llvm-project/commit/d76650bced1de20cb79d1b4a0c1732339a5d0099 DIFF: https://github.com/llvm/llvm-project/commit/d76650bced1de20cb79d1b4a0c1732339a5d0099.diff LOG:

[clang] b4150ed - [clang][bytecode] Check composite bitcasts for indeterminate bits (#118988)

2024-12-07 Thread via cfe-commits
Author: Timm Baeder Date: 2024-12-07T13:06:00+01:00 New Revision: b4150ed128a136409a2510ee3bd318f703fb URL: https://github.com/llvm/llvm-project/commit/b4150ed128a136409a2510ee3bd318f703fb DIFF: https://github.com/llvm/llvm-project/commit/b4150ed128a136409a2510ee3bd318f703fb.diff L

[clang] [Tooling/Inclusion] Update std symbol mapping (PR #118174)

2024-12-07 Thread Vadim D. via cfe-commits
vvd170501 wrote: Ping. Could someone review this, please? https://github.com/llvm/llvm-project/pull/118174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Check composite bitcasts for indeterminate bits (PR #118988)

2024-12-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/118988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 416e4cd - [clang][bytecode][NFC] Remove leftover debug output

2024-12-07 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-12-07T13:56:37+01:00 New Revision: 416e4cd332c7421b187844ac9aaf6fe28b575a7d URL: https://github.com/llvm/llvm-project/commit/416e4cd332c7421b187844ac9aaf6fe28b575a7d DIFF: https://github.com/llvm/llvm-project/commit/416e4cd332c7421b187844ac9aaf6fe28b575a7d.diff LO

[clang] [clang-tools-extra] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-07 Thread Amr Hesham via cfe-commits
@@ -10274,6 +10274,11 @@ def warn_array_comparison : Warning< "to compare array addresses, use unary '+' to decay operands to pointers">, InGroup>; +def warn_array_comparison_cxx26 : Warning< + "comparison between two arrays compare their addresses not their contents; " -

[clang] [clang-tools-extra] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-07 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118872 >From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 5 Dec 2024 22:18:37 +0100 Subject: [PATCH 1/6] [Clang] Warning as error Array Comparisons from C++26 St

[clang] [clang-tools-extra] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-07 Thread via cfe-commits
@@ -10274,6 +10274,11 @@ def warn_array_comparison : Warning< "to compare array addresses, use unary '+' to decay operands to pointers">, InGroup>; +def warn_array_comparison_cxx26 : Warning< + "comparison between two arrays compare their addresses not their contents; " -

<    1   2