[clang] [NFC][ubsan] Pre-commit test with missed optimization (PR #119012)

2024-12-06 Thread Kirill Stoimenov via cfe-commits
https://github.com/kstoimenov approved this pull request. https://github.com/llvm/llvm-project/pull/119012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1df2855 - [HLSL] Add ByteAddressBuffer, RWByteAddressBuffer and RasterizerOrderedByteAddressBuffer definitions to HLSLExternalSemaSource #113477 (#116699)

2024-12-06 Thread via cfe-commits
Author: joaosaffran Date: 2024-12-06T12:19:39-08:00 New Revision: 1df28554bd6264d44aa2ce12e5a2fc29f61bb027 URL: https://github.com/llvm/llvm-project/commit/1df28554bd6264d44aa2ce12e5a2fc29f61bb027 DIFF: https://github.com/llvm/llvm-project/commit/1df28554bd6264d44aa2ce12e5a2fc29f61bb027.diff L

[clang] [HLSL] Add ByteAddressBuffer, RWByteAddressBuffer and RasterizerOrderedByteAddressBuffer definitions to HLSLExternalSemaSource #113477 (PR #116699)

2024-12-06 Thread via cfe-commits
https://github.com/joaosaffran closed https://github.com/llvm/llvm-project/pull/116699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread Gedare Bloom via cfe-commits
gedare wrote: > Yes. I followed the code that implements `AlignAfterOpenBracket: > BlockIndent`, except applying to ClosesTemplateDeclaration. I made it a new > setting for backwards compatibility. 👍 Maybe we should make it a sub-option for `BlockIndent`. I'm seeing a possible need for having

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
tstellar wrote: /cherry-pick 18af3fc1bf8855e1e166e64a9210ed07d610aa54 https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#119051 https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread Gedare Bloom via cfe-commits
gedare wrote: > > Yes. I followed the code that implements `AlignAfterOpenBracket: > > BlockIndent`, except applying to ClosesTemplateDeclaration. I made it a new > > setting for backwards compatibility. 👍 > > Maybe we should make it a sub-option for `BlockIndent`. I'm seeing a possible > nee

[clang] bcf6f84 - Revert "[Clang] Deleting an incomplete enum type is not an error (#118455) (#118980)

2024-12-06 Thread via cfe-commits
Author: cor3ntin Date: 2024-12-07T04:22:47+01:00 New Revision: bcf6f84763ea01d0a22022d0d64442e774fe86ab URL: https://github.com/llvm/llvm-project/commit/bcf6f84763ea01d0a22022d0d64442e774fe86ab DIFF: https://github.com/llvm/llvm-project/commit/bcf6f84763ea01d0a22022d0d64442e774fe86ab.diff LOG:

[clang] [Clang] Deleting an incomplete enum type is not an error (PR #118455)

2024-12-06 Thread Alexander Kornienko via cfe-commits
alexfh wrote: The test case was reduced to this: ``` template struct a { union b {}; struct c { c() { delete d; } b *d; } f; }; a e; ``` https://gcc.godbolt.org/z/d5cP4McG3 https://github.com/llvm/llvm-project/pull/118455 ___ cfe-commits

[clang] Revert "[Clang] Deleting an incomplete enum type is not an error (#118455) (PR #118980)

2024-12-06 Thread Alexander Kornienko via cfe-commits
alexfh wrote: I've added a reduced test case to https://github.com/llvm/llvm-project/pull/118455. Merging this to unbreak clang. https://github.com/llvm/llvm-project/pull/118980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] Revert "[Clang] Deleting an incomplete enum type is not an error (#118455) (PR #118980)

2024-12-06 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh closed https://github.com/llvm/llvm-project/pull/118980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread Malavika Samak via cfe-commits
@@ -433,37 +433,36 @@ AST_MATCHER(ArraySubscriptExpr, isSafeArraySubscript) { //already duplicated // - call both from Sema and from here - const auto *BaseDRE = - dyn_cast(Node.getBase()->IgnoreParenImpCasts()); - const auto *SLiteral = - dyn_cast(Node.ge

[clang] [clang][ExprConst] Add diagnostics for invalid binary arithmetic (PR #118475)

2024-12-06 Thread Shafik Yaghmour via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/shafik commented: Am I missing something, it seems like several of the new diagnostics don't have tests that cover them. https://github.com/llvm/llvm-project/pull/118475 __

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak edited https://github.com/llvm/llvm-project/pull/118249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7f19b1e49c172772390a3c2e71631115da80af4b e1eadf464509ab74ff4f097f92e7140f43c61262 --e

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/118249 >From e1eadf464509ab74ff4f097f92e7140f43c61262 Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Fri, 29 Nov 2024 14:53:37 +0530 Subject: [PATCH] [-Wunsafe-buffer-usage] Suppress warning for multi-dimens

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

2024-12-06 Thread Haohai Wen via cfe-commits
HaohaiWen wrote: > > Better to double check with author who specified those CLOption. > > Do you mean the person that added `CLOption` to these flags? That was > @tarunprabhu, but IIUC that was by mistake; his intention was to extend these > flags only to Flang. > > Otherwise `-Xlinker` has b

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 requested changes to this pull request. It would be better to use `GtestCmp` if you really want clang-tidy support gtest in this check. Here is an unfinished example which can match ```int v = 10; TEST(a, b) { std::optional a; if (v) { a = 1; } ASSERT_N

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread via cfe-commits
leijurv wrote: Yes. I followed the code that implements `AlignAfterOpenBracket: BlockIndent`, except applying to ClosesTemplateDeclaration. I made it a new setting for backwards compatibility. 👍 https://github.com/llvm/llvm-project/pull/118046 ___ cf

[clang] 18af3fc - [Clang][perf-training] Fix clean command in perf-helper.py (#118978)

2024-12-06 Thread via cfe-commits
Author: Tom Stellard Date: 2024-12-06T18:34:59-08:00 New Revision: 18af3fc1bf8855e1e166e64a9210ed07d610aa54 URL: https://github.com/llvm/llvm-project/commit/18af3fc1bf8855e1e166e64a9210ed07d610aa54 DIFF: https://github.com/llvm/llvm-project/commit/18af3fc1bf8855e1e166e64a9210ed07d610aa54.diff

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Handle bitcasts involving bitfields (PR #116843)

2024-12-06 Thread LLVM Continuous Integration via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `clang` at step 3 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildb

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread Gedare Bloom via cfe-commits
gedare wrote: I think you should add test cases with multiple `>>` closing, see `UnderstandsTemplateParameters` for example. Consider trying the code snippet mentioned in https://github.com/llvm/llvm-project/issues/80049 as well. https://github.com/llvm/llvm-project/pull/118046 _

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread via cfe-commits
https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001 From: Leijurv Date: Fri, 29 Nov 2024 21:54:36 -0600 Subject: [PATCH 1/2] [clang-format] Add BreakBeforeTemplateClose option --- clang/doc

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread via cfe-commits
leijurv wrote: > I think you should add test cases with multiple `>>` closing, see > `UnderstandsTemplateParameters` for example. > > Consider trying the code snippet mentioned in #80049 as well. Thank you for the suggestion! I have integrated that test case. It indicated that I was being too

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread Malavika Samak via cfe-commits
@@ -433,37 +433,36 @@ AST_MATCHER(ArraySubscriptExpr, isSafeArraySubscript) { //already duplicated // - call both from Sema and from here - const auto *BaseDRE = - dyn_cast(Node.getBase()->IgnoreParenImpCasts()); - const auto *SLiteral = - dyn_cast(Node.ge

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/118249 >From c1f7c2b37948271ccc8de7910d2bab91dfb2f87e Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Fri, 29 Nov 2024 14:53:37 +0530 Subject: [PATCH] [-Wunsafe-buffer-usage] Suppress warning for multi-dimens

[clang] [clang][bytecode] Check composite bitcasts for indeterminate bits (PR #118988)

2024-12-06 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/118988 >From 7e723fd3ee3844ad83fa61118dd263a84a6145e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 6 Dec 2024 15:52:38 +0100 Subject: [PATCH] [clang][bytecode] Check composite bitcasts for i

<    1   2   3   4   5