https://github.com/cjappl closed
https://github.com/llvm/llvm-project/pull/118989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/118872
>From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Thu, 5 Dec 2024 22:18:37 +0100
Subject: [PATCH 1/4] [Clang] Warning as error Array Comparisons from C++26
St
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3b29a8a00809e868e3df7e687695670ff5077fbd
ee10510d15e75da7fc75420fa33d00e97d6477a0 --e
@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const
ASTContext *Context) {
return Context->buildImplicitTypedef(VaListTagArrayType,
"__builtin_va_list");
}
+static TypedefDecl *
+CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) {
+ /
@@ -0,0 +1,62 @@
+//===--- Xtensa.cpp - Implement Xtensa target feature support
-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.
@@ -0,0 +1,62 @@
+//===--- Xtensa.cpp - Implement Xtensa target feature support
-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.
@@ -358,7 +358,10 @@ class TargetInfo : public TransferrableTargetInfo,
//void *__saved_reg_area_end_pointer;
//void *__overflow_area_pointer;
//} va_list;
-HexagonBuiltinVaList
+HexagonBuiltinVaList,
+
+// Tensilica Xtensa
+XtensaABIBuiltinV
@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const
ASTContext *Context) {
return Context->buildImplicitTypedef(VaListTagArrayType,
"__builtin_va_list");
}
+static TypedefDecl *
+CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) {
+ /
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/118978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jvoung updated
https://github.com/llvm/llvm-project/pull/115051
>From 8d83ec25ccdedad5f6a48e4a23176435f71a3e72 Mon Sep 17 00:00:00 2001
From: Jan Voung
Date: Tue, 5 Nov 2024 19:20:36 +
Subject: [PATCH 1/5] [clang-tidy] Filter out googletest TUs in
bugprone-unchecked-opti
jvoung wrote:
Thanks! Ok that does that look useful (and I think the our other reviewer
ymand@ wrote it =) https://reviews.llvm.org/D74840).
- I'll work on using those in parallel
- It will need to be extended a little to handle a few more matches (right now
it's the binary comparison eq/ne, e
https://github.com/jvoung updated
https://github.com/llvm/llvm-project/pull/115051
>From 8d83ec25ccdedad5f6a48e4a23176435f71a3e72 Mon Sep 17 00:00:00 2001
From: Jan Voung
Date: Tue, 5 Nov 2024 19:20:36 +
Subject: [PATCH 1/4] [clang-tidy] Filter out googletest TUs in
bugprone-unchecked-opti
@@ -291,6 +365,36 @@ BareMetal::OrderedMultilibs
BareMetal::getOrderedMultilibs() const {
return llvm::reverse(Default);
}
+ToolChain::CXXStdlibType BareMetal::GetDefaultCXXStdlibType() const {
+ if (getTriple().isRISCV()) {
+return GCCInstallation.isValid() ? ToolChai
@@ -0,0 +1,141 @@
+//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE
https://github.com/fahadnayyar updated
https://github.com/llvm/llvm-project/pull/118938
>From 781bb2a49fed8fa38059cfd23563b02c82f83eb0 Mon Sep 17 00:00:00 2001
From: Fahad Nayyar
Date: Thu, 5 Dec 2024 18:25:49 -0800
Subject: [PATCH] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes
https://github.com/egorzhdan approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/118938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yuxuanchen1997 wrote:
> > > so we don't need to carry around multiple implementations of
> > > machine-readable diagnostic information.
> >
> >
> > I just realized that we also have `-diagnostic-log-file` as a cc1 flag.
> > This logs into an XML. Is this preferred to the binary format or no?
https://github.com/jwanggit86 edited
https://github.com/llvm/llvm-project/pull/118907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jwanggit86 edited
https://github.com/llvm/llvm-project/pull/118907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jwanggit86 edited
https://github.com/llvm/llvm-project/pull/118907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/118309
>From 8398d47a413dfbabb9a4eb96809304c240f4e3ad Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 2 Dec 2024 15:22:50 +
Subject: [PATCH] [llvm] Move sub-project lead maintainers into their own fi
DavidSpickett wrote:
Libcxx part pushed as
https://github.com/llvm/llvm-project/commit/1bdb0a408f1e2e9f6d5f43b23b4f87f87b3950ab.
https://github.com/llvm/llvm-project/pull/118309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/118872
>From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Thu, 5 Dec 2024 22:18:37 +0100
Subject: [PATCH 1/3] [Clang] Warning as error Array Comparisons from C++26
St
@@ -36,3 +42,29 @@
// CHECK-ESCAPABLE: Dumping EscapableType:
// CHECK-ESCAPABLE-NEXT: CXXRecordDecl {{.+}} imported in SwiftImportAs {{.+}}
struct EscapableType
// CHECK-ESCAPABLE: SwiftAttrAttr {{.+}} "Escapable"
+
+//CHECK-FUNCTION-RETURNING-FRT: Dumping functionReturningFr
https://github.com/egorzhdan edited
https://github.com/llvm/llvm-project/pull/118938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lizhengxing edited
https://github.com/llvm/llvm-project/pull/117781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> > so we don't need to carry around multiple implementations of
> > machine-readable diagnostic information.
>
> I just realized that we also have `-diagnostic-log-file` as a cc1 flag. This
> logs into an XML. Is this preferred to the binary format or no?
I don't think ei
@@ -226,3 +226,26 @@
//
// RUN: HOME=%S/Inputs/config %clang -### --config-user-dir=~ -v 2>&1 |
FileCheck %s --check-prefix=CHECK-TILDE
// CHECK-TILDE: User configuration file directory: {{.*}}/Inputs/config
+
+//--- Fallback to stripping OS versions
+//
+// RUN: touch %t/test
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/111387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan commented:
Please remember to increment the APINotes serialization version since the
format is changing in this patch.
https://github.com/llvm/llvm-project/pull/118938
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
@@ -428,6 +428,9 @@ New Compiler Flags
- The ``-Warray-compare`` warning has been added to warn about array comparison
on versions older than C++20.
+- The ``-Warray-compare-cxx26`` warning has been added to warn about array
comparison
+ starting from C++26, this warn is e
@@ -1243,13 +1268,14 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) {
// Try parsing configuration file.
if (!ContainsError)
ContainsError = loadConfigFiles();
- bool HasConfigFile = !ContainsError && (CfgOptions.get() != nullptr);
+ bool HasConfigFileHead
@@ -239,7 +239,7 @@ C++2c implementation status
Remove Deprecated Array Comparisons from C++26
https://wg21.link/P2865R6";>P2865R6
- No
+ Clang 20
AmrDeveloper wrote:
Done, thanks
https://github.com/llvm/llvm-project/pull/118872
__
https://github.com/MaskRay approved this pull request.
The subject (linker flags) is no longer accurate.
It's better to mention that Add $ for
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
spall wrote:
Work for this PR begins at 'splat cast wip' commit.
https://github.com/llvm/llvm-project/pull/118992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lizhengxing edited
https://github.com/llvm/llvm-project/pull/117781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lizhengxing edited
https://github.com/llvm/llvm-project/pull/117781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
This seems fine to me. Please give folks ~24 hrs to chime in before merging.
https://github.com/llvm/llvm-project/pull/118872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
@@ -650,6 +655,8 @@ llvm::Type *CodeGenTypes::ConvertType(QualType T) {
// An ext_vector_type of Bool is really a vector of bits.
llvm::Type *IRElemTy = VT->isExtVectorBoolType()
? llvm::Type::getInt1Ty(getLLVMContext())
+
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (fahadnayyar)
Changes
Adding support to APINotes to annotate C++ methods and functions with
`swift_attr("returns_retained")` and `swift_attr("returns_unretained")`
rdar://141007510
---
Full diff: https://github.com/llvm/llvm-project
@@ -12153,8 +12166,15 @@ static QualType DecodeTypeFromStr(const char *&Str,
const ASTContext &Context,
RequiresICE, false);
assert(!RequiresICE && "Can't require vector ICE");
-// TODO: No way to make AltiVec vectors in bu
https://github.com/SpencerAbson commented:
Thanks! Does this work need to be based on
https://github.com/llvm/llvm-project/pull/118957 and
https://github.com/llvm/llvm-project/pull/118961?
https://github.com/llvm/llvm-project/pull/118969
___
cfe-comm
@@ -448,15 +448,15 @@ std::string SVEType::builtinBaseType() const {
case TypeKind::PredicatePattern:
return "i";
case TypeKind::Fpm:
-return "Wi";
+return "UWi";
SpencerAbson wrote:
Good catch
https://github.com/llvm/llvm-project/pull/118969
https://github.com/SpencerAbson edited
https://github.com/llvm/llvm-project/pull/118969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lizhengxing edited
https://github.com/llvm/llvm-project/pull/117781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fahadnayyar ready_for_review
https://github.com/llvm/llvm-project/pull/118938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -24,7 +24,7 @@ const uint16_t VERSION_MAJOR = 0;
/// API notes file minor version number.
///
/// When the format changes IN ANY WAY, this number should be incremented.
-const uint16_t VERSION_MINOR = 33; // SwiftEscapable
+const uint16_t VERSION_MINOR = 34; // SwiftEscapabl
https://github.com/SpencerAbson edited
https://github.com/llvm/llvm-project/pull/118969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/paulwalker-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/118956
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spall created
https://github.com/llvm/llvm-project/pull/118992
Implement HLSL Flat casting that handles splatting for arrays and structs, and
vectors if splatting from a vec1.
Closes #100609 and Closes #100619
Depends on #118842
>From 2e932a57ccb992b856b58bec4c30c6b64f24f7
@@ -1655,8 +1655,10 @@ static ExprResult LookupMemberExpr(Sema &S, LookupResult
&R,
// We disallow element access for ext_vector_type bool. There is no way to
// materialize a reference to a vector element as a pointer (each element
is
// one bit in the vector).
https://github.com/fahadnayyar updated
https://github.com/llvm/llvm-project/pull/118938
>From b134b97d3ff44bdf2d9147dda33c9c1e4077 Mon Sep 17 00:00:00 2001
From: Fahad Nayyar
Date: Thu, 5 Dec 2024 18:25:49 -0800
Subject: [PATCH] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes
Fznamznon wrote:
@AaronBallman
Tt seems `SetBuffered` is not honored for stderr intentionally :
Here we return 0
https://github.com/llvm/llvm-project/blob/e68a3e4d0dd349a34c02471438d2e97c2b29e846/llvm/lib/Support/raw_ostream.cpp#L858
To not set the buffer here
https://github.com/llvm/llvm-proje
@@ -1655,8 +1655,10 @@ static ExprResult LookupMemberExpr(Sema &S, LookupResult
&R,
// We disallow element access for ext_vector_type bool. There is no way to
// materialize a reference to a vector element as a pointer (each element
is
// one bit in the vector).
yuxuanchen1997 wrote:
> I'd like to understand the motivation for the tool a bit better. IMO, the
> goal should be to deprecate serialized diagnostics because we are now able to
> emit diagnostics to SARIF instead, and the whole point to SARIF is to be a
> machine-readable interchange format f
@@ -1655,8 +1655,10 @@ static ExprResult LookupMemberExpr(Sema &S, LookupResult
&R,
// We disallow element access for ext_vector_type bool. There is no way to
// materialize a reference to a vector element as a pointer (each element
is
// one bit in the vector).
https://github.com/smallp-o-p edited
https://github.com/llvm/llvm-project/pull/118186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fahadnayyar updated
https://github.com/llvm/llvm-project/pull/118938
>From 8d84df75f6d6c03a15525c678bf789824f3db07a Mon Sep 17 00:00:00 2001
From: Fahad Nayyar
Date: Thu, 5 Dec 2024 18:25:49 -0800
Subject: [PATCH] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes
danilaml wrote:
@nikic Does `AllowEphemerals` actually do what we want in that case? Haven't
looked in detail, but on the surface it seemed way more involved than just `if
(I == CtxI) return true;`.
https://github.com/llvm/llvm-project/pull/109277
__
@@ -12153,8 +12166,15 @@ static QualType DecodeTypeFromStr(const char *&Str,
const ASTContext &Context,
RequiresICE, false);
assert(!RequiresICE && "Can't require vector ICE");
-// TODO: No way to make AltiVec vectors in bu
https://github.com/fahadnayyar updated
https://github.com/llvm/llvm-project/pull/118938
>From 09da7e7207a44338c2f8418464a307cbcad4bc42 Mon Sep 17 00:00:00 2001
From: Fahad Nayyar
Date: Thu, 5 Dec 2024 18:25:49 -0800
Subject: [PATCH] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/118872
>From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Thu, 5 Dec 2024 22:18:37 +0100
Subject: [PATCH 1/3] [Clang] Warning as error Array Comparisons from C++26
St
Author: Haowei Wu
Date: 2024-12-06T10:33:57-08:00
New Revision: 12bdeba76eef1c7adf004a280036a7fb690ba573
URL:
https://github.com/llvm/llvm-project/commit/12bdeba76eef1c7adf004a280036a7fb690ba573
DIFF:
https://github.com/llvm/llvm-project/commit/12bdeba76eef1c7adf004a280036a7fb690ba573.diff
LOG
https://github.com/momchil-velikov edited
https://github.com/llvm/llvm-project/pull/118969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/118954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2024-12-06T15:50:59+01:00
New Revision: 2f9cd43a736008bdecdd920f84c702209ddbd20f
URL:
https://github.com/llvm/llvm-project/commit/2f9cd43a736008bdecdd920f84c702209ddbd20f
DIFF:
https://github.com/llvm/llvm-project/commit/2f9cd43a736008bdecdd920f84c702209ddbd20f.diff
L
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/118743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: David Olsen
Date: 2024-12-06T07:01:09-08:00
New Revision: a43b2e13f9cc69ec7077ea9c74a972e178a2d8f7
URL:
https://github.com/llvm/llvm-project/commit/a43b2e13f9cc69ec7077ea9c74a972e178a2d8f7
DIFF:
https://github.com/llvm/llvm-project/commit/a43b2e13f9cc69ec7077ea9c74a972e178a2d8f7.diff
L
gerekon wrote:
> I don't know what this target IS, did we have an RFC to approve this in Clang
> as a target? Do we have sufficient interest in the project to maintain
> it/keep it?
This is a part of our work for upstreaming Xtensa target support.
https://github.com/espressif/llvm-project/iss
https://github.com/dkolsen-pgi closed
https://github.com/llvm/llvm-project/pull/118743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aaupov approved this pull request.
https://github.com/llvm/llvm-project/pull/118978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kadir çetinkaya
Date: 2024-12-06T15:50:32+01:00
New Revision: d74214cc8c03159e5d1f1168a09368cf3b23fd5f
URL:
https://github.com/llvm/llvm-project/commit/d74214cc8c03159e5d1f1168a09368cf3b23fd5f
DIFF:
https://github.com/llvm/llvm-project/commit/d74214cc8c03159e5d1f1168a09368cf3b23fd5f.dif
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/118960
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
I'd like to understand the motivation for the tool a bit better. IMO, the goal
should be to deprecate serialized diagnostics because we are now able to emit
diagnostics to SARIF instead, and the whole point to SARIF is to be a
machine-readable interch
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/117703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danilaml wrote:
@nikic one thing I've discovered with this fact is that now `load` is not
dereferenceable at "load" itself due to `isValidAssumeForContext` quirk of not
allowing `assume` affect itself. Not sure if it's intentional for attributes
here - makes it look like it's not safe to specu
@@ -511,6 +511,10 @@ static void ProcessAPINotes(Sema &S, FunctionOrMethod
AnyFunc,
AnyTypeChanged = true;
}
+ // returns_(un)retained
+ if (!Info.SwiftReturnOwnership.empty())
Xazax-hun wrote:
There are other places where we do not validate string
@@ -105,6 +105,7 @@ include "arm_immcheck_incl.td"
// N: svfloat64_t
// $: svbfloat16_t
// ~: svmfloat8_t
+// !: mfloat8_t (splat to svmfloat8_t)
CarolineConcatto wrote:
Nit: Can you move this to line 78 to be together with the other splats.
https://github.co
@@ -10877,24 +10923,37 @@ class sve_fp8_dot_indexed opc, ZPRRegOp
dst_ty, Operand iop_ty, string m
let DestructiveInstType = DestructiveOther;
let hasSideEffects = 0;
let mayRaiseFPException = 1;
+
+ let mayLoad = 1;
+ let mayStore = 0;
}
// FP8 Widening Dot-Produ
@@ -2447,3 +2447,39 @@ let SVETargetGuard = "sve2,faminmax", SMETargetGuard =
"sme2,faminmax" in {
defm SVAMIN : SInstZPZZ<"svamin", "hfd", "aarch64_sve_famin",
"aarch64_sve_famin_u">;
defm SVAMAX : SInstZPZZ<"svamax", "hfd", "aarch64_sve_famax",
"aarch64_sve_famax_u">;
https://github.com/fahadnayyar updated
https://github.com/llvm/llvm-project/pull/118938
>From 911d5b4b8549060e8e4eb71a5e34db7b95f1c551 Mon Sep 17 00:00:00 2001
From: Fahad Nayyar
Date: Thu, 5 Dec 2024 18:25:49 -0800
Subject: [PATCH] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes
https://github.com/MacDue closed
https://github.com/llvm/llvm-project/pull/118956
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mgorny approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/111387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
> Current patch breaks test:
>
> ```
> // We pass --sysroot="" to defeat any -DDEFAULT_SYSROOT parameter.
> ```
>
> I think that just a pure hack in the test case, we can just update the test.
> @cyndyishida what do you think about the current approach?
SGTM too. I don't se
yuxuanchen1997 wrote:
> so we don't need to carry around multiple implementations of machine-readable
> diagnostic information.
I just realized that we also have `-diagnostic-log-file` as a cc1 flag. This
logs into an XML. Is this preferred to the binary format or no?
https://github.com/llvm
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/98652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Benjamin Maxwell
Date: 2024-12-06T17:27:46Z
New Revision: bded8890149e55b9abc9c32cb4a9c883c3daad91
URL:
https://github.com/llvm/llvm-project/commit/bded8890149e55b9abc9c32cb4a9c883c3daad91
DIFF:
https://github.com/llvm/llvm-project/commit/bded8890149e55b9abc9c32cb4a9c883c3daad91.diff
L
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-codegen
Author: Jeremy Morse (jmorse)
Changes
This is a reapplication and fix for the code in #75385 , support for
function-local types in debug-info. The first commit is a reapplication of that
code (plus some rebasing
jmorse wrote:
I've placed a re-application of this code in #119001, along with a commit that
attempts to fix the matter discovered here. To avoid multiple DICompositeTypes
in multiple DISubprograms being ODRUnique'd, we instead put them in the
declaration DISubprogram which should be unique'd
https://github.com/sivan-shani deleted
https://github.com/llvm/llvm-project/pull/118771
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fdb1bf9b5949b2a97041922405a812a060fce5f4
a7a3f59f3caae556c6613056f634b504d5052964 --e
AaronBallman wrote:
> > I'd like to understand the motivation for the tool a bit better. IMO, the
> > goal should be to deprecate serialized diagnostics because we are now able
> > to emit diagnostics to SARIF instead, and the whole point to SARIF is to be
> > a machine-readable interchange fo
AaronBallman wrote:
> @AaronBallman Tt seems `SetBuffered` is not honored for stderr intentionally :
>
> Here we return 0
>
> https://github.com/llvm/llvm-project/blob/e68a3e4d0dd349a34c02471438d2e97c2b29e846/llvm/lib/Support/raw_ostream.cpp#L858
>
> To not set the buffer here
>
> https://git
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/118872
>From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Thu, 5 Dec 2024 22:18:37 +0100
Subject: [PATCH 1/2] [Clang] Warning as error Array Comparisons from C++26
St
https://github.com/spall updated
https://github.com/llvm/llvm-project/pull/118992
>From 2e932a57ccb992b856b58bec4c30c6b64f24f711 Mon Sep 17 00:00:00 2001
From: Sarah Spall
Date: Thu, 28 Nov 2024 16:23:57 +
Subject: [PATCH 1/8] Flat casts WIP
---
clang/include/clang/AST/OperationKinds.def
https://github.com/lizhengxing updated
https://github.com/llvm/llvm-project/pull/117781
>From 2941d87dbaf091aa443ad57ce55e98e7bab83d2b Mon Sep 17 00:00:00 2001
From: Zhengxing Li
Date: Wed, 13 Nov 2024 10:54:16 -0800
Subject: [PATCH 1/3] [HLSL] Implement SV_GroupThreadId semantic
Support SV_Gr
@@ -2,15 +2,18 @@
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-mesh -hlsl-entry CSMain -x
hlsl -finclude-default-header -verify -o - %s
[numthreads(8,8,1)]
-// expected-error@+3 {{attribute 'SV_GroupIndex' is unsupported in 'mesh'
shaders, requires compute}}
-// expect
@@ -389,6 +389,11 @@ llvm::Value *CGHLSLRuntime::emitInputSemantic(IRBuilder<>
&B,
CGM.getIntrinsic(getThreadIdIntrinsic());
return buildVectorInput(B, ThreadIDIntrinsic, Ty);
}
+ if (D.hasAttr()) {
+llvm::Function *GroupThreadIDIntrinsic =
+CGM.getI
@@ -10274,6 +10274,11 @@ def warn_array_comparison : Warning<
"to compare array addresses, use unary '+' to decay operands to pointers">,
InGroup>;
+def warn_array_comparison_cxx26 : Warning<
+ "comparison between two arrays compare their addresses not their contents; "
-
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/98652
>From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 12 Jul 2024 11:17:24 -0400
Subject: [PATCH 1/2] update autoconversion functionality to fix erro
301 - 400 of 429 matches
Mail list logo
