[clang] [llvm] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2024-12-06 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/118969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl` (PR #118518)

2024-12-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `clang` at step 3 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/1628 Here is the relevant piece of the build log f

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FDOT LANE instructions (PR #118492)

2024-12-06 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray updated https://github.com/llvm/llvm-project/pull/118492 >From 609cf3fbdb28c155f4b8c787c1e2cb791c8a292f Mon Sep 17 00:00:00 2001 From: Jonathan Thackray Date: Fri, 29 Nov 2024 11:27:03 + Subject: [PATCH 1/7] [AArch64] Add intrinsics for SME FP8 FDOT LANE instru

[clang] [Clang] Deleting an incomplete enum type is not an error (PR #118455)

2024-12-06 Thread Alexander Kornienko via cfe-commits
alexfh wrote: In my case I don't see an assertion before this change (using Clang built from c0192a008c4a2b8afdc2b63526c0483632d81c07). https://github.com/llvm/llvm-project/pull/118455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[libclc] [libcxx] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-06 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 952c515 - [Driver][OpenMP] Fix OpenMP target-toolchain-option parser (#115375)

2024-12-06 Thread via cfe-commits
Author: Jefferson Le Quellec Date: 2024-12-06T09:02:05-05:00 New Revision: 952c5156e65d15e0f8692ec55e2874657150259e URL: https://github.com/llvm/llvm-project/commit/952c5156e65d15e0f8692ec55e2874657150259e DIFF: https://github.com/llvm/llvm-project/commit/952c5156e65d15e0f8692ec55e2874657150259

[clang] [Driver][OpenMP] Fix OpenMP target-toolchain-option parser (PR #115375)

2024-12-06 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev closed https://github.com/llvm/llvm-project/pull/115375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][OpenMP] Fix OpenMP target-toolchain-option parser (PR #115375)

2024-12-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clangd-ubuntu-tsan` running on `clangd-ubuntu-clang` while building `clang` at step 2 "checkout". Full details are available at: https://lab.llvm.org/buildbot/#/builders/134/builds/9882 Here is the relevant piece of the buil

[clang] 2f4eac6 - [clang][ARM] disable frame pointers by default for bare metal ARM targets (#117140)

2024-12-06 Thread via cfe-commits
Author: Ties Stuij Date: 2024-12-06T14:05:30Z New Revision: 2f4eac62879f9ccf6fda53e4e083e8eed46a9119 URL: https://github.com/llvm/llvm-project/commit/2f4eac62879f9ccf6fda53e4e083e8eed46a9119 DIFF: https://github.com/llvm/llvm-project/commit/2f4eac62879f9ccf6fda53e4e083e8eed46a9119.diff LOG: [c

[clang] [clang][ARM] disable frame pointers by default for bare metal ARM targets (PR #117140)

2024-12-06 Thread Ties Stuij via cfe-commits
https://github.com/stuij closed https://github.com/llvm/llvm-project/pull/117140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Fix C++11 style initialization of typedef'd vectors (PR #118956)

2024-12-06 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue updated https://github.com/llvm/llvm-project/pull/118956 >From cb9857aad6f84e4ac473f572a828ea5db6d4fd58 Mon Sep 17 00:00:00 2001 From: Benjamin Maxwell Date: Fri, 6 Dec 2024 11:42:11 + Subject: [PATCH 1/2] [clang][AArch64] Fix C++11 style initialization of typedef

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I don't know what this target IS, did we have an RFC to approve this in Clang as a target? Do we have sufficient interest in the project to maintain it/keep it? https://github.com/llvm/llvm-project/pull/118008 __

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/118978 The first path argument was always being ignored, and since most calls to this command only passed one path, it wasn't actually doing anything in most cases. This bug was introduced by dd0356d741aefa25ece973d6

[clang] [clang][AArch64] Fix C++11 style initialization of typedef'd vectors (PR #118956)

2024-12-06 Thread Paul Walker via cfe-commits
@@ -0,0 +1,23 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 2 +// RUN: %clang_cc1 -fclang-abi-compat=latest -triple aarch64-none-linux-gnu -target-feature +sve -emit-llvm -o - %s | FileCheck %s + +#include + +using vec_t =

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes (PR #118938)

2024-12-06 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun requested changes to this pull request. https://github.com/llvm/llvm-project/pull/118938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes (PR #118938)

2024-12-06 Thread Gábor Horváth via cfe-commits
@@ -542,6 +542,9 @@ class FunctionInfo : public CommonEntityInfo { /// The result type of this function, as a C type. std::string ResultType; + /// Swift name of this entity. + std::string SwiftReturnOwnership; Xazax-hun wrote: Do we need a string to re

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes (PR #118938)

2024-12-06 Thread Gábor Horváth via cfe-commits
@@ -542,6 +542,9 @@ class FunctionInfo : public CommonEntityInfo { /// The result type of this function, as a C type. std::string ResultType; + /// Swift name of this entity. Xazax-hun wrote: Nit: this comment might be a remnant of a copy and paste. htt

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes (PR #118938)

2024-12-06 Thread Gábor Horváth via cfe-commits
@@ -1093,6 +1093,7 @@ unsigned getFunctionInfoSize(const FunctionInfo &FI) { for (const auto &P : FI.Params) size += getParamInfoSize(P); size += sizeof(uint16_t) + FI.ResultType.size(); + size += FI.SwiftReturnOwnership.size(); Xazax-hun wrote: Is th

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Stellard (tstellar) Changes The first path argument was always being ignored, and since most calls to this command only passed one path, it wasn't actually doing anything in most cases. This bug was introduced by dd0356d741aefa25ece97

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes (PR #118938)

2024-12-06 Thread Egor Zhdan via cfe-commits
@@ -542,6 +542,9 @@ class FunctionInfo : public CommonEntityInfo { /// The result type of this function, as a C type. std::string ResultType; + /// Swift name of this entity. + std::string SwiftReturnOwnership; egorzhdan wrote: I think it's fine to repr

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes (PR #118938)

2024-12-06 Thread Gábor Horváth via cfe-commits
@@ -542,6 +542,9 @@ class FunctionInfo : public CommonEntityInfo { /// The result type of this function, as a C type. std::string ResultType; + /// Swift name of this entity. + std::string SwiftReturnOwnership; Xazax-hun wrote: We talked about this with

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes (PR #118938)

2024-12-06 Thread Gábor Horváth via cfe-commits
@@ -511,6 +511,10 @@ static void ProcessAPINotes(Sema &S, FunctionOrMethod AnyFunc, AnyTypeChanged = true; } + // returns_(un)retained + if (!Info.SwiftReturnOwnership.empty()) Xazax-hun wrote: I don't think this is a good idea. This lets the users

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes (PR #118938)

2024-12-06 Thread Egor Zhdan via cfe-commits
@@ -600,6 +603,13 @@ class FunctionInfo : public CommonEntityInfo { friend bool operator==(const FunctionInfo &, const FunctionInfo &); + FunctionInfo &operator|=(const FunctionInfo &RHS) { egorzhdan wrote: This function needs to invoke the overload from

[clang] [llvm] [AMDGPU] Infer amdgpu-no-flat-scratch-init attribute in AMDGPUAttributor (PR #118907)

2024-12-06 Thread Matt Arsenault via cfe-commits
arsenm wrote: > Supposedly you can revert the revert to get the reapply. Yes. You can just revert the revert and force push the PR branch to replace it https://github.com/llvm/llvm-project/pull/118907 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang-tools-extra] [clang-tidy] Add C++ member function support to custom bugprone-unsafe-functions matches (PR #117165)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/117165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Implement operand bundles for floating-point operations (PR #109798)

2024-12-06 Thread Joshua Cranmer via cfe-commits
@@ -357,6 +357,9 @@ class IRBuilderBase { void setConstrainedFPCallAttr(CallBase *I) { I->addFnAttr(Attribute::StrictFP); +MemoryEffects ME = MemoryEffects::inaccessibleMemOnly(); jcranmer-intel wrote: It should be possible to make `CallBase::getMem

[clang] [clang] Fix a crash issue that caused by handling of fields with initializers in nested anonymous unions (PR #113049)

2024-12-06 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM I'm a little concerned this is going to lead to other crashes due to exposing more codepaths to "invalid" decls. But it seems like it's doing the right thing in the given cases. https://github.com/llvm/llvm-project/pull/113049

[clang] [CIR] Infrastructure: class CIRGenBuilderTy; cache CIR types (PR #119037)

2024-12-06 Thread David Olsen via cfe-commits
https://github.com/dkolsen-pgi created https://github.com/llvm/llvm-project/pull/119037 Small infrastructure and background changes to ClangIR. Create class `CIRGenBuilderTy` and its base class `CIRBaseBuilderTy`. These are mostly empty for now, except for what is inherited from `mlir::OpBuild

[clang] [CIR] Infrastructure: class CIRGenBuilderTy; cache CIR types (PR #119037)

2024-12-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/119037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Infrastructure: class CIRGenBuilderTy; cache CIR types (PR #119037)

2024-12-06 Thread Erich Keane via cfe-commits
@@ -9,22 +9,32 @@ using namespace clang; using namespace clang::CIRGen; CIRGenTypes::CIRGenTypes(CIRGenModule &genModule) -: cgm(genModule), context(genModule.getASTContext()) {} +: cgm(genModule), context(genModule.getASTContext()), + builder(cgm.getBuilder()) {}

[clang] [CIR] Infrastructure: class CIRGenBuilderTy; cache CIR types (PR #119037)

2024-12-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: 1 question, else LGTM. @lanza or @bcardosolopes should be the one to approve this, as this is basically all directly CIR related. https://github.com/llvm/llvm-project/pull/119037 ___ cfe-commits mailing list c

[clang] f9e1150 - [Driver] Normalize the baremetal handling of libc++ and runtimes (#101259)

2024-12-06 Thread via cfe-commits
Author: Petr Hosek Date: 2024-12-06T14:02:14-08:00 New Revision: f9e11501841fc602488fea78b88910eab7d4d396 URL: https://github.com/llvm/llvm-project/commit/f9e11501841fc602488fea78b88910eab7d4d396 DIFF: https://github.com/llvm/llvm-project/commit/f9e11501841fc602488fea78b88910eab7d4d396.diff LO

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Jan Voung via cfe-commits
https://github.com/jvoung edited https://github.com/llvm/llvm-project/pull/115051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

2024-12-06 Thread Vladislav Belov via cfe-commits
https://github.com/vbe-sc created https://github.com/llvm/llvm-project/pull/119024 An assertion failure occurs in Clang when attempting to compile such an example: ```c++ template struct MozPromise { class Private; private: int mMagic4 = 42; }; template struct MozPromise::Private : Moz

[clang] [clang][NFC] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

2024-12-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vladislav Belov (vbe-sc) Changes An assertion failure occurs in Clang when attempting to compile such an example: ```c++ template struct MozPromise { class Private; private: int mMagic4 = 42; }; template

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2024-12-06 Thread Momchil Velikov via cfe-commits
momchil-velikov wrote: > Thanks! Does this work need to be based on #118957 and #118961? I rebased it on `main`. It creates a little conflict with https://github.com/llvm/llvm-project/pull/118961 but not a big deal, easy to resolve. https://github.com/llvm/llvm-project/pull/118969

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-06 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH 1/2] update autoconversion functionality to fix erro

[clang-tools-extra] [clang-tidy] Add C++ member function support to custom bugprone-unsafe-functions matches (PR #117165)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: The matching-on-members part looks good, but I don't know about adding the `ShowFullyQualifiedNames` option https://github.com/llvm/llvm-project/pull/117165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [AArch64] Add Neon FP8 conversion intrinsics (PR #119033)

2024-12-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7f4414b2a1a4d9f802a03f56894c406f0fe3e9a9 5c45f4b3cf80e504902bccf9b7526453199070a8 --e

[clang-tools-extra] [clang-tidy] Add C++ member function support to custom bugprone-unsafe-functions matches (PR #117165)

2024-12-06 Thread Julian Schmidt via cfe-commits
@@ -43,7 +43,10 @@ class UnsafeFunctionsCheck : public ClangTidyCheck { private: const std::vector CustomFunctions; - // If true, the default set of functions are reported. + /// If true, the fully qualified name of custom functions will be shown in a + /// note tag. + c

[clang] [llvm] Reimplement constrained 'trunc' using operand bundles (PR #118253)

2024-12-06 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > > llvm.trunc is currently marked IntrNoMem in Intrinsics.td; you'll need to > > update that if you want it to read/modify FP state. (Trying to override the > > default by sticking attributes on top doesn't work properly, as far as I > > know.) > This this the key point

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

2024-12-06 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: > > Better to double check with author who specified those CLOption. > > Do you mean the person that added `CLOption` to these flags? That was > @tarunprabhu, but IIUC that was by mistake; his intention was to extend these > flags only to Flang. That is correct, the intenti

[clang] [CIR] Infrastructure: class CIRGenBuilderTy; cache CIR types (PR #119037)

2024-12-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: David Olsen (dkolsen-pgi) Changes Small infrastructure and background changes to ClangIR. Create class `CIRGenBuilderTy` and its base class `CIRBaseBuilderTy`. These are mostly empty for now, except for what is inherited from `mlir::OpBui

[clang] [Driver] Normalize the baremetal handling of libc++ and runtimes (PR #101259)

2024-12-06 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/101259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/AMDGPU: Set amdgpu-max-num-workgroups to disable Y/Z by default (PR #119009)

2024-12-06 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/119009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Deleting an incomplete enum type is not an error (PR #118455)

2024-12-06 Thread Alexander Kornienko via cfe-commits
alexfh wrote: > PR here https://github.com/llvm/llvm-project/pull/118980 - But I'd love to > understand the actual issue before merging It'll take some time. cvise has reduced the preprocessed input from 13MB to 7.5MB so far. The input is not shareable so far. https://github.com/llvm/llvm-pro

[clang] clang/AMDGPU: Set amdgpu-max-num-workgroups to disable Y/Z by default (PR #119009)

2024-12-06 Thread Matt Arsenault via cfe-commits
arsenm wrote: So this is wrong. It was correct for openmp. Is there a language version we check can where 3d grids were introduced? https://github.com/llvm/llvm-project/pull/119009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [clang-tools-extra] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-06 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118872 >From 30eb50c2fff14d4f79b3f3bd2b36e511bcb2db27 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 5 Dec 2024 22:18:37 +0100 Subject: [PATCH 1/5] [Clang] Warning as error Array Comparisons from C++26 St

[clang-tools-extra] [clang-tidy][NFC] merge same part matchers in return-const-ref-from-parameter (PR #118985)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/118985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Refactor implementation of FP8 types (NFC) (PR #118969)

2024-12-06 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/118969 >From a83b190b25f01843922530d9e409cfb9c0a86c18 Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Fri, 6 Dec 2024 13:09:23 + Subject: [PATCH] [AArch64] Refactor implementation of FP8 types (NFC) *

[clang] [libcxx] [C++20] [Modules] Convert '-fexperimental-modules-reduced-bmi' to '-fmodules-reduced-bmi' (PR #114382)

2024-12-06 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: I still find the current approach wrt the warning to be odd, we would basically force every modules user to change their command line, either by adding the new `-fmodules-reduced-bmi`, or add `-Wno-wathever` to suppress the warning, or just learn to live with the warning I gue

[clang] [flang] [clang][driver] Special care for linker flags in config files (PR #117573)

2024-12-06 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm updated https://github.com/llvm/llvm-project/pull/117573 >From 537a1c6529410d2a8411b39f0072ef5c60ee865d Mon Sep 17 00:00:00 2001 From: Pawel Osmialowski Date: Mon, 25 Nov 2024 14:46:55 + Subject: [PATCH] [clang][driver] Use $ prefix with config file options to

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support (PR #118938)

2024-12-06 Thread Saleem Abdulrasool via cfe-commits
@@ -373,6 +373,13 @@ void ReadFunctionInfo(const uint8_t *&Data, FunctionInfo &Info) { endian::readNext(Data); Info.ResultType = std::string(Data, Data + ResultTypeLen); Data += ResultTypeLen; + + unsigned SwiftReturnOwnershipLength = + endian::readNext(Data);

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread Paul Osmialowski via cfe-commits
@@ -1243,13 +1268,14 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) { // Try parsing configuration file. if (!ContainsError) ContainsError = loadConfigFiles(); - bool HasConfigFile = !ContainsError && (CfgOptions.get() != nullptr); + bool HasConfigFileHead

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm edited https://github.com/llvm/llvm-project/pull/117573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 691e55643daa3470ff19b02a55e3e2503d2de0c9 537a1c6529410d2a8411b39f0072ef5c60ee865d --e

[clang] [RISCV] Merging RISCVToolChain and BareMetal toolchains (PR #118809)

2024-12-06 Thread Petr Hosek via cfe-commits
petrhosek wrote: The `BareMetal` driver currently isn't very idiomatic (compared to other drivers like `Generic_GCC`) and duplicates a lot of the logic that has been already factored out in other drivers. I think this change could be made a lot smaller by doing a clean up first, bringing the `

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread Paul Osmialowski via cfe-commits
pawosm-arm wrote: > The subject (linker flags) is no longer accurate. > > It's better to mention that Add $ for Reworded https://github.com/llvm/llvm-project/pull/117573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/118074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-06 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,96 @@ +//===--- UseSpanFirstLastCheck.cpp - clang-tidy -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-06 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,96 @@ +//===--- UseSpanFirstLastCheck.cpp - clang-tidy -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: > wasting effort would not be the problem (it never is; learning is the goal) - > right now i just dont understand the difference, and therefore dont see the > benefit, as far as i see it would introduce more complicated code to still > handle templates.

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm updated https://github.com/llvm/llvm-project/pull/117573 >From c599850a039d407061fb6b20d7365184a68c9938 Mon Sep 17 00:00:00 2001 From: Pawel Osmialowski Date: Mon, 25 Nov 2024 14:46:55 + Subject: [PATCH] [clang][driver] Use $ prefix with config file options to

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

2024-12-06 Thread Vladislav Belov via cfe-commits
vbe-sc wrote: @glandium, I've provided the fix in this PR (https://github.com/llvm/llvm-project/pull/119024). https://github.com/llvm/llvm-project/pull/118003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand approved this pull request. LGTM now. Thanks for your contribution! https://github.com/llvm/llvm-project/pull/116642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] 030bbc9 - [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (#116642)

2024-12-06 Thread via cfe-commits
Author: anoopkg6 Date: 2024-12-06T23:33:33+01:00 New Revision: 030bbc92a705758f1131fb29cab5be6d6a27dd1f URL: https://github.com/llvm/llvm-project/commit/030bbc92a705758f1131fb29cab5be6d6a27dd1f DIFF: https://github.com/llvm/llvm-project/commit/030bbc92a705758f1131fb29cab5be6d6a27dd1f.diff LOG:

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand closed https://github.com/llvm/llvm-project/pull/116642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread via cfe-commits
github-actions[bot] wrote: @anoopkg6 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang] da65fe1 - Revert "[clang][AArch64] Avoid a crash when a non-reserved register is used (#117419)"

2024-12-06 Thread Igor Kudrin via cfe-commits
Author: Igor Kudrin Date: 2024-12-06T15:10:40-08:00 New Revision: da65fe1c16308cdb71b2fd26aaedc0ce52521ab4 URL: https://github.com/llvm/llvm-project/commit/da65fe1c16308cdb71b2fd26aaedc0ce52521ab4 DIFF: https://github.com/llvm/llvm-project/commit/da65fe1c16308cdb71b2fd26aaedc0ce52521ab4.diff L

[clang] Bug/templated struct debug reference this (PR #119041)

2024-12-06 Thread via cfe-commits
https://github.com/joaosaffran created https://github.com/llvm/llvm-project/pull/119041 None >From f6a7af10669d71251c2235bef5b2625d88fa1d90 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Fri, 6 Dec 2024 01:27:24 + Subject: [PATCH 1/2] Apply DXC fix and add tests --- clang/lib/CodeGen/

[clang] Bug/templated struct debug reference this (PR #119041)

2024-12-06 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/119041 >From f6a7af10669d71251c2235bef5b2625d88fa1d90 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Fri, 6 Dec 2024 01:27:24 + Subject: [PATCH 1/3] Apply DXC fix and add tests --- clang/lib/CodeGen/CGDebu

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread Paul Kirth via cfe-commits
ilovepi wrote: This seems to have broken build bot and Fuchsia's Linux CI https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-host-linux-x64/b8729261510660874657/overview. Would you mind reverting until a fix is ready? https://github.com/llvm/llvm-project/pull/116642 _

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/1

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot8` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/7267 Here is the relevant piece o

[clang-tools-extra] a07e8cd - [clang-tidy] fix false positive in lambda expr for return-const-ref-from-parameter (#118990)

2024-12-06 Thread via cfe-commits
Author: Congcong Cai Date: 2024-12-07T08:31:35+08:00 New Revision: a07e8cdae7727583e20c9dec632a376365a6e209 URL: https://github.com/llvm/llvm-project/commit/a07e8cdae7727583e20c9dec632a376365a6e209 DIFF: https://github.com/llvm/llvm-project/commit/a07e8cdae7727583e20c9dec632a376365a6e209.diff

[clang-tools-extra] [clang-tidy] fix false positive in lambda expr for return-const-ref-from-parameter (PR #118990)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/118990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread Gedare Bloom via cfe-commits
gedare wrote: Without this patch, the test case on `main`: ``` [ RUN ] FormatTest.AlignsAfterOpenBracket /home/gedare/rtems/llvm-project/clang/unittests/Format/FormatTestBase.h:90: Failure Expected equality of these values: ExpectedCode Which is: "void foo(\nvoid (*foobarpntr)(\n

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support (PR #118938)

2024-12-06 Thread via cfe-commits
@@ -373,6 +373,13 @@ void ReadFunctionInfo(const uint8_t *&Data, FunctionInfo &Info) { endian::readNext(Data); Info.ResultType = std::string(Data, Data + ResultTypeLen); Data += ResultTypeLen; + + unsigned SwiftReturnOwnershipLength = + endian::readNext(Data);

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-06 Thread Tex Riddell via cfe-commits
@@ -3606,6 +3613,32 @@ bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, return Result && MIB.constrainAllUses(TII, TRI, RBI); } +bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, + const SPIR

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 commented: I am still confused why your team did not just disable this rule for test folder? It is normal cases that source code and test code have different quality metrics. https://github.com/llvm/llvm-project/pull/115051 ___

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread via cfe-commits
leijurv wrote: Ping :pray: https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support (PR #118938)

2024-12-06 Thread Saleem Abdulrasool via cfe-commits
@@ -373,6 +373,13 @@ void ReadFunctionInfo(const uint8_t *&Data, FunctionInfo &Info) { endian::readNext(Data); Info.ResultType = std::string(Data, Data + ResultTypeLen); Data += ResultTypeLen; + + unsigned SwiftReturnOwnershipLength = + endian::readNext(Data);

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-06 Thread Zhengxing li via cfe-commits
@@ -3606,6 +3613,32 @@ bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, return Result && MIB.constrainAllUses(TII, TRI, RBI); } +bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, + const SPIR

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-06 Thread Zhengxing li via cfe-commits
https://github.com/lizhengxing edited https://github.com/llvm/llvm-project/pull/117781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-06 Thread Tex Riddell via cfe-commits
@@ -3606,6 +3613,32 @@ bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, return Result && MIB.constrainAllUses(TII, TRI, RBI); } +bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, + const SPIR

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/117573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8787bc7 - Revert "[SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (#116642)"

2024-12-06 Thread Ulrich Weigand via cfe-commits
Author: Ulrich Weigand Date: 2024-12-07T00:55:54+01:00 New Revision: 8787bc72a61aa43a6e937647b6797ddb2ff287d2 URL: https://github.com/llvm/llvm-project/commit/8787bc72a61aa43a6e937647b6797ddb2ff287d2 DIFF: https://github.com/llvm/llvm-project/commit/8787bc72a61aa43a6e937647b6797ddb2ff287d2.diff

[clang-tools-extra] [clang-tidy] fix false positive in lambda expr for return-const-ref-from-parameter (PR #118990)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/118990 >From d9f50466850ee966829ce80f273ad9a10aa24489 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Fri, 6 Dec 2024 23:45:56 +0800 Subject: [PATCH] [clang-tidy] fix false positive in lambda expr for return-con

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread Paul Kirth via cfe-commits
ilovepi wrote: @uweigand Thanks for the prompt revert. For reference the Fuchsia bot is just a normal Linux build configured for building Fuchsia in a debian container. The toolchain isn't novel in anyway, except it normally builds with a recent toolchain, and uses the full runtimes build. T

[clang] [Clang] Deleting an incomplete enum type is not an error (PR #118455)

2024-12-06 Thread Mike Hommey via cfe-commits
glandium wrote: cvise has reduced my testcase to ``` union StyleColorFunctionStyleColorFunction *mRaw { delete mRaw ``` ... which is nowhere close to the real thing and nowhere close to legal C++ at all. Well, that definitely shouldn't trigger a crash, though. https://github.com/llvm/llvm-p

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/119044 >From 6233d3dc731ae15368231b9e956379d71e905311 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Fri, 6 Dec 2024 16:52:35 -0700 Subject: [PATCH] [clang-format] Reorder TokenAnnotator::canBreakBefore Move the che

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Gedare Bloom (gedare) Changes Move the checks related to breaking before right braces and right parens earlier to avoid conflicting checks that prevent breaking based on the left-hand token. This allows properly formatting declara

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-06 Thread Tex Riddell via cfe-commits
@@ -3606,6 +3613,32 @@ bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, return Result && MIB.constrainAllUses(TII, TRI, RBI); } +bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, + const SPIR

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 516d6ede122086027baa2288623605a423375e87 6233d3dc731ae15368231b9e956379d71e905311 --e

[clang] afa2fbf - [Reland][clang][AArch64] Avoid a crash when a non-reserved register is used (#117419)

2024-12-06 Thread Igor Kudrin via cfe-commits
Author: Igor Kudrin Date: 2024-12-06T16:13:36-08:00 New Revision: afa2fbf87a8e3fff609fd325c938929c48e94280 URL: https://github.com/llvm/llvm-project/commit/afa2fbf87a8e3fff609fd325c938929c48e94280 DIFF: https://github.com/llvm/llvm-project/commit/afa2fbf87a8e3fff609fd325c938929c48e94280.diff L

[clang-tools-extra] 17a7f20 - [clang-tidy][NFC] merge same part matchers in return-const-ref-from-parameter (#118985)

2024-12-06 Thread via cfe-commits
Author: Congcong Cai Date: 2024-12-07T08:00:11+08:00 New Revision: 17a7f20685de2a275fc2e53a38c5818797fe8a44 URL: https://github.com/llvm/llvm-project/commit/17a7f20685de2a275fc2e53a38c5818797fe8a44 DIFF: https://github.com/llvm/llvm-project/commit/17a7f20685de2a275fc2e53a38c5818797fe8a44.diff

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Please also add an `ASSERT_FALSE` (or just `ASSERT_TRUE(!opt.has_value())`) with a dereference after, to show that there are false-negatives https://github.com/llvm/llvm-project/pull/115051 ___ cfe-co

[clang-tools-extra] [clang-tidy] fix false positive in lambda expr for return-const-ref-from-parameter (PR #118990)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/118990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] merge same part matchers in return-const-ref-from-parameter (PR #118985)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/118985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/115051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >