[clang] [RISCV] Merging RISCVToolChain and BareMetal toolchains (PR #118809)

2024-12-05 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt updated https://github.com/llvm/llvm-project/pull/118809 >From b74795d44846b79252bd3fb1f1e8179311725c74 Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Wed, 13 Nov 2024 02:45:51 -0800 Subject: [PATCH] [RISCV] Merging RISCVToolChain and BareMetal toolchains Cu

[clang] [llvm] [ARM] Add Cortex-A510 CPU for AArch32 (PR #118811)

2024-12-05 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/118811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 FMLAL/FMLALL (Indexed) (PR #118549)

2024-12-05 Thread via cfe-commits
https://github.com/SpencerAbson edited https://github.com/llvm/llvm-project/pull/118549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 FMOPA (PR #118115)

2024-12-05 Thread via cfe-commits
@@ -305,6 +305,21 @@ multiclass sme_outer_product_fp32 sz, ZPRRegOp zpr_ty, string mne def : SME_ZA_Tile_TwoPred_TwoVec_Pat; } +multiclass sme2_fp8_fmopa_za32 { +def NAME : sme_fp_outer_product_inst<0, 0b01, 0b00, TileOp32, ZPR8, mnemonic>, SMEPseudo2Instr { + bit

[clang] [Clang] Improve error for `-fsanitize=function/kcfi -mexecute-only` incompatibility (PR #118816)

2024-12-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Csanád Hajdú (Il-Capitano) Changes The current error message when using the `-fsanitize=function -mexecute-only` flags together points to the target triple as the reason that `-fsanitize=function` is not allowed to be used, even wh

[clang] [Clang] Improve error for `-fsanitize=function/kcfi -mexecute-only` incompatibility (PR #118816)

2024-12-05 Thread Csanád Hajdú via cfe-commits
https://github.com/Il-Capitano created https://github.com/llvm/llvm-project/pull/118816 The current error message when using the `-fsanitize=function -mexecute-only` flags together points to the target triple as the reason that `-fsanitize=function` is not allowed to be used, even when the fun

[clang] f1d81db - [ASTWriter] Do not allocate source location space for module maps used only for textual headers (#116374)

2024-12-05 Thread via cfe-commits
Author: Ilya Biryukov Date: 2024-12-05T15:08:38+01:00 New Revision: f1d81dbd0573502134270495aa43e3ffb3193ab0 URL: https://github.com/llvm/llvm-project/commit/f1d81dbd0573502134270495aa43e3ffb3193ab0 DIFF: https://github.com/llvm/llvm-project/commit/f1d81dbd0573502134270495aa43e3ffb3193ab0.diff

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FDOT LANE instructions (PR #118492)

2024-12-05 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray updated https://github.com/llvm/llvm-project/pull/118492 >From 609cf3fbdb28c155f4b8c787c1e2cb791c8a292f Mon Sep 17 00:00:00 2001 From: Jonathan Thackray Date: Fri, 29 Nov 2024 11:27:03 + Subject: [PATCH 1/4] [AArch64] Add intrinsics for SME FP8 FDOT LANE instru

[clang] [C++20] Destroying delete and deleted destructors (PR #118800)

2024-12-05 Thread via cfe-commits
@@ -23,3 +30,14 @@ struct alignas(Align) B { }; void f(B<__STDCPP_DEFAULT_NEW_ALIGNMENT__> *p) { delete p; } void f(B<__STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2> *p) { delete p; } // expected-error {{deleted}} + +// Ensure that a deleted destructor is acceptable when the selected ov

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-05 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand commented: This now looks good to me (see one inline comment). The only part missing is the doc change as discussed above - can you add this to the PR here? Then it should be good to go. Thanks! https://github.com/llvm/llvm-project/pull/116642 __

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-05 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand edited https://github.com/llvm/llvm-project/pull/116642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Add Cortex-A510 CPU for AArch32 (PR #118811)

2024-12-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Oliver Stannard (ostannard) Changes This core was originally AArch64-only, but the r1p0 revision added optional support for AArch32 at EL0. TRM: https://developer.arm.com/documentation/101604/0103 --- Fu

[clang] [llvm] [ARM] Add Cortex-A510 CPU for AArch32 (PR #118811)

2024-12-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-arm Author: Oliver Stannard (ostannard) Changes This core was originally AArch64-only, but the r1p0 revision added optional support for AArch32 at EL0. TRM: https://developer.arm.com/documentation/101604/0103 --- Full diff: https://github.com/

[clang] [llvm] [ARM] Add Cortex-A510 CPU for AArch32 (PR #118811)

2024-12-05 Thread Oliver Stannard via cfe-commits
https://github.com/ostannard created https://github.com/llvm/llvm-project/pull/118811 This core was originally AArch64-only, but the r1p0 revision added optional support for AArch32 at EL0. TRM: https://developer.arm.com/documentation/101604/0103 >From 78abb36186afa3f46f596af201fe445a7b359fb5

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-05 Thread Ulrich Weigand via cfe-commits
@@ -1,4 +1,4 @@ -//===-- SystemZISelLowering.cpp - SystemZ DAG lowering implementation -===// +//===-- systemzisellowering.cpp - systemz dag lowering implementation -===// uweigand wrote: This seems to be some accidental change? Please remove. https:

[clang] [clang][CodeGen] `sret` args should always point to the `alloca` AS, so use that (PR #114062)

2024-12-05 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/114062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

2024-12-05 Thread Chris White via cfe-commits
whiteio wrote: @Maetveis I've disabled that settings now. Thanks! https://github.com/llvm/llvm-project/pull/116871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

2024-12-05 Thread via cfe-commits
github-actions[bot] wrote: @whiteio Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 FMLAL/FMLALL (PR #118549)

2024-12-05 Thread via cfe-commits
@@ -1965,21 +1987,91 @@ class sme2_mla_long_array_index_base op0, bits<2> op, Operand index_ty, let Inst{20}= !if(!eq(vg_acronym, ""), 0, 1); let Inst{19-16} = Zm; let Inst{14-13} = Rv; - let Inst{12}= 0b1; - let Inst{4-3} = op; let Constraints = "$ZAda

[clang-tools-extra] [NFC] Fix uninitialized scalar field in constructor. (PR #118324)

2024-12-05 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/118324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4443314 - [NFC] Fix uninitialized scalar field in constructor. (#118324)

2024-12-05 Thread via cfe-commits
Author: Zahira Ammarguellat Date: 2024-12-05T07:42:02-05:00 New Revision: 44433147d62ef0b918c8925874a407ecec15193f URL: https://github.com/llvm/llvm-project/commit/44433147d62ef0b918c8925874a407ecec15193f DIFF: https://github.com/llvm/llvm-project/commit/44433147d62ef0b918c8925874a407ecec15193f

[clang-tools-extra] [NFC] Use a move instead of a copy to optimize performance. (PR #118699)

2024-12-05 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/118699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME] Fix bug on SMELd1St1 (PR #118109)

2024-12-05 Thread via cfe-commits
wwwatermiao wrote: Hi, @momchil-velikov, Hi, @CarolineConcatto, it will be great if you help to review this patch as soon as possible! Thank you! https://github.com/llvm/llvm-project/pull/118109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [NFC] Use a move instead of a copy to optimize performance. (PR #118699)

2024-12-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd @llvm/pr-subscribers-clang-tools-extra Author: Zahira Ammarguellat (zahiraam) Changes This is an issue detected by a static analysis tool, --- Full diff: https://github.com/llvm/llvm-project/pull/118699.diff 1 Files Affected: - (modified) clan

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-12-05 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts commented: Thanks, answered the question for the intrinsic. As Chris said, this would definitely needs to have some tests in the spir-v backend. Especially given that the structurizer assumes the selection control mask was always `None`. When splitting edges, or movin

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-12-05 Thread Nathan Gauër via cfe-commits
@@ -2694,19 +2694,49 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register ResVReg, } return MIB.constrainAllUses(TII, TRI, RBI); } - case Intrinsic::spv_loop_merge: - case Intrinsic::spv_selection_merge: { -const auto Opcode = IID == Intrinsic::spv_select

[clang] [clang] Informative error for lifetimebound in decl-spec (PR #118567)

2024-12-05 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. The change looks good to me. https://github.com/llvm/llvm-project/pull/118567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Fix bitcasting from null pointers (PR #116999)

2024-12-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/116999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

2024-12-05 Thread Mészáros Gergely via cfe-commits
Maetveis wrote: > Hey @Maetveis, I've addressed the conflicts 👍 Thanks, ping @AaronBallman or @erichkeane I would appreciate a second look from someone closer to frontend. https://github.com/llvm/llvm-project/pull/116871 ___ cfe-commits mailing lis

[clang] [clang][CodeGen] `sret` args should always point to the `alloca` AS, so use that (PR #114062)

2024-12-05 Thread Alex Voicu via cfe-commits
@@ -1350,7 +1350,7 @@ bool ItaniumCXXABI::classifyReturnType(CGFunctionInfo &FI) const { // If C++ prohibits us from making a copy, return by address. if (!RD->canPassInRegisters()) { auto Align = CGM.getContext().getTypeAlignInChars(FI.getReturnType()); -FI.getRet

[clang] b6217f6 - [clang][bytecode] Fix bitcasting from null pointers (#116999)

2024-12-05 Thread via cfe-commits
Author: Timm Baeder Date: 2024-12-05T13:13:59+01:00 New Revision: b6217f67a422d2c0e24bcfa80cf663b610a0cfc4 URL: https://github.com/llvm/llvm-project/commit/b6217f67a422d2c0e24bcfa80cf663b610a0cfc4 DIFF: https://github.com/llvm/llvm-project/commit/b6217f67a422d2c0e24bcfa80cf663b610a0cfc4.diff L

[clang] [C++20] Deleting destructors can be noexcept (PR #118687)

2024-12-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/118687 >From 10985bcd5ae13f4533a9df4fa3035bd49e49af15 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 4 Dec 2024 14:31:48 -0500 Subject: [PATCH 1/4] [C++20] Deleting destructors can be noexcept Given a `n

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-12-05 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts edited https://github.com/llvm/llvm-project/pull/116331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-format] Add cmake target clang-format-style-options for updating ClangFormatStyleOptions.rst (PR #111513)

2024-12-05 Thread via cfe-commits
Andarwinux wrote: If CLANG_INCLUDE_DOCS=OFF then this should be skipped, otherwise the build will fail if llvm/clang/docs doesn't exist. https://github.com/llvm/llvm-project/pull/111513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] (reland) [clang] Warn [[clang::lifetimebound]] misusages on types (PR #118501)

2024-12-05 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/118501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Handle bitcasts involving bitfields (PR #116843)

2024-12-05 Thread Nikita Popov via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: nikic wrote: It looks like this still fails on i386 after the reapply: ``` RUN: at line 1: /builddir/build/BUILD/llvm-20.0.0_pre20241205.gb86a5993bc7be5-build/llvm-project-b86a5993bc7be59b49879a0e768f53b7330f71b2/llvm/r

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-05 Thread Helmut Januschka via cfe-commits
@@ -18,108 +18,77 @@ using namespace clang::ast_matchers; namespace clang::tidy::readability { void UseSpanFirstLastCheck::registerMatchers(MatchFinder *Finder) { - // Match span::subspan calls const auto HasSpanType = hasType(hasUnqualifiedDesugaredType(recordType(

[clang] [PAC][Driver] Add `-faarch64-jump-table-hardening` flag (PR #113149)

2024-12-05 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 closed https://github.com/llvm/llvm-project/pull/113149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Fix bitcasting from null pointers (PR #116999)

2024-12-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/116999 >From c9c39e81e3fae1351691feaf99528997114810cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 20 Nov 2024 17:14:01 +0100 Subject: [PATCH] [clang][bytecode] Fix bitcasting from null poin

[clang] [Clang] Add "extend lifetime" flags and release note (PR #110000)

2024-12-05 Thread Stephen Tozer via cfe-commits
https://github.com/SLTozer updated https://github.com/llvm/llvm-project/pull/11 >From 6a873f5c487a936344f6cd226b7d525b406f34b2 Mon Sep 17 00:00:00 2001 From: Stephen Tozer Date: Wed, 25 Sep 2024 15:08:39 +0100 Subject: [PATCH 1/4] [Clang] Add "extend lifetime" flags and release note Follow

[clang] [ASTWriter] Do not allocate source location space for module maps used only for textual headers (PR #116374)

2024-12-05 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/116374 >From ff328f256824e30b2c3c8db184a0fcafaef32637 Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Fri, 15 Nov 2024 11:18:21 +0100 Subject: [PATCH 1/5] [ASTWriter] Do not allocate source location space for

[clang] [clang] Add source range to 'use of undeclared identifier' diagnostics (PR #117671)

2024-12-05 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/117671 >From a55f27b1c479c91807254bd3f62a1771323d9fe1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 26 Nov 2024 08:44:57 +0100 Subject: [PAT

[clang-tools-extra] [clangd] Store full decl/def range with symbol locations (PR #118102)

2024-12-05 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/118102 >From c44237813fb3357dee3f7d17048a7178e67a2422 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 27 Nov 2024 13:47:32 +0100 Subject: [PATCH] [clangd] Store full decl/def range with symbol locations

[clang] 17dfdd3 - [clang][bytecode][tests] Specify triple in bitfields tests

2024-12-05 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-12-05T11:10:58+01:00 New Revision: 17dfdd3a86e0759ce67e54ca53f6174769ed7285 URL: https://github.com/llvm/llvm-project/commit/17dfdd3a86e0759ce67e54ca53f6174769ed7285 DIFF: https://github.com/llvm/llvm-project/commit/17dfdd3a86e0759ce67e54ca53f6174769ed7285.diff LO

[clang] [clang] Informative error for lifetimebound in decl-spec (PR #118567)

2024-12-05 Thread Ilya Biryukov via cfe-commits
@@ -3703,8 +3703,14 @@ void Parser::ParseDeclarationSpecifiers( // We reject AT_LifetimeBound and AT_AnyX86NoCfCheck, even though they // are type attributes, because we historically haven't allowed these // to be used as type attributes in C++11

[clang] [llvm] [clang-format] Add cmake target clang-format-style-options for updating ClangFormatStyleOptions.rst (PR #111513)

2024-12-05 Thread Nikita Popov via cfe-commits
nikic wrote: Reverted this because it breaks a the build. I initially assumed this is due to disabled docs per the previous comment, but I think in my case the problem is actually that this seems to be trying to write to the source directory, which is forbidden. If you need to write out files,

[clang] [llvm] [clang-format] Add cmake target clang-format-style-options for updating ClangFormatStyleOptions.rst (PR #111513)

2024-12-05 Thread Nikita Popov via cfe-commits
nikic wrote: Reading back here, the general thing you are trying to do here is not allowed. At best you can add this as a manually invoked target that is not implicitly called by anything else. Though the actually correct way to handle this is what was proposed in https://github.com/llvm/llvm-

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FDOT LANE instructions (PR #118492)

2024-12-05 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray updated https://github.com/llvm/llvm-project/pull/118492 >From 609cf3fbdb28c155f4b8c787c1e2cb791c8a292f Mon Sep 17 00:00:00 2001 From: Jonathan Thackray Date: Fri, 29 Nov 2024 11:27:03 + Subject: [PATCH 1/3] [AArch64] Add intrinsics for SME FP8 FDOT LANE instru

[clang] [llvm] [RISCV] Add stack clash protection (PR #117612)

2024-12-05 Thread Raphael Moreira Zinsly via cfe-commits
@@ -580,25 +580,134 @@ static MCCFIInstruction createDefCFAOffset(const TargetRegisterInfo &TRI, Comment.str()); } +// Allocate stack space and probe it if necessary. void RISCVFrameLowering::allocateStack(MachineBasicBlock &MBB,

[clang] [llvm] [RISCV] Add stack clash protection (PR #117612)

2024-12-05 Thread Raphael Moreira Zinsly via cfe-commits
@@ -1910,3 +2023,72 @@ bool RISCVFrameLowering::isSupportedStackID(TargetStackID::Value ID) const { TargetStackID::Value RISCVFrameLowering::getStackIDForScalableVectors() const { return TargetStackID::ScalableVector; } + +// Synthesize the probe loop. +static void emitStack

[clang] [llvm] [RISCV] Add stack clash protection (PR #117612)

2024-12-05 Thread Raphael Moreira Zinsly via cfe-commits
@@ -157,6 +159,9 @@ class RISCVMachineFunctionInfo : public MachineFunctionInfo { bool isVectorCall() const { return IsVectorCall; } void setIsVectorCall() { IsVectorCall = true; } + + bool hasStackProbing() const { return StackProbeSize != 0; } rzinsly

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-05 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin commented: Updated PR https://github.com/llvm/llvm-project/pull/111992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [Clang] Rename GPU intrinsic functions from `__gpu_` to `_gpu_` (PR #118674)

2024-12-05 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: I'm not opposed, but it doesn't seem particularly well-motivated to me as I think the only real motivation is to work around a frustrating behavior in clangd. I think double underscores are more well understood by users to be reserved names. https://github.com/llvm/llvm-pr

[clang] [SYCL] Change SYCL version according to standard (PR #114790)

2024-12-05 Thread Alexey Bader via cfe-commits
https://github.com/bader closed https://github.com/llvm/llvm-project/pull/114790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Make the `CHECK` lines here resistent to `chandlerc` (PR #118736)

2024-12-05 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc closed https://github.com/llvm/llvm-project/pull/118736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] Change SYCL version according to standard (PR #114790)

2024-12-05 Thread via cfe-commits
github-actions[bot] wrote: @dklochkov-emb Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[clang] [llvm] [RISCV] Add stack clash protection (PR #117612)

2024-12-05 Thread Raphael Moreira Zinsly via cfe-commits
@@ -580,25 +580,134 @@ static MCCFIInstruction createDefCFAOffset(const TargetRegisterInfo &TRI, Comment.str()); } +// Allocate stack space and probe it if necessary. void RISCVFrameLowering::allocateStack(MachineBasicBlock &MBB,

[libclc] [libclc] Move several integer functions to CLC library (PR #116786)

2024-12-05 Thread Fraser Cormack via cfe-commits
@@ -0,0 +1,21 @@ +#ifndef __CLC_INTEGER_CLC_CLZ_H__ +#define __CLC_INTEGER_CLC_CLZ_H__ + +#if defined(CLC_CLSPV) || defined(CLC_SPIRV) +// clspv and spir-v targets provide their own OpenCL-compatible clz +#define __clc_clz clz frasercrmck wrote: > On the `clspv`

[clang] [C++20] Destroying delete and deleted destructors (PR #118800)

2024-12-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/118800 >From 34d3d3000bc6096bbc9eb35ce85b6ceca50b91ca Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 5 Dec 2024 08:31:24 -0500 Subject: [PATCH 1/4] [C++20] Destroying delete and deleted destructors When

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-05 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/111992 >From 3eaaa7d70f4b57cc13bd00bd3a3a921f7914d599 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 11 Oct 2024 05:35:18 -0700 Subject: [PATCH 1/6] [C++20][Modules] Load function body from the module tha

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-05 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin edited https://github.com/llvm/llvm-project/pull/111992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-05 Thread Dmitry Polukhin via cfe-commits
@@ -1976,14 +1976,16 @@ TemplateDeclInstantiator::VisitFunctionTemplateDecl(FunctionTemplateDecl *D) { if (!InstParams) return nullptr; + // Use canonical templated decl because only canonical decl has body + // if declarations were merged during loading from modules.

[clang] [llvm] [RISCV] Add stack clash protection (PR #117612)

2024-12-05 Thread Raphael Moreira Zinsly via cfe-commits
https://github.com/rzinsly updated https://github.com/llvm/llvm-project/pull/117612 >From 9872154335da3b6f80c0ceb2d5756a99fb78df08 Mon Sep 17 00:00:00 2001 From: Raphael Moreira Zinsly Date: Mon, 25 Nov 2024 14:51:35 -0300 Subject: [PATCH 1/2] [RISCV] Add initial stack clash protection Enable

[clang] [llvm] [RISCV] Add stack clash protection (PR #117612)

2024-12-05 Thread Craig Topper via cfe-commits
@@ -0,0 +1,537 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv64 -mattr=+m -O2 < %s \ +; RUN: | FileCheck %s -check-prefix=RV64I +; RUN: llc -mtriple=riscv32 -mattr=+m -O2 < %s \ +; RUN: | FileCheck %s -check-prefix=

[clang] [HLSL] Implement HLSL Flat casting (excluding splat cases) (PR #118842)

2024-12-05 Thread Sarah Spall via cfe-commits
https://github.com/spall edited https://github.com/llvm/llvm-project/pull/118842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement HLSL Flat casting (excluding splat cases) (PR #118842)

2024-12-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-hlsl Author: Sarah Spall (spall) Changes Implement HLSL Flat casting excluding splat cases Partly closes #100609 and #100619 --- Patch is 40.86 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-p

[clang] 6b07853 - [SYCL] Change SYCL version according to standard (#114790)

2024-12-05 Thread via cfe-commits
Author: dklochkov-intel Date: 2024-12-05T10:16:45-08:00 New Revision: 6b0785390d02193d81d8db7fb12279ffa4651afe URL: https://github.com/llvm/llvm-project/commit/6b0785390d02193d81d8db7fb12279ffa4651afe DIFF: https://github.com/llvm/llvm-project/commit/6b0785390d02193d81d8db7fb12279ffa4651afe.dif

[libclc] [libclc] Move several integer functions to CLC library (PR #116786)

2024-12-05 Thread Romaric Jodin via cfe-commits
@@ -0,0 +1,21 @@ +#ifndef __CLC_INTEGER_CLC_CLZ_H__ +#define __CLC_INTEGER_CLC_CLZ_H__ + +#if defined(CLC_CLSPV) || defined(CLC_SPIRV) +// clspv and spir-v targets provide their own OpenCL-compatible clz +#define __clc_clz clz rjodinchr wrote: I don't think the s

[clang] 1e5c1a3 - Make the `CHECK` lines here resistent to `chandlerc` (#118736)

2024-12-05 Thread via cfe-commits
Author: Chandler Carruth Date: 2024-12-05T10:17:15-08:00 New Revision: 1e5c1a342e87961513da84a55cb7a3c3ba22b354 URL: https://github.com/llvm/llvm-project/commit/1e5c1a342e87961513da84a55cb7a3c3ba22b354 DIFF: https://github.com/llvm/llvm-project/commit/1e5c1a342e87961513da84a55cb7a3c3ba22b354.di

[libunwind] [libunwind] Fix a typo in debug print (PR #118856)

2024-12-05 Thread Sergei Barannikov via cfe-commits
https://github.com/s-barannikov created https://github.com/llvm/llvm-project/pull/118856 None >From 8af8a8c51955802a58341f32b2990859ee89038b Mon Sep 17 00:00:00 2001 From: Sergei Barannikov Date: Thu, 5 Dec 2024 21:41:36 +0300 Subject: [PATCH] [libunwind] Fix a typo in debug print --- libunw

[libunwind] [libunwind] Fix a typo in debug print (PR #118856)

2024-12-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Sergei Barannikov (s-barannikov) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/118856.diff 1 Files Affected: - (modified) libunwind/src/Unwind-sjlj.c (+1-1) ``diff diff --git a/libunwind/src/Unwind-sjl

[clang] cb6a02a - [OpenACC] Implement 'worker' clause for combined constructs

2024-12-05 Thread via cfe-commits
Author: erichkeane Date: 2024-12-05T10:43:52-08:00 New Revision: cb6a02abe21fb399e86863dd69e865d0ddaa6838 URL: https://github.com/llvm/llvm-project/commit/cb6a02abe21fb399e86863dd69e865d0ddaa6838 DIFF: https://github.com/llvm/llvm-project/commit/cb6a02abe21fb399e86863dd69e865d0ddaa6838.diff LO

[libunwind] [libunwind] Fix a typo in debug print (PR #118856)

2024-12-05 Thread Sergei Barannikov via cfe-commits
s-barannikov wrote: Spent quite a time tracking a non-existent address >_< https://github.com/llvm/llvm-project/pull/118856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement HLSL Flat casting (excluding splat cases) (PR #118842)

2024-12-05 Thread Sarah Spall via cfe-commits
https://github.com/spall edited https://github.com/llvm/llvm-project/pull/118842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 51a5b77 - [Webkit Checkers] Introduce a Webkit checker for memory unsafe casts (#114606)

2024-12-05 Thread via cfe-commits
Author: Rashmi Mudduluru Date: 2024-12-05T11:01:27-08:00 New Revision: 51a5b77b57ab3061f4a7fbcf858d7304cd9ccdce URL: https://github.com/llvm/llvm-project/commit/51a5b77b57ab3061f4a7fbcf858d7304cd9ccdce DIFF: https://github.com/llvm/llvm-project/commit/51a5b77b57ab3061f4a7fbcf858d7304cd9ccdce.di

[clang] [Webkit Checkers] Introduce a Webkit checker for memory unsafe casts (PR #114606)

2024-12-05 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud closed https://github.com/llvm/llvm-project/pull/114606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Migrate visitors in ARCMigrate (PR #116792)

2024-12-05 Thread via cfe-commits
Sirraide wrote: > this is now dead code, and we intend to open a PR to remove it Alright, in that case, I’ll close this and go ahead and open a PR myself to remove it myself while I’m at it. https://github.com/llvm/llvm-project/pull/116792 ___ cfe-co

[clang] [Clang] [NFC] Migrate visitors in ARCMigrate (PR #116792)

2024-12-05 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/116792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support to APINotes (PR #118938)

2024-12-05 Thread via cfe-commits
https://github.com/fahadnayyar created https://github.com/llvm/llvm-project/pull/118938 Adding support to APINotes to annotate C++ methods and functions with `swift_attr("returns_retained")` and `swift_attr("returns_unretained")` rdar://141007510 >From 3785e5cedbf2434566a62b7750a7ec48ccaa1fe1

[clang] e25c556 - [clang-format][NFC] Reformat git-clang-format with `black -l80`

2024-12-05 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-12-05T23:18:24-08:00 New Revision: e25c556abeb9ae5f82da42cd26b9dae8462a7197 URL: https://github.com/llvm/llvm-project/commit/e25c556abeb9ae5f82da42cd26b9dae8462a7197 DIFF: https://github.com/llvm/llvm-project/commit/e25c556abeb9ae5f82da42cd26b9dae8462a7197.diff LOG:

[clang] [clang-format] Add test to ensure formatting options docs are updated (PR #118154)

2024-12-05 Thread Mikael Holmén via cfe-commits
mikaelholmen wrote: Thanks! https://github.com/llvm/llvm-project/pull/118154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-05 Thread Chandler Carruth via cfe-commits
@@ -41,6 +41,10 @@ class LLVM_LIBRARY_VISIBILITY ARCTargetInfo : public TargetInfo { MacroBuilder &Builder) const override; ArrayRef getTargetBuiltins() const override { return {}; } chandlerc wrote: Doh, yes. I meant to remove the

[clang] [llvm] Implement operand bundles for floating-point operations (PR #109798)

2024-12-05 Thread Serge Pavlov via cfe-commits
@@ -273,29 +306,6 @@ void InstrProfCallsite::setCallee(Value *Callee) { setArgOperand(4, Callee); } -std::optional ConstrainedFPIntrinsic::getRoundingMode() const { - unsigned NumOperands = arg_size(); - Metadata *MD = nullptr; - auto *MAV = dyn_cast(getArgOperand(NumOper

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-05 Thread Craig Topper via cfe-commits
@@ -41,6 +41,10 @@ class LLVM_LIBRARY_VISIBILITY ARCTargetInfo : public TargetInfo { MacroBuilder &Builder) const override; ArrayRef getTargetBuiltins() const override { return {}; } topperc wrote: Should this override of getTargetB

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-05 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/118734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-05 Thread Malavika Samak via cfe-commits
@@ -433,37 +433,36 @@ AST_MATCHER(ArraySubscriptExpr, isSafeArraySubscript) { //already duplicated // - call both from Sema and from here - const auto *BaseDRE = - dyn_cast(Node.getBase()->IgnoreParenImpCasts()); - const auto *SLiteral = - dyn_cast(Node.ge

[clang] [clang][AArch64] Avoid a crash when a non-reserved register is used (PR #117419)

2024-12-05 Thread KAWASHIMA Takahiro via cfe-commits
https://github.com/kawashima-fj approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/117419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-05 Thread Malavika Samak via cfe-commits
@@ -8,6 +8,5 @@ // main function int main(int argc, char *argv[]) { // expected-warning{{'argv' is an unsafe pointer used for buffer access}} char tmp; - tmp = argv[5][5];// expected-note{{used in buffer access here}} \ -

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-05 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak edited https://github.com/llvm/llvm-project/pull/118249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reimplement constrained 'trunc' using operand bundles (PR #118253)

2024-12-05 Thread Kevin P. Neal via cfe-commits
@@ -251,10 +251,12 @@ static bool markTails(Function &F, OptimizationRemarkEmitter *ORE) { // Special-case operand bundles "clang.arc.attachedcall", "ptrauth", and // "kcfi". kpneal wrote: This comment needs to be updated. I suggest removing the

[clang] [clang][ARM] disable frame pointers by default for bare metal ARM targets (PR #117140)

2024-12-05 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/117140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add stack clash protection (PR #117612)

2024-12-05 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/117612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] Destroying delete can cause a type to be noexcept when deleting (PR #118687)

2024-12-05 Thread Richard Smith via cfe-commits
zygoloid wrote: Hm, the issue raised in #118800 is relevant here too, isn't it? If the destructor is virtual, we want to look at its exception specification, not the one on the destroying operator delete, because `delete p` actually invokes the virtual deleting destructor, not the statically s

[clang] [clang-format] Add test to ensure formatting options docs are updated (PR #118154)

2024-12-05 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > Hm, or it's not related to the testcase, but it happens every time we build > now due to > https://github.com/llvm/llvm-project/commit/6bec1806c9cc90f6e72fc04698f4221c86c5f95e That's more likely to be due to #111513. That got reverted. If it's still an issue here, let

[clang] [CIR] Integral types; simple global variables (PR #118743)

2024-12-05 Thread David Olsen via cfe-commits
@@ -0,0 +1,27 @@ +//===- CIRTypes.h - MLIR CIR Types --*- C++ -*-===// dkolsen-pgi wrote: Done. https://github.com/llvm/llvm-project/pull/118743 ___ cfe-commits mailing list cfe-commits@li

[clang] [CIR] Integral types; simple global variables (PR #118743)

2024-12-05 Thread David Olsen via cfe-commits
@@ -85,14 +115,15 @@ class CIR_Op traits = []> : def FuncOp : CIR_Op<"func"> { let summary = "Declare or define a function"; let description = [{ -... lots of text to be added later ... +THe `cir.func` operation defines a function, similar to the `mlir::FuncOp`

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-12-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/117491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-12-05 Thread Louis Dionne via cfe-commits
ldionne wrote: Since we support only the latest released GCC in the runtimes, so I don't think it makes sense to merge this. Newer GCCs don't seem to have this issue. Closing, please reopen if you'd like to pursue this despite the above information and we can chat. https://github.com/llvm/llv

[clang] [Clang] Diagnose down casting static_cast (PR #117914)

2024-12-05 Thread Julian Schmidt via cfe-commits
5chmidti wrote: > I think the checker can be removed if clang has this kind of compilation time > warning and can totally cover the checker. It only covers the whole check if `StrictMode` is not set to `false`, because that enables diagnosing down-casts for non-polymorphic types as well. > Pe

[clang] [llvm] Reimplement constrained 'trunc' using operand bundles (PR #118253)

2024-12-05 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: llvm.trunc is currently marked IntrNoMem in Intrinsics.td; you'll need to update that if you want it to read/modify FP state. (Trying to override the default by sticking attributes on top doesn't work properly, as far as I know.) https://github.com/llvm/llvm-project/pull/

<    1   2   3   4   >