[clang-tools-extra] [clang-tidy] Add recursion protection in ExceptionSpecAnalyzer (PR #66810)

2024-12-01 Thread Carlos Galvez via cfe-commits
@@ -0,0 +1,8 @@ +// RUN: %check_clang_tidy -std=c++17 -expect-clang-tidy-error %s performance-noexcept-move-constructor %t carlosgalvezp wrote: Does this need to be a separate file? Can't we just have it in an existing test, inside `namespace PRX`? https

[clang-tools-extra] [clang-tidy] Add recursion protection in ExceptionSpecAnalyzer (PR #66810)

2024-12-01 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: LGTM, had a small comment. Not sure it's worth mentioning this in the releases notes, it's just a crash fix. But it doesn't hurt I guess. https://github.com/llvm/llvm-project/pull/66810 ___ cfe-commits mailing list cfe-commits@lis

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-01 Thread Jonas Toth via cfe-commits
JonasToth wrote: @PiotrZSL I did assign you as reviewer because I noticed you do many reviews. Please remove yourself if that was not appropriate. I did not contribute to clang-tidy for a longer period and not sure who to assign (if any!) for the PR. It was not meant offensively or so :) https

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-01 Thread via cfe-commits
https://github.com/EugeneZelenko unassigned https://github.com/llvm/llvm-project/pull/118209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy][use-internal-linkage]fix false positives for ExportDecl (PR #117901)

2024-12-01 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/117901 >From d1d0722e833a9b66206c008a4cd3f6c5b4548b5c Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 27 Nov 2024 23:08:55 +0800 Subject: [PATCH 1/6] [ast-matcher] add `exportDecl` matcher --- clang/docs/R

[clang] [clang-tools-extra] [clang-tidy][use-internal-linkage]fix false positives for ExportDecl (PR #117901)

2024-12-01 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/117901 >From d1d0722e833a9b66206c008a4cd3f6c5b4548b5c Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 27 Nov 2024 23:08:55 +0800 Subject: [PATCH 1/5] [ast-matcher] add `exportDecl` matcher --- clang/docs/R

[clang] [flang] [clang][driver] Special care for -l flags in config files (PR #117573)

2024-12-01 Thread Paul Osmialowski via cfe-commits
pawosm-arm wrote: > @pawosm-arm See also > https://wiki.gentoo.org/wiki/Project:Quality_Assurance/As-needed#Importance_of_linking_order. > It is common for distributions to enable `-Wl,--as-needed` via patches to > the compiler or configuration files. Indeed, the distributions couldn't avoid

[clang] [flang] [clang][driver] Special care for -l flags in config files (PR #117573)

2024-12-01 Thread Sam James via cfe-commits
thesamesam wrote: I thought I recognised your name from somewhere ;) Apparently I completely forgot about https://github.com/llvm/llvm-project/issues/67209 too. https://github.com/llvm/llvm-project/pull/117573 ___ cfe-commits mailing list cfe-commits

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-01 Thread Piotr Zegar via cfe-commits
@@ -27,6 +27,29 @@ This check will flag: - All applications of binary operators with a narrowing conversions. For example: ``int i; i+= 0.1;``. +Note that arithmetic with integer types may perform implicit conversions if the used integer types are smaller than ``int``. +T

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-01 Thread Piotr Zegar via cfe-commits
@@ -27,6 +27,29 @@ This check will flag: - All applications of binary operators with a narrowing conversions. For example: ``int i; i+= 0.1;``. +Note that arithmetic with integer types may perform implicit conversions if the used integer types are smaller than ``int``. +T

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-01 Thread Piotr Zegar via cfe-commits
@@ -27,6 +27,29 @@ This check will flag: - All applications of binary operators with a narrowing conversions. For example: ``int i; i+= 0.1;``. +Note that arithmetic with integer types may perform implicit conversions if the used integer types are smaller than ``int``. --

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-01 Thread Piotr Zegar via cfe-commits
@@ -27,6 +27,29 @@ This check will flag: - All applications of binary operators with a narrowing conversions. For example: ``int i; i+= 0.1;``. +Note that arithmetic with integer types may perform implicit conversions if the used integer types are smaller than ``int``. --

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-01 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL requested changes to this pull request. - Formatting - Please think about simplifying this. https://github.com/llvm/llvm-project/pull/118209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-01 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/118209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Allow usage of applyFirst with rewriteDescendants (PR #117658)

2024-12-01 Thread via cfe-commits
https://github.com/SherAndrei updated https://github.com/llvm/llvm-project/pull/117658 >From 5eea9669c455e2b0dacbb4dca34be7dc100711cf Mon Sep 17 00:00:00 2001 From: SherAndrei Date: Tue, 26 Nov 2024 03:30:46 +0300 Subject: [PATCH] [clang][transformer] Allow usage of applyFirst with rewriteDesc

[clang] [clang][transformer] Allow usage of applyFirst with rewriteDescendants (PR #117658)

2024-12-01 Thread via cfe-commits
SherAndrei wrote: @ymand, could you please take a look? https://github.com/llvm/llvm-project/pull/117658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][transformer] Allow usage of applyFirst with rewriteDescendants (PR #117658)

2024-12-01 Thread via cfe-commits
https://github.com/SherAndrei edited https://github.com/llvm/llvm-project/pull/117658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add an off-by-default warning to complain about MSVC bitfield padding (PR #117428)

2024-12-01 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/117428 >From 3e25d7ef2e223942298078dace8979905956d05c Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Fri, 22 Nov 2024 17:53:24 +0100 Subject: [PATCH 1/3] Add an off-by-default warning to complain about MSVC bitfield

[clang] Add an off-by-default warning to complain about MSVC bitfield padding (PR #117428)

2024-12-01 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/117428 >From 3e25d7ef2e223942298078dace8979905956d05c Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Fri, 22 Nov 2024 17:53:24 +0100 Subject: [PATCH 1/4] Add an off-by-default warning to complain about MSVC bitfield

[clang] [clang][bytecode] Support vector-to-vector bitcasts (PR #118230)

2024-12-01 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/9413 Here is the re

[clang] dd0d956 - [clang][bytecode] Support vector-to-vector bitcasts (#118230)

2024-12-01 Thread via cfe-commits
Author: Timm Baeder Date: 2024-12-02T08:20:41+01:00 New Revision: dd0d9561b8945d4128814bd7eda1bc470a1552f7 URL: https://github.com/llvm/llvm-project/commit/dd0d9561b8945d4128814bd7eda1bc470a1552f7 DIFF: https://github.com/llvm/llvm-project/commit/dd0d9561b8945d4128814bd7eda1bc470a1552f7.diff L

[clang] [clang][bytecode] Support vector-to-vector bitcasts (PR #118230)

2024-12-01 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/118230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert [Clang] prevent errors for deduction guides using deduced type aliases (PR #118165)

2024-12-01 Thread Haojian Wu via cfe-commits
https://github.com/hokein commented: The change looks good to me (please wait for @erichkeane review before landing). I’d suggest adding a brief rationale in the commit message instead of just including links, to make it more self-contained. https://github.com/llvm/llvm-project/pull/118165 __

<    1   2