[clang] [clang] Check specialization for annotation (PR #117315)

2024-11-28 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/117315 >From e30ae8a6e0c1df8e33c2add6502342cb269c1cfd Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 22 Nov 2024 11:02:49 + Subject: [PATCH 1/2] [clang] Check specialization for annotation --- clang/lib/S

[clang] 88c2af8 - [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (#116257)

2024-11-28 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-11-28T09:22:05Z New Revision: 88c2af80fac423fc338027c007e1499333f05ddb URL: https://github.com/llvm/llvm-project/commit/88c2af80fac423fc338027c007e1499333f05ddb DIFF: https://github.com/llvm/llvm-project/commit/88c2af80fac423fc338027c007e1499333f05ddb.di

[clang] [clang] Improve the lifetime_capture_by diagnostic on the constructor. (PR #117792)

2024-11-28 Thread Utkarsh Saxena via cfe-commits
@@ -623,6 +623,26 @@ static void visitFunctionCallArguments(IndirectLocalPath &Path, Expr *Call, } if (CheckCoroCall || Callee->getParamDecl(I)->hasAttr()) VisitLifetimeBoundArg(Callee->getParamDecl(I), Arg); +else if (const auto *CaptureAttr = +

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-28 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/116257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve the lifetime_capture_by diagnostic on the constructor. (PR #117792)

2024-11-28 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 approved this pull request. https://github.com/llvm/llvm-project/pull/117792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve the lifetime_capture_by diagnostic on the constructor. (PR #117792)

2024-11-28 Thread Utkarsh Saxena via cfe-commits
@@ -535,6 +535,9 @@ static void visitFunctionCallArguments(IndirectLocalPath &Path, Expr *Call, bool EnableGSLAnalysis = !Callee->getASTContext().getDiagnostics().isIgnored( diag::warn_dangling_lifetime_pointer, SourceLocation()); + bool EnableDanglingCapture = +

[clang] [clang] Format bitfield width diagnostics with thousands-separators (PR #117763)

2024-11-28 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/117763 >From 07b326b59bf9a8e385840a590c5162b9d1914650 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 26 Nov 2024 19:26:32 +0100 Subject: [PAT

[clang] [clang] Format bitfield width diagnostics with thousands-separators (PR #117763)

2024-11-28 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Added a `%format` format specifier although the name isn't too good. https://github.com/llvm/llvm-project/pull/117763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [llvm] [ci] Include a log download link when test report is truncated (PR #117985)

2024-11-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/117985 Now "Download" will be a link to the file so people don't have to know to open the build tab and find the download button. This is a URL from a real build: https://buildkite.com/organizations/llvm-project/

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Sudharsan Veeravalli via cfe-commits
https://github.com/svs-quic created https://github.com/llvm/llvm-project/pull/117987 This extension adds 8 load/store instructions with a scaled index addressing mode. The current spec can be found at: https://github.com/quic/riscv-unified-db/releases/latest This patch adds assembler only sup

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc @llvm/pr-subscribers-clang-driver Author: Sudharsan Veeravalli (svs-quic) Changes This extension adds 8 load/store instructions with a scaled index addressing mode. The current spec can be found at: https://github.com/quic/riscv-unified-db/releases/

[clang] [clang-repl] Use default visibility for symbols while building CompilerInstance against emscripten (PR #116779)

2024-11-28 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 closed https://github.com/llvm/llvm-project/pull/116779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Use default visibility for symbols while building CompilerInstance against emscripten (PR #116779)

2024-11-28 Thread Anutosh Bhat via cfe-commits
anutosh491 wrote: Closing as superseded by https://github.com/llvm/llvm-project/pull/116779 https://github.com/llvm/llvm-project/pull/116779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [clang] Remove unused lambda capture. (PR #117988)

2024-11-28 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/117988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Check specialization for annotation (PR #117315)

2024-11-28 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/117315 >From e30ae8a6e0c1df8e33c2add6502342cb269c1cfd Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 22 Nov 2024 11:02:49 + Subject: [PATCH 1/6] [clang] Check specialization for annotation --- clang/lib/S

[clang] 12ccb62 - [clang] Add a common definition of isPointerLikeType for lifetime analysis (#117315)

2024-11-28 Thread via cfe-commits
Author: Utkarsh Saxena Date: 2024-11-28T17:54:40+05:30 New Revision: 12ccb628da231f3ab751c8e7b759e9920d38510b URL: https://github.com/llvm/llvm-project/commit/12ccb628da231f3ab751c8e7b759e9920d38510b DIFF: https://github.com/llvm/llvm-project/commit/12ccb628da231f3ab751c8e7b759e9920d38510b.diff

[clang] [llvm] [AArch64] Implement intrinsics for F1CVTL/F2CVTL and BF1CVTL/BF2CVTL (PR #116959)

2024-11-28 Thread via cfe-commits
https://github.com/SpencerAbson closed https://github.com/llvm/llvm-project/pull/116959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy][use-internal-linkage]fix false positives for global overloaded operator new and operator delete (PR #117945)

2024-11-28 Thread Congcong Cai via cfe-commits
@@ -43,7 +43,7 @@ void test(void) { } extern void g3(int); // expected-note{{previous declaration is here}} -static void g3(int x) { } // expected-error{{static declaration of 'g3' follows non-static declaration}} +static void g3(int x) { } // expected-error{{static declarati

[clang] [clang] Add a common definition of isPointerLikeType for lifetime analysis (PR #117315)

2024-11-28 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/117315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e4ee970 - [AArch64] Implement intrinsics for F1CVTL/F2CVTL and BF1CVTL/BF2CVTL (#116959)

2024-11-28 Thread via cfe-commits
Author: SpencerAbson Date: 2024-11-28T12:37:02Z New Revision: e4ee970c4b286b472a4c0b0cb43da85f77e97d79 URL: https://github.com/llvm/llvm-project/commit/e4ee970c4b286b472a4c0b0cb43da85f77e97d79 DIFF: https://github.com/llvm/llvm-project/commit/e4ee970c4b286b472a4c0b0cb43da85f77e97d79.diff LOG:

[clang] [clang] Add a common definition of isPointerLikeType for lifetime analysis (PR #117315)

2024-11-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `libc-x86_64-debian-fullbuild-dbg-asan` running on `libc-x86_64-debian-fullbuild` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/171/builds/11264 Here is

[clang-tools-extra] [clang-tidy] modernize-make-shared: Add MakeSmartPtrType option (PR #117529)

2024-11-28 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/117529 >From 9466fb73adfb050e9eac426459c18a7a5bca1982 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Mon, 25 Nov 2024 09:59:21 +0100 Subject: [PATCH 01/15] WIP: [clang-tidy] Add SmartPtrName to MakeSmartPtrCh

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,24 @@ +;Test longjmp load from jmp_buf. +; Frame pointer from Slot 1. +; Jump address from Slot 2. +; Stack Pointer from Slot 4. +; Literal Pool Pointer from Slot 5. + +; RUN: llc < %s -mtriple=s390x-linux-gnu -O2 | FileCheck %s + +@buf = dso_local global [20 x ptr] z

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,323 @@ +; Test for Frame Pointer in first slot in jmp_buf. uweigand wrote: Similar question here. This is a very long test, and only a couple of instructions are tested via CHECK statements. Whatever we want to test here should be done in a much mo

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,89 @@ +;Test longjmp load from jmp_buf. uweigand wrote: We certainly do not need to verify e.g. printf codegen here, so even if we do need the test for some reason, it should be significantly simplified. https://github.com/llvm/llvm-project/pull/116

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,89 @@ +;Test longjmp load from jmp_buf. uweigand wrote: What is the added benefit of this combined test? This seems to have been compiled from a C language test that would be useful to run as *execute* test (which we cannot do here). But here we

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,216 @@ +; Simulate register pressure around setjmp call for double precision +; arguments and return sum of 20 vaiables. It also prints the variables. uweigand wrote: As this is not an executable test, I don't think the printf code-gen tests anythin

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,34 @@ +;Test -mbackchain longjmp load from jmp_buf. +; Frame pointer from Slot 1. +; Jump address from Slot 2. +; Backchain Value from Slot 3. +; Stack Pointer from Slot 4. +; Literal Pool Pointer from Slot 5. + +; RUN: llc < %s -mtriple=s390x-linux-gnu -O2 | FileCheck

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand commented: Some additional comments on the test cases inline. https://github.com/llvm/llvm-project/pull/116642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,24 @@ +;Test longjmp load from jmp_buf. uweigand wrote: Please fix the white spaces. Space after ';', only one space between words. https://github.com/llvm/llvm-project/pull/116642 ___ cfe-commits mailing

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,75 @@ +; Test -mbackchain setjmp store jmp_buf uweigand wrote: See above. https://github.com/llvm/llvm-project/pull/116642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand edited https://github.com/llvm/llvm-project/pull/116642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,145 @@ +; Simulate register pressure around setjmp call for double precision arguments. +; Test assembly of funtion call foo in func() in setjmp if and else part. +; extern foo has 20 argument pointer to double precision. +; Test setjmp store jmp_buf. +; Return addre

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,145 @@ +; Simulate register pressure around setjmp call for double precision arguments. uweigand wrote: Register pressure may indeed be a good reason to have a longer test. Still, the CHECK statements should be auto-generated. Also, even here we s

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,24 @@ +;Test longjmp load from jmp_buf. +; Frame pointer from Slot 1. +; Jump address from Slot 2. +; Stack Pointer from Slot 4. +; Literal Pool Pointer from Slot 5. + +; RUN: llc < %s -mtriple=s390x-linux-gnu -O2 | FileCheck %s + +@buf = dso_local global [20 x ptr] z

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,146 @@ +; -mbackchain option. uweigand wrote: Also, I don't think we need -mbackchain versions of all of those. We have the simple tests above that verify -mbackchain works, we don't need to repeat this for all other tests. https://github.com/llvm

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,47 @@ +; Test setjmp store jmp_buf uweigand wrote: Most of the above longjmp comments apply likewise to the setjmp tests. https://github.com/llvm/llvm-project/pull/116642 ___ cfe-commits mailing list cfe-co

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,24 @@ +;Test longjmp load from jmp_buf. +; Frame pointer from Slot 1. +; Jump address from Slot 2. +; Stack Pointer from Slot 4. +; Literal Pool Pointer from Slot 5. + +; RUN: llc < %s -mtriple=s390x-linux-gnu -O2 | FileCheck %s + +@buf = dso_local global [20 x ptr] z

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,145 @@ +; Simulate register pressure around setjmp call for double precision arguments. uweigand wrote: There doesn't seem to be a -01 test with this name, please rename to remove those gaps. https://github.com/llvm/llvm-project/pull/116642 ___

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,47 @@ +; Test setjmp store jmp_buf +; Return address in slot 2. +; Stack Pointer in slot 4. +; Clobber %r6-%r15, %f8-%f15. + +; RUN: llc < %s -mtriple=s390x-linux-gnu -O3 | FileCheck %s + +@buf = dso_local global [20 x ptr] zeroinitializer, align 8 + +; Function Attrs

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,215 @@ +; Simulate register pressure around setjmp call for integer arguments and +; return sum of 20 vaiables. It also prints the variables. uweigand wrote: See above comments on the -double tests. https://github.com/llvm/llvm-project/pull/116642 _

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,24 @@ +;Test longjmp load from jmp_buf. +; Frame pointer from Slot 1. +; Jump address from Slot 2. +; Stack Pointer from Slot 4. +; Literal Pool Pointer from Slot 5. + +; RUN: llc < %s -mtriple=s390x-linux-gnu -O2 | FileCheck %s + +@buf = dso_local global [20 x ptr] z

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,145 @@ +; Simulate register pressure around setjmp call for double precision arguments. +; Test assembly of funtion call foo in func() in setjmp if and else part. +; extern foo has 20 argument pointer to double precision. +; Test setjmp store jmp_buf. +; Return addre

[clang] [llvm] [AArch64] Implement intrinsics for F1CVTL/F2CVTL and BF1CVTL/BF2CVTL (PR #116959)

2024-11-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `libc-x86_64-debian-fullbuild-dbg` running on `libc-x86_64-debian-fullbuild` while building `clang,llvm` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/179/builds/11252 Here is

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-11-28 Thread Alex Bradbury via cfe-commits
asb wrote: > RFC: > https://discourse.llvm.org/t/rfc-risc-v-add-support-for-mips-p8700-cpu/83365 Thank you Djordje - I've left some high level comments in response to your RFC post https://github.com/llvm/llvm-project/pull/117865 ___ cfe-commits ma

[clang-tools-extra] [clang-tidy] modernize-make-shared: Add MakeSmartPtrType option (PR #117529)

2024-11-28 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/117529 >From 9466fb73adfb050e9eac426459c18a7a5bca1982 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Mon, 25 Nov 2024 09:59:21 +0100 Subject: [PATCH 01/14] WIP: [clang-tidy] Add SmartPtrName to MakeSmartPtrCh

[clang] [Clang][AST] Fix PackIndexingExpr AST printout (PR #117947)

2024-11-28 Thread via cfe-commits
cor3ntin wrote: This change needs a release note. Please add an entry to `clang/docs/ReleaseNotes.rst` in the section the most adapted to the change, and referencing any Github issue this change fixes. https://github.com/llvm/llvm-project/pull/117947 ___

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Sam Elliott via cfe-commits
https://github.com/lenary edited https://github.com/llvm/llvm-project/pull/117987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Sam Elliott via cfe-commits
@@ -771,9 +772,11 @@ Error RISCVISAInfo::checkDependency() { return getIncompatibleError("xwchc", "zcb"); } - if (Exts.count("xqcicsr") != 0 && (XLen != 32)) { -return getError("'xqcicsr' is only supported for 'rv32'"); - } + for (auto Ext : XqciExts) +if (E

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Sam Elliott via cfe-commits
@@ -22,6 +22,28 @@ // Instruction Class Templates //===--===// +let hasSideEffects = 0, mayLoad = 1, mayStore = 0 in { +class QCILoad_ScaleIdx func4, string opcodestr> +: RVInstRBase<0b111, OPC_CUSTOM_0,

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Sam Elliott via cfe-commits
https://github.com/lenary commented: The encodings and functionality here are correct, but we're missing a test and it would be good to add a comment to the scaled store tablegen class. https://github.com/llvm/llvm-project/pull/117987 ___ cfe-commits

[clang] [clang] Move warning about memset/memcpy to NonTriviallyCopyable type… (PR #117387)

2024-11-28 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/117387 >From fda70bc5aeabe33fc578fbb2f55bc805a3304059 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Fri, 22 Nov 2024 22:38:23 +0100 Subject: [PATCH 1/3] [clang] Move warning about memset/memcpy to N

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-11-28 Thread Ulrich Weigand via cfe-commits
@@ -0,0 +1,34 @@ +;Test -mbackchain longjmp load from jmp_buf. +; Frame pointer from Slot 1. +; Jump address from Slot 2. +; Backchain Value from Slot 3. +; Stack Pointer from Slot 4. +; Literal Pool Pointer from Slot 5. + +; RUN: llc < %s -mtriple=s390x-linux-gnu -O2 | FileCheck

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

2024-11-28 Thread via cfe-commits
@@ -266,7 +265,7 @@ class RenameLocFinder : public RecursiveASTVisitor { return true; } - bool VisitDeclRefExpr(const DeclRefExpr *Expr) { cor3ntin wrote: This makes sense but it is not amazing. How hard do you think it would be to introduce something

[clang] [clang] Move warning about memset/memcpy to NonTriviallyCopyable type… (PR #117387)

2024-11-28 Thread via cfe-commits
https://github.com/zmodem approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/117387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AST] Fix MS Mangle concept uneval context template instantiation crash (PR #117845)

2024-11-28 Thread via cfe-commits
cor3ntin wrote: > The fix LGTM. I do wonder if the test should live in CodeGen/ instead, but I > don't have a strong feeling about this (AST/ already seems to have some > codegen tests). Moving the test would be more consistent indeed https://github.com/llvm/llvm-project/pull/117845 _

[clang] [clang] NFC, simplify the attr-lifetime-capture-by.test (PR #118001)

2024-11-28 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/118001 None >From feb9445efffa69c158407bda6f5981a033197567 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Thu, 28 Nov 2024 14:27:23 +0100 Subject: [PATCH] [clang] NFC, simplify the attr-lifetime-capture-by.test ---

[clang] [clang] NFC, simplify the attr-lifetime-capture-by.test (PR #118001)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/118001.diff 1 Files Affected: - (modified) clang/test/AST/attr-lifetime-capture-by.cpp (+28-38) ``diff diff --git a/clang/test/AST/attr-lif

[clang-tools-extra] [clang-tidy][use-internal-linkage]fix false positives for global overloaded operator new and operator delete (PR #117945)

2024-11-28 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/117945 >From a3ca8316f9a64b89631226015f75aa3a627735a0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 28 Nov 2024 08:15:34 +0800 Subject: [PATCH] [clang-tidy][use-internal-linkage]fix false positives for gl

[clang] [clang-tools-extra] [clang-tidy][use-internal-linkage]fix false positives for ExportDecl (PR #117901)

2024-11-28 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/117901 >From d1d0722e833a9b66206c008a4cd3f6c5b4548b5c Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 27 Nov 2024 23:08:55 +0800 Subject: [PATCH 1/4] [ast-matcher] add `exportDecl` matcher --- clang/docs/R

[clang-tools-extra] [clang-tidy][use-internal-linkage]fix false positives for global overloaded operator new and operator delete (PR #117945)

2024-11-28 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/117945 >From 7d0f420940240cf8522269fdde3682ff1f5d03e6 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 28 Nov 2024 08:15:34 +0800 Subject: [PATCH] [clang-tidy][use-internal-linkage]fix false positives for gl

[clang] [clang] NFC, simplify the attr-lifetime-capture-by.test (PR #118001)

2024-11-28 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 commented: Can you not remove the check-not. It makes sure we are matching all the capture by attr. https://github.com/llvm/llvm-project/pull/118001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2024-11-28 Thread via cfe-commits
cor3ntin wrote: By the time we are in Sema, the ranges should be correct. I think the issue is somewhere in `Parser::ParseLambdaIntroducer`. It does seem quite confused https://gcc.godbolt.org/z/h7rfEGnMb In particular, can you check whether `SourceLocation LocEnd = PrevTokLocation;` behave co

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

2024-11-28 Thread Vladislav Belov via cfe-commits
https://github.com/vbe-sc created https://github.com/llvm/llvm-project/pull/118003 Unlike the previous version, this patch also removes an unnecessary assert that causes Clang to crash when compiling such tests. (clang/lib/AST/DeclCXX.cpp) https://lab.llvm.org/buildbot/#/builders/52/builds/402

[clang] [Serialization] Downgrade error to warning for inconsistent language flags (PR #117840)

2024-11-28 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: I think this is too risky to become the default. We could map out what are the most user affecting compat issues here, and start from there, without opening the floodgates all at once. https://github.com/llvm/llvm-project/pull/117840

[clang] [llvm] [PowerPC] Update data layout aligment of i128 to 16 (PR #118004)

2024-11-28 Thread Lei Huang via cfe-commits
https://github.com/lei137 created https://github.com/llvm/llvm-project/pull/118004 Fix 64-bit PowerPC part of https://github.com/llvm/llvm-project/issues/102783. >From 6abea65c2667ecc0389c95e8a5527c360317524b Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Wed, 27 Nov 2024 18:44:38 + Subjec

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vladislav Belov (vbe-sc) Changes Unlike the previous version, this patch also removes an unnecessary assert that causes Clang to crash when compiling such tests. (clang/lib/AST/DeclCXX.cpp) https://lab.llvm.org/buildbot/#/builders/52/buil

[clang] [llvm] [PowerPC] Update data layout aligment of i128 to 16 (PR #118004)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Lei Huang (lei137) Changes Fix 64-bit PowerPC part of https://github.com/llvm/llvm-project/issues/102783. --- Full diff: https://github.com/llvm/llvm-project/pull/118004.diff 9 Files Affected: - (modified) clang/lib/Basic/Targets/OSTarg

[clang-tools-extra] [clang-tidy][use-internal-linkage]fix false positives for global overloaded operator new and operator delete (PR #117945)

2024-11-28 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/117945 >From a5c9f45fe2470a77c81d7eb0502053145ad854ca Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 28 Nov 2024 08:15:34 +0800 Subject: [PATCH] [clang-tidy][use-internal-linkage]fix false positives for gl

[clang] Reland [Clang] skip default argument instantiation for non-defining friend declarations to meet [dcl.fct.default] p4 (PR #115487)

2024-11-28 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. Yeah, this LGTM, thanks again. https://github.com/llvm/llvm-project/pull/115487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][use-internal-linkage]fix false positives for global overloaded operator new and operator delete (PR #117945)

2024-11-28 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/117945 >From 4cbe6e08f950d9d3075fa7a1da889b7566bef6c5 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 28 Nov 2024 08:15:34 +0800 Subject: [PATCH] [clang-tidy][use-internal-linkage]fix false positives for gl

[clang-tools-extra] [clang-reorder-fields] Handle macros fields declarations. (PR #118005)

2024-11-28 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle created https://github.com/llvm/llvm-project/pull/118005 Right now field with macro declarations break the tool: ``` struct Foo { Mutex mu; int x GUARDED_BY(mu); int y; }; ``` reordered by mu,y,x yields: ``` struct Foo { Mutex mu; int y GUARDED_BY(mu

[clang-tools-extra] [clang-reorder-fields] Handle macros fields declarations. (PR #118005)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Clement Courbet (legrosbuffle) Changes Right now fields with macro declarations break the tool: ``` struct Foo { Mutex mu; int x GUARDED_BY(mu); int y; }; ``` reordered by mu,y,x yields: ``` struct Foo { Mutex mu;

[clang] [llvm] [OpenMP][Clang] Migrate OpenMP UserDefinedMapper from Clang to OMPIRBuilder (PR #110001)

2024-11-28 Thread Akash Banerjee via cfe-commits
@@ -9041,257 +9041,65 @@ void CGOpenMPRuntime::emitUserDefinedMapper(const OMPDeclareMapperDecl *D, return; ASTContext &C = CGM.getContext(); QualType Ty = D->getType(); - QualType PtrTy = C.getPointerType(Ty).withRestrict(); - QualType Int64Ty = C.getIntTypeForBitwi

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread Helmut Januschka via cfe-commits
hjanuschka wrote: ohhh TIL! lets close this PR `readability-redundant-casting` with: `IgnoreTypeAliases` does what i was chasing! /close https://github.com/llvm/llvm-project/pull/118033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka closed https://github.com/llvm/llvm-project/pull/118033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support symbolTags for document symbol (PR #113669)

2024-11-28 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > I tried to build clangd from [my github > action](https://github.com/chouzz/clangd/actions/workflows/autobuild.yaml), > but I failed, maybe @HighCommander4 could help point out how to build clangd > via github actions with specify branch? What is it that you're trying

[clang] [Clang] fix crash due to incorrect argument position in merging deduced template arguments (PR #118041)

2024-11-28 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/118041 Fixes #113659 >From 59fa1de4e6638f1c8bba39e2e55c43cb3991fc3c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Fri, 29 Nov 2024 02:54:53 +0200 Subject: [PATCH] [Clang] fix crash due to incorrect argument pos

[clang] [Clang] fix crash due to incorrect argument position in merging deduced template arguments (PR #118041)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #113659 --- Full diff: https://github.com/llvm/llvm-project/pull/118041.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) clang/lib/Sema/SemaTemplateDeduction.cpp

[clang] [flang] [Flang] LoongArch64 support for BIND(C) derived types in mabi=lp64d. (PR #117108)

2024-11-28 Thread Zhaoxin Yang via cfe-commits
https://github.com/ylzsx updated https://github.com/llvm/llvm-project/pull/117108 >From 32e04b6538486006c98c6b805b1057110c3a2c1a Mon Sep 17 00:00:00 2001 From: yangzhaoxin Date: Wed, 20 Nov 2024 17:30:43 +0800 Subject: [PATCH 1/5] [Flang] LoongArch64 support for BIND(C) derived types. This pat

[clang] [flang] [Flang] LoongArch64 support for BIND(C) derived types in mabi=lp64d. (PR #117108)

2024-11-28 Thread Zhaoxin Yang via cfe-commits
https://github.com/ylzsx updated https://github.com/llvm/llvm-project/pull/117108 >From 32e04b6538486006c98c6b805b1057110c3a2c1a Mon Sep 17 00:00:00 2001 From: yangzhaoxin Date: Wed, 20 Nov 2024 17:30:43 +0800 Subject: [PATCH 1/5] [Flang] LoongArch64 support for BIND(C) derived types. This pat

[clang] [analyzer] Modernize, improve and promote chroot checker (PR #117791)

2024-11-28 Thread via cfe-commits
vabridgers wrote: Hi @steakhal , no problem. Thanks for the proactive help! https://github.com/llvm/llvm-project/pull/117791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

2024-11-28 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis approved this pull request. https://github.com/llvm/llvm-project/pull/118003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 3db70453e07f1378ed4d07023dc2a6cf2541b935 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/4] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [Clang][AArch64]Refactor typespec handling in SveEmitter.cpp (PR #117717)

2024-11-28 Thread Sander de Smalen via cfe-commits
@@ -50,20 +50,30 @@ using TypeSpec = std::string; namespace { class SVEType { - bool Float, Signed, Immediate, Void, Constant, Pointer, BFloat, MFloat; - bool DefaultType, IsScalable, Predicate, PredicatePattern, PrefetchOp, - Svcount; + + enum TypeKind { +Void, +

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: For future reference, `modernize` is typically related to new features of new C++ standards, so this check wouldn't quite fit there. Great that you found an existing check that suits your needs! https://github.com/llvm/llvm-project/pull/118033 _

[clang] [Clang][AArch64]Refactor typespec handling in SveEmitter.cpp (PR #117717)

2024-11-28 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/117717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64]Refactor typespec handling in SveEmitter.cpp (PR #117717)

2024-11-28 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm commented: One minor comment, but otherwise looks good! https://github.com/llvm/llvm-project/pull/117717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [llvm] [OpenMP][Clang] Migrate OpenMP UserDefinedMapper from Clang to OMPIRBuilder (PR #110001)

2024-11-28 Thread Akash Banerjee via cfe-commits
https://github.com/TIFitis updated https://github.com/llvm/llvm-project/pull/110001 >From 17ae5d768dc5ee113c4e859273706cb8e11f46e9 Mon Sep 17 00:00:00 2001 From: Akash Banerjee Date: Wed, 25 Sep 2024 16:06:36 +0100 Subject: [PATCH 1/3] [OpenMP][Clang] Migrate OpenMP UserDefinedMapper from Clan

[clang] [Clang][AST] Fix PackIndexingExpr AST printout (PR #117947)

2024-11-28 Thread via cfe-commits
https://github.com/AlexErofeev updated https://github.com/llvm/llvm-project/pull/117947 >From b3f7e8bda1bd38ef9bf5794ed4a6cece2ef77621 Mon Sep 17 00:00:00 2001 From: Aleksandr Erofeev Date: Thu, 28 Nov 2024 00:19:06 + Subject: [PATCH 1/2] Fix PackIndexingExpr AST printout --- clang/lib/AS

[clang-tools-extra] [clang-reorder-fields] Handle macros fields declarations. (PR #118005)

2024-11-28 Thread Alexander Shaposhnikov via cfe-commits
https://github.com/alexander-shaposhnikov approved this pull request. LG https://github.com/llvm/llvm-project/pull/118005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AST] Fix MS Mangle concept uneval context template instantiation crash (PR #117845)

2024-11-28 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/117845 >From 58a26201c8582fc573aa681867d57c236e799acb Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Tue, 26 Nov 2024 19:45:10 -0800 Subject: [PATCH 1/2] Fix MS Mangle concept uneval context template instantiation cra

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Sudharsan Veeravalli via cfe-commits
https://github.com/svs-quic updated https://github.com/llvm/llvm-project/pull/117987 >From 3d7772894ae10d79570899dbdfb34fd4877a37e5 Mon Sep 17 00:00:00 2001 From: Sudharsan Veeravalli Date: Thu, 28 Nov 2024 15:11:57 +0530 Subject: [PATCH 1/3] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store)

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Sudharsan Veeravalli via cfe-commits
@@ -771,9 +772,11 @@ Error RISCVISAInfo::checkDependency() { return getIncompatibleError("xwchc", "zcb"); } - if (Exts.count("xqcicsr") != 0 && (XLen != 32)) { -return getError("'xqcicsr' is only supported for 'rv32'"); - } + for (auto Ext : XqciExts) +if (E

[clang] 07a8ebe - [clang] Move warning about memset/memcpy to NonTriviallyCopyable type… (#117387)

2024-11-28 Thread via cfe-commits
Author: serge-sans-paille Date: 2024-11-28T13:55:29Z New Revision: 07a8ebed56cfa223d1587903e4de0d5788b5f777 URL: https://github.com/llvm/llvm-project/commit/07a8ebed56cfa223d1587903e4de0d5788b5f777 DIFF: https://github.com/llvm/llvm-project/commit/07a8ebed56cfa223d1587903e4de0d5788b5f777.diff

[clang] [Clang][AArch64] Include SME attributes in the name mangling of function types (PR #114209)

2024-11-28 Thread Sander de Smalen via cfe-commits
@@ -3535,6 +3536,70 @@ void CXXNameMangler::mangleExtFunctionInfo(const FunctionType *T) { // FIXME: noreturn } +enum class AAPCSBitmaskSME : unsigned { + ArmStreamingBit = 1 << 0, + ArmStreamingCompatibleBit = 1 << 1, + ArmAgnosticSMEZAStateBit = 1 << 2, + ZA_Shift = 3

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-11-28 Thread Alexey Gerenkov via cfe-commits
https://github.com/gerekon created https://github.com/llvm/llvm-project/pull/118008 This PR implements support for generic Xtensa target in CLang. >From bf0488585f41d3342c5c6d289d4621e3f50195cc Mon Sep 17 00:00:00 2001 From: Andrei Safronov Date: Thu, 1 Jun 2023 00:42:37 +0300 Subject: [PATCH]

[clang] [Xtensa] Default to unsigned char (PR #115967)

2024-11-28 Thread Alexey Gerenkov via cfe-commits
gerekon wrote: Looks like it is related to https://github.com/llvm/llvm-project/pull/118008 https://github.com/llvm/llvm-project/pull/115967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [clang] Move warning about memset/memcpy to NonTriviallyCopyable type… (PR #117387)

2024-11-28 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: > LLVM Buildbot has detected a new failure on builder > `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building > `clang` at step 7 "Add check check-offload". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/30/builds/11206 > > Here

[clang] [clang] Fix incorrect inferred lifetime_capture_by attr on STL (PR #118013)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes We incorrectly annotate the iterator parameter for `insert` method (`void insert(const_iterator, const value_type& value)`), because iterator is also a gsl-pointer type. This patch fixes it. --- Full diff: ht

<    1   2   3   4   >