https://github.com/MacDue updated
https://github.com/llvm/llvm-project/pull/116391
>From 90daf9c544bcb776c8a68ad504ba5eda50eafe8a Mon Sep 17 00:00:00 2001
From: Benjamin Maxwell
Date: Fri, 15 Nov 2024 14:35:41 +
Subject: [PATCH 1/5] [clang][SME] Ignore flatten for callees mismatched
stream
samitolvanen wrote:
> > AFAIK the use case for KCFI is very narrow: the x86-64 Linux kernel.
>
> At the very least, it's also used in the arm64 Linux Kernel.
Linux also supports KCFI on 32-bit ARM and RISC-V. However, this change seems
to only affect X86.
https://github.com/llvm/llvm-project/
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
Changes
Initially found by static analysis tool, the situation with the same memory
"owned" by two different uniqie_ptrs (one in Parser, another one in a
PragmaNamespace that is owned by Preprocessor) DOE
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/117703
Initially found by static analysis tool, the situation with the same memory
"owned" by two different uniqie_ptrs (one in Parser, another one in a
PragmaNamespace that is owned by Preprocessor) DOES seem like
https://github.com/MacDue updated
https://github.com/llvm/llvm-project/pull/116391
>From 90daf9c544bcb776c8a68ad504ba5eda50eafe8a Mon Sep 17 00:00:00 2001
From: Benjamin Maxwell
Date: Fri, 15 Nov 2024 14:35:41 +
Subject: [PATCH 1/5] [clang][SME] Ignore flatten for callees mismatched
stream
@@ -116,6 +116,7 @@ void foo(int n) { // expected-note {{declared here}}
B b2(A(1), {}, 1);
// beforecxx20-warning@-1 {{aggregate initialization of type 'A' from a
parenthesized list of values is a C++20 extension}}
// beforecxx20-warning@-2 {{aggregate initialization of
vgvassilev wrote:
> Would it be okay if I push the test for the Linux modification and check the
> results here? I don’t have access to a Linux x86 setup for testing.
Yes, that's what the pre-merge checks are for ;)
https://github.com/llvm/llvm-project/pull/117475
_
Author: Vladislav Belov
Date: 2024-11-26T12:56:46+01:00
New Revision: 486644723038555a224fd09d462bb5099e64809e
URL:
https://github.com/llvm/llvm-project/commit/486644723038555a224fd09d462bb5099e64809e
DIFF:
https://github.com/llvm/llvm-project/commit/486644723038555a224fd09d462bb5099e64809e.dif
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/114978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chandraghale updated
https://github.com/llvm/llvm-project/pull/117196
>From d19f41d39237b3d4fd2923f037743ddd495d5c9f Mon Sep 17 00:00:00 2001
From: Chandra Ghale
Date: Thu, 21 Nov 2024 11:15:11 -0600
Subject: [PATCH 1/4] Initial Codegen changes for strict modifier with
grain
https://github.com/chandraghale updated
https://github.com/llvm/llvm-project/pull/117196
>From d19f41d39237b3d4fd2923f037743ddd495d5c9f Mon Sep 17 00:00:00 2001
From: Chandra Ghale
Date: Thu, 21 Nov 2024 11:15:11 -0600
Subject: [PATCH 1/4] Initial Codegen changes for strict modifier with
grain
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clangd-ubuntu-tsan`
running on `clangd-ubuntu-clang` while building `clang` at step 6
"test-build-clangd-clangd-index-server-clangd-in...".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/134/builds/92
@@ -151,6 +152,9 @@ static bool useFramePointerForTargetByDefault(const
llvm::opt::ArgList &Args,
}
}
+ if (toolchains::isARMBareMetal(Triple))
stuij wrote:
Hi @jroelofs, adding the check for Apple shouldn't be necessary.
`isARMBareMetal` is trying t
https://github.com/stuij updated
https://github.com/llvm/llvm-project/pull/117140
>From 4a85a0cd98bf328f31465d47c56640abdf7ec08c Mon Sep 17 00:00:00 2001
From: Ties Stuij
Date: Fri, 15 Nov 2024 13:19:08 +
Subject: [PATCH 1/5] [clang][ARM] disable frame pointers by default for bare
metal AR
16bit-ykiko wrote:
A test failed after the modification, but it really confused me
```cpp
// Contexts where there is no function call, no diagnostic.
bool bad();
template
requires requires { bad(); }
void g() [[clang::nonblocking]] {}
void g() [[clang::nonblocking]] {
decltype(bad()) a; //
https://github.com/stuij updated
https://github.com/llvm/llvm-project/pull/117140
>From 4a85a0cd98bf328f31465d47c56640abdf7ec08c Mon Sep 17 00:00:00 2001
From: Ties Stuij
Date: Fri, 15 Nov 2024 13:19:08 +
Subject: [PATCH 1/4] [clang][ARM] disable frame pointers by default for bare
metal AR
@@ -0,0 +1,42 @@
+// RUN: %clang_cc1 -verify -std=c++20 %s -fsyntax-only
+
+namespace std {
+template struct remove_reference { typedef T type; };
+template struct remove_reference { typedef T type; };
+template struct remove_reference { typedef T type; };
+
+template typename
Author: ykiko
Date: 2024-11-26T13:03:39+01:00
New Revision: ec4c47d9490c90a98f2dda3fc9ff7c51782678f8
URL:
https://github.com/llvm/llvm-project/commit/ec4c47d9490c90a98f2dda3fc9ff7c51782678f8
DIFF:
https://github.com/llvm/llvm-project/commit/ec4c47d9490c90a98f2dda3fc9ff7c51782678f8.diff
LOG: Ad
https://github.com/PiotrZSL approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/117629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/107982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/107982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/117690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/117345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/c8ef closed https://github.com/llvm/llvm-project/pull/117473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein edited
https://github.com/llvm/llvm-project/pull/117690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: c8ef
Date: 2024-11-26T20:31:29+08:00
New Revision: 827ebf84e9af7c93a30daf4ed17e99ccef4cf94a
URL:
https://github.com/llvm/llvm-project/commit/827ebf84e9af7c93a30daf4ed17e99ccef4cf94a
DIFF:
https://github.com/llvm/llvm-project/commit/827ebf84e9af7c93a30daf4ed17e99ccef4cf94a.diff
LOG: [cl
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/117690
>From 8d159e95f67b4954e1a273658e612d05498748ab Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Tue, 26 Nov 2024 10:31:12 +0100
Subject: [PATCH] [clang] Diagnose dangling references for parethesized
aggregate ini
@@ -116,6 +116,7 @@ void foo(int n) { // expected-note {{declared here}}
B b2(A(1), {}, 1);
// beforecxx20-warning@-1 {{aggregate initialization of type 'A' from a
parenthesized list of values is a C++20 extension}}
// beforecxx20-warning@-2 {{aggregate initialization of
@@ -0,0 +1,42 @@
+// RUN: %clang_cc1 -verify -std=c++20 %s -fsyntax-only
+
+namespace std {
+template struct remove_reference { typedef T type; };
+template struct remove_reference { typedef T type; };
+template struct remove_reference { typedef T type; };
+
+template typename
AaronBallman wrote:
> @zygoloid I think we ended up concluding that
>
> * The tooling situation will not change (When Sema is not available
> mutation can't happen and we provide a default no-op implementation of the
> mutation function)
>
> * It's easy to check in `SemaProxyImpl` (or
https://github.com/NagyDonat approved this pull request.
LGTM, thanks for the updates.
https://github.com/llvm/llvm-project/pull/113899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidTruby edited
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1250,6 +1273,7 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) {
if (!ContainsError)
ContainsError = loadConfigFiles();
bool HasConfigFile = !ContainsError && (CfgOptions.get() != nullptr);
+ bool HasConfigLinkerIn = !ContainsError && (CfgLinkerInputs.ge
hokein wrote:
> LGTM, could you add a summary of the change to the commit message? I know the
> context is available in the linked issue, but I'd like the gist of it to be
> preserved in the commit history directly.
Done.
https://github.com/llvm/llvm-project/pull/117690
__
https://github.com/DavidTruby edited
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -61,3 +61,24 @@
! CHECK-TWO-CONFIGS-NEXT: Configuration file:
{{.*}}Inputs{{.}}config2{{.}}config-4.cfg
! CHECK-TWO-CONFIGS: -ffp-contract=fast
! CHECK-TWO-CONFIGS: -O3
+
+!--- The -l flags should be moved to the end of input list and appear only
when linking.
+! RUN: %fla
@@ -82,3 +82,24 @@
// CHECK-TWO-CONFIGS: -isysroot
// CHECK-TWO-CONFIGS-SAME: /opt/data
// CHECK-TWO-CONFIGS-SAME: -Wall
+
+//--- The -l flags should be moved to the end of input list and appear only
when linking.
+// RUN: %clang --target=aarch64-unknown-linux-gnu --config
%S
https://github.com/DavidTruby commented:
Change LGTM in general but I'd like Windows to have tests before approving as
we need this to be working there too
https://github.com/llvm/llvm-project/pull/117573
___
cfe-commits mailing list
cfe-commits@lists
@@ -232,13 +232,23 @@ bool AArch64TargetInfo::validateTarget(DiagnosticsEngine
&Diags) const {
bool AArch64TargetInfo::validateGlobalRegisterVariable(
StringRef RegName, unsigned RegSize, bool &HasSizeMismatch) const {
- if ((RegName == "sp") || RegName.starts_with("x"))
@@ -6404,20 +6404,23 @@ def warn_bitfield_width_exceeds_type_width: Warning<
def err_bitfield_too_wide : Error<
"%select{bit-field %1|anonymous bit-field}0 is too wide (%2 bits)">;
def warn_bitfield_too_small_for_enum : Warning<
- "bit-field %0 is not wide enough to store al
@@ -61,3 +61,24 @@
! CHECK-TWO-CONFIGS-NEXT: Configuration file:
{{.*}}Inputs{{.}}config2{{.}}config-4.cfg
! CHECK-TWO-CONFIGS: -ffp-contract=fast
! CHECK-TWO-CONFIGS: -O3
+
+!--- The -l flags should be moved to the end of input list and appear only
when linking.
+! RUN: %fla
@@ -6404,20 +6404,23 @@ def warn_bitfield_width_exceeds_type_width: Warning<
def err_bitfield_too_wide : Error<
"%select{bit-field %1|anonymous bit-field}0 is too wide (%2 bits)">;
def warn_bitfield_too_small_for_enum : Warning<
- "bit-field %0 is not wide enough to store al
erichkeane wrote:
> @erichkeane @Fznamznon what should the release note be - just something akin
> to "added warning flag -W... to warn when bitfield packing differs from MSVC"?
Elaborate a bit more than that, but yes, something like that. "Added warning
flag -Wxxx that does...". Some folks
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux`
running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/66/builds/6730
Here is the relevant piece of the b
@@ -6404,20 +6404,23 @@ def warn_bitfield_width_exceeds_type_width: Warning<
def err_bitfield_too_wide : Error<
"%select{bit-field %1|anonymous bit-field}0 is too wide (%2 bits)">;
def warn_bitfield_too_small_for_enum : Warning<
- "bit-field %0 is not wide enough to store al
https://github.com/erichkeane commented:
Unless I'm missing something, this doesn't really make sense. Pragma handlers
being owned by the Parser makes perfect sense to me, and making them shared
ownership does not make sense.
'Raw' pointers as non-owned references to a unique-ptr are complete
@@ -10488,7 +10488,14 @@ static bool AnalyzeBitFieldAssignment(Sema &S,
FieldDecl *Bitfield, Expr *Init,
// The RHS is not constant. If the RHS has an enum type, make sure the
// bitfield is wide enough to hold all the values of the enum without
// truncation.
-
@@ -4303,21 +4288,15 @@ void CodeGenModule::emitMultiVersionFunctions() {
continue;
llvm::Function *Func = createFunction(CurFD, I);
- StringRef Architecture;
Feats.clear();
- if (getTarget().getTriple().is
@@ -4692,6 +4692,17 @@ bool Sema::InstantiateDefaultArgument(SourceLocation
CallLoc, FunctionDecl *FD,
ParmVarDecl *Param) {
assert(Param->hasUninstantiatedDefaultArg());
+ // FIXME: We don't track member specialization info for non-de
https://github.com/NagyDonat approved this pull request.
I'm not familiar with these files, but the change seems to be harmless enough...
Let's hope that it doesn't cause any weird bugs.
https://github.com/llvm/llvm-project/pull/117481
___
cfe-commits
@@ -1143,30 +1146,63 @@ void AArch64TargetCodeGenInfo::checkFunctionABI(
}
}
-void AArch64TargetCodeGenInfo::checkFunctionCallABIStreaming(
-CodeGenModule &CGM, SourceLocation CallLoc, const FunctionDecl *Caller,
-const FunctionDecl *Callee) const {
- if (!Caller ||
@@ -1143,30 +1146,63 @@ void AArch64TargetCodeGenInfo::checkFunctionABI(
}
}
-void AArch64TargetCodeGenInfo::checkFunctionCallABIStreaming(
-CodeGenModule &CGM, SourceLocation CallLoc, const FunctionDecl *Caller,
-const FunctionDecl *Callee) const {
- if (!Caller ||
@@ -1143,30 +1146,63 @@ void AArch64TargetCodeGenInfo::checkFunctionABI(
}
}
-void AArch64TargetCodeGenInfo::checkFunctionCallABIStreaming(
-CodeGenModule &CGM, SourceLocation CallLoc, const FunctionDecl *Caller,
-const FunctionDecl *Callee) const {
- if (!Caller ||
@@ -697,27 +698,61 @@ static bool isTokenAtLoc(const SourceManager &SM, const
LangOptions &LangOpts,
return !Invalid && Text == TokenText;
}
-std::optional
-getExpansionLocOfMacro(StringRef MacroName, SourceLocation Loc,
- const ASTContext &Context) {
@@ -36,6 +36,7 @@
#include
#include
#include
+#include
AaronBallman wrote:
Would `llvm::DenseSet` make more sense?
https://llvm.org/docs/ProgrammersManual.html#llvm-adt-denseset-h
https://github.com/llvm/llvm-project/pull/117143
_
@@ -697,27 +698,61 @@ static bool isTokenAtLoc(const SourceManager &SM, const
LangOptions &LangOpts,
return !Invalid && Text == TokenText;
}
-std::optional
-getExpansionLocOfMacro(StringRef MacroName, SourceLocation Loc,
- const ASTContext &Context) {
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/117143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -697,27 +698,61 @@ static bool isTokenAtLoc(const SourceManager &SM, const
LangOptions &LangOpts,
return !Invalid && Text == TokenText;
}
-std::optional
-getExpansionLocOfMacro(StringRef MacroName, SourceLocation Loc,
- const ASTContext &Context) {
https://github.com/AaronBallman commented:
Thank you for working on a fix for this! Please be sure to update
`clang/docs/ReleaseNotes.rst` so users know about the fix.
Test coverage for the changes is interesting in that I'm not certain there's a
good test to add for this (the test would be on
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/116965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4683,13 +4683,22 @@ void CGOpenMPRuntime::emitTaskLoopCall(CodeGenFunction
&CGF, SourceLocation Loc,
Data.Schedule.getPointer()
? CGF.Builder.CreateIntCast(Data.Schedule.getPointer(), CGF.Int64Ty,
/*isSigned=*/false)
-
usx95 wrote:
Wow. This looks quite nice now without the special handling in `NoExtend` case.
Was the missing piece `Path.pop_back();` ?
https://github.com/llvm/llvm-project/pull/117690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
john-brawn-arm wrote:
Ping
https://github.com/llvm/llvm-project/pull/115894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
501 - 563 of 563 matches
Mail list logo
