[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-11-15 Thread Dmitry Polukhin via cfe-commits
dmpolukhin wrote: @alexfh and @ilya-biryukov do you have any updates? https://github.com/llvm/llvm-project/pull/111992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

2024-11-15 Thread Vladislav Belov via cfe-commits
vbe-sc wrote: > Please wait for a week before pinging someone again. > > I think this is fine to merge as is, if you want to go ahead. We can always > do post commit review later. Sorry, I didn't know. Let's do it this way you want https://github.com/llvm/llvm-project/pull/114978 ___

[clang] [NFC][Clang][AArch64]Refactor implementation of Neon vectors MFloat8… (PR #114804)

2024-11-15 Thread via cfe-commits
@@ -201,8 +201,6 @@ SVE_PREDICATE_TYPE_ALL("__clang_svboolx4_t", "svboolx4_t", SveBoolx4, SveBoolx4T SVE_OPAQUE_TYPE("__SVCount_t", "__SVCount_t", SveCount, SveCountTy) AARCH64_VECTOR_TYPE_MFLOAT("__MFloat8_t", "__MFloat8_t", MFloat8, MFloat8Ty, 1, 8, 1) Car

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Helmut Januschka via cfe-commits
@@ -147,6 +147,13 @@ New check aliases Changes in existing checks ^^ +- Improved :doc:`modernize-use-starts-ends-with hjanuschka wrote: not really sure if i understand that, see latest upload https://github.com/llvm/llvm-project/pull/

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/116033 >From 8a48d6be0b0cf28ab8e98b3a5e7f45628ceadb52 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Wed, 13 Nov 2024 12:52:36 +0100 Subject: [PATCH] [clang-tidy] Enhance modernize-use-starts-ends-with with

[clang] bc6c068 - [HLSL] Adding HLSL `clip` function. (#114588)

2024-11-15 Thread via cfe-commits
Author: joaosaffran Date: 2024-11-14T23:34:07-08:00 New Revision: bc6c0681271788ca7078fb679ac67b56944de1a6 URL: https://github.com/llvm/llvm-project/commit/bc6c0681271788ca7078fb679ac67b56944de1a6 DIFF: https://github.com/llvm/llvm-project/commit/bc6c0681271788ca7078fb679ac67b56944de1a6.diff L

[clang] e5a62d4 - [StaticAnalyzer] Fix -Wunused-but-set-variable in ExprEngineCXX.cpp (NFC)

2024-11-15 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2024-11-15T19:05:31+08:00 New Revision: e5a62d45fb1aa3b97ae47588cdc61d0d28f0c1a7 URL: https://github.com/llvm/llvm-project/commit/e5a62d45fb1aa3b97ae47588cdc61d0d28f0c1a7 DIFF: https://github.com/llvm/llvm-project/commit/e5a62d45fb1aa3b97ae47588cdc61d0d28f0c1a7.diff LOG: [

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/116033 >From bff5fd8031bbee5f81c17642256215d685965855 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Wed, 13 Nov 2024 12:52:36 +0100 Subject: [PATCH] [clang-tidy] Enhance modernize-use-starts-ends-with with

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka commented: @nicovank reading release notes! what a great community you folks have 😄 tried to use your matcher, still required a bit of plumbing in the check() but overall WAY better, LMKWYT, happy to address any further feedback. https://github.com/llvm/llvm-pr

[clang] [NFC][Clang][AArch64]Refactor implementation of Neon vectors MFloat8… (PR #114804)

2024-11-15 Thread via cfe-commits
@@ -11,23 +11,22 @@ void test_vector_sve(svmfloat8_t a, svuint8_t c) { a / c; // sve-error {{cannot convert between vector type 'svuint8_t' (aka '__SVUint8_t') and vector type 'svmfloat8_t' (aka '__SVMfloat8_t') as implicit conversion would cause truncation}} } - #includ

[clang-tools-extra] [clangd] Fix the modification detection logic in `ClangdLSPServer::applyConfiguration`. (PR #115438)

2024-11-15 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks, this LGTM. It would be nice to have a test exercising `applyConfiguration` itself, but I realize we don't currently have such tests (and that the intended effect -- that an open file whose command did not change does **not**

[clang] [clang] Implement lifetime analysis for lifetime_capture_by(X) (PR #115921)

2024-11-15 Thread Utkarsh Saxena via cfe-commits
@@ -1420,9 +1446,18 @@ static void checkExprLifetimeImpl(Sema &SemaRef, ? IndirectLocalPathEntry::LifetimeBoundCall : IndirectLocalPathEntry::GslPointerAssignment, Init}); + } else if (LK == LK_LifetimeCapture) { +Path.push_back({Indirect

[clang-tools-extra] [clangd] Fix the modification detection logic in `ClangdLSPServer::applyConfiguration`. (PR #115438)

2024-11-15 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/115438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-11-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-5` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/9546 Here i

[clang] [analyzer] Print the callee name in CallEnter in exploded-graph-rewriter (PR #116225)

2024-11-15 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/116225 >From 68086287a41c534704cdbc88027f61090b0540ea Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Thu, 14 Nov 2024 14:25:31 +0100 Subject: [PATCH 1/2] [analyzer] Print the callee name in CallEnter in exploded-

[clang] Enable AST mutation in the constant evaluator (PR #115168)

2024-11-15 Thread Vlad Serebrennikov via cfe-commits
@@ -182,6 +182,17 @@ struct TypeInfoChars { } }; +// Interface that allows constant evaluator to mutate AST. +// Sema is the only entity that can implement this. +struct EvalASTMutator { + virtual ~EvalASTMutator() = default; + + virtual void + InstantiateFunctionDefiniti

[clang] Enable AST mutation in the constant evaluator (PR #115168)

2024-11-15 Thread Vlad Serebrennikov via cfe-commits
@@ -8328,6 +8329,13 @@ class ExprEvaluatorBase const FunctionDecl *Definition = nullptr; Stmt *Body = FD->getBody(Definition); +if (Info.Ctx.getLangOpts().CPlusPlus26 && Info.getASTMutator() && Endilll wrote: Fixed https://github.com/llvm/llvm-pr

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
@@ -4216,22 +4216,11 @@ static void ReplaceUsesOfNonProtoTypeWithRealFunction(llvm::GlobalValue *Old, llvm::Function *NewFn); static unsigned -TargetMVPriority(const TargetInfo &TI, - const CodeGenFunction:

[clang] [llvm] AMDGPU: Add gfx950 subtarget definitions (PR #116307)

2024-11-15 Thread Matt Arsenault via cfe-commits
@@ -650,15 +650,15 @@ class VOP_SDWA_Pseudo pattern=[]> : let Uses = !if(ReadsModeReg, [MODE, EXEC], [EXEC]); let SubtargetPredicate = HasSDWA; - let AssemblerPredicate = HasSDWA; + //let AssemblerPredicate = HasSDWA; arsenm wrote: This should be in #1

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-15 Thread Erich Keane via cfe-commits
@@ -114,8 +114,8 @@ void ThreeVersionsSameAttr(void){} // CHECK: define {{.*}}void @ThreeVersionsSameAttr.Z() #[[K]] ATTR(cpu_specific(knl)) -void CpuSpecificNoDispatch(void) {} -// CHECK: define {{.*}}void @CpuSpecificNoDispatch.Z() #[[K:[0-9]+]] +void CpuSpecificNoDispatch(v

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/115762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Can you better explain what the crash cause is? It isn't clear what the change here is doing. https://github.com/llvm/llvm-project/pull/115762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] Add concepts to ast (PR #116407)

2024-11-15 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 created https://github.com/llvm/llvm-project/pull/116407 None >From 68985e64694b0f6e0e779d4711bbff8afb3fe6b2 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 10 Oct 2024 14:31:25 -0700 Subject: [PATCH 01/19] ConceptSpecializationExpr shows up in AST!!! ---

[clang] Add concepts to ast (PR #116407)

2024-11-15 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/116407 >From 68985e64694b0f6e0e779d4711bbff8afb3fe6b2 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 10 Oct 2024 14:31:25 -0700 Subject: [PATCH 01/19] ConceptSpecializationExpr shows up in AST!!! --- clang

[clang] [llvm] [Clang][Darwin] Introduce `SubFrameworks` as a SDK default location (PR #115048)

2024-11-15 Thread Cyndy Ishida via cfe-commits
@@ -346,6 +346,7 @@ void InitHeaderSearch::AddDefaultIncludePaths( AddPath("/System/DriverKit/System/Library/Frameworks", System, true); cyndyishida wrote: I'd rather discuss DriverKit support separately, so I will merge this pr now. > Also, why's there

[clang] [llvm] [Clang][Darwin] Introduce `SubFrameworks` as a SDK default location (PR #115048)

2024-11-15 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida edited https://github.com/llvm/llvm-project/pull/115048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2d48489 - [Clang][Darwin] Introduce `SubFrameworks` as a SDK default location (#115048)

2024-11-15 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-11-15T09:27:08-08:00 New Revision: 2d48489cc35ec9bb1c15ff115595e62d67ca8989 URL: https://github.com/llvm/llvm-project/commit/2d48489cc35ec9bb1c15ff115595e62d67ca8989 DIFF: https://github.com/llvm/llvm-project/commit/2d48489cc35ec9bb1c15ff115595e62d67ca8989.diff

[clang] [llvm] [Clang][Darwin] Introduce `SubFrameworks` as a SDK default location (PR #115048)

2024-11-15 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/115048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #116413)

2024-11-15 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/116413 >From 92ccbe72ca95ad2df5a81b76244a8a8d7cedef40 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 15 Nov 2024 09:00:15 -0800 Subject: [PATCH 1/2] update new tests --- clang/lib/Sema/HLSLExternalSemaSour

[clang] Enable AST mutation in the constant evaluator (PR #115168)

2024-11-15 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/115168 >From 5ca48e03412b1b8e9253f13356b9cc957f6fd9e5 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 6 Nov 2024 17:58:43 +0300 Subject: [PATCH 01/10] Add EvalASTMutator interface with `InstantiateFunctio

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang][AMDGPU] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (PR #116435)

2024-11-15 Thread Shilei Tian via cfe-commits
https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/116435 AMDGPU disabled the use of `byval` for struct argument passing in commit d77c620. However, when emitting `__enqueue_kernel_basic`, Clang still adds the `byval` attribute by default. This PR introduces a target c

[clang] [Clang][AMDGPU] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (PR #116435)

2024-11-15 Thread Matt Arsenault via cfe-commits
@@ -5985,10 +5985,14 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, llvm::Value *Block = Builder.CreatePointerCast(Info.BlockArg, GenericVoidPtrTy); - AttrBuilder B(Builder.getContext()); - B.addByValAttr(NDRangeL

[clang] [llvm] [SPIR-V] DRAFT: Shader built-ins - no spec change (PR #116393)

2024-11-15 Thread Steven Perron via cfe-commits
@@ -164,6 +164,16 @@ def HLSLBufferObj : SubsetSubject(S)}], "cbuffer/tbuffer">; +def HLSLInputBuiltin : SubsetSubjecthasGlobalStorage() && S->getType().isConstQualified() && + S->getStorageClass()==StorageClass::SC_Static}], +

[clang] [llvm] [SPIR-V] DRAFT: Shader built-ins - no spec change (PR #116393)

2024-11-15 Thread Steven Perron via cfe-commits
@@ -204,7 +204,11 @@ addressSpaceToStorageClass(unsigned AddrSpace, const SPIRVSubtarget &STI) { ? SPIRV::StorageClass::HostOnlyINTEL : SPIRV::StorageClass::CrossWorkgroup; case 7: +return SPIRV::StorageClass::Private; + case 8: return

[clang] [llvm] [SPIR-V] DRAFT: Shader built-ins - no spec change (PR #116393)

2024-11-15 Thread Steven Perron via cfe-commits
@@ -43,7 +43,7 @@ void neg() { template void tooBig() { - __attribute__((address_space(I))) int *bounds; // expected-error {{address space is larger than the maximum supported (8388586)}} + __attribute__((address_space(I))) int *bounds; // expected-error {{address space i

[clang] [Clang][AMDGPU] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (PR #116435)

2024-11-15 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/116435 >From 50b6941f3ee43f5c4e559112fbb3fd8fa9fb6016 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 15 Nov 2024 15:04:39 -0500 Subject: [PATCH] [Clang][AMDGPU] Avoid Using `byval` for `ndrange_t` when emittin

[clang] [llvm] [SPIR-V] DRAFT: Shader built-ins - no spec change (PR #116393)

2024-11-15 Thread Steven Perron via cfe-commits
@@ -59,6 +59,9 @@ enum class LangAS : unsigned { // HLSL specific address spaces. hlsl_groupshared, + // Vulkan specific address spaces. + vulkan_private, + s-perron wrote: Do we need a new address space? This is not an issue specific to these input an

[clang] [llvm] [SPIR-V] DRAFT: Shader built-ins - no spec change (PR #116393)

2024-11-15 Thread Steven Perron via cfe-commits
@@ -379,6 +380,18 @@ llvm::Value *CGHLSLRuntime::emitInputSemantic(IRBuilder<> &B, const ParmVarDecl &D, llvm::Type *Ty) { assert(D.hasAttrs() && "Entry parameter missing annotation a

[clang] [llvm] [SPIR-V] DRAFT: Shader built-ins - no spec change (PR #116393)

2024-11-15 Thread Steven Perron via cfe-commits
https://github.com/s-perron commented: This aligns with what I was thinking. Thanks. My only real question is if we have to use the new address space. We might need to figure out how to handle regular static variables first, and then we can revisit this. https://github.com/llvm/llvm-project/pu

[clang] [Clang][AMDGPU] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (PR #116435)

2024-11-15 Thread Shilei Tian via cfe-commits
shiltian wrote: * **#116435** https://app.graphite.dev/github/pr/llvm/llvm-project/116435?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/116

[clang] [Clang][AMDGPU] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (PR #116435)

2024-11-15 Thread Shilei Tian via cfe-commits
@@ -5985,10 +5985,14 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, llvm::Value *Block = Builder.CreatePointerCast(Info.BlockArg, GenericVoidPtrTy); - AttrBuilder B(Builder.getContext()); - B.addByValAttr(NDRangeL

[clang] [Clang] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (PR #116435)

2024-11-15 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/116435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I wont be able to get back to this until after WG21, but some comments. https://github.com/llvm/llvm-project/pull/116257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [llvm] AMDGPU: Add gfx950 subtarget definitions (PR #116307)

2024-11-15 Thread Ivan Kosarev via cfe-commits
@@ -650,15 +650,15 @@ class VOP_SDWA_Pseudo pattern=[]> : let Uses = !if(ReadsModeReg, [MODE, EXEC], [EXEC]); let SubtargetPredicate = HasSDWA; - let AssemblerPredicate = HasSDWA; + //let AssemblerPredicate = HasSDWA; kosarev wrote: Just remove the lin

[clang] 31ee667 - [Clang] Fix gpuintrin_lang test for OpenCL

2024-11-15 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-11-15T10:48:05-06:00 New Revision: 31ee667eb02c68ad186cb129f9dcb72a9dbc URL: https://github.com/llvm/llvm-project/commit/31ee667eb02c68ad186cb129f9dcb72a9dbc DIFF: https://github.com/llvm/llvm-project/commit/31ee667eb02c68ad186cb129f9dcb72a9dbc.diff

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea edited https://github.com/llvm/llvm-project/pull/116257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2024-11-15 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 38d97344ddf31e39e0a45303b6d10f92de3c3ce8 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
@@ -114,8 +114,8 @@ void ThreeVersionsSameAttr(void){} // CHECK: define {{.*}}void @ThreeVersionsSameAttr.Z() #[[K]] ATTR(cpu_specific(knl)) -void CpuSpecificNoDispatch(void) {} -// CHECK: define {{.*}}void @CpuSpecificNoDispatch.Z() #[[K:[0-9]+]] +void CpuSpecificNoDispatch(v

[clang] 3eb1bc5 - [Clang] Change 'gpuintrin.h' to use target specific address spceas

2024-11-15 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-11-15T10:28:20-06:00 New Revision: 3eb1bc5edfc69895bfdc0a8ddd31af3969e6aacc URL: https://github.com/llvm/llvm-project/commit/3eb1bc5edfc69895bfdc0a8ddd31af3969e6aacc DIFF: https://github.com/llvm/llvm-project/commit/3eb1bc5edfc69895bfdc0a8ddd31af3969e6aacc.diff

[clang-tools-extra] [clangd] Support symbolTags for document symbol (PR #113669)

2024-11-15 Thread Dietrich Travkin via cfe-commits
travkin79 wrote: Thank you @chouzz for adding _Declaration_ and _Definition_ tags. I'm sorry for answering late. I was quite busy last days. Could we please also replace the _Const_ tag with the _Read-only_ tag? (I'm planning to remove the _Const_ tag from my PR on the LSP spec). What about a

[clang] [Clang] Add 'gpuintrin.h' to the release notes (PR #116410)

2024-11-15 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/116410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Joseph Huber via cfe-commits
@@ -31,6 +31,7 @@ #include "clang/Basic/PointerAuthOptions.h" #include "clang/Basic/SourceLocation.h" #include "clang/Basic/Specifiers.h" +#include "clang/Basic/TargetInfo.h" jhuber6 wrote: Shouldn't be necessary, I can make a PR to remove it again. https://g

[clang] [Clang] Add 'gpuintrin.h' to the release notes (PR #116410)

2024-11-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/116410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fd5fcfb - [Clang] Add 'gpuintrin.h' to the release notes (#116410)

2024-11-15 Thread via cfe-commits
Author: Joseph Huber Date: 2024-11-15T11:08:06-06:00 New Revision: fd5fcfb1e620823e4ec896fb8e0520c1e7286cdb URL: https://github.com/llvm/llvm-project/commit/fd5fcfb1e620823e4ec896fb8e0520c1e7286cdb DIFF: https://github.com/llvm/llvm-project/commit/fd5fcfb1e620823e4ec896fb8e0520c1e7286cdb.diff

[clang] [AArch64][SVE] Fold svrev(svrev(v)) to v (PR #116422)

2024-11-15 Thread Jorge Botto via cfe-commits
https://github.com/jf-botto created https://github.com/llvm/llvm-project/pull/116422 This PR follows the approach specified in https://github.com/llvm/llvm-project/issues/110444#issuecomment-2391540986 by making clang emit `llvm.vector.reverse` instead of `llvm.aarch64.sve.rev`, meaning instc

[clang] Remove Linux search paths on Windows (PR #113628)

2024-11-15 Thread David Salinas via cfe-commits
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args, TC = std::make_unique(*this, Target, Args); break; case llvm::Triple::AMDHSA: - TC = std::make_unique(*this, Target, Args); + TC = std::make_unique(*this, Target, Args, +

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
@@ -48,6 +48,19 @@ std::optional AArch64::ArchInfo::findBySubArch(StringRef SubA return {}; } +unsigned AArch64::getFMVPriority(ArrayRef Features) { + constexpr unsigned MaxFMVPriority = 1000; + unsigned Priority = 0; + unsigned NumFeatures = 0; + for (StringRef Feature

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Fuchsia] Include runtimes for armv8.1m.main-none-eabi (PR #116420)

2024-11-15 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/116420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,713 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi requested changes to this pull request. I think there is still quite a lot to do here ATM. First, I see many things marked as resolved, that weren't actually changed. Unless there's a good reason I think those should be addressed. In particular, I and the other revie

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-11-15 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/116331 >From 3c792216f88e87b69b3ea7415c2fd74b7f5d7469 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Fri, 25 Oct 2024 17:48:41 + Subject: [PATCH 1/6] adding comments --- clang/include/clang/Basic/Attr.td

[clang] [Fuchsia] Include runtimes for armv8.1m.main-none-eabi (PR #116420)

2024-11-15 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/116420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-15 Thread Greg Roth via cfe-commits
@@ -1949,6 +1952,22 @@ bool SPIRVInstructionSelector::selectSign(Register ResVReg, return Result; } +bool SPIRVInstructionSelector::selectWaveActiveAnyTrue(Register ResVReg, + const SPIRVType *ResType, +

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-15 Thread Greg Roth via cfe-commits
@@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -finclude-default-header -fnative-half-type -triple \ +// RUN: dxil-pc-shadermodel6.3-compute %s -emit-llvm -disable-llvm-passes -o - | \ +// RUN: FileCheck %s --check-prefixes=CHECK,CHECK-DXIL +// RUN: %clang_cc1 -finclude-default-header

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-11-15 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/116331 >From 3c792216f88e87b69b3ea7415c2fd74b7f5d7469 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Fri, 25 Oct 2024 17:48:41 + Subject: [PATCH 1/7] adding comments --- clang/include/clang/Basic/Attr.td

[clang] [Fuchsia] Include runtimes for armv8.1m.main-none-eabi (PR #116420)

2024-11-15 Thread via cfe-commits
https://github.com/PiJoules approved this pull request. https://github.com/llvm/llvm-project/pull/116420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/116257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bc3b0fa - [AST] Remove unnecessary include (NFC)

2024-11-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2024-11-15T16:54:33+01:00 New Revision: bc3b0fadd5120bd88ed6635583941f7763523c0a URL: https://github.com/llvm/llvm-project/commit/bc3b0fadd5120bd88ed6635583941f7763523c0a DIFF: https://github.com/llvm/llvm-project/commit/bc3b0fadd5120bd88ed6635583941f7763523c0a.diff

[clang-tools-extra] Rename CODE_OWNERS -> Maintainers (PR #114544)

2024-11-15 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. Thanks! My details seem correct. https://github.com/llvm/llvm-project/pull/114544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Nikita Popov via cfe-commits
@@ -31,6 +31,7 @@ #include "clang/Basic/PointerAuthOptions.h" #include "clang/Basic/SourceLocation.h" #include "clang/Basic/Specifiers.h" +#include "clang/Basic/TargetInfo.h" nikic wrote: I dropped this include again in https://github.com/llvm/llvm-project/co

[clang] Remove Linux search paths on Windows (PR #113628)

2024-11-15 Thread Joseph Huber via cfe-commits
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args, TC = std::make_unique(*this, Target, Args); break; case llvm::Triple::AMDHSA: - TC = std::make_unique(*this, Target, Args); + TC = std::make_unique(*this, Target, Args, +

[clang] Remove Linux search paths on Windows (PR #113628)

2024-11-15 Thread David Salinas via cfe-commits
@@ -0,0 +1,9 @@ +// REQUIRES: system-windows david-salinas wrote: ah ok. :-) https://github.com/llvm/llvm-project/pull/113628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] Enable AST mutation in the constant evaluator (PR #115168)

2024-11-15 Thread via cfe-commits
cor3ntin wrote: @zygoloid @katzdm for awareness https://github.com/llvm/llvm-project/pull/115168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enable AST mutation in the constant evaluator (PR #115168)

2024-11-15 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > @zygoloid @katzdm for awareness This PR is still in flux. Discussions are lengthy and typically happen in meetings. My plan is to get to a stable point, write down how we got there, alternatives rejected (with reasoning), and get the PR out of the draft status. This would be

[clang] [clang-tools-extra] [clangd] Update clangDaemonTweaks to set symbol visibility macros (PR #112304)

2024-11-15 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @AaronBallman, can you help us move forward here? https://github.com/llvm/llvm-project/pull/112304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #116413)

2024-11-15 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 created https://github.com/llvm/llvm-project/pull/116413 This PR is step one on the journey to implement resource element type validation via C++20 concepts. The PR sets up the infrastructure for injecting implicit concept decls / concept specialization expressions

[clang] [Clang][AMDGPU] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (PR #116435)

2024-11-15 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/116435 >From c48f66338d05e21f2a60062cf825f4cba445d5d8 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 15 Nov 2024 15:04:39 -0500 Subject: [PATCH] [Clang][AMDGPU] Avoid Using `byval` for `ndrange_t` when emittin

[clang] [Fuchsia] Include runtimes for armv8.1m.main-none-eabi (PR #116420)

2024-11-15 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek updated https://github.com/llvm/llvm-project/pull/116420 >From 028021ded3dee3f55ba26540f5c9cf1a1e8cbb36 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Tue, 12 Nov 2024 19:50:46 + Subject: [PATCH 1/2] [Fuchsia] Include runtimes for armv8.1m.main-none-eabi These

[clang] [llvm] [SPIR-V] DRAFT: Shader built-ins - no spec change (PR #116393)

2024-11-15 Thread Steven Perron via cfe-commits
https://github.com/s-perron edited https://github.com/llvm/llvm-project/pull/116393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/115777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [flang] [clang][driver] When -fveclib=ArmPL flag is in use, always link against libamath (PR #116432)

2024-11-15 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm updated https://github.com/llvm/llvm-project/pull/116432 >From 0906f315571cfa093889077c5ec155cae3d174b6 Mon Sep 17 00:00:00 2001 From: Pawel Osmialowski Date: Fri, 15 Nov 2024 15:22:21 + Subject: [PATCH] [clang][driver] When -fveclib=ArmPL flag is in use, alway

[clang] [flang] [clang][driver] When -fveclib=ArmPL flag is in use, always link against libamath (PR #116432)

2024-11-15 Thread Paul Osmialowski via cfe-commits
pawosm-arm wrote: > Typo in PR title `flang` -> `flag` Corrected both the title and the commit message. Thanks for spotting this! https://github.com/llvm/llvm-project/pull/116432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] Remove device override for operator new when the C++ standard >= 26 (PR #114056)

2024-11-15 Thread Ognyan Mirev via cfe-commits
OgnianM wrote: Yeah, am I supposed to do anything at this point or should I just leave it to you? https://github.com/llvm/llvm-project/pull/114056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [flang] [clang][driver] When -fveclib=ArmPL flang is in use, always link against libamath (PR #116432)

2024-11-15 Thread Benjamin Maxwell via cfe-commits
MacDue wrote: Typo in PR title `flang` -> `flag` https://github.com/llvm/llvm-project/pull/116432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove Linux search paths on Windows (PR #113628)

2024-11-15 Thread Joseph Huber via cfe-commits
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args, TC = std::make_unique(*this, Target, Args); break; case llvm::Triple::AMDHSA: - TC = std::make_unique(*this, Target, Args); + TC = std::make_unique(*this, Target, Args, +

[clang] [clang][Driver] Use shared_ptr in the Compilation class (PR #116406)

2024-11-15 Thread Victor Campos via cfe-commits
https://github.com/vhscampos created https://github.com/llvm/llvm-project/pull/116406 This patch replaces uses of raw pointers by shared_ptrs in the Driver's Compilation class. The manual memory management which was done before this patch could be error prone. Plus, code is now simpler. >Fro

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: > Can you better explain what the crash cause is? It isn't clear what the > change here is doing. Oh sorry, I thought it became evident with the latest revision. The reason we are crashing is that we call takeName on the same Value. That is because when replaceDeclarationWith

[clang] [analyzer] [MallocChecker] Less aggressive analysis of functions (PR #116383)

2024-11-15 Thread via cfe-commits
https://github.com/likeamahoney updated https://github.com/llvm/llvm-project/pull/116383 >From 92354e08433b3b683c59634d8f8e4d4d7dd3fd44 Mon Sep 17 00:00:00 2001 From: Yan Churkin Date: Fri, 15 Nov 2024 15:44:17 +0300 Subject: [PATCH 1/2] [analyzer] [MallocChecker] Less aggressive analysis of f

[clang] [clang][Driver] Use shared_ptr in the Compilation class (PR #116406)

2024-11-15 Thread Victor Campos via cfe-commits
https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/116406 >From bfd7a4cd935c45b84d270b12d1989531d4522732 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Fri, 15 Nov 2024 16:15:04 + Subject: [PATCH 1/2] [clang][Driver] Use shared_ptr in the Compilation class T

[clang] [clang][Driver] Use shared_ptr in the Compilation class (PR #116406)

2024-11-15 Thread Victor Campos via cfe-commits
https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/116406 >From bfd7a4cd935c45b84d270b12d1989531d4522732 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Fri, 15 Nov 2024 16:15:04 + Subject: [PATCH] [clang][Driver] Use shared_ptr in the Compilation class This

[clang-tools-extra] 0b344b4 - Extend bugprone-use-after-move check to handle std::optional::reset() and std::any::reset() (#114255)

2024-11-15 Thread via cfe-commits
Author: higher-performance Date: 2024-11-16T00:47:52+08:00 New Revision: 0b344b4feff5cd04d63db7b914d783fd941fbda0 URL: https://github.com/llvm/llvm-project/commit/0b344b4feff5cd04d63db7b914d783fd941fbda0 DIFF: https://github.com/llvm/llvm-project/commit/0b344b4feff5cd04d63db7b914d783fd941fbda0.

[clang-tools-extra] Extend bugprone-use-after-move check to handle std::optional::reset() and std::any::reset() (PR #114255)

2024-11-15 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/114255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e9e8f59 - [clang] Instantiate attributes on LabelDecls (#115924)

2024-11-15 Thread via cfe-commits
Author: Eric Astor Date: 2024-11-15T12:33:20-05:00 New Revision: e9e8f59dd4f88229b731a0b5951db176a03bd8c4 URL: https://github.com/llvm/llvm-project/commit/e9e8f59dd4f88229b731a0b5951db176a03bd8c4 DIFF: https://github.com/llvm/llvm-project/commit/e9e8f59dd4f88229b731a0b5951db176a03bd8c4.diff LO

<    1   2   3   4   5   >