[clang-tools-extra] Rename CODE_OWNERS -> Maintainers (PR #114544)

2024-11-15 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. https://github.com/llvm/llvm-project/pull/114544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea edited https://github.com/llvm/llvm-project/pull/115762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove Linux search paths on Windows (PR #113628)

2024-11-15 Thread David Salinas via cfe-commits
@@ -272,6 +277,13 @@ class RocmInstallationDetector { return Loc->second; } + void init(bool DetectHIPRuntime = true, bool DetectDeviceLib = false) { david-salinas wrote: Yes. We are basically just trying to avoid adding "linux like paths" on Windows.

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -7,26 +7,39 @@ Checks for common roundabout ways to express ``starts_with`` and ``ends_with`` and suggests replacing with the simpler method when it is available. Notably, this will work with ``std::string`` and ``std::string_view``. -.. code-block:: c++ +The check handle

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -189,7 +203,54 @@ void UseStartsEndsWithCheck::check(const MatchFinder::MatchResult &Result) { if (ComparisonExpr->getBeginLoc().isMacroID()) return; - const bool Neg = ComparisonExpr->getOpcode() == BO_NE; + bool Neg; + if (const auto *BO = llvm::dyn_cast(Compari

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -171,10 +171,24 @@ void UseStartsEndsWithCheck::registerMatchers(MatchFinder *Finder) { hasRHS(lengthExprForStringNode("needle") .bind("expr"), this); + Finder->addMatcher( nicovank wrote: This needs `c

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -7,26 +7,39 @@ Checks for common roundabout ways to express ``starts_with`` and ``ends_with`` and suggests replacing with the simpler method when it is available. Notably, this will work with ``std::string`` and ``std::string_view``. -.. code-block:: c++ +The check handle

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -7,26 +7,39 @@ Checks for common roundabout ways to express ``starts_with`` and ``ends_with`` and suggests replacing with the simpler method when it is available. Notably, this will work with ``std::string`` and ``std::string_view``. -.. code-block:: c++ +The check handle

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -189,7 +203,54 @@ void UseStartsEndsWithCheck::check(const MatchFinder::MatchResult &Result) { if (ComparisonExpr->getBeginLoc().isMacroID()) return; - const bool Neg = ComparisonExpr->getOpcode() == BO_NE; + bool Neg; + if (const auto *BO = llvm::dyn_cast(Compari

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -244,7 +244,10 @@ Changes in existing checks - Improved :doc:`modernize-use-starts-ends-with ` check to handle two cases - that can be replaced with ``ends_with`` + that can be replaced with ``ends_with`` and detect patterns using ``substr`` + that can be replaced with

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -266,3 +266,37 @@ void test(std::string s, std::string_view sv, sub_string ss, sub_sub_string sss, s.compare(0, 1, "ab") == 0; s.rfind(suffix, 1) == s.size() - suffix.size(); } + +void test_substr() { +std::string str("hello world"); +std::string prefix = "hello

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -266,3 +266,37 @@ void test(std::string s, std::string_view sv, sub_string ss, sub_sub_string sss, s.compare(0, 1, "ab") == 0; s.rfind(suffix, 1) == s.size() - suffix.size(); } + +void test_substr() { +std::string str("hello world"); +std::string prefix = "hello

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Jon Roelofs via cfe-commits
@@ -48,6 +48,19 @@ std::optional AArch64::ArchInfo::findBySubArch(StringRef SubA return {}; } +unsigned AArch64::getFMVPriority(ArrayRef Features) { + constexpr unsigned MaxFMVPriority = 1000; + unsigned Priority = 0; + unsigned NumFeatures = 0; + for (StringRef Feature

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank commented: Nice! Few comments. I would like to have a single consolidated strategy to the FixIt generation if possible, I think that would be cleaner and I think it is possible. Some mix of what you added in the `IsSubstr` case and in the other existing cases should

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/116033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -59,6 +59,7 @@ struct basic_string { _Type& insert(size_type pos, const _Type& str); _Type& insert(size_type pos, const C* s); _Type& insert(size_type pos, const C* s, size_type n); + _Type substr(size_type pos = 0, size_type count = npos) const; nico

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -171,10 +171,24 @@ void UseStartsEndsWithCheck::registerMatchers(MatchFinder *Finder) { hasRHS(lengthExprForStringNode("needle") .bind("expr"), this); + Finder->addMatcher( nicovank wrote: For consisten

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] Remove Linux search paths on Windows (PR #113628)

2024-11-15 Thread David Salinas via cfe-commits
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args, TC = std::make_unique(*this, Target, Args); break; case llvm::Triple::AMDHSA: - TC = std::make_unique(*this, Target, Args); + TC = std::make_unique(*this, Target, Args, +

[clang] 1e49228 - [Fuchsia] Include runtimes for armv8.1m.main-none-eabi (#116420)

2024-11-15 Thread via cfe-commits
Author: Petr Hosek Date: 2024-11-15T11:32:15-08:00 New Revision: 1e492285f33ca7c7efa97671990d47a32eaf31f7 URL: https://github.com/llvm/llvm-project/commit/1e492285f33ca7c7efa97671990d47a32eaf31f7 DIFF: https://github.com/llvm/llvm-project/commit/1e492285f33ca7c7efa97671990d47a32eaf31f7.diff LO

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. LGTM as a refactor. We don't need to solve the spec clarification thing in this PR: https://github.com/llvm/llvm-project/pull/116257/files#r1844489795 https://github.com/llvm/llvm-project/pull/116257 __

[clang] [Clang] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (PR #116435)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Shilei Tian (shiltian) Changes AMDGPU disabled the use of `byval` for struct argument passing in commit d77c620. However, when emitting `__enqueue_kernel_basic`, Clang still adds the `byval` attribute by default. Emitting the `byval

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,113 @@ +//===--- Mustache.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-15 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/114715 >From 6bcb40f63c1393f45a0acdbe3631b85e20d4e93c Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 7 Nov 2024 01:58:21 +0100 Subject: [PATCH] [analyzer] Port alpha.core.IdenticalExpr to Tidy checks and

[clang] [docs][asan][lsan] Drop list of supported architechures (PR #116302)

2024-11-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/116302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add TT-Ascalon-d8 processor (PR #115100)

2024-11-15 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave approved this pull request. LGTM. I don't have any strong opinion on the CPU name https://github.com/llvm/llvm-project/pull/115100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [docs][asan][lsan] Drop list of supported architechures (PR #116302)

2024-11-15 Thread Florian Mayer via cfe-commits
https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/116302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] `sret` args should always point to the `alloca` AS, so use that (PR #114062)

2024-11-15 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/114062 >From d2d2d3d5db3f639aab178f9ca9a20db2842d2b65 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 29 Oct 2024 14:20:44 + Subject: [PATCH 1/9] `sret` args should always point to the `alloca` AS, so we can

[clang] [Clang] Implement CWG2351 `void{}` (PR #78060)

2024-11-15 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Looks like this PR was the cause of this regression: https://github.com/llvm/llvm-project/issues/116440 https://github.com/llvm/llvm-project/pull/78060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea edited https://github.com/llvm/llvm-project/pull/116257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Include runtimes for armv8.1m.main-none-eabi (PR #116420)

2024-11-15 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/116420 These are needed by some of our users. >From 028021ded3dee3f55ba26540f5c9cf1a1e8cbb36 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Tue, 12 Nov 2024 19:50:46 + Subject: [PATCH] [Fuchsia] Include runtime

[clang] Disable LIBCXX_INCLUDE_BENCHMARKS in Fuchsia cmake (PR #116446)

2024-11-15 Thread Caslyn Tonelli via cfe-commits
https://github.com/Caslyn created https://github.com/llvm/llvm-project/pull/116446 None >From eacaefef7cb0efe7dec5560803663200cc42302d Mon Sep 17 00:00:00 2001 From: Caslyn Tonelli Date: Fri, 15 Nov 2024 12:24:37 -0800 Subject: [PATCH] Disable LIBCXX_INCLUDE_BENCHMARKS for Fuchsia --- clang/

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Fix minor mistake in error message (PR #116132)

2024-11-15 Thread Julian Schmidt via cfe-commits
@@ -244,7 +244,7 @@ Changes in existing checks - Improved :doc:`modernize-use-starts-ends-with ` check to handle two cases - that can be replaced with ``ends_with`` + that can be replaced with ``ends_with``. Minor change to error message. 5chmidti wrote:

[clang] 64c4550 - [docs][asan][lsan] Drop list of supported architechures (#116302)

2024-11-15 Thread via cfe-commits
Author: Vitaly Buka Date: 2024-11-15T15:15:50-08:00 New Revision: 64c455077abe583f96fc19398712da9c1187ad61 URL: https://github.com/llvm/llvm-project/commit/64c455077abe583f96fc19398712da9c1187ad61 DIFF: https://github.com/llvm/llvm-project/commit/64c455077abe583f96fc19398712da9c1187ad61.diff L

[clang-tools-extra] [clang-tidy] Fix false positive in cppcoreguidelines-avoid-const-or-ref-data-members when detecting templated classes with inheritance (PR #115180)

2024-11-15 Thread Julian Schmidt via cfe-commits
@@ -13,79 +13,92 @@ using namespace clang::ast_matchers; namespace clang::tidy::cppcoreguidelines { -namespace { -AST_MATCHER(FieldDecl, isMemberOfLambda) { - return Node.getParent()->isLambda(); +static bool hasCopyConstructor(CXXRecordDecl const &Node) { + if (Node.needs

[clang-tools-extra] [clang-tidy] Fix false positive in cppcoreguidelines-avoid-const-or-ref-data-members when detecting templated classes with inheritance (PR #115180)

2024-11-15 Thread Julian Schmidt via cfe-commits
@@ -195,6 +195,10 @@ Changes in existing checks fix false positive that floating point variable is only used in increment expression. +- Improved :doc:`cppcoreguidelines-avoid-const-or-ref-data-members + ` check to + avoid false positive when detecting templated class w

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-15 Thread via cfe-commits
vabridgers wrote: I'll follow up after this PR is merged with a subsequent PR to split this LIT. If that's not acceptable please reopen this comment. Thanks. https://github.com/llvm/llvm-project/pull/114715 ___ cfe-c

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Matt Arsenault via cfe-commits
@@ -111,6 +111,18 @@ class LLVM_LIBRARY_VISIBILITY AMDGPUTargetInfo final : public TargetInfo { return getPointerWidthV(AddrSpace); } + virtual bool isAddressSpaceSupersetOf(LangAS A, LangAS B) const override { +// The flat address space AS(0) is a superset of all

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/115777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Joseph Huber via cfe-commits
@@ -111,6 +111,18 @@ class LLVM_LIBRARY_VISIBILITY AMDGPUTargetInfo final : public TargetInfo { return getPointerWidthV(AddrSpace); } + virtual bool isAddressSpaceSupersetOf(LangAS A, LangAS B) const override { +// The flat address space AS(0) is a superset of all

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [flang] [clang][driver] When -fveclib=ArmPL flag is in use, always link against libamath (PR #116432)

2024-11-15 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm edited https://github.com/llvm/llvm-project/pull/116432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Matt Arsenault via cfe-commits
@@ -111,6 +111,18 @@ class LLVM_LIBRARY_VISIBILITY AMDGPUTargetInfo final : public TargetInfo { return getPointerWidthV(AddrSpace); } + virtual bool isAddressSpaceSupersetOf(LangAS A, LangAS B) const override { +// The flat address space AS(0) is a superset of all

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-15 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh edited https://github.com/llvm/llvm-project/pull/116462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/116033 >From f79bd08bf910512c6c3b9d8ab2cd5162f9c0e5f8 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Wed, 13 Nov 2024 12:52:36 +0100 Subject: [PATCH 1/2] [clang-tidy] Enhance modernize-use-starts-ends-with wi

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/116033 >From 4fe224a3d16cff6532674516138fc6ff04678188 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Wed, 13 Nov 2024 12:52:36 +0100 Subject: [PATCH] [clang-tidy] Enhance modernize-use-starts-ends-with with

[clang] [analyzer][Solver] Early return if sym is concrete on assuming (PR #115579)

2024-11-15 Thread Balazs Benics via cfe-commits
steakhal wrote: @danix800 Could you please have a look at the failed test, such that we could reapply this PR? I reverted this soon after I realized the broken test is from this PR. https://github.com/llvm/llvm-project/pull/115579 ___ cfe-commits mail

[clang] [clang] Implement lifetime analysis for lifetime_capture_by(X) (PR #115921)

2024-11-15 Thread Utkarsh Saxena via cfe-commits
@@ -249,7 +254,7 @@ static void visitLocalsRetainedByReferenceBinding(IndirectLocalPath &Path, LocalVisitor Visit); template static bool isRecordWithAttr(QualType Type) { - if (auto *RD = Type->getAsCXXRecordDecl()) + if (a

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/116257 >From eb6fea771b0824fef979e5eef26718ecbc8c7f56 Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Thu, 14 Nov 2024 16:07:32 + Subject: [PATCH 1/2] [NFC][clang][FMV][TargetInfo] Refactor API for FMV

[clang] [llvm] AMDGPU: Add gfx950 subtarget definitions (PR #116307)

2024-11-15 Thread Jay Foad via cfe-commits
@@ -146,6 +146,11 @@ define amdgpu_kernel void @test_kernel() { ; RUN: llc -mtriple=amdgcn-amd-amdhsa --amdhsa-code-object-version=6 -mcpu=gfx9-generic -filetype=obj -O0 -o %t.o %s ; RUN: llvm-objdump -D --arch-name=amdgcn -mllvm --amdhsa-code-object-version=6 --mcpu=gfx9-gene

[clang] [llvm] AMDGPU: Add gfx950 subtarget definitions (PR #116307)

2024-11-15 Thread Jay Foad via cfe-commits
@@ -1617,6 +1617,7 @@ const EnumEntry ElfHeaderMipsFlags[] = { ENUM_ENT(EF_AMDGPU_MACH_AMDGCN_GFX90A, "gfx90a"), \ ENUM_ENT(EF_AMDGPU_MACH_AMDGCN_GFX90C, "gfx90c"), \ ENUM_ENT(EF_AMDGPU_MACH_AMDGCN_GFX940, "gfx940"),

[clang] [analyzer] Print the callee name in CallEnter in exploded-graph-rewriter (PR #116225)

2024-11-15 Thread Donát Nagy via cfe-commits
@@ -86,6 +86,8 @@ def __init__(self, json_pp): if json_pp["location"] is not None else None ) +elif self.kind == "CallEnter": +self.callee_decl = json_pp["callee_decl"] if "callee_decl" in json_pp else "None"

[clang] [analyzer] Print the callee name in CallEnter in exploded-graph-rewriter (PR #116225)

2024-11-15 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM, with one minor simplification suggestion marked in an inline comment. Disclaimer: I don't use this exploded-graph-rewriter tool, but the change seems to be straightforward and useful. https://github.com/llvm/llvm-project/pull/11622

[clang] [analyzer] Print the callee name in CallEnter in exploded-graph-rewriter (PR #116225)

2024-11-15 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/116225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b9d678d - [Clang] Use TargetInfo when deciding if an address space is compatible (#115777)

2024-11-15 Thread via cfe-commits
Author: Joseph Huber Date: 2024-11-15T06:58:36-06:00 New Revision: b9d678d22f74ebd6e34f0a3501fb01d3d80984e7 URL: https://github.com/llvm/llvm-project/commit/b9d678d22f74ebd6e34f0a3501fb01d3d80984e7 DIFF: https://github.com/llvm/llvm-project/commit/b9d678d22f74ebd6e34f0a3501fb01d3d80984e7.diff

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/115777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP][OMPIRBuilder] Handle non-failing calls properly (PR #115863)

2024-11-15 Thread Sergio Afonso via cfe-commits
@@ -345,18 +344,15 @@ TEST_F(OpenMPIRBuilderTest, CreateBarrier) { IRBuilder<> Builder(BB); - OpenMPIRBuilder::InsertPointOrErrorTy BarrierIP1 = - OMPBuilder.createBarrier({IRBuilder<>::InsertPoint()}, OMPD_for); - assert(BarrierIP1 && "unexpected error"); + ASSERT_

[clang-tools-extra] Rename CODE_OWNERS -> Maintainers (PR #114544)

2024-11-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/114544 >From 6a9f356c13a2a391909cc2161318e4d6300e6a48 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Fri, 1 Nov 2024 10:43:14 -0400 Subject: [PATCH 1/6] Rename CODE_OWNERS -> Maintainers --- clang-tools-extr

[clang] Add Aaron Puchert as the maintainer for thread safety analysis (PR #115920)

2024-11-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/115920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[Driver][SYCL] Add initial SYCL offload compilation support" (PR #116381)

2024-11-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/116381 Reverts llvm/llvm-project#107493 Failing bots include: https://lab.llvm.org/buildbot/#/builders/190/builds/9546 https://lab.llvm.org/buildbot/#/builders/46/builds/7938 >From 2a02b2ef960820c9045fe180c403583

[clang] 62c3c1c - Revert "[Driver][SYCL] Add initial SYCL offload compilation support" (#116381)

2024-11-15 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-11-15T08:04:59-05:00 New Revision: 62c3c1cad78b3354432fe44285f3472d9c93a45a URL: https://github.com/llvm/llvm-project/commit/62c3c1cad78b3354432fe44285f3472d9c93a45a DIFF: https://github.com/llvm/llvm-project/commit/62c3c1cad78b3354432fe44285f3472d9c93a45a.diff

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-11-15 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: I reverted the changes due to the failing bots; you can make a new PR with the issues fixed and resubmit for a quick review. https://github.com/llvm/llvm-project/pull/107493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [llvm] Revert "[Driver][SYCL] Add initial SYCL offload compilation support" (PR #116381)

2024-11-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/116381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cb4b943 - Add Aaron Puchert as the maintainer for thread safety analysis (#115920)

2024-11-15 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-11-15T08:03:10-05:00 New Revision: cb4b943294fad949b1965f3eea2c5b492e7e3eba URL: https://github.com/llvm/llvm-project/commit/cb4b943294fad949b1965f3eea2c5b492e7e3eba DIFF: https://github.com/llvm/llvm-project/commit/cb4b943294fad949b1965f3eea2c5b492e7e3eba.diff

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-11-15 Thread via cfe-commits
https://github.com/joaosaffran created https://github.com/llvm/llvm-project/pull/116331 - adding Flatten and Branch to if stmt. - adding dxil control flow hint metadata generation - modifing spirv OpSelectMerge to account for the specific attributes. Closes #70112 >From 3c792216f88e87b69b3ea74

[clang] e5ac914 - [analyzer][taint] Recognize tainted LazyCompoundVals (4/4) (#115919)

2024-11-15 Thread via cfe-commits
Author: Balazs Benics Date: 2024-11-15T10:56:04+01:00 New Revision: e5ac9145ba2951b6454b13499f375284bdbde689 URL: https://github.com/llvm/llvm-project/commit/e5ac9145ba2951b6454b13499f375284bdbde689 DIFF: https://github.com/llvm/llvm-project/commit/e5ac9145ba2951b6454b13499f375284bdbde689.diff

[clang] [analyzer][taint] Recognize tainted LazyCompoundVals (4/4) (PR #115919)

2024-11-15 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/115919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Trigger copy event when copying empty structs (3/4) (PR #115918)

2024-11-15 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/115918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Extend bugprone-use-after-move check to handle std::optional::reset() and std::any::reset() (PR #114255)

2024-11-15 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Hm, on mobile it wants to use my email as the commit email... I'll merge the PR later then. https://github.com/llvm/llvm-project/pull/114255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [clang] Implement lifetime analysis for lifetime_capture_by(X) (PR #115921)

2024-11-15 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/115921 >From 2cef37ecdb81452a8f5882dfe765167c1e45b7b6 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 13 Nov 2024 10:24:33 + Subject: [PATCH 1/6] Implement semantics for lifetime analysis --- clang/include

[clang] 0b0d611 - [Driver][SYCL] Add initial SYCL offload compilation support (#107493)

2024-11-15 Thread via cfe-commits
Author: Michael Toguchi Date: 2024-11-15T07:14:21-05:00 New Revision: 0b0d61101fa0648a09ebc1dc7a26ee9a89e91be8 URL: https://github.com/llvm/llvm-project/commit/0b0d61101fa0648a09ebc1dc7a26ee9a89e91be8 DIFF: https://github.com/llvm/llvm-project/commit/0b0d61101fa0648a09ebc1dc7a26ee9a89e91be8.dif

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-11-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/107493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-11-15 Thread via cfe-commits
github-actions[bot] wrote: @mdtoguchi Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a buil

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-11-15 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Given that it's been a week, I'm merging; if @MaskRay has any concerns, they can be addressed post commit. https://github.com/llvm/llvm-project/pull/107493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-11-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/7938 Here i

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-11-15 Thread via cfe-commits
Sirraide wrote: Fyi, Erich is unavailable again until later this month, so you’ll have to wait a bit longer unfortunately... https://github.com/llvm/llvm-project/pull/112521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)

2024-11-15 Thread via cfe-commits
@@ -7,26 +7,39 @@ Checks for common roundabout ways to express ``starts_with`` and ``ends_with`` and suggests replacing with the simpler method when it is available. Notably, this will work with ``std::string`` and ``std::string_view``. -.. code-block:: c++ +The check handle

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-11-15 Thread Yihe Li via cfe-commits
https://github.com/Mick235711 updated https://github.com/llvm/llvm-project/pull/112521 >From 59f7dbdd8eed456b76e93f6260bf0e361242e9fd Mon Sep 17 00:00:00 2001 From: Yihe Li Date: Wed, 16 Oct 2024 18:53:04 +0800 Subject: [PATCH 1/4] [clang] Improve diagnostic on [[nodiscard]] attribute --- cla

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-11-15 Thread Yihe Li via cfe-commits
@@ -9300,6 +9300,12 @@ def warn_unused_container_subscript_expr : Warning< def warn_unused_call : Warning< "ignoring return value of function declared with %0 attribute">, InGroup; +def warn_unused_return_type : Warning< + "ignoring %select{return value|temporary}0 of type

[libunwind] [libunwind][Haiku] Improve support (PR #115462)

2024-11-15 Thread Jérôme Duval via cfe-commits
@@ -2917,7 +2980,8 @@ template int UnwindCursor::step(bool stage2) { // Use unwinding info to modify register set as if function returned. int result; -#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) +#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) ||

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/115762 >From aff962d795e56f7b41af44860feb77e656091b78 Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Mon, 11 Nov 2024 20:10:01 + Subject: [PATCH 1/2] [clang][FMV] Fix crash with cpu_specific attribute.

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: I believe the latest revision is a better fix. https://github.com/llvm/llvm-project/pull/115762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4d6a5fc - [Driver] Remove unused includes (NFC) (#116316)

2024-11-15 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-11-15T07:26:05-08:00 New Revision: 4d6a5fc702e568b0456c4d8f9e2307eb6d81e955 URL: https://github.com/llvm/llvm-project/commit/4d6a5fc702e568b0456c4d8f9e2307eb6d81e955 DIFF: https://github.com/llvm/llvm-project/commit/4d6a5fc702e568b0456c4d8f9e2307eb6d81e955.diff L

[clang] [Driver] Remove unused includes (NFC) (PR #116316)

2024-11-15 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/116316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-11-15 Thread Erich Keane via cfe-commits
@@ -148,6 +148,19 @@ C++ Specific Potentially Breaking Changes // Now diagnoses with an error. void f(int& i [[clang::lifetimebound]]); +- Clang will now prefer the ``[[nodiscard]]`` declaration on function declarations over ``[[nodiscard]]`` erichkea

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-11-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/112521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-11-15 Thread Yihe Li via cfe-commits
https://github.com/Mick235711 updated https://github.com/llvm/llvm-project/pull/112521 >From 59f7dbdd8eed456b76e93f6260bf0e361242e9fd Mon Sep 17 00:00:00 2001 From: Yihe Li Date: Wed, 16 Oct 2024 18:53:04 +0800 Subject: [PATCH 1/5] [clang] Improve diagnostic on [[nodiscard]] attribute --- cla

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-11-15 Thread Yihe Li via cfe-commits
@@ -148,6 +148,19 @@ C++ Specific Potentially Breaking Changes // Now diagnoses with an error. void f(int& i [[clang::lifetimebound]]); +- Clang will now prefer the ``[[nodiscard]]`` declaration on function declarations over ``[[nodiscard]]`` Mick2357

[clang] 91aad9b - [Clang][AArch64]Fix Name and Mangle name for scalar fp8 (#114983)

2024-11-15 Thread via cfe-commits
Author: CarolineConcatto Date: 2024-11-15T09:19:39Z New Revision: 91aad9bfb24347db4c4fed7b0ab5e4180ddcdc7f URL: https://github.com/llvm/llvm-project/commit/91aad9bfb24347db4c4fed7b0ab5e4180ddcdc7f DIFF: https://github.com/llvm/llvm-project/commit/91aad9bfb24347db4c4fed7b0ab5e4180ddcdc7f.diff L

[clang] [Clang][AArch64]Fix Name and Mangle name for scalar fp8 (PR #114983)

2024-11-15 Thread via cfe-commits
https://github.com/CarolineConcatto closed https://github.com/llvm/llvm-project/pull/114983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Extend bugprone-use-after-move check to handle std::optional::reset() and std::any::reset() (PR #114255)

2024-11-15 Thread Julian Schmidt via cfe-commits
5chmidti wrote: > Thanks! Could we merge this? Yes, thanks https://github.com/llvm/llvm-project/pull/114255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >