[clang] [llvm] [ARM] Fix operand order for MVE predicated VFMAS (PR #115908)

2024-11-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-arm Author: Oliver Stannard (ostannard) Changes For most MVE predicated FMA instructions, disabled lanes will contain the value in the addend operand. However, The VFMAS instruction takes the addend in a GPR, and the output register is shared w

[clang] [llvm] [ARM] Fix operand order for MVE predicated VFMAS (PR #115908)

2024-11-12 Thread Oliver Stannard via cfe-commits
https://github.com/ostannard created https://github.com/llvm/llvm-project/pull/115908 For most MVE predicated FMA instructions, disabled lanes will contain the value in the addend operand. However, The VFMAS instruction takes the addend in a GPR, and the output register is shared with the firs

[clang] Reapply "[clang] Introduce [[clang::lifetime_capture_by(X)]] (PR #115823)

2024-11-12 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/115823 >From 3c233df64906972016c26909263cfd53940d87a0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 12 Nov 2024 04:28:37 + Subject: [PATCH 1/3] Reapply "[clang] Introduce [[clang::lifetime_capture_by(X)]]

[clang] Add Aaron Puchert as the maintainer for thread safety analysis (PR #115920)

2024-11-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes Aaron has been helping out with TSA for several years and is highly knowledgeable about the implementation. --- Full diff: https://github.com/llvm/llvm-project/pull/115920.diff 1 Files Affected: - (

[clang] [Clang] skip shadow warnings for enum constants in distinct class scopes (PR #115656)

2024-11-12 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon approved this pull request. LGTM, in case @Sirraide and @AaronBallman don't have any further comments. https://github.com/llvm/llvm-project/pull/115656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] Add Aaron Puchert as the maintainer for thread safety analysis (PR #115920)

2024-11-12 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/115920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] skip shadow warnings for enum constants in distinct class scopes (PR #115656)

2024-11-12 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. https://github.com/llvm/llvm-project/pull/115656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add [[clang::no_specializations]] (PR #101469)

2024-11-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > I went for only adding `[[clang::no_specialization]]` to function templates, > since the other cases seem even more unlikely to me and seem to have a higher > implementation complexity. Is that OK? Your test coverage also handles class templates and variable templates in

[clang] [Clang] Add [[clang::no_specializations]] (PR #101469)

2024-11-12 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > > I went for only adding `[[clang::no_specialization]]` to function > > templates, since the other cases seem even more unlikely to me and seem to > > have a higher implementation complexity. Is that OK? > > Your test coverage also handles class templates and variable templ

[clang] [Clang] Add [[clang::no_specializations]] (PR #101469)

2024-11-12 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: No real comments, other than FunctionTemplate being left out of the documentation. https://github.com/llvm/llvm-project/pull/101469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Clang] Add [[clang::no_specializations]] (PR #101469)

2024-11-12 Thread Erich Keane via cfe-commits
@@ -981,6 +981,15 @@ Query for this feature with ``__has_attribute(diagnose_if)``. }]; } +def NoSpecializationsDocs : Documentation { + let Category = DocCatDecl; + let Content = [{ +``[[clang::no_specializations]]`` can be applied to class or variable er

[clang] [Clang] Add [[clang::no_specializations]] (PR #101469)

2024-11-12 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/101469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Comments] Make @relates an inline comment command (PR #115040)

2024-11-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/115040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Fix false positives in warning againt 2-parameter std::span constructor (PR #115797)

2024-11-12 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 approved this pull request. Nice! nit: please add the pattern `std::span{std::addressor(...), 1}` to the comment: ``` // Given a two-param std::span construct call, matches iff the call has the // following forms: // 1. `std::span{new T[n], n}`, where `n` is a

[clang] [Clang][Comments] Make @relates an inline comment command (PR #115040)

2024-11-12 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/115040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-12 Thread Finn Plummer via cfe-commits
@@ -19108,6 +19108,21 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { /*ReturnType=*/Op0->getType(), CGM.getHLSLRuntime().getStepIntrinsic(), ArrayRef{Op0, Op1}, nullptr, "hlsl.step"); } + case Builtin::BI__builtin_hlsl_wave_active_any_true: { +Int

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-12 Thread Finn Plummer via cfe-commits
@@ -0,0 +1,17 @@ +; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv32v1.3-vulkan-unknown %s -o - | FileCheck %s inbelic wrote: I think we prefer `-mtriple=spirv-unknown-unknown`. You might need to use `spirv1.[5|6]` if you are using an new included spirv op.

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

2024-11-12 Thread via cfe-commits
no92 wrote: Rebased and updated the PR to include the feedback. We've decided to drop the `kernel` environment for now, and will maintain it out-of-tree for the time being. We might come up with a better solution for it in the future, also see @ArsenArsen's comment above for details why we use

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-12 Thread Finn Plummer via cfe-commits
@@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -fnative-half-type -triple \ inbelic wrote: I think we can remove the `-std=hlsl2021` flags. https://github.com/llvm/llvm-project/pull/115902 ___

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-12 Thread Finn Plummer via cfe-commits
https://github.com/inbelic commented: Nice work. Mostly just some nits and cleanups :) https://github.com/llvm/llvm-project/pull/115902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-12 Thread Finn Plummer via cfe-commits
@@ -93,6 +93,7 @@ def int_dx_rsqrt : DefaultAttrsIntrinsic<[llvm_anyfloat_ty], [LLVMMatchType<0>] def int_dx_wave_active_countbits : DefaultAttrsIntrinsic<[llvm_i32_ty], [llvm_i1_ty], [IntrConvergent, IntrNoMem]>; def int_dx_wave_getlaneindex : DefaultAttrsIntrinsic<[llvm_i32

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-12 Thread Finn Plummer via cfe-commits
@@ -202,6 +202,7 @@ defset list OpClasses = { def unpack4x8 : DXILOpClass; def viewID : DXILOpClass; def waveActiveAllEqual : DXILOpClass; + def waveActiveAnyTrue : DXILOpClass; inbelic wrote: You shouldn't define and use this, instead use `waveAnyTrue`

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-12 Thread Finn Plummer via cfe-commits
@@ -2091,6 +2091,12 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { return true; break; } + case Builtin::BI__builtin_hlsl_wave_active_any_true: { +if (SemaRef.checkArgCount(TheCall, 1)) + return true; + +break; +

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-12 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/115902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Introduce a new generic target `gfx9-4-generic` (PR #115190)

2024-11-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/115190 >From 43ef3b94c4a716134b4f3cdeb1405277cd06f6ea Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Wed, 6 Nov 2024 12:49:45 -0500 Subject: [PATCH] [AMDGPU] Introduce a new generic target `gfx9-4-generic` --- cla

[clang] [NFC][lang][TableGen] Simplify `EmitClangDiagsIndexName` (PR #115962)

2024-11-12 Thread Kazu Hirata via cfe-commits
@@ -1786,33 +1786,17 @@ void clang::EmitClangDiagGroups(const RecordKeeper &Records, raw_ostream &OS) { // Diagnostic name index generation //===--===// -namespace { -struct RecordIndexElement -{ - RecordIn

[clang] [NFC][Clang] Use StringRef and range for loops in SA/Syntax Emitters (PR #115972)

2024-11-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Use StringRef and range for loops in Clang SACheckers and Syntax emitters. --- Full diff: https://github.com/llvm/llvm-project/pull/115972.diff 2 Files Affected: - (modified) clang/utils/TableGen/ClangSAChe

[clang] [NFC][lang][TableGen] Simplify `EmitClangDiagsIndexName` (PR #115962)

2024-11-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/115962 >From 07c74bee58d1a56978b1cba00755cc3ca14cb71f Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 12 Nov 2024 15:51:54 -0800 Subject: [PATCH 1/2] [NFC][lang][TableGen] Simplify `EmitClangDiagsIndexName` Simp

[clang] [clang][Fuchsia] Have global dtors use llvm.global_dtors over atexit (PR #115788)

2024-11-12 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: To ensure we don't destroy objects that weren't constructed, you can use a guard variable of some sort, sure. I'm not quite sure what the goal is, here; are you trying to improve performance, or are you worried about the function pointers for security? >>Also, I'm not su

[clang] [NFC][Clang] Use StringRef and range for loops in SA/Syntax Emitters (PR #115972)

2024-11-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/115972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit stub version of OpenCL Kernel (PR #115821)

2024-11-12 Thread Aniket Lal via cfe-commits
https://github.com/lalaniket8 updated https://github.com/llvm/llvm-project/pull/115821 >From d3f01b0578135588fb04596dcaa57d442be7a3d7 Mon Sep 17 00:00:00 2001 From: anikelal Date: Tue, 12 Nov 2024 11:30:45 +0530 Subject: [PATCH] [Clang][AMDGPU] Emit stub version of OpenCL Kernel OpenCL allows

[clang] [Darwin][Driver][clang] Prioritise `-isysroot` over `--sysroot` consistently (PR #115993)

2024-11-12 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab created https://github.com/llvm/llvm-project/pull/115993 On Darwin, `clang` currently prioritises `-isysroot` over `--sysroot` when selecting headers, but does the reverse when setting `-syslibroot` for the linker, which determines library selection. This is wrong, b

[clang] [Darwin][Driver][clang] Prioritise `-isysroot` over `--sysroot` consistently (PR #115993)

2024-11-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Carlo Cabrera (carlocab) Changes On Darwin, `clang` currently prioritises `-isysroot` over `--sysroot` when selecting headers, but does the reverse when setting `-syslibroot` for the linker, which determines library selection. This is wron

[clang] [TableGen] Use heterogenous lookups with std::map (NFC) (PR #115994)

2024-11-12 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/115994 Heterogenous lookups allow us to call find with StringRef, avoiding a temporary heap allocation of std::string. >From 9fb5006cd20c4ecb3a5aaec2bdd355089a5dabc9 Mon Sep 17 00:00:00 2001 From: Kazu Hirata

[clang] [TableGen] Use heterogenous lookups with std::map (NFC) (PR #115994)

2024-11-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Heterogenous lookups allow us to call find with StringRef, avoiding a temporary heap allocation of std::string. --- Full diff: https://github.com/llvm/llvm-project/pull/115994.diff 1 Files Affected:

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2024-11-12 Thread Matt Arsenault via cfe-commits
arsenm wrote: Is this still relevant? https://github.com/llvm/llvm-project/pull/67721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Fix false positives in warning againt 2-parameter std::span constructor (PR #115797)

2024-11-12 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/115797 >From d0a95e158f6d39fdb284c067f945299e27029dbc Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Mon, 11 Nov 2024 17:18:40 -0800 Subject: [PATCH] [-Wunsafe-buffer-usage] Fix false positive in warnging aga

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-11-12 Thread kadir çetinkaya via cfe-commits
kadircet wrote: @AaronBallman merging this to main now. PLMK if you have any concerns, I am happy to address them post-submit (or revert if need be) https://github.com/llvm/llvm-project/pull/112517 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [codegen] Fix crash in codegen caused by pointer calculation overflow (PR #115791)

2024-11-12 Thread via cfe-commits
https://github.com/vabridgers edited https://github.com/llvm/llvm-project/pull/115791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [NFC] Explicitly pass a VFS when creating DiagnosticsEngine (PR #115852)

2024-11-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 41e3919ded78d8870f7c95e9181c7f7e29aa3cc4 a999e3081d16170d510ab74222564fbcb4c6a7c2 --e

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-12 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @SahilPatidar, can you revert if there is not an easy fix? https://github.com/llvm/llvm-project/pull/110418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang-Repl] Add support for out-of-process execution." (PR #115854)

2024-11-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (SahilPatidar) Changes Reverts llvm/llvm-project#110418 Buildbot encountered a failure. --- Patch is 26.72 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/115854.diff 8 Files Affected:

[clang] [clang-tools-extra] [NFC] Explicitly pass a VFS when creating DiagnosticsEngine (PR #115852)

2024-11-12 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/115852 From a999e3081d16170d510ab74222564fbcb4c6a7c2 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Tue, 12 Nov 2024 12:09:29 +0100 Subject: [PATCH 1/2] [NFC] Explicitly pass a VFS when creating DiagnosticsEngi

[clang-tools-extra] e385e0d - [clangd] [Modules] Support Reusable Modules Builder (#106683)

2024-11-12 Thread via cfe-commits
Author: Chuanqi Xu Date: 2024-11-12T17:45:05+08:00 New Revision: e385e0d3e71e17da0b2023f480259c95923707bd URL: https://github.com/llvm/llvm-project/commit/e385e0d3e71e17da0b2023f480259c95923707bd DIFF: https://github.com/llvm/llvm-project/commit/e385e0d3e71e17da0b2023f480259c95923707bd.diff LO

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-12 Thread Tom Weaver via cfe-commits
TomWeaver18 wrote: Hello and greetings from the UK, is anyone looking at the above build bot failures? I'm looking to get the bots green again within a few hours, are you able to help out? thanks in advance, Tom https://github.com/llvm/llvm-project/pull/110418 ___

[clang] [llvm] Reland [clang][AArch64] Add getHostCPUFeatures to query for enabled f… (PR #115467)

2024-11-12 Thread Elvina Yakubova via cfe-commits
ElvinaYakubova wrote: @davemgreen all tests are shown as passed, and I noticed the same failure on some other PRs. Can this be an infrastructure problem then? Regarding the original error - it was showing "unsupported argument 'native' to option '-mcpu='" for the cases where the target was AAr

[clang] [clang-tools-extra] [NFC] Explicitly pass a VFS when creating DiagnosticsEngine (PR #115852)

2024-11-12 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. LGTM, but please give others the time to chime in and approve. https://github.com/llvm/llvm-project/pull/115852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [clang-tools-extra] [NFC] Explicitly pass a VFS when creating DiagnosticsEngine (PR #115852)

2024-11-12 Thread Boaz Brickner via cfe-commits
@@ -368,11 +365,10 @@ IntrusiveRefCntPtr CompilerInstance::createDiagnostics( SetUpDiagnosticLog(Opts, CodeGenOpts, *Diags); if (!Opts->DiagnosticSerializationFile.empty()) -SetupSerializedDiagnostics(Opts, *Diags, - Opts->DiagnosticSer

[clang] [clang-tools-extra] [NFC] Explicitly pass a VFS when creating DiagnosticsEngine (PR #115852)

2024-11-12 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb approved this pull request. Thanks for fixing! It might be worth understanding whether this should have been caught by some test. We might want to add a test or a check that would catch this. https://github.com/llvm/llvm-project/pull/115852 _

[clang] [clang-tools-extra] [NFC] Explicitly pass a VFS when creating DiagnosticsEngine (PR #115852)

2024-11-12 Thread Boaz Brickner via cfe-commits
@@ -332,23 +332,20 @@ static void SetupSerializedDiagnostics(DiagnosticOptions *DiagOpts, } } -void CompilerInstance::createDiagnostics(DiagnosticConsumer *Client, +void CompilerInstance::createDiagnostics(llvm::vfs::FileSystem &VFS, +

[clang] [clang-tools-extra] [NFC] Explicitly pass a VFS when creating DiagnosticsEngine (PR #115852)

2024-11-12 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb edited https://github.com/llvm/llvm-project/pull/115852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-armv7-global-isel` running on `linaro-clang-armv7-global-isel` while building `clang` at step 7 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/39/builds/2785 Here is the relev

[clang] [llvm] [X86][AMX] Support AMX-TRANSPOSE, part 2 (PR #115660)

2024-11-12 Thread Feng Zou via cfe-commits
@@ -275,6 +276,27 @@ std::pair ShapeCalculator::getShape(IntrinsicInst *II, Col = II->getArgOperand(1); break; } + case Intrinsic::x86_ttdpbf16ps_internal: + case Intrinsic::x86_ttdpfp16ps_internal: + case Intrinsic::x86_ttcmmimfp16ps_internal: + case Intrinsic::

[clang] [compiler-rt] [libc] [lld] [lldb] [llvm] [mlir] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-11-12 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/99891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[analyzer][NFC] Make RegionStore dumps deterministic" (PR #115881)

2024-11-12 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/115881 Reverts llvm/llvm-project#115615 There are two problems with this PR: 1) If any of the dumps contains a store with a symbolic binding, we crash. 2) The memory space clusters come last among the clusters, whic

[clang] Revert "[analyzer][NFC] Make RegionStore dumps deterministic" (PR #115881)

2024-11-12 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/115881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter (PR #115573)

2024-11-12 Thread Rahul Joshi via cfe-commits
@@ -185,10 +174,8 @@ static void groupDiagnostics(ArrayRef Diags, } // Assign unique ID numbers to the groups. - unsigned IDNo = 0; - for (std::map::iterator - I = DiagsInGroup.begin(), E = DiagsInGroup.end(); I != E; ++I, ++IDNo) -I->second.IDNo = IDNo; + fo

[clang] Revert "[analyzer][NFC] Make RegionStore dumps deterministic" (PR #115881)

2024-11-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes Reverts llvm/llvm-project#115615 There are two problems with this PR: 1) If any of the dumps contains a store with a symbolic binding, we crash. 2) The memory space clusters come last am

[clang] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter (PR #115573)

2024-11-12 Thread Rahul Joshi via cfe-commits
@@ -468,11 +442,9 @@ static StringRef getModifierName(ModifierType MT) { return "objcclass"; case MT_ObjCInstance: return "objcinstance"; - case MT_Unknown: + default: jurahul wrote: Thanks. I'll revert this back. https://github.com/llvm/llvm-proj

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-11-12 Thread Michael Buch via cfe-commits
Michael137 wrote: Hmm this one's a bit strange. Looks like the issue is in: ``` // Clang-diagnostics pragmas always take precedence over suppression mapping. if (!Mapping.isPragma()) { // We also use presumed locations here to improve reproduci

[clang] Reapply "[clang] Introduce [[clang::lifetime_capture_by(X)]] (PR #115823)

2024-11-12 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/115823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter (PR #115573)

2024-11-12 Thread Erich Keane via cfe-commits
@@ -185,10 +174,8 @@ static void groupDiagnostics(ArrayRef Diags, } // Assign unique ID numbers to the groups. - unsigned IDNo = 0; - for (std::map::iterator - I = DiagsInGroup.begin(), E = DiagsInGroup.end(); I != E; ++I, ++IDNo) -I->second.IDNo = IDNo; + fo

[clang] Reapply "[clang] Introduce [[clang::lifetime_capture_by(X)]] (PR #115823)

2024-11-12 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/115823 >From 3c233df64906972016c26909263cfd53940d87a0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 12 Nov 2024 04:28:37 + Subject: [PATCH 1/2] Reapply "[clang] Introduce [[clang::lifetime_capture_by(X)]]

[clang] Reapply "[clang] Introduce [[clang::lifetime_capture_by(X)]] (PR #115823)

2024-11-12 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Fixed the issues. Added more details in the description. https://github.com/llvm/llvm-project/pull/115823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter (PR #115573)

2024-11-12 Thread Rahul Joshi via cfe-commits
@@ -970,10 +942,11 @@ struct DiagTextPrinter : DiagTextVisitor { void VisitPlural(PluralPiece *P) { Result += "%plural{"; assert(P->Options.size() == P->OptionPrefixes.size()); -for (unsigned I = 0, End = P->Options.size(); I < End; ++I) { - if (P->OptionPre

[clang] Enable AST mutation in the constant evaluator (PR #115168)

2024-11-12 Thread Erich Keane via cfe-commits
@@ -352,6 +353,16 @@ struct SkipBodyInfo { NamedDecl *New = nullptr; }; +/// Implementation of EvalASTMutator interface that enables constant evaluator +/// to modify AST, e.g. to instantiate templates. +struct SemaASTMutator : EvalASTMutator { erichkeane wr

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-12 Thread Erich Keane via cfe-commits
erichkeane wrote: > > Wouldn't mind it if @Fznamznon took a look though, IIRC, she did a bunch of > > work with cpu_specific/cpu_dispatch. > > I don't think I did. I'm not familiar with this area to provide any opinion. Ah, hrmph... maybe it was @elizabethandrews who did a bunch of multiversio

[clang] Reapply "[clang] Introduce [[clang::lifetime_capture_by(X)]] (PR #115823)

2024-11-12 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/115823 >From 3c233df64906972016c26909263cfd53940d87a0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 12 Nov 2024 04:28:37 + Subject: [PATCH 1/2] Reapply "[clang] Introduce [[clang::lifetime_capture_by(X)]]

[clang] Enable AST mutation in the constant evaluator (PR #115168)

2024-11-12 Thread Erich Keane via cfe-commits
@@ -8328,6 +8329,13 @@ class ExprEvaluatorBase const FunctionDecl *Definition = nullptr; Stmt *Body = FD->getBody(Definition); +if (Info.Ctx.getLangOpts().CPlusPlus26 && Info.getASTMutator() && erichkeane wrote: Based on our discussion, the C++26

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-11-12 Thread kadir çetinkaya via cfe-commits
kadircet wrote: so https://github.com/llvm/llvm-project/commit/12e3ed8de8c6063b15916b3faf67c8c9cd17df1f should resolve both lldb buildbot breakage and compile time regression in clang. that being said, I don't think https://github.com/llvm/llvm-project/commit/12e3ed8de8c6063b15916b3faf67c8c9

[clang] Revert "[analyzer][NFC] Make RegionStore dumps deterministic" (PR #115881)

2024-11-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `libc-x86_64-debian-dbg` running on `libc-x86_64-debian` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/93/builds/9969 Here is the relevant piece of the bu

[clang] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter (PR #115573)

2024-11-12 Thread Erich Keane via cfe-commits
@@ -970,10 +942,11 @@ struct DiagTextPrinter : DiagTextVisitor { void VisitPlural(PluralPiece *P) { Result += "%plural{"; assert(P->Options.size() == P->OptionPrefixes.size()); -for (unsigned I = 0, End = P->Options.size(); I < End; ++I) { - if (P->OptionPre

[clang] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter (PR #115573)

2024-11-12 Thread Erich Keane via cfe-commits
@@ -1553,15 +1526,13 @@ static void emitDiagSubGroups(std::map &DiagsInGroup, RecordVec &GroupsInPedantic, raw_ostream &OS) { OS << "static const int16_t DiagSubGroups[] = {\n" << " /* Empty */ -1,\n"; - for (auto const &I : DiagsInGroup)

[libclc] [libclc] Move sign to the CLC builtins library (PR #115699)

2024-11-12 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/115699 >From 47512ee4162318160964f1af132be90bed67c90c Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Thu, 7 Nov 2024 12:40:56 + Subject: [PATCH 1/2] [libclc] Move sign to the CLC builtins library This pat

[clang] [clang][analyzer] Bring checker 'alpha.unix.cstring.NotNullTerminated' out of alpha (PR #113899)

2024-11-12 Thread Balázs Kéri via cfe-commits
@@ -53,3 +53,7 @@ struct TestNotNullTerm { strlen((char *)&x); // expected-warning{{Argument to string length function is not a null-terminated string}} } }; + +void test_notcstring_tempobject() { + strlen((char[]){'a', 0}); // expected-warning{{Argument to string lengt

[clang] Revert "[analyzer][NFC] Make RegionStore dumps deterministic" (PR #115881)

2024-11-12 Thread Balazs Benics via cfe-commits
steakhal wrote: We crash because even calling the `getRegion()` raises an assert that the binding should be a symbolic binding. https://github.com/llvm/llvm-project/pull/115881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [Clang] enhance diagnostic by attaching source location to deduced type in trailing return without auto (PR #115786)

2024-11-12 Thread Mariya Podchishchaeva via cfe-commits
@@ -4887,9 +4887,18 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state, cast(T)->getKeyword() != AutoTypeKeyword::Auto || cast(T)->isConstrained())) { -S.Diag(D.getDecl

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-msan` running on `sanitizer-buildbot5` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/164/builds/4509 Here is the releva

[clang] [clang][NFC] add release note for n3030 support (PR #115648)

2024-11-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM and thanks for the drive-by typo fix. :-) https://github.com/llvm/llvm-project/pull/115648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [Clang] [NFC] Add "human" diagnostic argument format (PR #115835)

2024-11-12 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb updated https://github.com/llvm/llvm-project/pull/115835 >From ccf18e49f884b4430dff70d59fb3236259661f9d Mon Sep 17 00:00:00 2001 From: Boaz Brickner Date: Tue, 12 Nov 2024 10:19:58 +0100 Subject: [PATCH 1/3] [Clang] [NFC] Add "human" diagnostic argument format This

[clang] [Clang] [NFC] Add "human" diagnostic argument format (PR #115835)

2024-11-12 Thread Boaz Brickner via cfe-commits
@@ -315,6 +315,18 @@ Description: than ``1`` are not supported. This formatter is currently hard-coded to use English ordinals. +**"human" format** + +Example: + ``"total size is %human0 bytes"`` +Class: + Integers +Description: + This is a formatter which represents t

[clang] [Clang] [NFC] Add "human" diagnostic argument format (PR #115835)

2024-11-12 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. https://github.com/llvm/llvm-project/pull/115835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] enhance diagnostic by attaching source location to deduced type in trailing return without auto (PR #115786)

2024-11-12 Thread Oleksandr T. via cfe-commits
@@ -4887,9 +4887,18 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state, cast(T)->getKeyword() != AutoTypeKeyword::Auto || cast(T)->isConstrained())) { -S.Diag(D.getDecl

[clang] [clang][APINotes] Add support for the SwiftEscapable attribute (PR #115866)

2024-11-12 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun created https://github.com/llvm/llvm-project/pull/115866 This is similar to SwiftCopyable. Also fix missing SwiftCopyable dump for TagInfo. From 70ebdd0a63397130e45b79b3c6096c1847c07110 Mon Sep 17 00:00:00 2001 From: Gabor Horvath Date: Tue, 12 Nov 2024 13:07:01 +

[clang] [clang][APINotes] Add support for the SwiftEscapable attribute (PR #115866)

2024-11-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Gábor Horváth (Xazax-hun) Changes This is similar to SwiftCopyable. Also fix missing SwiftCopyable dump for TagInfo. --- Full diff: https://github.com/llvm/llvm-project/pull/115866.diff 10 Files Affected: - (modified) clang/include/cla

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-11-12 Thread Michael Buch via cfe-commits
Michael137 wrote: > > FYI, looks like this is causing following LLDB tests to fail: > > https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/15106/execution/node/97/log/ > > ``` > > Unresolved Tests (17): > > lldb-api :: > > commands/expression/import-std-module/array/TestArray

[clang] [clang-tools-extra] [llvm] Add code completion for C++20 keywords. (PR #107982)

2024-11-12 Thread via cfe-commits
16bit-ykiko wrote: @cor3ntin Can we merge this PR? https://github.com/llvm/llvm-project/pull/107982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 12e3ed8 - [clang] Avoid possibly expensive SM call when suppression-mappings are off

2024-11-12 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2024-11-12T15:57:38+01:00 New Revision: 12e3ed8de8c6063b15916b3faf67c8c9cd17df1f URL: https://github.com/llvm/llvm-project/commit/12e3ed8de8c6063b15916b3faf67c8c9cd17df1f DIFF: https://github.com/llvm/llvm-project/commit/12e3ed8de8c6063b15916b3faf67c8c9cd17df1f.dif

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-12 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Hmm... I don't know why that would be. Replacing the declaration seems reasonable/necessary in some cases? Though I'm a little frightened by the test changes as a result Wouldn't mind it if @Fznamznon took a look though, IIRC, she did a bunch of work

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-12 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: > Wouldn't mind it if @Fznamznon took a look though, IIRC, she did a bunch of > work with cpu_specific/cpu_dispatch. I don't think I did. I'm not familiar with this area to provide any opinion. https://github.com/llvm/llvm-project/pull/115762 _

[clang] [Clang] Prevent Null Pointer Dereference in in sema::​isNormalAssignmentOperator() (PR #115880)

2024-11-12 Thread via cfe-commits
https://github.com/smanna12 created https://github.com/llvm/llvm-project/pull/115880 This patch replaces dyn_cast<> with cast<> for CXXMethodDecl in isNormalAssignmentOperator() function, assuming FD is always a CXXMethodDecl. This change simplifies the code by removing the null check and rely

[clang] [Clang] Prevent Null Pointer Dereference in in sema::​isNormalAssignmentOperator() (PR #115880)

2024-11-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (smanna12) Changes This patch replaces dyn_cast<> with cast<> for CXXMethodDecl in isNormalAssignmentOperator() function, assuming FD is always a CXXMethodDecl. This change simplifies the code by removing the null check and relying o

[clang] [Clang] Prevent Null Pointer Dereference in in sema::​isNormalAssignmentOperator() (PR #115880)

2024-11-12 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/115880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Allow import of similar friend template with different depth (PR #115734)

2024-11-12 Thread Balázs Kéri via cfe-commits
@@ -6120,6 +6119,19 @@ ExpectedDecl ASTNodeImporter::VisitClassTemplateDecl(ClassTemplateDecl *D) { // see ASTTests test ImportExistingFriendClassTemplateDef. continue; } +// When importing a friend, it is possible that multiple declarations

[clang] [Clang] enhance diagnostic by attaching source location to deduced type in trailing return without auto (PR #115786)

2024-11-12 Thread Mariya Podchishchaeva via cfe-commits
@@ -652,6 +652,7 @@ Bug Fixes to C++ Support an implicitly instantiated class template specialization. (#GH51051) - Fixed an assertion failure caused by invalid enum forward declarations. (#GH112208) - Name independent data members were not correctly initialized from default

[clang] [Clang] enhance diagnostic by attaching source location to deduced type in trailing return without auto (PR #115786)

2024-11-12 Thread Mariya Podchishchaeva via cfe-commits
@@ -4887,9 +4887,18 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state, cast(T)->getKeyword() != AutoTypeKeyword::Auto || cast(T)->isConstrained())) { -S.Diag(D.getDecl

[clang] [Clang] enhance diagnostic by attaching source location to deduced type in trailing return without auto (PR #115786)

2024-11-12 Thread Mariya Podchishchaeva via cfe-commits
@@ -4887,9 +4887,18 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state, cast(T)->getKeyword() != AutoTypeKeyword::Auto || cast(T)->isConstrained())) { -S.Diag(D.getDecl

[clang] [Clang] enhance diagnostic by attaching source location to deduced type in trailing return without auto (PR #115786)

2024-11-12 Thread Mariya Podchishchaeva via cfe-commits
@@ -4887,9 +4887,18 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state, cast(T)->getKeyword() != AutoTypeKeyword::Auto || cast(T)->isConstrained())) { -S.Diag(D.getDecl

[clang] Revert "[Clang-Repl] Add support for out-of-process execution." (PR #115854)

2024-11-12 Thread via cfe-commits
https://github.com/SahilPatidar created https://github.com/llvm/llvm-project/pull/115854 Reverts llvm/llvm-project#110418 Buildbot encountered a failure. >From d23ed7b82735b367501949541b7194bbb6b4fb86 Mon Sep 17 00:00:00 2001 From: SahilPatidar Date: Tue, 12 Nov 2024 16:46:14 +0530 Subject: [

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-12 Thread Tom Weaver via cfe-commits
TomWeaver18 wrote: Thanks for the revert 👍 https://github.com/llvm/llvm-project/pull/110418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >