[clang] [llvm] [Transforms][Utils][PromoteMem2Reg] Propagate nnan flag on par with the nsz flag (PR #114271)

2024-11-05 Thread Paul Osmialowski via cfe-commits
pawosm-arm wrote: > We should probably also handle `no-infs-fp-math` to save the next person the > trouble. I'd leave it to a separate PR, as this one has a specific story behind the proposed change, anything extra would go beyond it. https://github.com/llvm/llvm-project/pull/114271 _

[clang] [clang] Fix the post-filtering heuristic for GSLPointer. (PR #114044)

2024-11-05 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/114044 >From 1252cfdea59e94a91750a49fd5aaab4a6c2650b6 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 1 Nov 2024 16:51:03 +0100 Subject: [PATCH 1/3] [clang] Fix the post-filtering heuristics for GSLPointer case.

[clang] [llvm] [Transforms][Utils][PromoteMem2Reg] Propagate nnan flag on par with the nsz flag (PR #114271)

2024-11-05 Thread Paul Walker via cfe-commits
paulwalker-arm wrote: > Yet we see a value in the change proposed here too hence a good reason for > merging it. I've clearly misunderstood the context of the rebase. What is the value in merging this change if the original issue has already been resolved? I guess this fix is simpler and

[clang] Add Mariya as maintainer for constant expressions & Sema (PR #114974)

2024-11-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/114974 Mariya has extensive knowledge of the constant expression evaluator and has done a lot of reviewing in Sema over the past year or so. >From 4c1e1ac48afe4f873355c7e8a7e54f7506ab1014 Mon Sep 17 00:00:00 2001

[clang] [llvm] [Transforms][Utils][PromoteMem2Reg] Propagate nnan flag on par with the nsz flag (PR #114271)

2024-11-05 Thread Paul Osmialowski via cfe-commits
pawosm-arm wrote: > > Yet we see a value in the change proposed here too hence a good reason for > > merging it. > > I've clearly misunderstood the context of the rebase. What is the value in > merging this change if the original issue has already been resolved? I guess > this fix is simpler

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

2024-11-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vladislav Belov (vbe-sc) Changes Currently the following example is a compilation failure: ``` template struct A { typedef int M; struct B { typedef void M; struct C; }; }; template struct A

[clang] [llvm] [Transforms][Utils][PromoteMem2Reg] Propagate nnan flag on par with the nsz flag (PR #114271)

2024-11-05 Thread Nikita Popov via cfe-commits
nikic wrote: I do think this change still makes sense, especially from a consistency point of view. If SROA sets one of the value-based FMF flags (nsz) then it stands to reason that it should also set the other two (nnan and ninf). Unless there is some reason why nsz would be more problematic

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

2024-11-05 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/114978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Driver] When linking with the Fortran runtime, the `addArchSpecificRPath()` should be called too (PR #114837)

2024-11-05 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur commented: `addSanitizerRuntime` and `addOpenMPRuntime` are already calling `addArchSpecificRPath`. It it a problem if rpath is added multiple times? Compiler-rt libs (`libclang_rt.*.a`) are added as absolute paths, shouldn't the Fortran-runtime do the same? http

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove features which expose non exploitable runtime behavior. (PR #114387)

2024-11-05 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea ready_for_review https://github.com/llvm/llvm-project/pull/114387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2024-11-05 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/114529 >From 9337e170d920eaabe2b59a25622f0c554ca5afcf Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 20 Oct 2024 11:35:15 +0100 Subject: [PATCH 1/2] [WIP][lldb][Expression] More reliable function call resol

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove features which expose non exploitable runtime behavior. (PR #114387)

2024-11-05 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/114387 >From 71786e09b65da73e998cbce32386a54e9eb3ee1e Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Tue, 29 Oct 2024 16:45:47 + Subject: [PATCH 1/2] [FMV][AArch64] Remove features which expose non ex

[clang] Add Mariya as maintainer for constant expressions & Sema (PR #114974)

2024-11-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes Mariya has extensive knowledge of the constant expression evaluator and has done a lot of reviewing in Sema over the past year or so. --- Full diff: https://github.com/llvm/llvm-project/pull/114974.dif

[clang] [clang] Fix the post-filtering heuristic for GSLPointer. (PR #114044)

2024-11-05 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/114044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Mariya as maintainer for constant expressions & Sema (PR #114974)

2024-11-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. https://github.com/llvm/llvm-project/pull/114974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Check for editsNearCursor client capability under experimental capabilities (PR #114699)

2024-11-05 Thread Rafał Chłodnicki via cfe-commits
rchl wrote: Personally I haven't yet looked if other custom capabilities are relevant for the editor I use (Sublime Text) but I also think it would makes sense to be with all of them (and follow the spec). https://github.com/llvm/llvm-project/pull/114699 ___

[clang] [compiler-rt] [XRay][AArch64] Support -fxray-shared (PR #114431)

2024-11-05 Thread Julian Nagele via cfe-commits
juliannagele wrote: Unfortunately it looks like this has broken building compiler-rt on green dragon: https://green.lab.llvm.org/job/llvm.org/job/clang-stage1-RA/2606/console ``` :1:1: error: unrecognized instruction mnemonic pushfq ^ /Users/ec2-user/jenkins/workspace/llvm.org/clang-stage1-RA/ll

[clang] Add -mno-unaligned-access and -mbig-endian to ARM and AArch64 multilib flags (PR #114782)

2024-11-05 Thread Lucas Duarte Prates via cfe-commits
https://github.com/pratlucas approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/114782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2024-11-05 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/114529 >From 9337e170d920eaabe2b59a25622f0c554ca5afcf Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 20 Oct 2024 11:35:15 +0100 Subject: [PATCH 1/2] [WIP][lldb][Expression] More reliable function call resol

[clang] Nominate Saleem and myself as maintainers for API Notes (PR #114981)

2024-11-05 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/114981 >From 1bf3932e901177518632eeaa05b21a05f3d43880 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Mon, 4 Nov 2024 19:52:37 + Subject: [PATCH] Nominate Saleem and myself as maintainers for API Notes --- clan

[clang] Nominate Saleem and myself as maintainers for API Notes (PR #114981)

2024-11-05 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan created https://github.com/llvm/llvm-project/pull/114981 Saleem has upstreamed a large chunk of API Notes infrastructure from the Apple fork, and over the past year I've upstreamed the remaining part of API Notes, added new annotations and improved C++ language sup

[clang-tools-extra] [clang-query] add basic profiling on matching each ASTs (PR #114806)

2024-11-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/114806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Driver] When linking with the Fortran runtime, the `addArchSpecificRPath()` should be called too (PR #114837)

2024-11-05 Thread Paul Osmialowski via cfe-commits
pawosm-arm wrote: > `addSanitizerRuntime` and `addOpenMPRuntime` are already calling > `addArchSpecificRPath`. It it a problem if rpath is added multiple times? > I've been testing it with and without -fopenmp and didn't observe any problem > Compiler-rt libs (`libclang_rt.*.a`) are added as

[clang] [Clang] update reasoned delete diagnostic kind to use Extension, making it pedantic only (PR #114713)

2024-11-05 Thread Aaron Ballman via cfe-commits
@@ -464,6 +464,8 @@ Improvements to Clang's diagnostics - Clang now diagnoses ``[[deprecated]]`` attribute usage on local variables (#GH90073). +- Clang now diagnoses misused reasoned ``delete("reason")`` warnings only in pedantic mode. (#GH109311). AaronBa

[clang] [Clang][AArch64]Fix Name and Mangle name for scalar fp8 (PR #114983)

2024-11-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (CarolineConcatto) Changes The scalar __mfp8 type has the wrong name and mangle name in AArch64SVEACLETypes.def According to the ACLE[1] the name should be __mfp8, then mangle name __u6mfp8. This patch fixes this problem by replacin

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

2024-11-05 Thread Vladislav Belov via cfe-commits
https://github.com/vbe-sc created https://github.com/llvm/llvm-project/pull/114978 Currently the following example is a compilation failure: ``` template struct A { typedef int M; struct B { typedef void M; struct C; }; }; template struct A::B::C : A { M m; // void

[clang] Nominate Saleem and myself as maintainers for API Notes (PR #114981)

2024-11-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Egor Zhdan (egorzhdan) Changes Saleem has upstreamed a large chunk of API Notes infrastructure from the Apple fork, and over the past year I've upstreamed the remaining part of API Notes, added new annotations and improved C++ language su

[clang] Nominate Saleem and myself as maintainers for API Notes (PR #114981)

2024-11-05 Thread Aaron Ballman via cfe-commits
@@ -132,6 +132,14 @@ Compiler options | jan_svoboda\@apple.com (email), jansvoboda11 (Phabricator), jansvoboda11 (GitHub) +API Notes + +| Egor Zhdan +| e_zhdan\@apple.com (email), egorzhdan (GitHub), egor.zhdan (Discourse) + +| Saleem Abdulrasool +| compnerd\

[clang] Nominate Saleem and myself as maintainers for API Notes (PR #114981)

2024-11-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM (with a minor whitespace nit for consistency with the rest of the file), though please wait to land until after @compnerd has accepted the nomination as well. Thank you for volunteering! https://github.com/llvm/llvm-project/pull

[clang] Nominate Saleem and myself as maintainers for API Notes (PR #114981)

2024-11-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/114981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Call code gen; create empty cir.func op (PR #113483)

2024-11-05 Thread Aaron Ballman via cfe-commits
@@ -52,10 +62,33 @@ class CIRGenModule : public CIRGenTypeCache { /// A "module" matches a c/cpp source file: containing a list of functions. mlir::ModuleOp theModule; + clang::DiagnosticsEngine &diags; + const clang::TargetInfo ⌖ public: + mlir::ModuleOp getModule

[clang] [CIR] Call code gen; create empty cir.func op (PR #113483)

2024-11-05 Thread Aaron Ballman via cfe-commits
@@ -24,9 +27,140 @@ CIRGenModule::CIRGenModule(mlir::MLIRContext &context, clang::ASTContext &astctx, const clang::CodeGenOptions &cgo, DiagnosticsEngine &diags) -: astCtx(astctx), langOpts(ast

[clang] [lld] [llvm] [Windows] Add support for emitting PGO/LTO magic strings in the Windows PE debug directory (PR #114260)

2024-11-05 Thread Mikołaj Piróg via cfe-commits
https://github.com/mikolaj-pirog updated https://github.com/llvm/llvm-project/pull/114260 From f903e7e2effbd9675d0977dc1fd176ce97f11778 Mon Sep 17 00:00:00 2001 From: "Pirog, Mikolaj Maciej" Date: Wed, 30 Oct 2024 16:30:39 +0100 Subject: [PATCH 1/8] Correct test --- clang/test/CodeGen/debug-d

[compiler-rt] [libunwind] [llvm] [cmake] Remove obsolete files, docs and CMake variables related to the standalone build (PR #112741)

2024-11-05 Thread Louis Dionne via cfe-commits
ldionne wrote: Both CI failures seem to be unrelated. https://github.com/llvm/llvm-project/pull/112741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix the post-filtering heuristic for GSLPointer. (PR #114044)

2024-11-05 Thread Utkarsh Saxena via cfe-commits
@@ -793,3 +794,44 @@ void test13() { } } // namespace GH100526 + +namespace LifetimeboundInterleave { + +const std::string& Ref(const std::string& abc [[clang::lifetimebound]]); usx95 wrote: Can you also add the following tests: `std::string_view TakeSv(std::

[clang] [clang] Fix the post-filtering heuristic for GSLPointer. (PR #114044)

2024-11-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/114044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-05 Thread Louis Dionne via cfe-commits
@@ -230,11 +230,22 @@ else() endif() set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) -set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use. Supported values are ${LIBCXX_SUP

[clang] Fix for codegen Crash in Clang when using locator omp_all_memory with depobj construct (PR #114221)

2024-11-05 Thread Shilei Tian via cfe-commits
@@ -36,6 +36,8 @@ int main(int argc, char **argv) { #pragma omp depobj(b) update(mutexinoutset) #pragma omp depobj(a) depend(iterator(char *p = argv[argc]:argv[0]:-1), out: p[0]) (void)tmain(a), tmain(b); + omp_depend_t obj; shiltian wrote: Auto-gen check

[clang] [clang] Make source locations space usage diagnostics numbers easier to read (PR #114999)

2024-11-05 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb created https://github.com/llvm/llvm-project/pull/114999 Instead of writing "12345678B", write "12345678B (12.34MB)". >From 6f3c9f95f7ad558659bc7d868ab4d5e5f6af05c0 Mon Sep 17 00:00:00 2001 From: Boaz Brickner Date: Tue, 5 Nov 2024 15:29:10 +0100 Subject: [PATCH] [

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-11-05 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > This is unexpected and I think it breaks the correctness of clang-scan-deps. > I think we might need to take your patch a bit further and make it so that > `ASTWriter::WriteInputFiles()` doesn't care whether the SLocEntry associated > with the file through `Module::Defin

[clang] [Clang][AArch64]Fix Name and Mangle name for scalar fp8 (PR #114983)

2024-11-05 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/114983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correctly initialize placeholder fields from their initializers (PR #114196)

2024-11-05 Thread Erich Keane via cfe-commits
@@ -5560,6 +5560,25 @@ ExprResult Sema::BuildCXXDefaultArgExpr(SourceLocation CallLoc, Init, InitializationContext->Context); } +static FieldDecl *FindFieldDeclInstantiationPattern(const ASTContext &Ctx, +

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-05 Thread Louis Dionne via cfe-commits
@@ -230,11 +230,22 @@ else() endif() set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) -set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use. Supported values are ${LIBCXX_SUP

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From 504518235aa19ab517b59e41c003b86dc610bbb0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[clang] [HLSL] add IsTypedResourceElementCompatible type trait (PR #114864)

2024-11-05 Thread Chris B via cfe-commits
@@ -2163,6 +2163,50 @@ static void BuildFlattenedTypeList(QualType BaseTy, } } +bool SemaHLSL::IsTypedResourceElementCompatible(clang::QualType QT) { + if (QT.isNull()) +return false; + + // check if the outer type was an array type + if (QT->isArrayType()) +retur

[clang] [clang] Add steakhal to the Clang Static Analyzer maintainers (PR #114991)

2024-11-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes I've been contributing to the Clang Static Analyzer for a while now. I think from 2019, or something like that. I've ensured the quality of the Static Analyzer releases for the last ~4-6 releases now, with

[clang] [Clang][AArch64]Fix Name and Mangle name for scalar fp8 (PR #114983)

2024-11-05 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/114983 >From 3839546afb0136507e8220803389e1ef5571f1bf Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Tue, 5 Nov 2024 09:53:08 + Subject: [PATCH 1/2] [Clang][AArch64]Fix Name and Mangle name for sca

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-11-05 Thread Ilya Biryukov via cfe-commits
@@ -43,7 +43,7 @@ module third {} // CHECK-NEXT: "command-line": [ // CHECK-NEXT: "-cc1", // CHECK: "-fmodule-map-file=[[PREFIX]]/second/second/module.modulemap" -// CHECK-NOT: "-fmodule-map-file=[[PREFIX]]/second/second/sub.modulemap" +//

[clang] [Clang][AArch64]Fix Name and Mangle name for scalar fp8 (PR #114983)

2024-11-05 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/114983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ba60f6d - Remove leftover uses of llvm::Type::getPointerTo() (#114993)

2024-11-05 Thread via cfe-commits
Author: Youngsuk Kim Date: 2024-11-05T10:00:23-05:00 New Revision: ba60f6dc03126d8b26bba5be6338fd8b3580bd25 URL: https://github.com/llvm/llvm-project/commit/ba60f6dc03126d8b26bba5be6338fd8b3580bd25 DIFF: https://github.com/llvm/llvm-project/commit/ba60f6dc03126d8b26bba5be6338fd8b3580bd25.diff

[clang] [llvm] Remove leftover uses of llvm::Type::getPointerTo() (PR #114993)

2024-11-05 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 closed https://github.com/llvm/llvm-project/pull/114993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correctly initialize placeholder fields from their initializers (PR #114196)

2024-11-05 Thread Erich Keane via cfe-commits
@@ -5560,6 +5560,25 @@ ExprResult Sema::BuildCXXDefaultArgExpr(SourceLocation CallLoc, Init, InitializationContext->Context); } +static FieldDecl *FindFieldDeclInstantiationPattern(const ASTContext &Ctx, +

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-05 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/112792 >From 802764e879862541e205ba1a070824b71d2fef9a Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Thu, 17 Oct 2024 17:31:24 -0500 Subject: [PATCH 01/10] [emacs][clang-format] Add elisp API for clang-format o

[clang] [Clang] Correctly initialize placeholder fields from their initializers (PR #114196)

2024-11-05 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/114196 >From e8fe0b3e63cdf9a2e16f680d59705074da10338e Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 30 Oct 2024 10:25:42 +0100 Subject: [PATCH] [Clang] Correctly initialize placeholder fields from their in

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-11-05 Thread Ilia Kuklin via cfe-commits
https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/115005 The information about an enum's best promotion type is discarded after compilation and is not present in debug info. This patch repeats the same analysis of each enum value as in the front-end to determine the b

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-11-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes The information about an enum's best promotion type is discarded after compilation and is not present in debug info. This patch repeats the same analysis of each enum value as in the front-end to determine the

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-11-05 Thread Ilia Kuklin via cfe-commits
kuilpd wrote: My thought process for this patch: https://github.com/llvm/llvm-project/issues/86989#issuecomment-2438116468 https://github.com/llvm/llvm-project/pull/115005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [Multilib] Custom flags YAML parsing (PR #110657)

2024-11-05 Thread Victor Campos via cfe-commits
vhscampos wrote: Created PR to amend `Multilib.rst`: https://github.com/llvm/llvm-project/pull/114998 https://github.com/llvm/llvm-project/pull/110657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-11-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b2d2494731976ab7aa9702f3134472db694b9332 62c801145a2312d2c9339d30cf116fc2e709d630 --e

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-11-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r b2d2494731976ab7aa9702f3134472db694b9332...62c801145a2312d2c9339d30cf116fc2e709d630 lldb/

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-11-05 Thread Ilia Kuklin via cfe-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/115005 >From 5290832b802d98b9d293b6910c0837911ec490c4 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Mon, 4 Nov 2024 14:33:45 +0500 Subject: [PATCH 1/4] [lldb] Analyze enum promotion type during parsing --- clang/in

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-11-05 Thread Michael Buch via cfe-commits
Michael137 wrote: I haven't done an in-depth review of the patch yet but my first instinct here is that this looks like a lot of work for LLDB which the compiler has already done, so we ideally don't want to repeat. Where is this actually an issue from a user perspective? In the example you ga

[clang] [PS5][Driver] Pass `-z rodynamic` to the linker (PR #115009)

2024-11-05 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd created https://github.com/llvm/llvm-project/pull/115009 Until now, suppression of `DT_DEBUG` has been hardcoded as a downstream patch in lld. This can instead be achieved by passing `-z rodynamic`. Have the driver do this so that the private patch can be rem

[clang] [PS5][Driver] Pass `-z rodynamic` to the linker (PR #115009)

2024-11-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Edd Dawson (playstation-edd) Changes Until now, suppression of `DT_DEBUG` has been hardcoded as a downstream patch in lld. This can instead be achieved by passing `-z rodynamic`. Have the driver do this so that the private patch can be re

[libclc] [libclc] Move abs/abs_diff to CLC library (PR #114960)

2024-11-05 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/114960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS5][Driver] Pass `-z rodynamic` to the linker (PR #115009)

2024-11-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Edd Dawson (playstation-edd) Changes Until now, suppression of `DT_DEBUG` has been hardcoded as a downstream patch in lld. This can instead be achieved by passing `-z rodynamic`. Have the driver do this so that the private patch ca

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-11-05 Thread Ilia Kuklin via cfe-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/115005 >From 5290832b802d98b9d293b6910c0837911ec490c4 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Mon, 4 Nov 2024 14:33:45 +0500 Subject: [PATCH 1/4] [lldb] Analyze enum promotion type during parsing --- clang/in

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-11-05 Thread Ilia Kuklin via cfe-commits
kuilpd wrote: > Not that this shouldn't be fixed, just weighing of the amount of complexity > added here versus the benefit. I don't really know how useful it is in general to know the actual promotion type of the enum, I guess only for using enum values in expressions without explicit castin

[clang] 44f49b5 - [NFC] Move RegisterBuiltinMacro function into the Preprocessor class (#100142)

2024-11-05 Thread via cfe-commits
Author: muiez Date: 2024-11-05T10:32:21-05:00 New Revision: 44f49b551df8152a3e1e84705e116f8a20f62295 URL: https://github.com/llvm/llvm-project/commit/44f49b551df8152a3e1e84705e116f8a20f62295 DIFF: https://github.com/llvm/llvm-project/commit/44f49b551df8152a3e1e84705e116f8a20f62295.diff LOG: [N

[clang] [NFC] Move RegisterBuiltinMacro function into the Preprocessor class (PR #100142)

2024-11-05 Thread via cfe-commits
https://github.com/muiez closed https://github.com/llvm/llvm-project/pull/100142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2024-11-05 Thread Pavel Labath via cfe-commits
labath wrote: I'm worried about the same thing as Michael. My question is: if the promotion type can be computed from the information in dwarf (can it always?), and clang already has code to compute it (not from DWARF, but from.. clang AST I guess), can we refactor that code somehow so that it

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `dot4add_i8packed` intrinsic (PR #113623)

2024-11-05 Thread Steven Perron via cfe-commits
@@ -1694,6 +1701,112 @@ bool SPIRVInstructionSelector::selectIntegerDot(Register ResVReg, return Result; } +template +bool SPIRVInstructionSelector::selectDot4AddPacked(Register ResVReg, + const SPIRVType *ResType, +

[clang] [llvm] [LLVM][IR] Use splat syntax when printing Constant[Data]Vector. (PR #112548)

2024-11-05 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/112548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make source locations space usage diagnostics numbers easier to read (PR #114999)

2024-11-05 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Do we really care about the exact byte numbers? Maybe we should only show the human-friendly version? It's appealing to have less noise if we can. https://github.com/llvm/llvm-project/pull/114999 ___ cfe-commits mailing list cfe-c

[clang] [llvm] [Transforms][Utils][PromoteMem2Reg] Propagate nnan flag on par with the nsz flag (PR #114271)

2024-11-05 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm updated https://github.com/llvm/llvm-project/pull/114271 >From a426e17ed3c3cad6b3c813bd996e649a2e544591 Mon Sep 17 00:00:00 2001 From: Pawel Osmialowski Date: Wed, 30 Oct 2024 14:30:08 + Subject: [PATCH] [Transforms][Utils][PromoteMem2Reg] Propagate nnan and ni

[clang] [llvm] [AArch64] Reduce +sve2-aes to an alias of +sve-aes+sve2 (PR #114293)

2024-11-05 Thread via cfe-commits
@@ -369,9 +369,12 @@ def FeatureSVE2 : ExtensionWithMArch<"sve2", "SVE2", "FEAT_SVE2", "Enable Scalable Vector Extension 2 (SVE2) instructions", [FeatureSVE, FeatureUseScalarIncVL]>; -def FeatureSVE2AES : ExtensionWithMArch<"sve2-aes", "SVE2AES", +def FeatureSVEAES : Exte

[clang] [clang] Make source locations space usage diagnostics numbers easier to read (PR #114999)

2024-11-05 Thread Boaz Brickner via cfe-commits
bricknerb wrote: > Do we really care about the exact byte numbers? Maybe we should only show the > human-friendly version? It's appealing to have less noise if we can. Yes, I was considering both options. It might be useful to see the full number in case you want to diff between logs, and the

[clang] 34b0bb5 - Add Chris as the HLSL maintainer (#114863)

2024-11-05 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-11-05T11:01:58-05:00 New Revision: 34b0bb51213d0c4e3afa128d6107884cd7138cf2 URL: https://github.com/llvm/llvm-project/commit/34b0bb51213d0c4e3afa128d6107884cd7138cf2 DIFF: https://github.com/llvm/llvm-project/commit/34b0bb51213d0c4e3afa128d6107884cd7138cf2.diff

[clang] Add Mariya as maintainer for constant expressions & Sema (PR #114974)

2024-11-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/114974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Transforms][Utils][PromoteMem2Reg] Propagate nnan flag on par with the nsz flag (PR #114271)

2024-11-05 Thread Matt Arsenault via cfe-commits
arsenm wrote: > I do think this change still makes sense, especially from a consistency point > of view. If SROA sets one of the value-based FMF flags (nsz) then it stands > to reason that it should also set the other two (nnan and ninf). Unless there > is some reason why nsz would be more pro

[clang] [llvm] AMDGPU: Treat uint32_max as the default value for amdgpu-max-num-workgroups (PR #113751)

2024-11-05 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/113751 >From 6981d5ad80130130d373b8c879a88b7d727b0115 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Sat, 19 Oct 2024 02:39:06 +0400 Subject: [PATCH 1/4] clang/AMDGPU: Emit grid size builtins with range metadata T

[clang] clang/AMDGPU: Emit grid size builtins with range metadata (PR #113038)

2024-11-05 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/113038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c48fc46 - Add Mariya as maintainer for constant expressions & Sema (#114974)

2024-11-05 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-11-05T11:02:16-05:00 New Revision: c48fc467575e6dfa6578c66ebafa7c29de3fdaf4 URL: https://github.com/llvm/llvm-project/commit/c48fc467575e6dfa6578c66ebafa7c29de3fdaf4 DIFF: https://github.com/llvm/llvm-project/commit/c48fc467575e6dfa6578c66ebafa7c29de3fdaf4.diff

[clang] 1a59087 - [SYCL] The sycl_kernel_entry_point attribute. (#111389)

2024-11-05 Thread via cfe-commits
Author: Tom Honermann Date: 2024-11-05T11:09:32-05:00 New Revision: 1a590870b6b3452934ecc245e01957fdab48909c URL: https://github.com/llvm/llvm-project/commit/1a590870b6b3452934ecc245e01957fdab48909c DIFF: https://github.com/llvm/llvm-project/commit/1a590870b6b3452934ecc245e01957fdab48909c.diff

[clang] Add Chris as the HLSL maintainer (PR #114863)

2024-11-05 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/114863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-11-05 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann closed https://github.com/llvm/llvm-project/pull/111389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Chris as the HLSL maintainer (PR #114863)

2024-11-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/114863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-11-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Ping https://github.com/llvm/llvm-project/pull/110179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] eliminate shadowing warnings for parameters using deducing this (PR #114813)

2024-11-05 Thread Oleksandr T. via cfe-commits
@@ -8236,11 +8236,14 @@ void Sema::CheckShadow(NamedDecl *D, NamedDecl *ShadowedDecl, DeclContext *NewDC = D->getDeclContext(); if (FieldDecl *FD = dyn_cast(ShadowedDecl)) { -// Fields are not shadowed by variables in C++ static methods. -if (CXXMethodDecl *MD = d

[clang] [clang] Make source locations space usage diagnostics numbers easier to read (PR #114999)

2024-11-05 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > Yes, I was considering both options. It might be useful to see the full > number in case you want to diff between logs, and the diff would be > relatively small (people might care about zero diff vs. tiny diff), so I > decided to make this change not lose any information

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From 2e50f00dfc6636abbaf0c8350c6e7c92b7b3dba0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[clang] [clang] Make source locations space usage diagnostics numbers easier to read (PR #114999)

2024-11-05 Thread Ilya Biryukov via cfe-commits
@@ -2227,6 +2227,28 @@ LLVM_DUMP_METHOD void SourceManager::dump() const { } } +static std::string NumberToHumanString(uint64_t Number) { + static constexpr std::array, 4> Units = { + {{1'000'000'000'000UL, 'T'}, + {1'000'000'000UL, 'G'}, + {1'000'000UL, 'M

[clang] [clang] Make source locations space usage diagnostics numbers easier to read (PR #114999)

2024-11-05 Thread Ilya Biryukov via cfe-commits
@@ -2227,6 +2227,28 @@ LLVM_DUMP_METHOD void SourceManager::dump() const { } } +static std::string NumberToHumanString(uint64_t Number) { + static constexpr std::array, 4> Units = { + {{1'000'000'000'000UL, 'T'}, + {1'000'000'000UL, 'G'}, + {1'000'000UL, 'M

[clang] [llvm] [RISCV][VLS] Support RISCV VLS calling convention (PR #100346)

2024-11-05 Thread Craig Topper via cfe-commits
@@ -317,38 +323,60 @@ ABIArgInfo RISCVABIInfo::coerceAndExpandFPCCEligibleStruct( // Fixed-length RVV vectors are represented as scalable vectors in function // args/return and must be coerced from fixed vectors. -ABIArgInfo RISCVABIInfo::coerceVLSVector(QualType Ty) const {

[clang] dc62edf - [clang][Driver][HIP] Add support for mixing AMDGCNSPIRV & concrete `offload-arch`s. (#113509)

2024-11-05 Thread via cfe-commits
Author: Alex Voicu Date: 2024-11-05T10:53:05+02:00 New Revision: dc62edf10543137fbf7f3d4aaa21c17ff073a8fe URL: https://github.com/llvm/llvm-project/commit/dc62edf10543137fbf7f3d4aaa21c17ff073a8fe DIFF: https://github.com/llvm/llvm-project/commit/dc62edf10543137fbf7f3d4aaa21c17ff073a8fe.diff LO

[clang] [clang][Driver][HIP] Add support for mixing AMDGCNSPIRV & concrete `offload-arch`s. (PR #113509)

2024-11-05 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/113509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add maintainer for Recovery expressions. (PR #114859)

2024-11-05 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/114859 >From 04254d2352a385df1ab57c855d6b5de6e668844d Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 4 Nov 2024 21:01:32 +0100 Subject: [PATCH 1/2] [clang] Add maintainer for Recovery expressions. --- clang/Main

[clang] [RFC] [clang] [CodeGen] Avoid creating global variable repeatedly when type are not specified (PR #114948)

2024-11-05 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/114948 This comes from an internal crash. I know generally it is better to reproduce it first but I do feel the pattern is pretty risky. So I am wondering if we can discuss it first. So maybe this is more of a disc

[clang] [Clang] Consider outer instantiation scopes for constraint normalization (PR #114749)

2024-11-05 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Backport PR https://github.com/llvm/llvm-project/pull/114951 (I have to backport it manually as there are some other changes on the post-19 branch) https://github.com/llvm/llvm-project/pull/114749 ___ cfe-commits mailing list cfe-commi

[clang] [clang] SemaFunctionEffects: When verifying a function, ignore any trailing 'requires' clause. (PR #114266)

2024-11-05 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/114266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   >