[clang] [Driver] Remove ignored Flag form of -fauto-profile/-fprofile-sample-use (PR #113528)

2024-10-25 Thread Fangrui Song via cfe-commits
MaskRay wrote: > It's true that there isn't any compatibility argument for leaving > `-fprofile-sample/auto` (it was silently ignored afterall), but I think the > consistency argument is important. From a standpoint of a clang user, it's > very reasonable to expect that `fprofile-use` and `-fp

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

2024-10-25 Thread Gang Chen via cfe-commits
https://github.com/cmc-rep updated https://github.com/llvm/llvm-project/pull/113614 >From 166a4aec8a8ee813be0ee3045563cd45efd944c0 Mon Sep 17 00:00:00 2001 From: gangc Date: Thu, 24 Oct 2024 11:18:22 -0700 Subject: [PATCH 1/4] [AMDGPU] Add a type for the named barrier --- clang/include/clang/

[clang] [Clang][AST] Store injected template arguments in TemplateParameterList (PR #113579)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -244,6 +245,17 @@ bool TemplateParameterList::hasAssociatedConstraints() const { return HasRequiresClause || HasConstrainedParameters; } +ArrayRef TemplateParameterList::getInjectedTemplateArgs() { + if (const auto *Context = InjectedArgs.dyn_cast()) { +TemplateArgu

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -2474,19 +2474,46 @@ bool CXXMethodDecl::isUsualDeallocationFunction( getOverloadedOperator() != OO_Array_Delete) return false; + auto NumParams = getNumParams(); + bool IsTypeAware = IsTypeAwareOperatorNewOrDelete(); + // C++ [basic.stc.dynamic.deallocation]

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -4749,6 +4753,15 @@ class Sema final : public SemaBase { CXXRecordDecl *getStdBadAlloc() const; EnumDecl *getStdAlignValT() const; + ClassTemplateDecl *getStdTypeIdentity() const; + std::optional InstantiateSpecializedTypeIdentity(QualType Subject); e

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I cant find my comment, but I see the args structure isn't actually stored anywhere except as params, so feel free to disregard that comment. https://github.com/llvm/llvm-project/pull/113510 ___ cfe-commits mai

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -2474,19 +2474,46 @@ bool CXXMethodDecl::isUsualDeallocationFunction( getOverloadedOperator() != OO_Array_Delete) return false; + auto NumParams = getNumParams(); + bool IsTypeAware = IsTypeAwareOperatorNewOrDelete(); + // C++ [basic.stc.dynamic.deallocation]

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -8126,7 +8143,7 @@ class Sema final : public SemaBase { /// The scope in which to find allocation functions. enum AllocationFunctionScope { -/// Only look for allocation functions in the global scope. +/// Only look for allocation functions in the global scope -

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -3358,6 +3358,12 @@ bool FunctionDecl::isReservedGlobalPlacementOperator() const { return false; const auto *proto = getType()->castAs(); + if (proto->getNumParams() < 2) +return false; + bool IsTypeAwareAllocator = erichkeane wrote: is this b

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -2474,19 +2474,46 @@ bool CXXMethodDecl::isUsualDeallocationFunction( getOverloadedOperator() != OO_Array_Delete) return false; + auto NumParams = getNumParams(); + bool IsTypeAware = IsTypeAwareOperatorNewOrDelete(); + // C++ [basic.stc.dynamic.deallocation]

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -2234,6 +2234,17 @@ enum class CXXNewInitializationStyle { Braces }; +struct ImplicitAllocationParameters { + bool PassTypeIdentity; erichkeane wrote: minor preference for all of these being bitfields, or perhaps make this an `enum` type that we can us

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/113510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -2474,19 +2474,46 @@ bool CXXMethodDecl::isUsualDeallocationFunction( getOverloadedOperator() != OO_Array_Delete) return false; + auto NumParams = getNumParams(); erichkeane wrote: Don't use auto here, only when the type is on the RHS per coding

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -2474,19 +2474,46 @@ bool CXXMethodDecl::isUsualDeallocationFunction( getOverloadedOperator() != OO_Array_Delete) return false; + auto NumParams = getNumParams(); + bool IsTypeAware = IsTypeAwareOperatorNewOrDelete(); + // C++ [basic.stc.dynamic.deallocation]

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -307,6 +307,10 @@ EXTENSION(datasizeof, LangOpts.CPlusPlus) FEATURE(cxx_abi_relative_vtable, LangOpts.CPlusPlus && LangOpts.RelativeCXXABIVTables) +// Type aware allocators +FEATURE(cxx_type_aware_allocators, LangOpts.TypeAwareAllocators) erichkeane wrote

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

2024-10-25 Thread Gang Chen via cfe-commits
https://github.com/cmc-rep updated https://github.com/llvm/llvm-project/pull/113614 >From 166a4aec8a8ee813be0ee3045563cd45efd944c0 Mon Sep 17 00:00:00 2001 From: gangc Date: Thu, 24 Oct 2024 11:18:22 -0700 Subject: [PATCH 1/5] [AMDGPU] Add a type for the named barrier --- clang/include/clang/

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -0,0 +1,73 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++2c -fcxx-type-aware-allocators -fexceptions + +namespace std { + template struct type_identity {}; + enum class align_val_t : __SIZE_TYPE__ {}; + struct destroying_delete_t { explicit destroying_delete_t()

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -17389,6 +17389,19 @@ Sema::ActOnTag(Scope *S, unsigned TagSpec, TagUseKind TUK, SourceLocation KWLoc, Previous.clear(); } + // I think DC check should be DC->isStdNamespace()? + // Also these guards are questionable - it's possible to get incorrect + // codegen w

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -0,0 +1,95 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++17 -fcxx-type-aware-allocators +// RUN: %clang_cc1 -fsyntax-only -verify %s -DNO_TAA -std=c++17 -fno-cxx-type-aware-allocators + +namespace std { + template struct type_identity {}; + enum class al

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -17389,6 +17389,19 @@ Sema::ActOnTag(Scope *S, unsigned TagSpec, TagUseKind TUK, SourceLocation KWLoc, Previous.clear(); } + // I think DC check should be DC->isStdNamespace()? erichkeane wrote: Should it? https://github.com/llvm/llvm-project/pull

[clang] Initial implementation of P2719 (PR #113510)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -0,0 +1,302 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s-std=c++2c -fcxx-type-aware-allocators -fexceptions +// RUN: %clang_cc1 -fsyntax-only -verify %s -DTADD -std=c++2c -fcxx-type-aware-allocators -fcxx-type-aware-destroying-delete -fexceptions + +namespace std {

[clang] [Clang][AST] Store injected template arguments in TemplateParameterList (PR #113579)

2024-10-25 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/113579 >From 95c86a7036e62240ab7704f0b1e47cdc9ac437c6 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 15 Oct 2024 11:15:55 -0400 Subject: [PATCH 1/2] [Clang][AST] Store injected template arguments in

[clang] [llvm] [HLSL][SPIRV] Added clamp intrinsic (PR #113394)

2024-10-25 Thread Adam Yang via cfe-commits
@@ -18661,14 +18661,30 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned BuiltinID, Value *OpMax = EmitScalarExpr(E->getArg(2)); QualType Ty = E->getArg(0)->getType(); -bool IsUnsigned = false; if (auto *VecTy = Ty->getAs()) Ty = VecTy->getElemen

[clang] [llvm] [HLSL][SPIRV] Added clamp intrinsic (PR #113394)

2024-10-25 Thread Adam Yang via cfe-commits
@@ -2559,6 +2559,12 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register ResVReg, } break; case Intrinsic::spv_saturate: return selectSaturate(ResVReg, ResType, I); + case Intrinsic::spv_fclamp: +return selectExtInst(ResVReg, ResType, I, CL::fclamp, GL::FCla

[clang] [llvm] [HLSL][SPIRV] Added clamp intrinsic (PR #113394)

2024-10-25 Thread Adam Yang via cfe-commits
@@ -40,8 +40,9 @@ def int_dx_cast_handle : Intrinsic<[llvm_any_ty], [llvm_any_ty]>; def int_dx_all : DefaultAttrsIntrinsic<[llvm_i1_ty], [llvm_any_ty], [IntrNoMem]>; def int_dx_any : DefaultAttrsIntrinsic<[llvm_i1_ty], [llvm_any_ty], [IntrNoMem]>; -def int_dx_clamp : Defaul

[clang] [llvm] [HLSL][SPIRV] Added clamp intrinsic (PR #113394)

2024-10-25 Thread Adam Yang via cfe-commits
@@ -0,0 +1,130 @@ +; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %} adam-yang wrote: clamp-vec is now gone. The vec

[clang] [BoundsSafety][Sema] Allow counted_by and counted_by_or_null on pointers where the pointee type is incomplete but potentially completable (PR #106321)

2024-10-25 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: @Sirraide 's comments are all relevant, and he's complained about everything I would have. So when he's happy with this, I am too. https://github.com/llvm/llvm-project/pull/106321 ___ cfe-commits mailing list

[clang] [BoundsSafety][Sema] Allow counted_by and counted_by_or_null on pointers where the pointee type is incomplete but potentially completable (PR #106321)

2024-10-25 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/106321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -41,7 +41,9 @@ #include "clang/Basic/CharInfo.h" #include "clang/Basic/CodeGenOptions.h" #include "clang/Basic/Diagnostic.h" +#include "clang/Basic/DiagnosticFrontend.h" erichkeane wrote: This is a LOT of include additions. Could we instead create a functi

[clang] [BoundsSafety][Sema] Allow counted_by and counted_by_or_null on pointers where the pointee type is incomplete but potentially completable (PR #106321)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -186,4 +218,216 @@ bool Sema::CheckCountedByAttrOnField(FieldDecl *FD, Expr *E, bool CountInBytes, return false; } +SourceRange Sema::BoundsSafetySourceRangeFor(const CountAttributedType *CATy) { + // This is an approximation that's not quite right. This points to the +

[clang] [analyzer] Fix a crash from element region construction during `ArrayInitLoopExpr` analysis (PR #113570)

2024-10-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. Still looks good. I couldnt find the "no-crash" comments in the tests at the statements where they crashed but im fine without them too. https://github.com/llvm/llvm-project/pull/113570 ___ cfe-c

[clang] [Clang][AST] Store injected template arguments in TemplateParameterList (PR #113579)

2024-10-25 Thread Krystian Stasiowski via cfe-commits
@@ -244,6 +245,17 @@ bool TemplateParameterList::hasAssociatedConstraints() const { return HasRequiresClause || HasConstrainedParameters; } +ArrayRef TemplateParameterList::getInjectedTemplateArgs() { + if (const auto *Context = InjectedArgs.dyn_cast()) { +TemplateArgu

[clang] [BoundsSafety][Sema] Allow counted_by and counted_by_or_null on pointers where the pointee type is incomplete but potentially completable (PR #106321)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -186,4 +218,216 @@ bool Sema::CheckCountedByAttrOnField(FieldDecl *FD, Expr *E, bool CountInBytes, return false; } +SourceRange Sema::BoundsSafetySourceRangeFor(const CountAttributedType *CATy) { + // This is an approximation that's not quite right. This points to the +

[clang] [BoundsSafety][Sema] Allow counted_by and counted_by_or_null on pointers where the pointee type is incomplete but potentially completable (PR #106321)

2024-10-25 Thread Erich Keane via cfe-commits
@@ -2440,6 +2440,26 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase { return !isFunctionType(); } + /// \returns True if the type is incomplete and it is also a type that + /// cannot be completed by a later type definition. + /// + /// E.g. For

[clang] f24c1dd - Fix MSVC "signed/unsigned mismatch" warning. NFC.

2024-10-25 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-10-25T18:11:28+01:00 New Revision: f24c1dd08ea71fa7334a85fd2772c2f728de0c56 URL: https://github.com/llvm/llvm-project/commit/f24c1dd08ea71fa7334a85fd2772c2f728de0c56 DIFF: https://github.com/llvm/llvm-project/commit/f24c1dd08ea71fa7334a85fd2772c2f728de0c56.diff

[clang] [Clang] Disable use of the counted_by attribute for whole struct pointers (PR #112636)

2024-10-25 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: But for now, I think we should merge #112786 into 19.1.3 so that the we can have that be the cutoff in the kernel. https://github.com/llvm/llvm-project/pull/112636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v4 (PR #108636)

2024-10-25 Thread Peilin Ye via cfe-commits
@@ -703,6 +715,39 @@ SDValue BPFTargetLowering::LowerSELECT_CC(SDValue Op, SelectionDAG &DAG) const { return DAG.getNode(BPFISD::SELECT_CC, DL, VTs, Ops); } +SDValue BPFTargetLowering::LowerATOMIC_LOAD(SDValue Op, +SelectionDAG &D

[clang] [Clang][Driver][AArch64] Add support for aarch64-amazon-linux triple (PR #109263)

2024-10-25 Thread Benjamin Herrenschmidt via cfe-commits
ozbenh wrote: So what should we (Amazon Linux) do to help with this ? I'm not the most familiar with autotools and cmake, I know we did some tweaking of triples in the version of llvm/clang we ship as part of the distro and it's very possible that we did something wrong. I would love to help m

[clang-tools-extra] [clangd] Support symbolTags for document symbol (PR #113669)

2024-10-25 Thread via cfe-commits
https://github.com/chouzz updated https://github.com/llvm/llvm-project/pull/113669 >From 02124e4cfd7dbc395d4974c7561d5f110980aaa5 Mon Sep 17 00:00:00 2001 From: chouzz Date: Fri, 25 Oct 2024 17:42:04 +0800 Subject: [PATCH] [clangd] Support symbolTags for document symbol --- clang-tools-extra/

[clang] [llvm] Expose format (attribute) info for function declarations in Clang Index API (PR #113754)

2024-10-25 Thread AR Visions via cfe-commits
https://github.com/ar-visions edited https://github.com/llvm/llvm-project/pull/113754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov_dpp8 (PR #113610)

2024-10-25 Thread Matt Arsenault via cfe-commits
@@ -152,6 +115,44 @@ bool SemaAMDGPU::CheckAMDGCNBuiltinFunctionCall(unsigned BuiltinID, return false; } +bool SemaAMDGPU::CheckMovDPPFunctionCall(CallExpr *TheCall, unsigned NumArgs, arsenm wrote: Start with lowercase https://github.com/llvm/llvm-projec

[clang] [ObjC] Insert method parameters in scope as they are parsed (PR #113745)

2024-10-25 Thread via cfe-commits
apple-fcloutier wrote: Failing test seems to be failing on main. https://github.com/llvm/llvm-project/pull/113745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Print the names of unfound files in error messages (PR #113640)

2024-10-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/8941 Here is the relevan

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-25 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH 1/4] [Clang] fix range calculation for conditionals with throw

[clang] [Clang][TableGen] Use StringRef::str() instead of std::string() cast (PR #113645)

2024-10-25 Thread Kazu Hirata via cfe-commits
@@ -54,19 +54,18 @@ class FlattenedSpelling { const Record &OriginalSpelling; public: - FlattenedSpelling(const std::string &Variety, const std::string &Name, + FlattenedSpelling(const std::string &Variety, StringRef Name, const std::string &Namespace,

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v4 (PR #108636)

2024-10-25 Thread Peilin Ye via cfe-commits
@@ -703,6 +715,39 @@ SDValue BPFTargetLowering::LowerSELECT_CC(SDValue Op, SelectionDAG &DAG) const { return DAG.getNode(BPFISD::SELECT_CC, DL, VTs, Ops); } +SDValue BPFTargetLowering::LowerATOMIC_LOAD(SDValue Op, +SelectionDAG &D

[clang] [clang-format] Print the names of unfound files in error messages (PR #113640)

2024-10-25 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/113640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Emit improved memory effects and return status for AsmStmt (PR #110510)

2024-10-25 Thread Bruno De Fraine via cfe-commits
brunodf-snps wrote: > Do we want nocapture markings on memory operands? I had a chance to discuss this with @nikic and he brought up the LEA instruction. The following would capture the address the `b` field: ``` asm("lea %0, %1" : "=r" (r) : "m" (p[i].b)); ``` I could not find back if you ar

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v4 (PR #108636)

2024-10-25 Thread Peilin Ye via cfe-commits
@@ -703,6 +715,39 @@ SDValue BPFTargetLowering::LowerSELECT_CC(SDValue Op, SelectionDAG &DAG) const { return DAG.getNode(BPFISD::SELECT_CC, DL, VTs, Ops); } +SDValue BPFTargetLowering::LowerATOMIC_LOAD(SDValue Op, +SelectionDAG &D

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-25 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/112727 >From 37a1728dde2cad21b9f851268c1625b7ef2dc338 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 17 Oct 2024 08:20:08 -0700 Subject: [PATCH 1/4] [rtsan][NFC] Documentation of suppression flag --- clang/docs

[clang] [Clang]: enhance handling of [[deprecated]] attribute diagnostics for local variables (PR #113575)

2024-10-25 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113575 >From 67a48d3861b44bd5c37fc9740ee2c54ddd1a8d1b Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Thu, 24 Oct 2024 17:21:39 +0300 Subject: [PATCH] [Clang] enhance handling of [[deprecated]] attribute diagnosti

[clang] 61a76f5 - [clang][analyzer][doc] Migrate ClangSA www FAQ section (#112831)

2024-10-25 Thread via cfe-commits
Author: Endre Fülöp Date: 2024-10-24T17:37:04+02:00 New Revision: 61a76f58ebf161c739fb196d56c1899735c7cea8 URL: https://github.com/llvm/llvm-project/commit/61a76f58ebf161c739fb196d56c1899735c7cea8 DIFF: https://github.com/llvm/llvm-project/commit/61a76f58ebf161c739fb196d56c1899735c7cea8.diff L

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `dot4add_i8packed` intrinsic (PR #113623)

2024-10-25 Thread Finn Plummer via cfe-commits
https://github.com/inbelic created https://github.com/llvm/llvm-project/pull/113623 - create a clang built-in in Builtins.td - link dot4add_i8packed in hlsl_intrinsics.h - add lowering to spirv backend through expansion of operation as OPSDot is missing up to SPIRV 1.6 in SPIRVInstr

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][AArch64] Protect PC within libunwind's context. (PR #113368)

2024-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 70334081f75d67900c6ffa193c60c4d6f4767354 1423c03b1cc31749027b84f9ec063e0b5ba02c3a --e

[clang-tools-extra] [compiler-rt] Added support for the .yml file extension (PR #79899)

2024-10-25 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/79899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Disable use of the counted_by attribute for whole struct pointers (PR #112636)

2024-10-25 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: @bwendling What do you think about that? https://github.com/llvm/llvm-project/pull/112636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [clang-tools-extra] RFC: [clang-tidy] [analyzer] Move nondeterministic pointer usage check to tidy (PR #110471)

2024-10-25 Thread via cfe-commits
whisperity wrote: > I'm happy to document future changes beyond this check, but would like to > keep this PR's scope limited to just porting the original CSA based check to > a tidy check as much as possible. @vabridgers I believe it is perfectly fine to add a "Limitations" section to the doc

[clang] [llvm] [DXIL][SPIRV] Lower WaveActiveCountBits intrinsic (PR #113382)

2024-10-25 Thread Finn Plummer via cfe-commits
@@ -0,0 +1,22 @@ +// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -triple \ +// RUN: dxil-pc-shadermodel6.3-compute %s -emit-llvm -disable-llvm-passes -o - | \ +// RUN: FileCheck %s --check-prefixes=CHECK,CHECK-DXIL +// RUN: %clang_cc1 -std=hlsl2021 -finclude-defaul

[clang] [llvm] Enable format info for C function declarations in Clang Index API, so we may have this context (PR #113754)

2024-10-25 Thread AR Visions via cfe-commits
https://github.com/ar-visions created https://github.com/llvm/llvm-project/pull/113754 Enable format info for C function declarations in Clang Index API, so we may have this context clang_Cursor_getFormatAttr Get FormatAttr at Function Declaration clang_FormatAttr_getType

[clang] [llvm] Enable format info for C function declarations in Clang Index API, so we may have this context (PR #113754)

2024-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: AR Visions (ar-visions) Changes Enable format info for C function declarations in Clang Index API, so we may have this context clang_Cursor_getFormatAttr Get FormatAttr at Function Declaration clang_FormatAttr_getType

[clang] [llvm] Enable format info for C function declarations in Clang Index API, so we may have this context (PR #113754)

2024-10-25 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] Expose C format (attribute) info for function declarations in Clang Index API (PR #113754)

2024-10-25 Thread AR Visions via cfe-commits
https://github.com/ar-visions edited https://github.com/llvm/llvm-project/pull/113754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable format info for C function declarations in Clang Index API, so we may have this context (PR #113754)

2024-10-25 Thread AR Visions via cfe-commits
https://github.com/ar-visions edited https://github.com/llvm/llvm-project/pull/113754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Expose C format (attribute) info for C function declarations in Clang Index API (PR #113754)

2024-10-25 Thread AR Visions via cfe-commits
https://github.com/ar-visions edited https://github.com/llvm/llvm-project/pull/113754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Expose format (attribute) info for function declarations in Clang Index API (PR #113754)

2024-10-25 Thread AR Visions via cfe-commits
https://github.com/ar-visions edited https://github.com/llvm/llvm-project/pull/113754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Expose format (attribute) info for function declarations in Clang Index API (PR #113754)

2024-10-25 Thread AR Visions via cfe-commits
https://github.com/ar-visions edited https://github.com/llvm/llvm-project/pull/113754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Expose format (attribute) info for function declarations in Clang Index API (PR #113754)

2024-10-25 Thread AR Visions via cfe-commits
https://github.com/ar-visions edited https://github.com/llvm/llvm-project/pull/113754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Expose format (attribute) info for function declarations in Clang Index API (PR #113754)

2024-10-25 Thread AR Visions via cfe-commits
https://github.com/ar-visions edited https://github.com/llvm/llvm-project/pull/113754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v4 (PR #108636)

2024-10-25 Thread Peilin Ye via cfe-commits
@@ -703,6 +715,39 @@ SDValue BPFTargetLowering::LowerSELECT_CC(SDValue Op, SelectionDAG &DAG) const { return DAG.getNode(BPFISD::SELECT_CC, DL, VTs, Ops); } +SDValue BPFTargetLowering::LowerATOMIC_LOAD(SDValue Op, +SelectionDAG &D

[clang] [clang-format] Print the names of unfound files in error messages (PR #113640)

2024-10-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/7171 Here is the relevant p

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v4 (PR #108636)

2024-10-25 Thread Peilin Ye via cfe-commits
@@ -48,6 +48,13 @@ def BPF_END : BPFArithOp<0xd>; def BPF_XCHG: BPFArithOp<0xe>; def BPF_CMPXCHG : BPFArithOp<0xf>; +class BPFAtomicLoadStoreOp val> { + bits<4> Value = val; +} + +def BPF_LOAD_ACQ : BPFAtomicLoadStoreOp<0x1>; +def BPF_STORE_REL : BPFAtomicLoadStoreOp<0xb

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 commented: Two minor comments. Script otherwise seems reasonable enough to me. https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-25 Thread Chris Apple via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang] Update std symbols mapping (PR #113612)

2024-10-25 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 updated https://github.com/llvm/llvm-project/pull/113612 >From 96662cb7f681e7158c05a0190894de70eee03d67 Mon Sep 17 00:00:00 2001 From: Vadim Dudkin Date: Thu, 24 Oct 2024 23:18:52 +0300 Subject: [PATCH 1/2] Update std symbol mapping to v20230810; Move assertion to

[clang] [llvm] [ARM] Fix musttail calls (PR #109943)

2024-10-25 Thread Oliver Stannard via cfe-commits
https://github.com/ostannard closed https://github.com/llvm/llvm-project/pull/109943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Fix musttail calls (PR #109943)

2024-10-25 Thread Oliver Stannard via cfe-commits
ostannard wrote: Merged: 376d7b27fa3d [ARM] Optimise byval arguments in tail-calls 914a3990d1a0 [ARM] Avoid clobbering byval arguments when passing to tail-calls a96c14eeb8fc [Clang] Always forward sret parameters to musttail calls 78ec2e2ed5e3 [ARM] Allow tail calls with byval args 82e64721974b

[clang] [clang] Output an error when [[lifetimebound]] attribute is applied on a function parameter while the function returns void (PR #113460)

2024-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/113460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Supm extension to RVA23 profiles (PR #113619)

2024-10-25 Thread Alex Bradbury via cfe-commits
asb wrote: > LGTM. (And it's time to mark RV[A|B|M]23 as non-experimental now?) RVA23 and RVB23 yes. RVM23 isn't ratified yet. I've got a couple of other patches like this to lay the groundwork before flipping the switch. https://github.com/llvm/llvm-project/pull/113619 ___

[clang] Fieldregion descript name (PR #112313)

2024-10-25 Thread via cfe-commits
T-Gruber wrote: > LGTM Hi @steakhal, should we then merge it? Or do you have any comments? https://github.com/llvm/llvm-project/pull/112313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] Fieldregion descript name (PR #112313)

2024-10-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/112313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 86d65ae - [analyzer] Improve FieldRegion descriptive name (#112313)

2024-10-25 Thread via cfe-commits
Author: T-Gruber Date: 2024-10-25T11:59:16+02:00 New Revision: 86d65ae7949e0322f10e1856c5c33caa34ebfe2f URL: https://github.com/llvm/llvm-project/commit/86d65ae7949e0322f10e1856c5c33caa34ebfe2f DIFF: https://github.com/llvm/llvm-project/commit/86d65ae7949e0322f10e1856c5c33caa34ebfe2f.diff LOG:

[clang] [clang][NFC] Add test for CWG1898 "Use of “equivalent” in overload resolution" (PR #113439)

2024-10-25 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/113439 >From 467c478cbc2400e1337e6dcc344a96e4a697341a Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 23 Oct 2024 12:59:36 +0300 Subject: [PATCH 1/2] =?UTF-8?q?[clang][NFC]=20Add=20test=20for=20CWG1898?=

[clang] [clang][NFC] Add test for CWG1898 "Use of “equivalent” in overload resolution" (PR #113439)

2024-10-25 Thread Vlad Serebrennikov via cfe-commits
@@ -640,3 +640,48 @@ namespace H { struct S s; } } + +namespace cwg1898 { // cwg1898: 2.7 +void e(int) {} // #cwg1898-e-int +void e(int) {} +// expected-error@-1 {{redefinition of 'e'}} +// expected-note@#cwg1898-e-int {{previous definition is here}} +void e(long) {} + +voi

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

2024-10-25 Thread Jay Foad via cfe-commits
https://github.com/jayfoad edited https://github.com/llvm/llvm-project/pull/113614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

2024-10-25 Thread Jay Foad via cfe-commits
@@ -15,7 +15,15 @@ AMDGPU_TYPE(Name, Id, SingletonId, Width, Align) #endif +#ifndef AMDGPU_NAMED_BARRIER_TYPE +#define AMDGPU_NAMED_BARRIER_TYPE(Name, Id, SingletonId, Width, Align, Scope) \ + AMDGPU_TYPE(Name, Id, SingletonId, Width, Align) +#endif + AMDGPU_OPAQUE_PTR_TYP

[clang] [llvm] [RISCV] Mark pointer masking extensions as non-experimental (PR #113618)

2024-10-25 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/113618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2024-10-25 Thread Ulrich Weigand via cfe-commits
@@ -16534,7 +16534,7 @@ ExprResult Sema::BuildVAArgExpr(SourceLocation BuiltinLoc, PromoteType = QualType(); } } -if (TInfo->getType()->isSpecificBuiltinType(BuiltinType::Float)) +if (TInfo->getType()->isFloat16Type() || TInfo->getType()->isFloat32T

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-25 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 32baf29 - Make NoopLattice.h self-contained

2024-10-25 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2024-10-25T14:48:38+02:00 New Revision: 32baf2917357b4e5a566ff43c6e0156e5ad10cb8 URL: https://github.com/llvm/llvm-project/commit/32baf2917357b4e5a566ff43c6e0156e5ad10cb8 DIFF: https://github.com/llvm/llvm-project/commit/32baf2917357b4e5a566ff43c6e0156e5ad10cb8.dif

[clang] [WebKit Checkers] Allow a guardian CheckedPtr/CheckedRef (PR #110222)

2024-10-25 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/110222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-25 Thread Boaz Brickner via cfe-commits
@@ -477,6 +485,100 @@ void DiagnosticsEngine::setSeverityForAll(diag::Flavor Flavor, setSeverity(Diag, Map, Loc); } +namespace { +class WarningsSpecialCaseList : public llvm::SpecialCaseList { bricknerb wrote: Do we need to use inheritance here? Could

[clang] [compiler-rt] Reapply " [XRay] Add support for instrumentation of DSOs on x86_64 (#90959)" (PR #113548)

2024-10-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-hwasan` running on `sanitizer-buildbot12` while building `clang,compiler-rt` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/3071 Her

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-25 Thread Boaz Brickner via cfe-commits
@@ -477,6 +485,100 @@ void DiagnosticsEngine::setSeverityForAll(diag::Flavor Flavor, setSeverity(Diag, Map, Loc); } +namespace { +class WarningsSpecialCaseList : public llvm::SpecialCaseList { +public: + static std::unique_ptr + create(const llvm::MemoryBuffer &MB, st

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: Example failing build: https://buildkite.com/llvm-project/github-pull-requests/builds/113045#_ Another example: https://buildkite.com/llvm-project/github-pull-requests/builds/113055#_ The second example should not be failing but this modulemap test is for whatever reason,

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ve-ninja` running on `hpce-ve-main` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/12/builds/8311 Here is the relevant piece of the build log for th

[clang] [clang-repl] Fix undefined lld::wasm::link symbol while building clangInterpreter for wasm (PR #113446)

2024-10-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-s390x-linux` running on `systemz-1` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/42/builds/1620 Here is the relevant piece of the build log f

<    1   2   3   4   5   6   >