[clang] [llvm] [HLSL] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/112400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/112400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/112400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] Full path names are used in several unittests instead of the binary name. Fix up the testcase failures (PR #107974)

2024-10-18 Thread via cfe-commits
https://github.com/HighW4y2H3ll closed https://github.com/llvm/llvm-project/pull/107974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 629a182 - Full path names are used in several unittests instead of the binary name. Fix up the testcase failures (#107974)

2024-10-18 Thread via cfe-commits
Author: HighW4y2H3ll Date: 2024-10-18T11:16:57-07:00 New Revision: 629a182282c5e3dad31e8af5f651f91a4fff1b6a URL: https://github.com/llvm/llvm-project/commit/629a182282c5e3dad31e8af5f651f91a4fff1b6a DIFF: https://github.com/llvm/llvm-project/commit/629a182282c5e3dad31e8af5f651f91a4fff1b6a.diff

[clang] [NFC] add DiagnosticsTestHelper decl (PR #112820)

2024-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c3bbc3a57d439a039d2ea49d9b7e0f6e1c87219d a40fb059ae8bb81806cc399361c48ea5caca0336 --e

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/112400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/112400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov/update_dpp (PR #112447)

2024-10-18 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/112447 >From 761b3e21748dd3a7b53cd0ead745943213317eb4 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Tue, 15 Oct 2024 15:23:28 -0700 Subject: [PATCH 1/6] [AMDGPU] Allow overload of __builtin_amdgcn_mov/up

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/112400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread Richard Smith via cfe-commits
https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/112927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][RISCV] Extend intrinsic size check variable from 16 -> 32 bits. NFC (PR #111481)

2024-10-18 Thread via cfe-commits
goldsteinn wrote: Can this get merged? https://github.com/llvm/llvm-project/pull/111481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][RISCV] Extend intrinsic size check variable from 16 -> 32 bits. NFC (PR #111481)

2024-10-18 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/111481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e3b22dc - [clang][RISCV] Extend intrinsic size check variable from 16 -> 32 bits. NFC (#111481)

2024-10-18 Thread via cfe-commits
Author: Brandon Wu Date: 2024-10-18T11:36:19-07:00 New Revision: e3b22dcedb53386d7ed4db0e013365ebfe67571c URL: https://github.com/llvm/llvm-project/commit/e3b22dcedb53386d7ed4db0e013365ebfe67571c DIFF: https://github.com/llvm/llvm-project/commit/e3b22dcedb53386d7ed4db0e013365ebfe67571c.diff LO

[clang] [Clang] Fix an assertion in expression recovery (PR #112888)

2024-10-18 Thread Shafik Yaghmour via cfe-commits
@@ -1989,7 +1989,7 @@ Expr *CastExpr::getSubExprAsWritten() { SubExpr = IgnoreExprNodes(cast(SubExpr)->getArg(0), ignoreImplicitSemaNodes); } else if (E->getCastKind() == CK_UserDefinedConversion) { - assert((isa(SubExpr) || isa(Su

[clang] [llvm] [RISCV][ISel] Ensure 'in X' Constraints prevent X0 (PR #112563)

2024-10-18 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-18 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: I just had someone in my office hours also running into problems from this commit. I went to revert the changes myself and I cannot because of merge conflicts... due to line endings. @ldrumm -- can you revert these changes ASAP? They're causing significant problems in prac

[clang] [Clang] prevent setting default lexical access specifier for missing primary declarations (PR #112424)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112424 >From a22c6bae4f42f42e67f8e0c2b1f914e50d140099 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 15 Oct 2024 22:43:24 +0300 Subject: [PATCH 1/2] [Clang] prevent setting default lexical access specifier f

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Joshua Batista via cfe-commits
@@ -323,30 +324,119 @@ struct TemplateParameterListBuilder { S.Context, Builder.Record->getDeclContext(), SourceLocation(), SourceLocation(), /* TemplateDepth */ 0, Position, &S.Context.Idents.get(Name, tok::TokenKind::identifier), -/* Typename *

[clang] [llvm] [RISCV][ISel] Ensure 'in X' Constraints prevent X0 (PR #112563)

2024-10-18 Thread Craig Topper via cfe-commits
topperc wrote: > I spent some time trying to write a test that should fail before, but doesn't > after, but it doesn't happen - I presume because x0 is reasonably dealt with > by the allocator. This maybe suggests the patch isn't needed? I'm not sure > why we do this for GPRs then. I think th

[clang] 3eaf4a9 - [clang][bytecode] Check for memory leaks after destroying global scope (#112868)

2024-10-18 Thread via cfe-commits
Author: Timm Baeder Date: 2024-10-18T13:03:13+02:00 New Revision: 3eaf4a9d1a847a4e03a21365682b3a73d7e2e6d0 URL: https://github.com/llvm/llvm-project/commit/3eaf4a9d1a847a4e03a21365682b3a73d7e2e6d0 DIFF: https://github.com/llvm/llvm-project/commit/3eaf4a9d1a847a4e03a21365682b3a73d7e2e6d0.diff L

[clang] [analyzer] Improve solver (PR #112583)

2024-10-18 Thread Arseniy Zaostrovnykh via cfe-commits
https://github.com/necto approved this pull request. https://github.com/llvm/llvm-project/pull/112583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4995d09 - [analyzer][Solver] Improve getSymVal and friends (1/2) (#112583)

2024-10-18 Thread via cfe-commits
Author: Balazs Benics Date: 2024-10-18T13:51:20+02:00 New Revision: 4995d093555f00728e20f4e4095cd182f748cec7 URL: https://github.com/llvm/llvm-project/commit/4995d093555f00728e20f4e4095cd182f748cec7 DIFF: https://github.com/llvm/llvm-project/commit/4995d093555f00728e20f4e4095cd182f748cec7.diff

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl deleted https://github.com/llvm/llvm-project/pull/112767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][Solver] Improve getSymVal and friends (1/2) (PR #112583)

2024-10-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/112583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][Solver] Improve getSymVal and friends (1/2) (PR #112583)

2024-10-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/112583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer][doc] Update Clang SA www docs index.html (PR #112833)

2024-10-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Farzon Lotfi via cfe-commits
@@ -102,6 +102,7 @@ static ResourceClass getResourceClass(RegisterType RT) { return ResourceClass::Sampler; case RegisterType::C: case RegisterType::I: + default: llvm_unreachable("unexpected RegisterType value"); } farzonl wrote: I don't agre

[clang] [NFC] clang add DiagnosticsTestHelper decl (PR #112820)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112820 >From 53683a8543bb6a558a778dc1cc15adb3180df7e4 Mon Sep 17 00:00:00 2001 From: Jinsong Ji Date: Fri, 18 Oct 2024 05:23:19 +0200 Subject: [PATCH 1/2] [NFC] clang add DiagnosticsTestHelper decl MIME-Version: 1.0 Conten

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
@@ -483,10 +573,103 @@ static BuiltinTypeDeclBuilder setupBufferType(CXXRecordDecl *Decl, Sema &S, .addDefaultHandleConstructor(S, RC); } +BinaryOperator *getSizeOfLEQ16Expr(clang::ASTContext &context, damyanp wrote: ```suggestion BinaryOperator *getSi

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
@@ -323,30 +324,99 @@ struct TemplateParameterListBuilder { S.Context, Builder.Record->getDeclContext(), SourceLocation(), SourceLocation(), /* TemplateDepth */ 0, Position, &S.Context.Idents.get(Name, tok::TokenKind::identifier), -/* Typename */

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp edited https://github.com/llvm/llvm-project/pull/112600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
@@ -1,64 +1,64 @@ -// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-library -x hlsl -ast-dump -DEMPTY %s | FileCheck -check-prefix=EMPTY %s damyanp wrote: We should try to fix this before completing the PR. https://github.com/llvm/llvm-project/pull/112600

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
@@ -483,10 +573,103 @@ static BuiltinTypeDeclBuilder setupBufferType(CXXRecordDecl *Decl, Sema &S, .addDefaultHandleConstructor(S, RC); } +BinaryOperator *getSizeOfLEQ16Expr(clang::ASTContext &context, + SourceLocation NameLoc, +

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
@@ -323,30 +324,99 @@ struct TemplateParameterListBuilder { S.Context, Builder.Record->getDeclContext(), SourceLocation(), SourceLocation(), /* TemplateDepth */ 0, Position, &S.Context.Idents.get(Name, tok::TokenKind::identifier), -/* Typename */

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
@@ -483,10 +573,103 @@ static BuiltinTypeDeclBuilder setupBufferType(CXXRecordDecl *Decl, Sema &S, .addDefaultHandleConstructor(S, RC); } +BinaryOperator *getSizeOfLEQ16Expr(clang::ASTContext &context, + SourceLocation NameLoc, +

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp commented: Some more notes https://github.com/llvm/llvm-project/pull/112600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread Richard Smith via cfe-commits
@@ -326,45 +328,65 @@ struct LazyOffsetPtr { /// /// If the low bit is clear, a pointer to the AST node. If the low /// bit is set, the upper 63 bits are the offset. - mutable uint64_t Ptr = 0; + static constexpr size_t DataSize = std::max(sizeof(uint64_t), sizeof(T *))

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/112767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread Richard Smith via cfe-commits
https://github.com/zygoloid approved this pull request. One style nit, otherwise looks good, thanks! https://github.com/llvm/llvm-project/pull/112927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 updated https://github.com/llvm/llvm-project/pull/112927 >From 4f37ed5ff6c18c8cf0de244bb064d5f4f60065a4 Mon Sep 17 00:00:00 2001 From: Jessica Clarke Date: Fri, 18 Oct 2024 16:50:22 +0100 Subject: [PATCH 1/2] [clang] Make LazyOffsetPtr more portable LazyOffsetPtr curr

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: > One style nit, otherwise looks good, thanks! I'm not sure "good" is quite the right word given the horrors this interface is hiding, but thanks for the review! https://github.com/llvm/llvm-project/pull/112927 ___ cfe-commits mailing l

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread via cfe-commits
@@ -18957,6 +18957,134 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: @awilfox Could you please verify if this fixes the bug for you? https://github.com/llvm/llvm-project/pull/112927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8182f81 - [NFC] Fix c++ style comment in c file (#112814)

2024-10-18 Thread via cfe-commits
Author: Jinsong Ji Date: 2024-10-18T12:51:29-04:00 New Revision: 8182f8176ec0eb9f96ad50280c759ef6e2ca2d60 URL: https://github.com/llvm/llvm-project/commit/8182f8176ec0eb9f96ad50280c759ef6e2ca2d60 DIFF: https://github.com/llvm/llvm-project/commit/8182f8176ec0eb9f96ad50280c759ef6e2ca2d60.diff LO

[clang] [llvm] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji closed https://github.com/llvm/llvm-project/pull/112814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] add DiagnosticsTestHelper decl (PR #112820)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji closed https://github.com/llvm/llvm-project/pull/112820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-18 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: I believe Chrome is also seeing many test failures due to this (https://crbug.com/374115887), although I haven't yet confirmed it's due to this specific commit. https://github.com/llvm/llvm-project/pull/86318 ___ cfe-commits mailing l

[clang] [llvm] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang,llvm` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/8527 Here is the re

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Farzon Lotfi via cfe-commits
@@ -18957,6 +18957,134 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
@@ -323,30 +324,119 @@ struct TemplateParameterListBuilder { S.Context, Builder.Record->getDeclContext(), SourceLocation(), SourceLocation(), /* TemplateDepth */ 0, Position, &S.Context.Idents.get(Name, tok::TokenKind::identifier), -/* Typename *

[clang] [analyzer] Suppress out of bounds reports after weak loop assumptions (PR #109804)

2024-10-18 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: steakhal wrote: Thank you for sharing your roadmap. I didn't remember there was consensus on a direction of dropping exec

[clang] [clang] Make -fveclib={ArmPL, SLEEF} imply -fno-math-errno (PR #112580)

2024-10-18 Thread Paul Walker via cfe-commits
@@ -502,6 +502,10 @@ def err_sls_hardening_arm_not_supported : Error< def warn_drv_large_data_threshold_invalid_code_model: Warning< "'%0' only applies to medium and large code models">, InGroup; +def warn_drv_math_errno_reenabled_after_veclib: Warning< + "math errno re-en

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Can you explain again why the compiler isn't providing the C library and the > start files implicitly by default, just like it does for non-GPU code? Because the GPU is not a target that wants to provide a C library and start files by default. This is an edge case where I make

[clang] [clang] Make -fveclib={ArmPL, SLEEF} imply -fno-math-errno (PR #112580)

2024-10-18 Thread Maciej Gabka via cfe-commits
@@ -36,16 +36,23 @@ /* Verify that the correct vector library is passed to LTO flags. */ // RUN: %clang -### --target=x86_64-unknown-linux-gnu -fveclib=LIBMVEC -flto %s 2>&1 | FileCheck --check-prefix=CHECK-LTO-LIBMVEC %s +// CHECK-LTO-LIBMVEC: "-fmath-errno" // CHECK-LTO-LI

[clang] [Clang] Fix an assertion in expression recovery (PR #112888)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes Explicit object member function calls are not modelled as member calls Fixes #112559 --- Full diff: https://github.com/llvm/llvm-project/pull/112888.diff 3 Files Affected: - (modified) clang/docs/ReleaseNote

[clang] [Clang] Fix an assertion in expression recovery (PR #112888)

2024-10-18 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/112888 Explicit object member function calls are not modelled as member calls Fixes #112559 >From bbb39f2941e38c07ea6902486276528fc10db367 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Fri, 18 Oct 2024 13:52:2

[clang] [clang][analyzer][doc] Migrate ClangSA www FAQ section (PR #112831)

2024-10-18 Thread Balazs Benics via cfe-commits
steakhal wrote: I more than welcome migrating from raw html to rst. - or basically to any other format. https://github.com/llvm/llvm-project/pull/112831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [llvm] OpenMP offload 'simd' directive (PR #91261)

2024-10-18 Thread Eric Wright via cfe-commits
https://github.com/efwright updated https://github.com/llvm/llvm-project/pull/91261 >From 4b76d56f38baf86f6b65ef7e610ad266ba3d69b1 Mon Sep 17 00:00:00 2001 From: Eric Francis Wright Date: Mon, 6 May 2024 12:20:44 -0700 Subject: [PATCH 1/4] OpenMP offload 'simd' directive --- clang/lib/CodeGen

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: Can you explain again why the compiler isn't providing the C library and the start files implicitly by default, just like it does for non-GPU code? https://github.com/llvm/llvm-project/pull/112025 ___ cfe-commits mailing list cfe-commi

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-18 Thread via cfe-commits
@@ -102,7 +102,7 @@ struct __aliasing_iterator_wrapper { _LIBCPP_HIDE_FROM_ABI _Alias operator*() const _NOEXCEPT { _Alias __val; - __builtin_memcpy(&__val, std::__to_address(__base_), sizeof(value_type)); + __builtin_memcpy(&__val, static_cast(std::__to_ad

[clang] [flang] [lldb] [llvm] [mlir] Fix typo "instrinsic" (PR #112899)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-webassembly @llvm/pr-subscribers-clang Author: Jay Foad (jayfoad) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/112899.diff 19 Files Affected: - (modified) clang/utils/TableGen/RISCVVEmitter.cpp (+2-2) - (modified) flang/

[clang] [flang] [lldb] [llvm] [mlir] Fix typo "instrinsic" (PR #112899)

2024-10-18 Thread Christian Ulmann via cfe-commits
https://github.com/Dinistro approved this pull request. LGTM, thanks for the fixes 😄 https://github.com/llvm/llvm-project/pull/112899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove type-punning in LazyOffsetPtr. (PR #112806)

2024-10-18 Thread Jessica Clarke via cfe-commits
@@ -321,50 +322,87 @@ class ExternalASTSource : public RefCountedBase { /// external AST source itself. template struct LazyOffsetPtr { - /// Either a pointer to an AST node or the offset within the - /// external AST source where the AST node can be found. - /// - /// If

[clang] [analyzer][Solver] Teach SymbolicRangeInferrer about commutativity (2/2) (PR #112887)

2024-10-18 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM. I already reviewed this together with the first step. https://github.com/llvm/llvm-project/pull/112887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[libcxx] [libcxxabi] [libunwind] [CMake] Handle multiple flags in ADDITIONAL_COMPILE_FLAGS properly (PR #112703)

2024-10-18 Thread Stephanos Ioannidis via cfe-commits
https://github.com/stephanosio closed https://github.com/llvm/llvm-project/pull/112703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [CMake] Handle multiple flags in ADDITIONAL_COMPILE_FLAGS properly (PR #112703)

2024-10-18 Thread Stephanos Ioannidis via cfe-commits
stephanosio wrote: @ldionne Thanks for clarifying. I will close this since `{LIBCXX,LIBCXXABI,LIBUNWIND}_ADDITIONAL_COMPILE_FLAGS` was never meant to take space-separated compile flags. https://github.com/llvm/llvm-project/pull/112703 ___ cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/109331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove support for RenderScript (PR #112916)

2024-10-18 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM once @pirama-arumuga-nainar is happy with it https://github.com/llvm/llvm-project/pull/112916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang-format] Fix a bug that always returns error for JSON (PR #112839)

2024-10-18 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/112839 >From 9eb81c845aa102e28c87eeefe82fac3f029ae29e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 17 Oct 2024 21:52:16 -0700 Subject: [PATCH 1/2] [clang-format] Fix a bug that always returns error for JSON Fixe

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/109331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Jinsong Ji via cfe-commits
@@ -8,7 +8,6 @@ #include "clang-c/Documentation.h" #include "clang-c/Index.h" #include "clang/Config/config.h" -#include "llvm/Support/AutoConvert.h" jsji wrote: Done. Please review. Thanks. https://github.com/llvm/llvm-project/pull/112814 ___

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Farzon Lotfi via cfe-commits
@@ -18957,6 +18957,134 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] [llvm] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112814 >From d37014d8da13a3de36a7aaa0ed9a6f72c72d155d Mon Sep 17 00:00:00 2001 From: Jinsong Ji Date: Fri, 18 Oct 2024 04:56:17 +0200 Subject: [PATCH 1/3] [NFC] Fix c++ style comment in c file This is one of the many PRs

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-18 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > > a number of test input files need to be in LF form to work > > Which ones? A whole bunch of them. @AaronBallman's link to https://buildkite.com/llvm-project/github-pull-requests/builds/65#0192a01b-d3ac-44ad-abff-e53ac4a206ab shows mostly what I saw. If including `clang

[clang] [clang] Make -fveclib={ArmPL, SLEEF} imply -fno-math-errno (PR #112580)

2024-10-18 Thread Benjamin Maxwell via cfe-commits
@@ -36,16 +36,23 @@ /* Verify that the correct vector library is passed to LTO flags. */ // RUN: %clang -### --target=x86_64-unknown-linux-gnu -fveclib=LIBMVEC -flto %s 2>&1 | FileCheck --check-prefix=CHECK-LTO-LIBMVEC %s +// CHECK-LTO-LIBMVEC: "-fmath-errno" // CHECK-LTO-LI

[clang] [clang-format] Fix a bug that always returns error for JSON (PR #112839)

2024-10-18 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/112839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] add DiagnosticsTestHelper decl (PR #112820)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112820 >From 53683a8543bb6a558a778dc1cc15adb3180df7e4 Mon Sep 17 00:00:00 2001 From: Jinsong Ji Date: Fri, 18 Oct 2024 05:23:19 +0200 Subject: [PATCH 1/5] [NFC] clang add DiagnosticsTestHelper decl MIME-Version: 1.0 Conten

[clang] [llvm] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c3bbc3a57d439a039d2ea49d9b7e0f6e1c87219d d72d0e3d31ec0569a2e8e35df2bbae469bbb1b27 --e

[clang] [llvm] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/112814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove support for RenderScript (PR #112916)

2024-10-18 Thread via cfe-commits
https://github.com/pirama-arumuga-nainar approved this pull request. https://github.com/llvm/llvm-project/pull/112916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] LazyOffsetPtr: Use native pointer width (PR #111995)

2024-10-18 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: > > But yes, the short answer is that the code as written should work on > > Morello and CHERI-RISC-V. > > Great, thanks. > > > > > The std::launder may be unnecessary > > > > > > > > > Formally I think it's correct and necessary for the pointer and integer > > > case because

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-18 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > This seems to have broken precommit CI on Windows: > https://buildkite.com/llvm-project/github-pull-requests/builds/65#0192a01b-d3ac-44ad-abff-e53ac4a206ab > all of the failures look related to line endings, and I noticed that I got a > ton of command line messages of the

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jessica Clarke (jrtc27) Changes LazyOffsetPtr currently relies on uint64_t being able to store a pointer and, unless sizeof(uint64_t) == sizeof(void *), little endianness, since getAddressOfPointer reinterprets the memory as a pointer. This

[clang] [Clang] Emit error for duplicate mangled names within a lambda (PR #107581)

2024-10-18 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Can you add a testcase that doesn't involve lambdas? Maybe something like the following: ``` inline void f(int) asm("foo"); inline void f(int) {} inline void f() asm("foo"); inline void f(){} ``` https://github.com/llvm/llvm-project/pull/107581 ___

[clang] [llvm] [Coverage] Introduce "partial fold" on BranchRegion (PR #112694)

2024-10-18 Thread Alan Phipps via cfe-commits
https://github.com/evodius96 approved this pull request. https://github.com/llvm/llvm-project/pull/112694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-18 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/111561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread A. Wilcox via cfe-commits
awilfox wrote: I'll run a full test on the ppc32 builder now and report back. Thanks for this work. https://github.com/llvm/llvm-project/pull/112927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] Remove support for RenderScript (PR #112916)

2024-10-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/112916 >From bb479e3a3d3b5181495fa5dc61ec61cb61b59b46 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Fri, 18 Oct 2024 10:40:06 -0400 Subject: [PATCH 1/2] Remove support for RenderScript See https://discourse

[clang] [clang-tools-extra] [flang] Fix OOM in FormatDiagnostic (2nd attempt) (PR #108866)

2024-10-18 Thread Ivan Kosarev via cfe-commits
kosarev wrote: @igelbox This seems to cause `Clang-Unit :: Rename/./ClangRenameTests/*` failures on my machine. Still reproduces on the current top of branch, dbe47c2a06e0928edde802d062ecf1a0ce45fbb9. Anyone else can see the failures? The `Clang-Unit :: AST/Interp/./InterpTests/*` failures are

[clang] [llvm] [Coverage] Introduce "partial fold" on BranchRegion (PR #112694)

2024-10-18 Thread Alan Phipps via cfe-commits
evodius96 wrote: I think this is a meaningful enhancement to branch coverage. I don't have much to add to what's been said. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/112694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] Fix typo in "translation unit" in analyzer doc CommandLineUsage.rst (PR #112966)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: BrnBlrg (BenBlumer) Changes Fix typo in "translation unit" in analyzer doc CommandLineUsage.rst --- Full diff: https://github.com/llvm/llvm-project/pull/112966.diff 1 Files Affected: - (modified) clang/docs/analyzer/user-docs/CommandLin

[clang] Fix typo in "translation unit" in analyzer doc CommandLineUsage.rst (PR #112966)

2024-10-18 Thread via cfe-commits
https://github.com/BenBlumer created https://github.com/llvm/llvm-project/pull/112966 Fix typo in "translation unit" in analyzer doc CommandLineUsage.rst >From cc1f072fa7c10147d19fa67037a642c7967914db Mon Sep 17 00:00:00 2001 From: BrnBlrg Date: Fri, 18 Oct 2024 12:57:54 -0700 Subject: [PATCH]

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov/update_dpp (PR #112447)

2024-10-18 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/112447 >From 761b3e21748dd3a7b53cd0ead745943213317eb4 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Tue, 15 Oct 2024 15:23:28 -0700 Subject: [PATCH 1/7] [AMDGPU] Allow overload of __builtin_amdgcn_mov/up

[clang] Fix typo in "translation unit" in analyzer doc CommandLineUsage.rst (PR #112966)

2024-10-18 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] Fix handling of immediate escalation for inherited constructors (PR #112860)

2024-10-18 Thread Erik Jensen via cfe-commits
rkjnsn wrote: > With this patch, the first one produces an error, the second doesn't. > Which... seems dubious? I am far from a standards expert, but I would _expect_ both to compile? When calling an inherited constructor, "all other bases and members of Derived are initialized as if by the d

[clang] [Clang] prevent setting default lexical access specifier for missing primary declarations (PR #112424)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112424 >From a22c6bae4f42f42e67f8e0c2b1f914e50d140099 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 15 Oct 2024 22:43:24 +0300 Subject: [PATCH 1/2] [Clang] prevent setting default lexical access specifier f

[clang] e669bbb - Revert "Finally formalise our defacto line-ending policy"

2024-10-18 Thread Luke Drummond via cfe-commits
Author: Luke Drummond Date: 2024-10-18T21:16:24+01:00 New Revision: e6697265a7d4d59bac2d3889194efa167ea8 URL: https://github.com/llvm/llvm-project/commit/e6697265a7d4d59bac2d3889194efa167ea8 DIFF: https://github.com/llvm/llvm-project/commit/e6697265a7d4d59bac2d3889194efa167ea8.diff

[clang] Fix typo in "translation unit" in analyzer doc CommandLineUsage.rst (PR #112966)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: BrnBlrg (BenBlumer) Changes Fix typo in "translation unit" in analyzer doc CommandLineUsage.rst --- Full diff: https://github.com/llvm/llvm-project/pull/112966.diff 1 Files Affected: - (modified) clang/docs/analyzer/us

[clang] [clang] Make -fveclib={ArmPL, SLEEF} imply -fno-math-errno (PR #112580)

2024-10-18 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue updated https://github.com/llvm/llvm-project/pull/112580 >From 9d378377a16798f4a866364a1c3f5d71b963cf15 Mon Sep 17 00:00:00 2001 From: Benjamin Maxwell Date: Wed, 2 Oct 2024 10:28:29 + Subject: [PATCH 1/6] [clang] Make -fveclib={ArmPL,SLEEF} imply -fno-math-errno

<    1   2   3   4   5   >