[clang] [clang][dataflow] Add a lattice to help cache const accessor methods (PR #111006)

2024-10-15 Thread Jan Voung via cfe-commits
@@ -0,0 +1,217 @@ +//===- unittests/Analysis/FlowSensitive/CachedConstAccessorsLatticeTest.cpp ==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [lld] [Driver] Default enable LoongArch linker relaxation (PR #111488)

2024-10-15 Thread Fangrui Song via cfe-commits
MaskRay wrote: Personally I hope that `-mrelax` stays > > How about now? > > The patch doesn't touch lld, so my suggestion is "[Driver] Default enable > LoongArch linker relaxation". > > Some additional comments: > > * Do we need to consider the `-gsplit-dwarf` issue [MC: "error: A dwo sect

[clang] [Clang][Sema] Use the correct injected template arguments for partial specializations when collecting multi-level template argument lists (PR #112381)

2024-10-15 Thread Matheus Izvekov via cfe-commits
@@ -2085,7 +2085,9 @@ class ClassTemplateSpecializationDecl : public CXXRecordDecl, class ClassTemplatePartialSpecializationDecl : public ClassTemplateSpecializationDecl { /// The list of template parameters - TemplateParameterList* TemplateParams = nullptr; + TemplatePa

[clang] [lld] [Driver] Default enable LoongArch linker relaxation (PR #111488)

2024-10-15 Thread Jinyang He via cfe-commits
@@ -134,6 +134,12 @@ void loongarch::getLoongArchTargetFeatures(const Driver &D, (!Args.hasArgNoClaim(clang::driver::options::OPT_march_EQ))) Features.push_back("+lsx"); + if (Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true)) { +Features.push_back

[clang] [clang][dataflow] Add a lattice to help cache const accessor methods (PR #111006)

2024-10-15 Thread Jan Voung via cfe-commits
@@ -0,0 +1,218 @@ +//===-- CachedConstAccessorsLattice.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][dataflow] Add a lattice to help cache const accessor methods (PR #111006)

2024-10-15 Thread Jan Voung via cfe-commits
@@ -0,0 +1,218 @@ +//===-- CachedConstAccessorsLattice.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-15 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @dmpolukhin I am still confusing about the problem. I mean, why your previous patch will break the reproducer and why this patch can "fix" it? I feel the current patch is somewhat workaround. It's not your fault. The original codes are somewhat tricky already. But let's try t

[clang] [Clang][Sema] Use the correct injected template arguments for partial specializations when collecting multi-level template argument lists (PR #112381)

2024-10-15 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/112381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add CHECK-LABEL to avoid source tree path sensitivity in test (PR #112461)

2024-10-15 Thread Tex Riddell via cfe-commits
https://github.com/tex3d created https://github.com/llvm/llvm-project/pull/112461 The test `clang/test/CodeGen/2004-02-20-Builtins.c` will erroneously fail if "builtin" is in the path to your source tree. This change adds a `CHECK-LABEL !llvm.ident` after the `CHECK-NOT` to avoid searching in

[libunwind] [libunwind][AIX] Remove weak declaration "__xlcxx_personality_v0" (PR #112436)

2024-10-15 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast edited https://github.com/llvm/llvm-project/pull/112436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov/update_dpp (PR #112447)

2024-10-15 Thread Stanislav Mekhanoshin via cfe-commits
rampitec wrote: Note, there is also dpp8 with the similar problem. But dpp8 is not properly handled even if intrinsic is used with a 64-bit type (i.e. not split into 2 separate 32-bit dpp ops). This would be a nice to have, but not absolutely necessary like here, because there are no 64-bit re

[libunwind] [libunwind][AIX] Remove weak declaration "__xlcxx_personality_v0" (PR #112436)

2024-10-15 Thread Hubert Tong via cfe-commits
hubert-reinterpretcast wrote: @xingxue-ibm, I edited the PR description text. Please check my edits. https://github.com/llvm/llvm-project/pull/112436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Arvind Sudarsanam via cfe-commits
https://github.com/asudarsa updated https://github.com/llvm/llvm-project/pull/112245 >From eff4a0300336c4c106e1d293b19e795f5ccbabc1 Mon Sep 17 00:00:00 2001 From: Arvind Sudarsanam Date: Fri, 27 Sep 2024 13:03:12 -0700 Subject: [PATCH 1/8] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link

[libunwind] [libunwind][AIX] Remove weak declaration "__xlcxx_personality_v0" (PR #112436)

2024-10-15 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast edited https://github.com/llvm/llvm-project/pull/112436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > LLD has a wasm target. Exactly what I meant. > I think LLD also needs to eventually gain a SPIR-V target to support linking > SPIR-V binaries, because SPIR-V does support linkage at the SPIR-V level not > just the LTO IR level (see: > https://registry.khronos.org/SPIR-V/spec

[clang] [compiler-rt] [llvm] [PGO] Initialize GCOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-15 Thread Hubert Tong via cfe-commits
@@ -0,0 +1,129 @@ +; Tests if the __llvm_gcov_ctr section contains a .ref pseudo-op +; referring to the __llvm_covinit section. +; RUN: llc < %s | FileCheck --check-prefixes=CHECK,CHECK-RW %s +; RUN: llc -mxcoff-roptr < %s | FileCheck --check-prefixes=CHECK,CHECK-RO %s + +target d

[clang] [lld] [llvm] [WebAssembly] Enable nontrapping-fptoint and bulk-memory by default. (PR #112049)

2024-10-15 Thread Dan Gohman via cfe-commits
@@ -2,7 +2,7 @@ ; RUN: llvm-as -o %t.o %s ; RUN: llvm-as -o %t2.o %S/Inputs/libcall-archive.ll ; RUN: llvm-ar rcs %t.a %t2.o -; RUN: wasm-ld -o %t %t.o %t.a +; RUN: wasm-ld -mllvm -mattr=-bulk-memory -o %t %t.o %t.a sunfishcode wrote: This is an LTO test, so t

[clang] [clang][HLSL] Add GroupMemoryBarrierWithGroupSync intrinsic (PR #111883)

2024-10-15 Thread Adam Yang via cfe-commits
https://github.com/adam-yang updated https://github.com/llvm/llvm-project/pull/111883 >From 0f97b92617dcadd78362f24f3ef0719c19f6f3f6 Mon Sep 17 00:00:00 2001 From: Adam Yang Date: Thu, 10 Oct 2024 10:20:37 -0700 Subject: [PATCH 1/6] Added the intrinsic to clang --- clang/include/clang/Basic/B

[libunwind] [libunwind][AIX] Remove weak definition "__xlcxx_personality_v0" (PR #112436)

2024-10-15 Thread Hubert Tong via cfe-commits
@@ -2126,42 +2125,34 @@ bool UnwindCursor::getInfoFromTBTable(pint_t pc, R ®isters) { // function __xlcxx_personality_v0(), which is the personality for the state // table and is exported from libc++abi, is directly assigned as the // handler here. When a legacy X

[libunwind] [libunwind][AIX] Remove weak definition "__xlcxx_personality_v0" (PR #112436)

2024-10-15 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast edited https://github.com/llvm/llvm-project/pull/112436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][AIX] Remove weak definition "__xlcxx_personality_v0" (PR #112436)

2024-10-15 Thread Hubert Tong via cfe-commits
@@ -2126,42 +2125,34 @@ bool UnwindCursor::getInfoFromTBTable(pint_t pc, R ®isters) { // function __xlcxx_personality_v0(), which is the personality for the state // table and is exported from libc++abi, is directly assigned as the // handler here. When a legacy X

[libunwind] [libunwind][AIX] Remove weak definition "__xlcxx_personality_v0" (PR #112436)

2024-10-15 Thread Hubert Tong via cfe-commits
@@ -2126,42 +2125,34 @@ bool UnwindCursor::getInfoFromTBTable(pint_t pc, R ®isters) { // function __xlcxx_personality_v0(), which is the personality for the state // table and is exported from libc++abi, is directly assigned as the // handler here. When a legacy X

[libunwind] [libunwind][AIX] Remove weak definition "__xlcxx_personality_v0" (PR #112436)

2024-10-15 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast commented: I think a small test case could be added with a `int main(void) {}` C program linked with -`brtl` and `LDR_PRELOAD`/`LDR_PRELOAD64` set to `libunwind.a(libunwind.so.1)`. https://github.com/llvm/llvm-project/pull/112436 __

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Chris B via cfe-commits
llvm-beanz wrote: > I don't think `lld` makes sense, but you can definitely use the LTO interface > inside of this tool to create a similar effect. Why not? `lld` is a toolchain linker (which you said this is supposed to emulate), and it is an interface to the LTO interface... so it seems to

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov/update_dpp (PR #112447)

2024-10-15 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/112447 >From 761b3e21748dd3a7b53cd0ead745943213317eb4 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Tue, 15 Oct 2024 15:23:28 -0700 Subject: [PATCH 1/3] [AMDGPU] Allow overload of __builtin_amdgcn_mov/up

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I don't think `lld` makes sense, but you can definitely use the LTO > > interface inside of this tool to create a similar effect. > > Why not? `lld` is a toolchain linker (which you said this is supposed to > emulate), and it is an interface to the LTO interface... so it see

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Chris B via cfe-commits
llvm-beanz wrote: > I guess the closest analogue would be the WASM target? LLD has a wasm target. > It seems like overkill since the `ld.lld` source code doesn't really share > much code and this target pretty much only consumes LLVM-IR. I think LLD also needs to eventually gain a SPIR-V targ

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Chris B via cfe-commits
llvm-beanz wrote: I think we could all benefit from some documentation describing how the SYCL compiler flow is intended to work, what tools are added/modified, and what the expected outputs are at each compiler phase. Without some idea of the architecture of what is being built changes like t

[clang] [lld] [llvm] [WebAssembly] Enable nontrapping-fptoint and bulk-memory by default. (PR #112049)

2024-10-15 Thread Sam Clegg via cfe-commits
@@ -2,7 +2,7 @@ ; RUN: llvm-as -o %t.o %s ; RUN: llvm-as -o %t2.o %S/Inputs/libcall-archive.ll ; RUN: llvm-ar rcs %t.a %t2.o -; RUN: wasm-ld -o %t %t.o %t.a +; RUN: wasm-ld -mllvm -mattr=-bulk-memory -o %t %t.o %t.a sbc100 wrote: I was thinking that might make

[clang] [clang][HLSL] Add GroupMemoryBarrierWithGroupSync intrinsic (PR #111883)

2024-10-15 Thread Adam Yang via cfe-commits
@@ -2018,6 +2018,11 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { return true; break; } + case Builtin::BI__builtin_hlsl_group_memory_barrier_with_group_sync: { +if (SemaRef.checkArgCountAtMost(TheCall, 0)) ---

[clang] [clang][modules] Timestamp PCM files when writing (PR #112452)

2024-10-15 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/112452 Clang uses timestamp files to track the last time an implicitly-built PCM file was verified to be up-to-date with regard to its inputs. With `-fbuild-session-{file,timestamp}=` and `-fmodules-validate-on

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I think we could all benefit from some documentation describing how the SYCL > compiler flow is intended to work, what tools are added/modified, and what > the expected outputs are at each compiler phase. Without some idea of the > architecture of what is being built changes l

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Arvind Sudarsanam via cfe-commits
asudarsa wrote: Hi @llvm-beanz and @jhuber6 Thanks so much for all the feedback and discussion here. I am very much grateful for both your time and insights here. I will try to give my answers in this comment. An overview of the SYCL compilation flow (with a bit more emphasis on the device c

[clang] Add arrangeCXXMethodCall to the CodeGenABITypes interface. (PR #111597)

2024-10-15 Thread Hiroshi Yamauchi via cfe-commits
https://github.com/hjyamauchi updated https://github.com/llvm/llvm-project/pull/111597 >From ae4cdf4458b84b5fe5ab22f1ef4b5ceaf439a4f0 Mon Sep 17 00:00:00 2001 From: Hiroshi Yamauchi Date: Thu, 10 Oct 2024 13:50:01 -0700 Subject: [PATCH] Add arrangeCXXMethodCall to the CodeGenABITypes interface.

[clang] [clang][modules] Timestamp PCM files when writing (PR #112452)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Jan Svoboda (jansvoboda11) Changes Clang uses timestamp files to track the last time an implicitly-built PCM file was verified to be up-to-date with regard to its inputs. With `-fbuild-session-{file,timestamp}=` and `-fmodules-v

[clang] [clang][modules] Timestamp PCM files when writing (PR #112452)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes Clang uses timestamp files to track the last time an implicitly-built PCM file was verified to be up-to-date with regard to its inputs. With `-fbuild-session-{file,timestamp}=` and `-fmodules-validate-

[clang] [clang][modules] Timestamp PCM files when writing (PR #112452)

2024-10-15 Thread Jan Svoboda via cfe-commits
@@ -4905,6 +4905,10 @@ ASTFileSignature ASTWriter::WriteAST(Sema &SemaRef, StringRef OutputFile, this->BaseDirectory.clear(); WritingAST = false; + + if (WritingModule) +updateModuleTimestamp(OutputFile); jansvoboda11 wrote: Calling this here is a b

[clang] [compiler-rt] [llvm] [PGO] Initialize GCOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-15 Thread Hubert Tong via cfe-commits
@@ -8,14 +8,19 @@ target triple = "powerpc-ibm-aix" ; CHECK-RW: .csect __llvm_covinit[RW],3 ; CHECK-RO: .csect __llvm_covinit[RO],3 -; CHECK: .vbyte 4, __llvm_gcov_writeout[DS] -; CHECK-NEXT:.vbyte 4, __llvm_gcov_reset[DS] -; CHECK: __llvm_gcov_ctr.1: +; CHECK-NE

[clang] [lld] [llvm] [WebAssembly] Enable nontrapping-fptoint and bulk-memory by default. (PR #112049)

2024-10-15 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode updated https://github.com/llvm/llvm-project/pull/112049 >From 7d55b35158ceb1a5d35ac62ecfe404f6a374e526 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Fri, 11 Oct 2024 13:31:13 -0700 Subject: [PATCH 1/5] [WebAssembly] Enable nontrapping-fptoint and bulk-memory b

[clang] [llvm] [MIPS] LLVM data layout give i128 an alignment of 16 for mips64 (PR #112084)

2024-10-15 Thread via cfe-commits
beetrees wrote: Clang currently always gives `__int128` and `__uint128` an alignment of 16 bytes (128 bits), except on SystemZ where they have an alignment of 8 bytes (64 bits). I'm not aware of any MIPS ABI specification that includes 128-bit integers, but an alignment of 16 bytes is used by

[clang] [compiler-rt] [llvm] [PGO] Initialize GCOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-15 Thread Hubert Tong via cfe-commits
@@ -0,0 +1,129 @@ +; Tests if the __llvm_gcov_ctr section contains a .ref pseudo-op +; referring to the __llvm_covinit section. +; RUN: llc < %s | FileCheck --check-prefixes=CHECK,CHECK-RW %s +; RUN: llc -mxcoff-roptr < %s | FileCheck --check-prefixes=CHECK,CHECK-RO %s + +target d

[clang] [Clang][Sema] Use the correct injected template arguments for partial specializations when collecting multi-level template argument lists (PR #112381)

2024-10-15 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/112381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Use the correct injected template arguments for partial specializations when collecting multi-level template argument lists (PR #112381)

2024-10-15 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. LG modulo one question. Thanks for the prompt fix. https://github.com/llvm/llvm-project/pull/112381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [Clang][Sema] Use the correct injected template arguments for partial specializations when collecting multi-level template argument lists (PR #112381)

2024-10-15 Thread Younan Zhang via cfe-commits
@@ -2085,7 +2085,9 @@ class ClassTemplateSpecializationDecl : public CXXRecordDecl, class ClassTemplatePartialSpecializationDecl : public ClassTemplateSpecializationDecl { /// The list of template parameters - TemplateParameterList* TemplateParams = nullptr; + TemplatePa

[clang] d1a4791 - [Clang][TableGen] Use const pointers for various `Init *` pointers in SA checker emitter (#112321)

2024-10-15 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-10-15T12:50:44-07:00 New Revision: d1a47915d0f44d7392de1665dbb99cfceec907a5 URL: https://github.com/llvm/llvm-project/commit/d1a47915d0f44d7392de1665dbb99cfceec907a5 DIFF: https://github.com/llvm/llvm-project/commit/d1a47915d0f44d7392de1665dbb99cfceec907a5.diff L

[clang] [Clang][TableGen] Use const pointers for various `Init *` pointers in SA checker emitter (PR #112321)

2024-10-15 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/112321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add GroupMemoryBarrierWithGroupSync intrinsic (PR #111883)

2024-10-15 Thread Adam Yang via cfe-commits
@@ -2018,6 +2018,11 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { return true; break; } + case Builtin::BI__builtin_hlsl_group_memory_barrier_with_group_sync: { +if (SemaRef.checkArgCountAtMost(TheCall, 0)) ---

[clang] [Clang][TableGen] Use const pointers for various Init objects in NeonEmitter (PR #112317)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Use const pointers for various Init objects in NeonEmitter. This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getal

[clang] [Clang][TableGen] Use const pointers for various Init objects in Diagnostic Emitter (PR #112318)

2024-10-15 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/112318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use const pointers for various Init objects in Diagnostic Emitter (PR #112318)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Use const pointers for various Init objects in Diagnostic Emitter. This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-

[clang] [Clang][TableGen] Use const pointers for various `Init *` pointers in SA checker emitter (PR #112321)

2024-10-15 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/112321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use const pointers for various Init objects in NeonEmitter (PR #112317)

2024-10-15 Thread Rahul Joshi via cfe-commits
@@ -1438,9 +1439,9 @@ void Intrinsic::emitReturn() { emitNewLine(); } -std::pair Intrinsic::DagEmitter::emitDag(DagInit *DI) { +std::pair Intrinsic::DagEmitter::emitDag(const DagInit *DI) { // At this point we should only be seeing a def. - DefInit *DefI = cast(DI->getO

[clang] [clang][HLSL] Add GroupMemoryBarrierWithGroupSync intrinsic (PR #111883)

2024-10-15 Thread Adam Yang via cfe-commits
https://github.com/adam-yang updated https://github.com/llvm/llvm-project/pull/111883 >From 0f97b92617dcadd78362f24f3ef0719c19f6f3f6 Mon Sep 17 00:00:00 2001 From: Adam Yang Date: Thu, 10 Oct 2024 10:20:37 -0700 Subject: [PATCH 1/5] Added the intrinsic to clang --- clang/include/clang/Basic/B

[clang] [Clang] prevent setting default lexical access specifier for missing primary declarations (PR #112424)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #112208 --- Full diff: https://github.com/llvm/llvm-project/pull/112424.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modified) clang/lib/Sema/SemaAccess.cpp (+2-1) -

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-10-15 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/112015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-10-15 Thread Jan Svoboda via cfe-commits
@@ -43,7 +43,7 @@ module third {} // CHECK-NEXT: "command-line": [ // CHECK-NEXT: "-cc1", // CHECK: "-fmodule-map-file=[[PREFIX]]/second/second/module.modulemap" -// CHECK-NOT: "-fmodule-map-file=[[PREFIX]]/second/second/sub.modulemap" +//

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-10-15 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 commented: Thanks for trying to find an alternative solution! > However, when reading the .pcm files, we will reuse the FileID loaded from it > for the same module map file and the FileID we created can never be used > again, but we will still not mark it as aff

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-15 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/112047 >From 604835395cd4006cb0344e94553191035fe4cbfb Mon Sep 17 00:00:00 2001 From: higher-performance Date: Fri, 11 Oct 2024 17:09:13 -0400 Subject: [PATCH] Make [[clang::lifetimebound]] work for expressio

[clang] Different info in docs in AST methods (PR #112190)

2024-10-15 Thread Mikhnenko Sasha via cfe-commits
https://github.com/4JustMe4 updated https://github.com/llvm/llvm-project/pull/112190 >From 4cd2e269cec8eb0c0bc31c10ecef4979645e32f1 Mon Sep 17 00:00:00 2001 From: mikhnenko Date: Mon, 14 Oct 2024 15:29:16 +0300 Subject: [PATCH 1/2] Fix different info --- clang/include/clang/ASTMatchers/ASTMat

[clang] [Clang][TableGen] Use const pointers for various Init objects in Diagnostic Emitter (PR #112318)

2024-10-15 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/112318 >From 1629f6eacc566139a3f38100014586fa5dbba152 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Mon, 14 Oct 2024 22:56:07 -0700 Subject: [PATCH] [Clang][TableGen] Use const pointer for various `Init` pointers.

[libunwind] [libunwind][AIX] Remove weak definition "__xlcxx_personality_v0" (PR #112436)

2024-10-15 Thread Xing Xue via cfe-commits
https://github.com/xingxue-ibm updated https://github.com/llvm/llvm-project/pull/112436 >From edabcb3b43800c3e12a55325a786600064ccde10 Mon Sep 17 00:00:00 2001 From: Xing Xue Date: Tue, 15 Oct 2024 16:21:29 -0400 Subject: [PATCH 1/2] Remove weak definition "__xlcxx_personality_v0". --- libunw

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-15 Thread Aaron Puchert via cfe-commits
@@ -5335,6 +5335,217 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// This function is called only if function call is not inside template body. +// TODO: Add call

[clang] clang-format: Add "AllowShortNamespacesOnASingleLine" option (PR #105597)

2024-10-15 Thread Galen Elias via cfe-commits
https://github.com/galenelias updated https://github.com/llvm/llvm-project/pull/105597 >From 4118b7dde9adbee7b6aaf5d094d34cb6b64f6c77 Mon Sep 17 00:00:00 2001 From: Galen Elias Date: Wed, 21 Aug 2024 16:33:42 -0700 Subject: [PATCH 01/10] clang-format: Add "AllowShortNamespacesOnASingleLine" op

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Chris B via cfe-commits
llvm-beanz wrote: > The goal is to just have a tool that clang can use as a normal toolchain > linker so we can reuse as much as possible when it comes to creating link > jobs. Clang can use `lld`, `llvm-ar`, and `dsymutil` (among others), so being part of Clang certainly isn't necessary for

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Clang can use `lld`, `llvm-ar`, and `dsymutil` (among others), so being part > of Clang certainly isn't necessary for the clang driver to invoke it. Yes, but generally we've just stashed stuff in `clang` if we didn't plan to expose them as general utilities, since it's not lik

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Chris B via cfe-commits
llvm-beanz wrote: > I don't know if there's some existing heuristic for what clang tools do, but > generally I find it to either be something that the user interfaces in, or > something that clang uses when it's building job actions. This is the latter. Generally clang-based tools have depende

[clang] [clang][HLSL] Add GroupMemoryBarrierWithGroupSync intrinsic (PR #111883)

2024-10-15 Thread Adam Yang via cfe-commits
@@ -0,0 +1,6 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -emit-llvm-only -disable-llvm-passes -verify -verify-ignore-unexpected adam-yang wrote: It's removed now. https://github.com/llvm/llvm-project/pull/111883 __

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > Why is this a clang-based tool? Other than using clang/Basic to get the > > clang version (which could also be retrieved from LLVM), this doesn't seem > > to have any dependencies on Clang. > > As I'm seeing the SYCL patches coming in I'm getting concerned that the > > archi

[clang] clang-format: Add "AllowShortNamespacesOnASingleLine" option (PR #105597)

2024-10-15 Thread Galen Elias via cfe-commits
galenelias wrote: > I'm inclined to think that all the AllowShort options should work the same > way whether ColumnLimit is 0. However, a couple of them I checked > (AllowShortLoops and AllowShortBlocks) have no effect unless set to false. I > suggest that we mark the test as a FIXME or don't

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Generally clang-based tools have dependencies on Clang. This tool does not > (other than pulling the version number which could come from LLVM). We can move this to `llvm` if it's a blocking issue, doesn't really make much of a difference (I forget if this patch adds it to the

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Chris B via cfe-commits
llvm-beanz wrote: I'm also concerned that there are no tests for the new tool. There are tests for the clang driver changes, but none for the new tool. The new tool seems to be just a wrapper around llvm-link, which does make me think this should probably just be folded into llvm-link. Underst

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I'm also concerned that there are no tests for the new tool. There are tests > for the clang driver changes, but none for the new tool. The new tool seems > to be just a wrapper around llvm-link, which does make me think this should > probably just be folded into llvm-link. Un

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov/update_dpp (PR #112447)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-clang Author: Stanislav Mekhanoshin (rampitec) Changes We need to support 64-bit data types (intrinsics do support it). We are also silently converting FP to integer argument now, also fixed. --- Full diff: https://g

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov/update_dpp (PR #112447)

2024-10-15 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec created https://github.com/llvm/llvm-project/pull/112447 We need to support 64-bit data types (intrinsics do support it). We are also silently converting FP to integer argument now, also fixed. >From 761b3e21748dd3a7b53cd0ead745943213317eb4 Mon Sep 17 00:00:00 2001

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov/update_dpp (PR #112447)

2024-10-15 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b0a25468faca32d9db4d35e56fb120ed4eaeec09 761b3e21748dd3a7b53cd0ead745943213317eb4 --e

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-15 Thread Florian Mayer via cfe-commits
fmayer wrote: An example dump that is now possible but crashed before ![image](https://github.com/user-attachments/assets/21e4ce35-4bf2-41dd-9a65-32dedb82723a) https://github.com/llvm/llvm-project/pull/112457 ___ cfe-commits mailing list cfe-commits@l

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: Florian Mayer (fmayer) Changes We have an internal analysis that uses them, and the HTML dump would fail on the assertion. --- Full diff: https://github.com/llvm/llvm-project/pull/112457.diff 1 Files Affected: - (modified) cla

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Florian Mayer (fmayer) Changes We have an internal analysis that uses them, and the HTML dump would fail on the assertion. --- Full diff: https://github.com/llvm/llvm-project/pull/112457.diff 1 Files Affected: - (modified) clang/lib/An

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-15 Thread Florian Mayer via cfe-commits
https://github.com/fmayer created https://github.com/llvm/llvm-project/pull/112457 We have an internal analysis that uses them, and the HTML dump would fail on the assertion. >From 4264fe1dfed3fc54f339ad4a769d76158c5ee7d5 Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Tue, 15 Oct 2024 17:

[clang] [lld] [llvm] [WebAssembly] Enable nontrapping-fptoint and bulk-memory by default. (PR #112049)

2024-10-15 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin approved this pull request. This LGTM, but I guess we need to wait until Emscripten disables them by default, because there are some failing Emscripten tests and Binaryen doesn't yet have lowering passes for these. I don't think we need to block this on all these; we

[clang] [lld] [llvm] [WebAssembly] Enable nontrapping-fptoint and bulk-memory by default. (PR #112049)

2024-10-15 Thread Heejin Ahn via cfe-commits
@@ -1,4 +1,4 @@ -; RUN: llc -filetype=obj %s -o %t.o +; RUN: llc -filetype=obj -mattr=-bulk-memory %s -o %t.o aheejin wrote: Thanks for the explanation! https://github.com/llvm/llvm-project/pull/112049 ___ cfe-commits

[clang] [lld] [llvm] [WebAssembly] Enable nontrapping-fptoint and bulk-memory by default. (PR #112049)

2024-10-15 Thread Dan Gohman via cfe-commits
@@ -1,4 +1,4 @@ -; RUN: llc -filetype=obj %s -o %t.o +; RUN: llc -filetype=obj -mattr=-bulk-memory %s -o %t.o sunfishcode wrote: I've now investigated custom-section-name.ll more. With bulk-memory, we get a `__wasm_init_memory` function: ``` (module $custom-sect

[clang] [lld] [llvm] [WebAssembly] Enable nontrapping-fptoint and bulk-memory by default. (PR #112049)

2024-10-15 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode edited https://github.com/llvm/llvm-project/pull/112049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl]: Add /std:c++23preview and update _MSVC_LANG for C++23 (PR #112378)

2024-10-15 Thread Stephan T. Lavavej via cfe-commits
StephanTLavavej wrote: We can use `-Xclang -std=c++23` as a workaround, so we don't need a backport. https://github.com/llvm/llvm-project/pull/112378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-15 Thread Aaron Puchert via cfe-commits
@@ -5335,6 +5335,217 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// This function is called only if function call is not inside template body. +// TODO: Add call

[clang] [WIP][Wunsafe-buffer-usage] False positives for & expression indexing constant size array (arr[anything & 0]) (PR #112284)

2024-10-15 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/112284 >From 81af812176768eb663a09b5ccabe3c729b76 Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Fri, 11 Oct 2024 12:24:58 -0700 Subject: [PATCH] [Wunsafe-buffer-usage] False positives for & expression i

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-15 Thread via cfe-commits
higher-performance wrote: Actually @Xazax-hun looks like I don't have merge permission, would you mind clicking it (or giving me permission if that makes sense)? https://github.com/llvm/llvm-project/pull/112047 ___ cfe-commits mailing list cfe-commits

[clang] [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (PR #110327)

2024-10-15 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/110327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-15 Thread Richard Smith via cfe-commits
https://github.com/zygoloid closed https://github.com/llvm/llvm-project/pull/112047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dd47920 - Make [[clang::lifetimebound]] work for expressions coming from default arguments (#112047)

2024-10-15 Thread via cfe-commits
Author: higher-performance Date: 2024-10-15T13:41:52-07:00 New Revision: dd47920ce97e7db1ddeec34acdd9cb0ca7dcd7c4 URL: https://github.com/llvm/llvm-project/commit/dd47920ce97e7db1ddeec34acdd9cb0ca7dcd7c4 DIFF: https://github.com/llvm/llvm-project/commit/dd47920ce97e7db1ddeec34acdd9cb0ca7dcd7c4.

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-15 Thread Richard Smith via cfe-commits
https://github.com/zygoloid approved this pull request. Thanks, looks good to me too. https://github.com/llvm/llvm-project/pull/112047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3b45120 - [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (#110327)

2024-10-15 Thread via cfe-commits
Author: Helena Kotas Date: 2024-10-15T13:38:15-07:00 New Revision: 3b4512074e8d2790794a49ea675f8a4af5817e60 URL: https://github.com/llvm/llvm-project/commit/3b4512074e8d2790794a49ea675f8a4af5817e60 DIFF: https://github.com/llvm/llvm-project/commit/3b4512074e8d2790794a49ea675f8a4af5817e60.diff

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-15 Thread via cfe-commits
higher-performance wrote: Thanks all! https://github.com/llvm/llvm-project/pull/112047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add isTrivial() and isTriviallyCopyable() AST matchers (PR #90634)

2024-10-15 Thread via cfe-commits
higher-performance wrote: Thanks! I'll close this for now then. https://github.com/llvm/llvm-project/pull/90634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add isTrivial() and isTriviallyCopyable() AST matchers (PR #90634)

2024-10-15 Thread via cfe-commits
https://github.com/higher-performance closed https://github.com/llvm/llvm-project/pull/90634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Correct __builtin_dynamic_object_size for subobject types (PR #83204)

2024-10-15 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/83204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-15 Thread Justin Bogner via cfe-commits
bogner wrote: I think it's reasonable to limit this to implement things that are independently testable and leave the parts that aren't yet being used for some future change. https://github.com/llvm/llvm-project/pull/111203 ___ cfe-commits mailing li

[libunwind] [libunwind][AIX] Remove weak definition "__xlcxx_personality_v0". (PR #112436)

2024-10-15 Thread Xing Xue via cfe-commits
https://github.com/xingxue-ibm created https://github.com/llvm/llvm-project/pull/112436 `__xlcxx_personality_v0` is the personality routine in `libc++abi` for the EH of applications generated by the legacy IBM C++ compiler. Since the EH info generated by the legacy compiler does not provide th

[libunwind] [libunwind][AIX] Remove weak definition "__xlcxx_personality_v0" (PR #112436)

2024-10-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Xing Xue (xingxue-ibm) Changes `__xlcxx_personality_v0` is the personality routine in `libc++abi` for the EH of applications generated by the legacy IBM C++ compiler. Since the EH info generated by the legacy compiler does not provide

[clang] [clang-cl]: Add /std:c++23preview and update _MSVC_LANG for C++23 (PR #112378)

2024-10-15 Thread via cfe-commits
cor3ntin wrote: @StephanTLavavej @CaseyCarter What is your timetable? I'm wondering whether we should do any back port effort (otherwise it will land in Clang 20 in ~february) https://github.com/llvm/llvm-project/pull/112378 ___ cfe-commits mailing li

<    1   2   3   4   5   6   >