[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vla-2stage` running on `linaro-g3-02` while building `clang,compiler-rt` at step 6 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/41/builds/2691 Here is the releva

[clang] [compiler-rt] [XRay] Fix LLVM include in xray_interface.cpp (PR #111978)

2024-10-11 Thread Sebastian Kreutzer via cfe-commits
https://github.com/sebastiankreutzer created https://github.com/llvm/llvm-project/pull/111978 Removes a dependency on LLVM in `xray_interface.cpp` by replacing `llvm_unreachable` with compiler-rt's `UNREACHABLE`. Applies clang-format to some unformatted changes. Original PR: #90959 >From e5

[clang] [compiler-rt] [XRay] Fix LLVM include in xray_interface.cpp (PR #111978)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Sebastian Kreutzer (sebastiankreutzer) Changes Removes a dependency on LLVM in `xray_interface.cpp` by replacing `llvm_unreachable` with compiler-rt's `UNREACHABLE`. Applies clang-format to some unformatted changes. Original PR: #

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-clang` running on `bolt-worker` while building `clang,compiler-rt` at step 6 "test-build-clang-bolt-stage2-clang-bolt". Full details are available at: https://lab.llvm.org/buildbot/#/builders/113/builds/332

[clang] [llvm] [clang][RISCV] Introduce CodeGenModule::calcRISCVZicfilpFuncSigLabel() (PR #111661)

2024-10-11 Thread Ming-Yi Lai via cfe-commits
https://github.com/mylai-mtk updated https://github.com/llvm/llvm-project/pull/111661 >From 9041af3df59b6f6f2f6c2ff335cc697dfd41ac73 Mon Sep 17 00:00:00 2001 From: Ming-Yi Lai Date: Fri, 31 May 2024 17:03:04 +0800 Subject: [PATCH] [clang][RISCV] Emit RISCV function-signature-based CFI label in

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang,llvm,mlir,polly` at step 5 "compile-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/8067 Here is the

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-sles-build-only` running on `rocm-worker-hw-04-sles` while building `clang,llvm,mlir,polly` at step 5 "compile-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/8577

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Rahul Joshi via cfe-commits
jurahul wrote: Fix for build break available here: https://github.com/llvm/llvm-project/pull/111990 https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [Clang] Replace Intrinsic::getDeclaration with getOrInsertDeclaration (PR #111990)

2024-10-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/111990 Fix build failure from the rename change. Looks like one additional reference sneaked in between pre-commit checks and the commit itself. >From 0f71249d70bc5f1505bd4b0145c8e361494e435d Mon Sep 17 00:00:00 2001

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-11 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb updated https://github.com/llvm/llvm-project/pull/111701 >From 1a63281b6c240352653fd2e4299755c1f32a76f4 Mon Sep 17 00:00:00 2001 From: bricknerb Date: Wed, 9 Oct 2024 15:05:34 + Subject: [PATCH 1/2] [clang] Fix segmentation fault caused by stack overflow on dee

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang,llvm,mlir,polly` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/7483 Here is th

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-11 Thread Boaz Brickner via cfe-commits
@@ -5817,7 +5817,10 @@ LValue CodeGenFunction::EmitHLSLArrayAssignLValue(const BinaryOperator *E) { LValue CodeGenFunction::EmitCallExprLValue(const CallExpr *E, llvm::CallBase **CallOrInvoke) { - RValue RV = EmitCallExpr(E, ReturnV

[clang] [clang] Ignore inline namespace for `hasName` (PR #109147)

2024-10-11 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource updated https://github.com/llvm/llvm-project/pull/109147 From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?= Date: Mon, 24 Jul 2023 13:56:29 +0200 Subject: [PATCH 1/8] [

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-11 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin created https://github.com/llvm/llvm-project/pull/111992 Summary: Fix crash from reproducer provided in https://github.com/llvm/llvm-project/pull/109167#issuecomment-2405289565 Test Plan: TBD (need to further reduce the reproducer) >From 0d02e79ced894769cfbea45a1

[clang] [clang] Ignore inline namespace for `hasName` (PR #109147)

2024-10-11 Thread Alejandro Álvarez Ayllón via cfe-commits
@@ -141,10 +143,11 @@ struct PrintingPolicy { unsigned SuppressUnwrittenScope : 1; /// Suppress printing parts of scope specifiers that correspond - /// to inline namespaces, where the name is unambiguous with the specifier + /// to inline namespaces. + /// If Redudant,

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ve-ninja` running on `hpce-ve-main` while building `clang,llvm,mlir,polly` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/12/builds/7556 Here is the relevant piece of the

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] Clang: Support minimumnum and maximumnum intrinsics (PR #96281)

2024-10-11 Thread YunQiang Su via cfe-commits
@@ -15314,6 +15314,32 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr *E) { Result = RHS; wzssyqa wrote: I have no idea. I will try to fixed in future patches. https://github.com/llvm/llvm-project/issues/111991 https://github.com/llvm/llvm-proje

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-fuzzer` running on `sanitizer-buildbot12` while building `clang,llvm,mlir,polly` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/159/builds/7994 Here is

[clang] [clang] Ignore inline namespace for `hasName` (PR #109147)

2024-10-11 Thread Alejandro Álvarez Ayllón via cfe-commits
alejandro-alvarez-sonarsource wrote: > Do you need someone to commit these changes for you? (If so, I can apply the > changes myself and land them.) Yes, please, I can't merge myself. https://github.com/llvm/llvm-project/pull/109147 ___ cfe-commits m

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `libc-x86_64-debian-dbg-runtimes-build` running on `libc-x86_64-debian` while building `clang,llvm,mlir,polly` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/78/builds/7640 Here

[clang] [Clang] Replace Intrinsic::getDeclaration with getOrInsertDeclaration (PR #111990)

2024-10-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/111990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c8da225 - [Clang] Replace Intrinsic::getDeclaration with getOrInsertDeclaration (#111990)

2024-10-11 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-10-11T05:45:09-07:00 New Revision: c8da2253f9aa4dff039e9ed766ff0f865632a0eb URL: https://github.com/llvm/llvm-project/commit/c8da2253f9aa4dff039e9ed766ff0f865632a0eb DIFF: https://github.com/llvm/llvm-project/commit/c8da2253f9aa4dff039e9ed766ff0f865632a0eb.diff L

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-aarch64-out-of-tree` running on `linaro-flang-aarch64-out-of-tree` while building `clang,llvm,mlir,polly` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/53/builds

[clang] [C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #109167)

2024-10-11 Thread Dmitry Polukhin via cfe-commits
dmpolukhin wrote: > Here is the reproducer that crashes at head. > [lambdas.tgz](https://github.com/user-attachments/files/17329901/lambdas.tgz) I reproduced this issue on my machine and confirm that it is indeed due to my changes. https://github.com/llvm/llvm-project/pull/111992 has fix that

[clang] [Clang] Replace Intrinsic::getDeclaration with getOrInsertDeclaration (PR #111990)

2024-10-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/111990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d905a3c51b31775791c15132a1b3613d75871853 d49f8037b4a9022aecece21a4073773fb65fa5c0 --e

[clang] [Clang] Replace Intrinsic::getDeclaration with getOrInsertDeclaration (PR #111990)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Rahul Joshi (jurahul) Changes Fix build failure from the rename change. Looks like one additional reference sneaked in between pre-commit checks and the commit itself. --- Full diff: https://github.com/llvm/llvm-project/pull/11199

[clang] [Clang] Replace Intrinsic::getDeclaration with getOrInsertDeclaration (PR #111990)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Fix build failure from the rename change. Looks like one additional reference sneaked in between pre-commit checks and the commit itself. --- Full diff: https://github.com/llvm/llvm-project/pull/111990.diff

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang,llvm,mlir,polly` at step 6 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/11581 Here i

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] efcfa6e - Revert "Reland: [clang] Finish implementation of P0522 (#111711)"

2024-10-11 Thread Mikhail Goncharov via cfe-commits
Author: Mikhail Goncharov Date: 2024-10-11T14:47:38+02:00 New Revision: efcfa6e711689ada546c323316145ecd749d380a URL: https://github.com/llvm/llvm-project/commit/efcfa6e711689ada546c323316145ecd749d380a DIFF: https://github.com/llvm/llvm-project/commit/efcfa6e711689ada546c323316145ecd749d380a.d

[clang] bdd46cc - Revert "[clang] CWG2398: improve overload resolution backwards compat (#107350)"

2024-10-11 Thread Mikhail Goncharov via cfe-commits
Author: Mikhail Goncharov Date: 2024-10-11T14:47:21+02:00 New Revision: bdd46cc6b74eeed14936f1373bbb6446e09979fe URL: https://github.com/llvm/llvm-project/commit/bdd46cc6b74eeed14936f1373bbb6446e09979fe DIFF: https://github.com/llvm/llvm-project/commit/bdd46cc6b74eeed14936f1373bbb6446e09979fe.d

[clang] ed7251b - Revert "[clang] Implement TTP P0522 pack matching for deduced function template calls. (#111457)"

2024-10-11 Thread Mikhail Goncharov via cfe-commits
Author: Mikhail Goncharov Date: 2024-10-11T14:46:46+02:00 New Revision: ed7251b3aeb7c471dc50e9409e83a9ec01f40df5 URL: https://github.com/llvm/llvm-project/commit/ed7251b3aeb7c471dc50e9409e83a9ec01f40df5 DIFF: https://github.com/llvm/llvm-project/commit/ed7251b3aeb7c471dc50e9409e83a9ec01f40df5.d

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > @abhina-sree do you plan to modify embed in this PR? Actually Sean has pointed out that if we pass in non-ascii inputs, the tests do in fact fail. So I will look into passing the IsText parameter in the necessary functions. Thanks for pointing this out! https://github.com

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Rahul Joshi via cfe-commits
jurahul wrote: Fix for build break is now committed. https://github.com/llvm/llvm-project/commit/c8da2253f9aa4dff039e9ed766ff0f865632a0eb https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] Clang: Support minimumnum and maximumnum intrinsics (PR #96281)

2024-10-11 Thread YunQiang Su via cfe-commits
wzssyqa wrote: > > Can you add a test that passes a non-float value and checks that it's > > rejected? > > Do you mean something like this? > > ``` > $ cat xx.c > #include > > float f(char *a, char *b) { > return fminimum_num(a, b); > } > $ ./bin/clang -std=c23 -O2 -S -emit-llvm xx.

[clang] Clang: Support minimumnum and maximumnum intrinsics (PR #96281)

2024-10-11 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa updated https://github.com/llvm/llvm-project/pull/96281 >From c08b0a8d34107dc4563c434485ba5f326ab8df93 Mon Sep 17 00:00:00 2001 From: YunQiang Su Date: Fri, 21 Jun 2024 14:28:42 +0800 Subject: [PATCH 01/10] Clang: Support minimumnum and maximumnum intrinsics We just

[clang] Clang: Support minimumnum and maximumnum intrinsics (PR #96281)

2024-10-11 Thread Timm Baeder via cfe-commits
@@ -15314,6 +15314,32 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr *E) { Result = RHS; return true; } + + case Builtin::BI__builtin_fmaximum_num: + case Builtin::BI__builtin_fmaximum_numf: + case Builtin::BI__builtin_fmaximum_numl: + case Builtin::B

[clang] Clang: Support minimumnum and maximumnum intrinsics (PR #96281)

2024-10-11 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa updated https://github.com/llvm/llvm-project/pull/96281 >From c08b0a8d34107dc4563c434485ba5f326ab8df93 Mon Sep 17 00:00:00 2001 From: YunQiang Su Date: Fri, 21 Jun 2024 14:28:42 +0800 Subject: [PATCH 1/9] Clang: Support minimumnum and maximumnum intrinsics We just in

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `clang,llvm,mlir,polly` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/9650 Here is the rel

[clang] [clang] When checking for covariant return types, make sure the pointers or references are to *classes* (PR #111856)

2024-10-11 Thread Boaz Brickner via cfe-commits
@@ -289,3 +289,13 @@ namespace PR8168 { static void foo() {} // expected-error{{'static' member function 'foo' overrides a virtual function}} }; } + +namespace T13 { + struct A { +virtual const int *f() const; // expected-note{{overridden virtual function is here}}

[clang] [OpenACC] Implement loop 'gang' clause. (PR #112006)

2024-10-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/112006 The 'gang' clause is used to specify parallel execution of loops, thus has some complicated rules depending on the 'loop's associated compute construct. This patch implements all of those. >From 8d6dd131cc

[clang] [OpenACC] Implement loop 'gang' clause. (PR #112006)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Erich Keane (erichkeane) Changes The 'gang' clause is used to specify parallel execution of loops, thus has some complicated rules depending on the 'loop's associated compute construct. This patch implements all of those. --- P

[clang] [OpenACC] Implement loop 'gang' clause. (PR #112006)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes The 'gang' clause is used to specify parallel execution of loops, thus has some complicated rules depending on the 'loop's associated compute construct. This patch implements all of those. --- Patch is

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-11 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/109165 >From 6ff1fcb6dcd55b1d77dacc8b6d117176033038c0 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Wed, 18 Sep 2024 09:49:26 -0600 Subject: [PATCH 1/5] [clang][flang] Support -time in both clang and flang The

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-11 Thread Tarun Prabhu via cfe-commits
@@ -0,0 +1,24 @@ +// The -time option prints timing information for the various subcommands in a +// format similar to that used by gcc. When compiling and linking, this will +// include the time to call clang-${LLVM_VERSION_MAJOR} and the linker. Since +// the name of the linker

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `bolt-aarch64-ubuntu-clang` running on `bolt-worker-aarch64` while building `clang,compiler-rt` at step 6 "test-build-clang-bolt-stage2-clang-bolt". Full details are available at: https://lab.llvm.org/buildbot/#/builders/128/b

[clang] [llvm] [RISCV] Add support for inline asm constraint vd (PR #111653)

2024-10-11 Thread Craig Topper via cfe-commits
https://github.com/topperc requested changes to this pull request. https://github.com/llvm/llvm-project/pull/111653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add support for inline asm constraint vd (PR #111653)

2024-10-11 Thread Craig Topper via cfe-commits
@@ -102,7 +102,7 @@ bool RISCVTargetInfo::validateAsmConstraint( return true; case 'v': // A vector register. -if (Name[1] == 'r' || Name[1] == 'm') { +if (Name[1] == 'r' || Name[1] == 'd' || Name[1] == 'm') { topperc wrote: This needs to be

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-11 Thread Dmitry Polukhin via cfe-commits
@@ -10057,15 +10057,18 @@ void ASTReader::finishPendingActions() { // For a function defined inline within a class template, force the // canonical definition to be the one inside the canonical definition of // the template. This ensures that we instantiate fr

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-11 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin ready_for_review https://github.com/llvm/llvm-project/pull/111992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: Dmitry Polukhin (dmpolukhin) Changes Summary: Fix crash from reproducer provided in https://github.com/llvm/llvm-project/pull/109167#issuecomment-2405289565 Test Plan: TBD (need to further reduce the rep

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Daniel Chen via cfe-commits
DanielCChen wrote: > `test_demangle` should definitely **not** be updated when renaming functions. Could you please explain a bit more since this is new to me? Thanks in advance! https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Nikita Popov via cfe-commits
nikic wrote: > > `test_demangle` should definitely **not** be updated when renaming > > functions. > > Could you please explain a bit more since this is new to me? Thanks in > advance! The use of LLVM symbols in this file is incidental -- it's just a data set of mangled C++ symbol names. The

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Daniel Chen via cfe-commits
DanielCChen wrote: > > > `test_demangle` should definitely **not** be updated when renaming > > > functions. > > > > > > Could you please explain a bit more since this is new to me? Thanks in > > advance! > > The use of LLVM symbols in this file is incidental -- it's just a data set of > ma

[clang] Add isTrivial() and isTriviallyCopyable() AST matchers (PR #90634)

2024-10-11 Thread via cfe-commits
higher-performance wrote: @AaronBallman that makes sense, thanks! For `isTrivial`, I do see it is used in two places, but they're not fully compatible (one operates on `QualType`, and neither works on methods): - https://github.com/llvm/llvm-project/blob/ebe77cc320a1bcc8e2cec44f4f388fb43b7201

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-10-11 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov created https://github.com/llvm/llvm-project/pull/112015 Currently, any FileID that references a module map file that was required for a compilation is considered as affecting. This misses an important opportunity to reduce the source location space taken by th

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ilya Biryukov (ilya-biryukov) Changes Currently, any FileID that references a module map file that was required for a compilation is considered as affecting. This misses an important opportunity to reduce the source location space taken b

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-11 Thread Louis Dionne via cfe-commits
ldionne wrote: If other folks get here because of an error like `multiple rules generate lib/SOMETHING.a`, this is the issue (from https://github.com/llvm/llvm-project/pull/80007#issuecomment-2402188675): > > The fix for this is: > > ``` > # On embedded platforms that don't support shared li

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-10-11 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: This is a change that should remove the need for a hack from #88893, reaching the same effect while keeping the command-line interface as it is today. https://github.com/llvm/llvm-project/pull/112015 ___ cfe-commits mailing list

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Nikita Popov via cfe-commits
nikic wrote: `test_demangle` should definitely **not** be updated when renaming functions. https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110435 >From c52634882631a71fad956a70179b480abf13006a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 29 Sep 2024 22:01:38 +0300 Subject: [PATCH 1/3] [Clang] fix overload resolution for object parameters with

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/112025 Summary: The C library for GPUs provides the ability to target regular C/C++ programs by providing the C library and a file containing kernels that call the `main` function. This is mostly used for unit tests, th

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: The C library for GPUs provides the ability to target regular C/C++ programs by providing the C library and a file containing kernels that call the `main` function. This is mostly used for unit tests,

[clang] bc53359 - Update the C status page with papers adopted in Minneapolis

2024-10-11 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-10-11T14:45:47-04:00 New Revision: bc53359b92e0fa3e1cf70505e1f2399f07c850d5 URL: https://github.com/llvm/llvm-project/commit/bc53359b92e0fa3e1cf70505e1f2399f07c850d5 DIFF: https://github.com/llvm/llvm-project/commit/bc53359b92e0fa3e1cf70505e1f2399f07c850d5.diff

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-10-11 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: Right, that's what I meant by "Is it trying to set it too early before the VFS is created or something?". We could make the driver setup the VFS like the frontend would and do that before checking the -working-directory; not sure if there's a reason we don't do that already

[clang] [C2y] Add test coverage for N3298 (PR #112033)

2024-10-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/112033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/112041 Summary: We currently use `llvm-mc` which is intended for internal testing and not expected to be present in every installation. This patch changes that to just use clang instead to get the `.o` from the HIP regi

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: We currently use `llvm-mc` which is intended for internal testing and not expected to be present in every installation. This patch changes that to just use clang inst

[clang] [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (PR #110327)

2024-10-11 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/110327 >From 4f235c0e9c539cdaa2bab9a7f8228f33c0fea2b8 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Thu, 26 Sep 2024 14:34:16 -0700 Subject: [PATCH 1/9] Add codegen for existing resource types and make HLSLAttribut

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 67160c5ab5f5b7fd5fa7851abcfde367c8a9f91b 84a8f05136c71a4fbc00062ffe1d33575336cbdc --e

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-10-11 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/106146 >From 40224473a7b43bc4ffe2024ab51196c2130bedc7 Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Sun, 25 Aug 2024 12:00:03 -0600 Subject: [PATCH 1/5] [DirectX] Remove trivially dead functions at linkage finalize

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-10-11 Thread Greg Roth via cfe-commits
@@ -0,0 +1,222 @@ +; RUN: opt -S -dxil-finalize-linkage -mtriple=dxil-unknown-shadermodel6.5-compute %s | FileCheck %s +; RUN: llc %s --filetype=asm -o - | FileCheck %s pow2clk wrote: Done! https://github.com/llvm/llvm-project/pull/106146 __

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-10-11 Thread Helena Kotas via cfe-commits
@@ -0,0 +1,222 @@ +; RUN: opt -S -dxil-finalize-linkage -mtriple=dxil-unknown-shadermodel6.5-compute %s | FileCheck %s +; RUN: llc %s --filetype=asm -o - | FileCheck %s hekota wrote: Shouldn't the exported functions stay in the module when it is compiled as a l

[clang-tools-extra] [clang-tidy] Make `P +- BS / sizeof(*P)` opt-outable in `bugprone-sizeof-expression` (PR #111178)

2024-10-11 Thread Julian Schmidt via cfe-commits
@@ -352,21 +352,30 @@ void good13(void) { int Buffer[BufferSize]; int *P = &Buffer[0]; - while (P < (Buffer + sizeof(Buffer) / sizeof(int))) { + while (P < Buffer + sizeof(Buffer) / sizeof(int)) { // NO-WARNING: Calculating the element count of the buffer here, whic

[clang] [clang-format] Stop crashing when formatting Verilog (PR #112043)

2024-10-11 Thread via cfe-commits
https://github.com/sstwcw created https://github.com/llvm/llvm-project/pull/112043 The part of the code for parsing Verilog module instantiations dereferenced a pointer without checking for null pointer. The pointer may be null if the input is not complete and a line starts with a comma. >Fr

[clang-tools-extra] [clang-tidy] Make `P +- BS / sizeof(*P)` opt-outable in `bugprone-sizeof-expression` (PR #111178)

2024-10-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: Basically LGTM, but the name `WarnOnArithmeticWithDivisionBySizeOf` would imply that ```c++ (Buffer - Buffer) / sizeof(*Buffer); ``` would be ignored as well when the flag is `false`. Please add something in the documentation about this. The option could a

[clang-tools-extra] [clang-tidy] Make `P +- BS / sizeof(*P)` opt-outable in `bugprone-sizeof-expression` (PR #111178)

2024-10-11 Thread Julian Schmidt via cfe-commits
@@ -221,6 +221,17 @@ and the result is typically unintended, often out of bounds. ``Ptr + sizeof(T)`` will offset the pointer by ``sizeof(T)`` elements, effectively exponentiating the scaling factor to the power of 2. +Similarly, multiplying or dividing a numeric value with t

[clang-tools-extra] [clang-tidy] Make `P +- BS / sizeof(*P)` opt-outable in `bugprone-sizeof-expression` (PR #111178)

2024-10-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/78 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Stop crashing when formatting Verilog (PR #112043)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: None (sstwcw) Changes The part of the code for parsing Verilog module instantiations dereferenced a pointer without checking for null pointer. The pointer may be null if the input is not complete and a line starts with a comma. -

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-11 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @cor3ntin @erichkeane If no further review is needed, could you merge the PR? I don’t have access. Thanks! https://github.com/llvm/llvm-project/pull/110435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Add support for two ends_with patterns (PR #110448)

2024-10-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM (got ideas on writing a small part of the matchers differently for an NFC I'll do afterward) https://github.com/llvm/llvm-project/pull/110448 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [clang-format] clang-format-ignore: Add support for double asterisk patterns (PR #110560)

2024-10-11 Thread Ameer J via cfe-commits
ameerj wrote: @mydeveloperday @owenca bump for review feedback https://github.com/llvm/llvm-project/pull/110560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-11 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/111434 >From df4552469da6186141520b68da65c894ff8966a7 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Mon, 7 Oct 2024 15:30:24 +0200 Subject: [PATCH 1/4] [clang] Warn about memset/memcpy to NonTriviall

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: for such a wide-reaching change, it would have been nice to add the new function in one commit, update users in other commits, then remove the old function in one last commit. makes it easier to revert the removal of the old function, and makes it easier for out of tree users t

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-11 Thread via cfe-commits
https://github.com/higher-performance created https://github.com/llvm/llvm-project/pull/112047 This is an attempt to fix #68596. I'm very unfamiliar with this code, so it is very likely that I have made mistakes or overlooked a lot of things, especially things that might introduce unintended

[clang] [llvm] [MTE] Apply alignment / size in AsmPrinter rather than IR (PR #111918)

2024-10-11 Thread Florian Mayer via cfe-commits
https://github.com/fmayer updated https://github.com/llvm/llvm-project/pull/111918 >From 3a962270521aa7b48b64e5ac5fa0edb900990023 Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Thu, 10 Oct 2024 16:05:50 -0700 Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UT

[clang] [-Wunsafe-buffer-usage] Emit a warning if pointer returned by vector::data and array::data is cast to larger type (PR #111910)

2024-10-11 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/111910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (higher-performance) Changes This is an attempt to fix #68596. I'm very unfamiliar with this code, so it is very likely that I have made mistakes or overlooked a lot of things, especially things that might introduce unintended false

[clang] Make [[clang::lifetimebound]] work for expressions coming from default arguments (PR #112047)

2024-10-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a6438360d416f4529574eebf6aa65b80d48ef85e 50d036893494f53d22b1c968d48f952d25281605 --e

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-10-11 Thread Neil Henning via cfe-commits
sheredom wrote: Ok already need some advice after hacking! - `-working-directory` is only used by the **non** `-cc1` clang driver path. - But the VFS is only initialized way deep once you are in the `-cc1` path. - The problem is that just after `-working-directory` is set, we then use it to que

[clang] [C2y] Add test coverage for N3298 (PR #112033)

2024-10-11 Thread Erich Keane via cfe-commits
@@ -57,7 +57,7 @@ void test4(void) { var =+5; // no warning when the subexpr of the unary op has no space before it. var =-5; - erichkeane wrote: Handful of WS changes in this file, though not sure I care enough to have you change this. http

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112041 >From 9de8a92c3bcda9d1fa414b9b355cb8ac77ae0812 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 14:53:17 -0500 Subject: [PATCH] [HIP] Replace use of `llvm-mc` with `clang` Summary: We currentl

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-10-11 Thread Neil Henning via cfe-commits
sheredom wrote: > Right, that's what I meant by "Is it trying to set it too early before the > VFS is created or something?". We could make the driver setup the VFS like > the frontend would and do that before checking the -working-directory; not > sure if there's a reason we don't do that alr

[clang] [llvm] [RISCV] Add support for inline asm constraint vd (PR #111653)

2024-10-11 Thread Craig Topper via cfe-commits
@@ -29,6 +29,14 @@ vint32m1_t test_vr(vint32m1_t a, vint32m1_t b) { return ret; } +vint32m1_t test_vd(vint32m1_t a, vint32m1_t b) { +// CHECK-LABEL: define{{.*}} @test_vd +// CHECK: %0 = tail call asm sideeffect "vadd.vv $0, $1, $2", "=^vd,^vd,^vd"( %a, %b) + vint32m1_t

[clang] [llvm] [RISCV] Add support for inline asm constraint vd (PR #111653)

2024-10-11 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add support for inline asm constraint vd (PR #111653)

2024-10-11 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/111653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Enable nontrapping-fptoint and bulk-memory by default. (PR #112049)

2024-10-11 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode created https://github.com/llvm/llvm-project/pull/112049 We were prepared to enable these features [back in February], but they got pulled for what appear to be unrelated reasons. So let's have another try at enabling them! Another motivation here is that it'd b

<    1   2   3   4   5   6   >