[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-10-08 Thread Tor Shepherd via cfe-commits
torshepherd wrote: Ping https://github.com/llvm/llvm-project/pull/95712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,546 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,546 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic (PR #111576)

2024-10-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/111576 >From 167718e352554e167c4690a4962234ba782bceff Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Tue, 8 Oct 2024 09:28:43 -0700 Subject: [PATCH] [HLSL][DXIL] Implement WaveGetLaneIndex - add additional lowe

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,546 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread Paul Kirth via cfe-commits
@@ -39,20 +41,27 @@ class Token { Comment, }; - Token(std::string Str); + Token(StringRef Str); - Token(std::string Str, char Identifier); + Token(StringRef RawBody, StringRef Str, char Identifier); - std::string getTokenBody() const { return TokenBody; }; + St

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,546 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,546 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,546 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,190 @@ +//===--- Mustache.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,546 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-08 Thread via cfe-commits
serge-sans-paille wrote: cc @ldionne got the compiler-rt part. https://github.com/llvm/llvm-project/pull/111434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread Erich Keane via cfe-commits
@@ -4453,9 +4453,9 @@ class Sema final : public SemaBase { SourceLocation *ArgLocation = nullptr); /// Determine if type T is a valid subject for a nonnull and similar - /// attributes. By default, we look through references (the behavi

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-08 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm updated https://github.com/llvm/llvm-project/pull/109837 >From 07a2cab3fa5df2965f9f7da9ee2d3603581a47f1 Mon Sep 17 00:00:00 2001 From: wlei Date: Sun, 22 Sep 2024 20:23:20 -0700 Subject: [PATCH 1/4] [InstrPGO] Instrument sampling profile based cold function --- c

[clang] [ItaniumCXXABI] Mark RTTI type name as global unnamed_addr (PR #111343)

2024-10-08 Thread Richard Smith via cfe-commits
zygoloid wrote: > But, I have a question: now that it has ensured the uniqueness of typeinfo's > address, why does the implementation still compare the type equality by the > address of type name string? The uniqueness of the address of the `type_info` object itself is not guaranteed. The rea

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-08 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/111561 >From da01bdac8a99a127a74073df4a505bdc936291e2 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 8 Oct 2024 12:54:26 -0400 Subject: [PATCH 1/2] [Clang][Sema] Fix exception specification comparison

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/111573 Fix `assume_aligned` incorrectly diagnoses a dependent return type Fixes: #111563 >From fd3247ecb2fb2c83e8441d082a446c85e6268146 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread via cfe-commits
@@ -0,0 +1,489 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread Amr Hesham via cfe-commits
@@ -1216,6 +1216,8 @@ static void handlePreferredName(Sema &S, Decl *D, const ParsedAttr &AL) { } bool Sema::isValidPointerAttrType(QualType T, bool RefOkay) { + if (T->isDependentType()) AmrDeveloper wrote: Done, please check the updated documentation of t

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From 4202153623dd64cec76b6ca9a08191ff884327a7 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-08 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,67 @@ +//===-- clang/Support/Compiler.h - Compiler abstraction support -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang] Add test for CWG110 "Can template functions and classes be declared in the same scope?" (PR #111446)

2024-10-08 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/7857 Here is the relevan

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/108276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-08 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,67 @@ +//===-- clang/Support/Compiler.h - Compiler abstraction support -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. The changes LGTM with some minor changes to the comments. I did have a question, but I don't think it holds up landing the changes. https://github.com/llvm/llvm-project/pull/108276 ___ cfe-co

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-08 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,67 @@ +//===-- clang/Support/Compiler.h - Compiler abstraction support -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Add support for aligning BlockComments in declarations (PR #109497)

2024-10-08 Thread via cfe-commits
https://github.com/JessehMSFT updated https://github.com/llvm/llvm-project/pull/109497 >From 38333491868dfad9c84719d9dd8fd872a2aa7584 Mon Sep 17 00:00:00 2001 From: Jesse Harvey Date: Fri, 20 Sep 2024 16:40:35 -0700 Subject: [PATCH 1/3] Add support for aligning BlockComments in declarations --

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-08 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,67 @@ +//===-- clang/Support/Compiler.h - Compiler abstraction support -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang] Allow `ConditionalOperator` fast-math flags to be overridden by `pragma float_control` (PR #105912)

2024-10-08 Thread John McCall via cfe-commits
rjmccall wrote: I don't understand what fast-math flags are supposed to mean for loads, phis, and selects. These are not arithmetic operations; they just propagate values. If you're trying to implement some kind of rule where fast-math analysis should not pass across certain kinds of abstrac

[clang] [clang-tools-extra] RFC: [clang-tidy] [analyzer] Move nondeterministic pointer usage check to tidy (PR #110471)

2024-10-08 Thread Julian Schmidt via cfe-commits
5chmidti wrote: > I'd like to keep the scope limited for this PR to just moving the static > analysis checks to a single clang-tidy check. Would that be ok with the > reviewers? Fine with me, yes, but there needs to be some sort of plan on how to address some of the pointed out challenges wit

[clang] Fix out-of-bounds access to std::unique_ptr (PR #111581)

2024-10-08 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh created https://github.com/llvm/llvm-project/pull/111581 This manifested as an assertion failure in Clang built against libc++ with hardening enabled (e.g. -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG): `libcxx/include/__memory/unique_ptr.h:596: assertion __c

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-08 Thread Louis Dionne via cfe-commits
ldionne wrote: I had to fix how we were excluding targets from `EXCLUDE_FROM_ALL`, which didn't work as intended and was breaking the MinGW CI. I'll merge this if the CI passes. https://github.com/llvm/llvm-project/pull/80007 ___ cfe-commits mailing

[clang] Fix out-of-bounds access to std::unique_ptr (PR #111581)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexander Kornienko (alexfh) Changes This manifested as an assertion failure in Clang built against libc++ with hardening enabled (e.g. -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG): `libcxx/include/__memory/unique_ptr.h:596: asse

[clang] [clang-tools-extra] [Clang][Sema] Don't set instantiated from function when rewriting operator<=> (PR #91339)

2024-10-08 Thread Shafik Yaghmour via cfe-commits
shafik wrote: This regression: https://github.com/llvm/llvm-project/issues/104720 seems to be linked to this change. https://github.com/llvm/llvm-project/pull/91339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-08 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/80007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-08 Thread via cfe-commits
Sirraide wrote: ping https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved readability redundant casting with enums (PR #111424)

2024-10-08 Thread Julian Schmidt via cfe-commits
5chmidti wrote: > Fixed false negatives with readability-redundant-casting when the underlying > types are the same and the option IgnoreTypeAliases is set to true. To me, > Fixed false negatives with readability-redundant-casting when casting an enum > to its underlying type and the option I

[clang] [clang] Allow `ConditionalOperator` fast-math flags to be overridden by `pragma float_control` (PR #105912)

2024-10-08 Thread John McCall via cfe-commits
rjmccall wrote: Oh, that's interesting. I'd been assuming this was a cross-function issue or something like that, but that's a great example of where we need more than that. I agree that it feels like having some kind of barrier instruction is the right way to go — basically a unary operator

[clang] [llvm] Thin3 (PR #108614)

2024-10-08 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/108614 >From 1cac61d42d7965a095aba3b47cca1f5e3c27fd82 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 13 Sep 2024 08:51:00 -0700 Subject: [PATCH 1/4] [CGData][ThinLTO] Global Outlining with Two-CodeGen Round

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From 036f76530beca7f6fddae1460a5fd527a71bcf94 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes Fix `assume_aligned` incorrectly diagnoses a dependent return type Fixes: #111563 --- Full diff: https://github.com/llvm/llvm-project/pull/111573.diff 2 Files Affected: - (modified) clang/lib/Sema/Sema

[clang] [clang-tools-extra] [flang] [lld] [lldb] [llvm] [NFC] Rename Option parsing related files from OptXYZ -> OptionXYZ (PR #110692)

2024-10-08 Thread David Blaikie via cfe-commits
dwblaikie wrote: Yeah, I think given how wide the change is and the speculative nature of the harm - probably best to abandon this for now. We can pick it up again if more folks speak up/more evidence is presented that it's problematic. https://github.com/llvm/llvm-project/pull/110692

[clang] Add support for aligning BlockComments in declarations (PR #109497)

2024-10-08 Thread via cfe-commits
https://github.com/JessehMSFT updated https://github.com/llvm/llvm-project/pull/109497 >From 38333491868dfad9c84719d9dd8fd872a2aa7584 Mon Sep 17 00:00:00 2001 From: Jesse Harvey Date: Fri, 20 Sep 2024 16:40:35 -0700 Subject: [PATCH 1/3] Add support for aligning BlockComments in declarations --

[clang] [llvm] [HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic (PR #111576)

2024-10-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/111576 >From 167718e352554e167c4690a4962234ba782bceff Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Tue, 8 Oct 2024 09:28:43 -0700 Subject: [PATCH 1/2] [HLSL][DXIL] Implement WaveGetLaneIndex - add additional

[clang] [clang-tools-extra] [clang-tidy] bugprone-implicit-widening ignores unsigned consts (PR #101073)

2024-10-08 Thread Chris Warner via cfe-commits
cwarner-8702 wrote: Ping https://github.com/llvm/llvm-project/pull/101073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/AMDGPU: Stop emitting amdgpu-unsafe-fp-atomics attribute (PR #111579)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) Changes This has been replaced with metadata on individual atomicrmw instructions. --- Full diff: https://github.com/llvm/llvm-project/pull/111579.diff 3 Files Affected: - (modified) clang/lib/CodeGen/Ta

[clang] clang/AMDGPU: Stop emitting amdgpu-unsafe-fp-atomics attribute (PR #111579)

2024-10-08 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/111579 This has been replaced with metadata on individual atomicrmw instructions. >From be077b9947546b5d6a87be7c57d44b57ff6efb5f Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Thu, 27 Jun 2024 13:46:35 +0200 Subje

[clang] clang/AMDGPU: Stop emitting amdgpu-unsafe-fp-atomics attribute (PR #111579)

2024-10-08 Thread Matt Arsenault via cfe-commits
arsenm wrote: * **#111579** https://app.graphite.dev/github/pr/llvm/llvm-project/111579?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 * `main` This stack of pull requests is managed by Graphi

[clang] clang/AMDGPU: Stop emitting amdgpu-unsafe-fp-atomics attribute (PR #111579)

2024-10-08 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/111579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Track function template instantiation from definition (PR #110387)

2024-10-08 Thread Matheus Izvekov via cfe-commits
@@ -1008,6 +1008,15 @@ class FunctionTemplateDecl : public RedeclarableTemplateDecl { return getTemplatedDecl()->isThisDeclarationADefinition(); } + bool isCompatibleWithDefinition() const { +return getTemplatedDecl()->isInstantiatedFromMemberTemplate() || +

[clang] [clang] Track function template instantiation from definition (PR #110387)

2024-10-08 Thread Younan Zhang via cfe-commits
@@ -1008,6 +1008,15 @@ class FunctionTemplateDecl : public RedeclarableTemplateDecl { return getTemplatedDecl()->isThisDeclarationADefinition(); } + bool isCompatibleWithDefinition() const { +return getTemplatedDecl()->isInstantiatedFromMemberTemplate() || +

[clang-tools-extra] [clangd] Harden incomingCalls() against possible misinterpretation of a range as pertaining to the wrong file (PR #111616)

2024-10-08 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/111616 I don't have a concrete motivating scenario here, just something I noticed during code reading: `CallHierarchyIncomingCall::fromRanges` are interpreted as ranges in the same file as the `CallHierarchyIt

[clang-tools-extra] [clangd] Harden incomingCalls() against possible misinterpretation of a range as pertaining to the wrong file (PR #111616)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Nathan Ridge (HighCommander4) Changes I don't have a concrete motivating scenario here, just something I noticed during code reading: `CallHierarchyIncomingCall::fromRanges` are interpreted as ranges in the same file as the `

[clang-tools-extra] [clangd] Harden incomingCalls() against possible misinterpretation of a range as pertaining to the wrong file (PR #111616)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Nathan Ridge (HighCommander4) Changes I don't have a concrete motivating scenario here, just something I noticed during code reading: `CallHierarchyIncomingCall::fromRanges` are interpreted as ranges in the same file as the `CallHierarc

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-08 Thread via cfe-commits
@@ -782,6 +782,13 @@ llvm::DIType *CGDebugInfo::CreateType(const BuiltinType *BT) { #define SVE_TYPE(Name, Id, SingletonId) case BuiltinType::Id: #include "clang/Basic/AArch64SVEACLETypes.def" { + if (BT->getKind() == BuiltinType::ArmMFloat8) { +Encoding = llv

[clang] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-08 Thread via cfe-commits
serge-sans-paille wrote: This change is triggering warnings at several point in the code base, I'll fix that too. https://github.com/llvm/llvm-project/pull/111434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-08 Thread Iuri Chaer via cfe-commits
https://github.com/ichaer updated https://github.com/llvm/llvm-project/pull/111513 >From 7db80ba448fe4f434362de505330f504b9362844 Mon Sep 17 00:00:00 2001 From: Iuri Chaer Date: Tue, 8 Oct 2024 10:52:13 +0100 Subject: [PATCH 1/4] [clang-format] Add CI check confirming ClangFormatStyleOptions.r

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-08 Thread Iuri Chaer via cfe-commits
ichaer wrote: Sample failure: https://github.com/llvm/llvm-project/actions/runs/11233429933/job/31227131778?pr=111513#step:10:127 https://github.com/llvm/llvm-project/pull/111513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [Basic] Avoid repeated hash lookups (NFC) (PR #111467)

2024-10-08 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Tooling] Avoid repeated hash lookups (NFC) (PR #111469)

2024-10-08 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Avoid repeated hash lookups (NFC) (PR #111468)

2024-10-08 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [lld][LoongArch] Enable relaxation when --relax option is passed (PR #111488)

2024-10-08 Thread via cfe-commits
https://github.com/ywgrit updated https://github.com/llvm/llvm-project/pull/111488 >From 32aae75a78fbd10c8238494b9b01b85f576a47a8 Mon Sep 17 00:00:00 2001 From: Xin Wang Date: Tue, 8 Oct 2024 14:03:51 +0800 Subject: [PATCH 1/2] [lld][LoongArch] Enable relaxation when --relax option is passed

[clang] [RFC][C++20][Modules] Relax ODR check in unnamed modules (PR #111160)

2024-10-08 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/60 >From dc4a79c2ee5630eb551ea3a40b4bd67da20c7034 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 4 Oct 2024 06:41:34 -0700 Subject: [PATCH 1/3] [RFC][C++20][Modules] Relax ODR check in unnamed modules

[clang] [RFC][C++20][Modules] Relax ODR check in unnamed modules (PR #111160)

2024-10-08 Thread Dmitry Polukhin via cfe-commits
@@ -2527,7 +2527,7 @@ class BitsUnpacker { inline bool shouldSkipCheckingODR(const Decl *D) { return D->getASTContext().getLangOpts().SkipODRCheckInGMF && - D->isFromGlobalModule(); + (D->isFromGlobalModule() || !D->isInNamedModule()); dmpolu

[clang] [clang-format] convert path to Windows path if user is using a MSYS2 shell (PR #111526)

2024-10-08 Thread Gary Wang via cfe-commits
https://github.com/BLumia created https://github.com/llvm/llvm-project/pull/111526 Currently, we simply rely on the result of `git rev-parse --show-toplevel` in `cd_to_toplevel()`, which when using MSYS2 shell under Windows, can result getting a UNIX path instead of Windows path, and `os.chdir

[clang] [clang-format] convert path to Windows path if user is using a MSYS2 shell (PR #111526)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Gary Wang (BLumia) Changes Currently, we simply rely on the result of `git rev-parse --show-toplevel` in `cd_to_toplevel()`, which when using MSYS2 shell under Windows, can result getting a UNIX path instead of Windows path, and `o

[clang] [clang-format] convert path to Windows path if user is using a MSYS2 shell (PR #111526)

2024-10-08 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [RFC][C++20][Modules] Relax ODR check in unnamed modules (PR #111160)

2024-10-08 Thread Dmitry Polukhin via cfe-commits
@@ -0,0 +1,32 @@ +// RUN: rm -fR %t +// RUN: split-file %s %t +// RUN: cd %t +// RUN: %clang_cc1 -verify -std=c++20 -fskip-odr-check-in-gmf -emit-header-unit -xc++-user-header bz0.h +// RUN: %clang_cc1 -verify -std=c++20 -fskip-odr-check-in-gmf -emit-header-unit -xc++-user-heade

[clang] [clang] Add test for CWG110 "Can template functions and classes be declared in the same scope?" (PR #111446)

2024-10-08 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/111446 >From 9e427888749e7fc77c0302742de971d69c8c2889 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 8 Oct 2024 00:58:48 +0300 Subject: [PATCH 1/2] [clang] Add test for CWG110 --- clang/test/CXX/drs/cwg

[clang] [clang] Add test for CWG110 "Can template functions and classes be declared in the same scope?" (PR #111446)

2024-10-08 Thread Vlad Serebrennikov via cfe-commits
@@ -119,6 +119,16 @@ namespace cwg109 { // cwg109: yes }; } +namespace cwg110 { // cwg110: 2.8 +template +void f(); + +class f; + +template +void f(int); +} // namespace cwg110 Endilll wrote: I updated the test. Does it look good now? https://github.com/

[clang] [clang][Sema] Add instant event when template instantiation is deferred. (PR #111524)

2024-10-08 Thread via cfe-commits
https://github.com/ivanaivanovska created https://github.com/llvm/llvm-project/pull/111524 None >From cbfb9438dbfaf4618fb17825228527c33c5ee836 Mon Sep 17 00:00:00 2001 From: Ivana Ivanovska Date: Mon, 7 Oct 2024 12:51:55 + Subject: [PATCH] [Sema] This commit contains Sema changes --- cla

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-10-08 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/110446 >From a61f3e94d0636f4294f3be440d79b83889771800 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Mon, 30 Sep 2024 02:58:31 +0200 Subject: [PATCH 1/3] [Clang] Instantiate the correct lambda call operator --- clang

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-10-08 Thread via cfe-commits
@@ -644,8 +646,8 @@ New features if class of allocation and deallocation function mismatches. `Documentation `__. -- Function effects, e.g. the ``nonblocking`` and ``nonallocating`` "perfo

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-10-08 Thread via cfe-commits
@@ -644,8 +646,8 @@ New features if class of allocation and deallocation function mismatches. `Documentation `__. -- Function effects, e.g. the ``nonblocking`` and ``nonallocating`` "perfo

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2024-10-08 Thread Younan Zhang via cfe-commits
@@ -1841,9 +1872,71 @@ Decl *TemplateInstantiator::TransformDecl(SourceLocation Loc, Decl *D) { // template parameter. } + if (auto *PVD = dyn_cast(D); + PVD && PVD->getDeclContext() == FunctionDCForParameterDeclInstantiation && + !ParameterInstantiationScop

[clang] [RFC][C++20][Modules] Relax ODR check in unnamed modules (PR #111160)

2024-10-08 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/60 >From dc4a79c2ee5630eb551ea3a40b4bd67da20c7034 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 4 Oct 2024 06:41:34 -0700 Subject: [PATCH 1/2] [RFC][C++20][Modules] Relax ODR check in unnamed modules

[libclc] 64f7e1b - [libclc] Update build instructions in readme (#111369)

2024-10-08 Thread via cfe-commits
Author: David Spickett Date: 2024-10-08T16:23:42+01:00 New Revision: 64f7e1b697d834f620b069f2c3dc701ed8ff732a URL: https://github.com/llvm/llvm-project/commit/64f7e1b697d834f620b069f2c3dc701ed8ff732a DIFF: https://github.com/llvm/llvm-project/commit/64f7e1b697d834f620b069f2c3dc701ed8ff732a.diff

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Thankyou! So I think in CI we can not add any extra testing targets if libclc is included in the build. If you have some in future I'm happy to help enable them. https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits ma

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: > Also do you know if libclc has any tests worth running in CI? It doesn't have > a check-libclc so I'm not sure if that's because there's not much to run, or > running the tests requires a GPU or something else. > > Context is I've been looking at the pipeline we use for PR

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck approved this pull request. LGTM other than the question about sorting the list https://github.com/llvm/llvm-project/pull/111528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread Fraser Cormack via cfe-commits
@@ -151,6 +147,17 @@ if( "spirv-mesa3d-" IN_LIST LIBCLC_TARGETS_TO_BUILD OR "spirv64-mesa3d-" IN_LIST endif() endif() +if( LIBCLC_TARGETS_TO_BUILD STREQUAL "all" ) frasercrmck wrote: Right yeah, because `spirv-mesa3d-` is only added to `ALL` if the tool is

[clang] [clang][RISCV] Make the index of riscv_tuple_extract and riscv_tuple_insert be truncated rather than zero extended (PR #111466)

2024-10-08 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/111466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8ab7718 - [clang][RISCV] Make the index of riscv_tuple_extract and riscv_tuple_insert be truncated rather than zero extended (#111466)

2024-10-08 Thread via cfe-commits
Author: Brandon Wu Date: 2024-10-08T08:28:57-07:00 New Revision: 8ab77184dde2583950fc6e4886ff526e7e598f7e URL: https://github.com/llvm/llvm-project/commit/8ab77184dde2583950fc6e4886ff526e7e598f7e DIFF: https://github.com/llvm/llvm-project/commit/8ab77184dde2583950fc6e4886ff526e7e598f7e.diff LO

[clang] clang-format: Add "AllowShortNamespacesOnASingleLine" option (PR #105597)

2024-10-08 Thread Galen Elias via cfe-commits
galenelias wrote: Ping https://github.com/llvm/llvm-project/pull/105597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Convert README to Markdown (PR #111549)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111549 A bit nicer to read on GitHub and with clickable links. No content changes purely formatting. >From c84c1754ed6142293a2a06e75900772054cfcc67 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 8 Oct

<    1   2   3   4   5