[clang] Switch DirectX Target to use the Itanium ABI (PR #111632)

2024-10-08 Thread Greg Roth via cfe-commits
https://github.com/pow2clk edited https://github.com/llvm/llvm-project/pull/111632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Switch DirectX Target to use the Itanium ABI (PR #111632)

2024-10-08 Thread Greg Roth via cfe-commits
https://github.com/pow2clk edited https://github.com/llvm/llvm-project/pull/111632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-08 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod updated https://github.com/llvm/llvm-project/pull/108276 >From fff6064a63ddf85857ea5036333866317a156ffc Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Tue, 10 Sep 2024 02:22:18 +0100 Subject: [PATCH 1/7] [Clang] Add explicit visibility symbol macros and update CM

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-08 Thread Iuri Chaer via cfe-commits
ichaer wrote: > The documentation build workflow is not really the correct place to put this. Yeah, I agree, but I couldn't find a place which looked correct :sweat_smile:. This thing of adding built artifacts to the repo always introduces sadness... the documentation build workflow looked lik

[clang] [clang] Introduce [[clang::lifetime_capture_by(X)]] (PR #111499)

2024-10-08 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/111499 >From 4951a7b9b87f9800bc3629bd44f65141ba98c6b0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 8 Oct 2024 08:19:56 + Subject: [PATCH 1/3] start working on lifetime capture --- clang/include/clang/Ba

[clang] [analyzer] Modernize FuchsiaHandleChecker (PR #111588)

2024-10-08 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag created https://github.com/llvm/llvm-project/pull/111588 This PR modernizes FuchsiaHandleChecker to fix real-world problem. Previous checker logic was modeling handles via `checkPreCall` and `checkPostCall`, which doesn't work well for CTU, since function body gets i

[clang] [analyzer] Modernize FuchsiaHandleChecker (PR #111588)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pavel Skripkin (pskrgag) Changes This PR modernizes FuchsiaHandleChecker to fix real-world problem. Previous checker logic was modeling handles via `checkPreCall` and `checkPostCall`, which doesn't work well for CTU, since function body g

[clang] 75611ca - [Clang] Improve type traits recognition in `__has_builtin` (#111516)

2024-10-08 Thread via cfe-commits
Author: cor3ntin Date: 2024-10-08T23:03:32+02:00 New Revision: 75611caff4fab2f73358ae1f4c4f490622cfaa1d URL: https://github.com/llvm/llvm-project/commit/75611caff4fab2f73358ae1f4c4f490622cfaa1d DIFF: https://github.com/llvm/llvm-project/commit/75611caff4fab2f73358ae1f4c4f490622cfaa1d.diff LOG:

[clang] [Clang] Improve type traits recognition in `__has_builtin` (PR #111516)

2024-10-08 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/111516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Thin3 (PR #108614)

2024-10-08 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/108614 >From 411fc459e58a65d9599c917f220ba68bb799baac Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 13 Sep 2024 08:51:00 -0700 Subject: [PATCH 1/4] [CGData][ThinLTO] Global Outlining with Two-CodeGen Round

[clang] [clang] Introduce [[clang::lifetime_capture_by(X)]] (PR #111499)

2024-10-08 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/111499 >From 4951a7b9b87f9800bc3629bd44f65141ba98c6b0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 8 Oct 2024 08:19:56 + Subject: [PATCH 1/4] start working on lifetime capture --- clang/include/clang/Ba

[clang] [clang-tools-extra] [clang-tidy] bugprone-implicit-widening ignores unsigned consts (PR #101073)

2024-10-08 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Looking at the clang-tidy changes only, this looks good. Though, I don't know if the changes to Clang are okay with Clang maintainers, but maybe they have an untapped use for this as well? Either way, a Clang maintainer needs to sign off on those changes before merging. Maybe t

[clang] [llvm] [HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic (PR #111576)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Finn Plummer (inbelic) Changes - add additional lowering for directx backend in CGBuiltin.cpp - add directx intrinsic to IntrinscsDirectX.td - add semantic check of arguments in SemaHLSL.cpp - add mapping to DXIL op

[clang] [clang-format] convert path to Windows path if user is using a MSYS2 shell (PR #111526)

2024-10-08 Thread via cfe-commits
mydeveloperday wrote: I personally use Cygwin and it's git understands unix paths is that not the case for msys2 or are you mixing msys2 with windows based git, won't this have the potential to break others? https://github.com/llvm/llvm-project/pull/111526 _

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-08 Thread Finn Plummer via cfe-commits
inbelic wrote: I will go ahead and merge this tomorrow if there are no other comments. https://github.com/llvm/llvm-project/pull/111010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Insert a space between l_paren and ref-qualifier (PR #111465)

2024-10-08 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/111465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] convert path to Windows path if user is using a MSYS2 shell (PR #111526)

2024-10-08 Thread via cfe-commits
mydeveloperday wrote: Can you please log an issue for this to show what you see and a reproducer https://github.com/llvm/llvm-project/pull/111526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [llvm] [HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic (PR #111576)

2024-10-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/111576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic (PR #111576)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Finn Plummer (inbelic) Changes - add additional lowering for directx backend in CGBuiltin.cpp - add directx intrinsic to IntrinscsDirectX.td - add semantic check of arguments in SemaHLSL.cpp - add mapping to DXIL op in DXIL.

[clang] [llvm] [HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic (PR #111576)

2024-10-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic ready_for_review https://github.com/llvm/llvm-project/pull/111576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic (PR #111576)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-directx Author: Finn Plummer (inbelic) Changes - add additional lowering for directx backend in CGBuiltin.cpp - add directx intrinsic to IntrinscsDirectX.td - add semantic check of arguments in SemaHLSL.cpp - add mapping to DXIL o

[clang] Add arrangeCXXMethodCall to the CodeGenABITypes interface. (PR #111597)

2024-10-08 Thread Hiroshi Yamauchi via cfe-commits
https://github.com/hjyamauchi created https://github.com/llvm/llvm-project/pull/111597 In MSVC, the calling conventions for free functions and C++ instance methods could be different, it makes sense to have this variant there. >From 7be9488cc36596788ea6a1b979cb028e3c28e961 Mon Sep 17 00:00:00

[clang-tools-extra] [clang-tidy][performance-move-const-arg] Fix crash when argument type has no definition (PR #111472)

2024-10-08 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/111472 >From 05519fa9c4a15c60759063e7a750b61a48abf956 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Tue, 8 Oct 2024 18:19:37 -0400 Subject: [PATCH] [clang-tidy][performance-move-const-arg] Fix crash when ar

[clang-tools-extra] [clang-tidy][performance-move-const-arg] Fix crash when argument type has no definition (PR #111472)

2024-10-08 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/111472 >From 05519fa9c4a15c60759063e7a750b61a48abf956 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Tue, 8 Oct 2024 18:19:37 -0400 Subject: [PATCH] [clang-tidy][performance-move-const-arg] Fix crash when ar

[clang] Add arrangeCXXMethodCall to the CodeGenABITypes interface. (PR #111597)

2024-10-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c6d6da4659599507b44c167f335639082f28fae6 7be9488cc36596788ea6a1b979cb028e3c28e961 --e

[clang] [libcxx] [clang] remove extra space in warn_atomic_op_oversized (NFC) (PR #110955)

2024-10-08 Thread via cfe-commits
https://github.com/Enna1 closed https://github.com/llvm/llvm-project/pull/110955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RFC][C++20][Modules] Relax ODR check in unnamed modules (PR #111160)

2024-10-08 Thread Chuanqi Xu via cfe-commits
@@ -2527,7 +2527,7 @@ class BitsUnpacker { inline bool shouldSkipCheckingODR(const Decl *D) { return D->getASTContext().getLangOpts().SkipODRCheckInGMF && - D->isFromGlobalModule(); + (D->isFromGlobalModule() || !D->isInNamedModule()); Chuanq

[clang] [RFC][C++20][Modules] Relax ODR check in unnamed modules (PR #111160)

2024-10-08 Thread Chuanqi Xu via cfe-commits
@@ -2527,7 +2527,7 @@ class BitsUnpacker { inline bool shouldSkipCheckingODR(const Decl *D) { return D->getASTContext().getLangOpts().SkipODRCheckInGMF && - D->isFromGlobalModule(); + (D->isFromGlobalModule() || !D->isInNamedModule()); Chuanq

[clang] [libcxx] [clang] remove extra space in warn_atomic_op_oversized (NFC) (PR #110955)

2024-10-08 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-fuzzer` running on `sanitizer-buildbot11` while building `clang,libcxx` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/159/builds/7776 Here is the relev

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-08 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @kadircet ping~ It will be pretty good for the users if we can have this for clang20. https://github.com/llvm/llvm-project/pull/106683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang-tools-extra] [clang-include-cleaner] Fix incorrect directory issue for writing files (PR #111375)

2024-10-08 Thread Byoungchan Lee via cfe-commits
bc-lee wrote: Could you provide a minimal reproducer for this case if possible? Ideally, it should not depend on Google's internal Bazel setup or tools. From what I understand, Bazel itself doesn’t generate compilation databases, and third-party tools adjust the paths of raw compiler invocatio

[clang] [clang] Track function template instantiation from definition (PR #110387)

2024-10-08 Thread Younan Zhang via cfe-commits
@@ -1008,6 +1008,15 @@ class FunctionTemplateDecl : public RedeclarableTemplateDecl { return getTemplatedDecl()->isThisDeclarationADefinition(); } + bool isCompatibleWithDefinition() const { +return getTemplatedDecl()->isInstantiatedFromMemberTemplate() || +

[clang] [libcxx] [clang][driver] Cleanup UEFI toolchain driver (PR #111473)

2024-10-08 Thread via cfe-commits
https://github.com/Prabhuk updated https://github.com/llvm/llvm-project/pull/111473 >From 9b55509827b25fda48bdb8e2322259415c01e206 Mon Sep 17 00:00:00 2001 From: prabhukr Date: Mon, 7 Oct 2024 20:14:58 -0700 Subject: [PATCH] [clang][driver] Cleanup UEFI toolchain driver UEFI toolchain predefin

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-10-08 Thread Teresa Johnson via cfe-commits
@@ -74,6 +75,8 @@ static cl::opt ThinLTOAssumeMerged( cl::desc("Assume the input has already undergone ThinLTO function " "importing and the other pre-optimization pipeline changes.")); +extern cl::opt CodeGenDataThinLTOTwoRounds; teresajohnso

[clang-tools-extra] [clang-tidy] Avoid repeated hash lookups (NFC) (PR #111628)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111628.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp (+1-3) ```

[clang-tools-extra] [clang-tidy] Avoid repeated hash lookups (NFC) (PR #111628)

2024-10-08 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/111628 None >From 04ac47ef9952eaeb4e9d8ef7f7b96cb050865a3a Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 8 Oct 2024 20:42:13 -0700 Subject: [PATCH] [clang-tidy] Avoid repeated hash lookups (NFC) --- .

[clang] 1809d0f - [clang-format] Insert a space between l_paren and ref-qualifier (#111465)

2024-10-08 Thread via cfe-commits
Author: Owen Pan Date: 2024-10-08T21:24:17-07:00 New Revision: 1809d0fa1c15b16ca94381d8be3ef70c4a83c36b URL: https://github.com/llvm/llvm-project/commit/1809d0fa1c15b16ca94381d8be3ef70c4a83c36b DIFF: https://github.com/llvm/llvm-project/commit/1809d0fa1c15b16ca94381d8be3ef70c4a83c36b.diff LOG:

[clang] [clang-format] Insert a space between l_paren and ref-qualifier (PR #111465)

2024-10-08 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/111465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] convert path to Windows path if user is using a MSYS2 shell (PR #111526)

2024-10-08 Thread Gary Wang via cfe-commits
BLumia wrote: > I personally use Cygwin and it's git understands unix paths is that not the > case for msys2 Git can understand (and will return a) unix path, but it seems MSYS2's python won't accept unix path. It fails at `os.chdir(toplevel)`, and `toplevel` is a unix path. > are you mixing

[clang] [clang][RISCV] Correct the SEW operand of indexed/fault only first segment intrinsics (PR #111476)

2024-10-08 Thread Brandon Wu via cfe-commits
4vtomat wrote: > Make sense to me. It was wrong since when? It's from the tuple interface change patches, https://github.com/llvm/llvm-project/pull/97992. https://github.com/llvm/llvm-project/pull/111476 ___ cfe-commits mailing list cfe-commits@lists

[clang] [-Wunsafe-buffer-usage] Add user documentation. (PR #111624)

2024-10-08 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ updated https://github.com/llvm/llvm-project/pull/111624 >From b5c9082e36efcc7be2cabc73c985749f2fd41725 Mon Sep 17 00:00:00 2001 From: Artem Dergachev Date: Tue, 8 Oct 2024 20:24:00 -0700 Subject: [PATCH 1/2] [-Wunsafe-buffer-usage] Add user documentation. --- clang/

[clang] [clang-format] Insert a space between l_paren and ref-qualifier (PR #111465)

2024-10-08 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-fuzzer` running on `sanitizer-buildbot11` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/159/builds/7782 Here is the relevant pie

[clang] [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (PR #110327)

2024-10-08 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/110327 >From 4f235c0e9c539cdaa2bab9a7f8228f33c0fea2b8 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Thu, 26 Sep 2024 14:34:16 -0700 Subject: [PATCH 1/7] Add codegen for existing resource types and make HLSLAttribut

[clang] ada6372 - Revert "[clang] Finish implementation of P0522 (#96023)"

2024-10-08 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2024-10-09T08:41:42+02:00 New Revision: ada6372e52547ba0090f52a2e9e9d95d7eca28d3 URL: https://github.com/llvm/llvm-project/commit/ada6372e52547ba0090f52a2e9e9d95d7eca28d3 DIFF: https://github.com/llvm/llvm-project/commit/ada6372e52547ba0090f52a2e9e9d95d7eca28d3.diff

[clang] [clang] Finish implementation of P0522 (PR #96023)

2024-10-08 Thread via cfe-commits
zmodem wrote: I'll revert to unbreak trunk in the meantime. https://github.com/llvm/llvm-project/pull/96023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Thin3 (PR #108614)

2024-10-08 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/108614 >From 411fc459e58a65d9599c917f220ba68bb799baac Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 13 Sep 2024 08:51:00 -0700 Subject: [PATCH 1/5] [CGData][ThinLTO] Global Outlining with Two-CodeGen Round

[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-10-08 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 commented: Thanks for the update! The patch is looking pretty good, just some minor comments remaining and then it should be good to go. https://github.com/llvm/llvm-project/pull/95712 ___ cfe-commits mailing list cf

[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-10-08 Thread Nathan Ridge via cfe-commits
@@ -709,7 +738,8 @@ class InlayHintVisitor : public RecursiveASTVisitor { private: using NameVec = SmallVector; - void processCall(Callee Callee, llvm::ArrayRef Args) { + void processCall(Callee Callee, SourceRange RParenOrBraceRange, HighCommander4 wrote

[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-10-08 Thread Nathan Ridge via cfe-commits
@@ -372,6 +381,25 @@ maybeDropCxxExplicitObjectParameters(ArrayRef Params) { return Params; } +template +std::string joinAndTruncate(R &&Range, size_t MaxLength, HighCommander4 wrote: Now that the function has only one call site, can we drop the `GetAsStr

[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-10-08 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/95712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-10-08 Thread Nathan Ridge via cfe-commits
@@ -1465,6 +1469,34 @@ TEST(TypeHints, DefaultTemplateArgs) { ExpectedHint{": A", "binding"}); } +TEST(DefaultArguments, Smoke) { + Config Cfg; + Cfg.InlayHints.Parameters = + true; // To test interplay of parameters and default parameters + Cfg.Inlay

[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-10-08 Thread Nathan Ridge via cfe-commits
@@ -1681,6 +1681,15 @@ enum class InlayHintKind { /// This is a clangd extension. BlockEnd = 4, + /// An inlay hint that is for a default argument. + /// + /// An example of a parameter hint for a default argument: + ///void foo(bool A = true); + ///foo(^); +

[clang] [clang][RISCV] Correct the SEW operand of indexed/fault only first segment intrinsics (PR #111476)

2024-10-08 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp approved this pull request. Make sense to me. It was wrong since when? https://github.com/llvm/llvm-project/pull/111476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-08 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -2282,6 +2308,9 @@ void ThreadSafetyAnalyzer::runAnalysis(AnalysisDeclContex

[clang] [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (PR #110327)

2024-10-08 Thread Helena Kotas via cfe-commits
@@ -32,6 +32,7 @@ #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/StringExtras.h" #include "llvm/Support/CRC.h" +#include "llvm/Support/DXILABI.h" hekota wrote: Nope :) https://github.com/llvm/llvm-project/pull/110327

[clang] clang/AMDGPU: Stop emitting amdgpu-unsafe-fp-atomics attribute (PR #111579)

2024-10-08 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/111579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d50302f - clang/AMDGPU: Stop emitting amdgpu-unsafe-fp-atomics attribute (#111579)

2024-10-08 Thread via cfe-commits
Author: Matt Arsenault Date: 2024-10-09T08:52:32+04:00 New Revision: d50302f31cee86d3270a34f5739c63a41f60f2c1 URL: https://github.com/llvm/llvm-project/commit/d50302f31cee86d3270a34f5739c63a41f60f2c1 DIFF: https://github.com/llvm/llvm-project/commit/d50302f31cee86d3270a34f5739c63a41f60f2c1.diff

[clang] [clang] Track function template instantiation from definition (PR #110387)

2024-10-08 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/110387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4336f00 - [clang] Track function template instantiation from definition (#110387)

2024-10-08 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-10-09T01:55:21-03:00 New Revision: 4336f00f2156970cc0af2816331387a0a4039317 URL: https://github.com/llvm/llvm-project/commit/4336f00f2156970cc0af2816331387a0a4039317 DIFF: https://github.com/llvm/llvm-project/commit/4336f00f2156970cc0af2816331387a0a4039317.dif

[clang] Switch DirectX Target to use the Itanium ABI (PR #111632)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Greg Roth (pow2clk) Changes To consolidate behavior of function mangling and limit the number of places that ABI changes will need to be made, this switches the DirectX target used for HLSL to use the It

[clang] Switch DirectX Target to use the Itanium ABI (PR #111632)

2024-10-08 Thread Greg Roth via cfe-commits
https://github.com/pow2clk edited https://github.com/llvm/llvm-project/pull/111632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Switch DirectX Target to use the Itanium ABI (PR #111632)

2024-10-08 Thread Greg Roth via cfe-commits
@@ -260,10 +260,10 @@ void order_matters(inout int X, inout int Y) { // CHECK: store i32 [[VVal]], ptr [[Tmp0]] // CHECK: [[VVal:%.*]] = load i32, ptr [[V]] // CHECK: store i32 [[VVal]], ptr [[Tmp1]] -// CHECK: call void {{.*}}order_matters{{.*}}(ptr noalias noundef nonnull al

[clang] Switch DirectX Target to use the Itanium ABI (PR #111632)

2024-10-08 Thread Greg Roth via cfe-commits
@@ -1,93 +1,96 @@ -// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \ -// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ -// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ -// RUN: --check-prefixes=CHECK,NATIVE_HALF -// RUN:

[clang-tools-extra] Insert `// NOLINTNEXTLINE(...)` for clang-tidy diagnostics (PR #111640)

2024-10-08 Thread Richard Li via cfe-commits
https://github.com/chomosuke created https://github.com/llvm/llvm-project/pull/111640 In some other language servers, there will be code actions that inserts warning suppression comment for the user. This PR implements that for clangd for clang-tidy diagnostics.. >From 0c18e956b9ef4c44bb2f896

[clang-tools-extra] Insert `// NOLINTNEXTLINE(...)` for clang-tidy diagnostics (PR #111640)

2024-10-08 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-08 Thread Aiden Grossman via cfe-commits
@@ -34,8 +34,12 @@ config.test_format = lit.formats.ShTest(use_lit_shell == "0") config.substitutions.append( ('%clang_cpp_skip_driver', ' %s %s %s ' % (cc1_wrapper, config.clang, sysroot_flags))) config.substitutions.append( ('%clang_cpp', ' %s --driver-mode=g++ %s ' % (confi

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-08 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,2 @@ +RUN: %cmake -G %cmake_generator -B %t -S %llvm_src_dir -DCMAKE_C_COMPILER=%clang -DCMAKE_CXX_COMPILER=%clang -DCMAKE_CXX_FLAGS="--driver-mode=g++" -DCMAKE_BUILD_TYPE=Release boomanaiden154 wrote: Why the `--driver-mode=g++` flag here? https://

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-08 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 commented: This looks very interesting! Thanks for taking the time to collect all the numbers. It definitely seems like collecting proper profiles for BOLT is something that we want to do, at least for the CI compiler, given the numbers here. I'm assuming you

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-08 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/111625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [lld][LoongArch] Enable relaxation when --relax option is passed (PR #111488)

2024-10-08 Thread via cfe-commits
@@ -1462,6 +1462,8 @@ template void Writer::finalizeAddressDependentContent() { for (;;) { bool changed = ctx.target->needsThunks ? tc.createThunks(pass, ctx.outputSections) + : ctx.arg.emachine == EM_LOONGARCH && !ctx.arg.relax

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

2024-10-08 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > Right, use `git clang-format`, that will take care of formatting the file > over time without creating churn. I think the number of changes is relatively small for a file this size. The churn here is comparable to that created by a "normal" patch... https://github.com/llvm/

[clang] [clang][python] Add CLANG_DISABLE_RUN_PYTHON_TESTS CMake option to disable clang python bindings tests (PR #111367)

2024-10-08 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum approved this pull request. LGTM, but I'd like @Endilll to take a look as well, since I'm not that familiar with our build infrastructure & cmake https://github.com/llvm/llvm-project/pull/111367 ___ cfe-commits mailing

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) Changes Currently, we do not account for differences in template depth when comparing exception specifications for equivalence. This results in explicit specializations of member function templates special

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-08 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: > FYI I just realized the Final parameter is not wired up to the Collecter. It > appertains to the Innermost argument. Oops! I don't think it affects functionality though, so it can probably be addressed in a follow-up patch https://github.com/llvm/llvm-project/pull/73 _

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread Amr Hesham via cfe-commits
@@ -1217,6 +1217,8 @@ static void handlePreferredName(Sema &S, Decl *D, const ParsedAttr &AL) { bool Sema::isValidPointerAttrType(QualType T, bool RefOkay) { if (RefOkay) { +if (T->isDependentType()) AmrDeveloper wrote: Think you, updated https://gith

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: This seems reasonable, other than 1 `#if 0` https://github.com/llvm/llvm-project/pull/111561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-08 Thread Erich Keane via cfe-commits
@@ -574,6 +675,7 @@ static bool CheckEquivalentExceptionSpecImpl( } } +#if 0 erichkeane wrote: Hmm? https://github.com/llvm/llvm-project/pull/111561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/111561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-08 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: FYI I just realized the Final parameter is not wired up to the Collecter. It appertains to the Innermost argument. https://github.com/llvm/llvm-project/pull/73 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-08 Thread Krystian Stasiowski via cfe-commits
@@ -574,6 +675,7 @@ static bool CheckEquivalentExceptionSpecImpl( } } +#if 0 sdkrystian wrote: Just an implementation remnant, I'll remove it :) https://github.com/llvm/llvm-project/pull/111561 ___ cfe-commit

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane requested changes to this pull request. https://github.com/llvm/llvm-project/pull/111573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread Erich Keane via cfe-commits
@@ -1217,6 +1217,8 @@ static void handlePreferredName(Sema &S, Decl *D, const ParsedAttr &AL) { bool Sema::isValidPointerAttrType(QualType T, bool RefOkay) { if (RefOkay) { +if (T->isDependentType()) erichkeane wrote: This doesn't seem like the right p

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread Erich Keane via cfe-commits
@@ -52,6 +52,9 @@ T *atest3() __attribute__((assume_aligned(31, o))); // expected-error {{requeste template T *atest4() __attribute__((assume_aligned(32, o))); +template +T atest5(int) __attribute__((assume_aligned(2))); erichkeane wrote: This change causes

[clang] [clang] Add test for CWG110 "Can template functions and classes be declared in the same scope?" (PR #111446)

2024-10-08 Thread Richard Smith via cfe-commits
https://github.com/zygoloid approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/111446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic (PR #111576)

2024-10-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/111576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][DXIL] Implement WaveGetLaneIndex (PR #111576)

2024-10-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic created https://github.com/llvm/llvm-project/pull/111576 - add additional lowering for directx backend in CGBuiltin.cpp - add directx intrinsic to IntrinscsDirectX.td - add semantic check of arguments in SemaHLSL.cpp - add mapping to DXIL op in DXIL.td

[clang] [clang] Introduce [[clang::lifetime_capture_by(X)]] (PR #111499)

2024-10-08 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/111499 >From 4951a7b9b87f9800bc3629bd44f65141ba98c6b0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 8 Oct 2024 08:19:56 + Subject: [PATCH 1/3] start working on lifetime capture --- clang/include/clang/Ba

[clang] [clang] Allow `ConditionalOperator` fast-math flags to be overridden by `pragma float_control` (PR #105912)

2024-10-08 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > Are you suggesting that loads need to have fast-math flags attached to them? > Because this sounds like a bad representation in IR. What I'm primarily suggesting is that we should be handling conditional operators consistently in the presence of pragmas. Whether that can be

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-08 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/111573 >From 076c867c16141f2c1b78c55fd78250155c0d97fd Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 8 Oct 2024 20:12:45 +0200 Subject: [PATCH] [clang] assume_aligned incorrectly diagnoses a dependent ret

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-08 Thread via cfe-commits
serge-sans-paille wrote: Some of the libcxx builds fail, they are marked as "build stopped: interrupted by user."... I can't find the origin https://github.com/llvm/llvm-project/pull/111434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] clang/AMDGPU: Stop emitting amdgpu-unsafe-fp-atomics attribute (PR #111579)

2024-10-08 Thread Shilei Tian via cfe-commits
https://github.com/shiltian commented: Not sure if you still want to keep it for backward compatibility. https://github.com/llvm/llvm-project/pull/111579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] clang/AMDGPU: Stop emitting amdgpu-unsafe-fp-atomics attribute (PR #111579)

2024-10-08 Thread Matt Arsenault via cfe-commits
arsenm wrote: > Not sure if you still want to keep it for backward compatibility. Definitely not. It's already bitcode auto upgraded https://github.com/llvm/llvm-project/pull/111579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] clang/AMDGPU: Stop emitting amdgpu-unsafe-fp-atomics attribute (PR #111579)

2024-10-08 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/111579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-08 Thread via cfe-commits
@@ -0,0 +1,546 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-08 Thread Chris B via cfe-commits
@@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify -verify-ignore-unexpected llvm-beanz wrote: I'm always suspicious when I see `verify-ignore-u

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-08 Thread Chris B via cfe-commits
@@ -87,6 +87,7 @@ class CGHLSLRuntime { GENERATE_HLSL_INTRINSIC_FUNCTION(SDot, sdot) GENERATE_HLSL_INTRINSIC_FUNCTION(UDot, udot) GENERATE_HLSL_INTRINSIC_FUNCTION(WaveIsFirstLane, wave_is_first_lane) + GENERATE_HLSL_INTRINSIC_FUNCTION(WaveReadLaneAt, waveReadLaneAt)

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsic (PR #111010)

2024-10-08 Thread Chris B via cfe-commits
@@ -18835,6 +18835,24 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { Intrinsic::ID ID = CGM.getHLSLRuntime().getWaveIsFirstLaneIntrinsic(); return EmitRuntimeCall(Intrinsic::getDeclaration(&CGM.getModule(), ID)); } + case Builtin::BI__builtin_hlsl_wave_read_l

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-08 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110435 >From c52634882631a71fad956a70179b480abf13006a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 29 Sep 2024 22:01:38 +0300 Subject: [PATCH 1/3] [Clang] fix overload resolution for object parameters with

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-08 Thread Younan Zhang via cfe-commits
@@ -501,6 +519,89 @@ bool Sema::CheckEquivalentExceptionSpec( return Result; } +static const Expr *SubstituteExceptionSpecWithoutEvaluation( +Sema &S, const Sema::TemplateCompareNewDeclInfo &DeclInfo, +const Expr *ExceptionSpec) { + MultiLevelTemplateArgumentList ML

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-08 Thread Younan Zhang via cfe-commits
@@ -501,6 +519,89 @@ bool Sema::CheckEquivalentExceptionSpec( return Result; } +static const Expr *SubstituteExceptionSpecWithoutEvaluation( +Sema &S, const Sema::TemplateCompareNewDeclInfo &DeclInfo, +const Expr *ExceptionSpec) { + MultiLevelTemplateArgumentList ML

<    1   2   3   4   5   >