carlosgalvezp wrote:
> > It now comes to mind that we probably also want to check `memcpy(ptr,
> > ptr)`, which is equivalent to `bit_cast`. In that case I wonder if the
> > check name still holds or it should be named something else?
>
> Yeah, with the addition of `memcpy`, the `bit` part of
ostannard wrote:
Rebased over #110093, and squashed the fixup commits.
https://github.com/llvm/llvm-project/pull/109943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib`
running on `gribozavr4` while building `clang,llvm` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/60/builds/8662
Here is the relevant piece
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
Add the primitive type and implement to-bool casts.
---
Full diff: https://github.com/llvm/llvm-project/pull/110216.diff
14 Files Affected:
- (modified) clang/lib/AST/ByteCode/ByteCodeEmitter.cpp (+1)
- (
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/109389
>From b8f95b5b809cbeb8199de6cd24e18a605189f722 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 19 Sep 2024 23:41:10 -0700
Subject: [PATCH 1/5] WebKit Checkers should set DeclWithIssue.
Set DeclWithIssue in
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`clang-cmake-x86_64-avx512-win` running on `avx512-intel64-win` while building
`clang` at step 6 "ninja check 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/81/builds/1993
Here is the relevant pi
https://github.com/vikramRH updated
https://github.com/llvm/llvm-project/pull/108497
>From 6afc2e91d8877cc330f6e317a404a74990d9c607 Mon Sep 17 00:00:00 2001
From: vikhegde
Date: Wed, 4 Sep 2024 10:34:54 +
Subject: [PATCH 1/2] [clang][TableGen] Support specifying address space in
clang buil
vikramRH wrote:
Made some initial changes according to suggestions @AaronBallman , how does
this look ?
https://github.com/llvm/llvm-project/pull/108497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
thetruestblue wrote:
pinging for a review.
https://github.com/llvm/llvm-project/pull/108328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kiranchandramohan approved this pull request.
LG.
https://github.com/llvm/llvm-project/pull/109907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/110257.diff
3 Files Affected:
- (modified) clang/lib/AST/ByteCode/Compiler.cpp (+4-1)
- (modified) clang/lib/AST/ByteCode/FixedPoint.h (+4)
- (mo
Author: agozillon
Date: 2024-09-27T18:17:53+02:00
New Revision: 3625f9f615c024b85f1daa967abae77998b939dc
URL:
https://github.com/llvm/llvm-project/commit/3625f9f615c024b85f1daa967abae77998b939dc
DIFF:
https://github.com/llvm/llvm-project/commit/3625f9f615c024b85f1daa967abae77998b939dc.diff
LOG
mizvekov wrote:
> I'm wondering what level of granularity we should aim for when reusing the
> current implementation in `GetTypeForDeclarator`?
You can perhaps extract just the parts that are common between both use cases
into a separate function, or another possible approach would be to reus
https://github.com/agozillon closed
https://github.com/llvm/llvm-project/pull/109907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AlexVlx edited
https://github.com/llvm/llvm-project/pull/110182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz updated
https://github.com/llvm/llvm-project/pull/110195
>From 4226fd6d3788396bc7515d20d46cf6f358489d3e Mon Sep 17 00:00:00 2001
From: Chris Bieneman
Date: Thu, 26 Sep 2024 20:06:20 -0500
Subject: [PATCH] HLSL has a different set of usual arithmetic conversions for
@@ -4282,6 +4282,64 @@ static void upgradeDbgIntrinsicToDbgRecord(StringRef
Name, CallBase *CI) {
CI->getParent()->insertDbgRecordBefore(DR, CI->getIterator());
}
+static CallBase *upgradeConstrainedIntrinsicCall(CallBase *CB, Function *F,
+
@@ -2994,6 +2994,29 @@ A "convergencectrl" operand bundle is only valid on a
``convergent`` operation.
When present, the operand bundle must contain exactly one value of token type.
See the :doc:`ConvergentOperations` document for details.
+.. _ob_fpe:
+
+Floating-point Envir
@@ -357,6 +357,9 @@ class IRBuilderBase {
void setConstrainedFPCallAttr(CallBase *I) {
I->addFnAttr(Attribute::StrictFP);
+MemoryEffects ME = MemoryEffects::inaccessibleMemOnly();
spavloff wrote:
If a constrained intrinsic like `experimental_constra
@@ -43,6 +43,15 @@ enum ExceptionBehavior : uint8_t {
}
+inline bool isValidExceptionBehavior(unsigned X) {
spavloff wrote:
I think this is historically, because the functionality was implemented by
different people. We have "FPE.h" and "FloatingPointMode.h
Author: Timm Baeder
Date: 2024-09-27T18:29:34+02:00
New Revision: 6fd870bf3585db7d9b4af5e4b95bc731bbf9c0fa
URL:
https://github.com/llvm/llvm-project/commit/6fd870bf3585db7d9b4af5e4b95bc731bbf9c0fa
DIFF:
https://github.com/llvm/llvm-project/commit/6fd870bf3585db7d9b4af5e4b95bc731bbf9c0fa.diff
L
@@ -47,6 +47,15 @@ enum class RoundingMode : int8_t {
Invalid = -1///< Denotes invalid value.
};
+inline bool isValidRoundingMode(int X) {
+ return X >= 0 && X <= static_cast(RoundingMode::Dynamic);
spavloff wrote:
This is bad function name. Actually s
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/110171
>From f6c1590f9513ecab8fe0ea6db8b5367513ce95a1 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 26 Sep 2024 17:09:32 -0400
Subject: [PATCH] [libc++abi][libunwind] Run c++abi and unwind tests against a
fak
inbelic wrote:
Hm, the failing test-case is unrelated to these changes. But please let me know
if action is required.
https://github.com/llvm/llvm-project/pull/110027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Eric Astor (ericastor)
Changes
We already have support for declaration attributes; this is just a matter of
extending the plugin infrastructure to cover one more case.
---
Full diff: https://github.com/llvm/llvm-project/pull/110334.diff
https://github.com/AlexVlx updated
https://github.com/llvm/llvm-project/pull/110182
>From af1adfafaa09bc7992cf9aaf34a6121cf2d56d5b Mon Sep 17 00:00:00 2001
From: Alex Voicu
Date: Thu, 26 Sep 2024 04:16:52 +0100
Subject: [PATCH 1/2] Mark globals as `constant` if they have been annotated
with `_
@@ -85,4 +85,9 @@ def int_dx_rsqrt : DefaultAttrsIntrinsic<[llvm_anyfloat_ty],
[LLVMMatchType<0>]
def int_dx_wave_is_first_lane : DefaultAttrsIntrinsic<[llvm_i1_ty], [],
[IntrConvergent]>;
def int_dx_sign : DefaultAttrsIntrinsic<[LLVMScalarOrSameVectorWidth<0,
llvm_i32_ty>],
https://github.com/joaosaffran updated
https://github.com/llvm/llvm-project/pull/109331
>From ef969c536d700a8585f0892952fae49cdd9c42d1 Mon Sep 17 00:00:00 2001
From: Joao Saffran
Date: Thu, 19 Sep 2024 00:13:51 +
Subject: [PATCH 1/9] Codegen builtin
---
clang/include/clang/Basic/Builtins.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/110350.diff
5 Files Affected:
- (modified) clang/lib/AST/ByteCode/Compiler.cpp (+11)
- (modified) clang/lib/AST/ByteCode/FixedPoint.h (+2-1)
- (m
@@ -4488,6 +4488,30 @@ void CXXNameMangler::mangleType(const ArrayParameterType
*T) {
mangleType(cast(T));
}
+void CXXNameMangler::mangleType(const HLSLAttributedResourceType *T) {
+ mangleType(T->getWrappedType());
+ const HLSLAttributedResourceType::Attributes &Attrs =
@@ -322,6 +322,40 @@ uint32_t mapping::getNumberOfProcessorElements() {
return static_cast(config::getHardwareParallelism());
}
+uint32_t mapping::getSimdLen() {
+ return 1;
jdoerfert wrote:
How does this work if it's always 1?
https://github.com/llvm/llv
https://github.com/jdoerfert edited
https://github.com/llvm/llvm-project/pull/91261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1033,6 +1033,7 @@ static FieldDecl *addFieldToRecordDecl(ASTContext &C,
DeclContext *DC,
CGOpenMPRuntime::CGOpenMPRuntime(CodeGenModule &CGM)
: CGM(CGM), OMPBuilder(CGM.getModule()) {
+
jdoerfert wrote:
Cleanup the PR please.
https://github.com/llvm
@@ -790,8 +794,167 @@ void OpenMPIRBuilder::finalize(Function *Fn) {
"OMPIRBuilder finalization \n";
};
- if (!OffloadInfoManager.empty())
+ if (!OffloadInfoManager.empty())
createOffloadEntriesAndInfoMetadata(ErrorReportFn);
+
+ if (Config.EmitLLVMUse
@@ -87,8 +87,10 @@ extern "C" {
int32_t num_threads,
void *fn, void **args,
const int64_t nargs) {
+ //printf("SPMD mode\n")
@@ -336,13 +337,15 @@ class CheckVarsEscapingDeclContext final
return;
if (!D->hasAssociatedStmt())
return;
+
if (const auto *S =
dyn_cast_or_null(D->getAssociatedStmt())) {
// Do not analyze directives that do not actually require captu
@@ -1402,6 +1402,7 @@ void CodeGenFunction::EmitOMPReductionClauseInit(
}
const auto *VD = cast(cast(TaskRedRef)->getDecl());
+llvm::dbgs() << "Emitting " << VD->getName() << " " << VD << "\n";
jdoerfert wrote:
leftover, same as all the commented out
@@ -2824,155 +2829,78 @@ void CGOpenMPRuntimeGPU::emitReduction(
return;
}
- assert((TeamsReduction || ParallelReduction) &&
- "Invalid reduction selection in emitReduction.");
-
- llvm::SmallDenseMap VarFieldMap;
- llvm::SmallVector PrivatesReductions(Private
@@ -167,6 +167,9 @@ double omp_get_wtick(void);
double omp_get_wtime(void);
///}
+
+int omp_get_simd_lane(void);
jdoerfert wrote:
ompx_, assuming this is not in the standard.
https://github.com/llvm/llvm-project/pull/91261
___
https://github.com/jdoerfert commented:
There is too much unrelated stuff, printfs, commented code, etc. too review it
properly.
I left high-level comments, including why there is a hardcoded simdlen of 1 and
globalization for all allocas.
https://github.com/llvm/llvm-project/pull/91261
_
@@ -105,6 +105,13 @@ uint32_t getMaxTeamThreads(bool IsSPMD);
/// Return the number of processing elements on the device.
uint32_t getNumberOfProcessorElements();
+uint32_t getSimdLen();
+uint32_t getSimdGroup();
+uint32_t getSimdLane();
+bool isSimdLeader();
+uint32_t getNumS
@@ -184,7 +196,7 @@ __kmpc_parallel_51(IdentTy *ident, int32_t, int32_t if_expr,
// set, but they do not have individual ThreadStates yet. If they ever
// modify the ICVs beyond this point a ThreadStates will be allocated.
- bool IsActiveParallelRegion = NumThreads > 1;
+
shiltian wrote:
> I am wondering if it would be easier to provide generic builtins in clang and
> just codegen them. I guess in that case we'd just upscale everything to
> 64-bit and say "If you need the other one use the target specific version".
I'm not sure if that's a good idea. For simple
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/110306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3,12 +3,12 @@
// Supported targets
//
-// RUN: %clang -target dxil-unknown-shadermodel6.2-compute %s -S -o /dev/null
2>&1 | FileCheck --allow-empty --check-prefix=CHECK-VALID %s
-// RUN: %clang -target spirv-unknown-vulkan-compute %s -S -o /dev/null 2>&1 |
FileCheck --al
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/100684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tcwzxx updated
https://github.com/llvm/llvm-project/pull/109970
>From f9a25251087a160f2dc9e7f589aeb7b215bef60f Mon Sep 17 00:00:00 2001
From: tcwzxx
Date: Wed, 25 Sep 2024 19:19:08 +0800
Subject: [PATCH 1/7] Rename mangleNameOrStandardSubstitution to
mangleCXXRecordDecl and
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/110257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
I also think that "bad" is a confusing word to use here, "unsupported" would be
better but I will address that in a follow up PR.
https://github.com/llvm/llvm-project/pull/110239
___
cfe-commits mailing list
cfe-commits@lists.llvm
https://github.com/ericastor created
https://github.com/llvm/llvm-project/pull/110334
We already have support for declaration attributes; this is just a matter of
extending the plugin infrastructure to cover one more case.
>From 0411b2939e10ca335e84731502126145509bef2d Mon Sep 17 00:00:00 2001
https://github.com/jryans approved this pull request.
This part looks good to me, thanks for working on this! 😄
https://github.com/llvm/llvm-project/pull/107279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/110239
...not the register keyword. Fixes #109776.
Until now the error was only tested in clang/test/Sema/asm.c, where you can't
check for the "^" character. I've added a new caret test file as I see has been
d
@@ -4282,6 +4282,64 @@ static void upgradeDbgIntrinsicToDbgRecord(StringRef
Name, CallBase *CI) {
CI->getParent()->insertDbgRecordBefore(DR, CI->getIterator());
}
+static CallBase *upgradeConstrainedIntrinsicCall(CallBase *CB, Function *F,
+
teresajohnson wrote:
> > @teresajohnson Do you have any concern or comment on this direction?
>
> Just a quick reply to say that I am taking a look today (unfamiliar with this
> approach so need to read through the RFC etc) and will get back later today
Sorry I was obviously over optimistic on
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast`
running on `gribozavr4` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/56/builds/8505
Here is the rele
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib`
running on `gribozavr4` while building `clang` at step 6
"test-build-unified-tree-check-clang".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/60/builds/8762
Here is the re
https://github.com/python3kgae approved this pull request.
https://github.com/llvm/llvm-project/pull/110306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -422,6 +422,55 @@ template constexpr uint asuint(T F) {
return __detail::bit_cast(F);
}
+//===--===//
+// asuint splitdouble builtins
+//===---
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-arm64-windows-msvc`
running on `linaro-armv8-windows-msvc-04` while building `clang` at step 5
"ninja check 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/161/builds/2385
Here is the relev
@@ -470,6 +484,11 @@ class OpenMPIRBuilder {
/// all functions are finalized.
void finalize(Function *Fn = nullptr);
+ CallInst *globalizeAlloca(AllocaInst *Alloca, SmallVector&);
+ void globalizeParallelVars(Function *CurFn);
+ SmallPtrSet
@@ -1210,12 +1211,16 @@ CallInst
*CodeExtractor::emitCallAndSwitchStatement(Function *newFunction,
if (ArgsInZeroAddressSpace && DL.getAllocaAddrSpace() != 0) {
auto *StructSpaceCast = new AddrSpaceCastInst(
- Struct, PointerType ::get(Context, 0), "structA
@@ -2974,10 +2974,8 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
Sema::CompoundScopeRAII Scope(Actions);
AssociatedStmt = ParseStatement();
-if (AssociatedStmt.isUsable() && isOpenMPLoopDirective(DKind) &&
-getLangOpts
@@ -164,9 +164,57 @@ uint32_t roundToWarpsize(uint32_t s) {
uint32_t kmpcMin(uint32_t x, uint32_t y) { return x < y ? x : y; }
+static int32_t nvptx_simd_reduce_nowait(void *reduce_data,
+ShuffleReductFnTy shflFct,
+
@@ -287,7 +303,7 @@ __kmpc_parallel_51(IdentTy *ident, int32_t, int32_t if_expr,
// Set to true for workers participating in the parallel region.
uint32_t TId = mapping::getThreadIdInBlock();
- bool ThreadIsActive = TId < state::getEffectivePTeamSize();
+ bool ThreadIsAc
@@ -6,6 +6,10 @@ uint4 test_asuint_too_many_arg(float p0, float p1) {
// expected-error@-1 {{no matching function for call to 'asuint'}}
// expected-note@hlsl/hlsl_intrinsics.h:* {{candidate function template not
viable: requires single argument 'V', but 2 arguments were pr
@@ -3,12 +3,12 @@
// Supported targets
//
-// RUN: %clang -target dxil-unknown-shadermodel6.2-compute %s -S -o /dev/null
2>&1 | FileCheck --allow-empty --check-prefix=CHECK-VALID %s
-// RUN: %clang -target spirv-unknown-vulkan-compute %s -S -o /dev/null 2>&1 |
FileCheck --al
https://github.com/llvm-beanz requested changes to this pull request.
I have concerns about a few aspects of this change. @joaosaffran, let's sync up
on Monday.
https://github.com/llvm/llvm-project/pull/109331
___
cfe-commits mailing list
cfe-commits@
https://github.com/joaosaffran updated
https://github.com/llvm/llvm-project/pull/109331
>From 9adaad635c4252c377daba166ef5fa7eb022942d Mon Sep 17 00:00:00 2001
From: Joao Saffran
Date: Thu, 19 Sep 2024 00:13:51 +
Subject: [PATCH 1/8] Codegen builtin
---
clang/include/clang/Basic/Builtins.
AlexVlx wrote:
I've extende the test under `Transforms/GlobalOpt/externally-initialized.ll` to
also cover `constant`s / ensure they don't get CSEd.
https://github.com/llvm/llvm-project/pull/110182
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
https://github.com/AlexVlx updated
https://github.com/llvm/llvm-project/pull/110182
>From af1adfafaa09bc7992cf9aaf34a6121cf2d56d5b Mon Sep 17 00:00:00 2001
From: Alex Voicu
Date: Thu, 26 Sep 2024 04:16:52 +0100
Subject: [PATCH 1/3] Mark globals as `constant` if they have been annotated
with `_
@@ -85,4 +85,9 @@ def int_dx_rsqrt : DefaultAttrsIntrinsic<[llvm_anyfloat_ty],
[LLVMMatchType<0>]
def int_dx_wave_is_first_lane : DefaultAttrsIntrinsic<[llvm_i1_ty], [],
[IntrConvergent]>;
def int_dx_sign : DefaultAttrsIntrinsic<[LLVMScalarOrSameVectorWidth<0,
llvm_i32_ty>],
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/109331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -422,6 +422,55 @@ template constexpr uint asuint(T F) {
return __detail::bit_cast(F);
}
+//===--===//
+// asuint splitdouble builtins
+//===---
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/109331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/110350
None
>From 164521d666e573789b720d457c6c42809224e905 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Fri, 27 Sep 2024 20:24:52 +0200
Subject: [PATCH] [clang][bytecode] Implement integral-to-f
401 - 475 of 475 matches
Mail list logo
