[clang-tools-extra] [clang-move] Avoid repeated hash lookups (NFC) (PR #109374)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/109374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] modernize-use-nullptr matches "NULL" in templates (PR #109169)

2024-09-20 Thread Congcong Cai via cfe-commits
@@ -38,7 +38,9 @@ AST_MATCHER(Type, sugaredNullptrType) { StatementMatcher makeCastSequenceMatcher(llvm::ArrayRef NameList) { auto ImplicitCastToNull = implicitCastExpr( anyOf(hasCastKind(CK_NullToPointer), hasCastKind(CK_NullToMemberPointer)), - unless(hasImplic

[clang] [RISCV] Fix incorrect check prefix in riscv32-toolchain.c and riscv64-toolchain.c. NFC. (PR #109390)

2024-09-20 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. You can use `[test]` instead of `. NFC.` `-SAME: ` is preferred when testing a string on the same line https://github.com/llvm/llvm-project/pull/109390 ___ cfe-commits mailing list cfe-commits@li

[clang] [libcxx] [Clang] Add __builtin_common_type (PR #99473)

2024-09-20 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Changes LGTM! It would be nice to add an additional test case that does -ast-dump (or I suppose -ast-print would work as well) to verify the builtin common type list has the expected form. However, I don't insist as I expect the libc+

[clang] [C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #109167)

2024-09-20 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/109167 >From 72b43bd2f392a009187e1cdd90627691a4017707 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Wed, 18 Sep 2024 09:02:23 -0700 Subject: [PATCH 1/5] [C++20][Modules] Fix crash when function and lambda in

[clang] [AMDGPU] Correctly use the auxiliary toolchain to include libc++ (PR #109366)

2024-09-20 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/109366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #109167)

2024-09-20 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/109167 >From 72b43bd2f392a009187e1cdd90627691a4017707 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Wed, 18 Sep 2024 09:02:23 -0700 Subject: [PATCH 1/4] [C++20][Modules] Fix crash when function and lambda in

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-09-20 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod edited https://github.com/llvm/llvm-project/pull/109362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c472c9f - [OpenACC] Remove mistakenly left over commented code from a previous

2024-09-20 Thread via cfe-commits
Author: erichkeane Date: 2024-09-20T09:39:25-07:00 New Revision: c472c9f367e8376fb5cb9bcc954d9c434ecd242a URL: https://github.com/llvm/llvm-project/commit/c472c9f367e8376fb5cb9bcc954d9c434ecd242a DIFF: https://github.com/llvm/llvm-project/commit/c472c9f367e8376fb5cb9bcc954d9c434ecd242a.diff LO

[clang] [C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #109167)

2024-09-20 Thread Dmitry Polukhin via cfe-commits
dmpolukhin wrote: @ChuanqiXu9 thank you for the detailed steps, I uploaded new version. Does it look like something you had in mind? https://github.com/llvm/llvm-project/pull/109167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-20 Thread Shilei Tian via cfe-commits
shiltian wrote: > Why is that a DL property and not just a target property? It is indeed a target property. DL is one choice here (if it is not the most preferable one). Like I mentioned before, TTI and `TargetMachine` could have been one, but not feasible. Where else do you suggest? > Or eve

[clang] 2162a18 - [clang][CodeGen] Check initializer of zero-size fields for nullptr (#109271)

2024-09-20 Thread via cfe-commits
Author: Michael Buch Date: 2024-09-20T19:42:41+01:00 New Revision: 2162a18fb206736c41c9182737b72ae15d5e6bf0 URL: https://github.com/llvm/llvm-project/commit/2162a18fb206736c41c9182737b72ae15d5e6bf0 DIFF: https://github.com/llvm/llvm-project/commit/2162a18fb206736c41c9182737b72ae15d5e6bf0.diff

[clang] [clang][CodeGen] Check initializer of zero-size fields for nullptr (PR #109271)

2024-09-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/109271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Warn about incomplete language support (PR #108894)

2024-09-20 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 approved this pull request. https://github.com/llvm/llvm-project/pull/108894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-20 Thread via cfe-commits
@@ -266,6 +262,20 @@ void Sema::inferLifetimeBoundAttribute(FunctionDecl *FD) { LifetimeBoundAttr::CreateImplicit(Context, FD->getLocation())); } } + } else if (auto *CanonDecl = FD->getCanonicalDecl(); FD != CanonDecl) { +// Propagate the lifetimeb

[clang] cdd71d6 - [Clang][Sema] Refactor collection of multi-level template argument lists (#106585)

2024-09-20 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-09-20T14:57:40-04:00 New Revision: cdd71d61664b63ae57bdba9ee0d891f78ef79c07 URL: https://github.com/llvm/llvm-project/commit/cdd71d61664b63ae57bdba9ee0d891f78ef79c07 DIFF: https://github.com/llvm/llvm-project/commit/cdd71d61664b63ae57bdba9ee0d891f78ef79c07

[clang] [Clang][Sema] Refactor collection of multi-level template argument lists (PR #106585)

2024-09-20 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/106585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Doc][HLSL] Add documentation for root signature (PR #88781)

2024-09-20 Thread Joshua Batista via cfe-commits
@@ -0,0 +1,312 @@ + +HLSL Root Signatures + + +.. contents:: + :local: + +Usage += + +In HLSL, the `root signature +`_ +defines what types of resources are bou

[clang] [Doc][HLSL] Add documentation for root signature (PR #88781)

2024-09-20 Thread Joshua Batista via cfe-commits
@@ -0,0 +1,312 @@ + +HLSL Root Signatures + + +.. contents:: + :local: + +Usage += + +In HLSL, the `root signature +`_ +defines what types of resources are bou

[clang-tools-extra] [clang-tidy] modernize-use-nullptr matches "NULL" in templates (PR #109169)

2024-09-20 Thread Congcong Cai via cfe-commits
@@ -38,7 +38,9 @@ AST_MATCHER(Type, sugaredNullptrType) { StatementMatcher makeCastSequenceMatcher(llvm::ArrayRef NameList) { auto ImplicitCastToNull = implicitCastExpr( anyOf(hasCastKind(CK_NullToPointer), hasCastKind(CK_NullToMemberPointer)), - unless(hasImplic

[clang] [Sema] Declare GlobalMethodPool with using (NFC) (PR #109437)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/109437 GlobalMethodPool is a wrapper around DenseMap that does not add anything except: using Lists = std::pair; This patch removes the wrapper and switches to an alias with "using". In ReadMethodPool in AST

[clang] [clang][CodeGen] Check initializer of zero-size fields for nullptr (PR #109271)

2024-09-20 Thread Aaron Ballman via cfe-commits
@@ -738,7 +738,7 @@ bool ConstStructBuilder::Build(const InitListExpr *ILE, bool AllowOverwrite) { // Zero-sized fields are not emitted, but their initializers may still // prevent emission of this struct as a constant. if (isEmptyFieldForLayout(CGM.getContext(), F

[clang] [Clang][NFC] Remove incorrect SYCL tests (PR #109182)

2024-09-20 Thread via cfe-commits
https://github.com/elizabethandrews closed https://github.com/llvm/llvm-project/pull/109182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] c498af7 - [clang-tidy] Avoid repeated hash lookups (NFC) (#109373)

2024-09-20 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-09-20T07:59:08-07:00 New Revision: c498af71d73e96e95730f3b3caaea08d3edbe62c URL: https://github.com/llvm/llvm-project/commit/c498af71d73e96e95730f3b3caaea08d3edbe62c DIFF: https://github.com/llvm/llvm-project/commit/c498af71d73e96e95730f3b3caaea08d3edbe62c.diff L

[clang-tools-extra] [clang-tidy] Avoid repeated hash lookups (NFC) (PR #109373)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/109373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #109375)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/109375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] add static for internal linkage function and extract common function to header file (PR #109436)

2024-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109436.diff 7 Files Affected: - (added) clang/lib/Sema/AttrTemplateInstantiate.cpp (+6) - (added) clang/lib/Sema/AttrTemplateInstantiate.h (+19

[clang] [clang][NFC] add static for internal linkage function and extract common function to header file (PR #109436)

2024-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109436.diff 7 Files Affected: - (added) clang/lib/Sema/AttrTemplateInstantiate.cpp (+6) - (added) clang/lib/Sema/AttrTemplateInstantiate.h (+1

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-09-20 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: Thanks for the instructions on how to reproduce. I'll take a look. https://github.com/llvm/llvm-project/pull/102975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Correctly use the auxiliary toolchain to include libc++ (PR #109366)

2024-09-20 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/109366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix false warning on reinterpret_casting unknown template type (PR #109430)

2024-09-20 Thread Krystian Stasiowski via cfe-commits
@@ -2092,6 +2092,10 @@ void Sema::CheckCompatibleReinterpretCast(QualType SrcType, QualType DestType, } } + if (SrcTy->isTemplateTypeParmType() || DestTy->isTemplateTypeParmType()) { sdkrystian wrote: This should probably be`if (SrcTy->isDependentType

[clang] [clang] Fix false warning on reinterpret_casting unknown template type (PR #109430)

2024-09-20 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian requested changes to this pull request. https://github.com/llvm/llvm-project/pull/109430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix false warning on reinterpret_casting unknown template type (PR #109430)

2024-09-20 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/109430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 12e8e0b - [AMDGPU] Correctly use the auxiliary toolchain to include libc++ (#109366)

2024-09-20 Thread via cfe-commits
Author: Joseph Huber Date: 2024-09-20T09:29:59-07:00 New Revision: 12e8e0b10c3f52098cc41322c12eb7f3bfd75b06 URL: https://github.com/llvm/llvm-project/commit/12e8e0b10c3f52098cc41322c12eb7f3bfd75b06 DIFF: https://github.com/llvm/llvm-project/commit/12e8e0b10c3f52098cc41322c12eb7f3bfd75b06.diff

[clang] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

2024-09-20 Thread Rahman Lavaee via cfe-commits
rlavaee wrote: > Just chiming in that I happened to spot the pre-merge check failure looks > possibly related. @jh7370 It's weird I can't reproduce this on my machine. https://github.com/llvm/llvm-project/pull/107494 ___ cfe-commits mailing list cfe-

[clang] ebf1308 - [OpenACC] Ensure clause expressions side-effects don't happen

2024-09-20 Thread via cfe-commits
Author: erichkeane Date: 2024-09-20T11:08:38-07:00 New Revision: ebf13086740d714339b5f7a8bdadf9a5e1b754bb URL: https://github.com/llvm/llvm-project/commit/ebf13086740d714339b5f7a8bdadf9a5e1b754bb DIFF: https://github.com/llvm/llvm-project/commit/ebf13086740d714339b5f7a8bdadf9a5e1b754bb.diff LO

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-09-20 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod edited https://github.com/llvm/llvm-project/pull/109362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d497f46 - [FMV][AArch64] Unify ls64, ls64_v and ls64_accdata. (#108024)

2024-09-20 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-09-20T19:10:54+01:00 New Revision: d497f465df024068cb2c134cdccd2f76bebd2a1e URL: https://github.com/llvm/llvm-project/commit/d497f465df024068cb2c134cdccd2f76bebd2a1e DIFF: https://github.com/llvm/llvm-project/commit/d497f465df024068cb2c134cdccd2f76bebd2a

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify ls64, ls64_v and ls64_accdata. (PR #108024)

2024-09-20 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/108024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fb78495 - Reland "[Driver] Add toolchain for X86_64 UEFI target" (#109364)

2024-09-20 Thread via cfe-commits
Author: Prabhuk Date: 2024-09-20T11:16:36-07:00 New Revision: fb78495376017111d8b5a1f43745d3c17b0d8978 URL: https://github.com/llvm/llvm-project/commit/fb78495376017111d8b5a1f43745d3c17b0d8978 DIFF: https://github.com/llvm/llvm-project/commit/fb78495376017111d8b5a1f43745d3c17b0d8978.diff LOG:

[clang] Reland "[Driver] Add toolchain for X86_64 UEFI target" (PR #109364)

2024-09-20 Thread via cfe-commits
https://github.com/Prabhuk closed https://github.com/llvm/llvm-project/pull/109364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] add static for internal linkage function and extract common function to header file (PR #109436)

2024-09-20 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/109436 None >From abac0e695412e0613cdb50a9e59e84f224e4138d Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Fri, 20 Sep 2024 23:03:57 +0800 Subject: [PATCH] [clang][NFC] add static for internal linkage function a

[clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 17ba7e8538a2a4cc7b17322d26e8ea83ce27d617 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6 +

[clang-tools-extra] [clang-move] Use a range-based for loop (NFC) (PR #109438)

2024-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109438.diff 1 Files Affected: - (modified) clang-tools-extra/clang-move/HelperDeclRefGraph.cpp (+2-2) ``diff diff --gi

[clang-tools-extra] [clang-move] Use a range-based for loop (NFC) (PR #109438)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/109438 None >From a8f5541213f25f266355db26cb685d969cdf6ef9 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 20 Sep 2024 08:36:08 -0700 Subject: [PATCH] [clang-move] Use a range-based for loop (NFC) --- c

[clang] [Clang] Prevent Copying of LateParsedClass Instances (PR #109428)

2024-09-20 Thread via cfe-commits
smanna12 wrote: Thank you @tahonermann for reviews! https://github.com/llvm/llvm-project/pull/109428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] modernize-use-nullptr matches "NULL" in templates (PR #109169)

2024-09-20 Thread Thomas Köppe via cfe-commits
https://github.com/tkoeppe updated https://github.com/llvm/llvm-project/pull/109169 From 07df4ed66b36fab2da9a2ae83ab85d8fcb39aa3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20K=C3=B6ppe?= Date: Wed, 18 Sep 2024 17:04:44 + Subject: [PATCH] [clang-tidy] Make modernize-use-nullptr matcher

[clang-tools-extra] [clang-tidy] modernize-use-nullptr matches "NULL" in templates (PR #109169)

2024-09-20 Thread Thomas Köppe via cfe-commits
@@ -38,7 +38,9 @@ AST_MATCHER(Type, sugaredNullptrType) { StatementMatcher makeCastSequenceMatcher(llvm::ArrayRef NameList) { auto ImplicitCastToNull = implicitCastExpr( anyOf(hasCastKind(CK_NullToPointer), hasCastKind(CK_NullToMemberPointer)), - unless(hasImplic

[clang] [TableGen] Use StringSet instead of StringMap (NFC) (PR #109441)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/109441 None >From 2d341c98063a16644c373b41390d681df4908034 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 20 Sep 2024 09:07:34 -0700 Subject: [PATCH] [TableGen] Use StringSet instead of StringMap (NFC)

[clang] [TableGen] Use StringSet instead of StringMap (NFC) (PR #109441)

2024-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109441.diff 1 Files Affected: - (modified) clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp (+3-2) ``diff diff --git a/clang/uti

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-09-20 Thread Thomas Fransham via cfe-commits
fsfod wrote: > One thing I don't understand about this PR is why we need Compiler.h in Clang > -- wouldn't the LLVM definitions in their Compiler.h work for Clang as well? > (This would probably be worth explaining in the patch summary.) We could if we didn't need the visibility macros in diff

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

2024-09-20 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,32 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++20 %s + +namespace GH49093 { + class B { + public: +static int a() { return 0; } // expected-note {{member is declared here}} +decltype(a< 0 >(0)) test;// expected-error {{member 'a' used before its

[clang] [llvm] Update llvm::Registry to work for LLVM shared library builds on windows (PR #109024)

2024-09-20 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod updated https://github.com/llvm/llvm-project/pull/109024 >From fcb6837e5c6ff48bf261bae9d3cedda55da89a7e Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Wed, 28 Aug 2024 16:08:52 +0100 Subject: [PATCH 1/4] Update llvm::Registry to work for LLVM shared library build

[clang] [clang] implement current direction of CWG2765 for string literal comparisons in constant evaluation (PR #109208)

2024-09-20 Thread James Y Knight via cfe-commits
jyknight wrote: I worry about string literals in vague-linkage entities, because the "version" of the string literal which is referred to from an inline-function/variable at runtime may not actually be the same version of the string literal seen in the current compilation -- at runtime we may

[clang] [clang] Use {} instead of std::nullopt to initialize empty ArrayRef (PR #109399)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/109399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tools-extra] Use {} instead of std::nullopt to initialize empty ArrayRef (PR #109400)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/109400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-09-20 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: > One thing I don't understand about this PR is why we need Compiler.h in Clang > -- wouldn't the LLVM definitions in their Compiler.h work for Clang as well? > (This would probably be worth explaining in the patch summary.) The symbol lookup in PE/COFF is two level and symmetr

[clang] efb5831 - [Clang] Prevent Copying of LateParsedClass Instances (#109428)

2024-09-20 Thread via cfe-commits
Author: smanna12 Date: 2024-09-20T12:08:05-05:00 New Revision: efb583178d74b2174e8b9660b67ba7295527b09f URL: https://github.com/llvm/llvm-project/commit/efb583178d74b2174e8b9660b67ba7295527b09f DIFF: https://github.com/llvm/llvm-project/commit/efb583178d74b2174e8b9660b67ba7295527b09f.diff LOG:

[clang] [Clang] Prevent Copying of LateParsedClass Instances (PR #109428)

2024-09-20 Thread via cfe-commits
https://github.com/smanna12 closed https://github.com/llvm/llvm-project/pull/109428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][wasm] Replace the target integer sub saturate intrinsics with the equivalent generic `__builtin_elementwise_sub_sat` intrinsics (PR #109405)

2024-09-20 Thread Thomas Lively via cfe-commits
https://github.com/tlively approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/109405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit error for duplicate mangled names within a lambda (PR #107581)

2024-09-20 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Oh, that makes sense... so the issue is generally with functions we emit lazily? I'd say it's reasonable to emit an error if we have two definitions for the same symbol, even if we don't end up emitting them because they're deferred. Lazy emission is an optimization, and

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-09-20 Thread Joshua Batista via cfe-commits
@@ -19,20 +19,20 @@ using namespace llvm; static bool finalizeLinkage(Module &M) { - SmallPtrSet EntriesAndExports; + SmallPtrSet Funcs; // Find all entry points and export functions bob80905 wrote: This comment may be better updated to something like:

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-09-20 Thread Joshua Batista via cfe-commits
@@ -0,0 +1,47 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -S -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -S -o - %s | FileCheck %s + +// Verify that internal linkage unused functions are removed + +RWBuffer buf; + +// Never

[clang] [Clang] Include the clang-shlib CMake project when building for MSVC (PR #109457)

2024-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Thomas Fransham (fsfod) Changes Enable building clang-cpp shared library for windows when building with explicit visibility macros enabled and LLVM is built as a shared library(LLVM_BUILD_LLVM_DYLIB_VIS). This is part of the effort to sup

[clang] [Clang] Include the clang-shlib CMake project when building for MSVC (PR #109457)

2024-09-20 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod created https://github.com/llvm/llvm-project/pull/109457 Enable building clang-cpp shared library for windows when building with explicit visibility macros enabled and LLVM is built as a shared library(LLVM_BUILD_LLVM_DYLIB_VIS). This is part of the effort to support f

[clang] [Clang] Include the clang-shlib CMake project when building for MSVC (PR #109457)

2024-09-20 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/109457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Check initializer of zero-size fields for nullptr (PR #109271)

2024-09-20 Thread Eli Friedman via cfe-commits
@@ -738,7 +738,7 @@ bool ConstStructBuilder::Build(const InitListExpr *ILE, bool AllowOverwrite) { // Zero-sized fields are not emitted, but their initializers may still // prevent emission of this struct as a constant. if (isEmptyFieldForLayout(CGM.getContext(), F

[clang] [clang][CodeGen] Check initializer of zero-size fields for nullptr (PR #109271)

2024-09-20 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/109271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Add 'collapse' clause AST/basic Sema implementation (PR #109461)

2024-09-20 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/109461 >From f25688a5f6242e4e16cad377fa281df665d0e38b Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 20 Sep 2024 09:38:32 -0700 Subject: [PATCH 1/3] [OpenACC] Add 'collapse' clause AST/basic Sema implementati

[clang-tools-extra] [clang-move] Use a range-based for loop (NFC) (PR #109438)

2024-09-20 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/109438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Refactor collection of multi-level template argument lists (PR #106585)

2024-09-20 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: I've fixed a warning from this PR with 30adb43c897a45c18d7dd163fb4ff40c915fc488. https://github.com/llvm/llvm-project/pull/106585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] 30adb43 - [AST] Fix a warning

2024-09-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-09-20T13:05:04-07:00 New Revision: 30adb43c897a45c18d7dd163fb4ff40c915fc488 URL: https://github.com/llvm/llvm-project/commit/30adb43c897a45c18d7dd163fb4ff40c915fc488 DIFF: https://github.com/llvm/llvm-project/commit/30adb43c897a45c18d7dd163fb4ff40c915fc488.diff L

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-09-20 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/106146 >From 40224473a7b43bc4ffe2024ab51196c2130bedc7 Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Sun, 25 Aug 2024 12:00:03 -0600 Subject: [PATCH 1/3] [DirectX] Remove trivially dead functions at linkage finalize

[clang] [TableGen] Use StringSet instead of StringMap (NFC) (PR #109441)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/109441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-move] Use a range-based for loop (NFC) (PR #109438)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/109438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d64fc57 - [TableGen] Use StringSet instead of StringMap (NFC) (#109441)

2024-09-20 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-09-20T13:15:08-07:00 New Revision: d64fc57353c6e6f5796c97e9dc541ba7a7ab3cb4 URL: https://github.com/llvm/llvm-project/commit/d64fc57353c6e6f5796c97e9dc541ba7a7ab3cb4 DIFF: https://github.com/llvm/llvm-project/commit/d64fc57353c6e6f5796c97e9dc541ba7a7ab3cb4.diff L

[clang-tools-extra] 9be7f77 - [clang-move] Use a range-based for loop (NFC) (#109438)

2024-09-20 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-09-20T13:14:43-07:00 New Revision: 9be7f7748484e4fb6ca653ac92ba0548ef844ce3 URL: https://github.com/llvm/llvm-project/commit/9be7f7748484e4fb6ca653ac92ba0548ef844ce3 DIFF: https://github.com/llvm/llvm-project/commit/9be7f7748484e4fb6ca653ac92ba0548ef844ce3.diff L

[clang] [Sema] Declare GlobalMethodPool with using (NFC) (PR #109437)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/109437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 533c7ff - [Sema] Declare GlobalMethodPool with using (NFC) (#109437)

2024-09-20 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-09-20T13:14:27-07:00 New Revision: 533c7ff2db6e7f78e34fc0cc1f6390645337d964 URL: https://github.com/llvm/llvm-project/commit/533c7ff2db6e7f78e34fc0cc1f6390645337d964 DIFF: https://github.com/llvm/llvm-project/commit/533c7ff2db6e7f78e34fc0cc1f6390645337d964.diff L

[clang] [TableGen] Use StringSet instead of StringMap (NFC) (PR #109469)

2024-09-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/109469 None >From 8605aa9564d7fdf1d6185ceb498e29d276d39dc3 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 20 Sep 2024 09:02:01 -0700 Subject: [PATCH] [TableGen] Use StringSet instead of StringMap (NFC)

[clang] [C++20][Modules] Restore inliness of constexpr/consteval functions defined in-class (PR #109470)

2024-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (tomasz-kaminski-sonarsource) Changes This correct issue, when the functions declared as `constexpr` are `consteval`, are not considered to be inline (`isInlined()` is false) when defined inside the class attached to the named module

[clang] [TableGen] Use StringSet instead of StringMap (NFC) (PR #109469)

2024-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109469.diff 1 Files Affected: - (modified) clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp (+5-7) ``diff diff --git a/clang/uti

[clang] [TableGen] Use StringSet instead of StringMap (NFC) (PR #109469)

2024-09-20 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/109469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[Driver] Add toolchain for X86_64 UEFI target" (PR #109364)

2024-09-20 Thread via cfe-commits
Prabhuk wrote: The failure reported by build bot appears to be a flake. The next few builders have passed. https://github.com/llvm/llvm-project/pull/109364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [llvm] [Support] Add scaling support in `indent` (PR #109478)

2024-09-20 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/109478 >From 31194fd2fc1dbc2918fe60e4de7198517ff821a3 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Fri, 20 Sep 2024 14:04:25 -0700 Subject: [PATCH] [Support] Add scaling support in `indent` Scaled indent is useful

[clang] [llvm] riscv: Support -mstack-protector-guard=tls (PR #108942)

2024-09-20 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/108942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] riscv: Support -mstack-protector-guard=tls (PR #108942)

2024-09-20 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/108942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy] bugprone-implicit-widening ignores unsigned consts (PR #101073)

2024-09-20 Thread Chris Warner via cfe-commits
https://github.com/cwarner-8702 updated https://github.com/llvm/llvm-project/pull/101073 >From 24f52fbfb9117a6498769cebdc7b09ecbd7e019e Mon Sep 17 00:00:00 2001 From: Chris Warner Date: Wed, 17 Jul 2024 11:22:39 -0700 Subject: [PATCH 1/5] [clang-tidy] bugprone-implicit-widening ignores unsigned

[clang] 4b4ea6d - [HLSL] Make casting functions constexpr (#108902)

2024-09-20 Thread via cfe-commits
Author: Chris B Date: 2024-09-20T16:42:53-05:00 New Revision: 4b4ea6d84bddb5e7b3f144d18630390755e8f7b6 URL: https://github.com/llvm/llvm-project/commit/4b4ea6d84bddb5e7b3f144d18630390755e8f7b6 DIFF: https://github.com/llvm/llvm-project/commit/4b4ea6d84bddb5e7b3f144d18630390755e8f7b6.diff LOG:

[clang] [HLSL] Make casting functions constexpr (PR #108902)

2024-09-20 Thread Chris B via cfe-commits
https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/108902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy] bugprone-implicit-widening ignores unsigned consts (PR #101073)

2024-09-20 Thread Chris Warner via cfe-commits
cwarner-8702 wrote: @EugeneZelenko @PiotrZSL @njames93 @SimplyDanny @5chmidti @HerrCai0907 @AaronBallman Sorry for mass tagging folks, but this PR has been open for nearly 8 weeks with barely any feedback, and is starting to bit rot. I'd really appreciate some feedback, even if it's "this is

[clang] [llvm] Update llvm::Registry to work for LLVM shared library builds on windows (PR #109024)

2024-09-20 Thread Thomas Fransham via cfe-commits
fsfod wrote: @AaronBallman I've added some missing extern template entries for Clang. clang-tools-extra also needs some idk if you ok adding them to this PR as well. https://github.com/llvm/llvm-project/pull/109024 ___ cfe-commits mailing list cfe-com

[clang] 4d62102 - [HLSL] Warn about incomplete language support (#108894)

2024-09-20 Thread via cfe-commits
Author: Chris B Date: 2024-09-20T16:41:15-05:00 New Revision: 4d621025d4fc2f2438affdca7a016dd93b56f4e0 URL: https://github.com/llvm/llvm-project/commit/4d621025d4fc2f2438affdca7a016dd93b56f4e0 DIFF: https://github.com/llvm/llvm-project/commit/4d621025d4fc2f2438affdca7a016dd93b56f4e0.diff LOG:

[clang] [HLSL] Warn about incomplete language support (PR #108894)

2024-09-20 Thread Chris B via cfe-commits
https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/108894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] implement current direction of CWG2765 for string literal comparisons in constant evaluation (PR #109208)

2024-09-20 Thread James Y Knight via cfe-commits
jyknight wrote: > I think that's a separable issue from this PR Yep. I brought it up mainly in case consideration of that set of issues might necessitate design changes here. It sounds like that's not the case though, so I'm happy for it to not be a blocker for this PR. https://github.com/llv

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-09-20 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,24 @@ +// The -time option prints timing information for the various subcommands in a +// format similar to that used by gcc. When compiling and linking, this will +// include the time to call clang-${LLVM_VERSION_MAJOR} and the linker. Since +// the name of the linker

[clang-tools-extra] c24418a - [clang-tidy] Add `std::span` to default `bugprone-dangling-handle.HandleClasses` (#107711)

2024-09-20 Thread via cfe-commits
Author: Afonso Faria Date: 2024-09-21T00:23:17+02:00 New Revision: c24418ad914c64c78facb1bb77951b161448fcc0 URL: https://github.com/llvm/llvm-project/commit/c24418ad914c64c78facb1bb77951b161448fcc0 DIFF: https://github.com/llvm/llvm-project/commit/c24418ad914c64c78facb1bb77951b161448fcc0.diff

[clang] [Driver][Sparc] Default to -mcpu=v9 for 32-bit Linux/sparc64 (PR #109278)

2024-09-20 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > Just to be certain: the revised version of the patch is ok to commit? > > I think it would be good to get an ACK from at least one of the SPARC Leon > maintainers. > > CC @andreas-gaisler Thanks for informing the maintainer. Note: this is done as a courtesy. When we bump a

[clang-tools-extra] [clang-tidy] Add `std::span` to default `bugprone-dangling-handle.HandleClasses` (PR #107711)

2024-09-20 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti closed https://github.com/llvm/llvm-project/pull/107711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-09-20 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,24 @@ +// The -time option prints timing information for the various subcommands in a +// format similar to that used by gcc. When compiling and linking, this will +// include the time to call clang-${LLVM_VERSION_MAJOR} and the linker. Since +// the name of the linker

<    1   2   3   4   5   >