https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/109383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2024-09-20T11:26:58+02:00
New Revision: 9a32f28366b1099b0f5214e62473c0a2a2155434
URL:
https://github.com/llvm/llvm-project/commit/9a32f28366b1099b0f5214e62473c0a2a2155434
DIFF:
https://github.com/llvm/llvm-project/commit/9a32f28366b1099b0f5214e62473c0a2a2155434.diff
L
https://github.com/Keenuts closed
https://github.com/llvm/llvm-project/pull/107408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nikic wrote:
It looks like this change causes regressions in sinking/hoisting, because we
currently can't handle identical calls with different call site attributes.
Basic example: https://llvm.godbolt.org/z/5dTcTfs1x
We need to extend the attribute intersection support to call attributes. It'
@@ -738,7 +738,7 @@ bool ConstStructBuilder::Build(const InitListExpr *ILE,
bool AllowOverwrite) {
// Zero-sized fields are not emitted, but their initializers may still
// prevent emission of this struct as a constant.
if (isEmptyFieldForLayout(CGM.getContext(), F
@@ -0,0 +1,11 @@
+// RUN: %clang_cc1 %s -emit-llvm -triple x86_64-linux-gnu -o - | FileCheck %s
--check-prefixes=CHECK
+// RUN: %clang_cc1 -x c++ %s -emit-llvm -triple x86_64-linux-gnu -o - |
FileCheck %s --check-prefixes=CHECK-CXX
+
+union Foo {
+ struct Empty {} val;
+};
+
+u
labrinea wrote:
Just letting you know that I have reopened
https://github.com/llvm/llvm-project/pull/101712 as a draft just to demonstrate
that backwards compatibility can be preserved if we split the features
(previously I thought it wasn't possible, but I found a way). However I
couldn't co
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/99620
>From 46ab5f809414b3f06ab9956e0fc6910284417b6d Mon Sep 17 00:00:00 2001
From: Nikita Popov
Date: Fri, 19 Jul 2024 11:02:56 +0200
Subject: [PATCH 1/3] [CVP] Infer range return attribute
We already infer this in IPSC
@@ -0,0 +1,163 @@
+; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o -
| FileCheck %s
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o -
-filetype=obj | spirv-val %}
+
+; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv32-unkno
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/109271
>From 6d541092e00f0c59861ad17c8bf6988d849c42f0 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 19 Sep 2024 11:41:51 +0100
Subject: [PATCH 1/2] [clang][CodeGen] Check initializer of zero-size fields
fo
@@ -1289,6 +1299,14 @@ static bool runImpl(Function &F, LazyValueInfo *LVI,
DominatorTree *DT,
FnChanged |= BBChanged;
}
+ // Infer range attribute on return value.
+ if (RetRange && !RetRange->isFullSet()) {
+Attribute RangeAttr = F.getRetAttribute(Attribute::Ran
@@ -766,8 +766,19 @@ static void EmitAtomicOp(CodeGenFunction &CGF, AtomicExpr
*Expr, Address Dest,
// LLVM atomic instructions always have synch scope. If clang atomic
// expression has no scope operand, use default LLVM synch scope.
if (!ScopeModel) {
+llvm::SyncSc
@@ -251,6 +251,24 @@ SPIRV::MemorySemantics::MemorySemantics
getMemSemantics(AtomicOrdering Ord) {
llvm_unreachable(nullptr);
}
+SPIRV::Scope::Scope getMemScope(const LLVMContext &Ctx, SyncScope::ID ID) {
VyacheslavLevytskyy wrote:
No problems, I'm quite h
Author: Nikita Popov
Date: 2024-09-20T14:29:19+02:00
New Revision: 3127b659fad358b135721bd937fead49e5c73de5
URL:
https://github.com/llvm/llvm-project/commit/3127b659fad358b135721bd937fead49e5c73de5
DIFF:
https://github.com/llvm/llvm-project/commit/3127b659fad358b135721bd937fead49e5c73de5.diff
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/108997
>From 10f74046b87f67a6efba1ee30806e73eea14007e Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Mon, 16 Sep 2024 08:59:45 -0400
Subject: [PATCH 1/2] [clang] Code owners -> Maintainers transition
This is
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/99620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AlexVlx created
https://github.com/llvm/llvm-project/pull/109415
This is primarily meant to address the issue identified in #109182, around
incorrect usage of `-fsycl-is-device`; we now have AMDGCN flavoured SPIR-V
which retains the desired behaviour around the default AS an
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Alex Voicu (AlexVlx)
Changes
This is primarily meant to address the issue identified in #109182,
around incorrect usage of `-fsycl-is-device`; we now have AMDGCN flavoured
SPIR-V which retains the desired behaviour around the default AS a
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Alex Voicu (AlexVlx)
Changes
This is primarily meant to address the issue identified in #109182,
around incorrect usage of `-fsycl-is-device`; we now have AMDGCN flavoured
SPIR-V which retains the desired behaviour around the defa
AaronBallman wrote:
> FWIW, I plan to land these changes tomorrow morning.
I lied. :-D I just emailed both Manuel and Michael privately and I want them to
have some time to consider and respond before landing the changes, but I did
make anticipatory changes.
https://github.com/llvm/llvm-proje
https://github.com/AlexVlx edited
https://github.com/llvm/llvm-project/pull/109415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AlexVlx wrote:
> > Ah, I remember now why the SYCL flag / mode was abused here (the default AS
> > Map for SPIR-V is problematic in this case); I believe that using the
> > `spirv64-amd-amdhsa` triple instead of `spirv64-unknown-unknown` will work,
> > and allow for the removal of the SYCL ref
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 2c90eb990af176f2b57baecd2920481243845bb9
75ca598c7e8a583545f50ee2c526556df261cc7f --e
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309
>From 511445e35376c904be454ed987786cb6faa70a81 Mon Sep 17 00:00:00 2001
From: Nikita Popov
Date: Thu, 19 Sep 2024 17:27:13 +0200
Subject: [PATCH] apint only
---
clang/lib/AST/ByteCode/IntegralAP.h | 6 +
https://github.com/AlexVlx updated
https://github.com/llvm/llvm-project/pull/109415
>From 75ca598c7e8a583545f50ee2c526556df261cc7f Mon Sep 17 00:00:00 2001
From: Alex Voicu
Date: Fri, 20 Sep 2024 13:25:49 +0100
Subject: [PATCH 1/2] Implement `getGlobalVarAddressSpace` for SPIR-V; stop
using SY
jplehr wrote:
I ran this through a buildbot config and found no errors.
https://github.com/llvm/llvm-project/pull/109152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fd21b7911fbdddc80db2d3971ff10ee70a49b7e3
b8f95b5b809cbeb8199de6cd24e18a605189f722 --e
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/109389
>From b8f95b5b809cbeb8199de6cd24e18a605189f722 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 19 Sep 2024 23:41:10 -0700
Subject: [PATCH 1/2] WebKit Checkers should set DeclWithIssue.
Set DeclWithIssue in
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/109389
Set DeclWithIssue in alpha.webkit.UncountedCallArgsChecker and
alpha.webkit.UncountedLocalVarsChecker.
>From b8f95b5b809cbeb8199de6cd24e18a605189f722 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 19 Sep
https://github.com/hokein edited
https://github.com/llvm/llvm-project/pull/109255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/109389
>From b8f95b5b809cbeb8199de6cd24e18a605189f722 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 19 Sep 2024 23:41:10 -0700
Subject: [PATCH 1/3] WebKit Checkers should set DeclWithIssue.
Set DeclWithIssue in
eddyz87 wrote:
@peilin-ye,
> I couldn't find a way to generate a better error message for
> `__ATOMIC_SEQ_CST`, however; it seems that CodeGen simply calls
> `CannotYetSelect()` if nothing in `MatcherTable` matches. Any suggestions?
There is probably some tablegen incantation to invoke custom
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/107906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
> The fix looks good. A test would be preferred.
Done
https://github.com/llvm/llvm-project/pull/109366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
i've also just noticed
https://github.com/llvm/llvm-project/commit/3b3accb598ec87a6a30b0e18ded06071030bb78f,
which seem to be pushed without review and any tests, changing behavior more
in a non-obvious way. Please not that logic you have in:
```
Expected FDOrErr = sys::fs::o
@@ -323,10 +325,11 @@ ErrorOr RealFileSystem::status(const Twine &Path)
{
}
ErrorOr>
-RealFileSystem::openFileForRead(const Twine &Name) {
+RealFileSystem::openFileForRead(const Twine &Name, bool IsText) {
SmallString<256> RealName, Storage;
Expected FDOrErr = sys::fs::
@@ -121,8 +121,18 @@ ContentCache::getBufferOrNone(DiagnosticsEngine &Diag,
FileManager &FM,
// Start with the assumption that the buffer is invalid to simplify early
// return paths.
IsBufferInvalid = true;
-
- auto BufferOrError = FM.getBufferForFile(*ContentsEntry, I
https://github.com/kadircet commented:
hi sorry for missing this during the review time, i believe this change is
changing some of the core support library interfaces in a way that's not
justified.
this is an interface implemented by quite a lot of both upstream and downstream
clients, but th
@@ -1806,7 +1806,7 @@ bool AMDGPUDAGToDAGISel::SelectGlobalSAddr(SDNode *N,
// instructions to perform VALU adds with immediates or inline literals.
unsigned NumLiterals =
!TII->isInlineConstant(APInt(32, COffsetVal & 0x)) +
- !TII->isInli
abhina-sree wrote:
> 3b3accb
Hi, sure I will revert the two changes so we can discuss further. The OF_Text
flag only affects the z/OS platform behaviour, the OF_TextWithCRLF will affect
z/OS and Windows. On other platforms, the flag doesn't show any difference in
behaviour that I'm aware of
Author: Abhina Sreeskantharajan
Date: 2024-09-20T08:18:16-04:00
New Revision: efdb3ae23247850d3886e3708400f0d991ed59e1
URL:
https://github.com/llvm/llvm-project/commit/efdb3ae23247850d3886e3708400f0d991ed59e1
DIFF:
https://github.com/llvm/llvm-project/commit/efdb3ae23247850d3886e3708400f0d991ed
Author: Abhina Sreeskantharajan
Date: 2024-09-20T08:18:16-04:00
New Revision: efdb3ae23247850d3886e3708400f0d991ed59e1
URL:
https://github.com/llvm/llvm-project/commit/efdb3ae23247850d3886e3708400f0d991ed59e1
DIFF:
https://github.com/llvm/llvm-project/commit/efdb3ae23247850d3886e3708400f0d991ed
Author: Abhina Sreeskantharajan
Date: 2024-09-20T08:17:45-04:00
New Revision: d6f91200fe95dbf30a091af3ba039a817e7ddf14
URL:
https://github.com/llvm/llvm-project/commit/d6f91200fe95dbf30a091af3ba039a817e7ddf14
DIFF:
https://github.com/llvm/llvm-project/commit/d6f91200fe95dbf30a091af3ba039a817e7d
arsenm wrote:
> @aeubanks It's not impossible to separate them completely. `MCContext` is
> needed during initialization and finalization of the
> `MachineModuleInfoWrapperPass` (and its new pass manager variant) to set the
> diagnostics handler.
>
> In theory, you can just pass the context t
https://github.com/ckandeler updated
https://github.com/llvm/llvm-project/pull/67802
>From 9dd725113a156a01f1866cfefe181c1b22f7e8d0 Mon Sep 17 00:00:00 2001
From: Christian Kandeler
Date: Fri, 29 Sep 2023 15:01:58 +0200
Subject: [PATCH] [clangd] Collect comments from function definitions into t
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Ryosuke Niwa (rniwa)
Changes
This PR fixes a bug in UncountedCallArgsChecker that calling a function with a
member variable which is Ref/RefPtr is erroneously treated as safe by
canoniclizing t
@@ -451,8 +451,17 @@ const RawComment *ASTContext::getRawCommentForAnyRedecl(
if (LastCheckedRedecl) {
if (LastCheckedRedecl == Redecl) {
LastCheckedRedecl = nullptr;
+continue;
ckandeler wrote:
Done.
https://github.com/llvm/llvm-pro
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/109393
This PR fixes a bug in UncountedCallArgsChecker that calling a function with a
member variable which is Ref/RefPtr is erroneously treated as safe by
canoniclizing the type before checking whether it's ref counted
https://github.com/svenvh approved this pull request.
https://github.com/llvm/llvm-project/pull/109372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -896,9 +896,8 @@ static void OCL2Qual(Sema &S, const OpenCLTypeStruct &Ty,
if (ImageTypesMap.contains(T->getValueAsString("Name")))
continue;
// Check we have not seen this Type
-if (TypesSeen.contains(T->getValueAsString("Name")))
+if (!TypesSeen.try_e
nikic wrote:
>From the last run:
```
Top 5 regressions:
verilator/V3WidthSel.cpp.ll 1476069359 1597049838 +8.20%
verilator/V3LinkResolve.cpp.ll 1301807129 1388286283 +6.64%
opencv/gscalar.cpp.ll 203273801 211586743 +4.09%
verilator/V3Clock.cpp.ll 734000737 758828622 +3.38%
verilator/V3W
@@ -267,3 +267,30 @@ namespace ns {}
void TestCallNonValue() {
[[clang::musttail]] return ns; // expected-error {{unexpected namespace name
'ns': expected expression}}
}
+
+// Test diagnostics for lifetimes of local variables, which end earlier for a
+// musttail call than f
@@ -58,7 +58,35 @@ class SPIRVTargetCodeGenInfo : public
CommonSPIRTargetCodeGenInfo {
SPIRVTargetCodeGenInfo(CodeGen::CodeGenTypes &CGT)
: CommonSPIRTargetCodeGenInfo(std::make_unique(CGT)) {}
void setCUDAKernelCallingConvention(const FunctionType *&FT) const overri
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Carlos Galvez (carlosgalvezp)
Changes
The example code doesn't compile otherwise.
---
Full diff: https://github.com/llvm/llvm-project/pull/109403.diff
9 Files Affected:
- (adde
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Carlos Galvez (carlosgalvezp)
Changes
The example code doesn't compile otherwise.
---
Full diff: https://github.com/llvm/llvm-project/pull/109403.diff
9 Files Affected:
- (added) cl
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/109366
>From f47b67c20014fbedc5ce9764be2e2687258a474e Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Thu, 19 Sep 2024 22:03:42 -0500
Subject: [PATCH] [AMDGPU] Correctly use the auxiliary toolchain to include
libc++
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/108949
>From 3601f708847f70485fae640c5b5d96fed965e7c3 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Tue, 17 Sep 2024 17:39:47 +0800
Subject: [PATCH 1/4] [clang][bytecode] Implement arithmetic, bitwise and
compound as
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Arseniy Zaostrovnykh (necto)
Changes
After 1595988ee6f9732e7ea79928af8a470ad5ef7dbe
diag::warn_undefined_reinterpret_cast started raising on non-instantiated
template functions without sufficient knowledge whether the reinterpret_cast is
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 57b12e8fbc9bb29ebe8f9d2a0f2c5085b38c2454
d792de91f9a01b927a274c83f0d2553ac06aa3cb --e
yronglin wrote:
Sure, added them to test. And regular binary operators works well.
https://github.com/llvm/llvm-project/pull/108949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,163 @@
+; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o -
| FileCheck %s
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o -
-filetype=obj | spirv-val %}
+
+; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv32-unkno
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/109422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -38,7 +38,9 @@ AST_MATCHER(Type, sugaredNullptrType) {
StatementMatcher makeCastSequenceMatcher(llvm::ArrayRef NameList) {
auto ImplicitCastToNull = implicitCastExpr(
anyOf(hasCastKind(CK_NullToPointer),
hasCastKind(CK_NullToMemberPointer)),
-
unless(hasImplic
@@ -1289,6 +1299,14 @@ static bool runImpl(Function &F, LazyValueInfo *LVI,
DominatorTree *DT,
FnChanged |= BBChanged;
}
+ // Infer range attribute on return value.
+ if (RetRange && !RetRange->isFullSet()) {
+Attribute RangeAttr = F.getRetAttribute(Attribute::Ran
@@ -58,7 +58,35 @@ class SPIRVTargetCodeGenInfo : public
CommonSPIRTargetCodeGenInfo {
SPIRVTargetCodeGenInfo(CodeGen::CodeGenTypes &CGT)
: CommonSPIRTargetCodeGenInfo(std::make_unique(CGT)) {}
void setCUDAKernelCallingConvention(const FunctionType *&FT) const overri
@@ -1,7 +1,7 @@
; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
--check-prefix=CHECK-SPIRV
; CHECK-SPIRV: %[[#Int:]] = OpTypeInt 32 0
-; CHECK-SPIRV-DAG: %[[#MemScope_Device:]] = OpConstant %[[#Int]] 1
+; CHECK-SPIRV-DAG: %[[#MemScope_AllSvmDevic
kadircet wrote:
thanks a lot for the swift response!
I can see how none of these implementations are not using those flags _today_,
but we're changing the observable behavior for them as well, and if some of
those implementations decides to give meaning to these flags, it might be
impossible
@@ -567,23 +567,28 @@ static bool checkArmStreamingBuiltin(Sema &S, CallExpr
*TheCall,
// * When compiling for SVE only, the caller must be in non-streaming mode.
// * When compiling for both SVE and SME, the caller can be in either mode.
if (BuiltinType == SemaARM::Veri
https://github.com/erichkeane commented:
Does this need a release note? Also, can you point out the 'diff' from the
previous commit?
I'm really not a fan of the 'out' parameter, I'd prefer perhaps returning a
`std::pair` + structured binding. WDYT?
https://github.com/llvm/llvm-project/pul
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/109422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -484,16 +484,19 @@ namespace N4 {
template
struct A {
void not_instantiated(A a, A b, T c) {
- a->x;
- b->x;
+ a->x; // expected-error {{member reference type 'A' is not a pointer;
did you mean to use '.'?}}
+ b->x; // expected-error {{member ref
@@ -8002,15 +7991,26 @@ ExprResult Sema::ActOnStartCXXMemberReference(Scope *S,
Expr *Base,
return ExprError();
}
+ bool IsDependent;
erichkeane wrote:
Please initialize this to false anyway.
https://github.com/llvm/llvm-project/pull/1094
@@ -10639,9 +10639,9 @@ class Sema final : public SemaBase {
/// BuildOverloadedArrowExpr - Build a call to an overloaded @c operator->
/// (if one exists), where @c Base is an expression of class type and
/// @c Member is the name of the member we're trying to find.
-
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Congcong Cai (HerrCai0907)
Changes
Detect by misc-use-internal-linkage
---
Full diff: https://github.com/llvm/llvm-project/pull/109431.diff
6 Files Affected:
- (modified) clang/lib/CodeGen/CGBuiltin.cpp (+2-2)
- (modified) cla
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/109431
Detect by misc-use-internal-linkage
>From cc42a41300c3acb202635902e6746061e09e7114 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 20 Sep 2024 22:27:28 +0800
Subject: [PATCH] [codegen][NFC] add stat
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Congcong Cai (HerrCai0907)
Changes
Detect by misc-use-internal-linkage
---
Full diff: https://github.com/llvm/llvm-project/pull/109431.diff
6 Files Affected:
- (modified) clang/lib/CodeGen/CGBuiltin.cpp (+2-2)
- (modified) clang/lib/C
@@ -11392,9 +11392,9 @@ class Sema final : public SemaBase {
CXXScopeSpec &SS, IdentifierInfo *Name, SourceLocation NameLoc,
const ParsedAttributesView &Attr, TemplateParameterList *TemplateParams,
AccessSpecifier AS, SourceLocation ModulePrivateLoc,
- So
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/106585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/necto created
https://github.com/llvm/llvm-project/pull/109430
After 1595988ee6f9732e7ea79928af8a470ad5ef7dbe
diag::warn_undefined_reinterpret_cast started raising on non-instantiated
template functions without sufficient knowledge whether the reinterpret_cast is
indeed UB.
https://github.com/smanna12 created
https://github.com/llvm/llvm-project/pull/109428
Class clang::Parser::LateParsedClass owns resources that are freed in its
destructor but has no user-written assignment operator.
This commit explicitly deletes the copy constructor and copy assignment
operato
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
Class clang::Parser::LateParsedClass owns resources that are freed in its
destructor but has no user-written assignment operator.
This commit explicitly deletes the copy constructor and copy assignment
operator for
https://github.com/smanna12 updated
https://github.com/llvm/llvm-project/pull/109428
>From d792de91f9a01b927a274c83f0d2553ac06aa3cb Mon Sep 17 00:00:00 2001
From: "Manna, Soumi"
Date: Fri, 20 Sep 2024 07:07:46 -0700
Subject: [PATCH 1/2] [Clang] Prevent Copying of LateParsedClass Instances
---
https://github.com/paulwalker-arm edited
https://github.com/llvm/llvm-project/pull/109420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -53,6 +53,7 @@ class MultiplexConsumer : public SemaConsumer {
public:
// Takes ownership of the pointers in C.
MultiplexConsumer(std::vector> C);
+ MultiplexConsumer(std::unique_ptr C);
vgvassilev wrote:
Surprisingly we can’t do this unfortunately htt
https://github.com/erichkeane approved this pull request.
1 comment, otherwise LGTM.
https://github.com/llvm/llvm-project/pull/106585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -738,7 +738,7 @@ bool ConstStructBuilder::Build(const InitListExpr *ILE,
bool AllowOverwrite) {
// Zero-sized fields are not emitted, but their initializers may still
// prevent emission of this struct as a constant.
if (isEmptyFieldForLayout(CGM.getContext(), F
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/109431
>From d6eae7c4543e081f3a7d2e8bd33d11082c7e06cb Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 20 Sep 2024 22:27:28 +0800
Subject: [PATCH] [codegen][NFC] add static mark for internal usage variable
a
abhina-sree wrote:
> thanks a lot for the swift response!
>
> I can see how none of these implementations are not using those flags
> _today_, but we're changing the observable behavior for them as well, and if
> some of those implementations decides to give meaning to these flags, it
> might
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9c5ad62e7440423fbcd2d84c8f0347a5f000400e
d6eae7c4543e081f3a7d2e8bd33d11082c7e06cb --e
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/109431
>From fdca1726b8fe9d60407e48426a513eebb81a710e Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 20 Sep 2024 22:27:28 +0800
Subject: [PATCH] [codegen][NFC] add static mark for internal usage variable
a
kovdan01 wrote:
> I think you should be able to avoid constructing the initializer twice if you
> restructure the code a bit to just construct the global before the call to
> BuildVTablePointer. I added GlobalVariable::replaceInitializer because I was
> looking at this review: it lets you cons
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/109302
>From cc2c798193722b3a537c76e74981ff767d064efa Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 19 Sep 2024 23:46:16 +0800
Subject: [PATCH 1/3] [clang-tidy][bugprone-posix-return] support integer
lite
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5e3d48a68096a0017a0fa4bb89f2d48767c8a7e4
b42278e592a9d64ba6868ee6eb5663cb8306e16b --e
https://github.com/rmaz approved this pull request.
https://github.com/llvm/llvm-project/pull/109375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/109302
>From cc2c798193722b3a537c76e74981ff767d064efa Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 19 Sep 2024 23:46:16 +0800
Subject: [PATCH 1/2] [clang-tidy][bugprone-posix-return] support integer
lite
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/109431
>From fdca1726b8fe9d60407e48426a513eebb81a710e Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 20 Sep 2024 22:27:28 +0800
Subject: [PATCH 1/2] [codegen][NFC] add static mark for internal usage
variab
satmandu wrote:
Worth noting that this affects mesa too:
https://gitlab.freedesktop.org/mesa/mesa/-/issues/11896
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
jayfoad wrote:
> Although, revisiting this now, I still don't understand why they decided to
> include ALL spill opcodes in the prologue, but not only the SGPR spills?
> Clearly, none of the VGPR reloads really belong to the prologue.
>
> At a first glance, changing the isSpill(opcode) to isSG
https://github.com/tahonermann approved this pull request.
Looks good to me. Thanks @smanna12!
https://github.com/llvm/llvm-project/pull/109428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: Kazu Hirata
Date: 2024-09-20T07:57:49-07:00
New Revision: 78768c52a0e5d9915ee75a190b07114c174ff8cb
URL:
https://github.com/llvm/llvm-project/commit/78768c52a0e5d9915ee75a190b07114c174ff8cb
DIFF:
https://github.com/llvm/llvm-project/commit/78768c52a0e5d9915ee75a190b07114c174ff8cb.diff
L
101 - 200 of 473 matches
Mail list logo
