[clang] [clang][powerpc][wasm][systemz][x86] Replace target vector popcount intrinsics with __builtin_elementwise_popcount (PR #109160)

2024-09-18 Thread Phoebe Wang via cfe-commits
@@ -23,7 +23,7 @@ static __inline__ __m512i __DEFAULT_FN_ATTRS _mm512_popcnt_epi16(__m512i __A) { - return (__m512i) __builtin_ia32_vpopcntw_512((__v32hi) __A); + return (__m512i)__builtin_elementwise_popcount((__v32hi)__A); phoebewang wrote: hi or hu? The s

[clang] [clang-format] Annotate the l_paren of function pointer types (PR #109229)

2024-09-18 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/109229 Fixes #109146. >From 84c166dfabc3f314cd922baa3933b3d0ea11e08e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 18 Sep 2024 21:03:24 -0700 Subject: [PATCH] [clang-format] Annotate the l_paren of function pointe

[clang] [clang-format] Annotate the l_paren of function pointer types (PR #109229)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #109146. --- Full diff: https://github.com/llvm/llvm-project/pull/109229.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+8-6) - (modified) clang/unittests/Format/TokenAnn

[clang] [clang-format] Fix a bug in annotating StartOfName (PR #99791)

2024-09-18 Thread Owen Pan via cfe-commits
owenca wrote: Wouldn't you have the same problem if we were to backport the fix, say, to 18.1.9? Anyway, LLVM 19.1.0 has just been released. https://github.com/llvm/llvm-project/pull/99791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang-tools-extra] [clang-tidy][NFC] add qutation mark for C++ classes in warning message (PR #109068)

2024-09-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/109068 >From 66be189c281db7a49c5238c2fe09df64842c1e25 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 17 Sep 2024 23:01:17 +0800 Subject: [PATCH 1/2] add quotation --- .../modernize/AvoidCArraysCheck.cpp

[clang-tools-extra] [clang-tidy] insert ``static`` keyword in correct position for misc-use-internal-linkage (PR #108792)

2024-09-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/108792 >From 795b3ae677210ff50f7710a0cf73d435889b68ae Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 16 Sep 2024 13:47:10 +0800 Subject: [PATCH] [clang-tidy] insert ``static`` keyword in correct position f

[clang] [C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #109167)

2024-09-18 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Would you like to explain more why this fail previously in more detail? Also I am thinking if we can make the process more efficiently: (1) Can we avoid the visitor in the writing process? (2) Can we delay the loading of lambdas to the load of definitions of the functions? I

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-18 Thread Chuanqi Xu via cfe-commits
@@ -462,6 +462,33 @@ Currently, Clang accepts the above example, though it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` in other translation units. +Source Files Consistency + + +Clang may open the input

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-18 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,2 @@ +// RUN: %clang -std=c++20 %s -fmodules-embed-all-files -### 2>&1 | FileCheck %s ChuanqiXu9 wrote: Done https://github.com/llvm/llvm-project/pull/107194 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-18 Thread Chuanqi Xu via cfe-commits
@@ -484,6 +511,13 @@ fragment is disabled by default. These checks can be enabled by specifying and you encounter incorrect or missing diagnostics, please report them via the `community issue tracker `_. +Privacy Issue +--

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-18 Thread Chuanqi Xu via cfe-commits
@@ -462,6 +462,33 @@ Currently, Clang accepts the above example, though it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` in other translation units. +Source Files Consistency + + +Clang may open the input

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-18 Thread Chuanqi Xu via cfe-commits
@@ -462,6 +462,33 @@ Currently, Clang accepts the above example, though it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` in other translation units. +Source Files Consistency + + +Clang may open the input

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-18 Thread Chuanqi Xu via cfe-commits
@@ -462,6 +462,33 @@ Currently, Clang accepts the above example, though it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` in other translation units. +Source Files Consistency + + +Clang may open the input

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/107194 >From f18b50fb6ae778ac9b4ddaee4029d54f859c50f9 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Wed, 4 Sep 2024 16:02:53 +0800 Subject: [PATCH 1/2] [C++20] [Modules] Offer -fmodules-embed-all-files option See

[clang] [clang-format] Fix regression in BAS_AlwaysBreak for-await (PR #108634)

2024-09-18 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/108634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c9aa9d5 - [clang-format] Fix regression in BAS_AlwaysBreak for-await (#108634)

2024-09-18 Thread via cfe-commits
Author: Gedare Bloom Date: 2024-09-18T19:44:09-07:00 New Revision: c9aa9d53b6f92d9780430ab8239ea9117574c95d URL: https://github.com/llvm/llvm-project/commit/c9aa9d53b6f92d9780430ab8239ea9117574c95d DIFF: https://github.com/llvm/llvm-project/commit/c9aa9d53b6f92d9780430ab8239ea9117574c95d.diff

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/107194 >From f18b50fb6ae778ac9b4ddaee4029d54f859c50f9 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Wed, 4 Sep 2024 16:02:53 +0800 Subject: [PATCH 1/3] [C++20] [Modules] Offer -fmodules-embed-all-files option See

[clang] [NFC] Delete unused clang-formatted-files.txt file (PR #109220)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Looks like this file is generated by the `generate_formatted_state.py` script in the same directory. So it seems this was committed to the repo inadvertently. --- Patch is 408.98 KiB, truncated to 20.00 KiB

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw requested changes to this pull request. Reproducer: ``` ; bin/opt -passes=inline reduced.ll -S target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128" target triple = "x86_64-unknown-linux-gnu" define i64 @caller(ptr %p1,

[clang] [NFC] Delete unused clang-formatted-files.txt file (PR #109220)

2024-09-18 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/107194 >From f18b50fb6ae778ac9b4ddaee4029d54f859c50f9 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Wed, 4 Sep 2024 16:02:53 +0800 Subject: [PATCH 1/4] [C++20] [Modules] Offer -fmodules-embed-all-files option See

[clang] [AST] Iterate redecls starting from the canonical one in getRawCommentsForAnyRedecl() (PR #108475)

2024-09-18 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/108475 >From 1df905728da591bae0acf231e2d7c1f7492d43f3 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 10 Sep 2024 22:34:55 -0400 Subject: [PATCH] [AST] Ensure getRawCommentsForAnyRedecl() does not miss an

[clang] [AST] Iterate redecls starting from the canonical one in getRawCommentsForAnyRedecl() (PR #108475)

2024-09-18 Thread Nathan Ridge via cfe-commits
@@ -444,7 +444,7 @@ const RawComment *ASTContext::getRawCommentForAnyRedecl( return CommentlessRedeclChains.lookup(CanonicalD); }(); - for (const auto Redecl : D->redecls()) { + for (const auto Redecl : CanonicalD->redecls()) { HighCommander4 wrote: T

[clang] [clang][Sema] Fix assertion in `tryDiagnoseOverloadedCast` (PR #108021)

2024-09-18 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource updated https://github.com/llvm/llvm-project/pull/108021 From b414b6e184fc566efd6a2dbe631ee68a25b461a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?= Date: Fri, 16 Jun 2023 18:01:33 +0200 Subject: [PATCH 1/3] [

[clang] [Clang] Propagate elide safe context through [[clang::coro_await_elidable_argument]] (PR #108474)

2024-09-18 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-qemu` running on `sanitizer-buildbot3` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/139/builds/3883 Here is the relevant piece o

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-09-18 Thread Alexander Kornienko via cfe-commits
alexfh wrote: I looked at the original code and found a much more involved expression there (https://gitlab.com/libeigen/eigen/-/blob/master/Eigen/src/Core/util/ForwardDeclarations.h?ref_type=heads#L66), so the parenthesized expression is merely an artifact of reduction and there doesn't seem

[clang] [clang-tools-extra] Remove clang-pseudo (PR #109154)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes The functionality is incomplete and the authors have since shifted gears to other work, so this is effectively unmaintained. The original design document for clang-pseudo can be found at: https://docs.

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-09-18 Thread Kyungwoo Lee via cfe-commits
@@ -164,6 +164,22 @@ publishOutlinedHashTree(std::unique_ptr HashTree) { CodeGenData::getInstance().publishOutlinedHashTree(std::move(HashTree)); } +/// Initialize the two-codegen rounds. +void initializeTwoCodegenRounds(); + +/// Save the current module before the first co

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-09-18 Thread Kyungwoo Lee via cfe-commits
kyulee-com wrote: > Oh I just saw that you have dependent changes in #90934. I think when you > create your PR, you can specify a base branch. If you select the branch for > #90934, I believe it won't show those changes in this PR. I'm not sure if you > can do that after you've created the PR,

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-09-18 Thread Nikita Popov via cfe-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/100757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-18 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/108786 >From 7b6a66d635fdb522d6fe0046157971f9d5112982 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 17 Sep 2024 21:47:45 -0400 Subject: [PATCH] [IR] Introduce `T` to `DataLayout` to represent flat address spa

[clang] [Clang] Automatically link the `compiler-rt` for GPUs if present (PR #109152)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: This automically links `copmiler-rt` for offloading languages if it exists in the resource directory. --- Full diff: https://github.com/llvm/llvm-project/pull/10915

[clang] [Clang] Automatically link the `compiler-rt` for GPUs if present (PR #109152)

2024-09-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/109152 Summary: This automically links `copmiler-rt` for offloading languages if it exists in the resource directory. >From b6f6cbf7e1819779eeece437daef5bfb9b2a8cd0 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: W

[clang] [libc] [libcxx] [Clang] Do not implicitly link C libraries for the GPU targets (PR #109052)

2024-09-18 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang,libc,libcxx` at step 10 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/5724 H

[clang] 67518a4 - [HLSL] Implement elementwise popcount (#108121)

2024-09-18 Thread via cfe-commits
Author: Sarah Spall Date: 2024-09-18T08:19:52-07:00 New Revision: 67518a44fec0f59b2f926059cf15ec77ec72da13 URL: https://github.com/llvm/llvm-project/commit/67518a44fec0f59b2f926059cf15ec77ec72da13 DIFF: https://github.com/llvm/llvm-project/commit/67518a44fec0f59b2f926059cf15ec77ec72da13.diff L

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-18 Thread Sarah Spall via cfe-commits
https://github.com/spall closed https://github.com/llvm/llvm-project/pull/108121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOptions.def (PR #108804)

2024-09-18 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108804 >From 43e6c22f25f419b64678374dd247eaf8bc28fa57 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Mon, 16 Sep 2024 09:50:33 +0530 Subject: [PATCH 01/12] [clang] Increase VecLib bitfield size to 4 bits in CodeGen

[clang] [clang-tools-extra] [flang] Fix OOM in FormatDiagnostic (2nd attempt) (PR #108866)

2024-09-18 Thread Vakhurin Sergei via cfe-commits
igelbox wrote: Well, the more it waits the bigger a probability it will have logical conflicts after merging into `main`. https://github.com/llvm/llvm-project/pull/108866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [clang-tools-extra] Remove clang-pseudo (PR #109154)

2024-09-18 Thread Aaron Ballman via cfe-commits
@@ -181,16 +181,16 @@ llvm::Expected> getFoldingRanges(ParsedAST &AST) { // Related issue: https://github.com/clangd/clangd/issues/310 llvm::Expected> getFoldingRanges(const std::string &Code, bool LineFoldingOnly) { AaronBallman wrote: I don't have strong op

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2024-09-18 Thread Oliver Hunt via cfe-commits
ojhunt wrote: LGTM https://github.com/llvm/llvm-project/pull/109056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #109167)

2024-09-18 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin created https://github.com/llvm/llvm-project/pull/109167 Summary: Because AST loading code is lazy and happens in unpredictable order, it is possible that a function and lambda inside the function can be loaded from different modules. As a result, the captured Dec

[clang] [C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #109167)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: Dmitry Polukhin (dmpolukhin) Changes Summary: Because AST loading code is lazy and happens in unpredictable order, it is possible that a function and lambda inside the function can be loaded from differe

[clang] [clang][powerpc][wasm][systemz][x86] Replace target vector popcount intrinsics with __builtin_elementwise_popcount (PR #109160)

2024-09-18 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon updated https://github.com/llvm/llvm-project/pull/109160 >From dcbe496df1ce109167e07136d2a7e8f65232f812 Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Thu, 12 Sep 2024 10:39:26 +0100 Subject: [PATCH] [clang][powerpc][wasm][systemz][x86] Replace target vector popc

[clang] [Clang][TableGen] Support specifying address space in clang builtin prototypes (PR #108497)

2024-09-18 Thread Vikram Hegde via cfe-commits
vikramRH wrote: > > Gentle ping @AaronBallman , @philnik777 , @fpetrogalli :) > > Ah, sorry -- because the PR is marked as a Draft, I figured it wasn't ready > for review yet. > > I think I'd rather this was expressed differently; we already don't put > attribute information in the prototype

[clang] [llvm] riscv: Support -mstack-protector-guard=tls (PR #108942)

2024-09-18 Thread Keith Packard via cfe-commits
https://github.com/keith-packard edited https://github.com/llvm/llvm-project/pull/108942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2e3c7db - [analyzer] Note last "fclose" call from "ensureStreamOpened" (#109112)

2024-09-18 Thread via cfe-commits
Author: Balazs Benics Date: 2024-09-18T12:22:02+02:00 New Revision: 2e3c7dbbcbfa37ae83251bb3da388df772680689 URL: https://github.com/llvm/llvm-project/commit/2e3c7dbbcbfa37ae83251bb3da388df772680689 DIFF: https://github.com/llvm/llvm-project/commit/2e3c7dbbcbfa37ae83251bb3da388df772680689.diff

[clang] [analyzer] Note last "fclose" call from "ensureStreamOpened" (PR #109112)

2024-09-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/109112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-09-18 Thread Nikita Popov via cfe-commits
@@ -9800,3 +9817,45 @@ SDValue SystemZTargetLowering::lowerVECREDUCE_ADD(SDValue Op, ISD::EXTRACT_VECTOR_ELT, DL, VT, DAG.getBitcast(OpVT, Op), DAG.getConstant(OpVT.getVectorNumElements() - 1, DL, MVT::i32)); } + +// Only consider a function fully internal as long

[clang] [clang-tools-extra] [clang-tidy] Fix performance-unnecessary-value-param (PR #109145)

2024-09-18 Thread Nikita Popov via cfe-commits
@@ -118,10 +118,19 @@ class FunctionParmMutationAnalyzer { static FunctionParmMutationAnalyzer * getFunctionParmMutationAnalyzer(const FunctionDecl &Func, ASTContext &Context, ExprMutationAnalyzer::Memoized &Memorized) { -auto [it, Ins

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-09-18 Thread Nikita Popov via cfe-commits
@@ -1185,6 +1189,9 @@ Currently, only the following parameter attributes are defined: value should be sign-extended to the extent required by the target's ABI (which is usually 32-bits) by the caller (for a parameter) or the callee (for a return value). +``noext``

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-09-18 Thread Nikita Popov via cfe-commits
@@ -9800,3 +9817,45 @@ SDValue SystemZTargetLowering::lowerVECREDUCE_ADD(SDValue Op, ISD::EXTRACT_VECTOR_ELT, DL, VT, DAG.getBitcast(OpVT, Op), DAG.getConstant(OpVT.getVectorNumElements() - 1, DL, MVT::i32)); } + +// Only consider a function fully internal as long

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-09-18 Thread Nikita Popov via cfe-commits
@@ -1185,6 +1189,9 @@ Currently, only the following parameter attributes are defined: value should be sign-extended to the extent required by the target's ABI (which is usually 32-bits) by the caller (for a parameter) or the callee (for a return value). +``noext``

[clang] [clang-tools-extra] [llvm] Remove clang-rename (PR #108988)

2024-09-18 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang-tools-extra,clang,llvm,utils` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/bui

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-09-18 Thread Nikita Popov via cfe-commits
https://github.com/nikic commented: Looks good to me with some nits. In particular LangRef could be clearer on the purpose of the attribute. https://github.com/llvm/llvm-project/pull/100757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [clang-tools-extra] [clang-tidy] Fix performance-unnecessary-value-param (PR #109145)

2024-09-18 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. The code change looks good to me, but not familiar with clang-tidy testing. https://github.com/llvm/llvm-project/pull/109145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [clang-tools-extra] [clang-tidy] Fix performance-unnecessary-value-param (PR #109145)

2024-09-18 Thread Nikita Popov via cfe-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/109145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOptions.def (PR #108804)

2024-09-18 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108804 >From 43e6c22f25f419b64678374dd247eaf8bc28fa57 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Mon, 16 Sep 2024 09:50:33 +0530 Subject: [PATCH 1/9] [clang] Increase VecLib bitfield size to 4 bits in CodeGenOp

[clang-tools-extra] issue-63565: community requested small QoL fix for more configurabili… (PR #108005)

2024-09-18 Thread via cfe-commits
https://github.com/MK-Alias updated https://github.com/llvm/llvm-project/pull/108005 >From 4e9cbd615c56604fbc3c05f677b9da11f30977a2 Mon Sep 17 00:00:00 2001 From: MK-Alias Date: Tue, 10 Sep 2024 13:24:46 +0200 Subject: [PATCH 1/5] issue-63565: community requested small QoL fix for more configu

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-09-18 Thread Michael Toguchi via cfe-commits
@@ -5116,15 +5123,39 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, if (const Arg *PF = Args.getLastArg(options::OPT_mprintf_kind_EQ)) PF->claim(); - if (Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false)) { + Arg *SYCLStdArg = Args.getLa

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-18 Thread Erich Keane via cfe-commits
@@ -484,6 +511,13 @@ fragment is disabled by default. These checks can be enabled by specifying and you encounter incorrect or missing diagnostics, please report them via the `community issue tracker `_. +Privacy Issue +--

[clang] [clang-tools-extra] [clang-tidy] Fix performance-unnecessary-value-param (PR #109145)

2024-09-18 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: This test is passing for me even when I revert `ExprMutationAnalyzer.h` changes. Is it standard library or setup specific? https://github.com/llvm/llvm-project/pull/109145 ___ cfe-commits mailing list

[clang] [clang-tools-extra] [clang-tidy] Fix performance-unnecessary-value-param (PR #109145)

2024-09-18 Thread Congcong Cai via cfe-commits
@@ -118,10 +118,19 @@ class FunctionParmMutationAnalyzer { static FunctionParmMutationAnalyzer * getFunctionParmMutationAnalyzer(const FunctionDecl &Func, ASTContext &Context, ExprMutationAnalyzer::Memoized &Memorized) { -auto [it, Ins

[clang] [clang-tools-extra] [clang-tidy] Fix performance-unnecessary-value-param (PR #109145)

2024-09-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/109145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy] Fix performance-unnecessary-value-param (PR #109145)

2024-09-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM. The comment is a little bit hard to understand. maybe you can sort out the wording. https://github.com/llvm/llvm-project/pull/109145 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] -ast-dump-decl-types crashes on codes involving concepts #94928 (PR #108142)

2024-09-18 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Also, please add the example code from the linked issue to > > `ast-dump-concepts.cpp` so that we more clearly demonstrate that the issue > > was fixed. > > Hi @AaronBallman The example code provided by @zyn0217 has already in the > `ast-dump-concepts.cpp`. Ah, I miss

[clang] -ast-dump-decl-types crashes on codes involving concepts #94928 (PR #108142)

2024-09-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/108142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] Fix OOM in FormatDiagnostic (2nd attempt) (PR #108866)

2024-09-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Thank you! I think this fixes everything caught by post-commit, so let's re-land. https://github.com/llvm/llvm-project/pull/108866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] eda72fa - Fix OOM in FormatDiagnostic (2nd attempt) (#108866)

2024-09-18 Thread via cfe-commits
Author: Vakhurin Sergei Date: 2024-09-18T11:46:25-04:00 New Revision: eda72fac548f317cec997967494763e9a7bafa27 URL: https://github.com/llvm/llvm-project/commit/eda72fac548f317cec997967494763e9a7bafa27 DIFF: https://github.com/llvm/llvm-project/commit/eda72fac548f317cec997967494763e9a7bafa27.dif

[clang] [clang-tools-extra] [flang] Fix OOM in FormatDiagnostic (2nd attempt) (PR #108866)

2024-09-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/108866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy] Fix performance-unnecessary-value-param (PR #109145)

2024-09-18 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/109145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-systemz Author: Jonas Paulsson (JonPsson1) Changes Make sure that fp16<=>float conversions are expanded to libcalls and that 16-bit fp values can be loaded and stored properly via GPRs. With this patch the Half IR Type used in operations should

[clang] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jonas Paulsson (JonPsson1) Changes Make sure that fp16<=>float conversions are expanded to libcalls and that 16-bit fp values can be loaded and stored properly via GPRs. With this patch the Half IR Type used in operations should be handle

[clang] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2024-09-18 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 created https://github.com/llvm/llvm-project/pull/109164 Make sure that fp16<=>float conversions are expanded to libcalls and that 16-bit fp values can be loaded and stored properly via GPRs. With this patch the Half IR Type used in operations should be handled cor

[clang] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2024-09-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8411214c56eb3f9fb77fe3a9f156d4e6ef6cec06 e0bb2adac31f9bec6fa1521a5f9fd67ce7442e14 --e

[clang] [clang-tools-extra] Remove clang-pseudo (PR #109154)

2024-09-18 Thread via cfe-commits
cor3ntin wrote: Thanks for doing that Aaron. LGTM on the clang side of things (and it does what the rfc proposed) - but I'll let a clangd maintainer approve. I was really excited by the pseudo parser as I think it would have been a very useful tool with many use cases. However, since the RFC w

[clang] [clang][powerpc][wasm][systemz][x86] Replace target vector popcount intrinsics with __builtin_elementwise_popcount (PR #109160)

2024-09-18 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon updated https://github.com/llvm/llvm-project/pull/109160 >From aee207dd6246128e3f532cbf9b36f4ea9b5a1a5a Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Thu, 12 Sep 2024 10:39:26 +0100 Subject: [PATCH] [clang][powerpc][wasm][systemz][x86] Replace target vector popc

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tarun Prabhu (tarunprabhu) Changes The -time option prints timing information for the subcommands (compiler, linker) in a format similar to that used by gcc/gfortran (we use more digits of precision). This partially addresses requests fr

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-09-18 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu created https://github.com/llvm/llvm-project/pull/109165 The -time option prints timing information for the subcommands (compiler, linker) in a format similar to that used by gcc/gfortran (we use more digits of precision). This partially addresses requests from

[clang] [clang][NFC] Add regression tests for GH63782 (PR #109104)

2024-09-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/109104 Patch by Alejandro Alvarez Ayllon! CPP-5380 >From f495ed375b0581d475e13636e201cef57718d127 Mon Sep 17 00:00:00 2001 From: Alejandro _lvarez Ayll_n Date: Wed, 18 Sep 2024 10:58:03 +0200 Subject: [PATCH] [clang

[clang] [clang][NFC] Add regression tests for GH63782 (PR #109104)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes Patch by Alejandro Alvarez Ayllon! CPP-5380 --- Full diff: https://github.com/llvm/llvm-project/pull/109104.diff 1 Files Affected: - (modified) clang/test/SemaTemplate/concepts-out-of-line-def.cpp (+44)

[clang] [clang-tools-extra] [llvm] [Clang] Add __builtin_type_pack_dedup template to deduplicate types in template arguments (PR #106730)

2024-09-18 Thread Ilya Biryukov via cfe-commits
@@ -3158,6 +3161,33 @@ checkBuiltinTemplateIdType(Sema &SemaRef, BuiltinTemplateDecl *BTD, int64_t N = Index.getExtValue(); return Ts.getPackAsArray()[N].getAsType(); } + case BTK__type_pack_dedup: { +assert(Converted.size() == 2 && "__builtin_type_pack_dedup sh

[clang] [analyzer] Note last "fclose" call from "ensureStreamOpened" (PR #109112)

2024-09-18 Thread Donát Nagy via cfe-commits
@@ -1849,11 +1889,12 @@ ProgramStateRef StreamChecker::ensureStreamOpened(SVal StreamVal, if (SS->isClosed()) { // Using a stream pointer after 'fclose' causes undefined behavior // according to cppreference.com . -ExplodedNode *N = C.generateErrorNode(); -if

[clang] [analyzer] Note last "fclose" call from "ensureStreamOpened" (PR #109112)

2024-09-18 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. I like this improvement :smile:, thanks for implementing it! The code that you added LGTM, my only concern is the awkward warning message which was inherited from the earlier state of the codebase. I think it would be nice to slip in an

[clang] [analyzer] Note last "fclose" call from "ensureStreamOpened" (PR #109112)

2024-09-18 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/109112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Split FeatureLS64 to LS64_ACCDATA and LS64_V. (PR #101712)

2024-09-18 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/101712 >From 2fe8ef63846989952a1c72b83114aabe6f36637a Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Fri, 2 Aug 2024 17:32:23 +0100 Subject: [PATCH] [AArch64] Split FeatureLS64 to LS64_ACCDATA and LS64_V.

[clang] [analyzer] Note last "fclose" call from "ensureStreamOpened" (PR #109112)

2024-09-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/109112 >From 408ee82b1ee3ae15302b2a0dde9faded3e43bf0f Mon Sep 17 00:00:00 2001 From: Arseniy Zaostrovnykh Date: Wed, 18 Sep 2024 11:30:10 +0200 Subject: [PATCH 1/2] [analyzer] Note last "fclose" call from "ensureStre

[clang] [clang][NFC] Remove trailing spaces from Sema diag messages (PR #109098)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109098.diff 1 Files Affected: - (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+3-3) ``diff diff --git a/clang/include/c

[clang] [llvm] [X86][AVX10.2] Support AVX10.2 MOVZXC new Instructions. (PR #108537)

2024-09-18 Thread via cfe-commits
https://github.com/mahesh-attarde updated https://github.com/llvm/llvm-project/pull/108537 >From 71bbd1b23ed363517327a32f9aa92264866f143a Mon Sep 17 00:00:00 2001 From: mattarde Date: Fri, 13 Sep 2024 03:26:14 -0700 Subject: [PATCH 1/6] update clr --- clang/lib/Headers/CMakeLists.txt

[clang] [analyzer] Indicate UnarySymExpr is not supported by Z3 (PR #108900)

2024-09-18 Thread Balazs Benics via cfe-commits
steakhal wrote: I'm okay with the PR, but this leaves me wonder how did you end up with this crash? How did you manage to avoid all the zillion other ways to crash the Z3 solver? Have you experienced such issues? https://github.com/llvm/llvm-project/pull/108900

[clang] [clang][codegen] Don't mark "int" TBAA on FP libcalls with indirect args (PR #108853)

2024-09-18 Thread Matt Arsenault via cfe-commits
@@ -690,23 +690,46 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, const CallExpr *E, llvm::Constant *calleeValue) { CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, E); CGCallee callee = CGCallee::forDirect(call

[clang-tools-extra] 11b95de - [clang-tidy][NFC] fix typo in clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

2024-09-18 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2024-09-18T21:51:14+08:00 New Revision: 11b95deab9a00d53e94a089b5d4bf3c05e5d5370 URL: https://github.com/llvm/llvm-project/commit/11b95deab9a00d53e94a089b5d4bf3c05e5d5370 DIFF: https://github.com/llvm/llvm-project/commit/11b95deab9a00d53e94a089b5d4bf3c05e5d5370.diff

[clang] [clang][codegen] Don't mark "int" TBAA on FP libcalls with indirect args (PR #108853)

2024-09-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam approved this pull request. https://github.com/llvm/llvm-project/pull/108853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][codegen] Don't mark "int" TBAA on FP libcalls with indirect args (PR #108853)

2024-09-18 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: OK. This LGTM. I guess we can adopt this PR instead of https://github.com/llvm/llvm-project/pull/107598 unless other reviewers have more to say. https://github.com/llvm/llvm-project/pull/108853 ___ cfe-commits mailing list cfe-commit

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-18 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: This is a duplicate solution of https://github.com/llvm/llvm-project/pull/108853. Closing it if no objection from reviewers. https://github.com/llvm/llvm-project/pull/107598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [clang-tools-extra] [clang-tidy] Fix performance-unnecessary-value-param (PR #109145)

2024-09-18 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/109145 This patch essentially reverts #108674 while adding a testcase that triggers a crash in clang-tidy. Fixes #108963. >From c230f7e30e60f11c5675ec1dd9f49f5f6378dc6f Mon Sep 17 00:00:00 2001 From: Kazu Hira

[clang] [clang-tools-extra] [clang-tidy] Fix performance-unnecessary-value-param (PR #109145)

2024-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes This patch essentially reverts #108674 while adding a testcase that triggers a crash in clang-tidy. Fixes #108963. --- Full diff: https://github.com/llvm/llvm-project/pull/109145.diff 2 Files Affect

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-18 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/107521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-18 Thread Shilei Tian via cfe-commits
shiltian wrote: > Would it be possible to update the SPIR-V DataLayout(s) as well please? > Caveat, those targets use 4 to denote Flat/Generic, see e.g. > [here](https://github.com/llvm/llvm-project/blob/47c3df2a7fcdfb33064d4d5e7d82dde1ea379023/llvm/lib/Target/SPIRV/SPIRVUtils.cpp#L176) > and

[clang] [clang-tools-extra] [flang] Fix OOM in FormatDiagnostic (2nd attempt) (PR #108866)

2024-09-18 Thread Vakhurin Sergei via cfe-commits
igelbox wrote: 30 of 31, this time is much closer) https://github.com/user-attachments/assets/de806772-30df-42bd-9928-19bad35dca02";> it seems like [those](https://lab.llvm.org/buildbot/#/builders/73) builds were broken a couple hours ago: https://github.com/user-attachments/assets/c375276a-d3a

[clang] Reland "[Utils] add update-verify-tests.py" (#108630)" (PR #108658)

2024-09-18 Thread Erich Keane via cfe-commits
erichkeane wrote: >I don't know the solution, but I think there is some inherent flaw when it >comes to how -verify tests operate currently, in that you need to trust that >the author formatted the test to accurately reflect reality. In part why I push for bookmarks, it makes it clear on the o

<    1   2   3   4   5   >