sdkrystian wrote:
@ericniebler Once I merge #106585, I have a follow up patch ready that will fix
#101330.
https://github.com/llvm/llvm-project/pull/102267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
AaronBallman wrote:
> can you inspect these files that still reference clang-rename?
>
> ```
> lib/Tooling/Refactoring/Rename/RenamingAction.cpp:errs() <<
> "clang-rename: renamed at: " << SourceMgr.getFilename(FullLoc)
> lib/Tooling/Refactoring/Rename/USRFindingAction.cpp:"
AaronBallman wrote:
> Also these bazel build scripts
>
> ```
> llvm/utils/gn/secondary/clang-tools-extra/test/BUILD.gn:
> "//clang/tools/clang-rename",
> llvm/utils/gn/secondary/clang/test/BUILD.gn:"//clang/tools/clang-rename",
> llvm/utils/gn/secondary/clang/tools/clang-rename/BUILD.gn:
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
Ping @erichkeane
https://github.com/llvm/llvm-project/pull/106585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/108474
>From c32b36e249cb1062cc05618181bf4cb4fdcd2133 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Thu, 12 Sep 2024 17:13:57 -0700
Subject: [PATCH] [Clang] Propagate elide safe context through
[[clang::coro
https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/109003
>From d9bb31da5c897aad0dbc55781df2341db75aad6d Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Mon, 12 Aug 2024 08:46:12 -0500
Subject: [PATCH 1/2] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock f
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt
*CurDirective) {
// clause requires an accessible, unambiguous default constructor for the
// class type, unless the list item is also specified in a firstprivate
// clause.
- if (const auto *D = dyn_c
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt
*CurDirective) {
// clause requires an accessible, unambiguous default constructor for the
// class type, unless the list item is also specified in a firstprivate
// clause.
- if (const auto *D = dyn_c
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt
*CurDirective) {
// clause requires an accessible, unambiguous default constructor for the
// class type, unless the list item is also specified in a firstprivate
// clause.
- if (const auto *D = dyn_c
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt
*CurDirective) {
// clause requires an accessible, unambiguous default constructor for the
// class type, unless the list item is also specified in a firstprivate
// clause.
- if (const auto *D = dyn_c
@@ -3377,7 +3377,8 @@ static void encodeTypeForFunctionPointerAuth(const
ASTContext &Ctx,
#include "clang/Basic/HLSLIntangibleTypes.def"
case BuiltinType::Dependent:
llvm_unreachable("should never get here");
-case BuiltinType::AMDGPUBufferRsrc:
+#define AMDGPU_T
https://github.com/shiltian approved this pull request.
https://github.com/llvm/llvm-project/pull/109004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexey-bataev approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/109003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -585,8 +585,8 @@ static bool CheckConstraintSatisfaction(
ArrayRef TemplateArgs =
TemplateArgsLists.getNumSubstitutedLevels() > 0
- ? TemplateArgsLists.getOutermost()
- : ArrayRef {};
+ ? TemplateArgsLists.getInnermost()
e
@@ -309,35 +309,35 @@ bool TemplateDecl::isTypeAlias() const {
void RedeclarableTemplateDecl::anchor() {}
RedeclarableTemplateDecl::CommonBase *RedeclarableTemplateDecl::getCommonPtr()
const {
- if (Common)
-return Common;
+ if (CommonBase *C = Common.getPointer())
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/106585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11392,9 +11392,9 @@ class Sema final : public SemaBase {
CXXScopeSpec &SS, IdentifierInfo *Name, SourceLocation NameLoc,
const ParsedAttributesView &Attr, TemplateParameterList *TemplateParams,
AccessSpecifier AS, SourceLocation ModulePrivateLoc,
- So
https://github.com/erichkeane approved this pull request.
Thanks for the ping, I'd forgotten about this one! I'm happy for the most
part, I have 1 question and a couple nits.
https://github.com/llvm/llvm-project/pull/106585
___
cfe-commits mailing li
Author: Benjamin Kramer
Date: 2024-09-17T19:07:36+02:00
New Revision: c23d6df60d62f971d957e730f6fe55ea89541f6b
URL:
https://github.com/llvm/llvm-project/commit/c23d6df60d62f971d957e730f6fe55ea89541f6b
DIFF:
https://github.com/llvm/llvm-project/commit/c23d6df60d62f971d957e730f6fe55ea89541f6b.dif
Author: Greg Roth
Date: 2024-09-17T10:09:42-07:00
New Revision: a729e706de3fc6ebee49ede3c50afb47f2e29191
URL:
https://github.com/llvm/llvm-project/commit/a729e706de3fc6ebee49ede3c50afb47f2e29191
DIFF:
https://github.com/llvm/llvm-project/commit/a729e706de3fc6ebee49ede3c50afb47f2e29191.diff
LOG
https://github.com/pow2clk closed
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fursov updated
https://github.com/llvm/llvm-project/pull/108769
>From 4d9f2e2e9ac57b4279a4aafc078a3b4fb3ff646f Mon Sep 17 00:00:00 2001
From: Dmitry Fursov
Date: Sun, 15 Sep 2024 18:14:48 +0300
Subject: [PATCH] Fix evaluation of the unsigned enumeration values
If the type of
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while
building `clang` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/144/builds/7235
https://github.com/kirillbobyrev approved this pull request.
I agree, clang-rename should probably be removed. I haven't touched it in years
and its usability has dropped over the last few years after I re-implemented
the most useful functionality in clangd.
https://github.com/llvm/llvm-projec
@@ -1,16 +1,25 @@
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -ast-dump -o
- %s | FileCheck %s
// CHECK: CXXRecordDecl 0x{{[0-9a-f]+}} {{.*}} struct MyBuffer definition
-// CHECK: FieldDecl 0x{{[0-9a-f]+}} col:68 h
'__hlsl_resource_t {{\[\[}}hlsl::reso
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/108919
>From ef22d6e40b6c835a4a46633ba87f2053285c1b49 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Mon, 16 Sep 2024 15:13:54 -0700
Subject: [PATCH 1/2] [HLSL][NFC] Update resource attribute tests
- split resource
mizvekov wrote:
AFAIK the bazel build scripts are externally automatically updated based on the
cmake scripts, so I don't think we should be touching them.
https://github.com/llvm/llvm-project/pull/108988
___
cfe-commits mailing list
cfe-commits@lists
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin`
running on `doug-worker-4` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/190/builds/5917
Here is the
@@ -828,101 +831,85 @@ static void
updateResourceClassFlagsFromRecordType(RegisterBindingFlags &Flags,
const Type *FieldTy = FD->getType().getTypePtr();
if (const HLSLAttributedResourceType *AttrResType =
dyn_cast(FieldTy)) {
-updateResourceCl
https://github.com/pow2clk created
https://github.com/llvm/llvm-project/pull/109023
The Alwaysinline change made the mangled form of entry points get removed. The
StructuredBuffer-subscript.hlsl test was introduced in the meantime depending
on that version of the entry point. This revises it i
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Greg Roth (pow2clk)
Changes
The Alwaysinline change made the mangled form of entry points get removed. The
StructuredBuffer-subscript.hlsl test was introduced in the meantime depending
on that version of the entry point. This revises it i
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Greg Roth (pow2clk)
Changes
The Alwaysinline change made the mangled form of entry points get removed. The
StructuredBuffer-subscript.hlsl test was introduced in the meantime depending
on that version of the entry point. This revises it in
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/109023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/python3kgae approved this pull request.
https://github.com/llvm/llvm-project/pull/109023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Greg Roth
Date: 2024-09-17T10:45:18-07:00
New Revision: f4fe26ddfde0d5bb1c512e89a9cdd442a7518ee1
URL:
https://github.com/llvm/llvm-project/commit/f4fe26ddfde0d5bb1c512e89a9cdd442a7518ee1
DIFF:
https://github.com/llvm/llvm-project/commit/f4fe26ddfde0d5bb1c512e89a9cdd442a7518ee1.diff
LOG
https://github.com/pow2clk closed
https://github.com/llvm/llvm-project/pull/109023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 approved this pull request.
https://github.com/llvm/llvm-project/pull/108924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vabridgers updated
https://github.com/llvm/llvm-project/pull/108900
>From 33621d8862e6d1b98dc88aa0452faced0e3e5f17 Mon Sep 17 00:00:00 2001
From: einvbri
Date: Tue, 17 Sep 2024 01:25:20 +0200
Subject: [PATCH] [analyzer] Indicate UnarySymExpr is not supported by Z3
Random tes
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/108924
>From 1dd552dfb6217804ba5e84a35e59e348622df581 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Mon, 16 Sep 2024 20:54:23 -0700
Subject: [PATCH 1/4] [HLSL][NFC] Remove RegisterBindingFlags struct
When diagnosin
@@ -0,0 +1,16 @@
+// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -verify
%s \
+// RUN: -analyzer-constraints=z3
+
+// REQUIRES: Z3
+//
+// This LIT covers a crash associated with this test.
+// The expectation is to not crash!
vabridgers
@@ -0,0 +1,16 @@
+// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -verify
%s \
+// RUN: -analyzer-constraints=z3
+
+// REQUIRES: Z3
+//
+// This LIT covers a crash associated with this test.
+// The expectation is to not crash!
+//
+
+long a;
+void b() {
https://github.com/fsfod created
https://github.com/llvm/llvm-project/pull/109024
This is part of the effort to support for enabling plugins on windows by adding
better support for building llvm and clang as a DLL.
Since windows doesn't implicitly import and merge exported symbols across
shar
vabridgers wrote:
Hi @NagyDonat , yes this is only exposed when z3 is used as the constraint
manager. This crash does not occur when using z3-refutation.
https://github.com/llvm/llvm-project/pull/108900
___
cfe-commits mailing list
cfe-commits@lists.
llvmbot wrote:
@llvm/pr-subscribers-llvm-ir
Author: Thomas Fransham (fsfod)
Changes
This is part of the effort to support for enabling plugins on windows by adding
better support for building llvm and clang as a DLL.
Since windows doesn't implicitly import and merge exported symbols acro
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
Author: Thomas Fransham (fsfod)
Changes
This is part of the effort to support for enabling plugins on windows by adding
better support for building llvm and clang as a DLL.
Since windows doesn't implicitly import and merge exported symbols
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/108929
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/108797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18197,7 +18197,7 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned
BuiltinID,
CallOps.push_back(Ops[i]);
llvm::Function *F = CGM.getIntrinsic(ID);
Value *Call = Builder.CreateCall(F, CallOps);
-return Builder.CreateAlignedStore(Call, Ops[0], MaybeAli
Author: Zahira Ammarguellat
Date: 2024-09-17T13:56:20-04:00
New Revision: 39a4b3274de3283e5c5d12053678b7ecf947a2dc
URL:
https://github.com/llvm/llvm-project/commit/39a4b3274de3283e5c5d12053678b7ecf947a2dc
DIFF:
https://github.com/llvm/llvm-project/commit/39a4b3274de3283e5c5d12053678b7ecf947a2dc
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/107397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/108513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/108334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,220 @@
+//===- AMDGPUMCResourceInfo.cpp --- MC Resource Info
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`ppc64le-lld-multistage-test` running on `ppc64le-lld-multistage-test` while
building `clang` at step 7 "test-build-stage1-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/168/bu
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/109004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
As a CFE reviewer, I very much hate the existence of this script (and the
CodeGen equivalents, but that is a separate discussion).
This existing means I can no longer trust that a test is a reflection of what
the author intended to write, as they might have just run this and
https://github.com/rupprecht commented:
Bazel changes LGTM. Updating them is totally not necessary, but appreciated if
you do. Thanks!
https://github.com/llvm/llvm-project/pull/108988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
erichkeane wrote:
I mentioned on a separate commit here, but as a reviewer/code-owner, I very
much dislike the existence of tooling like this. I believe it to be actively
harmful to the project.
https://github.com/llvm/llvm-project/pull/108425
___
cf
rupprecht wrote:
> AFAIK the bazel build scripts are externally automatically updated based on
> the cmake scripts, so I don't think we should be touching them.
Bazel files are not updated automatically. Updating them in the same commit is
fine (but not required).
GN files are updated by the
@@ -585,8 +585,8 @@ static bool CheckConstraintSatisfaction(
ArrayRef TemplateArgs =
TemplateArgsLists.getNumSubstitutedLevels() > 0
- ? TemplateArgsLists.getOutermost()
- : ArrayRef {};
+ ? TemplateArgsLists.getInnermost()
s
@@ -3158,6 +3161,33 @@ checkBuiltinTemplateIdType(Sema &SemaRef,
BuiltinTemplateDecl *BTD,
int64_t N = Index.getExtValue();
return Ts.getPackAsArray()[N].getAsType();
}
+ case BTK__type_pack_dedup: {
+assert(Converted.size() == 2 && "__builtin_type_pack_dedup sh
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heide
=��___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=��___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=��___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=��___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heide
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heide
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heide
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heide
hnrklssn wrote:
> As a CFE reviewer, I very much hate the existence of this script (and the
> CodeGen equivalents, but that is a separate discussion).
>
> This existing means I can no longer trust that a test is a reflection of what
> the author intended to write, as they might have just run t
@@ -18197,7 +18197,7 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned
BuiltinID,
CallOps.push_back(Ops[i]);
llvm::Function *F = CGM.getIntrinsic(ID);
Value *Call = Builder.CreateCall(F, CallOps);
-return Builder.CreateAlignedStore(Call, Ops[0], MaybeAli
@@ -585,8 +585,8 @@ static bool CheckConstraintSatisfaction(
ArrayRef TemplateArgs =
TemplateArgsLists.getNumSubstitutedLevels() > 0
- ? TemplateArgsLists.getOutermost()
- : ArrayRef {};
+ ? TemplateArgsLists.getInnermost()
e
@@ -585,8 +585,8 @@ static bool CheckConstraintSatisfaction(
ArrayRef TemplateArgs =
TemplateArgsLists.getNumSubstitutedLevels() > 0
- ? TemplateArgsLists.getOutermost()
- : ArrayRef {};
+ ? TemplateArgsLists.getInnermost()
e
https://github.com/usx95 approved this pull request.
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/108344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -347,6 +361,30 @@ static bool shouldTrackFirstArgument(const FunctionDecl
*FD) {
return false;
}
+// Returns true if we should perform the GSL analysis on the first argument for
+// the given constructor.
+static bool
+shouldTrackFirstArgumentForConstructor(const CXXCons
Author: Mital Ashok
Date: 2024-09-17T21:35:49+02:00
New Revision: 09284e7eb20db88a9a5d60a591360ee35b256b7f
URL:
https://github.com/llvm/llvm-project/commit/09284e7eb20db88a9a5d60a591360ee35b256b7f
DIFF:
https://github.com/llvm/llvm-project/commit/09284e7eb20db88a9a5d60a591360ee35b256b7f.diff
L
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/108817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/107982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1837,6 +1837,10 @@ static void AddTypeSpecifierResults(const LangOptions
&LangOpts,
Builder.AddChunk(CodeCompletionString::CK_RightParen);
Results.AddResult(Result(Builder.TakeString()));
}
+
+if (LangOpts.CPlusPlus20) {
cor3ntin wrote:
https://github.com/cor3ntin commented:
This change needs a release note.
Please add an entry to `clang/docs/ReleaseNotes.rst` in the section the most
adapted to the change, and referencing any Github issue this change fixes.
Thanks!
https://github.com/llvm/llvm-project/pull/107982
https://github.com/vogelsgesang commented:
Looks good to me, but at the same time: I am not experienced in the
clang-frontend, so please wait for an approval of a more experienced
clang-frontend contributor
https://github.com/llvm/llvm-project/pull/108474
__
alex1701c wrote:
But that does not mean everyone who works on the projects will update to that
version right away :(
https://github.com/llvm/llvm-project/pull/99791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=
Message-ID:
In-Reply-To:
https://github.com/shafik approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108021
___
cfe-commits mailin
efriedma-quic wrote:
In the example in
https://github.com/llvm/llvm-project/pull/107581#issuecomment-2343651051 ,
there are four relevant calls to GetOrCreateLLVMFunction: one for each function
with IsInDefinition false, and one for each function with IsInDefinition true.
The last of those c
@@ -5125,24 +5127,54 @@ QualType ASTContext::getUnresolvedUsingType(
QualType ASTContext::getAttributedType(attr::Kind attrKind,
QualType modifiedType,
- QualType equivalentType) const {
+
https://github.com/cor3ntin approved this pull request.
I think this makes sense
I added a couple extra pair of eyes to the review so please wait a bit before
merging.
In the future, it would be better to push the unrelated parts of the pr in
separate NFC commits, for ease of review. Thanks!
https://github.com/erichkeane approved this pull request.
I was going to comment on the amount of NFC changes here, but as Corentin
already approved, I think we're OK for this for now. LGTM as well.
https://github.com/llvm/llvm-project/pull/108693
@@ -1105,16 +1120,16 @@ enum AttributeDeclKind {
inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
const ParsedAttr &At) {
- DB.AddTaggedVal(reinterpret_cast(At.getAttrName()),
+ const IdentifierInfo *Att
Author: Tarun Prabhu
Date: 2024-09-17T13:59:14-06:00
New Revision: 1c0958bd95076665e379783969bb81c730e88023
URL:
https://github.com/llvm/llvm-project/commit/1c0958bd95076665e379783969bb81c730e88023
DIFF:
https://github.com/llvm/llvm-project/commit/1c0958bd95076665e379783969bb81c730e88023.diff
https://github.com/tarunprabhu closed
https://github.com/llvm/llvm-project/pull/108868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -186,4 +218,370 @@ bool Sema::CheckCountedByAttrOnField(FieldDecl *FD, Expr
*E, bool CountInBytes,
return false;
}
+SourceRange Sema::BoundsSafetySourceRangeFor(const CountAttributedType *CATy) {
hnrklssn wrote:
[#108631](https://github.com/llvm/llvm-pr
https://github.com/python3kgae approved this pull request.
https://github.com/llvm/llvm-project/pull/106782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Krzysztof Parzyszek
Date: 2024-09-17T15:14:07-05:00
New Revision: 815b0046b8998e3b9e7a964608c725eec8e85d8a
URL:
https://github.com/llvm/llvm-project/commit/815b0046b8998e3b9e7a964608c725eec8e85d8a
DIFF:
https://github.com/llvm/llvm-project/commit/815b0046b8998e3b9e7a964608c725eec8e85d8a
https://github.com/kparzysz closed
https://github.com/llvm/llvm-project/pull/109003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
porglezomp wrote:
@sdkrystian sorry to bother, do you have that change to re-land it?
https://github.com/llvm/llvm-project/pull/104458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haoNoQ approved this pull request.
Yeah sounds about right!
The property syntax is confusing, I don't have enough expertise to confirm that
`getResultExpr()` is the right solution so I think we should keep trying and
incrementally figuring out what's going on.
Setters proba
haoNoQ wrote:
I'm also somewhat terrified of returning C++ objects from ObjC methods by
value, ever since I learned that when you call an ObjC method on a nil it
returns a _zero-initialized_ object without calling a constructor on it.
https://github.com/llvm/llvm-project/pull/108669
__
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux`
running on `premerge-linux-1` while building `clang` at step 7
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/153/builds/9181
Here is
201 - 300 of 466 matches
Mail list logo
