pskrgag wrote:
Thank you for review!
No, I don't have
https://github.com/llvm/llvm-project/pull/104599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
VyacheslavLevytskyy wrote:
> > @AlexVlx I don't see much objections against #108528 on a conceptual level,
> > so what do you think about merging it into this PR in a way that I
> > commented above, by changing `getMemScope()` and moving
> > `getOrInsertSyncScopeID()` into its static vars init
https://github.com/AaronBallman commented:
I think this is a reasonable direction to go, so the changes notionally LGTM.
And I didn't spot any issues with the conversion either, but I'd appreciate a
second set of eyes more familiar with x86 builtins to double-check.
https://github.com/llvm/llv
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus wrote:
You already have a good number of quality patches under your belt. I suggest
that you ask for a commit access, I have no doubt it'll be granted:
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
https://github.com/llvm/llvm-project/pull/104599
_
@@ -196,8 +208,10 @@ define amdgpu_kernel void @add_i32_constant(ptr
addrspace(1) %out, ptr addrspace
; GFX11W32-NEXT:v_mbcnt_lo_u32_b32 v0, s1, 0
; GFX11W32-NEXT:; implicit-def: $vgpr1
; GFX11W32-NEXT:s_delay_alu instid0(VALU_DEP_1)
-; GFX11W32-NEXT:v_cmpx_eq_
nhaehnle wrote:
I agree with Jay that this change isn't acceptable from a codegen quality point
of view.
> Then it appeared that instructions loading the values spilled to the memory
> and used in the current block must be placed at the block beginning before
> they are used but after the poi
a-tarasyuk wrote:
@AaronBallman Thanks for the review.
If these changes seem fine, could someone merge them? I don't have the required
permissions. thanks
https://github.com/llvm/llvm-project/pull/108701
___
cfe-commits mailing list
cfe-commits@lists
Author: Matheus Izvekov
Date: 2024-09-16T09:56:16-03:00
New Revision: 63b6c384468784d247401098c6200deb9ab70ba0
URL:
https://github.com/llvm/llvm-project/commit/63b6c384468784d247401098c6200deb9ab70ba0
DIFF:
https://github.com/llvm/llvm-project/commit/63b6c384468784d247401098c6200deb9ab70ba0.dif
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/108491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> CC @AaronBallman for an opinion about the AST represenation
This is a bit awkward in that it's only used for the `annotate` attributes'
argument lists, which should pass all of their arguments down to LLVM IR.
However, we don't typically generate LLVM IR for discarded val
Author: Oleksandr T.
Date: 2024-09-16T08:58:50-04:00
New Revision: ed4a2a108ec867188c65f4c3743008db8dd1c0bb
URL:
https://github.com/llvm/llvm-project/commit/ed4a2a108ec867188c65f4c3743008db8dd1c0bb
DIFF:
https://github.com/llvm/llvm-project/commit/ed4a2a108ec867188c65f4c3743008db8dd1c0bb.diff
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/108701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/107786
>From 8774b4b073b5ebb52bdf35a7c44c613c6fcf56fc Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Fri, 13 Sep 2024 17:55:15 +0300
Subject: [PATCH] [Clang] prevent recovery call expression from proceeding with
a-tarasyuk wrote:
@AaronBallman could you please review these changes? thanks
https://github.com/llvm/llvm-project/pull/107786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein edited
https://github.com/llvm/llvm-project/pull/108280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,31 @@
+// REQUIRES: aarch64-registered-target
+
+// RUN: %clang_cc1 -triple aarch64 -emit-llvm -o - %s -verify -DTEST1
+// RUN: %clang_cc1 -triple aarch64 -target-feature +sme -target-feature +sme2
-emit-llvm -o - %s -verify -DTEST2
sdesmalen-arm wrote
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/108280
>From 05bdd3878f6c958db52902d641bb0bb37b026616 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Wed, 11 Sep 2024 21:45:40 +0200
Subject: [PATCH] [clang] Don't emit bogus dangling diagnostics when
``[[gsl::Owner]]
hokein wrote:
> Can you add some more details to the summary e.g. "The fix adds an additional
> check in isGSLOwner() for Owner attribute" or something along those lines.
Done.
https://github.com/llvm/llvm-project/pull/108280
___
cfe-commits mailing
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/108570
>From e1b5e886f3f7642ec691a08378a1f2cdc9e2465f Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 11 Sep 2024 14:56:58 -0400
Subject: [PATCH 1/3] Initial commit.
---
clang/test/CodeGen/attr-function-return
erichkeane wrote:
@yashssh : We can take this offline (see slack), but Feature Test Macros are
intended to change. The values listed in the standard are the 'minimum' value
for a compiler that implemented every feature in the standard.
The expectation is that an implementation will use a nu
https://github.com/hokein closed
https://github.com/llvm/llvm-project/pull/108280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Haojian Wu
Date: 2024-09-16T15:21:33+02:00
New Revision: abe964aa47a293523613df1ab5bd1c16cf50e0e7
URL:
https://github.com/llvm/llvm-project/commit/abe964aa47a293523613df1ab5bd1c16cf50e0e7
DIFF:
https://github.com/llvm/llvm-project/commit/abe964aa47a293523613df1ab5bd1c16cf50e0e7.diff
LO
https://github.com/hokein edited
https://github.com/llvm/llvm-project/pull/108280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
So the problem is that we would have another implicitly-created explicit
template specialization `foo` in the process of the
DeduceTemplateArguments, and that specialization would share the same
`FunctionTemplateSpecializationInfo` with the eventual template specialization
that
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/108786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/108786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dfukalov wrote:
Gentle ping...
https://github.com/llvm/llvm-project/pull/106810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shiltian wrote:
I updated the PR description. Hopefully it can make the motivation of this
patch more clear. I think the central question is, why it can't be just address
space 0. I don't have a clear answer to that. @arsenm first introduced this
concept to LLVM at least 8 years ago. I agree t
Author: Rahul Joshi
Date: 2024-09-16T06:34:56-07:00
New Revision: a06d84abd3f90a71f077ed45a54fa5439740267d
URL:
https://github.com/llvm/llvm-project/commit/a06d84abd3f90a71f077ed45a54fa5439740267d
DIFF:
https://github.com/llvm/llvm-project/commit/a06d84abd3f90a71f077ed45a54fa5439740267d.diff
L
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Rahul Joshi
Date: 2024-09-16T06:35:34-07:00
New Revision: 0e948bfd31df6a1d4f62934c9ef453a38da6ca2b
URL:
https://github.com/llvm/llvm-project/commit/0e948bfd31df6a1d4f62934c9ef453a38da6ca2b
DIFF:
https://github.com/llvm/llvm-project/commit/0e948bfd31df6a1d4f62934c9ef453a38da6ca2b.diff
L
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
> > CC @AaronBallman for an opinion about the AST represenation
>
> This is a bit awkward in that it's only used for the `annotate` attributes'
> argument lists, which should pass all of their arguments down to LLVM IR.
> However, we don't typically generate LLVM IR for disca
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while
building `clang` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/144/builds/7115
Here is the rel
Author: Kazu Hirata
Date: 2024-09-16T06:43:26-07:00
New Revision: 91591794514fa6f17d87285acb41e3dba1eee5e5
URL:
https://github.com/llvm/llvm-project/commit/91591794514fa6f17d87285acb41e3dba1eee5e5
DIFF:
https://github.com/llvm/llvm-project/commit/91591794514fa6f17d87285acb41e3dba1eee5e5.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/108794
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jplehr wrote:
Hi, we see the same errors on our buildbots, two as examples:
https://lab.llvm.org/buildbot/#/builders/30/builds/6250
https://lab.llvm.org/buildbot/#/builders/140/builds/6648
https://github.com/llvm/llvm-project/pull/108627
___
cfe-commi
erichkeane wrote:
It seems reasonable to me, but I want @cor3ntin to review this, he's the one
who got his foot stuck in array bounds for a while :D
However, this patch needs a few changes:
1- A better patch title, perhaps improved commit message
2- Release note
https://github.com/llvm/llvm
igelbox wrote:
> LGTM! Do you need someone to land these changes on your behalf?
I suppose so.. or what are my options? The Merge button isn't active of course.
I believe someone from maintainers would merge this PR and I will be so proud)
https://github.com/llvm/llvm-project/pull/108187
__
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/108826
Fixes build failure by avoiding conflicting with `Record` class name.
>From 4c9eb0b0edb3487097f44d1afc58397f03a370b7 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Mon, 16 Sep 2024 06:50:09 -0700
Subject: [PA
jurahul wrote:
I have a proposed fix here: https://github.com/llvm/llvm-project/pull/108826
https://github.com/llvm/llvm-project/pull/108627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Fixes build failure by avoiding conflicting with `Record` class name.
---
Full diff: https://github.com/llvm/llvm-project/pull/108826.diff
1 Files Affected:
- (modified) clang/utils/TableGen/ClangSyntaxEmit
https://github.com/erichkeane commented:
So I think this patch is doing too much, I'd like to see the changes to
`AttributedType` split into a separate patch so we can talk about the
`swift_attr` alone.
As far as moving this attribute to be a Type Attribute, that comes with a ton
of concerns
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/108631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6037,13 +6038,24 @@ class AttributedType : public Type, public
llvm::FoldingSetNode {
private:
friend class ASTContext; // ASTContext creates these
+ const Attr *Attribute;
+
QualType ModifiedType;
QualType EquivalentType;
AttributedType(QualType canon, attr
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Rahul Joshi
Date: 2024-09-16T06:59:36-07:00
New Revision: adb70045144ac2cab085a2a377b33388aed23114
URL:
https://github.com/llvm/llvm-project/commit/adb70045144ac2cab085a2a377b33388aed23114
DIFF:
https://github.com/llvm/llvm-project/commit/adb70045144ac2cab085a2a377b33388aed23114.diff
L
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/108826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Fix has been merged: https://github.com/llvm/llvm-project/pull/108826
https://github.com/llvm/llvm-project/pull/108627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Congcong Cai
Date: 2024-09-16T22:02:38+08:00
New Revision: b3470c3d7ab078b201bd65afc3b902d1ed41bc21
URL:
https://github.com/llvm/llvm-project/commit/b3470c3d7ab078b201bd65afc3b902d1ed41bc21
DIFF:
https://github.com/llvm/llvm-project/commit/b3470c3d7ab078b201bd65afc3b902d1ed41bc21.diff
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/108759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5055,6 +5058,17 @@ void Parser::ParseLexedCAttribute(LateParsedAttribute
&LA, bool EnterScope,
ParseGNUAttributeArgs(&LA.AttrName, LA.AttrNameLoc, Attrs, nullptr, nullptr,
SourceLocation(), ParsedAttr::Form::GNU(), nullptr);
+ const auto &SM = P
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/107619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
I apparently forgot to commit some comments here!
https://github.com/llvm/llvm-project/pull/107619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
@@ -1105,16 +1120,16 @@ enum AttributeDeclKind {
inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
const ParsedAttr &At) {
- DB.AddTaggedVal(reinterpret_cast(At.getAttrName()),
+ const IdentifierInfo *Att
@@ -493,9 +500,11 @@ class ParsedAttr final
/// Set the macro identifier info object that this parsed attribute was
/// declared in if it was declared in a macro. Also set the expansion
location
/// of the macro.
- void setMacroIdentifier(IdentifierInfo *MacroName, Sour
jurahul wrote:
This was not flagged by pre-commit CI. I am wondering if the CI can be tweaked
to flag this pre commit.
https://github.com/llvm/llvm-project/pull/108627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/ksromanov updated
https://github.com/llvm/llvm-project/pull/104540
>From 31ed1cf97be643b3a6c9a05d4e461789c37e2408 Mon Sep 17 00:00:00 2001
From: Konstantin Romanov
Date: Fri, 9 Aug 2024 23:40:07 -0400
Subject: [PATCH 1/6] Workaround for cppcoreguidelines-pro-type-union-access
ksromanov wrote:
@PiotrZSL would you please review once again?
https://github.com/llvm/llvm-project/pull/104540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sheredom updated
https://github.com/llvm/llvm-project/pull/106577
>From 588d45ef291997bc6df487ce9562768d92bff14d Mon Sep 17 00:00:00 2001
From: Neil Henning
Date: Thu, 29 Aug 2024 13:15:49 +0100
Subject: [PATCH] Make PCH's respect any VFS specified.
We want to be able to gen
@@ -0,0 +1,26 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t/From
+// RUN: mkdir -p %t/To
+// RUN: echo '#pragma once' > %t/From/B.h
sheredom wrote:
Done!
https://github.com/llvm/llvm-project/pull/106577
___
cfe-commits ma
@@ -1115,13 +1115,13 @@ void ASTWriter::WriteBlockInfoBlock() {
}
/// Prepares a path for being written to an AST file by converting it
-/// to an absolute path and removing nested './'s.
+/// to an absolute path and removing nested './'s and '../'s.
///
/// \return \c true
https://github.com/sheredom updated
https://github.com/llvm/llvm-project/pull/106577
>From bbf433a5f56db6375e132b27bd4f7cd58feafe7b Mon Sep 17 00:00:00 2001
From: Neil Henning
Date: Thu, 29 Aug 2024 13:15:49 +0100
Subject: [PATCH] Make PCH's respect any VFS specified.
We want to be able to gen
@@ -245,6 +246,7 @@ class DataLayout {
unsigned getDefaultGlobalsAddressSpace() const {
return DefaultGlobalsAddrSpace;
}
+ unsigned getFlatAddressSpace() const { return FlatAddressSpace; }
AlexVlx wrote:
I think that for general ergonomics making thi
@@ -3050,6 +3050,19 @@ as follows:
address space 0, this property only affects the default value to be used
when creating globals without additional contextual information (e.g. in
LLVM passes).
+``T``
+Specifies the address space for a target's 'flat' address s
Author: Vakhurin Sergei
Date: 2024-09-16T10:30:53-04:00
New Revision: e5d255607d200f59c5f7474b8dde6fe72d53e348
URL:
https://github.com/llvm/llvm-project/commit/e5d255607d200f59c5f7474b8dde6fe72d53e348
DIFF:
https://github.com/llvm/llvm-project/commit/e5d255607d200f59c5f7474b8dde6fe72d53e348.dif
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/108187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@igelbox Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
AaronBallman wrote:
> > LGTM! Do you need someone to land these changes on your behalf?
>
> I suppose so.. or what are my options? The Merge button isn't active of
> course. I believe someone from maintainers would merge this PR and I will be
> so proud)
I've merged on your behalf (I sometime
AlexVlx wrote:
> I updated the PR description. Hopefully it can make the motivation of this
> patch more clear. I think the central question is, why it can't be just
> address space 0. I don't have a clear answer to that. @arsenm first
> introduced this concept to LLVM at least 8 years ago. I
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `ppc64le-flang-rhel-clang`
running on `ppc64le-flang-rhel-test` while building `clang-tools-extra,clang`
at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/157/builds/7831
https://github.com/zwuis created
https://github.com/llvm/llvm-project/pull/108837
According to [[expr.cond]/5](https://eel.is/c++draft/expr.cond#5) and
[[expr.cond]/7.1](https://eel.is/c++draft/expr.cond#7.1), no conversion should
be performed to compute result type if middle operand and right
erichkeane wrote:
@igelbox: That seems to be a problem with this patch! If it is something you
cannot fix/get a review up for very quickly so we can accept/get it in, we'll
have to revert this. Please let us know ASAP what you'd like to do.
https://github.com/llvm/llvm-project/pull/108187
__
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yanzuo Liu (zwuis)
Changes
According to [[expr.cond]/5](https://eel.is/c++draft/expr.cond#5) and
[[expr.cond]/7.1](https://eel.is/c++draft/expr.cond#7.1), no conversion
should be performed to compute result type if middle operand and righ
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-sles-build-only` running on `rocm-worker-hw-04-sles` while
building `clang-tools-extra,clang` at step 5 "compile-openmp".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/140/builds/6654
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/108837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `flang-aarch64-libcxx`
running on `linaro-flang-aarch64-libcxx` while building
`clang-tools-extra,clang` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/89/builds/6426
tarunprabhu wrote:
> Why do we need the two new files?
>
> We have clang/lib/Driver/ToolChains/CommonArgs.cpp and
> clang/lib/Driver/ToolChain.cpp for shared code.
Since most of the code in `CommonArgs.cpp` had to do with functions in the
`clang::driver::tools` namespace, I wasn't sure that c
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ed4a2a108ec867188c65f4c3743008db8dd1c0bb
7e5f88c322852939ae68c65f6adf4a5d2973d095 --e
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/108838
Reverts llvm/llvm-project#108187
>From dee00441ed4f5d2b872dca9cd0c925e2e5e04107 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Mon, 16 Sep 2024 10:48:26 -0400
Subject: [PATCH] Revert "Fix OOM in Format
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin`
running on `doug-worker-5` while building `clang-tools-extra,clang` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/190/builds/5825
Here is
AaronBallman wrote:
Reverting due to build failures found in
https://github.com/llvm/llvm-project/pull/108187
https://github.com/llvm/llvm-project/pull/108838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
@llvm/pr-subscribers-clang-modules
Author: Aaron Ballman (AaronBallman)
Changes
Reverts llvm/llvm-project#108187
---
Patch is 44.93 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/108838.diff
16
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/108838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Aaron Ballman
Date: 2024-09-16T10:49:17-04:00
New Revision: 5cead0cb0bdeebd47e648114541b2998ed83df6f
URL:
https://github.com/llvm/llvm-project/commit/5cead0cb0bdeebd47e648114541b2998ed83df6f
DIFF:
https://github.com/llvm/llvm-project/commit/5cead0cb0bdeebd47e648114541b2998ed83df6f.diff
AaronBallman wrote:
I've reverted; @igelbox, you can create a new PR that addresses the failures
found by post-commit CI and I'll review them.
https://github.com/llvm/llvm-project/pull/108187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
@@ -245,6 +246,7 @@ class DataLayout {
unsigned getDefaultGlobalsAddressSpace() const {
return DefaultGlobalsAddrSpace;
}
+ unsigned getFlatAddressSpace() const { return FlatAddressSpace; }
shiltian wrote:
@arsenm made a point in
https://github.com/l
Author: Joseph Huber
Date: 2024-09-16T09:57:47-05:00
New Revision: 0f723eb67197421caf6504a7e4594751040b1924
URL:
https://github.com/llvm/llvm-project/commit/0f723eb67197421caf6504a7e4594751040b1924
DIFF:
https://github.com/llvm/llvm-project/commit/0f723eb67197421caf6504a7e4594751040b1924.diff
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clangd-ubuntu-tsan`
running on `clangd-ubuntu-clang` while building `clang-tools-extra,clang` at
step 6 "test-build-clangd-clangd-index-server-clangd-indexer-check-clangd".
Full details are available at:
https://lab.llvm.org/
@@ -780,6 +780,22 @@ class ASTContext : public RefCountedBase {
const TargetInfo &getTargetInfo() const { return *Target; }
const TargetInfo *getAuxTargetInfo() const { return AuxTarget; }
+ const QualType GetHigherPrecisionFPType(QualType ElementType) const {
---
@@ -7964,6 +7964,12 @@ class Sema final : public SemaBase {
/// Do an explicit extend of the given block pointer if we're in ARC.
void maybeExtendBlockObject(ExprResult &E);
+ std::vector>
+ ExcessPrecisionNotSatisfied;
+ unsigned NumExcessPrecisionNotSatisfied = 0;
jakeegan wrote:
Hi, `--strip-trailing-cr` isn't a supported option with diff on AIX. Would you
be able to adapt the tests?
https://lab.llvm.org/buildbot/#/builders/64/builds/985
https://github.com/llvm/llvm-project/pull/108658
___
cfe-commits mailing
https://github.com/zwuis updated
https://github.com/llvm/llvm-project/pull/108837
>From 7e5f88c322852939ae68c65f6adf4a5d2973d095 Mon Sep 17 00:00:00 2001
From: Yanzuo Liu
Date: Mon, 16 Sep 2024 21:50:11 +0800
Subject: [PATCH 1/2] Fix computing result type of conditional operand
---
clang/docs
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick`
running on `linaro-clang-aarch64-quick` while building
`clang-tools-extra,clang` at step 5 "ninja check 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/65/builds/4601
Here is
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast`
running on `gribozavr4` while building `clang-tools-extra,clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/56/builds/7472
AaronBallman wrote:
> Gentle ping @AaronBallman , @philnik777 , @fpetrogalli :)
Ah, sorry -- because the PR is marked as a Draft, I figured it wasn't ready for
review yet.
I think I'd rather this was expressed differently; we already don't put
attribute information in the prototype anyway (`n
https://github.com/python3kgae approved this pull request.
Why the name is contained_type instead of element_type?
https://github.com/llvm/llvm-project/pull/108456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
101 - 200 of 478 matches
Mail list logo