[clang] [HLSL] Add HLSL 202y language mode (PR #108437)

2024-09-13 Thread Chris B via cfe-commits
https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/108437 >From 34cc492bad3f1b2b4cae7eb4dc5cbd4b219a8944 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Tue, 10 Sep 2024 10:24:08 -0500 Subject: [PATCH 1/2] [HLSL] Add HLSL 202y language mode This change adds a n

[clang] [NFC][Clang][TableGen] Refactor ClangASTNodesEmitter (PR #108580)

2024-09-13 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/108580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][TableGen] Refactor ClangASTNodesEmitter (PR #108580)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Change macroName() to accept a StringRef to avoid extra string copy. Simplify ASTNode comparison function. Use equal_range() instead of calling lower_bound() and upper_bound() separately for std::multimap. No

[clang] [HLSL] Fix move assignment of `this` (PR #108445)

2024-09-13 Thread Chris B via cfe-commits
https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/108445 >From a5be65fa3b763659dda7fd9ab2fda9ca9dae4391 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Thu, 12 Sep 2024 12:06:02 -0500 Subject: [PATCH 1/2] [HLSL] Fix move assignment of `this` Under HLSL 202x+ m

[clang] [llvm] [ValueTracking] Add dominating condition support in computeKnownBits() (PR #73662)

2024-09-13 Thread Alexander Kornienko via cfe-commits
alexfh wrote: Apologies for resurrecting this old thread, but I found a problem with this patch. It seems like it makes a comparator violate strict weak ordering requirements. This manifests as an assertion failure when Clang is compiled with the corresponding libc++ check: ``` clang -O1 -c -o

[clang] [HLSL] Add `[[hlsl::raw_buffer]]` attribute (PR #107954)

2024-09-13 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/107954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-09-13 Thread Sebastian Kreutzer via cfe-commits
https://github.com/sebastiankreutzer updated https://github.com/llvm/llvm-project/pull/90959 >From 86e252cb84803bfaa2ec096b671ef366fd3ac5cb Mon Sep 17 00:00:00 2001 From: Sebastian Kreutzer Date: Thu, 26 Oct 2023 15:13:05 +0200 Subject: [PATCH 1/2] [XRay] Add DSO support for XRay instrumentatio

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-09-13 Thread Sebastian Kreutzer via cfe-commits
@@ -2922,6 +2922,11 @@ def fxray_selected_function_group : HelpText<"When using -fxray-function-groups, select which group of functions to instrument. Valid range is 0 to fxray-function-groups - 1">, MarshallingInfoInt, "0">; +defm xray_enable_shared : BoolFOption<"xray-e

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-09-13 Thread Sebastian Kreutzer via cfe-commits
@@ -27,6 +27,7 @@ class XRayArgs { XRayInstrSet InstrumentationBundle; llvm::opt::Arg *XRayInstrument = nullptr; bool XRayRT = true; + bool XRayEnableShared = false; sebastiankreutzer wrote: Done https://github.com/llvm/llvm-project/pull/90959

[clang] [llvm] [ValueTracking] Add dominating condition support in computeKnownBits() (PR #73662)

2024-09-13 Thread Alexander Kornienko via cfe-commits
alexfh wrote: Filed #108618 https://github.com/llvm/llvm-project/pull/73662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][TableGen] Refactor ClangASTNodesEmitter (PR #108580)

2024-09-13 Thread Aaron Ballman via cfe-commits
@@ -93,34 +87,31 @@ class ClangASTNodesEmitter { // Called recursively to ensure that nodes remain contiguous std::pair ClangASTNodesEmitter::EmitNode(raw_ostream &OS, ASTNode Base) { - std::string BaseName = macroName

[clang] [llvm] Prefer std::getenv to ::getenv (PR #108529)

2024-09-13 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Okay, thanks for clarifying. Shall I close this one? I don't see a lot of value in the change, but because it's an NFC and the changes only impact code always compiled as C++ anyway, it's not entirely unreasonable. Personally, I'd close, but it's up to you (if you move ah

[clang] [NFC][Clang][TableGen] Refactor ClangASTNodesEmitter (PR #108580)

2024-09-13 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/108580 >From 4976e21df6cbbc7b97277a00b85c97a70ecef96c Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Fri, 13 Sep 2024 07:55:02 -0700 Subject: [PATCH] [NFC][Clang][TableGen] Refactor ClangASTNodesEmitter Change macro

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

2024-09-13 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @AaronBallman could you please review this PR when you have a chance? thanks https://github.com/llvm/llvm-project/pull/107786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-13 Thread via cfe-commits
@@ -1472,3 +1472,49 @@ template struct Outer { }; }; Outer::Inner outerinner; + +void aggregate() { + struct S { +[[clang::requires_explicit_initialization]] int x; +int y; +int z = 12; +[[clang::requires_explicit_initialization]] int q = 100; +static voi

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-13 Thread via cfe-commits
joaosaffran wrote: > ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️ > > You can test this locally with the following command: > View the diff from clang-format here. This is formatting issue is caused because, clang's LLVM style assumes C++14, where the space isn't require

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-13 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/102040 >From 7ea9d3dbb6ff74ca3f7f9b9a0c589e4a0a3366f2 Mon Sep 17 00:00:00 2001 From: higher-performance Date: Mon, 5 Aug 2024 15:04:19 -0400 Subject: [PATCH] Add Clang attribute to ensure that fields are ini

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-13 Thread via cfe-commits
@@ -743,6 +743,12 @@ void InitListChecker::FillInEmptyInitForField(unsigned Init, FieldDecl *Field, ILE->updateInit(SemaRef.Context, Init, Filler); return; } + +if (Field->hasAttr()) { + SemaRef.Diag(ILE->getExprLoc(), diag::warn_field_requires_expli

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-13 Thread via cfe-commits
@@ -743,6 +743,12 @@ void InitListChecker::FillInEmptyInitForField(unsigned Init, FieldDecl *Field, ILE->updateInit(SemaRef.Context, Init, Filler); return; } + +if (Field->hasAttr()) { + SemaRef.Diag(ILE->getExprLoc(), diag::warn_field_requires_expli

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-13 Thread via cfe-commits
@@ -2148,6 +2158,19 @@ void CXXRecordDecl::completeDefinition(CXXFinalOverriderMap *FinalOverriders) { for (conversion_iterator I = conversion_begin(), E = conversion_end(); I != E; ++I) I.setAccess((*I)->getAccess()); + + ASTContext &Context = getASTContext(); +

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-13 Thread via cfe-commits
@@ -119,6 +119,14 @@ FIELD(HasInitMethod, 1, NO_MERGE) /// within anonymous unions or structs. FIELD(HasInClassInitializer, 1, NO_MERGE) +/// Custom attribute that is True if any field is marked as explicit in a type higher-performance wrote: Done. https://g

[clang] [CGData] Clang Options (PR #90304)

2024-09-13 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: The options handling part LGTM, but I'll let others review the actual semantics of this PR. https://github.com/llvm/llvm-project/pull/90304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-13 Thread Matt Arsenault via cfe-commits
@@ -686,6 +686,20 @@ static Value *EmitSignBit(CodeGenFunction &CGF, Value *V) { return CGF.Builder.CreateICmpSLT(V, Zero); } +static bool hasPointerArgsOrPointerReturnType(const Value *V) { + if (const CallBase *CB = dyn_cast(V)) { +for (const Value *A : CB->args()) {

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-13 Thread Matt Arsenault via cfe-commits
@@ -699,9 +713,12 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, bool ConstWithoutErrnoAndExceptions = Context.BuiltinInfo.isConstWithoutErrnoAndExceptions(BuiltinID); // Restrict to target with errno, for example, MacOS doesn't

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-13 Thread Matt Arsenault via cfe-commits
@@ -686,6 +686,20 @@ static Value *EmitSignBit(CodeGenFunction &CGF, Value *V) { return CGF.Builder.CreateICmpSLT(V, Zero); } +static bool hasPointerArgsOrPointerReturnType(const Value *V) { + if (const CallBase *CB = dyn_cast(V)) { +for (const Value *A : CB->args()) {

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-13 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,31 @@ +// RUN: %clang_cc1 %s -O3 -fmath-errno -emit-llvm -triple x86_64-unknown-unknown -o - %s | FileCheck %s -check-prefixes=CHECK +// RUN: %clang_cc1 %s -O3 -fmath-errno -emit-llvm -triple x86_64-pc-win64 -o - %s | FileCheck %s -check-prefixes=CHECK +// RUN: %clan

[clang] [NFC][clang][TableGen] Remove redundant llvm:: namespace qualifier (PR #108627)

2024-09-13 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/108627 Remove llvm:: from .cpp files, and add "using namespace llvm" if needed. >From 73a8e42a15441b38a1d88e2fd4de0dd420a33398 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Fri, 13 Sep 2024 11:55:45 -0700 Subject:

[clang] [Utils] add update-verify-tests.py (PR #97369)

2024-09-13 Thread Rahul Joshi via cfe-commits
jurahul wrote: Looks like these tests are failing in CI: see https://buildkite.com/llvm-project/github-pull-requests/builds/100644#0191ec9f-441f-4299-ad47-a9318fbae7a8 https://github.com/llvm/llvm-project/pull/97369 ___ cfe-commits mailing list cfe-c

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-13 Thread via cfe-commits
https://github.com/yonghong-song updated https://github.com/llvm/llvm-project/pull/107343 >From a29ba5bd76ba0bb2149fe8ab20da0bd78c2b04dd Mon Sep 17 00:00:00 2001 From: Yonghong Song Date: Tue, 3 Sep 2024 21:26:17 -0700 Subject: [PATCH 1/3] [BPF] Do atomic_fetch_*() pattern matching with memory

[clang-tools-extra] issue-63565: community requested small QoL fix for more configurabili… (PR #108005)

2024-09-13 Thread via cfe-commits
MK-Alias wrote: Thanks for the feedback. Will update the patch soon! (I've got lots of stuff to do, but it's high on my todo-list!) Just to be clear, do you want to keep the new `--function-arg-placeholders` flags and also add it to the `.clangd` config!? Or do you only want the `.clangd` con

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-13 Thread via cfe-commits
https://github.com/yonghong-song edited https://github.com/llvm/llvm-project/pull/107343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-13 Thread via cfe-commits
yonghong-song wrote: This pull request has been used for the merged kernel patch: https://lore.kernel.org/r/20240909223431.1666305-1-yonghong.s...@linux.dev https://github.com/llvm/llvm-project/pull/107343 ___ cfe-commits mailing list cfe-commits@li

[clang] [Utils] add update-verify-tests.py (PR #97369)

2024-09-13 Thread Nico Weber via cfe-commits
nico wrote: This breaks tests on windows: http://45.33.8.238/win/94083/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/97369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-13 Thread via cfe-commits
@@ -864,26 +864,119 @@ class XFALU32; -def XFANDW32 : XFALU32; -def XFORW32 : XFALU32; -def XFXORW32 : XFALU32; +def XFADDW32 : XFALU32; +def XFANDW32 : XFALU32; +def XFORW32 : XFALU32; +def XFXORW32 : XFALU32; } let Predicates = [BPFHasALU32]

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-13 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/107292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-13 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,25 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify bogner wrote: The `-emit-llvm-only` and `-disable-llvm-passes` flags don't really do anything

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-13 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. looks good, thanks! https://github.com/llvm/llvm-project/pull/107292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Utils] add update-verify-tests.py (PR #97369)

2024-09-13 Thread Rahul Joshi via cfe-commits
jurahul wrote: Also note that this was also detected by CI prior to merging the PR. https://github.com/llvm/llvm-project/pull/97369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-13 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/107292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Utils] add update-verify-tests.py" (PR #108630)

2024-09-13 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/108630 Reverts llvm/llvm-project#97369 >From 4e53d121f3f83f7ffe23a9dc835a0ffd68a5a1c9 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Fri, 13 Sep 2024 12:13:02 -0700 Subject: [PATCH] Revert "[Utils] add update-veri

[clang] Revert "[Utils] add update-verify-tests.py" (PR #108630)

2024-09-13 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/108630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b7e585b - Revert "[Utils] add update-verify-tests.py" (#108630)

2024-09-13 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-13T12:17:17-07:00 New Revision: b7e585b95e241d0506b6f71d53ff5b6e72a9c8f4 URL: https://github.com/llvm/llvm-project/commit/b7e585b95e241d0506b6f71d53ff5b6e72a9c8f4 DIFF: https://github.com/llvm/llvm-project/commit/b7e585b95e241d0506b6f71d53ff5b6e72a9c8f4.diff L

[clang] Revert "[Utils] add update-verify-tests.py" (PR #108630)

2024-09-13 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Utils] add update-verify-tests.py (PR #97369)

2024-09-13 Thread Rahul Joshi via cfe-commits
jurahul wrote: Reverted in https://github.com/llvm/llvm-project/pull/108630 https://github.com/llvm/llvm-project/pull/97369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Utils] add update-verify-tests.py" (PR #108630)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Reverts llvm/llvm-project#97369 --- Patch is 33.70 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/108630.diff 36 Files Affected: - (removed) clang/test/utils/

[clang] [clang/AST] Make it possible to use SwiftAttr in type context (PR #108631)

2024-09-13 Thread Pavel Yaskevich via cfe-commits
https://github.com/xedin created https://github.com/llvm/llvm-project/pull/108631 Swift ClangImporter now supports concurrency annotations on imported declarations and their parameters/results, to make it possible to use imported APIs in Swift safely there has to be a way to annotate individua

[clang] [clang/AST] Make it possible to use SwiftAttr in type context (PR #108631)

2024-09-13 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [CGData] Clang Options (PR #90304)

2024-09-13 Thread Kyungwoo Lee via cfe-commits
kyulee-com wrote: @NuriAmari Do you see or expect any issues with using distributed ThinLTO? https://github.com/llvm/llvm-project/pull/90304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang/AST] Make it possible to use SwiftAttr in type context (PR #108631)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: Pavel Yaskevich (xedin) Changes Swift ClangImporter now supports concurrency annotations on imported declarations and their parameters/results, to make it possible to use imported APIs in Swift safely th

[clang] [NFC][Clang][TableGen] Refactor ClangASTNodesEmitter (PR #108580)

2024-09-13 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/108580 >From 8d249f31cb3f07ad630092945e870b3527aca0bf Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Fri, 13 Sep 2024 07:55:02 -0700 Subject: [PATCH] [NFC][Clang][TableGen] Refactor ClangASTNodesEmitter Change macro

[clang] [NFC][clang][TableGen] Remove redundant llvm:: namespace qualifier (PR #108627)

2024-09-13 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/108627 >From 18064b1c154672e2f7e6387fdb70efde85b9bb81 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Fri, 13 Sep 2024 11:55:45 -0700 Subject: [PATCH] [NFC][clang][TableGen] Remove redundant llvm:: namespace qualifie

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-13 Thread via cfe-commits
@@ -864,26 +864,119 @@ class XFALU32; -def XFANDW32 : XFALU32; -def XFORW32 : XFALU32; -def XFXORW32 : XFALU32; +def XFADDW32 : XFALU32; +def XFANDW32 : XFALU32; +def XFORW32 : XFALU32; +def XFXORW32 : XFALU32; } let Predicates = [BPFHasALU32]

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-13 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/106588 >From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Wed, 24 Jul 2024 16:49:19 -0600 Subject: [PATCH 01/12] [HLSL] set alwaysinline on HLSL functions HLSL inlines all it

[clang] [llvm] Thin3 (PR #108614)

2024-09-13 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/108614 >From dd7de1a900dceb411931d9d5a49b164096c314a2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/2] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang] [llvm] Thin3 (PR #108614)

2024-09-13 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/108614 >From dd7de1a900dceb411931d9d5a49b164096c314a2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/2] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang] [CGData] Clang Options (PR #90304)

2024-09-13 Thread Nuri Amari via cfe-commits
NuriAmari wrote: > Do you see or expect any issues with using distributed ThinLTO? No seems good to me! https://github.com/llvm/llvm-project/pull/90304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang-tools-extra] issue-63565: community requested small QoL fix for more configurabili… (PR #108005)

2024-09-13 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > Just to be clear, do you want to keep the new `--function-arg-placeholders` > flags and also add it to the `.clangd` config!? Or do you only want the > `.clangd` config and drop the changes to the `--function-arg-placeholders` > flag!? The latter. The only change relat

[clang] Reland: [clang] Diagnose dangling issues for the "Container" case. #107213 (PR #108344)

2024-09-13 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/108344 >From e4b4b55fc169ce6a31aefadc523d26440bdf46d7 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Thu, 12 Sep 2024 09:27:03 +0200 Subject: [PATCH 1/4] Reapply "[clang] Diagnose dangling issues for the "Container" c

[clang] Reland: [clang] Diagnose dangling issues for the "Container" case. #107213 (PR #108344)

2024-09-13 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7574e1ddc4be63628cb7617857cc8938058a79d2 ca0b4ba6b691fdd7e55ed50d3240397a00126498 --e

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-09-13 Thread Ben Langmuir via cfe-commits
@@ -1115,13 +1115,13 @@ void ASTWriter::WriteBlockInfoBlock() { } /// Prepares a path for being written to an AST file by converting it -/// to an absolute path and removing nested './'s. +/// to an absolute path and removing nested './'s and '../'s. /// /// \return \c true

[clang] [Utils] add update-verify-tests.py (PR #97369)

2024-09-13 Thread Henrik G. Olsson via cfe-commits
hnrklssn wrote: Very sorry about the CI oversight on my part! Thanks for reverting, I was in a meeting. Looks like I was bitten by Windows line endings again... https://github.com/llvm/llvm-project/pull/97369 ___ cfe-commits mailing list cfe-commits@l

[clang] a26ec54 - [clang-scan-deps] Infer the tool locations from PATH (#108539)

2024-09-13 Thread via cfe-commits
Author: Martin Storsjö Date: 2024-09-13T23:18:10+03:00 New Revision: a26ec542371652e1d774696e90016fd5b0b1c191 URL: https://github.com/llvm/llvm-project/commit/a26ec542371652e1d774696e90016fd5b0b1c191 DIFF: https://github.com/llvm/llvm-project/commit/a26ec542371652e1d774696e90016fd5b0b1c191.diff

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/108539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-13 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/107292 >From c6434c06d17a2442863f8843e75dc870966fb97c Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Tue, 3 Sep 2024 19:06:22 + Subject: [PATCH 1/6] Adding `asuint` implementation to hlsl --- clang/includ

[clang] Reland: [clang] Diagnose dangling issues for the "Container" case. #107213 (PR #108344)

2024-09-13 Thread Haojian Wu via cfe-commits
@@ -347,6 +361,30 @@ static bool shouldTrackFirstArgument(const FunctionDecl *FD) { return false; } +// Returns true if we should perform the GSL analysis on the first argument for +// the given constructor. +static bool +shouldTrackFirstArgumentForConstructor(const CXXCons

[clang] Reland: [clang] Diagnose dangling issues for the "Container" case. #107213 (PR #108344)

2024-09-13 Thread Haojian Wu via cfe-commits
@@ -633,4 +633,12 @@ std::optional test4(int a) { return std::make_optional(nullptr); // fine } +template +struct [[gsl::Owner]] StatusOr { + const T &value() [[clang::lifetimebound]]; +}; hokein wrote: Thanks a lot for these tests. I've added them with s

[clang] [Clang] Propagate elide safe context through [[clang::coro_must_await]] (PR #108474)

2024-09-13 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/108474 >From b2cd6f3e0bd1b3aefa84c7d733d1119303551d42 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Thu, 12 Sep 2024 17:13:57 -0700 Subject: [PATCH] [Clang] Propagate elide safe context through [[clang::coro

[clang] [Clang] Propagate elide safe context through [[clang::coro_must_await]] (PR #108474)

2024-09-13 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/108474 >From 73e3d278eca1c9b47cb9c6aa436a82d495d03f83 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Thu, 12 Sep 2024 17:13:57 -0700 Subject: [PATCH] [Clang] Propagate elide safe context through [[clang::coro

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-09-13 Thread via cfe-commits
@@ -0,0 +1,276 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] Reland: [clang] Diagnose dangling issues for the "Container" case. #107213 (PR #108344)

2024-09-13 Thread Haojian Wu via cfe-commits
hokein wrote: > We seem to be good at detecting new false positives but this is natural due > to the visible compiler diagnositc. Unfortunately, same is not true for new > false-negatives. More tests in our test-suite is the only way to detect those > and we should be extensively adding more t

[clang] ebf25d9 - [-Wunsafe-buffer-usage] Reduce false positives with constant arrays in libc warnings (#108308)

2024-09-13 Thread via cfe-commits
Author: Ziqing Luo Date: 2024-09-13T13:47:07-07:00 New Revision: ebf25d9509d19a381d94a0383135ee37f5b7b6e2 URL: https://github.com/llvm/llvm-project/commit/ebf25d9509d19a381d94a0383135ee37f5b7b6e2 DIFF: https://github.com/llvm/llvm-project/commit/ebf25d9509d19a381d94a0383135ee37f5b7b6e2.diff LO

[clang] [-Wunsafe-buffer-usage] Reduce false positives with constant arrays in libc warnings (PR #108308)

2024-09-13 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 closed https://github.com/llvm/llvm-project/pull/108308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,38 @@ +//===-- SwapBinaryOperandsTests.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,210 @@ +//===--- SwapBinaryOperands.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,210 @@ +//===--- SwapBinaryOperands.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: Could you add a release note for this as well? https://github.com/llvm/llvm-project/pull/78999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,210 @@ +//===--- SwapBinaryOperands.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/78999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,210 @@ +//===--- SwapBinaryOperands.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,210 @@ +//===--- SwapBinaryOperands.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/78999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/78999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-09-13 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/78999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] Reapply "[clang] Extend diagnose_if to accept more detailed warning information (#70976)" (PR #108453)

2024-09-13 Thread Florian Mayer via cfe-commits
fmayer wrote: This caused a UBSan violation: ``` [--] 1 test from ConfigCompileTests [ RUN ] ConfigCompileTests.DiagnosticSuppression Config fragment: compiling :0 -> 0x7B8366E2F7D8 (trusted=false) /usr/local/google/home/fmayer/large/llvm-project/llvm/include/llvm/ADT/IntrusiveR

[clang] [Clang] Propagate elide safe context through [[clang::coro_must_await]] (PR #108474)

2024-09-13 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/108474 >From dc6239934105cad1f90b7b6185e6bfa8f30d5544 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Thu, 12 Sep 2024 17:13:57 -0700 Subject: [PATCH] [Clang] Propagate elide safe context through [[clang::coro

[clang] [Clang] Propagate elide safe context through [[clang::coro_must_await]] (PR #108474)

2024-09-13 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 ready_for_review https://github.com/llvm/llvm-project/pull/108474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Propagate elide safe context through [[clang::coro_must_await]] (PR #108474)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines @llvm/pr-subscribers-clang Author: Yuxuan Chen (yuxuanchen1997) Changes Based on discussion in https://discourse.llvm.org/t/language-extension-for-better-more-deterministic-halo-for-c-coroutines/80044/9, we are proposing a new attribute `[[c

[clang] Revert "[clang] Silence GCC warnings about control reaching end of non void function" (PR #108646)

2024-09-13 Thread Florian Mayer via cfe-commits
https://github.com/fmayer created https://github.com/llvm/llvm-project/pull/108646 This reverts commit 90a2e0bb423629b7e70f4b91adb44851199dd5ea. Reverting parent CL >From 6bc1ea84e078d01546286e6443d761e2a685902d Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Fri, 13 Sep 2024 14:02:14 -07

[clang] Revert "[clang] Silence GCC warnings about control reaching end of non void function" (PR #108646)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Florian Mayer (fmayer) Changes This reverts commit 90a2e0bb423629b7e70f4b91adb44851199dd5ea. Reverting parent CL --- Full diff: https://github.com/llvm/llvm-project/pull/108646.diff 2 Files Affected: - (modified) clang/include/clang/B

[clang] [llvm] Thin3 (PR #108614)

2024-09-13 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/108614 >From 95709740e820c0efddb1fdb53436a03194a1b88e Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/2] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang] [llvm] Thin3 (PR #108614)

2024-09-13 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 14b43563d1618c71385f3ac15a475adf9d0ef5f9 40c846ddf089d1a084eafc0e698f5c8d33954ca8 --e

[clang] [llvm] Thin3 (PR #108614)

2024-09-13 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/108614 >From 95709740e820c0efddb1fdb53436a03194a1b88e Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/2] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-09-13 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,463 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-09-13 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,463 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-09-13 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,463 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] f885e02 - Revert "[clang] Silence GCC warnings about control reaching end of non void function"

2024-09-13 Thread Florian Mayer via cfe-commits
Author: Florian Mayer Date: 2024-09-13T15:01:27-07:00 New Revision: f885e02cf7cac1b08cab4cd526773420076029dd URL: https://github.com/llvm/llvm-project/commit/f885e02cf7cac1b08cab4cd526773420076029dd DIFF: https://github.com/llvm/llvm-project/commit/f885e02cf7cac1b08cab4cd526773420076029dd.diff

[clang] e1bd974 - Revert "Reapply "[clang] Extend diagnose_if to accept more detailed warning information (#70976)" (#108453)"

2024-09-13 Thread Florian Mayer via cfe-commits
Author: Florian Mayer Date: 2024-09-13T15:01:33-07:00 New Revision: e1bd9740faa62c11cc785a7b70ec1ad17e286bd1 URL: https://github.com/llvm/llvm-project/commit/e1bd9740faa62c11cc785a7b70ec1ad17e286bd1 DIFF: https://github.com/llvm/llvm-project/commit/e1bd9740faa62c11cc785a7b70ec1ad17e286bd1.diff

[clang-tools-extra] e1bd974 - Revert "Reapply "[clang] Extend diagnose_if to accept more detailed warning information (#70976)" (#108453)"

2024-09-13 Thread Florian Mayer via cfe-commits
Author: Florian Mayer Date: 2024-09-13T15:01:33-07:00 New Revision: e1bd9740faa62c11cc785a7b70ec1ad17e286bd1 URL: https://github.com/llvm/llvm-project/commit/e1bd9740faa62c11cc785a7b70ec1ad17e286bd1 DIFF: https://github.com/llvm/llvm-project/commit/e1bd9740faa62c11cc785a7b70ec1ad17e286bd1.diff

[clang-tools-extra] [llvm] [WIP] add a mustache backend (PR #108653)

2024-09-13 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 62ae01201fc7185aca61d040c4f2df5303bae0ad 8d141ba80297ce024b0144f2522f7d662bf36568 --e

[clang] Revert "[clang] Silence GCC warnings about control reaching end of non void function" (PR #108646)

2024-09-13 Thread Florian Mayer via cfe-commits
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/108646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >